The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Scalar viz ensure field to select has a section (#69179)
Nick Fitzpatrick7200371783f4
diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsxindex 92ee8d8ca2e..8abc1f7639b 100644--- a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx@@ -70,6 +70,9 @@ export class Scalar extends Component<static settings = {...fieldSetting("scalar.field", {+ get section() {+ return t`Formatting`;+ },get title() {return t`Field to show`;},diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsxindex eff8c1da31d..0c9e53e8db7 100644--- a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx@@ -1,8 +1,17 @@+import userEvent from "@testing-library/user-event";import type { ComponentProps } from "react";-import { render, screen } from "__support__/ui";+import { render, renderWithProviders, screen, within } from "__support__/ui";+import { registerVisualization } from "metabase/visualizations";+import { QuestionChartSettings } from "metabase/visualizations/components/ChartSettings";import type { Series } from "metabase-types/api";-import { createMockCard, createMockColumn } from "metabase-types/api/mocks";+import {+ createMockCard,+ createMockColumn,+ createMockDataset,+ createMockDatasetData,+ createMockSingleSeries,+} from "metabase-types/api/mocks";import { Scalar } from "./Scalar";@@ -84,3 +93,79 @@ describe("Scalar", () => {expect(styles.textOverflow).not.toBe("ellipsis");});});++describe("scalar viz settings", () => {+ beforeAll(() => {+ // @ts-expect-error: incompatible prop types with registerVisualization+ registerVisualization(Scalar);+ });++ it("should render the field to show input in the formatting section if there are 2 or more columns", async () => {+ const series = [+ createMockSingleSeries(+ createMockCard({ display: "scalar" }),+ createMockDataset({+ data: createMockDatasetData({+ cols: [+ createMockColumn({+ display_name: "FOO",+ source: "native",+ name: "FOO",+ }),+ createMockColumn({+ display_name: "BAR",+ source: "native",+ name: "BAR",+ }),+ ],+ }),+ }),+ ),+ ];+ renderWithProviders(<QuestionChartSettings series={series} />);++ expect(+ await screen.findByRole("radio", { name: "Formatting" }),+ ).toBeChecked();+ expect(await screen.findByText("Field to show")).toBeInTheDocument();++ const getFieldSelect = async () =>+ await within(+ await screen.findByTestId("chart-settings-widget-scalar.field"),+ ).findByRole("textbox");++ expect(await getFieldSelect()).toHaveDisplayValue("FOO");+ await userEvent.click(await getFieldSelect());++ expect(await screen.findByRole("listbox")).toHaveTextContent("FOO");+ expect(await screen.findByRole("listbox")).toHaveTextContent("BAR");+ });++ it("should not render the field to show input in the formatting section if there is only 1 columns", async () => {+ const series = [+ createMockSingleSeries(+ createMockCard({ display: "scalar" }),+ createMockDataset({+ data: createMockDatasetData({+ cols: [+ createMockColumn({+ display_name: "BAR",+ source: "native",+ name: "BAR",+ }),+ ],+ }),+ }),+ ),+ ];+ renderWithProviders(<QuestionChartSettings series={series} />);++ expect(+ await screen.findByRole("radio", { name: "Formatting" }),+ ).toBeChecked();++ expect(+ screen.queryByTestId("chart-settings-widget-scalar.field"),+ ).not.toBeInTheDocument();+ });+});