Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[MongoDB] remove `:metadata/key-constraints` driver feature flag (#77659)

Cam Saul74af0a368d8c
diff --git a/modules/drivers/mongo/src/metabase/driver/mongo.clj b/modules/drivers/mongo/src/metabase/driver/mongo.clj
index 95c52f3195a..99ecf158cfd 100644
--- a/modules/drivers/mongo/src/metabase/driver/mongo.clj
+++ b/modules/drivers/mongo/src/metabase/driver/mongo.clj
@@ -513,13 +513,9 @@
[_driver _feature _db]
true)
-;; We say Mongo supports foreign keys so that the front end can use implicit
-;; joins. In reality, Mongo doesn't support foreign keys.
-;; Only define an implementation for `:metadata/key-constraints` if none exists already.
-;; In test extensions we define an alternate implementation, and we don't want
-;; to stomp over that if it was loaded already.
-(when-not (get (methods driver/database-supports?) [:mongo :metadata/key-constraints])
- (defmethod driver/database-supports? [:mongo :metadata/key-constraints] [_driver _feature _db] true))
+(defmethod driver/database-supports? [:mongo :metadata/key-constraints]
+ [_driver _feature _db]
+ false)
(defmethod driver/mbql->native :mongo
[_ query]
diff --git a/modules/drivers/mongo/test/metabase/test/data/mongo.clj b/modules/drivers/mongo/test/metabase/test/data/mongo.clj
index 4f1d1095135..08ae545ec16 100644
--- a/modules/drivers/mongo/test/metabase/test/data/mongo.clj
+++ b/modules/drivers/mongo/test/metabase/test/data/mongo.clj
@@ -4,7 +4,6 @@
[clojure.test :refer :all]
[flatland.ordered.map :as ordered-map]
[medley.core :as m]
- [metabase.config.core :as config]
[metabase.driver :as driver]
[metabase.driver.ddl.interface :as ddl.i]
[metabase.driver.mongo.connection :as mongo.connection]
@@ -25,9 +24,6 @@
[_driver _feature _database]
false))
-;; During tests don't treat Mongo as having FK support
-(defmethod driver/database-supports? [:mongo :metadata/key-constraints] [_driver _feature _db] (not config/is-test?))
-
(defn ssl-required?
"Returns if the mongo server requires an SSL connection."
[]