The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Update module-boundaries config (#79733)
Fraser74b08a51c800
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjsindex 413f194dc61..3b7c29ce340 100644--- a/frontend/lint/module-boundaries.mjs+++ b/frontend/lint/module-boundaries.mjs@@ -189,9 +189,8 @@ const elements = [enforceSharedTiers: false,}),createElement({ type: "feature", name: "models" }),- createElement({ type: "shared", name: "monitor" }),+ createElement({ type: "feature", name: "monitor" }),createElement({ type: "shared", name: "nav", enforceSharedTiers: false }),- createElement({ type: "shared", name: "new" }),createElement({ type: "shared", name: "notifications" }),createElement({ type: "shared", name: "palette" }),createElement({ type: "shared", name: "parameters" }),@@ -216,6 +215,7 @@ const elements = [createElement({ type: "shared", name: "selectors" }),createElement({ type: "shared", name: "settings", enforcePublicApi: true }),createElement({ type: "feature", name: "setup" }),+ createElement({ type: "shared", name: "static-viz" }),createElement({ type: "shared", name: "status" }),createElement({type: "shared",@@ -341,12 +341,12 @@ const elements = ["frontend/src/metabase/routes-public.tsx","frontend/src/metabase/AppThemeProvider.tsx","frontend/src/metabase/AppColorSchemeProvider.tsx",- // NewModals is used very high in the hierarchy and imports the EAJS wizard that uses EAJS (app level)- "frontend/src/metabase/new/components/NewModals/NewModals.tsx",- // Its spec mounts NewModals to assert menu clicks open modals, so the test is app-tier too.+ // NewItemMenu's spec mounts app-tier NewModals to assert menu clicks open modals,+ // so the test is app-tier too."frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx",// Entry point for the static-viz bundle (server-side chart rendering in// GraalJS) - like app.js, it composes OSS + EE code for a build artifact.+ // Full-mode entries match before folder patterns, whatever the order."frontend/src/metabase/static-viz/index.tsx",// Storybook config is a composition root: preview wires app-tier decorators.// Needs its own pattern because ** doesn't match dot-folders.@@ -364,11 +364,8 @@ const elements = [name: "nav",pattern: "frontend/src/metabase/app/nav/**",}),- // static-viz must come after the app entries rather than in the- // alphabetical shared list: its entry point (static-viz/index.tsx) is app- // tier, and the first matching element wins.- createElement({ type: "shared", name: "static-viz" }),-+ // NewModals is composition glue rendered at the app root, wiring in the app-tier embed wizard.+ createElement({ type: "app", name: "new" }),// Loose files living directly under frontend/src/metabase that have not yet// been pulled into a module folder....["frontend/src/metabase/dev.ts", "frontend/src/metabase/dev-noop.ts"].map(diff --git a/frontend/lint/shared-tiers.mjs b/frontend/lint/shared-tiers.mjsindex 81e8d183837..a030e8a781c 100644--- a/frontend/lint/shared-tiers.mjs+++ b/frontend/lint/shared-tiers.mjs@@ -19,13 +19,11 @@ const SHARED_UTILS_LEVELS = [],// U1 — the api client.["shared/api"],- // U2 — routing facade.- ["shared/router"],- // U3 — the store slices and hooks.+ // U2 — the store slices and hooks.["shared/redux"],- // U4 — the plugin registry, and instance settings over the api and store.+ // U3 — the plugin registry, and instance settings over the api and store.["shared/plugins", "shared/settings"],- // U5 — app services over the store and registry.+ // U4 — app services over the store and registry.["shared/selectors","shared/content-translation",@@ -34,23 +32,25 @@ const SHARED_UTILS_LEVELS = ["shared/archive","shared/hooks",],- // U6 — composition over the levels below.+ // U5 — composition over the levels below.// The store factory composes reducers, plugin middlewares, and the router.- ["shared/hoc", "shared/upsells", "shared/route-guards", "shared/redux-store"],+ [+ "shared/hoc",+ "shared/upsells",+ "shared/route-guards",+ "shared/redux-store",+ "shared/search-ui",+ ],];const SHARED_PLATFORM_LEVELS = [// P0 — independent peers: chart rendering and database metadata/forms.["shared/visualizations", "shared/databases"],- // P1 — query editing composes visualizations.- ["shared/querying"],+ // P1 — query editing and subscription editing compose visualizations;+ // querying and pulse have no edges between them.+ ["shared/querying", "shared/pulse"],// P2 — building blocks over querying; mutually independent.- [- "shared/metadata",- "shared/parameters",- "shared/questions",- "shared/search-ui",- ],+ ["shared/metadata", "shared/parameters", "shared/questions"],];const SHARED_DOMAIN = [@@ -64,9 +64,7 @@ const SHARED_DOMAIN = ["shared/nav","shared/notifications","shared/palette",- "shared/pulse","shared/rich_text_editing",- "shared/routes-stable-id-aware","shared/static-viz","shared/status","shared/timelines",@@ -91,7 +89,7 @@ const levelAllows = (levels, base = []) =>const sharedRules = [// Later rules win, so these must come after the baseline shared/* allow they narrow.- // Edges to untiered modules (common, monitor, embedding, types) fall through to that allow.+ // Edges to untiered modules (common, embedding, types) fall through to that allow.{from: SHARED_UTILS,disallow: TIERED_SHARED,@@ -137,10 +135,6 @@ const sharedRules = [from: ["shared/nav", "shared/palette"],allow: ["shared/nav", "shared/palette"],},- {- from: ["shared/notifications", "shared/pulse"],- allow: ["shared/notifications", "shared/pulse"],- },];export { sharedRules };