Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix: drag handler selecting text in query editor (#68970)

Maksym Yakubych77cb53561419
diff --git a/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.tsx b/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.tsx
index 5d04ba70b66..53916cd1efc 100644
--- a/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.tsx
+++ b/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.tsx
@@ -68,6 +68,11 @@ export function ResizableArea(props: {
setHeight(initialHeight);
}
+ const handleDragHandleMouseDown = useCallback((event: Event) => {
+ event.preventDefault();
+ event.stopPropagation();
+ }, []);
+
const dragHandle = (
<div className={S.dragHandleContainer} data-testid="drag-handle">
<div className={S.dragHandle} />
@@ -90,6 +95,7 @@ export function ResizableArea(props: {
axis="y"
handle={dragHandle}
resizeHandles={resizable ? ["s"] : []}
+ draggableOpts={{ onMouseDown: handleDragHandleMouseDown }}
onResize={handleResize}
onResizeStop={handleResize}
>
diff --git a/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.unit.spec.tsx b/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.unit.spec.tsx
new file mode 100644
index 00000000000..5be114993c8
--- /dev/null
+++ b/frontend/src/metabase/query_builder/components/NativeQueryEditor/ResizableArea/ResizableArea.unit.spec.tsx
@@ -0,0 +1,29 @@
+import { render, screen } from "@testing-library/react";
+
+import { ThemeProvider } from "metabase/ui";
+
+import { ResizableArea } from "./ResizableArea";
+
+const renderWithProvider = (component: React.ReactElement) => {
+ return render(<ThemeProvider>{component}</ThemeProvider>);
+};
+
+describe("ResizableArea", () => {
+ it("should prevent default mousedown behavior on drag handle", () => {
+ renderWithProvider(
+ <ResizableArea resizable initialHeight={200} maxHeight={500}>
+ <div>Query editor</div>
+ </ResizableArea>,
+ );
+
+ const dragHandle = screen.getByTestId("drag-handle");
+ const event = new MouseEvent("mousedown", {
+ bubbles: true,
+ cancelable: true,
+ });
+
+ dragHandle.dispatchEvent(event);
+
+ expect(event.defaultPrevented).toBe(true);
+ });
+});