Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move security-center endpoints into enterprise security_center (#79351)

Fraser781e650301ad
diff --git a/enterprise/frontend/src/metabase-enterprise/api/tags.ts b/enterprise/frontend/src/metabase-enterprise/api/tags.ts
index d1024d47b6e..a8afdcd4763 100644
--- a/enterprise/frontend/src/metabase-enterprise/api/tags.ts
+++ b/enterprise/frontend/src/metabase-enterprise/api/tags.ts
@@ -50,6 +50,7 @@ export const ENTERPRISE_TAG_TYPES = [
"ai-controls-usage-group-limits",
"ai-controls-usage-tenant-limits",
"data-complexity-scores",
+ "security-advisory",
] as const;
export type EnterpriseTagType = TagType | (typeof ENTERPRISE_TAG_TYPES)[number];
diff --git a/frontend/src/metabase/api/security-center.ts b/enterprise/frontend/src/metabase-enterprise/security_center/api.ts
similarity index 91%
rename from frontend/src/metabase/api/security-center.ts
rename to enterprise/frontend/src/metabase-enterprise/security_center/api.ts
index 0bc52b36070..a45b2841f94 100644
--- a/frontend/src/metabase/api/security-center.ts
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/api.ts
@@ -1,3 +1,5 @@
+import { EnterpriseApi } from "metabase-enterprise/api/api";
+import { listTag } from "metabase-enterprise/api/tags";
import type {
AcknowledgeAdvisoriesResponse,
AcknowledgeAdvisoryResponse,
@@ -6,10 +8,7 @@ import type {
SendTestNotificationRequest,
} from "metabase-types/api";
-import { Api } from "./api";
-import { listTag } from "./tags";
-
-export const securityCenterApi = Api.injectEndpoints({
+export const securityCenterApi = EnterpriseApi.injectEndpoints({
endpoints: (builder) => ({
listSecurityAdvisories: builder.query<ListAdvisoriesResponse, void>({
query: () => ({
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/api.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/security_center/api.unit.spec.ts
new file mode 100644
index 00000000000..9b55b67749a
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/api.unit.spec.ts
@@ -0,0 +1,100 @@
+import { act } from "@testing-library/react";
+import fetchMock from "fetch-mock";
+
+import { renderHookWithProviders, waitFor } from "__support__/ui";
+import { createAdvisory } from "metabase-types/api/mocks/security-center";
+
+import {
+ useAcknowledgeAdvisoriesMutation,
+ useAcknowledgeAdvisoryMutation,
+ useListSecurityAdvisoriesQuery,
+ useSyncSecurityAdvisoriesMutation,
+} from "./api";
+
+const LIST_URL = "path:/api/ee/security-center";
+const advisory = createAdvisory({ advisory_id: "SA-001" });
+
+function mockRefreshedAdvisories() {
+ fetchMock.modifyRoute("advisories", {
+ response: { advisories: [], last_checked_at: "2026-09-10T00:00:00Z" },
+ });
+}
+
+describe("security-center cache invalidation", () => {
+ beforeEach(() => {
+ fetchMock.get(
+ LIST_URL,
+ { advisories: [advisory], last_checked_at: null },
+ { name: "advisories" },
+ );
+ });
+
+ it("should refresh the subscribed list after acknowledging an advisory", async () => {
+ fetchMock.post("path:/api/ee/security-center/SA-001/acknowledge", advisory);
+ const { result } = renderHookWithProviders(() => {
+ const query = useListSecurityAdvisoriesQuery();
+ const [acknowledge] = useAcknowledgeAdvisoryMutation();
+ return { query, acknowledge };
+ }, {});
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([advisory]);
+ });
+ mockRefreshedAdvisories();
+
+ await act(async () => {
+ await result.current.acknowledge("SA-001").unwrap();
+ });
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([]);
+ });
+ expect(fetchMock.callHistory.calls(LIST_URL)).toHaveLength(2);
+ });
+
+ it("should refresh the subscribed list after acknowledging advisories in bulk", async () => {
+ fetchMock.post("path:/api/ee/security-center/acknowledge", [advisory]);
+ const { result } = renderHookWithProviders(() => {
+ const query = useListSecurityAdvisoriesQuery();
+ const [acknowledgeAll] = useAcknowledgeAdvisoriesMutation();
+ return { query, acknowledgeAll };
+ }, {});
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([advisory]);
+ });
+ mockRefreshedAdvisories();
+
+ await act(async () => {
+ await result.current.acknowledgeAll(["SA-001"]).unwrap();
+ });
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([]);
+ });
+ expect(fetchMock.callHistory.calls(LIST_URL)).toHaveLength(2);
+ });
+
+ it("should refresh the subscribed list after syncing advisories", async () => {
+ fetchMock.post("path:/api/ee/security-center/sync", 200);
+ const { result } = renderHookWithProviders(() => {
+ const query = useListSecurityAdvisoriesQuery();
+ const [sync] = useSyncSecurityAdvisoriesMutation();
+ return { query, sync };
+ }, {});
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([advisory]);
+ });
+ mockRefreshedAdvisories();
+
+ await act(async () => {
+ await result.current.sync().unwrap();
+ });
+
+ await waitFor(() => {
+ expect(result.current.query.data?.advisories).toEqual([]);
+ });
+ expect(fetchMock.callHistory.calls(LIST_URL)).toHaveLength(2);
+ });
+});
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx
index 4c9781604d3..8e1ad930eef 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx
@@ -1,12 +1,12 @@
import { useCallback, useState } from "react";
import { t } from "ttag";
-import { useSendTestNotificationMutation } from "metabase/api/security-center";
import { useToast } from "metabase/common/hooks";
import { useIsSmallScreen } from "metabase/common/hooks/use-is-small-screen";
import { useSetting } from "metabase/settings";
import { Button, Flex, Group, Icon, Modal, Stack } from "metabase/ui";
+import { useSendTestNotificationMutation } from "../../api";
import {
serializeNotificationConfig,
useNotificationConfig,
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx
index ca17602d8c6..492419fb6d2 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx
@@ -1,14 +1,12 @@
import { jt, t } from "ttag";
-import {
- useGetChannelInfoQuery,
- useListSecurityAdvisoriesQuery,
-} from "metabase/api";
+import { useGetChannelInfoQuery } from "metabase/api";
import { Banner } from "metabase/common/components/Banner";
import { Link } from "metabase/common/components/Link";
import { getPlan, useSetting } from "metabase/settings";
import { Anchor, Text } from "metabase/ui";
+import { useListSecurityAdvisoriesQuery } from "../../api";
import { isAffected } from "../../utils";
export function SecurityCenterBanner() {
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx
index 53d3243b755..d178c8276ca 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx
@@ -1,9 +1,9 @@
import { t } from "ttag";
-import { useListSecurityAdvisoriesQuery } from "metabase/api";
import { AdminNavLink } from "metabase/nav/components/AdminNavbar/AdminNavLink";
import { Box, Flex } from "metabase/ui";
+import { useListSecurityAdvisoriesQuery } from "../../api";
import { isAffected } from "../../utils";
const PATH = "/admin/security-center";
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx
index a4a8d2b66dd..b71f75dc46f 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx
@@ -1,12 +1,12 @@
import { t } from "ttag";
-import { useListSecurityAdvisoriesQuery } from "metabase/api";
import {
AdminNavLink,
AdminNavListItem,
} from "metabase/nav/components/AdminNavbar/AdminNavLink";
import { Box, Flex } from "metabase/ui";
+import { useListSecurityAdvisoriesQuery } from "../../api";
import { isAffected } from "../../utils";
const PATH = "/admin/security-center";
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx
index 8cd071b70e7..8ba5dc5eae9 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx
@@ -2,7 +2,6 @@ import { useCallback, useEffect, useRef, useState } from "react";
import { t } from "ttag";
import { AdminSettingsLayout } from "metabase/admin/components/AdminLayout/AdminSettingsLayout";
-import { useSyncSecurityAdvisoriesMutation } from "metabase/api";
import { EmptyState } from "metabase/common/components/EmptyState";
import { useToast } from "metabase/common/hooks";
import { useIsSmallScreen } from "metabase/common/hooks/use-is-small-screen";
@@ -20,6 +19,7 @@ import {
} from "metabase/ui";
import { trackSecurityCenterPageViewed } from "../../analytics";
+import { useSyncSecurityAdvisoriesMutation } from "../../api";
import {
NotificationConfigProvider,
useNotificationConfigState,
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.tsx
index 5935922a228..4af132056ca 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.tsx
@@ -2,16 +2,14 @@ import { skipToken } from "@reduxjs/toolkit/query/react";
import { useCallback, useState } from "react";
import { t } from "ttag";
-import {
- useGetChannelInfoQuery,
- useListSecurityAdvisoriesQuery,
-} from "metabase/api";
+import { useGetChannelInfoQuery } from "metabase/api";
import { getUserIsAdmin } from "metabase/current-user";
import { NavbarPromoCard } from "metabase/nav/components/NavbarPromoCard";
import { useSelector } from "metabase/redux";
import { getPlan, useSetting } from "metabase/settings";
import { Icon } from "metabase/ui";
+import { useListSecurityAdvisoriesQuery } from "../../api";
import { isAffected } from "../../utils";
const DISMISSED_KEY = "security-center-promo-dismissed";
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.unit.spec.tsx
index 2876027c70c..7865db00f2a 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPromoCard/SecurityCenterPromoCard.unit.spec.tsx
@@ -1,3 +1,4 @@
+import { act } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import fetchMock from "fetch-mock";
@@ -5,7 +6,6 @@ import { setupNotificationChannelsEndpoints } from "__support__/server-mocks";
import { mockSettings } from "__support__/settings";
import { createMockState } from "__support__/state";
import { renderWithProviders, screen, waitFor } from "__support__/ui";
-import { securityCenterApi, subscriptionApi } from "metabase/api";
import { Route } from "metabase/router";
import type { Advisory } from "metabase-types/api";
import {
@@ -56,7 +56,7 @@ function setup({
}),
});
- return renderWithProviders(
+ renderWithProviders(
<Route path="*" element={<SecurityCenterPromoCard />} />,
{
initialRoute: "/",
@@ -64,38 +64,25 @@ function setup({
withRouter: true,
},
);
-}
-
-type SetupResult = ReturnType<typeof setup>;
-async function waitForAdminQueriesToFinish({ store }: SetupResult) {
- await waitFor(() => {
- expect(
- subscriptionApi.endpoints.getChannelInfo.select()(store.getState())
- .isSuccess,
- ).toBe(true);
- expect(
- securityCenterApi.endpoints.listSecurityAdvisories.select()(
- store.getState(),
- ).isSuccess,
- ).toBe(true);
- });
+ return { user: userEvent.setup({ advanceTimers: jest.advanceTimersByTime }) };
}
-function expectAdminQueriesToBeSkipped({ store }: SetupResult) {
- expect(
- subscriptionApi.endpoints.getChannelInfo.select()(store.getState())
- .isUninitialized,
- ).toBe(true);
- expect(
- securityCenterApi.endpoints.listSecurityAdvisories.select()(
- store.getState(),
- ).isUninitialized,
- ).toBe(true);
+async function waitForRequests() {
+ await act(async () => {
+ await fetchMock.callHistory.flush(true);
+ // RTK Query batches subscriber updates on a timer.
+ await jest.runOnlyPendingTimersAsync();
+ });
}
describe("SecurityCenterPromoCard", () => {
+ beforeEach(() => {
+ jest.useFakeTimers();
+ });
+
afterEach(() => {
+ jest.useRealTimers();
localStorage.removeItem(DISMISSED_KEY);
});
@@ -111,63 +98,65 @@ describe("SecurityCenterPromoCard", () => {
});
it("does not render when email is configured", async () => {
- const view = setup({ emailConfigured: true });
+ setup({ emailConfigured: true });
- await waitForAdminQueriesToFinish(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
});
it("does not render when slack is configured", async () => {
- const view = setup({ slackConfigured: true });
+ setup({ slackConfigured: true });
- await waitForAdminQueriesToFinish(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
});
- it("does not render or fire admin-only requests for non-admin users", () => {
- const view = setup({ isAdmin: false });
+ it("does not render or fire admin-only requests for non-admin users", async () => {
+ setup({ isAdmin: false });
- expectAdminQueriesToBeSkipped(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
- // Non-admins must not trigger admin-only endpoints.
- expect(fetchMock.callHistory.called("path:/api/ee/security-center")).toBe(
- false,
- );
+ expect(
+ fetchMock.callHistory.calls("path:/api/ee/security-center"),
+ ).toHaveLength(0);
+ expect(
+ fetchMock.callHistory.calls("path:/api/pulse/form_input"),
+ ).toHaveLength(0);
});
it("does not render for non-pro-self-hosted plans", async () => {
- const view = setup({ isProSelfHosted: false });
+ setup({ isProSelfHosted: false });
- await waitForAdminQueriesToFinish(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
});
it("does not render when there is an active advisory (red banner takes over)", async () => {
- const view = setup({
+ setup({
advisories: [createAdvisory({ match_status: "active" })],
});
- await waitForAdminQueriesToFinish(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
});
it("is dismissible", async () => {
- setup();
+ const { user } = setup();
await screen.findByText(/Stay safe with security alerts/);
const close = screen.getByRole("button", { name: /close/i });
- await userEvent.click(close);
+ await user.click(close);
await waitFor(() => {
expect(
@@ -180,9 +169,9 @@ describe("SecurityCenterPromoCard", () => {
it("stays hidden after dismissal", async () => {
localStorage.setItem(DISMISSED_KEY, "true");
- const view = setup();
+ setup();
- await waitForAdminQueriesToFinish(view);
+ await waitForRequests();
expect(
screen.queryByText(/Stay safe with security alerts/),
).not.toBeInTheDocument();
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts b/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts
index 69e78e93b5d..186a488716b 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts
@@ -2,7 +2,7 @@ import {
useAcknowledgeAdvisoriesMutation,
useAcknowledgeAdvisoryMutation,
useListSecurityAdvisoriesQuery,
-} from "metabase/api";
+} from "../api";
const POLLING_INTERVAL = 2000;
diff --git a/frontend/src/metabase/api/index.ts b/frontend/src/metabase/api/index.ts
index 380e585953f..f40a8058b55 100644
--- a/frontend/src/metabase/api/index.ts
+++ b/frontend/src/metabase/api/index.ts
@@ -34,7 +34,6 @@ export * from "./pulse";
export * from "./retry-dropped-refetch";
export * from "./revision";
export * from "./search";
-export * from "./security-center";
export * from "./segment";
export * from "./session";
export * from "./setup";
diff --git a/frontend/src/metabase/api/tags/constants.ts b/frontend/src/metabase/api/tags/constants.ts
index c4bb708c40a..2b01987ff9d 100644
--- a/frontend/src/metabase/api/tags/constants.ts
+++ b/frontend/src/metabase/api/tags/constants.ts
@@ -81,7 +81,6 @@ export const TAG_TYPES = [
"metabot-entities-list",
"metabot-prompt-suggestions",
"metabot-permissions",
- "security-advisory",
] as const;
export const TAG_TYPE_MAPPING = {