The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Gdgt 1557 migrate eslint from deprecated rulesdir to custom plugin (#68570)
Jakub Chodorowicz78efb4247b03
diff --git a/.eslintrc.js b/.eslintrc.jsindex 060aaac0b11..f3092c4f228 100644--- a/.eslintrc.js+++ b/.eslintrc.js@@ -8,7 +8,13 @@ const path = require("path");// can use this flag to enable it. This is set to true in CIconst shouldLintCssModules =process.env.LINT_CSS_MODULES === "true" || process.env.CI;-const plugins = ["react", "no-only-tests", "ttag", "i18next"];+const plugins = [+ "react",+ "no-only-tests",+ "ttag",+ "i18next",+ "metabase",+];if (shouldLintCssModules) {plugins.push("postcss-modules");}@@ -176,11 +182,11 @@ module.exports = {{files: ["*.js", "*.jsx", "*.ts", "*.tsx"],rules: {- "jtag-missing-key": "error",- "no-unconditional-metabase-links-render": "error",- "no-color-literals": "error",- "no-literal-metabase-strings": "error",- "no-oss-reinitialize-import": "error",+ "metabase/jtag-missing-key": "error",+ "metabase/no-unconditional-metabase-links-render": "error",+ "metabase/no-color-literals": "error",+ "metabase/no-literal-metabase-strings": "error",+ "metabase/no-oss-reinitialize-import": "error","depend/ban-dependencies": ["error",{@@ -214,9 +220,9 @@ module.exports = {"rspack.embedding-sdk-bundle.config.js",],rules: {- "no-color-literals": "off",- "no-unconditional-metabase-links-render": "off",- "no-literal-metabase-strings": "off",+ "metabase/no-color-literals": "off",+ "metabase/no-unconditional-metabase-links-render": "off",+ "metabase/no-literal-metabase-strings": "off",},},{@@ -337,7 +343,7 @@ module.exports = {"import/no-default-export": "off","import/order": "off","import/no-unresolved": "off",- "no-color-literals": "off",+ "metabase/no-color-literals": "off",},},{diff --git a/e2e/.eslintrc b/e2e/.eslintrcindex 9b820a06f3c..abf218f4e32 100644--- a/e2e/.eslintrc+++ b/e2e/.eslintrc@@ -1,8 +1,8 @@{"rules": {- "no-unscoped-text-selectors": 2,+ "metabase/no-unscoped-text-selectors": 2,"import/no-commonjs": 0,- "no-color-literals": 0,+ "metabase/no-color-literals": 0,"no-console": 0,"@typescript-eslint/no-namespace": "off","cypress/no-assigning-return-values": "error",@@ -49,9 +49,9 @@]}],- "no-direct-helper-import": 2,- "no-unsafe-element-filtering": ["warn"],- "no-unordered-test-helpers": 2+ "metabase/no-direct-helper-import": 2,+ "metabase/no-unsafe-element-filtering": ["warn"],+ "metabase/no-unordered-test-helpers": 2},"env": {"cypress/globals": true,diff --git a/e2e/support/commands.js b/e2e/support/commands.jsindex 6dd539bbf26..06c80748607 100644--- a/e2e/support/commands.js+++ b/e2e/support/commands.js@@ -1,7 +1,7 @@import "cypress-iframe";// this is the only place we allow direct helper import-// eslint-disable-next-line no-direct-helper-import+// eslint-disable-next-line metabase/no-direct-helper-importimport { H } from "e2e/support";import "./commands/ui/button";diff --git a/e2e/support/helpers/e2e-api-key-helpers.ts b/e2e/support/helpers/e2e-api-key-helpers.tsindex 85579d3dbde..825457268b0 100644--- a/e2e/support/helpers/e2e-api-key-helpers.ts+++ b/e2e/support/helpers/e2e-api-key-helpers.ts@@ -1,4 +1,4 @@-// eslint-disable-next-line no-direct-helper-import+// eslint-disable-next-line metabase/no-direct-helper-importimport { H } from "e2e/support";export const tryToCreateApiKeyViaModal = ({diff --git a/e2e/support/helpers/e2e-collection-helpers.ts b/e2e/support/helpers/e2e-collection-helpers.tsindex f1ad883dc18..3b0afbf85cf 100644--- a/e2e/support/helpers/e2e-collection-helpers.ts+++ b/e2e/support/helpers/e2e-collection-helpers.ts@@ -44,7 +44,7 @@ export function getPersonalCollectionName(}export function openCollectionItemMenu(item: string, index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findByTestId("collection-table").findAllByText(item).eq(index)diff --git a/e2e/support/helpers/e2e-dashboard-helpers.ts b/e2e/support/helpers/e2e-dashboard-helpers.tsindex ed64ac4d2b8..50dca75e8dc 100644--- a/e2e/support/helpers/e2e-dashboard-helpers.ts+++ b/e2e/support/helpers/e2e-dashboard-helpers.ts@@ -36,12 +36,12 @@ export function getDashboardCards() {}export function getDashboardCard(index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn getDashboardCards().eq(index);}export function ensureDashboardCardHasText(text: string, index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("dashcard").eq(index).should("contain", text);}diff --git a/e2e/support/helpers/e2e-dimension-list-helpers.js b/e2e/support/helpers/e2e-dimension-list-helpers.jsindex 54a55568585..42d6f8776a5 100644--- a/e2e/support/helpers/e2e-dimension-list-helpers.js+++ b/e2e/support/helpers/e2e-dimension-list-helpers.js@@ -9,7 +9,7 @@ export function getDimensions(isSelected) {}export function getDimensionByName({ name, index = 0, isSelected }) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn getDimensions(isSelected).filter(`:contains("${name}")`).eq(index);}diff --git a/e2e/support/helpers/e2e-embedding-sdk-interactive-question-helpers.tsx b/e2e/support/helpers/e2e-embedding-sdk-interactive-question-helpers.tsxindex a84e6cf1c80..b83083db7d8 100644--- a/e2e/support/helpers/e2e-embedding-sdk-interactive-question-helpers.tsx+++ b/e2e/support/helpers/e2e-embedding-sdk-interactive-question-helpers.tsx@@ -13,7 +13,7 @@ export function saveInteractiveQuestionAsNewQuestion(options: {cy.intercept("POST", "/api/card").as("createCard");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("cell-data").last().click();popover().findByText(`See these ${entityName}`).click();cy.findByRole("button", { name: "Save" }).click();diff --git a/e2e/support/helpers/e2e-metabot-helpers.ts b/e2e/support/helpers/e2e-metabot-helpers.tsindex d2a0edd8ad0..2a0850b9442 100644--- a/e2e/support/helpers/e2e-metabot-helpers.ts+++ b/e2e/support/helpers/e2e-metabot-helpers.ts@@ -73,7 +73,7 @@ export function chatMessages() {}export function lastChatMessage() {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn chatMessages().last();}diff --git a/e2e/support/helpers/e2e-notebook-helpers.ts b/e2e/support/helpers/e2e-notebook-helpers.tsindex 2379d39ca47..7434eb1a02f 100644--- a/e2e/support/helpers/e2e-notebook-helpers.ts+++ b/e2e/support/helpers/e2e-notebook-helpers.ts@@ -84,7 +84,7 @@ export function addSummaryField({stage?: number;index?: number;}) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetNotebookStep("summarize", { stage, index }).findByTestId("aggregate-step").findAllByTestId("notebook-cell-item")@@ -118,7 +118,7 @@ export function addSummaryGroupingField({index?: number;bucketSize?: string;}) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetNotebookStep("summarize", { stage, index }).findByTestId("breakout-step").findAllByTestId("notebook-cell-item")@@ -142,7 +142,7 @@ export function addSummaryGroupingField({});if (bucketSize) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringpopover().last().findByText(bucketSize).click();}}@@ -339,7 +339,7 @@ function verifyNotebookExpressions();for (let index = 0; index < expressions.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetExpressionItems(stageIndex).eq(index).should("have.text", expressions[index]);@@ -360,7 +360,7 @@ function verifyNotebookFilters();for (let index = 0; index < filters.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetFilterItems(stageIndex).eq(index).should("have.text", filters[index]);}} else {@@ -381,7 +381,7 @@ function verifyNotebookAggregations();for (let index = 0; index < aggregations.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetSummarizeItems(stageIndex, "aggregate").eq(index).should("have.text", aggregations[index]);@@ -410,7 +410,7 @@ function verifyNotebookBreakouts();for (let index = 0; index < breakouts.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetSummarizeItems(stageIndex, "breakout").eq(index).should("have.text", breakouts[index]);@@ -444,9 +444,9 @@ function verifyNotebookSort(for (let index = 0; index < sort.length; ++index) {const { column, order } = sort[index];- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetSortItems(stageIndex).eq(index).should("have.text", column);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetSortItems(stageIndex).eq(index).icon(order === "asc" ? "arrow_up" : "arrow_down")diff --git a/e2e/support/helpers/e2e-permissions-helpers.js b/e2e/support/helpers/e2e-permissions-helpers.jsindex 86a8407e128..f46161da1d8 100644--- a/e2e/support/helpers/e2e-permissions-helpers.js+++ b/e2e/support/helpers/e2e-permissions-helpers.js@@ -38,7 +38,7 @@ export function modifyPermission(}export function selectPermissionRow(item, permissionIndex) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetPermissionRowPermissions(item).eq(permissionIndex).click();}@@ -80,7 +80,7 @@ export function assertPermissionForItem(permissionColumnIndex,permissionValue,) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetPermissionRowPermissions(item).eq(permissionColumnIndex).should("have.text", permissionValue);@@ -92,7 +92,7 @@ export function assertPermissionForItem(* @param {boolean} isDisabled*/export function isPermissionDisabled(row, index, permission, isDisabled) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn getPermissionRowPermissions(row).eq(index).should("have.attr", "aria-disabled", isDisabled.toString())diff --git a/e2e/support/helpers/e2e-ui-elements-helpers.js b/e2e/support/helpers/e2e-ui-elements-helpers.jsindex 3abc1dc7dac..955d1b022f6 100644--- a/e2e/support/helpers/e2e-ui-elements-helpers.js+++ b/e2e/support/helpers/e2e-ui-elements-helpers.js@@ -195,12 +195,12 @@ export function filterWidget({ isEditing = false, name = null } = {}) {}export function clearFilterWidget(index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn filterWidget().eq(index).icon("close").click();}export function resetFilterWidgetToDefault(index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn filterWidget().eq(index).icon("revert").click();}@@ -439,7 +439,7 @@ export function tableInteractiveFooter() {}export function resizeTableColumn(columnId, moveX, elementIndex = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId(`resize-handle-${columnId}`).eq(elementIndex).trigger("mousedown", {@@ -483,7 +483,7 @@ export function assertTableRowsCount(value) {}export function lastTableRow() {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn tableInteractiveScrollContainer().scrollTo("bottomLeft").findAllByRole("row")@@ -547,7 +547,7 @@ export function assertTableData({ columns, firstRows = [] }) {.should("have.length", columns.length);columns.forEach((column, index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringtableInteractive().findAllByTestId("header-cell").eq(index)@@ -556,7 +556,7 @@ export function assertTableData({ columns, firstRows = [] }) {firstRows.forEach((row, rowIndex) => {row.forEach((cell, cellIndex) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringtableInteractiveBody().findAllByTestId("cell-data").eq(columns.length * rowIndex + cellIndex)@@ -596,12 +596,12 @@ export function fieldValuesTextbox() {}export function fieldValuesValue(index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByTestId("token-field").eq(index);}export function removeFieldValuesValue(index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByTestId("token-field").findAllByLabelText("Remove")@@ -610,7 +610,7 @@ export function removeFieldValuesValue(index) {}export function multiAutocompleteValue(index, filter = ":eq(0)") {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByRole("combobox").filter(filter)diff --git a/e2e/support/helpers/e2e-upload-helpers.js b/e2e/support/helpers/e2e-upload-helpers.jsindex 75edf7d066e..31172005245 100644--- a/e2e/support/helpers/e2e-upload-helpers.js+++ b/e2e/support/helpers/e2e-upload-helpers.js@@ -78,7 +78,7 @@ export function uploadFile(cy.wait(`@${uploadMode}CSV`);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("status").last().findByText(`Data added to ${collectionName}`, {diff --git a/e2e/support/helpers/e2e-visual-tests-helpers.js b/e2e/support/helpers/e2e-visual-tests-helpers.jsindex 3871011c69c..80a9e59bb8b 100644--- a/e2e/support/helpers/e2e-visual-tests-helpers.js+++ b/e2e/support/helpers/e2e-visual-tests-helpers.js@@ -195,7 +195,7 @@ export function assertTooltipRow(name,{ color, value, secondaryValue, index } = {},) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText(name).eq(index ?? 0).parent("tr")diff --git a/e2e/test-component/scenarios/embedding-sdk/sdk-question-native.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/sdk-question-native.cy.spec.tsxindex 06951027b57..e75822f8c69 100644--- a/e2e/test-component/scenarios/embedding-sdk/sdk-question-native.cy.spec.tsx+++ b/e2e/test-component/scenarios/embedding-sdk/sdk-question-native.cy.spec.tsx@@ -69,7 +69,7 @@ describe("scenarios > embedding-sdk > interactive-question > native", () => {);// The first row should have the same ID column value as the initial SQL parameters- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringrows.findAllByTestId("cell-data").eq(idColumnIndex)diff --git a/e2e/test-component/scenarios/embedding-sdk/sdk-question.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/sdk-question.cy.spec.tsxindex 0a52c5b2112..da34ffe01af 100644--- a/e2e/test-component/scenarios/embedding-sdk/sdk-question.cy.spec.tsx+++ b/e2e/test-component/scenarios/embedding-sdk/sdk-question.cy.spec.tsx@@ -99,7 +99,7 @@ describe("scenarios > embedding-sdk > interactive-question", () => {expect(response?.statusCode).to.equal(202);});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("cell-data").last().click();cy.on("uncaught:exception", (error) => {diff --git a/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js b/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.jsindex 61c0fd22516..f0be2b75d8a 100644--- a/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js+++ b/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js@@ -307,7 +307,7 @@ function assertUpdatedScoreNotInTable() {function assertSuccessfullUpdateToast() {cy.log("it shows a toast informing the update was successful");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().should("be.visible")@@ -317,7 +317,7 @@ function assertSuccessfullUpdateToast() {function assertSuccessfullDeleteToast() {cy.log("it shows a toast informing the delete was successful");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().should("be.visible")diff --git a/e2e/test/scenarios/actions/actions-reproductions.cy.spec.js b/e2e/test/scenarios/actions/actions-reproductions.cy.spec.jsindex 6c919fff788..492890d05e9 100644--- a/e2e/test/scenarios/actions/actions-reproductions.cy.spec.js+++ b/e2e/test/scenarios/actions/actions-reproductions.cy.spec.js@@ -528,7 +528,7 @@ const actionButtonContainer = () =>cy.findByTestId("action-button-full-container");const dashCard = () =>- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("dashcard-container").last()diff --git a/e2e/test/scenarios/admin-2/people.cy.spec.js b/e2e/test/scenarios/admin-2/people.cy.spec.jsindex 2dfb8802e07..04fd22bcca1 100644--- a/e2e/test/scenarios/admin-2/people.cy.spec.js+++ b/e2e/test/scenarios/admin-2/people.cy.spec.js@@ -41,7 +41,7 @@ describe("scenarios > admin > people", () => {cy.visit("/admin/people");assertTableRowsCount(TOTAL_USERS);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${TOTAL_USERS} people found`);// A small sidebar selector@@ -57,13 +57,13 @@ describe("scenarios > admin > people", () => {cy.log("Dig into one of the user groups and make sure its members are listed",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("All Users").click();cy.findByTestId("admin-pane-page-title").contains("All Users");// The same list as for "People"assertTableRowsCount(TOTAL_USERS);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${TOTAL_USERS} members`);// We cannot add new users to the "All users" group directly@@ -73,31 +73,31 @@ describe("scenarios > admin > people", () => {const GROUP = "collection";cy.findByTestId("admin-layout-sidebar").findByText("Groups").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(GROUP).closest("tr").contains("4");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(GROUP).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("4 members");cy.button("Add members").click();cy.focused().type(admin.first_name);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(adminUserName).click();cy.button("Add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("5 members");removeUserFromGroup(adminUserName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("4 members");// should load the members when navigating to the group directlycy.visit(`/admin/people/groups/${DATA_GROUP}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2 members");cy.findByTestId("admin-layout-sidebar").findByText("People").click();@@ -112,13 +112,13 @@ describe("scenarios > admin > people", () => {cy.findByRole("table").findByRole("link", { name: /data$/i }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1 member");removeUserFromGroup(normalUserName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("0 members");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("A group is only as good as its members.");});@@ -136,14 +136,14 @@ describe("scenarios > admin > people", () => {clickButton("Create");// second modal- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${FULL_NAME} has been added`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(FULL_NAME);cy.location().should((loc) =>expect(loc.pathname).to.eq("/admin/people"),@@ -159,14 +159,14 @@ describe("scenarios > admin > people", () => {clickButton("Create");// second modal- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${email} has been added`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(email);});@@ -179,7 +179,7 @@ describe("scenarios > admin > people", () => {cy.findByLabelText("Last name").type(last_name + "New");cy.findByLabelText(/Email/).type(email.toUpperCase());clickButton("Create");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Email address already in use.");});@@ -269,7 +269,7 @@ describe("scenarios > admin > people", () => {cy.visit("/admin/people");showUserOptions(normalUserName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit user").click();H.modal().within(() => {@@ -282,7 +282,7 @@ describe("scenarios > admin > people", () => {clickButton("Update", { timeout: 4000 });});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(NEW_FULL_NAME);cy.location().should((loc) =>expect(loc.pathname).to.eq("/admin/people"),@@ -292,14 +292,14 @@ describe("scenarios > admin > people", () => {it("should reset user password without SMTP set up", () => {cy.visit("/admin/people");showUserOptions(normalUserName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Reset password").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`Reset ${normalUserName}'s password?`);clickButton("Reset password");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${normalUserName}'s password has been reset`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^temporary password$/i);clickButton("Done");cy.location().should((loc) =>@@ -331,9 +331,9 @@ describe("scenarios > admin > people", () => {cy.visit("/admin/people");showUserOptions(normalUserName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Reset password").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`Reset ${normalUserName}'s password?`);clickButton("Reset password");@@ -344,11 +344,11 @@ describe("scenarios > admin > people", () => {});cy.log("Should not show temporary password modal");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${normalUserName}'s password has been reset`).should("not.exist",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^temporary password$/i).should("not.exist");cy.log("Should close the modal");@@ -461,7 +461,7 @@ describe("scenarios > admin > people", () => {cy.visit("/admin/people/groups");cy.findByTestId("admin-layout-content").scrollTo("bottom");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("readonly");});@@ -486,16 +486,16 @@ describe("scenarios > admin > people", () => {clickButton("Create");// second modal- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${FULL_NAME} has been added`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(`We’ve sent an invite to ${email} with instructions to set their password.`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(FULL_NAME);});});@@ -517,11 +517,11 @@ describe("scenarios > admin > people", () => {cy.visit("/admin/people");// Total- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${NEW_TOTAL_USERS} people found`);// Page 1- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);assertTableRowsCount(PAGE_SIZE);cy.findByLabelText("Previous page").should("be.disabled");@@ -539,7 +539,7 @@ describe("scenarios > admin > people", () => {cy.findByLabelText("Previous page").click();// Page 1- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);assertTableRowsCount(PAGE_SIZE);});@@ -549,17 +549,17 @@ describe("scenarios > admin > people", () => {cy.visit(`admin/people/groups/${ALL_USERS_GROUP}`);// Total- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${NEW_TOTAL_USERS} members`);// Page 1- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);assertTableRowsCount(PAGE_SIZE);cy.findByLabelText("Previous page").should("be.disabled");cy.findByLabelText("Next page").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Loading...").should("not.exist");// Page 2@@ -568,11 +568,11 @@ describe("scenarios > admin > people", () => {cy.findByLabelText("Next page").should("be.disabled");cy.findByLabelText("Previous page").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Loading...").should("not.exist");// Page 1- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);assertTableRowsCount(PAGE_SIZE);});@@ -598,9 +598,9 @@ describe("scenarios > admin > people", () => {});cy.visit("/account/notifications");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Dashboard");cy.visit("/admin/people");@@ -618,9 +618,9 @@ describe("scenarios > admin > people", () => {cy.visit("/account/notifications");cy.findByLabelText("bell icon");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Dashboard").should("not.exist");});@@ -684,7 +684,7 @@ describe("scenarios > admin > people > group managers", () => {H.activateToken("pro-self-hosted");cy.visit("/admin/people");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(normalUserName).closest("tr").findByText("2 other groups")@@ -695,7 +695,7 @@ describe("scenarios > admin > people > group managers", () => {cy.signInAsNormalUser();cy.visit("/");cy.icon("gear").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Admin settings").click();});@@ -707,25 +707,25 @@ describe("scenarios > admin > people > group managers", () => {// Edit group namecy.icon("ellipsis").eq(0).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit Name").click();cy.findByDisplayValue("collection").type(" updated");cy.button("Done").click();// Click on the group with the new name- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("collection updated").click();// Add "No Collection" user as a membercy.button("Add members").click();cy.focused().type("No");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(noCollectionUserName).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add").click();// Find user row- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(noCollectionUserName).closest("tr").as("userRow");// Promote to manager and demote back to member@@ -743,11 +743,11 @@ describe("scenarios > admin > people > group managers", () => {cy.get("@userRow").within(() => {cy.icon("close").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(noCollectionUserName).should("not.exist");// Demote myself- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(normalUserName).closest("tr").within(() => {@@ -760,11 +760,11 @@ describe("scenarios > admin > people > group managers", () => {cy.url().should("match", /\/admin\/people\/groups$/);// Open another group- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("data").click();// Remove myself- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(normalUserName).closest("tr").within(() => {@@ -778,7 +778,7 @@ describe("scenarios > admin > people > group managers", () => {it("can manage members from the people page", () => {// Open membership select for a user- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(noCollectionUserName).closest("tr").as("userRow")@@ -809,7 +809,7 @@ describe("scenarios > admin > people > group managers", () => {});// Find own row- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(normalUserName).closest("tr").within(() => {@@ -864,7 +864,7 @@ describe("issue 23689", () => {visitGroupPermissionsPage(COLLECTION_GROUP);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3 members");findUserByFullName(normal);@@ -877,7 +877,7 @@ describe("issue 23689", () => {.click({ force: true });// Sanity check instead of waiting for the PUT request- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Manager");cy.sandboxTable({@@ -894,7 +894,7 @@ describe("issue 23689", () => {it("sandboxed group manager should see all other members (metabase#23689)", () => {visitGroupPermissionsPage(COLLECTION_GROUP);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3 members");findUserByFullName(sandboxed);@@ -904,7 +904,7 @@ describe("issue 23689", () => {cy.visit("/admin/people");cy.wait("@membership");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${totalUsers} people found`);findUserByFullName(sandboxed);findUserByFullName(normal);diff --git a/e2e/test/scenarios/admin-2/settings.cy.spec.js b/e2e/test/scenarios/admin-2/settings.cy.spec.jsindex 9e01fa1644d..68b99f1365e 100644--- a/e2e/test/scenarios/admin-2/settings.cy.spec.js+++ b/e2e/test/scenarios/admin-2/settings.cy.spec.js@@ -76,7 +76,7 @@ describe("scenarios > admin > settings", () => {// rather than aliasing it with .as()const emailInput = () =>cy- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.contains(/Email Address for Help Requests/i).parent().parent()@@ -139,7 +139,7 @@ describe("scenarios > admin > settings", () => {H.popover().contains("https://").click();cy.wait("@httpsCheck");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("It looks like HTTPS is not properly configured");});@@ -259,11 +259,11 @@ describe("scenarios > admin > settings", () => {cy.visit("/admin/settings/general");cy.wait("@appSettings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("We're a little lost...").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Site name/i);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Site URL/i);});@@ -717,7 +717,7 @@ describe("scenarios > admin > localization", () => {// find and open that questioncy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders created before June 1st 2022").click();cy.wait("@cardQuery");@@ -753,7 +753,7 @@ describe("scenarios > admin > localization", () => {});cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("13604").click();cy.log("Reported failing on v0.37.0.2 and labeled as `.Regression`");@@ -811,10 +811,10 @@ describe("scenarios > admin > localization", () => {it("should use currency settings for number columns with style set to currency (metabase#10787)", () => {cy.visit("/admin/settings/localization");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Unit of currency");cy.findByDisplayValue("US Dollar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Euro").click();H.undoToast().findByText("Changes saved").should("be.visible");@@ -837,7 +837,7 @@ describe("scenarios > admin > localization", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("€10.00");});@@ -938,14 +938,14 @@ describe("scenarios > admin > settings > map settings", () => {it("should be able to load a custom map even if a name has not been added yet (#14635)", () => {cy.intercept("GET", "/api/geojson*").as("load");cy.visit("/admin/settings/maps");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add a map").click();cy.findByPlaceholderText("Like https://my-mb-server.com/maps/my-map.json",).type("https://raw.githubusercontent.com/metabase/metabase/master/resources/frontend_client/app/assets/geojson/world.json",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Load").click();cy.wait("@load").then((interception) => {expect(interception.response.statusCode).to.eq(200);@@ -954,14 +954,14 @@ describe("scenarios > admin > settings > map settings", () => {it("should show an informative error when adding an invalid URL", () => {cy.visit("/admin/settings/maps");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add a map").click();cy.findByPlaceholderText("Like https://my-mb-server.com/maps/my-map.json",).type("bad-url");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Load").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Invalid GeoJSON file location: must either start with http:// or https:// or be a relative path to a file on the classpath. " +"URLs referring to hosts that supply internal hosting metadata are prohibited.",@@ -970,16 +970,16 @@ describe("scenarios > admin > settings > map settings", () => {it("should show an informative error when adding a valid URL that does not contain GeoJSON, or is missing required fields", () => {cy.visit("/admin/settings/maps");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add a map").click();// Not GeoJSONcy.findByPlaceholderText("Like https://my-mb-server.com/maps/my-map.json",).type("https://metabase.com");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Load").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("GeoJSON URL returned invalid content-type");// GeoJSON with an unsupported format (not a Feature or FeatureCollection)@@ -988,9 +988,9 @@ describe("scenarios > admin > settings > map settings", () => {.type("https://raw.githubusercontent.com/metabase/metabase/master/test_resources/test.geojson",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Load").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Invalid custom GeoJSON: does not contain features");});diff --git a/e2e/test/scenarios/admin-2/sso/ldap.cy.spec.js b/e2e/test/scenarios/admin-2/sso/ldap.cy.spec.jsindex 0cd1eb62a0c..8d86808db7c 100644--- a/e2e/test/scenarios/admin-2/sso/ldap.cy.spec.js+++ b/e2e/test/scenarios/admin-2/sso/ldap.cy.spec.js@@ -25,7 +25,7 @@ describe(cy.button("Save and enable").click();cy.wait("@updateLdapSettings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Success").should("exist");});@@ -126,7 +126,7 @@ describe(cy.button("Save and enable").click();cy.wait("@updateLdapSettings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Success").should("exist");});@@ -195,9 +195,9 @@ describe(cy.signOut();cy.visit("/auth/login");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Username or email address").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("be.visible");});diff --git a/e2e/test/scenarios/admin-2/sso/saml.cy.spec.js b/e2e/test/scenarios/admin-2/sso/saml.cy.spec.jsindex fe40ab9d7c3..bc44cd71958 100644--- a/e2e/test/scenarios/admin-2/sso/saml.cy.spec.js+++ b/e2e/test/scenarios/admin-2/sso/saml.cy.spec.js@@ -22,7 +22,7 @@ describe("scenarios > admin > settings > SSO > SAML", () => {enterSamlSettings();cy.button("Save and enable").click();cy.wait("@updateSamlSettings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Success").should("exist");H.goToAuthOverviewPage();diff --git a/e2e/test/scenarios/admin/admin-reproductions.cy.spec.js b/e2e/test/scenarios/admin/admin-reproductions.cy.spec.jsindex b28eb55e797..baa7fddd33c 100644--- a/e2e/test/scenarios/admin/admin-reproductions.cy.spec.js+++ b/e2e/test/scenarios/admin/admin-reproductions.cy.spec.js@@ -242,7 +242,7 @@ describe("(metabase#46714)", () => {cy.findByLabelText("Filter operator").should("have.text", "Between").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Less than").click();cy.findByLabelText("Filter operator").should("have.text", "Less than");H.popover().findByPlaceholderText("Enter a number").clear().type("1000");diff --git a/e2e/test/scenarios/admin/databases.cy.spec.js b/e2e/test/scenarios/admin/databases.cy.spec.jsindex d1d3e4cc5f2..8f4fdf8634d 100644--- a/e2e/test/scenarios/admin/databases.cy.spec.js+++ b/e2e/test/scenarios/admin/databases.cy.spec.js@@ -89,7 +89,7 @@ describe("admin > database > add", () => {cy.visit("/admin/databases/create");// should display a setup help card- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Need help connecting?");cy.findByLabelText("Database type").click();@@ -356,11 +356,11 @@ describe("admin > database > add", () => {);it("should add MySQL database and redirect to db info page", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("MySQL").click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show advanced options").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Additional JDBC connection string options");H.typeAndBlurUsingLabel("Display name", "QA MySQL8");@@ -377,7 +377,7 @@ describe("admin > database > add", () => {"allowPublicKeyRetrieval=true",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").should("not.be.disabled").click();cy.wait("@createDatabase");@@ -506,7 +506,7 @@ describe("scenarios > admin > databases > exceptions", () => {cy.get("nav").should("contain", "Metabase Admin");// The response still contains the database name,// so there's no reason we can't display it.- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/Sample Database/i);// This seems like a reasonable CTA if the database is beyond repair.cy.button("Remove this database").should("not.be.disabled");@@ -601,7 +601,7 @@ describe("scenarios > admin > databases > exceptions", () => {cy.wait("@loadDatabase").then(({ response }) => {expect(response.statusCode).to.eq(404);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Not found.");cy.findByRole("table").should("not.exist");});@@ -632,18 +632,18 @@ describe("scenarios > admin > databases > exceptions", () => {cy.visit("/admin/databases");cy.wait("@failedGet");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Something.s gone wrong/);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/We.ve run into an error\. You can try refreshing the page, or just go back\./,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(errorMessage).should("not.be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show error details").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(errorMessage).should("be.visible");});});@@ -666,7 +666,7 @@ describe("scenarios > admin > databases > sample database", () => {editDatabase();// should not display a setup help card- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Need help connecting?").should("not.exist");cy.log(@@ -683,7 +683,7 @@ describe("scenarios > admin > databases > sample database", () => {.and("contain", "sample-database.db");cy.log("should be possible to modify the connection settings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show advanced options").click();// `auto_run_queries` toggle should be ON by defaultcy.findByLabelText(/Rerun queries for simple explorations/)@@ -702,7 +702,7 @@ describe("scenarios > admin > databases > sample database", () => {cy.findByLabelText(/Choose when syncs and scans happen/).click({force: true,});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Hourly").click();H.popover().within(() => {cy.findByText("Daily").click({ force: true });@@ -836,14 +836,14 @@ describe("scenarios > admin > databases > sample database", () => {// lets you trigger the manual database schema synccy.button("Sync database schema").click();cy.wait("@sync_schema");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sync triggered!");// lets you trigger the manual rescan of field values- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Re-scan field values").click();cy.wait("@rescan_values");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Scan triggered!");// lets you discard saved field values@@ -905,7 +905,7 @@ describe("scenarios > admin > databases > sample database", () => {cy.location("pathname").should("eq", "/admin/databases/"); // FIXME why the trailing slash?cy.intercept("POST", "/api/database/sample_database").as("sample_database");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Bring the sample database back", {timeout: 10000,}).click();@@ -995,7 +995,7 @@ describe("add database card", () => {it("should track the click on the card", () => {cy.visit("/browse/databases");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findByTestId("database-browser").findAllByRole("link").last()diff --git a/e2e/test/scenarios/admin/datamodel/datamodel.cy.spec.ts b/e2e/test/scenarios/admin/datamodel/datamodel.cy.spec.tsindex c747477a726..983b65654b2 100644--- a/e2e/test/scenarios/admin/datamodel/datamodel.cy.spec.ts+++ b/e2e/test/scenarios/admin/datamodel/datamodel.cy.spec.ts@@ -990,9 +990,9 @@ describe("scenarios > admin > datamodel", () => {);cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1009,9 +1009,9 @@ describe("scenarios > admin > datamodel", () => {TableSection.getDescriptionInput().should("have.value", "");cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});});@@ -1114,9 +1114,9 @@ describe("scenarios > admin > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1145,9 +1145,9 @@ describe("scenarios > admin > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});});@@ -1514,9 +1514,9 @@ describe("scenarios > admin > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1546,9 +1546,9 @@ describe("scenarios > admin > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});@@ -2018,7 +2018,7 @@ describe("scenarios > admin > datamodel", () => {cy.log("verify viz");H.openOrdersTable();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Tax (CA$)").should("be.visible");});@@ -2581,7 +2581,7 @@ describe("scenarios > admin > datamodel", () => {cy.signInAsNormalUser();H.openReviewsTable({ limit: 1 });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rustic Paper Wallet").should("be.visible");});@@ -2817,7 +2817,7 @@ describe("scenarios > admin > datamodel", () => {fieldId: REVIEWS.RATING,});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CUSTOM_MAPPING_ERROR).should("exist");});diff --git a/e2e/test/scenarios/admin/datamodel/reproductions.cy.spec.ts b/e2e/test/scenarios/admin/datamodel/reproductions.cy.spec.tsindex cb1adef06fc..c6e9cf10fd9 100644--- a/e2e/test/scenarios/admin/datamodel/reproductions.cy.spec.ts+++ b/e2e/test/scenarios/admin/datamodel/reproductions.cy.spec.ts@@ -34,7 +34,7 @@ describe("issue 17768", () => {H.openReviewsTable({ mode: "notebook" });H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().within(() => {diff --git a/e2e/test/scenarios/admin/datamodel/segments.cy.spec.ts b/e2e/test/scenarios/admin/datamodel/segments.cy.spec.tsindex be61e3d6775..0dba62aaafd 100644--- a/e2e/test/scenarios/admin/datamodel/segments.cy.spec.ts+++ b/e2e/test/scenarios/admin/datamodel/segments.cy.spec.ts@@ -272,7 +272,7 @@ describe("scenarios > admin > datamodel > segments", () => {.first().should("contain", "You edited the description").and("contain", "Foo");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@revisions").last().should("contain", `You created "${SEGMENT_NAME}"`)diff --git a/e2e/test/scenarios/admin/tools/help.cy.spec.ts b/e2e/test/scenarios/admin/tools/help.cy.spec.tsindex 043826a030d..0a163b760ed 100644--- a/e2e/test/scenarios/admin/tools/help.cy.spec.ts+++ b/e2e/test/scenarios/admin/tools/help.cy.spec.ts@@ -11,9 +11,9 @@ describe("scenarios > admin > tools > help", { tags: "@OSS" }, () => {it("should link `Get help` to help", () => {cy.visit("/admin/tools/help");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Metabase Admin");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Get help").parents("a").should("have.prop", "href")diff --git a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts b/e2e/test/scenarios/admin/tools/tools.cy.spec.tsindex 74f3616f6d2..f0b1dfe3ee4 100644--- a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts+++ b/e2e/test/scenarios/admin/tools/tools.cy.spec.ts@@ -84,13 +84,13 @@ describe("issue 14636", () => {cy.location("search").should("eq", "");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Troubleshooting logs");cy.findByLabelText("pagination").findByText("1 - 50").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("field values scanning");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("513");cy.findByLabelText("Previous page").should("be.disabled");@@ -103,9 +103,9 @@ describe("issue 14636", () => {.findByText(`51 - ${total}`).should("be.visible");cy.findByLabelText("pagination").findByText("1 - 50").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("analyze");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("200");cy.findByLabelText("Next page").should("be.disabled");diff --git a/e2e/test/scenarios/binning/binning-options.cy.spec.js b/e2e/test/scenarios/binning/binning-options.cy.spec.jsindex f186e82782e..b16b46b4fd0 100644--- a/e2e/test/scenarios/binning/binning-options.cy.spec.js+++ b/e2e/test/scenarios/binning/binning-options.cy.spec.js@@ -146,7 +146,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Total: Auto binned");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total: Auto binned").click();openBinningListForDimension("Total", "Auto binned");@@ -162,7 +162,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Created At: Month");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At: Month").click();openBinningListForDimension("Created At", "by month");@@ -182,7 +182,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Longitude: Auto binned");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Longitude: Auto binned").click();openBinningListForDimension("Longitude", "Auto binned");@@ -322,7 +322,7 @@ function getAllOptions({ options, isSelected, shouldExpandList } = {}) {// Custom question has two popovers open.// The binning options are in the latest (last) one.// Using `.last()` works even when only one popover is open so it covers both scenarios.- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {diff --git a/e2e/test/scenarios/binning/binning-reproductions.cy.spec.js b/e2e/test/scenarios/binning/binning-reproductions.cy.spec.jsindex 6db51c7ba51..411dc9fe78e 100644--- a/e2e/test/scenarios/binning/binning-reproductions.cy.spec.js+++ b/e2e/test/scenarios/binning/binning-reproductions.cy.spec.js@@ -22,20 +22,20 @@ describe("binning related reproductions", () => {cy.findByText("16327").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/CREATED_AT/i).realHover();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("by month").click({ force: true });// Implicit assertion - it fails if there is more than one instance of the string, which is exactly what we need for this repro- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Day");});@@ -71,9 +71,9 @@ describe("binning related reproductions", () => {expect(xhr.response.body.error).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by Created At: Year");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2024");});@@ -112,7 +112,7 @@ describe("binning related reproductions", () => {.findByLabelText("Temporal bucket").realHover().click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Quarter").click();H.getNotebookStep("sort").findByText("CREATED_AT: Quarter");@@ -142,7 +142,7 @@ describe("binning related reproductions", () => {cy.findByText("ID").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Summarize").click();H.popover().findByText("Count of rows").click();@@ -281,11 +281,11 @@ describe("binning related reproductions", () => {it("should work for notebook mode", () => {openSummarizeOptions("Notebook mode");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.changeBinningForDimension({@@ -320,9 +320,9 @@ describe("binning related reproductions", () => {});H.startNewQuestion();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Saved Questions").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("SQL Binning").click();H.visualize();@@ -336,11 +336,11 @@ describe("binning related reproductions", () => {cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by TOTAL: Auto binned");cy.get(".bar").should("have.length.of.at.most", 10);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("-60");});@@ -360,9 +360,9 @@ describe("binning related reproductions", () => {expect(xhr.response.body.error).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by LONGITUDE: Auto binned");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("170° W");});});diff --git a/e2e/test/scenarios/binning/correctness/longitude.cy.spec.js b/e2e/test/scenarios/binning/correctness/longitude.cy.spec.jsindex 8c0ef3ec242..5375454ad77 100644--- a/e2e/test/scenarios/binning/correctness/longitude.cy.spec.js+++ b/e2e/test/scenarios/binning/correctness/longitude.cy.spec.js@@ -25,7 +25,7 @@ describe("scenarios > binning > correctness > longitude", () => {.should("contain", "Longitude").and("contain", selected);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();getTitle(`Count by Longitude: ${selected}`);@@ -47,7 +47,7 @@ describe("scenarios > binning > correctness > longitude", () => {.should("contain", "Longitude").and("contain", "Unbinned");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();getTitle("Count by Longitude");diff --git a/e2e/test/scenarios/binning/qb-explicit-joins.cy.spec.js b/e2e/test/scenarios/binning/qb-explicit-joins.cy.spec.jsindex bf64dae6d71..26bf18c09b7 100644--- a/e2e/test/scenarios/binning/qb-explicit-joins.cy.spec.js+++ b/e2e/test/scenarios/binning/qb-explicit-joins.cy.spec.js@@ -81,7 +81,7 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (// Make sure time series footer works as wellcy.findByTestId("timeseries-bucket-button").contains("Year").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quarter").click();cy.wait("@dataset");@@ -129,11 +129,11 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (cy.findByText("QB Binning").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();});@@ -153,7 +153,7 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (// Make sure time series footer works as wellcy.findByTestId("timeseries-bucket-button").contains("Year").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quarter").click();cy.wait("@dataset");@@ -207,11 +207,11 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (it("should work for time series", () => {H.tableHeaderClick("People → Birth Date");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();// Reproduces metabase#16693- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by People → Birth Date: Month");assertOnXYAxisLabels({ xLabel: "People → Birth Date", yLabel: "Count" });@@ -227,11 +227,11 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (// Make sure time series footer works as wellcy.findByTestId("timeseries-bucket-button").contains("Month").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quarter").click();// Reproduces metabase#16693- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by People → Birth Date: Quarter");H.echartsContainer()@@ -246,18 +246,18 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (it("should work for number", () => {H.tableHeaderClick("Products → Price");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();// Reproduces metabase#16693- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by Products → Price: Auto binned");assertOnXYAxisLabels({ xLabel: "Products → Price", yLabel: "Count" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("12.5");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("25");H.chartPathWithFillColor("#509EE3");@@ -265,11 +265,11 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (it("should work for longitude", () => {H.tableHeaderClick("People → Longitude");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();// Reproduces metabase#16693- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by People → Longitude: Auto binned");assertOnXYAxisLabels({@@ -277,9 +277,9 @@ describe("scenarios > binning > from a saved QB question with explicit joins", (yLabel: "Count",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("170° W");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("160° W");H.chartPathWithFillColor("#509EE3");diff --git a/e2e/test/scenarios/binning/qb-implicit-joins.cy.spec.js b/e2e/test/scenarios/binning/qb-implicit-joins.cy.spec.jsindex de8fd3faebd..c8d04b3e4a3 100644--- a/e2e/test/scenarios/binning/qb-implicit-joins.cy.spec.js+++ b/e2e/test/scenarios/binning/qb-implicit-joins.cy.spec.js@@ -35,7 +35,7 @@ describe("scenarios > binning > from a saved QB question using implicit joins",// Make sure time series assertQueryBuilderState works as wellcy.findByTestId("timeseries-bucket-button").contains("Year").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Month").click();cy.get("[data-testid=cell-data]")@@ -74,16 +74,16 @@ describe("scenarios > binning > from a saved QB question using implicit joins",beforeEach(() => {cy.visit(`/question/${ORDERS_QUESTION_ID}/notebook`);H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();// Click "Order" accordion to collapse it and expose the other tablesH.popover().findByText("Orders").click();});it("should work for time series", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User").click();cy.findByPlaceholderText("Find...").type("birth");@@ -101,7 +101,7 @@ describe("scenarios > binning > from a saved QB question using implicit joins",// Make sure time series assertQueryBuilderStateter works as wellcy.findByTestId("timeseries-bucket-button").contains("Year").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Month").click();cy.get("[data-testid=cell-data]")@@ -110,7 +110,7 @@ describe("scenarios > binning > from a saved QB question using implicit joins",});it("should work for number", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product").click();H.changeBinningForDimension({@@ -127,7 +127,7 @@ describe("scenarios > binning > from a saved QB question using implicit joins",});it("should work for longitude", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User").click();cy.findByPlaceholderText("Find...").type("longitude");diff --git a/e2e/test/scenarios/binning/qb-regular-table.cy.spec.js b/e2e/test/scenarios/binning/qb-regular-table.cy.spec.jsindex 16ae8e2a190..7b17f4dae11 100644--- a/e2e/test/scenarios/binning/qb-regular-table.cy.spec.js+++ b/e2e/test/scenarios/binning/qb-regular-table.cy.spec.js@@ -21,7 +21,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Total: 50 bins");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("70");});@@ -36,7 +36,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Created At: Quarter");H.cartesianChartCircle();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q1 2023");});@@ -51,7 +51,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Longitude: 20°");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("180° W");});});@@ -69,7 +69,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Total: 50 bins");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("70");});@@ -85,7 +85,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Created At: Quarter");H.cartesianChartCircle();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q1 2023");});@@ -101,7 +101,7 @@ describe("scenarios > binning > binning options", () => {getTitle("Count by Longitude: 20°");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("180° W");});});@@ -110,39 +110,39 @@ describe("scenarios > binning > binning options", () => {it("should work for number", () => {H.openTable({ table: ORDERS_ID });H.tableHeaderClick("Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();getTitle("Count by Total: Auto binned");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("60");});it("should work for time series", () => {H.openTable({ table: ORDERS_ID });H.tableHeaderClick("Created At");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();getTitle("Count by Created At: Month");H.cartesianChartCircle();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("January 2023");});it("should work for longitude/latitude", () => {H.openTable({ table: PEOPLE_ID });H.tableHeaderClick("Longitude");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();getTitle("Count by Longitude: Auto binned");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("170° W");});});diff --git a/e2e/test/scenarios/binning/sql.cy.spec.js b/e2e/test/scenarios/binning/sql.cy.spec.jsindex 86e21a34ee9..17d45fb3bf6 100644--- a/e2e/test/scenarios/binning/sql.cy.spec.js+++ b/e2e/test/scenarios/binning/sql.cy.spec.js@@ -59,7 +59,7 @@ describe("scenarios > binning > from a saved sql question", () => {waitAndAssertOnRequest("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by CREATED_AT: Year");H.cartesianChartCircle();});@@ -73,7 +73,7 @@ describe("scenarios > binning > from a saved sql question", () => {waitAndAssertOnRequest("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by TOTAL: 50 bins");H.chartPathWithFillColor("#509EE3");});@@ -87,7 +87,7 @@ describe("scenarios > binning > from a saved sql question", () => {waitAndAssertOnRequest("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by LONGITUDE: 10°");H.chartPathWithFillColor("#509EE3");});@@ -108,9 +108,9 @@ describe("scenarios > binning > from a saved sql question", () => {},{ mode: "notebook" },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Summarize").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();});@@ -121,7 +121,7 @@ describe("scenarios > binning > from a saved sql question", () => {toBinning: "Year",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by CREATED_AT: Year");H.visualize((response) => {@@ -138,7 +138,7 @@ describe("scenarios > binning > from a saved sql question", () => {toBinning: "50 bins",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by TOTAL: 50 bins");H.visualize((response) => {@@ -155,7 +155,7 @@ describe("scenarios > binning > from a saved sql question", () => {toBinning: "Bin every 10 degrees",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by LONGITUDE: 10°");H.visualize((response) => {@@ -177,46 +177,46 @@ describe("scenarios > binning > from a saved sql question", () => {it("should work for time series", () => {H.tableHeaderClick("CREATED_AT");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();assertOnXYAxisLabels({ xLabel: "CREATED_AT", yLabel: "Count" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by CREATED_AT: Month");H.cartesianChartCircle();// Open a popover with bucket options from the time series footercy.findByTestId("timeseries-bucket-button").contains("Month").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quarter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by CREATED_AT: Quarter");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q1 2023");});it("should work for number", () => {H.tableHeaderClick("TOTAL");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();assertOnXYAxisLabels({ xLabel: "TOTAL", yLabel: "Count" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by TOTAL: Auto binned");H.chartPathWithFillColor("#509EE3");});it("should work for longitude", () => {H.tableHeaderClick("LONGITUDE");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();assertOnXYAxisLabels({ xLabel: "LONGITUDE", yLabel: "Count" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by LONGITUDE: Auto binned");H.chartPathWithFillColor("#509EE3");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("170° W");});});diff --git a/e2e/test/scenarios/collections/collection-pinned-overview.cy.spec.js b/e2e/test/scenarios/collections/collection-pinned-overview.cy.spec.jsindex 8d01cbe05fe..56f19228a4c 100644--- a/e2e/test/scenarios/collections/collection-pinned-overview.cy.spec.js+++ b/e2e/test/scenarios/collections/collection-pinned-overview.cy.spec.js@@ -156,7 +156,7 @@ describe("scenarios > collection pinned items overview", () => {H.openPinnedItemMenu(DASHBOARD_NAME);H.popover().findByText("Move").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`Move "${DASHBOARD_NAME}"?`).should("be.visible");});@@ -169,7 +169,7 @@ describe("scenarios > collection pinned items overview", () => {H.openPinnedItemMenu(DASHBOARD_NAME);H.popover().findByText("Duplicate").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`Duplicate "${DASHBOARD_NAME}" and its questions`).should("be.visible",);@@ -186,7 +186,7 @@ describe("scenarios > collection pinned items overview", () => {cy.wait("@getPinnedItems");H.getPinnedSection().should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(DASHBOARD_NAME).should("not.exist");});diff --git a/e2e/test/scenarios/collections/collections.cy.spec.js b/e2e/test/scenarios/collections/collections.cy.spec.jsindex 9b9068e49d1..ca52790462d 100644--- a/e2e/test/scenarios/collections/collections.cy.spec.js+++ b/e2e/test/scenarios/collections/collections.cy.spec.js@@ -233,7 +233,7 @@ describe("scenarios > collection defaults", () => {});// 2. Ensure we show the helpful tooltip with the full (long) collection name- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Fifth collection with a very long name").realHover();cy.findByRole("tooltip", {name: /Fifth collection with a very long name/,@@ -355,7 +355,7 @@ describe("scenarios > collection defaults", () => {},);visitRootCollection();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("[email protected]").trigger("mouseenter");cy.findByRole("tooltip").should("not.exist");});@@ -379,7 +379,7 @@ describe("scenarios > collection defaults", () => {},);visitRootCollection();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("[email protected]").trigger("mouseenter",);@@ -487,7 +487,7 @@ describe("scenarios > collection defaults", () => {H.createNativeQuestion(questionDetails);visitRootCollection();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");});@@ -496,20 +496,20 @@ describe("scenarios > collection defaults", () => {H.visitCollection(FIRST_COLLECTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").as("dragSubject");H.navigationSidebar().findByText("Our analytics").as("dropTarget");H.dragAndDrop("dragSubject", "dropTarget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Moved question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("not.exist");visitRootCollection();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");});@@ -564,16 +564,16 @@ describe("scenarios > collection defaults", () => {// Even if user tries to navigate directly to the root collection, we have to make sure its content is not showncy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You don't have permissions to do that.");});it("should be able to choose a child collection when saving a question (metabase#14052)", () => {H.openOrdersTable();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();// Click to choose which collection should this question be saved to- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(revokedUsersPersonalCollectionName).click();H.pickEntity({ path: [revokedUsersPersonalCollectionName] });H.pickEntity({ path: ["Collections", "Child"] });@@ -711,7 +711,7 @@ describe("scenarios > collection defaults", () => {// Select oneselectItemUsingCheckbox("Orders");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1 item selected").should("be.visible");cy.icon("dash").should("exist");cy.icon("check").should("exist");@@ -725,7 +725,7 @@ describe("scenarios > collection defaults", () => {cy.findByLabelText("Select all items").click();cy.icon("check").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/item(s)? selected/).should("not.exist");});@@ -734,16 +734,16 @@ describe("scenarios > collection defaults", () => {collection_id: ADMIN_PERSONAL_COLLECTION_ID,});cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Your personal collection").click();selectItemUsingCheckbox("Orders");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1 item selected").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/item(s)? selected/).should("not.exist");});});@@ -758,7 +758,7 @@ describe("scenarios > collection defaults", () => {.button("Move to trash").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("not.exist");cy.findByTestId("toast-card").should("not.exist");});@@ -776,21 +776,21 @@ describe("scenarios > collection defaults", () => {cy.button("Move").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("not.exist");cy.findByTestId("toast-card").should("not.exist");// Check that items were actually movedH.navigationSidebar().findByText("First collection").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();H.navigationSidebar().findByText("Our analytics").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").should("not.exist");});@@ -995,7 +995,7 @@ describe("scenarios > collection items listing", () => {function assertCollectionItemsOrder(testId, names) {for (let index = 0; index < names.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId(testId).eq(index).should("have.text", names[index]);}}@@ -1067,7 +1067,7 @@ describe("scenarios > collection items listing", () => {visitRootCollection();// First page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("collection-entry").should("have.length", PAGE_SIZE);@@ -1076,7 +1076,7 @@ describe("scenarios > collection items listing", () => {cy.wait("@getCollectionItems");// Second page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${PAGE_SIZE + 1} - ${TOTAL_ITEMS}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("collection-entry").should(@@ -1088,7 +1088,7 @@ describe("scenarios > collection items listing", () => {cy.findByLabelText("Previous page").click();// First page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("collection-entry").should("have.length", PAGE_SIZE);@@ -1259,7 +1259,7 @@ describe("scenarios > collection items listing", () => {visitRootCollection();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);cy.findByLabelText("Next page").click();@@ -1268,7 +1268,7 @@ describe("scenarios > collection items listing", () => {toggleSortingFor(/Last edited at/i);cy.wait("@getCollectionItems");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);});});diff --git a/e2e/test/scenarios/collections/permissions.cy.spec.js b/e2e/test/scenarios/collections/permissions.cy.spec.jsindex 460e0ecb16c..67fb5feeb5c 100644--- a/e2e/test/scenarios/collections/permissions.cy.spec.js+++ b/e2e/test/scenarios/collections/permissions.cy.spec.js@@ -38,7 +38,7 @@ describe("collection permissions", () => {H.appBar().within(() => {cy.icon("add").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Dashboard").click();cy.findByLabelText(/Which collection/).findByText("Second collection",@@ -48,7 +48,7 @@ describe("collection permissions", () => {onlyOn(user === "admin", () => {it("should offer to save dashboard to root collection from a dashboard page (metabase#16832)", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").click();H.appBar().within(() => {cy.icon("add").click();@@ -137,7 +137,7 @@ describe("collection permissions", () => {cy.findByText("Trash").click();});cy.location("pathname").should("eq", "/trash");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");});});@@ -146,7 +146,7 @@ describe("collection permissions", () => {it("shouldn't be able to archive/edit root or personal collection", () => {cy.visit("/collection/root");cy.icon("edit").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Your personal collection").click();cy.icon("edit").should("not.exist");});@@ -168,7 +168,7 @@ describe("collection permissions", () => {H.openCollectionMenu();H.popover().within(() =>- // eslint-disable-next-line no-unscoped-text-selectors -- linter erroring for no reason+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- linter erroring for no reasoncy.findByText("Move to trash").click(),);H.modal().findByText("Move to trash").click();@@ -184,14 +184,14 @@ describe("collection permissions", () => {});// While we're here, we can test unarchiving the collection as well- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Trashed collection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@editCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sorry, you don’t have permission to see that.",).should("not.exist");@@ -297,7 +297,7 @@ describe("collection permissions", () => {it("should not show pins or a helper text (metabase#20043)", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");cy.icon("pin").should("not.exist");});@@ -316,7 +316,7 @@ describe("collection permissions", () => {it("should not be able to use bulk actions on collection items (metabase#16490)", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").closest("tr").within(() => {@@ -324,7 +324,7 @@ describe("collection permissions", () => {cy.findByRole("checkbox").should("not.exist");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").closest("tr").within(() => {@@ -338,7 +338,7 @@ describe("collection permissions", () => {const { first_name, last_name } = USERS[user];cy.visit(route);cy.icon("add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Dashboard").click();// Coming from the root collection, the initial offered collection will be "Our analytics" (read-only access)@@ -374,7 +374,7 @@ describe("collection permissions", () => {H.startNewNativeQuestion();H.NativeEditor.type("select * from people");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByLabelText(/Where do you want to save this/).findByText(diff --git a/e2e/test/scenarios/collections/personal-collections.cy.spec.js b/e2e/test/scenarios/collections/personal-collections.cy.spec.jsindex 288e858f63f..4d285fcf012 100644--- a/e2e/test/scenarios/collections/personal-collections.cy.spec.js+++ b/e2e/test/scenarios/collections/personal-collections.cy.spec.js@@ -164,7 +164,7 @@ describe("personal collections", () => {});cy.visit(`/collection/${NO_DATA_PERSONAL_COLLECTION_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo");});});diff --git a/e2e/test/scenarios/collections/revision-history.cy.spec.js b/e2e/test/scenarios/collections/revision-history.cy.spec.jsindex 8e16cb38617..8b2bfa4b19b 100644--- a/e2e/test/scenarios/collections/revision-history.cy.spec.js+++ b/e2e/test/scenarios/collections/revision-history.cy.spec.js@@ -37,7 +37,7 @@ describe("revision history", () => {openRevisionHistory();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/created this/);cy.findAllByText("Revert").should("not.exist");@@ -138,7 +138,7 @@ describe("revision history", () => {expect(body.cause).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/^Orders$/);});@@ -151,7 +151,7 @@ describe("revision history", () => {cy.findByRole("tab", { name: "History" }).click();// Last revert is the original state- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("question-revert-button").last().click();cy.wait("@revert").then(({ response: { statusCode, body } }) => {@@ -159,7 +159,7 @@ describe("revision history", () => {expect(body.cause).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/^Orders$/);});});@@ -191,7 +191,7 @@ describe("revision history", () => {});function clickRevert(event_name, index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByLabelText(event_name).eq(index).click();}diff --git a/e2e/test/scenarios/collections/trash.cy.spec.js b/e2e/test/scenarios/collections/trash.cy.spec.jsindex 45e50e5766a..c0e4d68bc8a 100644--- a/e2e/test/scenarios/collections/trash.cy.spec.js+++ b/e2e/test/scenarios/collections/trash.cy.spec.js@@ -29,7 +29,7 @@ describe("scenarios > collections > trash", () => {cy.log("should show trash at bottom of the side navbar");H.navigationSidebar().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("sidebar-collection-link-root").last().as("sidebar-trash-link")diff --git a/e2e/test/scenarios/collections/uploads.cy.spec.js b/e2e/test/scenarios/collections/uploads.cy.spec.jsindex 6912ad7dd3f..3f4f0fa7f96 100644--- a/e2e/test/scenarios/collections/uploads.cy.spec.js+++ b/e2e/test/scenarios/collections/uploads.cy.spec.js@@ -380,7 +380,7 @@ describe("Upload Table Cleanup/Management", { tags: "@external" }, () => {// multiple deletecy.findAllByRole("checkbox").first().click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("checkbox").last().click();});@@ -459,7 +459,7 @@ function uploadToExisting({cy.wait(uploadEndpoints[uploadMode]);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("status").last().findByText(/Data (added|replaced)/i, {diff --git a/e2e/test/scenarios/custom-column/cc-shortcuts-combine.cy.spec.ts b/e2e/test/scenarios/custom-column/cc-shortcuts-combine.cy.spec.tsindex acf5ff7a970..ae2c13e115c 100644--- a/e2e/test/scenarios/custom-column/cc-shortcuts-combine.cy.spec.ts+++ b/e2e/test/scenarios/custom-column/cc-shortcuts-combine.cy.spec.ts@@ -79,7 +79,7 @@ describe("scenarios > question > custom column > expression shortcuts > combine""123.45678901234567 123.45678901234567 [email protected]",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByLabelText("Remove column").last().click();cy.findByTestId("combine-example").should(@@ -161,11 +161,11 @@ function selectCombineColumns() {function selectColumn(index: number, table: string, name?: string) {H.expressionEditorWidget().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("column-input").eq(index).click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {diff --git a/e2e/test/scenarios/custom-column/cc-shortcuts.cy.spec.ts b/e2e/test/scenarios/custom-column/cc-shortcuts.cy.spec.tsindex 8b102d4729f..5401a8536a9 100644--- a/e2e/test/scenarios/custom-column/cc-shortcuts.cy.spec.ts+++ b/e2e/test/scenarios/custom-column/cc-shortcuts.cy.spec.ts@@ -14,11 +14,11 @@ function selectCombineColumns() {function selectColumn(index: number, table: string, name?: string) {H.expressionEditorWidget().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("column-input").eq(index).click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -157,7 +157,7 @@ describe("scenarios > question > custom column > expression shortcuts > extract"H.expressionEditorWidget().button("Done").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("notebook-cell-item").last().click();selectExtractColumn();@@ -302,7 +302,7 @@ describe("scenarios > question > custom column > expression shortcuts > combine""123.45678901234567 123.45678901234567 [email protected]",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByLabelText("Remove column").last().click();cy.findByTestId("combine-example").should(diff --git a/e2e/test/scenarios/custom-column/custom-column-reproductions.cy.spec.js b/e2e/test/scenarios/custom-column/custom-column-reproductions.cy.spec.jsindex 87d5c3609fc..c26deb91a8c 100644--- a/e2e/test/scenarios/custom-column/custom-column-reproductions.cy.spec.js+++ b/e2e/test/scenarios/custom-column/custom-column-reproductions.cy.spec.js@@ -55,7 +55,7 @@ describe("issue 13289", () => {H.openOrdersTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();// Add custom column that will be used later in summarize (group by)@@ -65,15 +65,15 @@ describe("issue 13289", () => {it("should allow 'zoom in' drill-through when grouped by custom column (metabase#13289)", () => {H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().findByText(CC_NAME).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("add").last().click();H.popover().within(() => {@@ -88,14 +88,14 @@ describe("issue 13289", () => {.click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See this month by week").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("There was a problem with your question").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At is Sep 1–30, 2022");});});@@ -154,7 +154,7 @@ describe(cy.signInAsAdmin();H.startNewQuestion();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(PG_DB_NAME).should("be.visible").click();cy.findByTextEnsureVisible("People").click();});@@ -208,9 +208,9 @@ describe("issue 14843", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${CC_NAME} is not equal to 3`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rye").should("not.exist");});});@@ -241,7 +241,7 @@ describe("issue 18069", () => {it("should not allow choosing text fields for SUM (metabase#18069)", () => {H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of ...").click();H.popover().within(() => {@@ -261,7 +261,7 @@ describe("issue 18069", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,041.45");});});@@ -323,10 +323,10 @@ describe("issue 18747", () => {addNumberParameterToDashboard();mapParameterToCustomColumn();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();// wait for saving to finish- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("You're editing this dashboard.").should("not.exist");addValueToParameterFilter();@@ -369,10 +369,10 @@ describe("issue 18814", () => {H.openNotebook();cy.icon("sum").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().contains(ccName).click();@@ -626,11 +626,11 @@ describe("issue 21513", () => {H.summarize({ mode: "notebook" });H.popover().findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().findByText("Category").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({formula: "[Count] * 2",@@ -683,9 +683,9 @@ describe("issue 23862", () => {);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Small");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("-36.53");});});@@ -716,13 +716,13 @@ describe("issue 24922", () => {it("should allow segments in case custom expressions (metabase#24922)", () => {H.openOrdersTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails(customColumnDetails);cy.button("Done").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("CustomColumn").should("be.visible");});});@@ -786,7 +786,7 @@ describe("issue 25189", { tags: "@skip" }, () => {});cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No results!");// 3. We shouldn't see duplication in the breakout fields@@ -932,7 +932,7 @@ describe("issue 42949", { tags: "@skip" }, () => {cy.button("Add column").click();H.popover().findByText("Combine columns").click();H.popover().findAllByTestId("column-input").eq(0).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -979,7 +979,7 @@ describe("issue 42949", { tags: "@skip" }, () => {H.popover().findByText("Extract part of column").should("not.exist");H.popover().findByText("Combine columns").click();H.popover().findAllByTestId("column-input").eq(0).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("N").should("be.visible");});@@ -1008,7 +1008,7 @@ describe("issue 42949", { tags: "@skip" }, () => {H.popover().findByText("Extract part of column").should("not.exist");H.popover().findByText("Combine columns").click();H.popover().findAllByTestId("column-input").eq(0).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("'abc'").should("be.visible");});});diff --git a/e2e/test/scenarios/custom-column/custom-column.cy.spec.js b/e2e/test/scenarios/custom-column/custom-column.cy.spec.jsindex 839a7dd7b71..5afb8096b3f 100644--- a/e2e/test/scenarios/custom-column/custom-column.cy.spec.js+++ b/e2e/test/scenarios/custom-column/custom-column.cy.spec.js@@ -55,7 +55,7 @@ describe("scenarios > question > custom column", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("There was a problem with your question").should("not.exist");cy.findByTestId("query-visualization-root").contains("Math");});@@ -179,7 +179,7 @@ describe("scenarios > question > custom column", () => {H.summarize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Group by").parent().findByText("Math")@@ -227,7 +227,7 @@ describe("scenarios > question > custom column", () => {// TODO: There isn't a single unique parent that can be used to scope this icon within// (a good candidate would be `.NotebookCell`)- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("add").last() // This is brittle..click();@@ -237,14 +237,14 @@ describe("scenarios > question > custom column", () => {cy.findByText("Total").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At").click();// Add custom column based on previous aggregatesconst columnName = "MegaTotal";- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({@@ -255,7 +255,7 @@ describe("scenarios > question > custom column", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("There was a problem with your question").should("not.exist");// This is a pre-save state of the question but the column name should appear// both in tabular and graph views (regardless of which one is currently selected)@@ -265,7 +265,7 @@ describe("scenarios > question > custom column", () => {it("should not return same results for columns with the same name (metabase#12649)", () => {H.openOrdersTable({ mode: "notebook" });// join with Products- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Join data").click();H.miniPickerBrowseAll().click();@@ -275,7 +275,7 @@ describe("scenarios > question > custom column", () => {});// add custom column- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({ formula: "1 + 1", name: "x" });cy.button("Done").click();@@ -323,7 +323,7 @@ describe("scenarios > question > custom column", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CC_NAME);});@@ -359,7 +359,7 @@ describe("scenarios > question > custom column", () => {cy.log("Regression since v0.37.1 - it works on v0.37.0");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(`Sum of ${CC_NAME}`);H.cartesianChartCircle().should("have.length.of.at.least", 8);});@@ -382,11 +382,11 @@ describe("scenarios > question > custom column", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("13634");cy.log("Reported failing in v0.34.3, v0.35.4, v0.36.8.2, v0.37.0.2");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo Bar");cy.findAllByText("57,911");});@@ -418,13 +418,13 @@ describe("scenarios > question > custom column", () => {.should("have.text", "1").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Subtotal is greater than 0/i).parent().find(".Icon-close").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CC_NAME);});@@ -447,9 +447,9 @@ describe("scenarios > question > custom column", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CC_NAME);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Gizmo2");});@@ -535,9 +535,9 @@ describe("scenarios > question > custom column", () => {{ callback: (xhr) => expect(xhr.response.body.error).not.to.exist },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CC_NAME);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});@@ -607,7 +607,7 @@ describe("scenarios > question > custom column", () => {});cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 487 rows").should("be.visible");});@@ -1180,7 +1180,7 @@ describe("scenarios > question > custom column > error feedback", () => {cy.signInAsAdmin();H.openProductsTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();});@@ -1190,7 +1190,7 @@ describe("scenarios > question > custom column > error feedback", () => {name: "Non-existent",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/^Unknown column: abcdef/i);});@@ -1200,7 +1200,7 @@ describe("scenarios > question > custom column > error feedback", () => {name: "BadSubstring",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/positive integer/i);});});@@ -1215,7 +1215,7 @@ describe("scenarios > question > custom column > expression editor", () => {cy.viewport(1280, 800);H.openOrdersTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({@@ -1236,7 +1236,7 @@ describe("scenarios > question > custom column > expression editor", () => {it("should not erase Custom column formula and Custom column name when expression is incomplete (metabase#16126)", () => {H.CustomExpressionEditor.type("{movetoend}{backspace}").blur();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Expected expression");cy.button("Done").should("be.disabled");});@@ -1254,7 +1254,7 @@ describe("scenarios > question > custom column > help text", () => {cy.signInAsAdmin();H.openProductsTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();});@@ -1420,7 +1420,7 @@ describe("scenarios > question > custom column > exiting the editor", () => {cy.signInAsAdmin();H.openProductsTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();});@@ -1553,13 +1553,13 @@ describe("scenarios > question > custom column > path", () => {});function assertTableData({ title, value }) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractive().findAllByTestId("header-cell").last().should("have.text", title);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractiveBody().findAllByTestId("cell-data").last()@@ -1747,13 +1747,13 @@ describe("scenarios > question > custom column > splitPart", () => {});function assertTableData({ title, value }) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractive().findAllByTestId("header-cell").last().should("have.text", title);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractiveBody().findAllByTestId("cell-data").last()diff --git a/e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js b/e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.jsindex e7837fe75ed..a08a05387cf 100644--- a/e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js+++ b/e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js@@ -2124,7 +2124,7 @@ describe("scenarios > dashboard > dashboard cards > click behavior", () => {H.popover().findByText("User → Longitude: 10°").click();// 1st stage - Products (implicit join with Reviews)- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetClickMapping("Product → Vendor").last().click();H.popover().findByText("Product → Category").click();@@ -2141,7 +2141,7 @@ describe("scenarios > dashboard > dashboard cards > click behavior", () => {H.popover().findByText("ID").click();// 2nd stage - Aggregations & breakouts- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetClickMapping("Count").last().click();H.popover().findByText("User → Longitude: 10°").click();@@ -2754,7 +2754,7 @@ describe("scenarios > dashboard > dashboard cards > click behavior", () => {});const clickLineChartPoint = () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(POINT_INDEX)/**@@ -2934,7 +2934,7 @@ const testChangingBackToDefaultBehavior = () => {};const getTableCell = (index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByRole("row").eq(POINT_INDEX)@@ -3008,7 +3008,7 @@ function getClickMapping(columnName) {function verifyAvailableClickTargetColumns(columns) {cy.get("aside").within(() => {for (let index = 0; index < columns.length; ++index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("click-target-column").eq(index).should("have.text", columns[index]);diff --git a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.jsindex 968d1597c8c..84e19f47ea6 100644--- a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js+++ b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js@@ -93,9 +93,9 @@ describe("issue 15993", () => {// Drill-throughcy.findAllByRole("gridcell").contains("0").realClick();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("117.03").should("not.exist"); // Total for the order in which quantity wasn't 0- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quantity is equal to 0");const getVisualizationSettings = (targetId) => ({@@ -473,7 +473,7 @@ describe("issue 17160", () => {cy.url().should("include", "/dashboard");cy.location("search").should("eq", "?category=Doohickey&category=Gadget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(TARGET_DASHBOARD_NAME);assertMultipleValuesFilterState();@@ -503,7 +503,7 @@ describe("issue 17160", () => {cy.url().should("include", "/public/dashboard");cy.location("search").should("eq", "?category=Doohickey&category=Gadget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(TARGET_DASHBOARD_NAME);assertMultipleValuesFilterState();@@ -541,7 +541,7 @@ describe("issue 18454", () => {cy.findByTestId("dashcard-container").within(() => {cy.icon("info").trigger("mouseenter", { force: true });});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(CARD_DESCRIPTION);});});@@ -1386,7 +1386,7 @@ describe("issue 48878", () => {cy.button("Save").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.modal().last().within(() => {diff --git a/e2e/test/scenarios/dashboard-cards/dashboard-drill.cy.spec.js b/e2e/test/scenarios/dashboard-cards/dashboard-drill.cy.spec.jsindex 74dba7bc7b9..471b28aed5f 100644--- a/e2e/test/scenarios/dashboard-cards/dashboard-drill.cy.spec.js+++ b/e2e/test/scenarios/dashboard-cards/dashboard-drill.cy.spec.js@@ -45,7 +45,7 @@ describe("scenarios > dashboard > dashboard drill", () => {cy.get("input").first().type("/foo/{{my_number}}/{{my_param}}", {parseSpecialCharSequences: false,});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("input").last().type("column value: {{my_number}}", {@@ -111,7 +111,7 @@ describe("scenarios > dashboard > dashboard drill", () => {},);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Click to find out which state does Rye belong to.").click();cy.log("Reported failing on v0.37.2");@@ -226,29 +226,29 @@ describe("scenarios > dashboard > dashboard drill", () => {});// configure clicks on "MY_NUMBER to update the param- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("On-click behavior for each column").parent().parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("MY_NUMBER").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Go to a custom destination").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Link to").parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("Dashboard").click());H.entityPickerModal().within(() => {cy.findByRole("tab", { name: /Dashboards/ }).click();cy.findByText("end dash").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Available filters").parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("My Param").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("MY_STRING").click());// set the text template@@ -256,11 +256,11 @@ describe("scenarios > dashboard > dashboard drill", () => {"text: {{my_string}}",{ parseSpecialCharSequences: false },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();// click on table value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("text: foo").click();// check that param was set to "foo"@@ -288,7 +288,7 @@ describe("scenarios > dashboard > dashboard drill", () => {cy.get("input").first().type(`/dashboard/${dashboardId}?my_param=Aaron Hand`, { delay: 0 });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("input").last().type("Click behavior", { delay: 0 }).blur();cy.button("Done").click();});@@ -315,34 +315,34 @@ describe("scenarios > dashboard > dashboard drill", () => {});// configure clicks on "MY_NUMBER to update the param- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("On-click behavior for each column").parent().parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("MY_NUMBER").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Update a dashboard filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick one or more filters to update").parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("My Param").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("MY_STRING").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();// click on table value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("111").click();// check that param was set to "foo"cy.location("search").should("eq", "?my_param=foo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("My Param").parent()- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage.within(() => cy.findByText("foo"));});@@ -544,9 +544,9 @@ describe("scenarios > dashboard > dashboard drill", () => {H.visitDashboard(ORDERS_DASHBOARD_ID);// Product ID in the first row (query fails for User ID as well)- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("105").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("View details").click();cy.log("Reported on v0.29.3");@@ -712,7 +712,7 @@ describe("scenarios > dashboard > dashboard drill", () => {);// formatting works, so we see "USD" in the table- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("USD 111.00").click();cy.location("pathname").should("eq", "/it/worked");});@@ -999,7 +999,7 @@ describe("scenarios > dashboard > dashboard drill", () => {function postDrillAssertion(filterName) {cy.findByTestId("qb-filters-panel").findByText(filterName).click();H.popover({ testId: "filter-picker-dropdown" }).within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("combobox").last().parent()diff --git a/e2e/test/scenarios/dashboard-filters-2/dashboard-filters-misc.cy.spec.ts b/e2e/test/scenarios/dashboard-filters-2/dashboard-filters-misc.cy.spec.tsindex ef2004aeab4..d674ddc3c06 100644--- a/e2e/test/scenarios/dashboard-filters-2/dashboard-filters-misc.cy.spec.ts+++ b/e2e/test/scenarios/dashboard-filters-2/dashboard-filters-misc.cy.spec.ts@@ -68,7 +68,7 @@ describe("scenarios > dashboard > filters > query stages + temporal unit paramet.findByLabelText("Temporal bucket").realHover().click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Week").click();H.getNotebookStep("summarize").findByTestId("breakout-step")@@ -80,7 +80,7 @@ describe("scenarios > dashboard > filters > query stages + temporal unit parametcy.findByText("Category").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().button("Summarize").click();H.popover().findByText("Count of rows").click();H.getNotebookStep("summarize", { stage: 1 })diff --git a/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts b/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.tsindex 63e5f25c6b6..4fd81366eab 100644--- a/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts+++ b/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts@@ -711,7 +711,7 @@ export function getPopoverItem(name: string, index = 0) {* Without scrollIntoView() the popover may scroll automatically to a different* place when clicking the item (unclear why).*/- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByText(name).eq(index).scrollIntoView();}@@ -836,7 +836,7 @@ export function verifyDashcardCellValues({for (let valueIndex = 0; valueIndex < values.length; ++valueIndex) {const value = values[valueIndex];- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getDashboardCard(dashcardIndex).findByRole("row").findAllByRole("gridcell")@@ -852,7 +852,7 @@ export function verifyDashcardCellValues({for (let valueIndex = 0; valueIndex < values.length; ++valueIndex) {const value = values[valueIndex];- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("gridcell").eq(valueIndex).should("have.text", value);}}diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-chained-filters.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-chained-filters.cy.spec.jsindex 55aa001a136..6d118258698 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-chained-filters.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-chained-filters.cy.spec.js@@ -114,7 +114,7 @@ describe("scenarios > dashboard > chained filter", () => {H.filterWidget().contains("AK").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -148,7 +148,7 @@ describe("scenarios > dashboard > chained filter", () => {}H.filterWidget().contains("GA").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filter-data-permissions.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filter-data-permissions.cy.spec.jsindex 4818e5d7426..0033285a8b4 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filter-data-permissions.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filter-data-permissions.cy.spec.js@@ -43,11 +43,11 @@ describe("support > permissions (metabase#8472)", () => {"Address",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Orders in a dashboard").click();});diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-auto-wiring.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-auto-wiring.cy.spec.jsindex 2dacfae4950..faca607116c 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-auto-wiring.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-auto-wiring.cy.spec.js@@ -801,7 +801,7 @@ function getTableCell(columnName, rowIndex) {const columnHeaderIndex = $columnHeaders.toArray().findIndex(($columnHeader) => $columnHeader.textContent === columnName);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("row").eq(rowIndex).findAllByTestId("cell-data")diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-date.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-date.cy.spec.jsindex 5e8c3a8ca01..f78cb01fba5 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-date.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-date.cy.spec.js@@ -35,7 +35,7 @@ describe("scenarios > dashboard > filters > date", () => {// Go through each of the filters and make sure they work individuallyObject.entries(DASHBOARD_DATE_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();dateFilterSelector({@@ -58,7 +58,7 @@ describe("scenarios > dashboard > filters > date", () => {// make sure the default filter works for just one of the available optionsit("should work when set as the default filter", () => {H.setFilter("Date picker", "Month and Year");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();DateFilter.setMonthAndYear({@@ -66,7 +66,7 @@ describe("scenarios > dashboard > filters > date", () => {year: "2022",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Created At").first().click();@@ -78,10 +78,10 @@ describe("scenarios > dashboard > filters > date", () => {});// Make sure we can override the default value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("November 2022").click();H.popover().contains("Jun").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("33.9");});@@ -132,25 +132,25 @@ describe("scenarios > dashboard > filters > date", () => {H.setFilter("Date picker", "All Options");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No default").click();// click on Relative date range…, to open the relative date filter type tabs- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Relative date range…").click();// choose Next, under which the new options should be available- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Next").click();// click on Days (the default value), which should open the resolution dropdowncy.findByDisplayValue("days").click();// Hours should appear in the selection box (don't click it)- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("hours");// Minutes should appear in the selection box; click it- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("minutes").click();// also check the "Include this minute" checkbox// which is actually "Include" followed by "this minute" wrapped in <strong>, so has to be clicked this way- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Include this minute").click();});@@ -168,7 +168,7 @@ describe("scenarios > dashboard > filters > date", () => {H.popover().icon("calendar").click(); // "Time" -> "All Options"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sélectionner...").click(); // "Select…"H.popover().contains("Created At").first().click();@@ -177,16 +177,16 @@ describe("scenarios > dashboard > filters > date", () => {editBarText: "Vous êtes en train d'éditer ce tableau de bord.",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Date").click(); // "Date" - it's the same word in English and in French- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Exclure...").click(); // "Exclude…"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Mois de l'année...").click(); // "Months of the year…"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("janvier").click(); // "January"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ajouter un filtre").click(); // "Add filter"cy.url().should("match", /\/dashboard\/\d+\?date=exclude-months-Jan/);diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-id.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-id.cy.spec.jsindex f77677c5a6b..e90af2f1be9 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-id.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-id.cy.spec.js@@ -13,7 +13,7 @@ describe("scenarios > dashboard > filters > ID", () => {H.editDashboard();H.setFilter("ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();/**@@ -47,7 +47,7 @@ describe("scenarios > dashboard > filters > ID", () => {});it("when set as the default filter", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetStringFilter("15");@@ -78,7 +78,7 @@ describe("scenarios > dashboard > filters > ID", () => {});it("when set as the default filter", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetStringFilter("4");@@ -114,7 +114,7 @@ describe("scenarios > dashboard > filters > ID", () => {});it("when set as the default filter", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetStringFilter("10");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-location.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-location.cy.spec.jsindex 0aa67b7f76e..6c53c744fc7 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-location.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-location.cy.spec.js@@ -33,7 +33,7 @@ describe("scenarios > dashboard > filters > location", () => {Object.entries(DASHBOARD_LOCATION_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();addWidgetStringFilter(value);@@ -50,11 +50,11 @@ describe("scenarios > dashboard > filters > location", () => {it("should work when set as the default filter", () => {H.setFilter("Location", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("City").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();selectFilterValueFromList("Abbeville");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-nested.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-nested.cy.spec.jsindex c00b98503ba..de2240c13f3 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-nested.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-nested.cy.spec.js@@ -51,7 +51,7 @@ describe("scenarios > dashboard > filters > nested questions", () => {H.editDashboard();H.filterWidget({ isEditing: true, name: filter.name }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();// This part reproduces metabase#13186@@ -74,18 +74,18 @@ describe("scenarios > dashboard > filters > nested questions", () => {cy.button("Add filter").click();cy.wait("@dashcardQuery");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2 selections");H.tableInteractiveBody().findAllByRole("row").should("have.length", 2);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").should("not.exist");cy.reload();cy.wait("@dashcardQuery");cy.location("search").should("eq", "?text=Gizmo&text=Gadget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2 selections");H.editDashboard();@@ -126,10 +126,10 @@ describe("scenarios > dashboard > filters > nested questions", () => {H.setFilter("ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No valid fields").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("ID").click();});diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.jsindex bff1b064f11..3cede8f8e7d 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js@@ -230,7 +230,7 @@ const filterDashboard = ({ isLabeled = false, isDropdown = false } = {}) => {if (isLabeled) {H.popover().first().findByPlaceholderText("Enter a number").type("T");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.popover().first().button("Add filter").click();return;diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number.cy.spec.jsindex 99ab8a0b6fe..e6f72bd9d1a 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number.cy.spec.js@@ -49,7 +49,7 @@ describe("scenarios > dashboard > filters > number", () => {DASHBOARD_NUMBER_FILTERS.forEach(({ operator, value, representativeResult }, index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();addWidgetNumberFilter(value);cy.wait("@dashboardData");@@ -66,7 +66,7 @@ describe("scenarios > dashboard > filters > number", () => {it("should work when set as the default filter", () => {H.setFilter("Number", "Equal to");H.selectDashboardFilter(cy.findByTestId("dashcard"), "Tax");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetNumberFilter("2.07");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts b/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.tsindex 219f427f42d..e6ecfb44db7 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts@@ -1255,7 +1255,7 @@ function addRangeFilter() {filter(label).click();H.popover().findAllByRole("textbox").first().clear().type(firstValue).blur();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().findAllByRole("textbox").last().clear().type(secondValue).blur();H.popover().button("Add filter").click();}@@ -1267,7 +1267,7 @@ function updateRangeFilter() {filter(label).click();H.popover().findAllByRole("textbox").first().clear().type(firstValue).blur();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().findAllByRole("textbox").last().clear().type(secondValue).blur();H.popover().button("Update filter").click();}diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-source.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-source.cy.spec.jsindex 0bcc85f1f54..c530d546627 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-source.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-source.cy.spec.js@@ -512,7 +512,7 @@ function setSearchFilter(label) {H.fieldValuesCombobox().type(label);});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(label).click();H.popover().within(() => {H.fieldValuesValue(0).should("be.visible").should("contain", label);diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-date.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-date.cy.spec.jsindex dde2f839962..cd23bc2784c 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-date.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-date.cy.spec.js@@ -40,7 +40,7 @@ describe("scenarios > dashboard > filters > SQL > date", () => {Object.entries(DASHBOARD_SQL_DATE_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();dateFilterSelector({filterType: filter,@@ -61,14 +61,14 @@ describe("scenarios > dashboard > filters > SQL > date", () => {it("should work when set as the default filter", () => {H.setFilter("Date picker", "Month and Year");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();DateFilter.setMonthAndYear({month: "Oct",year: "2022",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Month and Year").click();H.saveDashboard();@@ -79,10 +79,10 @@ describe("scenarios > dashboard > filters > SQL > date", () => {});// Make sure we can override the default value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("October 2022").click();H.popover().contains("Aug").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Macy Olson");});});diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-id.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-id.cy.spec.jsindex ecdf2725a1e..14d70c6e167 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-id.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-id.cy.spec.js@@ -28,7 +28,7 @@ describe("scenarios > dashboard > filters > SQL > ID", () => {});it("when set as the default filter", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetStringFilter("15");@@ -57,7 +57,7 @@ describe("scenarios > dashboard > filters > SQL > ID", () => {});it("when set as the default filter", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();addWidgetStringFilter("4");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-location.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-location.cy.spec.jsindex 42371542a4f..d0c82be05dc 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-location.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-location.cy.spec.js@@ -43,7 +43,7 @@ describe("scenarios > dashboard > filters > location", () => {Object.entries(DASHBOARD_SQL_LOCATION_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();applyFilterByType(filter, value, { search: true });@@ -60,11 +60,11 @@ describe("scenarios > dashboard > filters > location", () => {it("should work when set as the default filter", () => {H.setFilter("Location", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Is").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();selectFilterValueFromList("Rye", { search: true });diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-number.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-number.cy.spec.jsindex f1a9ef8812a..7cc21c6487d 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-number.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-number.cy.spec.js@@ -41,7 +41,7 @@ describe("scenarios > dashboard > filters > SQL > text/category", () => {Object.entries(DASHBOARD_SQL_NUMBER_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();addWidgetNumberFilter(value);diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-field-filter.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-field-filter.cy.spec.jsindex ffb9fcfa61d..04b8a130716 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-field-filter.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-field-filter.cy.spec.js@@ -135,7 +135,7 @@ describe("scenarios > dashboard > filters > SQL > field filter > required ", ()// Let's make sure the default dashboard filter is respected upon a subsequent visit from the rootcy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Required Filters Dashboard").click();cy.location("search").should("eq", "?category=Widget");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-simple-filter.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-simple-filter.cy.spec.jsindex 76d4b46632b..e785355aa9f 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-simple-filter.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-required-simple-filter.cy.spec.js@@ -86,7 +86,7 @@ describe("scenarios > dashboard > filters > SQL > simple filter > required ", ()// Let's make sure the default dashboard filter is respected upon a subsequent visit from the rootcy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Required Filters Dashboard").click();cy.location("search").should("eq", "?text=Bar");diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-text-category.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-text-category.cy.spec.jsindex 38323c36025..e50179f26c6 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-text-category.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-sql-text-category.cy.spec.js@@ -40,7 +40,7 @@ describe("scenarios > dashboard > filters > SQL > text/category", () => {Object.entries(DASHBOARD_SQL_TEXT_FILTERS).forEach(([filter, { value, representativeResult }], index) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();if (["Is", "Is not"].includes(filter)) {@@ -63,11 +63,11 @@ describe("scenarios > dashboard > filters > SQL > text/category", () => {it("should work when set as the default filter and when that filter is removed (metabase#20493)", () => {H.setFilter("Text or Category", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Is").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();applyFilterByType("Is", "Gizmo");@@ -86,7 +86,7 @@ describe("scenarios > dashboard > filters > SQL > text/category", () => {applyFilterByType("Is", "Doohickey", { buttonLabel: "Update filter" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rustic Paper Wallet").should("not.exist");});});diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.jsindex 1c01d53e954..b715220e3ee 100644--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-text-category.cy.spec.js@@ -80,11 +80,11 @@ describe("scenarios > dashboard > filters > text/category", () => {{ operator, value, representativeResult, single, negativeAssertion },index,) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).click();applyFilterByType(operator, value);waitDashboardCardQuery();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().eq(index).contains(single ? value.replace(/"/g, "") : /\d selections/);@@ -134,18 +134,18 @@ describe("scenarios > dashboard > filters > text/category", () => {it("should work when set as the default filter which (if cleared) should not be preserved on reload (metabase#13960)", () => {H.setFilter("Text or Category", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Source").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Default value").next().click();applyFilterByType("Is", "Organic");// We need to add another filter only to reproduce metabase#13960H.setFilter("ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("User ID").click();diff --git a/e2e/test/scenarios/dashboard-filters/old-parameters.cy.spec.js b/e2e/test/scenarios/dashboard-filters/old-parameters.cy.spec.jsindex 1ea8750e5d4..9c7e3104fc7 100644--- a/e2e/test/scenarios/dashboard-filters/old-parameters.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/old-parameters.cy.spec.js@@ -62,7 +62,7 @@ describe("scenarios > dashboard > OLD parameters", () => {it("should work", () => {cy.findAllByText("Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Category").click();H.popover().within(() => {cy.findByText("Gadget").click();@@ -70,7 +70,7 @@ describe("scenarios > dashboard > OLD parameters", () => {});// verify that the filter is applied- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").should("not.exist");});});@@ -192,7 +192,7 @@ describe("scenarios > dashboard > OLD parameters", () => {it("should work", () => {cy.findAllByText("Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Category").click();H.popover().within(() => {cy.findByText("Gadget").click();@@ -200,7 +200,7 @@ describe("scenarios > dashboard > OLD parameters", () => {});// verify that the filter is applied- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").should("not.exist");});});diff --git a/e2e/test/scenarios/dashboard-filters/parameters.cy.spec.js b/e2e/test/scenarios/dashboard-filters/parameters.cy.spec.jsindex f5262fcecd5..5ecdb8d4502 100644--- a/e2e/test/scenarios/dashboard-filters/parameters.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/parameters.cy.spec.js@@ -58,7 +58,7 @@ describe("scenarios > dashboard > parameters", () => {// add a category filterH.setFilter("Text or Category", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("A single value").click();// connect it to people.name and product.category@@ -77,7 +77,7 @@ describe("scenarios > dashboard > parameters", () => {cy.findByPlaceholderText("Search the list").type("Ga"),);cy.wait("@dashboard");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().contains("Gabrielle Considine");// Continue typing a "d" and you see "Gadget"@@ -86,7 +86,7 @@ describe("scenarios > dashboard > parameters", () => {.within(() => cy.findByPlaceholderText("Search the list").type("d"));cy.wait("@dashboard");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -101,7 +101,7 @@ describe("scenarios > dashboard > parameters", () => {cy.location("search").should("eq", "?text=Gadget");cy.findAllByTestId("dashcard-container").first().should("contain", "0");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("dashcard-container").last().should("contain", "4,939");});@@ -187,15 +187,15 @@ describe("scenarios > dashboard > parameters", () => {},);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(startsWith.name).click();cy.findByPlaceholderText("Enter some text").type("G");// Make sure the dropdown list with values is not populated,// because it makes no sense for non-exact parameter string operators.// See: https://github.com/metabase/metabase/pull/15477- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Gizmo").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Gadget").should("not.exist");cy.button("Add filter").click();@@ -204,16 +204,16 @@ describe("scenarios > dashboard > parameters", () => {"eq",`?${endsWith.slug}=&${startsWith.slug}=G`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("37.65").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(endsWith.name).click();cy.findByPlaceholderText("Enter some text").type("zmo");// Make sure the dropdown list with values is not populated,// because it makes no sense for non-exact parameter string operators.// See: https://github.com/metabase/metabase/pull/15477- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Gizmo").should("not.exist");cy.button("Add filter").click();@@ -222,14 +222,14 @@ describe("scenarios > dashboard > parameters", () => {"eq",`?${endsWith.slug}=zmo&${startsWith.slug}=G`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("52.72").should("not.exist");// Remove filter (metabase#17933)cy.icon("pencil").click();H.filterWidget({ isEditing: true, name: startsWith.name }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Remove").click();cy.location("search").should("eq", `?${endsWith.slug}=zmo`);@@ -468,7 +468,7 @@ describe("scenarios > dashboard > parameters", () => {cy.get("@fetchAllCategories").should("have.been.calledOnce");cy.button("Update filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2 selections").click();// Even after we reopen the dropdown, it shouldn't send additional requests for values (metabase#16103)@@ -481,7 +481,7 @@ describe("scenarios > dashboard > parameters", () => {});cy.button("Update filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2 selections").should("not.exist");H.filterWidget().contains("Widget");@@ -489,7 +489,7 @@ describe("scenarios > dashboard > parameters", () => {// Do not limit number of results (metabase#15695)// Prior to the issue being fixed, the cap was 100 resultscy.findByPlaceholderText("Search the list").type("Syner");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Synergistic Wool Coat");cy.location("search").should(@@ -500,9 +500,9 @@ describe("scenarios > dashboard > parameters", () => {// It should not reset previously defined filters when exiting 'edit' mode without making any changes (metabase#5332, metabase#17139)H.editDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Cancel").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You're editing this dashboard.").should("not.exist");cy.location("search").should(@@ -522,9 +522,9 @@ describe("scenarios > dashboard > parameters", () => {H.selectDashboardFilter(H.getDashboardCard(), "User ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You're editing this dashboard.").should("not.exist");cy.signIn("nodata");@@ -573,32 +573,32 @@ describe("scenarios > dashboard > parameters", () => {);H.editDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameter1Details.name).click();H.selectDashboardFilter(H.getDashboardCard(), "Category");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameter2Details.name).click();H.selectDashboardFilter(H.getDashboardCard(), "Vendor");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Linked filters").click();H.sidebar().findByRole("switch").parent().get("label").click();H.saveDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameter2Details.name).click();H.popover().within(() => {cy.findByText("Barrows-Johns").should("exist");cy.findByText("Balistreri-Ankunding").should("exist");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameter1Details.name).click();H.popover().within(() => {cy.findByText("Gadget").click();cy.button("Add filter").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameter2Details.name).click();H.popover().within(() => {cy.findByText("Barrows-Johns").should("exist");diff --git a/e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js b/e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.jsindex 2ad7eb1702d..a0134a9e1de 100644--- a/e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js+++ b/e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js@@ -784,7 +784,7 @@ describe("scenarios > dashboard > temporal unit parameters", () => {cy.log("add a temporal unit parameter");addTemporalUnitParameter();H.selectDashboardFilter(H.getDashboardCard(1), "Created At");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText("Auto-connect").click();H.saveDashboard();diff --git a/e2e/test/scenarios/dashboard/dashboard-questions.cy.spec.js b/e2e/test/scenarios/dashboard/dashboard-questions.cy.spec.jsindex 97642301ea6..3f94e1233ce 100644--- a/e2e/test/scenarios/dashboard/dashboard-questions.cy.spec.js+++ b/e2e/test/scenarios/dashboard/dashboard-questions.cy.spec.js@@ -638,7 +638,7 @@ describe("Dashboard > Dashboard Questions", () => {// remove the card saved inside the dashboardH.editDashboard();H.dashboardCards().findByText("Total Orders").realHover();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("trash").last().click();H.undoToast().findByText("Trashed and removed card");H.saveDashboard();diff --git a/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js b/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.jsindex 6813148dc49..80e474d9eb4 100644--- a/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js+++ b/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js@@ -754,9 +754,9 @@ describe("issue 29076", () => {// test that user is sandboxed - normal users has over 2000 rowsH.getDashboardCard().findAllByRole("row").should("have.length", 1);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");H.assertQueryBuilderRowCount(1); // test that user is sandboxed - normal users has over 2000 rowsH.assertDatasetReqIsSandboxed({diff --git a/e2e/test/scenarios/dashboard/dashboard.cy.spec.js b/e2e/test/scenarios/dashboard/dashboard.cy.spec.jsindex 4951372e7da..c0bebcbb970 100644--- a/e2e/test/scenarios/dashboard/dashboard.cy.spec.js+++ b/e2e/test/scenarios/dashboard/dashboard.cy.spec.js@@ -806,7 +806,7 @@ describe("scenarios > dashboard", () => {H.saveDashboard();cy.log("Assert that the selected filter is present in the dashboard");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Location", { exact: false }).should("be.visible");});@@ -837,14 +837,14 @@ describe("scenarios > dashboard", () => {cy.visit("/collection/root");// enter newly created dashboard- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("dash:11007").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This dashboard is empty");// add previously created question to itcy.findByLabelText("Edit dashboard").click();H.openQuestionsSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("11007").click();H.setFilter("Date picker", "All Options");@@ -869,9 +869,9 @@ describe("scenarios > dashboard", () => {// and connect it to the cardH.selectDashboardFilter(cy.findByTestId("dashcard-container"), "Category");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You're editing this dashboard.").should("not.exist");});@@ -975,9 +975,9 @@ describe("scenarios > dashboard", () => {cy.findByTestId("dashboardcard-actions-panel").within(() => {cy.icon("click").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("COUNT(*)").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Update a dashboard filter").click();checkOptionsForFilter("ID");@@ -1100,9 +1100,9 @@ describe("scenarios > dashboard", () => {H.visitDashboard(ORDERS_DASHBOARD_ID);cy.wait("@queryMetadata");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});@@ -1125,7 +1125,7 @@ describe("scenarios > dashboard", () => {});H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");assertScrollBarExists();@@ -1831,31 +1831,31 @@ describe("scenarios > dashboard > permissions", () => {it("should let admins view all cards in a dashboard", () => {H.visitDashboard(dashboardId);// Admin can see both questions- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("First Question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("foo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Second Question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("bar");});it("should display dashboards with some cards locked down", () => {cy.signIn("nodata");H.visitDashboard(dashboardId);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sorry, you don't have permission to see this card.");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Second Question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("bar");});it("should display an error if they don't have perms for the dashboard", () => {cy.signIn("nocollection");H.visitDashboard(dashboardId);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sorry, you don’t have permission to see that.");});});@@ -1976,7 +1976,7 @@ describe("scenarios > dashboard > entity id support", () => {});function validateIFrame(src, index = 0) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getDashboardCards().get("iframe").eq(index)diff --git a/e2e/test/scenarios/dashboard/text-cards.cy.spec.js b/e2e/test/scenarios/dashboard/text-cards.cy.spec.jsindex b01ba10c08b..0160d77a4d3 100644--- a/e2e/test/scenarios/dashboard/text-cards.cy.spec.js+++ b/e2e/test/scenarios/dashboard/text-cards.cy.spec.js@@ -367,7 +367,7 @@ describe("scenarios > dashboard > parameters in text and heading cards", () => {// Let's make sure the localization was reset back to the user locale by checking that specific text exists in// English on the homepage.cy.visit("/");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick up where you left off").should("exist");});diff --git a/e2e/test/scenarios/dashboard/title-drill.cy.spec.js b/e2e/test/scenarios/dashboard/title-drill.cy.spec.jsindex b15b62e8cfd..61fd0303fa4 100644--- a/e2e/test/scenarios/dashboard/title-drill.cy.spec.js+++ b/e2e/test/scenarios/dashboard/title-drill.cy.spec.js@@ -152,7 +152,7 @@ describe("scenarios > dashboard > title drill", () => {it("'contains' filter should still work after title drill through IF the native question field filter's type matches exactly (metabase#16181)", () => {checkScalarResult("200");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Text contains").click();cy.findByPlaceholderText("Enter some text").type("bb").blur();cy.button("Add filter").click();@@ -161,7 +161,7 @@ describe("scenarios > dashboard > title drill", () => {checkScalarResult("12");// Drill through on the question's title- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("16181").click();checkFilterLabelAndValue("Filter", "bb");@@ -178,7 +178,7 @@ describe("scenarios > dashboard > title drill", () => {it("'contains' filter should still work after title drill through IF the native question field filter's type matches exactly (metabase#16181)", () => {checkScalarResult("200");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Text contains").click();cy.findByPlaceholderText("Enter some text").type("bb").blur();cy.button("Add filter").click();@@ -187,7 +187,7 @@ describe("scenarios > dashboard > title drill", () => {checkScalarResult("12");// Drill through on the question's title- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("16181").click();checkFilterLabelAndValue("Filter", "bb");@@ -337,7 +337,7 @@ describe("scenarios > dashboard > title drill", () => {H.queryBuilderMain().findByText("53").should("be.visible");// make sure the unset id parameter works- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.filterWidget().last().click();H.dashboardParametersPopover().within(() => {H.fieldValuesCombobox().type("5");diff --git a/e2e/test/scenarios/dashboard/visualizer/drillthrough.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/drillthrough.cy.spec.tsindex 5974e70a9aa..cff3dcd0694 100644--- a/e2e/test/scenarios/dashboard/visualizer/drillthrough.cy.spec.ts+++ b/e2e/test/scenarios/dashboard/visualizer/drillthrough.cy.spec.ts@@ -76,7 +76,7 @@ describe("scenarios > dashboard > visualizer > drillthrough", () => {const SEP_2022_POINT_INDEX = 5;H.getDashboardCard(0).within(() =>- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircleWithColor(PRODUCTS_SERIES_COLOR).eq(SEP_2022_POINT_INDEX).click(),@@ -94,7 +94,7 @@ describe("scenarios > dashboard > visualizer > drillthrough", () => {H.queryBuilderHeader().findByLabelText("Back to Test Dashboard").click();H.getDashboardCard(0).within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircleWithColor(ORDERS_SERIES_COLOR).eq(SEP_2022_POINT_INDEX).click();diff --git a/e2e/test/scenarios/dashboard/x-rays.cy.spec.js b/e2e/test/scenarios/dashboard/x-rays.cy.spec.jsindex 59767826d70..b38318de06a 100644--- a/e2e/test/scenarios/dashboard/x-rays.cy.spec.js+++ b/e2e/test/scenarios/dashboard/x-rays.cy.spec.js@@ -19,17 +19,17 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {cy.visit("/");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Try out these sample x-rays to see what Metabase can do.",).should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^A summary of/).should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^A glance at/).should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^A look at/).should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Some insights about/).should("not.exist");});@@ -70,14 +70,14 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {.eq(23) // Random dot.click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Automatic insights…").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("X-ray").click();// x-rays take long time even locally - that can timeout in CI so we have to extend itcy.wait("@dataset", { timeout: 30000 });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("A closer look at number of Orders where Created At is in March 2024 and Category is Gadget",);@@ -157,13 +157,13 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {H.chartPathWithFillColor("#509EE3").first().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Automatic insights…").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(action).click();cy.wait("@xray");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("null").should("not.exist");});});@@ -191,7 +191,7 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {cy.url().should("contain", "a-look-at-orders");cy.findAllByTestId("dashcard").contains("18,760");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("How these transactions are distributed");H.openNavigationSidebar();@@ -237,20 +237,20 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {cy.wait("@geojson", { timeout });// confirm results of "Total transactions" card are present- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("18,760", timeout);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total transactions").click();// confirm we're in the query builder with the same resultscy.url().should("contain", "/question");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("18,760");cy.go("back");// add a parameter filter to the auto dashboard- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("State", timeout).click();cy.findByPlaceholderText("Search the list").type("GA{enter}");@@ -258,15 +258,15 @@ describe("scenarios > x-rays", { tags: "@slow" }, () => {cy.button("Add filter").click();// confirm results of "Total transactions" card were updated- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("463", timeout);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total transactions").click();// confirm parameter filter is applied as filter in query builder- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User → State is GA");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("463");});diff --git a/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts b/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.tsindex 195721c6845..084a3ca4296 100644--- a/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts@@ -1061,9 +1061,9 @@ describe("scenarios > data studio > datamodel", () => {);cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1080,9 +1080,9 @@ describe("scenarios > data studio > datamodel", () => {TableSection.getDescriptionInput().should("have.value", "");cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});@@ -1217,9 +1217,9 @@ describe("scenarios > data studio > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1248,9 +1248,9 @@ describe("scenarios > data studio > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});@@ -1653,9 +1653,9 @@ describe("scenarios > data studio > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New description").should("be.visible");});@@ -1685,9 +1685,9 @@ describe("scenarios > data studio > datamodel", () => {cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No description yet").should("be.visible");});@@ -2078,7 +2078,7 @@ describe("scenarios > data studio > datamodel", () => {cy.log("verify viz");H.openOrdersTable();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Tax (CA$)").should("be.visible");});diff --git a/e2e/test/scenarios/embedding/embedding-native.cy.spec.js b/e2e/test/scenarios/embedding/embedding-native.cy.spec.jsindex 0ad6da45d14..e39c9e7f1df 100644--- a/e2e/test/scenarios/embedding/embedding-native.cy.spec.js+++ b/e2e/test/scenarios/embedding/embedding-native.cy.spec.js@@ -53,11 +53,11 @@ describe("scenarios > embedding > native questions", () => {H.visitIframe();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Lora Cronin");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Organic");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("39.58");H.filterWidget().should("not.exist");@@ -96,9 +96,9 @@ describe("scenarios > embedding > native questions", () => {H.visitEmbeddedPage(payload);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Organic");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Twitter").should("not.exist");// Created At: Q2 2023@@ -107,7 +107,7 @@ describe("scenarios > embedding > native questions", () => {cy.findByText(/20\d+/).click();cy.contains("2023").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q2").click();// State: is not KS@@ -117,13 +117,13 @@ describe("scenarios > embedding > native questions", () => {cy.findByLabelText("KS").should("be.visible").click();cy.button("Add filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Logan Weber").should("not.exist");// Product ID is 10cy.findByPlaceholderText("Product ID").type("10{enter}");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Affiliate").should("not.exist");// Let's try to remove one filter@@ -136,11 +136,11 @@ describe("scenarios > embedding > native questions", () => {cy.findAllByRole("row").should("have.length", 1);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("December 29, 2024, 4:54 AM");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("CO");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sid Mills").should("not.exist");cy.location("search")@@ -364,7 +364,7 @@ describe("scenarios > embedding > native questions", () => {H.visitEmbeddedPage(payload);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You must specify a value for :source in the JWT.").should("be.visible",);diff --git a/e2e/test/scenarios/embedding/embedding-questions.cy.spec.js b/e2e/test/scenarios/embedding/embedding-questions.cy.spec.jsindex d8ba1838d42..7eb7cf34a4e 100644--- a/e2e/test/scenarios/embedding/embedding-questions.cy.spec.js+++ b/e2e/test/scenarios/embedding/embedding-questions.cy.spec.js@@ -138,7 +138,7 @@ describe("scenarios > embedding > questions", () => {H.echartsContainer().should("contain", "60");// Check the tooltip for the last point on the line- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().last().trigger("mousemove");H.assertEChartsTooltip({@@ -170,27 +170,27 @@ describe("scenarios > embedding > questions", () => {H.visitIframe();// Global (Data model) settings should be preserved- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID as Title");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Awesome Concrete Shoes");// Custom column- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Math");// Base question visualization settings should reset to the defaults (inherit global formatting)- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("39.72");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("February 11, 2025, 9:40 PM");cy.findAllByTestId("mini-bar-container").should("not.exist");// Data model: Subtotal is turned off globally- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Subtotal").should("not.exist");});diff --git a/e2e/test/scenarios/embedding/embedding-reproductions.cy.spec.js b/e2e/test/scenarios/embedding/embedding-reproductions.cy.spec.jsindex e492bf2ab8b..2522302ee7a 100644--- a/e2e/test/scenarios/embedding/embedding-reproductions.cy.spec.js+++ b/e2e/test/scenarios/embedding/embedding-reproductions.cy.spec.js@@ -157,7 +157,7 @@ describe("issue 15860", { tags: "@skip" }, () => {H.visitIframe();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q1 Category").click();H.popover().within(() => {@@ -166,7 +166,7 @@ describe("issue 15860", { tags: "@skip" }, () => {.and("contain", "Gizmo");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q2 Category").click();H.popover().within(() => {@@ -333,7 +333,7 @@ describe("locked parameters in embedded question (metabase#20634)", () => {});});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Locked").click();H.modal().within(() => {@@ -349,7 +349,7 @@ describe("locked parameters in embedded question (metabase#20634)", () => {H.visitIframe();// verify that the Text parameter doesn't show up but that its value is reflected in the dashcard- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Text").should("not.exist");cy.get(".CardVisualization").within(() => {cy.contains("foo");diff --git a/e2e/test/scenarios/embedding/embedding-snippets.cy.spec.js b/e2e/test/scenarios/embedding/embedding-snippets.cy.spec.jsindex ef37a57d1c8..1ed712bbd21 100644--- a/e2e/test/scenarios/embedding/embedding-snippets.cy.spec.js+++ b/e2e/test/scenarios/embedding/embedding-snippets.cy.spec.js@@ -66,7 +66,7 @@ tokens.forEach((token) => {.and("contain", "Python").and("contain", "Clojure");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcodeBlock().last().should("have.text", IFRAME_CODE);H.modal()diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/custom-elements-api.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/custom-elements-api.cy.spec.tsindex ef0fed22889..e1a0ea56271 100644--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/custom-elements-api.cy.spec.ts+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/custom-elements-api.cy.spec.ts@@ -527,7 +527,7 @@ describe("scenarios > embedding > sdk iframe embedding > custom elements api", (cy.log("Check that calling defineMetabaseConfig after the initial load works",);- // eslint-disable-next-line no-unscoped-text-selectors -- this is not the real app+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- this is not the real appcy.findByText("Change theme").click();H.getSimpleEmbedIframeContent()diff --git a/e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js b/e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.jsindex 998edc2352c..5aecf8518f4 100644--- a/e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js+++ b/e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js@@ -406,7 +406,7 @@ describe("issue 12985 > dashboard filter dropdown/search", () => {cy.button("Add filter").click();cy.location("search").should("eq", "?category=Gadget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ergonomic Silk Coat");});@@ -463,10 +463,10 @@ describe("issue 12985 > dashboard filter dropdown/search", () => {H.filterWidget().contains("Category").click();// It will fail at this point until the issue is fixed because popover never appearsH.popover().contains("Gadget").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add filter").click();cy.url().should("contain", "?category=Gadget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ergonomic Silk Coat");},);@@ -557,7 +557,7 @@ describe("issues 15119 and 16112", () => {},);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(reviewerFilter.name).click();H.popover().contains("adam").click();cy.button("Add filter").click();@@ -565,7 +565,7 @@ describe("issues 15119 and 16112", () => {cy.findByTestId("dashcard-container").should("contain", "adam");cy.location("search").should("eq", "?rating=&reviewer=adam");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(ratingFilter.name).click();H.popover().contains("5").click();@@ -711,10 +711,10 @@ describe("issue 17211", () => {H.filterWidget().click();cy.findByPlaceholderText("Search the list").type("abb");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Abbeville").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("No matching City found").should("not.exist");});});@@ -783,9 +783,9 @@ describe("issue 17551", () => {cy.url().should("include", "?date_filter=next30days~");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("tomorrow");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("today");});});@@ -840,7 +840,7 @@ describe("issue 17775", () => {// Make sure filter can be connected to the custom column using UI, rather than using API.H.filterWidget({ isEditing: true }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Column to filter on").parent().parent()@@ -886,7 +886,7 @@ describe("issue 19494", () => {.filter(`:contains("${filterName}")`).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText("Select…").eq(cardPosition).click();H.popover().contains("Category").click();@@ -1041,7 +1041,7 @@ describe("issue 20656", () => {// Make sure the filter widget is thereH.filterWidget();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sorry, you don't have permission to see this card.");// Trying to edit the filter should not show mapping fields and shouldn't break frontend (metabase#24536)@@ -1196,21 +1196,21 @@ describe("issue 22482", () => {H.editDashboard();H.setFilter("Date picker", "All Options");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("Created At").eq(0).click();H.saveDashboard();H.filterWidget().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Relative date range…").click();});it("should round relative date range (metabase#22482)", () => {cy.findByLabelText("Interval").clear().type(15);cy.findByRole("textbox", { name: "Unit" }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("months").click();const expectedRange = getFormattedRange(@@ -1218,7 +1218,7 @@ describe("issue 22482", () => {dayjs().add(-1, "month").endOf("month"),);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(expectedRange);});});@@ -1606,7 +1606,7 @@ describe("issue 25322", () => {throttleFieldValuesRequest(dashboard_id);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameterDetails.name).click();H.popover().findByTestId("loading-indicator").should("exist");});@@ -1687,14 +1687,14 @@ describe("issue 25248", () => {createDashboard();H.editDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(parameterDetails.name).click();cy.findAllByText("Select…").first().click();H.popover().findAllByText("Created At").first().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders.Created At").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").should("be.visible");});});@@ -1956,13 +1956,13 @@ describe("issue 25908", () => {});it("`contains` dashboard filter should respect case insensitivity on a title-drill-through (metabase#25908)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(questionDetails.name).click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Title contains Li");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`Showing ${CASE_INSENSITIVE_ROWS} rows`);});});@@ -2097,21 +2097,21 @@ describe("issue 27356", () => {it("should seamlessly move between dashboards with or without filters without triggering an error (metabase#27356)", () => {H.openNavigationSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(paramDashboard.name).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This dashboard is empty");H.openNavigationSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(regularDashboard.name).click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This dashboard is empty");H.openNavigationSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(paramDashboard.name).click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This dashboard is empty");});});@@ -3621,9 +3621,9 @@ describe("issue 34955", () => {H.saveDashboard();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").eq(-2).should("have.text", "Created At");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").eq(-1).should("have.text", ccName);H.tableInteractiveBody().findAllByRole("gridcell")diff --git a/e2e/test/scenarios/filters-reproductions/dashboard-filters-with-question-revert.cy.spec.js b/e2e/test/scenarios/filters-reproductions/dashboard-filters-with-question-revert.cy.spec.jsindex 3a38c8f7ab9..373b2ad79e1 100644--- a/e2e/test/scenarios/filters-reproductions/dashboard-filters-with-question-revert.cy.spec.js+++ b/e2e/test/scenarios/filters-reproductions/dashboard-filters-with-question-revert.cy.spec.js@@ -291,7 +291,7 @@ function connectFilterToColumn(column, index = 0) {});H.popover().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText(column).eq(index).click();});}diff --git a/e2e/test/scenarios/filters-reproductions/filters-reproductions.cy.spec.js b/e2e/test/scenarios/filters-reproductions/filters-reproductions.cy.spec.jsindex 439ba07cb5b..74123fc363e 100644--- a/e2e/test/scenarios/filters-reproductions/filters-reproductions.cy.spec.js+++ b/e2e/test/scenarios/filters-reproductions/filters-reproductions.cy.spec.js@@ -29,12 +29,12 @@ describe("issue 9339", () => {H.openOrdersTable();H.tableHeaderClick("Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column").click();H.selectFilterOperator("Greater than");cy.findByPlaceholderText("Enter a number").type("9339,1234").blur();cy.findByDisplayValue("9339").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,234").should("not.exist");cy.button("Add filter").should("be.enabled");});@@ -249,7 +249,7 @@ describe("issue 22230", () => {});it("should be able to filter on an aggregation (metabase#22230)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();H.clauseStepPopover().within(() => {@@ -293,7 +293,7 @@ describe("issue 22730", () => {});it("allows filtering by time column (metabase#22730)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Explore results").click();cy.wait("@dataset");@@ -305,9 +305,9 @@ describe("issue 22730", () => {cy.button("Add filter").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("before-row");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("after-row").should("not.exist");});});@@ -391,15 +391,15 @@ describe("issue 24994", () => {// Three filterscy.findByTestId("filters-visibility-control").contains("3").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Category is 2 selections").click();assertFilterValueIsSelected("Gadget");assertFilterValueIsSelected("Gizmo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").click();assertFilterValueIsSelected("Doohickey");cy.button("Update filter").should("not.be.disabled").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Category is 3 selections");});});@@ -457,7 +457,7 @@ describe("issue 25378", () => {});it("should be able to use relative date filter on a breakout after the aggregation (metabase#25378)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();H.clauseStepPopover().within(() => {@@ -602,7 +602,7 @@ describe("issue 25994", () => {});it("should be possible to use 'between' dates filter after aggregation (metabase#25994)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();H.popover().within(() => {@@ -651,12 +651,12 @@ describe("issue 26861", { tags: "@skip" }, () => {it("exclude filter shouldn't break native questions with field filters (metabase#26861)", () => {H.filterWidget().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Exclude…").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Days of the week…").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Tuesday").click();cy.button("Update filter").click();@@ -664,9 +664,9 @@ describe("issue 26861", { tags: "@skip" }, () => {// A part of this bug is that we have to manually run the query so the next step will failcy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("CREATED_AT excludes Tuesday");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("117.03").should("not.exist");});});@@ -688,11 +688,11 @@ describe("issue 27123", () => {it("exclude filter should not resolve to 'Days of the week' regardless of the chosen granularity (metabase#27123)", () => {H.tableHeaderClick("Created At");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Exclude…").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Months of the year…").click();H.popover()@@ -1205,7 +1205,7 @@ describe("issue 47887", () => {});cy.findByTestId("notebook-button").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();H.popover().within(() => {@@ -1259,7 +1259,7 @@ describe("issue 49321", () => {cy.findByText("Title").click();cy.findByText("Is").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Contains").click();H.popover().then(($popover) => {@@ -1344,7 +1344,7 @@ describe("issue 44665", () => {it("should use the correct widget for the default value picker (metabase#44665)", () => {H.startNewNativeQuestion();H.NativeEditor.type("select * from {{param");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().last().within(() => {@@ -1358,7 +1358,7 @@ describe("issue 44665", () => {cy.button("Done").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().last().findByText("Enter a default value…").click();H.popover().within(() => {cy.findByPlaceholderText("Enter a default value…")@@ -1371,7 +1371,7 @@ describe("issue 44665", () => {cy.findByText("baz").should("not.exist");});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().last().within(() => {diff --git a/e2e/test/scenarios/filters/filter-sources.cy.spec.js b/e2e/test/scenarios/filters/filter-sources.cy.spec.jsindex 01be3e8da6c..5da8424d448 100644--- a/e2e/test/scenarios/filters/filter-sources.cy.spec.js+++ b/e2e/test/scenarios/filters/filter-sources.cy.spec.js@@ -645,7 +645,7 @@ describe("scenarios > filters > filter sources", () => {});function addNewFilter() {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();}diff --git a/e2e/test/scenarios/filters/filter.cy.spec.js b/e2e/test/scenarios/filters/filter.cy.spec.jsindex 2ad8113c76c..0313318f226 100644--- a/e2e/test/scenarios/filters/filter.cy.spec.js+++ b/e2e/test/scenarios/filters/filter.cy.spec.js@@ -82,7 +82,7 @@ describe("scenarios > question > filter", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("12872");cy.log("At the moment of unfixed issue, it's showing '0'");cy.findByTestId("scalar-value").contains("1");@@ -174,10 +174,10 @@ describe("scenarios > question > filter", () => {.should("have.text", "2").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(AGGREGATED_FILTER);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Created At is after/i).find(".Icon-close").click();@@ -185,7 +185,7 @@ describe("scenarios > question > filter", () => {cy.log("**Removing or changing filters shouldn't remove aggregated filter**",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(AGGREGATED_FILTER);});@@ -255,21 +255,21 @@ describe("scenarios > question > filter", () => {);cy.get("[data-testid=cell-data]").contains("Widget");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 1 row");});it("should reject Enter when the filter expression is invalid", () => {H.openReviewsTable({ mode: "notebook" });H.filter({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({ formula: "[Rating] > 2E{enter}" }); // there should numbers after 'E'- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Missing exponent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rating is greater than 2").should("not.exist");});@@ -339,9 +339,9 @@ describe("scenarios > question > filter", () => {}).then(({ body: { id: QUESTION_ID } }) => {cy.visit(`/question/${QUESTION_ID}/notebook`);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({ formula: "[su", blur: false });@@ -355,7 +355,7 @@ describe("scenarios > question > filter", () => {it("should filter using IsNull() and IsEmpty()", () => {H.openReviewsTable({ mode: "notebook" });H.filter({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({ formula: "NOT IsNull([Rating])" });@@ -364,7 +364,7 @@ describe("scenarios > question > filter", () => {cy.findByTestId("query-builder-root").icon("add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({@@ -376,64 +376,64 @@ describe("scenarios > question > filter", () => {// check that filter is applied and rows displayedH.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 1,112 rows");});it("should convert 'is empty' on a text column to a custom expression using IsEmpty()", () => {H.openReviewsTable();H.tableHeaderClick("Reviewer");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column").click();H.selectFilterOperator("Is empty");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add filter").click();// filter out everything- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 0 rows");// change the corresponding custom expression- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Reviewer is empty").click();cy.get(".Icon-chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("isEmpty([Reviewer])");H.CustomExpressionEditor.clear().type("NOT IsEmpty([Reviewer])").blur();cy.button("Update").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 1,112 rows");});it("should convert 'is empty' on a numeric column to a custom expression using IsNull()", () => {H.openReviewsTable();H.tableHeaderClick("Rating");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column").click();H.selectFilterOperator("Is empty");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add filter").click();// filter out everything- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 0 rows");// change the corresponding custom expression- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rating is empty").click();cy.get(".Icon-chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("isNull([Rating])");H.CustomExpressionEditor.clear().type("NOT IsNull([Rating])", { delay: 50 }).blur();cy.button("Update").should("not.be.disabled").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 1,112 rows");});@@ -455,12 +455,12 @@ describe("scenarios > question > filter", () => {display: "table",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Title does not contain Wallet").click();cy.get(".Icon-chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains('doesNotContain([Title], "Wallet", "case-insensitive")');});@@ -482,7 +482,7 @@ describe("scenarios > question > filter", () => {display: "table",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Title does not contain Wallet").click();cy.get(".Icon-chevronleft").click();H.popover().findByText("Custom Expression").click();@@ -542,20 +542,20 @@ describe("scenarios > question > filter", () => {display: "table",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("wilma-muller");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Reviewer contains MULLER").click();cy.get(".Icon-chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains('contains([Reviewer], "MULLER", "case-insensitive")');cy.button("Update").click();cy.wait("@dataset").then((xhr) => {expect(xhr.response.body.data.rows).to.have.lengthOf(1);});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("wilma-muller");});@@ -599,13 +599,13 @@ describe("scenarios > question > filter", () => {});cy.get("[data-testid=cell-data]").contains("Count").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column").click();cy.findByPlaceholderText("Enter a number").type("42");cy.button("Update filter").should("not.be.disabled").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Gizmo").should("not.exist");},);@@ -702,7 +702,7 @@ describe("scenarios > question > filter", () => {it("should allow hiding the suggestion list with Escape", () => {H.openOrdersTable({ mode: "notebook" });H.filter({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();// Try to auto-complete Tax@@ -762,7 +762,7 @@ describe("scenarios > question > filter", () => {H.openPeopleTable({ mode: "notebook" });H.filter({ mode: "notebook" });H.popover().findByText("State").click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("AL").click();cy.button("Add filter").isVisibleInPopover();});@@ -797,7 +797,7 @@ describe("scenarios > question > filter", () => {assertOnLegendLabels();H.cartesianChartCircleWithColors(["#88BF4D", "#509EE3", "#A989C5"]);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").findByLabelText(/Where do you want to save this/)@@ -849,23 +849,23 @@ describe("scenarios > question > filter", () => {it("adding an ID filter shouldn't cause page error and page reload (metabase#16198-2)", () => {H.openOrdersTable({ mode: "notebook" });H.filter({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.CustomExpressionEditor.type("[Total] < [Product → Price]").blur();H.CustomExpressionEditor.format();cy.button("Done").click();// Filter currently says "Total is less than..." but it can change in https://github.com/metabase/metabase/pull/16174 to "Total < Price"// See: https://github.com/metabase/metabase/pull/16209#discussion_r638129099- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Total/);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("add").last().click();H.popover().findByText(/^ID$/i).click();cy.findByPlaceholderText("Enter an ID").type("1");cy.button("Add filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Total/);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Something went wrong").should("not.exist");});@@ -891,12 +891,12 @@ describe("scenarios > question > filter", () => {});// cy.findByText(/^Total/);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("add").last().click();H.clauseStepPopover().findByText(/^ID$/i).click();cy.findByPlaceholderText("Enter an ID").type("1");cy.button("Add filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total is equal to 123").parent().find(".Icon-close")@@ -988,7 +988,7 @@ describe("scenarios > question > filter", () => {it("with case", () => {H.openNotebook();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({formula: "Case(boolean, 45, -10)",diff --git a/e2e/test/scenarios/filters/relative-datetime.cy.spec.js b/e2e/test/scenarios/filters/relative-datetime.cy.spec.jsindex 6aad35e849c..b7aa713aefd 100644--- a/e2e/test/scenarios/filters/relative-datetime.cy.spec.js+++ b/e2e/test/scenarios/filters/relative-datetime.cy.spec.js@@ -36,7 +36,7 @@ describe("scenarios > question > relative-datetime", () => {date([[-30, unit]]),]);withStartingFrom("Previous", [10, unit], [10, unit]);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 2 rows").should("exist");}),);@@ -51,7 +51,7 @@ describe("scenarios > question > relative-datetime", () => {date([[30, unit]]),]);withStartingFrom("Next", [10, unit], [10, unit]);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 2 rows").should("exist");}),);diff --git a/e2e/test/scenarios/filters/view.cy.spec.js b/e2e/test/scenarios/filters/view.cy.spec.jsindex 65046de5292..3aabc5e0570 100644--- a/e2e/test/scenarios/filters/view.cy.spec.js+++ b/e2e/test/scenarios/filters/view.cy.spec.js@@ -15,9 +15,9 @@ describe("scenarios > question > view", () => {cy.visit("/admin/permissions/collections/root");cy.icon("close").first().click();cy.findAllByRole("option").contains("View").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Yes").click();// Native query saved in dasbhoard@@ -77,7 +77,7 @@ describe("scenarios > question > view", () => {// Filter by category and vendor// TODO: this should show values and allow searching- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This question is written in SQL.");cy.findAllByText("VENDOR").first().click();H.dashboardParametersPopover().within(() => {@@ -90,7 +90,7 @@ describe("scenarios > question > view", () => {cy.findByText("Add filter").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("run-button").last().click();cy.findAllByText("Widget");@@ -102,12 +102,12 @@ describe("scenarios > question > view", () => {cy.signIn("nodata");H.visitDashboard("@dashboardId");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").click();// Filter by category and vendor// TODO: this should show values and allow searching- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This question is written in SQL.");cy.findAllByText("VENDOR").first().click();H.popover().within(() => {@@ -126,7 +126,7 @@ describe("scenarios > question > view", () => {.type("Widget");cy.findByText("Add filter").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("run-button").last().click();cy.get(".test-TableInteractive-cellWrapper--firstColumn").should(diff --git a/e2e/test/scenarios/joins/joins-reproductions.cy.spec.js b/e2e/test/scenarios/joins/joins-reproductions.cy.spec.jsindex 15d97e8c6a5..1aa6c79326e 100644--- a/e2e/test/scenarios/joins/joins-reproductions.cy.spec.js+++ b/e2e/test/scenarios/joins/joins-reproductions.cy.spec.js@@ -192,7 +192,7 @@ describe("issue 15342", { tags: "@external" }, () => {H.getNotebookStep("join").findByLabelText("Right column").click();H.popover().findByText("Product ID").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("join_left_outer").last().click();H.miniPicker().within(() => {cy.findByText(MYSQL_DB_NAME).click();@@ -314,7 +314,7 @@ describe("issue 17767", () => {H.openNotebook();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Join data").click();// Join "Previous results" with@@ -327,7 +327,7 @@ describe("issue 17767", () => {expect(response.body.error).to.not.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("xavier");});});@@ -349,7 +349,7 @@ describe("issue 17968", () => {.click();H.popover().findByText("Created At").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().button("Join data").click();H.miniPicker().within(() => {cy.findByText("Sample Database").click();@@ -395,16 +395,16 @@ describe("issue 18502", () => {H.startNewQuestion();H.selectSavedQuestionsToJoin("18502#1", "18502#2");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At: Month").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Birth Date: Month").click();H.visualize((response) => {expect(response.body.error).to.not.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("April 2022");});});@@ -470,7 +470,7 @@ describe("issue 18512", () => {expect(response.body.error).to.not.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Products → Created At: Month");});});@@ -506,7 +506,7 @@ describe("issue 18589", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2,860,368");});});@@ -646,7 +646,7 @@ describe("issue 20519", () => {// Tightly related issue: metabase#17767it("should allow subsequent joins and nested query after summarizing on the implicit joins (metabase#20519)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByLabelText("Custom column").last().click();H.enterCustomColumnDetails({@@ -664,9 +664,9 @@ describe("issue 20519", () => {expect(response.body.error).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Two");});});@@ -844,12 +844,12 @@ describe("issue 23293", () => {"contain","Orders → Category is Doohickey",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").last().should("have.text", "Product → Category");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("grid").last().as("tableResults")@@ -889,9 +889,9 @@ describe("issue 27380", () => {);// Doesn't really matter which 'circle" we click on the graph- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().last().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See this month by week").click();cy.wait("@dataset");@@ -900,9 +900,9 @@ describe("issue 27380", () => {H.echartsContainer().findByText("Count");H.openNotebook();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product → Created At: Week");});});@@ -1232,7 +1232,7 @@ describe("issue 27521", () => {});function assertTableHeader(index, name) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").eq(index).should("have.text", name);}});diff --git a/e2e/test/scenarios/joins/joins.cy.spec.js b/e2e/test/scenarios/joins/joins.cy.spec.jsindex 0238a857c54..1318d1b53d7 100644--- a/e2e/test/scenarios/joins/joins.cy.spec.js+++ b/e2e/test/scenarios/joins/joins.cy.spec.js@@ -241,7 +241,7 @@ describe("scenarios > question > joined questions", () => {H.addSummaryField({ metric: "Count of rows" });H.addSummaryGroupingField({ table: "Products", field: "ID" });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().button("Join data").click();H.joinTable("Reviews");H.visualize();@@ -290,7 +290,7 @@ describe("scenarios > question > joined questions", () => {cy.findByLabelText("Right column").click();H.popover().findByText("by month").click({ force: true });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Week").click();assertJoinColumnName("left", "Created At: Week");@@ -300,7 +300,7 @@ describe("scenarios > question > joined questions", () => {cy.findByLabelText("Right column").click();H.popover().findByText("by week").click({ force: true });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Day").click();assertJoinColumnName("left", "Created At: Day");diff --git a/e2e/test/scenarios/metabot/transforms-codegen.cy.spec.ts b/e2e/test/scenarios/metabot/transforms-codegen.cy.spec.tsindex 81462b104c8..6bbfd49ddd3 100644--- a/e2e/test/scenarios/metabot/transforms-codegen.cy.spec.ts+++ b/e2e/test/scenarios/metabot/transforms-codegen.cy.spec.ts@@ -10,7 +10,7 @@ const SOURCE_TABLE = "Animals";const visitTransformListPage = () => cy.visit("/data-studio/transforms");const suggestions = () => cy.findAllByTestId("metabot-chat-suggestion");-// eslint-disable-next-line no-unsafe-element-filtering+// eslint-disable-next-line metabase/no-unsafe-element-filteringconst lastSuggestion = () => suggestions().last();const viewLastSuggestion = () =>diff --git a/e2e/test/scenarios/metrics/browse.cy.spec.ts b/e2e/test/scenarios/metrics/browse.cy.spec.tsindex 02176f6a0e2..7cf448e228a 100644--- a/e2e/test/scenarios/metrics/browse.cy.spec.ts+++ b/e2e/test/scenarios/metrics/browse.cy.spec.ts@@ -485,7 +485,7 @@ function findMetric(name: string) {}function getMetricsTableItem(index: number) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn metricsTable().findAllByTestId("metric-name").eq(index);}diff --git a/e2e/test/scenarios/metrics/metrics-collection.cy.spec.js b/e2e/test/scenarios/metrics/metrics-collection.cy.spec.jsindex 54ca3bb0bd2..9021456f356 100644--- a/e2e/test/scenarios/metrics/metrics-collection.cy.spec.js+++ b/e2e/test/scenarios/metrics/metrics-collection.cy.spec.js@@ -180,7 +180,7 @@ describe("scenarios > metrics > collection", () => {H.getUnpinnedSection().findByText(ORDERS_TIMESERIES_METRIC.name).should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText("Trashed metric").should("be.visible");openArchive();@@ -189,7 +189,7 @@ describe("scenarios > metrics > collection", () => {H.getUnpinnedSection().findByText(ORDERS_TIMESERIES_METRIC.name).should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText(`${ORDERS_TIMESERIES_METRIC.name} has been restored.`)@@ -203,7 +203,7 @@ describe("scenarios > metrics > collection", () => {H.popover().findByText("Delete permanently").click();H.modal().button("Delete permanently").click();H.getUnpinnedSection().should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText("This item has been permanently deleted.")diff --git a/e2e/test/scenarios/metrics/metrics-dashboard.cy.spec.js b/e2e/test/scenarios/metrics/metrics-dashboard.cy.spec.jsindex 06ed7e514a2..c9df8c4db91 100644--- a/e2e/test/scenarios/metrics/metrics-dashboard.cy.spec.js+++ b/e2e/test/scenarios/metrics/metrics-dashboard.cy.spec.js@@ -252,7 +252,7 @@ describe("scenarios > metrics > dashboard", () => {cy.findByText("Metrics").click();cy.findByText(ORDERS_SCALAR_METRIC.name).click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText("Question replaced")@@ -267,7 +267,7 @@ describe("scenarios > metrics > dashboard", () => {cy.findByText("Questions").click();cy.findByText("Orders").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.undoToastList().last().findByText("Metric replaced").should("be.visible");H.getDashboardCard().findByText("Orders").should("be.visible");});diff --git a/e2e/test/scenarios/metrics/metrics-editing.cy.spec.js b/e2e/test/scenarios/metrics/metrics-editing.cy.spec.jsindex 9d4e4c66ea5..aeaa95dccd4 100644--- a/e2e/test/scenarios/metrics/metrics-editing.cy.spec.js+++ b/e2e/test/scenarios/metrics/metrics-editing.cy.spec.js@@ -504,7 +504,7 @@ function getActionButton(title) {}function getPlusButton() {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findAllByTestId("notebook-cell-item").last();}@@ -570,7 +570,7 @@ function addBreakout({ tableName, columnName, bucketName, stageIndex }) {}if (bucketName) {H.popover().findByLabelText(columnName).findByText("by month").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(bucketName).click();} else {H.popover().findByText(columnName).click();diff --git a/e2e/test/scenarios/models/helpers/e2e-models-helpers.js b/e2e/test/scenarios/models/helpers/e2e-models-helpers.jsindex 0ff734a75c8..c90f4d97b6b 100644--- a/e2e/test/scenarios/models/helpers/e2e-models-helpers.js+++ b/e2e/test/scenarios/models/helpers/e2e-models-helpers.js@@ -90,7 +90,7 @@ export function turnIntoModel() {}export function selectFromDropdown(option, clickOpts) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringpopover().last().findByText(option).click(clickOpts);}diff --git a/e2e/test/scenarios/models/models-query-editor.cy.spec.js b/e2e/test/scenarios/models/models-query-editor.cy.spec.jsindex 317dc7e2740..7c4ddfbd633 100644--- a/e2e/test/scenarios/models/models-query-editor.cy.spec.js+++ b/e2e/test/scenarios/models/models-query-editor.cy.spec.js@@ -38,7 +38,7 @@ describe("scenarios > models query editor", () => {cy.findByTestId("data-step-cell").contains("Orders");cy.button("Save changes").should("be.disabled");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Row limit").click();cy.findByPlaceholderText("Enter a limit").type("2").blur();@@ -76,7 +76,7 @@ describe("scenarios > models query editor", () => {cy.findByText("Edit query definition").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Row limit").click();cy.findByPlaceholderText("Enter a limit").type("2").blur();@@ -220,27 +220,27 @@ describe("scenarios > models query editor", () => {cy.findByText("Edit metadata").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Syntax error in SQL/).should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Query").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Syntax error in SQL/).should("be.visible");H.NativeEditor.focus().type("{backspace}".repeat(" FROM".length));H.runNativeQuery();cy.get("[data-testid=cell-data]").contains(1);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Syntax error in SQL/).should("not.exist");cy.button("Save changes").click();cy.wait("@updateCard");cy.get("[data-testid=cell-data]").contains(1);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Syntax error in SQL/).should("not.exist");});});diff --git a/e2e/test/scenarios/models/models-with-aggregation-and-breakout.cy.spec.js b/e2e/test/scenarios/models/models-with-aggregation-and-breakout.cy.spec.jsindex 1fda4c0d88e..bf7c310cd41 100644--- a/e2e/test/scenarios/models/models-with-aggregation-and-breakout.cy.spec.js+++ b/e2e/test/scenarios/models/models-with-aggregation-and-breakout.cy.spec.js@@ -31,9 +31,9 @@ describe("scenarios > models with aggregation and breakout", () => {turnIntoModel();cy.wait("@updateCard");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At: Month");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distinct values of Product ID");});});diff --git a/e2e/test/scenarios/models/models.cy.spec.js b/e2e/test/scenarios/models/models.cy.spec.jsindex f43502e9281..41f70aa8dfa 100644--- a/e2e/test/scenarios/models/models.cy.spec.js+++ b/e2e/test/scenarios/models/models.cy.spec.js@@ -272,9 +272,9 @@ describe("scenarios > models", () => {H.echartsContainer();turnIntoModel();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This is a model now.");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();H.echartsContainer();@@ -294,12 +294,12 @@ describe("scenarios > models", () => {cy.wait("@cardUpdate");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This is a question now.");H.openQuestionActions();assertIsQuestion();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@cardUpdate");H.openQuestionActions();@@ -340,7 +340,7 @@ describe("scenarios > models", () => {it("shows 404 when opening a question with a /dataset URL", () => {cy.visit(`/model/${ORDERS_QUESTION_ID}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/We're a little lost/i);});@@ -457,17 +457,17 @@ describe("scenarios > models", () => {cy.button("Add filter").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();selectFromDropdown("Count of rows");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();selectFromDropdown("Created At");H.visualize();H.echartsContainer();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").within(() => {@@ -584,7 +584,7 @@ describe("scenarios > models", () => {cy.wait("@updateCard");cy.findByDisplayValue("M1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("foo");});});@@ -624,12 +624,12 @@ describe("scenarios > models", () => {H.closeQuestionActions();// Check card tags are supported by models- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Open editor/i).click();H.NativeEditor.focus().type("{leftarrow}{leftarrow}{backspace}{backspace}#1-orders",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click({ force: true });cy.findByTestId("save-question-modal").within((modal) => {@@ -689,9 +689,9 @@ describe("scenarios > models", () => {cy.wait("@cardUpdate");H.visitCollection("root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Useful data").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("A model").should("not.exist");});diff --git a/e2e/test/scenarios/models/reproductions.cy.spec.js b/e2e/test/scenarios/models/reproductions.cy.spec.jsindex 61e4662f160..db03121db25 100644--- a/e2e/test/scenarios/models/reproductions.cy.spec.js+++ b/e2e/test/scenarios/models/reproductions.cy.spec.js@@ -85,13 +85,13 @@ describe("issue 19737", () => {moveModel(modelName, personalCollectionName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Moved model");cy.findByLabelText("Navigation bar").within(() => {cy.findByText("New").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").should("be.visible").click();H.miniPickerBrowseAll().click();@@ -107,7 +107,7 @@ describe("issue 19737", () => {moveModel(modelName, "First collection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Moved model");// Close the modal so the next time we move the model another model will always be showncy.icon("close:visible").click();@@ -115,7 +115,7 @@ describe("issue 19737", () => {cy.findByLabelText("Navigation bar").within(() => {cy.findByText("New").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").should("be.visible").click();// Open question picker (this is crucial) so the collection list are loaded.@@ -134,13 +134,13 @@ describe("issue 19737", () => {moveModel(modelName, personalCollectionName);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Moved model");cy.findByLabelText("Navigation bar").within(() => {cy.findByText("New").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").should("be.visible").click();H.miniPickerBrowseAll().click();@@ -172,9 +172,9 @@ describe("issue 20042", () => {cy.wait("@query");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders Model");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});});@@ -279,11 +279,11 @@ describe("issue 20624", { tags: "@skip" }, () => {it("models metadata should override previously defined column settings (metabase#20624)", () => {openDetailsSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Customize metadata").click();// Open settings for this column- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(renamedColumn).click();// Let's set a new name for itcy.findByDisplayValue(renamedColumn).clear().type("Foo").blur();@@ -366,7 +366,7 @@ describe("issue 22517", () => {);H.openQuestionActions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit metadata").click();renameColumn("ID", "Foo");@@ -380,11 +380,11 @@ describe("issue 22517", () => {{ tags: "@skip" },() => {H.openQuestionActions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit query definition").click();// Make sure previous metadata changes are reflected in the UI- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo");// This will edit the original query and add the `SIZE` column@@ -397,13 +397,13 @@ describe("issue 22517", () => {cy.findByTestId("native-query-editor-container").icon("play").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo");},);@@ -427,7 +427,7 @@ describe("issue 22518", () => {it("UI should immediately reflect model query changes upon saving (metabase#22518)", () => {H.openQuestionActions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit query definition").click();H.NativeEditor.focus().type(", 'b' bar");@@ -470,9 +470,9 @@ describe("issue 22519", { tags: "@skip" }, () => {fieldId: REVIEWS.REVIEWS,});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Don't cast").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("UNIX seconds → Datetime").click();cy.wait("@updateField");});@@ -480,13 +480,13 @@ describe("issue 22519", { tags: "@skip" }, () => {it("model query should not fail when data model is using casting (metabase#22519)", () => {H.createQuestion(questionDetails, { visitQuestion: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("xavier");turnIntoModel();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("xavier");});});@@ -535,7 +535,7 @@ describe("filtering based on the remapped column name should result in a correctcy.findByText("Today").click();});cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Today").should("not.exist");cy.get("[data-testid=cell-data]").should("have.length", 4)@@ -814,7 +814,7 @@ describe("issue 28193", () => {function assertOnColumns() {cy.findAllByText("2.07").should("be.visible").and("have.length", 2);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").should("be.visible").last()@@ -835,7 +835,7 @@ describe("issue 28193", () => {// Go directly to model's query definitioncy.visit(`/model/${ORDERS_QUESTION_ID}/query`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({formula: "[Tax]",@@ -926,9 +926,9 @@ describe("issue 29378", () => {H.createAction(ACTION_DETAILS);cy.visit(`/model/${ORDERS_QUESTION_ID}/detail`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(ACTION_DETAILS.name).should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(ACTION_DETAILS.dataset_query.native.query).should("be.visible",);@@ -939,9 +939,9 @@ describe("issue 29378", () => {.should("exist");H.closeCommandPalette();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(ACTION_DETAILS.name).should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(ACTION_DETAILS.dataset_query.native.query).should("be.visible",);@@ -1507,7 +1507,7 @@ describe("issue 29951", { requestTimeout: 10000, viewportWidth: 1600 }, () => {cy.button("Get Answer").should("be.visible");H.saveMetadataChanges();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").last().should("have.text", "CC1");H.tableHeaderColumn("ID").as("idHeader");H.moveDnDKitElementByAlias("@idHeader", { horizontal: 100 });@@ -1949,7 +1949,7 @@ describe("issue 37009", () => {.button("Save").should("be.enabled").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.modal().last().within(() => {diff --git a/e2e/test/scenarios/models/reproductions.cy.spec.ts b/e2e/test/scenarios/models/reproductions.cy.spec.tsindex 7634484f447..1e0b556ba3b 100644--- a/e2e/test/scenarios/models/reproductions.cy.spec.ts+++ b/e2e/test/scenarios/models/reproductions.cy.spec.ts@@ -54,7 +54,7 @@ describe("issue 29943", () => {}function getHeaderCell(columnIndex: number, name: string) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").eq(columnIndex).should("have.text", name);return H.tableHeaderColumn(name);}@@ -555,7 +555,7 @@ describe("issue 40635", () => {}function assertTableHeader(index: number, name: string) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").eq(index).should("have.text", name);}diff --git a/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-helpers.js b/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-helpers.jsindex d9b7478d14d..ee329c9c5ce 100644--- a/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-helpers.js+++ b/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-helpers.js@@ -163,7 +163,7 @@ function addBetweenFilter([low, high] = [], buttonLabel = "Add filter") {popover().within(() => {cy.get("input").first().type(`${low}`);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("input").last().type(`${high}`);});diff --git a/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js b/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.jsindex ac6277f33af..ebac622f3ba 100644--- a/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js+++ b/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js@@ -74,7 +74,7 @@ describe("issue 11480", () => {// Run the query and see an error.SQLFilter.runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains('Data conversion error converting "some text"');// Oh wait! That doesn't match the total column, so we'll change the parameter to a number.@@ -90,7 +90,7 @@ describe("issue 11480", () => {describe("issue 11580", () => {function assertVariablesOrder() {cy.get("@variableLabels").first().should("have.text", "foo");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@variableLabels").last().should("have.text", "bar");}@@ -201,7 +201,7 @@ describe("issue 12581", () => {// Without them at least 1 in 10 test runs locally didn't fully clear the field or type correctlyH.NativeEditor.clear().type("SELECT 1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").within((modal) => {@@ -300,7 +300,7 @@ describe("issue 13961", { tags: "@skip" }, () => {cy.log("URL is correct at this point, but there are no results");cy.location("search").should("eq", `?${productIdFilter.name}=1`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rustic Paper Wallet"); // Product ID 1, Gizmo});});@@ -336,7 +336,7 @@ describe("issue 14302", () => {it("should not make the question dirty when there are no changes (metabase#14302)", () => {cy.log("Reported on v0.37.5 - Regression since v0.37.0");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").should("not.exist");});});@@ -428,7 +428,7 @@ describe("issue 14302", () => {});it(`${test.toUpperCase()} version:\n should be able to view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions (metabase#15163)`, () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New Title").click();cy.wait("@cardQuery", { timeout: 5000 }).then((xhr) => {@@ -437,7 +437,7 @@ describe("issue 14302", () => {H.NativeEditor.get().should("not.exist");cy.get("[data-testid=cell-data]").should("contain", "51");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 1 row");});});@@ -580,7 +580,7 @@ describe("issue 15981", () => {cy.findByTestId("query-visualization-root").contains("Rustic Paper Wallet");cy.icon("contract").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 51 rows");cy.icon("play").should("not.exist");});@@ -674,7 +674,7 @@ describe("issue 16756", () => {});it("should allow switching between date filter types (metabase#16756)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Open editor/i).click();cy.icon("variable").click();@@ -697,7 +697,7 @@ describe("issue 16756", () => {SQLFilter.runQuery();// We expect "No results"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No results!");});});@@ -936,7 +936,7 @@ describe("issue 27257", () => {it("should not drop numeric filter widget value on refresh even if it's zero (metabase#27257)", () => {cy.reload();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Here's where your results will appear");cy.findByDisplayValue("0");});@@ -978,7 +978,7 @@ describe("issue 29786", { tags: "@external" }, () => {FieldFilter.addWidgetStringFilter("Von-Gulgowski");SQLFilter.runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1087115303928").should("be.visible");});});@@ -1202,7 +1202,7 @@ describe("issue 49577", () => {it("should not show the values initially when using a single select search box (metabase#49577)", () => {H.startNewNativeQuestion();H.NativeEditor.type("select * from {{param");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().last().within(() => {@@ -1228,7 +1228,7 @@ describe("issue 49577", () => {cy.findByText("foo").should("be.visible");});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().last().findByText("Dropdown list").click();H.filterWidget().click();diff --git a/e2e/test/scenarios/native-filters/sql-field-filter.cy.spec.js b/e2e/test/scenarios/native-filters/sql-field-filter.cy.spec.jsindex 483875bf6db..c2fa7ffa47f 100644--- a/e2e/test/scenarios/native-filters/sql-field-filter.cy.spec.js+++ b/e2e/test/scenarios/native-filters/sql-field-filter.cy.spec.js@@ -149,7 +149,7 @@ describe("scenarios > filters > sql filters > field filter", () => {it("should work despite it not showing up in the widget type list", () => {H.createNativeQuestion(questionDetails, { visitQuestion: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 42 rows");H.clearFilterWidget();@@ -161,14 +161,14 @@ describe("scenarios > filters > sql filters > field filter", () => {});cy.findByTestId("qb-header").find(".Icon-play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 51 rows");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Open Editor").click();cy.icon("variable").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter widget type").parent().findByTestId("filter-widget-type-select")diff --git a/e2e/test/scenarios/native-filters/sql-filters-source.cy.spec.js b/e2e/test/scenarios/native-filters/sql-filters-source.cy.spec.jsindex 7847ff90120..b81e7f909f1 100644--- a/e2e/test/scenarios/native-filters/sql-filters-source.cy.spec.js+++ b/e2e/test/scenarios/native-filters/sql-filters-source.cy.spec.js@@ -86,7 +86,7 @@ describe("scenarios > filters > sql filters > values source", () => {FieldFilter.selectFilterValueFromList("Gadget", { addFilter: false });FieldFilter.selectFilterValueFromList("Gizmo");SQLFilter.runQuery("cardQuery");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 51 rows").should("exist");SQLFilter.toggleRequired();@@ -513,9 +513,9 @@ describe("scenarios > filters > sql filters > values source", () => {FieldFilter.openEntryForm();H.fieldValuesCombobox().type("Custom Label");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("1018947080336").should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Custom Label").click();H.fieldValuesValue(0).should("be.visible")@@ -538,9 +538,9 @@ describe("scenarios > filters > sql filters > values source", () => {FieldFilter.openEntryForm();H.fieldValuesCombobox().type("Custom Label");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("1018947080336").should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Custom Label").click();H.fieldValuesValue(0).should("be.visible")@@ -563,9 +563,9 @@ describe("scenarios > filters > sql filters > values source", () => {FieldFilter.openEntryForm();H.fieldValuesCombobox().type("Custom Label");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("1018947080336").should("not.exist");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Custom Label").click();H.fieldValuesValue(0).should("be.visible")@@ -730,7 +730,7 @@ describe("scenarios > filters > sql filters > values source > number parameter",checkFilterValueNotInList("10");checkFilterValueNotInList("20");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.popover().button("Add filter").click();@@ -758,7 +758,7 @@ describe("scenarios > filters > sql filters > values source > number parameter",checkFilterValueNotInList("10");checkFilterValueNotInList("20");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.popover().button("Add filter").click();@@ -785,7 +785,7 @@ describe("scenarios > filters > sql filters > values source > number parameter",checkFilterValueNotInList("10");checkFilterValueNotInList("20");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.popover().button("Add filter").click();@@ -814,7 +814,7 @@ describe("scenarios > filters > sql filters > values source > number parameter",H.dashboardParametersPopover().within(() => {H.multiAutocompleteInput().type("Tw");});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.multiAutocompleteValue(0)@@ -843,7 +843,7 @@ describe("scenarios > filters > sql filters > values source > number parameter",FieldFilter.openEntryForm();H.multiAutocompleteInput().type("Tw");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Twenty").click();H.multiAutocompleteValue(0).should("be.visible")@@ -1079,7 +1079,7 @@ const updateQuestion = () => {};const checkFilterValueInList = (value) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -1088,7 +1088,7 @@ const checkFilterValueInList = (value) => {};const checkFilterValueNotInList = (value) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {diff --git a/e2e/test/scenarios/native-filters/sql-filters.cy.spec.js b/e2e/test/scenarios/native-filters/sql-filters.cy.spec.jsindex 00283f5663f..3b9562c7ed7 100644--- a/e2e/test/scenarios/native-filters/sql-filters.cy.spec.js+++ b/e2e/test/scenarios/native-filters/sql-filters.cy.spec.js@@ -253,7 +253,7 @@ describe("scenarios > filters > sql filters > basic filter types", () => {// resize window to mobile form factorcy.viewport(480, 800);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1 active filter").click();H.filterWidget()diff --git a/e2e/test/scenarios/native/native-database-source.cy.spec.js b/e2e/test/scenarios/native/native-database-source.cy.spec.jsindex d1cdac2d225..89bb042c948 100644--- a/e2e/test/scenarios/native/native-database-source.cy.spec.js+++ b/e2e/test/scenarios/native/native-database-source.cy.spec.js@@ -292,7 +292,7 @@ describe("scenatios > question > native > mysql", { tags: "@external" }, () => {cy.wait("@dataset");cy.findByTextEnsureVisible("SUBTOTAL");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");// Save the querydiff --git a/e2e/test/scenarios/native/native-reproductions.cy.spec.js b/e2e/test/scenarios/native/native-reproductions.cy.spec.jsindex cb0541ff36b..a7111805e21 100644--- a/e2e/test/scenarios/native/native-reproductions.cy.spec.js+++ b/e2e/test/scenarios/native/native-reproductions.cy.spec.js@@ -268,20 +268,20 @@ describe("issue 19451", () => {});it("question field filter shows all tables from a selected database (metabase#19451)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Open Editor").click();cy.icon("variable").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Products").click();cy.icon("chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Products");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("People");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Reviews");});});@@ -513,7 +513,7 @@ describe("issue 31926", { tags: "@external" }, () => {});cy.findByTestId("native-query-editor-container").icon("play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("200");// Change DB@@ -620,7 +620,7 @@ describe("issue 23510", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Open Editor").click();cy.findByTestId("sidebar-content").within(() => {diff --git a/e2e/test/scenarios/native/native-reproductions.cy.spec.ts b/e2e/test/scenarios/native/native-reproductions.cy.spec.tsindex 8c3aed5b8f3..1bb450cc5a7 100644--- a/e2e/test/scenarios/native/native-reproductions.cy.spec.ts+++ b/e2e/test/scenarios/native/native-reproductions.cy.spec.ts@@ -915,7 +915,7 @@ describe("issue 66745", () => {cy.wait("@getCard");cy.wait("@cardQuery");- // eslint-disable-next-line no-unscoped-text-selectors+ // eslint-disable-next-line metabase/no-unscoped-text-selectorscy.findByText("Something’s gone wrong").should("not.exist");cy.findByTestId("query-visualization-root").within(() => {diff --git a/e2e/test/scenarios/native/native.cy.spec.js b/e2e/test/scenarios/native/native.cy.spec.jsindex 9661e784a0e..255edc6457e 100644--- a/e2e/test/scenarios/native/native.cy.spec.js+++ b/e2e/test/scenarios/native/native.cy.spec.js@@ -34,7 +34,7 @@ describe("scenarios > question > native", () => {H.NativeEditor.type("select count(*) from orders");runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("18,760");});@@ -88,7 +88,7 @@ describe("scenarios > question > native", () => {H.NativeEditor.type("select * from not_a_table");runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains('Table "NOT_A_TABLE" not found');});@@ -101,7 +101,7 @@ describe("scenarios > question > native", () => {// highlight back to the frontCypress._.range(19).forEach(() => cy.realPress(["Shift", "ArrowLeft"]));runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains('Table "ORD" not found');});@@ -112,7 +112,7 @@ describe("scenarios > question > native", () => {cy.get("input[placeholder*='Stars']").type("3");runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 168 rows");});@@ -126,7 +126,7 @@ describe("scenarios > question > native", () => {cy.get("input[placeholder*='Enter a default value']").type("Gizmo");runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();cy.findByTestId("save-question-modal").within(() => {@@ -152,7 +152,7 @@ describe("scenarios > question > native", () => {runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();cy.findByTestId("save-question-modal").within(() => {@@ -449,10 +449,10 @@ describe("scenarios > question > native", () => {H.startNewNativeQuestion();H.NativeEditor.type("select * from people where false");runQuery();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("No results!");cy.icon("contract").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();cy.findByTestId("save-question-modal").within(() => {@@ -488,7 +488,7 @@ describe("scenarios > question > native", () => {});});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This has a value");FILTERS.forEach((operator) => {@@ -562,7 +562,7 @@ describe("scenarios > question > native", () => {{ autorun: false },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Here's where your results will appear").should("be.visible");});diff --git a/e2e/test/scenarios/native/snippets.cy.spec.js b/e2e/test/scenarios/native/snippets.cy.spec.jsindex 3ad27d62b93..2599f88402e 100644--- a/e2e/test/scenarios/native/snippets.cy.spec.js+++ b/e2e/test/scenarios/native/snippets.cy.spec.js@@ -129,7 +129,7 @@ describe("scenarios > question > snippets", () => {cy.findByTestId("query-visualization-root").as("results").findByText("37.65");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Open Editor/i).click();// We need these mid-point checks to make sure Cypress typed the sequence/query correctly// Check 1@@ -258,7 +258,7 @@ describe("scenarios > question > snippets (EE)", () => {// create foldercy.icon("snippet").click();cy.findByTestId("sidebar-right").as("sidebar").find(".Icon-add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("New folder").click());H.modal().within(() => {cy.findByText("Create your new folder");@@ -282,7 +282,7 @@ describe("scenarios > question > snippets (EE)", () => {cy.findByText("Edit").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.modal().within(() => cy.findByText("SQL snippets").click());H.entityPickerModal().within(() => {cy.findByText("my favorite snippets").click();@@ -291,16 +291,16 @@ describe("scenarios > question > snippets (EE)", () => {cy.intercept("/api/collection/root/items?namespace=snippets").as("updateList",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.modal().within(() => cy.findByText("Save").click());// check that everything is in the right spotcy.wait("@updateList");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("snippet 1").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("my favorite snippets").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("snippet 1");cy.log("via collection picker (metabase#44930");@@ -419,7 +419,7 @@ describe("scenarios > question > snippets (EE)", () => {cy.visit("/collection/root");cy.wait("@collections");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Snippet Folder").should("not.exist");});diff --git a/e2e/test/scenarios/onboarding/auth/forgot_password.cy.spec.js b/e2e/test/scenarios/onboarding/auth/forgot_password.cy.spec.jsindex 8b13d7eeef1..81d7e7411cf 100644--- a/e2e/test/scenarios/onboarding/auth/forgot_password.cy.spec.js+++ b/e2e/test/scenarios/onboarding/auth/forgot_password.cy.spec.js@@ -16,9 +16,9 @@ describe("scenarios > auth > password", { tags: "@external" }, () => {cy.visit("/auth/forgot_password");cy.findByLabelText("Email address").type(admin.email);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Send password reset email").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/If the email exists/);H.getInbox().then(({ body: [{ html }] }) => {diff --git a/e2e/test/scenarios/onboarding/auth/sso.cy.spec.js b/e2e/test/scenarios/onboarding/auth/sso.cy.spec.jsindex 77f2ec4a0a5..6a6f2b6db63 100644--- a/e2e/test/scenarios/onboarding/auth/sso.cy.spec.js+++ b/e2e/test/scenarios/onboarding/auth/sso.cy.spec.js@@ -18,7 +18,7 @@ describe("scenarios > auth > signin > SSO", () => {it(`login history tab should be available with sso_source ${auth} (metabase#15558)`, () => {H.mockCurrentUserProperty("sso_source", auth);cy.visit("/account/profile");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Login History");});});@@ -30,7 +30,7 @@ describe("scenarios > auth > signin > SSO", () => {});it("should show SSO button", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with email");// Google SSO button is piped through an iframe@@ -38,22 +38,22 @@ describe("scenarios > auth > signin > SSO", () => {});it("should show login form when directed to sign in with email", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with email").click();cy.findByLabelText("Email address");cy.findByLabelText("Password");cy.button("Sign in").should("be.disabled");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with Google");});it("should surface login errors with Google sign in enabled (metabase#16122)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with email").click();cy.findByLabelText("Email address").type("[email protected]");cy.findByLabelText("Password").type("123");cy.button("Sign in").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("did not match stored password");});@@ -61,7 +61,7 @@ describe("scenarios > auth > signin > SSO", () => {const loginProtectedURL = "/admin/permissions/data";cy.visit(loginProtectedURL);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with email").click();fillInAuthForm();@@ -83,7 +83,7 @@ describe("scenarios > auth > signin > SSO", () => {cy.visit("/");// Google SSO button is piped through an iframecy.get("iframe");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in with email").should("not.exist");});});diff --git a/e2e/test/scenarios/onboarding/home/homepage.cy.spec.js b/e2e/test/scenarios/onboarding/home/homepage.cy.spec.jsindex fbc10234d4f..cc9a6a38334 100644--- a/e2e/test/scenarios/onboarding/home/homepage.cy.spec.js+++ b/e2e/test/scenarios/onboarding/home/homepage.cy.spec.js@@ -168,23 +168,23 @@ describe("scenarios > home > homepage", () => {cy.intercept("/api/automagic-*/database/**", getXrayCandidates());cy.visit("/");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Here are some explorations of the/);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("public");cy.findAllByRole("link").contains("sqlite");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("People").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("public").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("private").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("People");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("not.exist");});});@@ -199,18 +199,18 @@ describe("scenarios > home > homepage", () => {cy.signInAsAdmin();H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");cy.visit("/");cy.wait("@getRecentItems");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick up where you left off");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").click();cy.wait("@getDashboard");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");});@@ -250,19 +250,19 @@ describe("scenarios > home > homepage", () => {H.activateToken("pro-self-hosted");H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");cy.signOut();cy.signInAsNormalUser();cy.visit("/");cy.wait("@getPopularItems");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Here are some popular dashboards");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").click();cy.wait("@getDashboard");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders");});});@@ -271,7 +271,7 @@ describe("scenarios > home > homepage", () => {cy.signInAsAdmin();H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard");cy.visit("/collection/root");@@ -282,9 +282,9 @@ describe("scenarios > home > homepage", () => {cy.visit("/");cy.wait("@getRecentItems");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders, Count").should("not.exist");});diff --git a/e2e/test/scenarios/onboarding/navbar/new-menu.cy.spec.js b/e2e/test/scenarios/onboarding/navbar/new-menu.cy.spec.jsindex dceb633e526..a7ff68c2ec1 100644--- a/e2e/test/scenarios/onboarding/navbar/new-menu.cy.spec.js+++ b/e2e/test/scenarios/onboarding/navbar/new-menu.cy.spec.js@@ -6,7 +6,7 @@ describe("metabase > scenarios > navbar > new menu", () => {cy.signInAsAdmin();cy.visit("/");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New").click();});diff --git a/e2e/test/scenarios/onboarding/notifications.cy.spec.js b/e2e/test/scenarios/onboarding/notifications.cy.spec.jsindex db9ea002f7d..6475b2a1cc9 100644--- a/e2e/test/scenarios/onboarding/notifications.cy.spec.js+++ b/e2e/test/scenarios/onboarding/notifications.cy.spec.js@@ -80,7 +80,7 @@ describe("scenarios > account > notifications", () => {it("should be able to see help info", () => {openUserNotifications();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Not seeing one here?").click();H.modal().within(() => {@@ -219,7 +219,7 @@ describe("scenarios > account > notifications", () => {it("should be able to see help info", () => {openUserNotifications();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Not seeing one here?").click();H.modal().within(() => {@@ -233,18 +233,18 @@ describe("scenarios > account > notifications", () => {it("should be able to see pulses notifications", () => {openUserNotifications();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Subscription");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Slack’d hourly", { exact: false });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created by you", { exact: false });});it("should be able to unsubscribe and delete a pulse when the user has created it", () => {openUserNotifications();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Subscription");clickUnsubscribe();@@ -253,7 +253,7 @@ describe("scenarios > account > notifications", () => {cy.findByText("Yes, delete this subscription").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Subscription").should("not.exist");});});diff --git a/e2e/test/scenarios/onboarding/reference/databases.cy.spec.js b/e2e/test/scenarios/onboarding/reference/databases.cy.spec.jsindex 49c842d13d6..776e17ef05f 100644--- a/e2e/test/scenarios/onboarding/reference/databases.cy.spec.js+++ b/e2e/test/scenarios/onboarding/reference/databases.cy.spec.js@@ -12,7 +12,7 @@ describe("scenarios > reference > databases", () => {it("should see the listing", () => {cy.visit("/reference/databases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sample Database");});@@ -30,9 +30,9 @@ describe("scenarios > reference > databases", () => {cy.button(/Edit/).trigger("click");// Q - is there any cleaner way to get a nearby element without having to know the DOM?cy.findByPlaceholderText("No description yet").type("A pretty ok store");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("A pretty ok store");});@@ -45,9 +45,9 @@ describe("scenarios > reference > databases", () => {cy.findByPlaceholderText("Nothing interesting yet").type("Turns out it's not",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Cancel").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Turns out").should("have.length", 0);});@@ -60,9 +60,9 @@ describe("scenarios > reference > databases", () => {cy.findByPlaceholderText("Sample Database").clear().type("My definitely profitable business");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("My definitely profitable business");});@@ -158,7 +158,7 @@ describe("scenarios > reference > databases", () => {function checkReferenceDatabasesOrder() {cy.get("[class*=Card]").as("databaseCard").first().should("have.text", "a");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@databaseCard").last().should("have.text", "Sample Database");}@@ -171,7 +171,7 @@ function checkQuestionSourceDatabasesOrder() {H.popover().within(() => {cy.findByText("Raw Data").click();cy.get(selector).as("databaseName").eq(1).should("have.text", "a");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@databaseName").eq(lastDatabaseIndex).should("have.text", "Sample Database");diff --git a/e2e/test/scenarios/onboarding/reference/reproductions/5276-remove-field-type.cy.spec.js b/e2e/test/scenarios/onboarding/reference/reproductions/5276-remove-field-type.cy.spec.jsindex c365bf38378..c53efeabc5a 100644--- a/e2e/test/scenarios/onboarding/reference/reproductions/5276-remove-field-type.cy.spec.js+++ b/e2e/test/scenarios/onboarding/reference/reproductions/5276-remove-field-type.cy.spec.js@@ -10,13 +10,13 @@ describe("issue 5276", () => {it("should allow removing the field type (metabase#5276)", () => {cy.visit("/reference/databases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sample Database").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Tables in Sample Database").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Products").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Fields in this table").click();// Calling .click on this element goes into edit more and immediately calls resetForm to pull us back outdiff --git a/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts b/e2e/test/scenarios/onboarding/setup/setup.cy.spec.tsindex c7346f30292..55ed1017871 100644--- a/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts+++ b/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts@@ -436,19 +436,19 @@ describe("scenarios > setup", () => {skipLicenseStepOnEE();// usage data- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().findByText(/certain data about product usage/);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().button("Finish").click();// done- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().findByText(/You're all set up/);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().findByRole("link", { name: "Take me to Metabase" })@@ -506,16 +506,16 @@ describe("scenarios > setup", () => {"not.exist",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().findByText(/certain data about product usage/);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().button("Finish").click();// Finish & Subscribecy.intercept("GET", "/api/session/properties").as("properties");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("section").last().findByRole("link", { name: "Take me to Metabase" })diff --git a/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js b/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.jsindex 57511efe950..2498e129ff8 100644--- a/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js+++ b/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js@@ -16,7 +16,7 @@ describe("user > settings", () => {it("should be able to remove first name and last name (metabase#22754)", () => {cy.visit("/account/profile");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(fullName);cy.findByLabelText("First name").clear();cy.findByLabelText("Last name").clear();@@ -44,7 +44,7 @@ describe("user > settings", () => {cy.intercept("GET", "/api/permissions/membership").as("membership");cy.visit("/account/profile");cy.findByDisplayValue(first_name).click().clear().type("John");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Update").click();cy.findByDisplayValue("John");@@ -58,7 +58,7 @@ describe("user > settings", () => {cy.visit("/account/profile");cy.wait("@getUser");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("exist");});@@ -66,7 +66,7 @@ describe("user > settings", () => {cy.signOut();cy.visit("/account/profile");cy.url().should("include", "/auth/login");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in to Metabase");});@@ -76,15 +76,15 @@ describe("user > settings", () => {cy.findByLabelText("Current password").type(password);cy.findByLabelText("Create a password").type(password);cy.findByLabelText("Confirm your password").type(password);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Success");cy.findByLabelText("gear icon").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign out").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sign in to Metabase");});@@ -98,7 +98,7 @@ describe("user > settings", () => {.type("qwerty123").blur();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("password is too common");cy.get("@passwordInput").clear();@@ -111,7 +111,7 @@ describe("user > settings", () => {cy.findByLabelText("Confirm your password").type("new_password1");cy.button("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Invalid password");});@@ -122,7 +122,7 @@ describe("user > settings", () => {cy.findByTestId("user-locale-select").findByRole("textbox").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("Indonesian").click());cy.button("Update").click();@@ -182,7 +182,7 @@ describe("user > settings", () => {});it("should hide change password tab", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("not.exist");});});@@ -196,7 +196,7 @@ describe("user > settings", () => {});it("should hide change password tab", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("not.exist");});@@ -216,7 +216,7 @@ describe("user > settings", () => {});it("should hide change password tab", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("not.exist");});@@ -235,7 +235,7 @@ describe("user > settings", () => {});it("should hide change password tab", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Password").should("not.exist");});diff --git a/e2e/test/scenarios/onboarding/urls.cy.spec.js b/e2e/test/scenarios/onboarding/urls.cy.spec.jsindex b82ca498e5b..fb88a0d41d6 100644--- a/e2e/test/scenarios/onboarding/urls.cy.spec.js+++ b/e2e/test/scenarios/onboarding/urls.cy.spec.js@@ -21,7 +21,7 @@ describe("URLs", () => {it('should slugify database name when opening it from /browse/databases"', () => {cy.visit("/browse/databases");cy.findByTextEnsureVisible("Sample Database").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sample Database");cy.location("pathname").should("eq",@@ -44,7 +44,7 @@ describe("URLs", () => {describe("dashboards", () => {it("should slugify dashboard URLs", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").click();cy.location("pathname").should("eq",@@ -56,7 +56,7 @@ describe("URLs", () => {describe("questions", () => {it("should slugify question URLs", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").click();cy.location("pathname").should("eq",@@ -79,7 +79,7 @@ describe("URLs", () => {it("should slugify current user's personal collection name correctly", () => {cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Your personal collection").click();cy.location("pathname").should("eq",diff --git a/e2e/test/scenarios/organization/bookmarks-collection.cy.spec.js b/e2e/test/scenarios/organization/bookmarks-collection.cy.spec.jsindex e914dcd36d2..f137afdc380 100644--- a/e2e/test/scenarios/organization/bookmarks-collection.cy.spec.js+++ b/e2e/test/scenarios/organization/bookmarks-collection.cy.spec.js@@ -161,7 +161,7 @@ describe("scenarios > organization > bookmarks > collection", () => {H.visitCollection("root");pin(name);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("A dashboard");bookmarkPinnedItem(name);H.expectUnstructuredSnowplowEvent({diff --git a/e2e/test/scenarios/organization/edit-history-metadata.cy.spec.js b/e2e/test/scenarios/organization/edit-history-metadata.cy.spec.jsindex 5e9d0ba4b1e..0f3f37cc9c9 100644--- a/e2e/test/scenarios/organization/edit-history-metadata.cy.spec.js+++ b/e2e/test/scenarios/organization/edit-history-metadata.cy.spec.js@@ -18,14 +18,14 @@ describe("scenarios > collection items metadata", () => {it("should display last edit moment for dashboards", () => {H.visitDashboard(ORDERS_DASHBOARD_ID);changeDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Edited a few seconds ago/i);});it("should display last edit moment for questions", () => {H.visitQuestion(ORDERS_QUESTION_ID);changeQuestion();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Edited a few seconds ago/i);});});@@ -34,10 +34,10 @@ describe("scenarios > collection items metadata", () => {it("should display if user is the last editor", () => {cy.signInAsAdmin();H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Edited .* by you/i);H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Edited .* by you/i);cy.signOut();});@@ -49,10 +49,10 @@ describe("scenarios > collection items metadata", () => {cy.signIn("normal");H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(new RegExp(`Edited .* by ${expectedName}`, "i"));H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(new RegExp(`Edited .* by ${expectedName}`, "i"));});diff --git a/e2e/test/scenarios/organization/timelines-collection.cy.spec.js b/e2e/test/scenarios/organization/timelines-collection.cy.spec.jsindex 7a1ef6a6ded..c6a17af378d 100644--- a/e2e/test/scenarios/organization/timelines-collection.cy.spec.js+++ b/e2e/test/scenarios/organization/timelines-collection.cy.spec.js@@ -171,21 +171,21 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");H.modal().findByText("Metrics").click();openMenu("RC2");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Move event").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").click();H.modal().button("Move").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("not.exist");cy.icon("chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2");});@@ -202,19 +202,19 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");H.modal().findByText("Metrics").click();openMenu("RC2");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Move event").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").click();H.modal().button("Move").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("be.visible");});@@ -227,15 +227,15 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit event").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive event").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("not.exist");});@@ -248,16 +248,16 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive event").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");});@@ -269,23 +269,23 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("View archived events").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archived events").should("be.visible");openMenu("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Unarchive event").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No events found").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");});@@ -297,18 +297,18 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("View archived events").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archived events").should("be.visible");openMenu("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete event").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete").click();cy.wait("@deleteEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No events found").should("be.visible");});@@ -317,7 +317,7 @@ describe("scenarios > organization > timelines > collection", () => {H.createTimeline({ name: "Metrics" });cy.visit("/collection/root/timelines/1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases");cy.icon("chevronleft").click();@@ -329,7 +329,7 @@ describe("scenarios > organization > timelines > collection", () => {H.createTimeline({ name: "Releases" });cy.visit("/collection/root/timelines/1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases");cy.icon("chevronleft").should("not.exist");});@@ -342,16 +342,16 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New timeline").click();cy.findByLabelText("Name").type("Launches");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create").click();cy.wait("@createTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Launches").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("be.visible");});@@ -363,14 +363,14 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit timeline details").click();cy.findByLabelText("Name").clear().type("Launches");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Update").click();cy.wait("@updateTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Launches").should("be.visible");});@@ -391,9 +391,9 @@ describe("scenarios > organization > timelines > collection", () => {cy.wait("@updateTimeline");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics events").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${H.getFullName(admin)}'s Personal Collection`).should("be.visible",);@@ -407,24 +407,24 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit timeline details").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive timeline and all events").click();cy.wait("@updateTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics events").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@updateTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("be.visible");});@@ -440,9 +440,9 @@ describe("scenarios > organization > timelines > collection", () => {});cy.visit("/collection/root/timelines");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Release notes").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Holiday list").should("be.visible");});@@ -460,7 +460,7 @@ describe("scenarios > organization > timelines > collection", () => {});cy.visit("/collection/root/timelines");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Release notes").should("be.visible");});@@ -472,24 +472,24 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit timeline details").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive timeline and all events").click();cy.wait("@updateTimeline");openMenu("Our analytics events");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("View archived timelines").click();openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Unarchive timeline").click();cy.wait("@updateTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No timelines found");H.modal().icon("chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases");});@@ -501,38 +501,38 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit timeline details").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive timeline and all events").click();cy.wait("@updateTimeline");openMenu("Our analytics events");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("View archived timelines").click();openMenu("Releases");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete timeline").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete").click();cy.wait("@deleteTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("No timelines found");H.modal().icon("chevronleft").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics events");});it("should preserve collection names for default timelines", () => {cy.visit(`/collection/${FIRST_COLLECTION_ID}/timelines`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").click();cy.findByLabelText("Event name").type("RC1");cy.findByLabelText("Date").type("10/20/2026");cy.button("Create").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("First collection events");cy.wait("@createTimeline");cy.icon("close").click();@@ -545,12 +545,12 @@ describe("scenarios > organization > timelines > collection", () => {cy.icon("calendar").click();openMenu("1st collection events");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit timeline details").click();cy.findByLabelText("Name").clear().type("Releases");cy.button("Update").click();cy.wait("@updateTimeline");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases");});@@ -564,14 +564,14 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root/timelines");openMenu("RC1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit event").click();cy.findByDisplayValue("2022/10/12").should("be.visible");cy.findByLabelText("Date").clear().type("2022/10/15");cy.button("Update").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2022/10/15").should("be.visible");});@@ -603,9 +603,9 @@ describe("scenarios > organization > timelines > collection", () => {cy.visit("/collection/root");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics events").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("not.exist");});@@ -620,9 +620,9 @@ describe("scenarios > organization > timelines > collection", () => {cy.signIn("readonly");cy.visit("/collection/root");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("not.exist");});});@@ -657,7 +657,7 @@ describe("scenarios > collections > timelines", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").click();cy.findByLabelText("Event name").type("Event");cy.findByLabelText("Date").type("10/20/2026");diff --git a/e2e/test/scenarios/organization/timelines-question.cy.spec.js b/e2e/test/scenarios/organization/timelines-question.cy.spec.jsindex d8eee6c5fdd..2c8b5a9bf93 100644--- a/e2e/test/scenarios/organization/timelines-question.cy.spec.js+++ b/e2e/test/scenarios/organization/timelines-question.cy.spec.js@@ -21,11 +21,11 @@ describe("scenarios > organization > timelines > question", () => {it("should create the first event and timeline", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").click();cy.findByLabelText("Event name").type("RC1");@@ -33,9 +33,9 @@ describe("scenarios > organization > timelines > question", () => {cy.button("Create").click();cy.wait("@createEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Our analytics events").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");});@@ -47,11 +47,11 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").click();cy.findByLabelText("Event name").type("RC2");@@ -59,11 +59,11 @@ describe("scenarios > organization > timelines > question", () => {cy.button("Create").click();cy.wait("@createEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("be.visible");});@@ -79,23 +79,23 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.findByLabelText("calendar icon").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v1").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v2").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v3").should("be.visible");cy.findByLabelText("Switch to data").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v1").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v2").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("v3").should("be.visible");});@@ -107,24 +107,24 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");H.rightSidebar().icon("ellipsis").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Edit event").click();cy.findByLabelText("Event name").clear().type("RC2");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Update").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC2").should("be.visible");});@@ -137,23 +137,23 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Builds").should("be.visible");H.rightSidebar().icon("ellipsis").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Move event").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").click();cy.button("Move").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Builds").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");});@@ -165,23 +165,23 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.wait("@getCollection");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");H.rightSidebar().icon("ellipsis").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Archive event").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Undo").click();cy.wait("@updateEvent");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("RC1").should("be.visible");});@@ -202,9 +202,9 @@ describe("scenarios > organization > timelines > question", () => {H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Release notes").should("be.visible");});@@ -231,7 +231,7 @@ describe("scenarios > organization > timelines > question", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");H.echartsIcon("star").should("be.visible");});@@ -261,7 +261,7 @@ describe("scenarios > organization > timelines > question", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");H.echartsIcon("star").should("not.exist");});@@ -287,7 +287,7 @@ describe("scenarios > organization > timelines > question", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");H.echartsIcon("star").should("be.visible");});@@ -545,13 +545,13 @@ describe("scenarios > organization > timelines > question", () => {it("should not allow creating default timelines", () => {cy.signIn("readonly");H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At: Year").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Events in Metabase/);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("not.exist");});@@ -564,13 +564,13 @@ describe("scenarios > organization > timelines > question", () => {cy.signOut();cy.signIn("readonly");H.visitQuestion(ORDERS_BY_YEAR_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At: Year").should("be.visible");cy.icon("calendar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Releases").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Create event").should("not.exist");H.rightSidebar().icon("ellipsis").should("not.exist");});diff --git a/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.jsindex 648feffa178..18744eb60a7 100644--- a/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js+++ b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js@@ -58,14 +58,14 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {cy.intercept("PUT", "/api/permissions/graph", (req) => {req.reply(500, "Server error");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Save changes").click();cy.contains("button", "Yes").click();// see error modal- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Server error");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("There was an error saving");});@@ -186,7 +186,7 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {cy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable([@@ -278,7 +278,7 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {"Query builder and native",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You've made changes to permissions.");// Switching to databases focus should not show any warnings@@ -314,7 +314,7 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {cy.visit("/admin/permissions");// no groups selected initially and it shows an empty state- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select a group to see its data permissions");const groups = [@@ -354,9 +354,9 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {`/admin/permissions/data/group/${ADMIN_GROUP}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Permissions for the Administrators group");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1 person");H.assertPermissionTable([@@ -482,7 +482,7 @@ describe("scenarios > admin > permissions", () => {cy.signIn("nodata");H.visitDashboard(ORDERS_DASHBOARD_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sorry, you don't have permission to see this card.");});});diff --git a/e2e/test/scenarios/permissions/create-queries.cy.spec.js b/e2e/test/scenarios/permissions/create-queries.cy.spec.jsindex 12ce98e87bc..8f6dd31da5d 100644--- a/e2e/test/scenarios/permissions/create-queries.cy.spec.js+++ b/e2e/test/scenarios/permissions/create-queries.cy.spec.js@@ -198,7 +198,7 @@ describe("scenarios > admin > permissions > create queries > query builder and ncy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable(finalTablePermissions);@@ -227,7 +227,7 @@ describe("scenarios > admin > permissions > create queries > query builder and ncy.visit("/admin/permissions/");cy.get("label").contains("Databases").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select a database to see group permissions");H.selectSidebarItem("Sample Database");@@ -274,7 +274,7 @@ describe("scenarios > admin > permissions > create queries > query builder and ncy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable(finalPermissions);@@ -344,7 +344,7 @@ describe("scenarios > admin > permissions > create queries > query builder only"cy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable(finalTablePermissions);@@ -433,7 +433,7 @@ describe("scenarios > admin > permissions > create queries > query builder only"cy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");// Drill down to tables permissions@@ -499,7 +499,7 @@ describe("scenarios > admin > permissions > create queries > query builder only"cy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable(finalTablePermissions);@@ -528,7 +528,7 @@ describe("scenarios > admin > permissions > create queries > query builder only"cy.visit("/admin/permissions/");cy.get("label").contains("Databases").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select a database to see group permissions");H.selectSidebarItem("Sample Database");@@ -575,7 +575,7 @@ describe("scenarios > admin > permissions > create queries > query builder only"cy.button("Yes").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save changes").should("not.exist");H.assertPermissionTable(finalPermissions);diff --git a/e2e/test/scenarios/permissions/data-model-permissions.cy.spec.js b/e2e/test/scenarios/permissions/data-model-permissions.cy.spec.jsindex e5761c5eb1c..434d22776f2 100644--- a/e2e/test/scenarios/permissions/data-model-permissions.cy.spec.js+++ b/e2e/test/scenarios/permissions/data-model-permissions.cy.spec.js@@ -38,11 +38,11 @@ describe("scenarios > admin > permissions", () => {// Go to the admin settingscy.icon("gear").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Admin settings").click();// Assert the Data Model page state- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Table Metadata");H.DataModel.TablePicker.getTable("Orders").click();cy.wait("@tableMetadataFetch");@@ -87,11 +87,11 @@ describe("scenarios > admin > permissions", () => {// Go to the admin settingscy.icon("gear").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Admin settings").click();// Assert the Data Model page state- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Table Metadata");H.DataModel.TablePicker.getTables().should("have.length", 8);H.DataModel.TablePicker.getTable("Accounts").should("be.visible");diff --git a/e2e/test/scenarios/permissions/database-details-permissions.cy.spec.js b/e2e/test/scenarios/permissions/database-details-permissions.cy.spec.jsindex ed2732e8092..ca171adfc7b 100644--- a/e2e/test/scenarios/permissions/database-details-permissions.cy.spec.js+++ b/e2e/test/scenarios/permissions/database-details-permissions.cy.spec.js@@ -30,7 +30,7 @@ describe("scenarios > admin > permissions > database details permissions", () =>cy.visit("/");cy.icon("gear").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Admin settings").should("be.visible").click();cy.location("pathname").should("eq", "/admin/databases");@@ -40,7 +40,7 @@ describe("scenarios > admin > permissions > database details permissions", () =>.and("not.contain", "Settings").and("not.contain", "Data Model");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sample Database").click();cy.findByTestId("database-connection-info-section").within(() => {diff --git a/e2e/test/scenarios/permissions/download-permissions.cy.spec.js b/e2e/test/scenarios/permissions/download-permissions.cy.spec.jsindex 41b8ca99c39..27ddfe0d9fd 100644--- a/e2e/test/scenarios/permissions/download-permissions.cy.spec.js+++ b/e2e/test/scenarios/permissions/download-permissions.cy.spec.js@@ -105,7 +105,7 @@ describe("scenarios > admin > permissions > data > downloads", () => {H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing first 2,000 rows");cy.icon("download").should("not.exist");});@@ -124,7 +124,7 @@ describe("scenarios > admin > permissions > data > downloads", () => {H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing first 2,000 rows");cy.icon("download").should("not.exist");diff --git a/e2e/test/scenarios/permissions/permissions-baseline.cy.spec.js b/e2e/test/scenarios/permissions/permissions-baseline.cy.spec.jsindex 54470291296..9b64874a143 100644--- a/e2e/test/scenarios/permissions/permissions-baseline.cy.spec.js+++ b/e2e/test/scenarios/permissions/permissions-baseline.cy.spec.js@@ -47,7 +47,7 @@ describe("scenarios > permissions", () => {it("should let a user with no data permissions view questions", () => {cy.signIn("nodata");H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("February 11, 2025, 9:40 PM"); // check that the data loads});});diff --git a/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.js b/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.jsindex e3addd4f84c..bd31eca672b 100644--- a/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.js+++ b/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.js@@ -61,14 +61,14 @@ describe("issue 13347", { tags: ["@external", "@skip"] }, () => {cy.signIn("none");H.startNewQuestion();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Saved Questions").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagetest === "QB" ? cy.findByText("Q1").click() : cy.findByText("Q2").click();cy.wait("@dataset", { timeout: 5000 });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});});@@ -167,7 +167,7 @@ describe("issue 17777", { tags: "@skip" }, () => {it("should still be able to set permissions on individual tables, even though they are hidden in data model (metabase#17777)", () => {cy.visit(`/admin/permissions/data/group/${ALL_USERS_GROUP}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Permissions for the All Users group");cy.findByTextEnsureVisible("Sample Database").click();@@ -205,9 +205,9 @@ describe("issue 19603", () => {it("archived subcollection should not show up in permissions (metabase#19603)", () => {cy.visit("/admin/permissions/collections");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("First collection").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Second collection").should("not.exist");});});@@ -267,7 +267,7 @@ describe("issue 20436", () => {cy.wait("@updatePermissions");cy.visit(url);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Query builder only");});});@@ -283,7 +283,7 @@ describe("UI elements that make no sense for users without data permissions (metH.visitQuestion(ORDERS_QUESTION_ID);cy.findByTestId("viz-settings-button");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").click();cy.findByTestId("display-options-sensible");@@ -299,7 +299,7 @@ describe("UI elements that make no sense for users without data permissions (met.should("have.attr", "data-disabled");cy.get("@saveButton").realHover();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You don't have permission to save this question.");cy.findByTestId("qb-header-action-panel").within(() => {@@ -354,7 +354,7 @@ describe("issue 22473", () => {it("nocollection user should be able to view and unsubscribe themselves from a subscription", () => {cy.visit(`/dashboard/${ORDERS_DASHBOARD_ID}`);H.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();cy.findByPlaceholderText("Enter user names or email addresses").click()@@ -367,7 +367,7 @@ describe("issue 22473", () => {cy.signIn("nocollection");cy.visit("/account/notifications");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").should("exist");cy.findByTestId("notifications-list").within(() => {cy.findByLabelText("close icon").click();@@ -375,7 +375,7 @@ describe("issue 22473", () => {H.modal().within(() => {cy.button("Unsubscribe").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders in a dashboard").should("not.exist");});});@@ -475,12 +475,12 @@ describe("issue 22727", () => {// We already have a reproduction that makes sure "Our analytics" is not offered when starting from an ad-hoc question (table).H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("31.44").click();H.popover().contains("=").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").then((modal) => {@@ -522,9 +522,9 @@ describe("issue 23981", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${H.getFullName(nocollection)}'s Personal Collection`,).click();diff --git a/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-api.cy.spec.js b/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-api.cy.spec.jsindex 78173e1dcc4..76acc430d1c 100644--- a/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-api.cy.spec.js+++ b/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-api.cy.spec.js@@ -366,9 +366,9 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {H.openOrdersTable({ mode: "notebook" });H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();cy.log(@@ -390,9 +390,9 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by User → ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("11"); // Sum of orders for user with ID #1H.assertQueryBuilderRowCount(2); // test that user is sandboxed - normal users has over 2000 rowsH.assertDatasetReqIsSandboxed();@@ -512,7 +512,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {// Find saved question in "Our analytics"cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(QUESTION_NAME).click();cy.wait("@cardQuery");@@ -521,16 +521,16 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {// Click on the first bar in a graph (Category: "Doohickey")H.chartPathWithFillColor("#509EE3").eq(0).click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();cy.log("Reported failing on v1.37.0.2");cy.wait("@dataset").then((xhr) => {expect(xhr.response.body.error).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product → Category is Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("97.44"); // Subtotal for order #10H.assertQueryBuilderRowCount(2); // test that user is sandboxed - normal users has over 2000 rowsH.assertDatasetReqIsSandboxed({@@ -599,7 +599,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {// Find saved question in "Our analytics"cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(QUESTION_NAME).click();cy.wait("@cardQuery");@@ -608,14 +608,14 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {// Click on the first bar in a graph (Category: "Doohickey")H.chartPathWithFillColor("#509EE3").eq(0).click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();cy.wait("@dataset");cy.log("Reported failing on v1.36.4");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Products → Category is Doohickey");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("97.44"); // Subtotal for order #10H.assertQueryBuilderRowCount(2); // test that user is sandboxed - normal users has over 2000 rowsH.assertDatasetReqIsSandboxed({@@ -769,7 +769,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {cy.get("[data-testid=cell-data]").contains("Awesome Concrete Shoes").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/View details/i).click();cy.log(@@ -822,7 +822,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {});// Title of the first order for User ID = 1- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Awesome Concrete Shoes");cy.signOut();@@ -892,7 +892,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {cy.intercept("POST", "/api/dataset").as("dataset");cy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(QUESTION_NAME).click();cy.wait("@cardQuery");@@ -904,13 +904,13 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {// Click on the second bar in a graph (Category: "Widget")H.chartPathWithFillColor("#509EE3").eq(1).click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();cy.wait("@dataset").then((xhr) => {expect(xhr.response.body.error).not.to.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");H.assertQueryBuilderRowCount(6); // test that user is sandboxed - normal users has over 2000H.assertDatasetReqIsSandboxed({ requestAlias: "@dataset" });@@ -966,13 +966,13 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {cy.findByText("Our analytics").click();cy.findByText("14766_joined").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Products? → ID/).click();H.visualize((response) => {@@ -1016,9 +1016,9 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {cy.button("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Subtotal").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65").should("not.exist");H.assertQueryBuilderRowCount(11); // test that user is sandboxed - normal users has over 2000 rowsH.assertDatasetReqIsSandboxed({@@ -1092,9 +1092,9 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {});});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Twitter");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Row totals");H.assertQueryBuilderRowCount(6); // test that user is sandboxed - normal users has 30});@@ -1145,7 +1145,7 @@ describe("admin > permissions > sandboxes (tested via the API)", () => {callback: (xhr) => expect(xhr.response.body.error).not.to.exist,});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});diff --git a/e2e/test/scenarios/permissions/view-data.cy.spec.js b/e2e/test/scenarios/permissions/view-data.cy.spec.jsindex df0a9fb7694..1b81bf677dd 100644--- a/e2e/test/scenarios/permissions/view-data.cy.spec.js+++ b/e2e/test/scenarios/permissions/view-data.cy.spec.js@@ -41,7 +41,7 @@ describe("scenarios > admin > permissions > view data > blocked", () => {cy.log("assert that user properly sees native query warning related to table level blocking",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getPermissionRowPermissions("All Users").eq(DATA_ACCESS_PERM_IDX).findByLabelText("warning icon")@@ -341,7 +341,7 @@ describe(H.saveImpersonationSettings();H.savePermissions();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getPermissionRowPermissions("QA Postgres12").eq(DATA_ACCESS_PERM_IDX).findByLabelText("warning icon")@@ -591,17 +591,17 @@ describe("scenarios > admin > permissions > view data > sandboxed", () => {"include",`/admin/permissions/data/database/${SAMPLE_DB_ID}/schema/PUBLIC/table/${ORDERS_ID}/segmented/group/${ALL_USERS_GROUP}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Configure row and column security for this table");cy.button("Save").should("be.disabled");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User ID").click();cy.findByPlaceholderText("Pick a user attribute").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("attr_uid").click();cy.button("Save").click();@@ -638,11 +638,11 @@ describe("scenarios > admin > permissions > view data > sandboxed", () => {"include",`/admin/permissions/data/database/${SAMPLE_DB_ID}/schema/PUBLIC/table/${ORDERS_ID}/segmented/group/${ALL_USERS_GROUP}`,);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Configure row and column security for this table");cy.button("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Configure row and column security for this table").should("not.exist",);diff --git a/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js b/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.jsindex c679dd47814..ad5fe260dd9 100644--- a/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js+++ b/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js@@ -27,31 +27,31 @@ describe("issue 4482", () => {it("should be possible to summarize min of a temporal column (metabase#4482-1)", () => {pickMetric("Minimum of");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Created At").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("April 1, 2022, 12:00 AM");});it("should be possible to summarize max of a temporal column (metabase#4482-2)", () => {pickMetric("Maximum of");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Created At").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("April 1, 2025, 12:00 AM");});it("should be not possible to average a temporal column (metabase#4482-3)", () => {pickMetric("Average of");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At").should("not.exist");});});@@ -72,7 +72,7 @@ describe("issue 6239", () => {H.openOrdersTable({ mode: "notebook" });H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.CustomExpressionEditor.type("CountIf([Total] > 0)").format();@@ -82,13 +82,13 @@ describe("issue 6239", () => {cy.findByTestId("aggregate-step").contains("CE").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().contains("Created At").first().click();});it("should be possible to sort by using custom expression (metabase#6239)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sort").click();H.popover().contains(/^CE$/).click();@@ -212,16 +212,16 @@ describe("issue 13097", { tags: "@mongo" }, () => {it("should correctly apply distinct count on multiple columns (metabase#13097)", () => {H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Number of distinct values of ...").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("City").click();cy.findAllByTestId("notebook-cell-item").find(".Icon-add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Number of distinct values of ...").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("State").click();H.visualize();@@ -263,9 +263,9 @@ describe("postgres > user > query", { tags: "@external" }, () => {// Assertionscy.log("Fails in v0.36.6");// This could be omitted because real test is searching for "37.65" on the page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("There was a problem with your question").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});});@@ -312,16 +312,16 @@ describe("postgres > question > custom columns", { tags: "@external" }, () => {});it("`Percentile` custom expression function should accept two parameters (metabase#15714)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({formula: "Percentile([Subtotal], 0.1)",format: true,});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Function Percentile expects 1 argument").should("not.exist");H.CustomExpressionEditor.nameInput().type("Expression name");cy.button("Done").should("not.be.disabled").click();@@ -411,9 +411,9 @@ describe("issue 17512", () => {cy.findByTestId("aggregate-step").contains("CE").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At").click();addCustomColumn("1 + 1", "CC");@@ -576,7 +576,7 @@ describe("issue 17514", () => {cy.findByTextEnsureVisible("Subtotal");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").within((modal) => {@@ -589,7 +589,7 @@ describe("issue 17514", () => {it("should not show the run overlay because of the references to the orphaned fields (metabase#17514-2)", () => {openNotebookMode();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Join data").click();H.miniPicker().within(() => {cy.findByText("Sample Database").click();@@ -606,7 +606,7 @@ describe("issue 17514", () => {// Cypress cannot click elements that are blocked by an overlay so this will immediately fail if the issue is not fixedH.tableHeaderClick("Subtotal");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter by this column");});});@@ -664,7 +664,7 @@ describe("issue 17910", () => {it("revisions should work after creating a question without reloading (metabase#17910)", () => {H.openOrdersTable();cy.intercept("POST", "/api/card").as("card");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").within((modal) => {cy.findByText("Save").click();@@ -744,51 +744,51 @@ describe("issue 18207", () => {});it("should be possible to use MIN on a string column (metabase#18207, metabase#22155)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Minimum of").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Price");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rating");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ean").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Category").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey");});it("should be possible to use MAX on a string column (metabase#18207, metabase#22155)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Maximum of").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Price");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rating");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ean").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Category").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Widget");});it("should be not possible to use AVERAGE on a string column (metabase#18207, metabase#22155)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Average of").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Price");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rating");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Ean").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Category").should("not.exist");});@@ -804,24 +804,24 @@ describe("issue 18207", () => {cy.findByTestId("aggregate-step").contains("LastVendor").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Pick a column to group by").click();H.popover().contains("Category").click();H.visualize();// Why is it not a table?- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();H.leftSidebar().within(() => {cy.icon("table2").click();cy.findByTestId("Table-button").realHover();cy.icon("gear").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Done").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Zemlak-Wiegand");});});@@ -989,10 +989,10 @@ describe("issue 19341", () => {// Test "Explore results" button is hidden for native questionscy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(TEST_NATIVE_QUESTION_NAME).click();cy.wait("@cardQuery");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Explore results").should("not.exist");});});@@ -1007,7 +1007,7 @@ describe("issue 19742", () => {// and don't refresh the app state (like by doing cy.visit)it("shouldn't auto-close the data selector after a table was hidden", () => {cy.visit("/");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New").click();H.popover().findByText("Question").click();@@ -1022,13 +1022,13 @@ describe("issue 19742", () => {cy.icon("gear").click();selectFromDropdown("Admin settings");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Table Metadata").click();H.DataModel.TablePicker.getTable("Orders").button("Hide table").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Exit admin").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New").click();H.popover().findByText("Question").click();@@ -1185,7 +1185,7 @@ describe("issue 20627", () => {it("nested queries should handle long column and/or table names (metabase#20627)", () => {H.openOrdersTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Join data").click();H.miniPicker().within(() => {@@ -1193,12 +1193,12 @@ describe("issue 20627", () => {cy.findByText(newTableName).click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Summarize").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().within(() => {cy.findByText(newTableName).click();@@ -1206,7 +1206,7 @@ describe("issue 20627", () => {cy.findByText("Category").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();H.enterCustomColumnDetails({ formula: "1 + 1", name: "Math" });cy.button("Done").click();@@ -1292,7 +1292,7 @@ describe("issue 20809", () => {expect(response.body.error).to.not.exist;});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});});diff --git a/e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.js b/e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.jsindex ada1b9ab1b6..f1d71e35ea4 100644--- a/e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.js+++ b/e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.js@@ -84,9 +84,9 @@ describe("issue 24839: should be able to summarize a nested question based on thit("from the notebook GUI (metabase#24839-1)", () => {H.openNotebook();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Summarize").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of ...").click();H.popover().should("contain", "Sum of Quantity")@@ -148,7 +148,7 @@ describe("issue 25016", () => {});cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 1 row").should("be.visible");});});@@ -177,7 +177,7 @@ describe("issue 27104", () => {});it("should correctly format the filter operator after the aggregation (metabase#27104)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().findByText("Filter").click();H.popover().findByText("Count").click();// The following line is the main assertion.@@ -230,7 +230,7 @@ describe("issue 27462", () => {cy.button("Visualize").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("200").should("be.visible");});});@@ -274,7 +274,7 @@ describe("issue 28221", () => {cy.findByDisplayValue(questionName).should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(customFieldName).should("be.visible");});});@@ -352,10 +352,10 @@ describe("issue 28874", () => {it("should allow to modify a pivot question in the notebook (metabase#28874)", () => {H.visitQuestionAdhoc(questionDetails, { mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID").parent().icon("close").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID").should("not.exist");});});@@ -382,31 +382,31 @@ describe("issue 29082", () => {it("should handle nulls in quick filters (metabase#29082)", () => {H.visitQuestionAdhoc(questionDetails);cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 11 rows").should("exist");cy.get(".test-TableInteractive-emptyCell").first().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("=").click());cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 8 rows").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Discount is empty").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Discount is empty").icon("close").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 11 rows").should("exist");cy.get(".test-TableInteractive-emptyCell").first().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("≠").click());cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 3 rows").should("exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Discount is not empty").should("exist");});});diff --git a/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js b/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.jsindex beb0a92c2e1..ce2d3d39152 100644--- a/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js+++ b/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js@@ -518,7 +518,7 @@ describe("issue 40435", () => {H.getNotebookStep("data").button("Pick columns").click();H.popover().findByText("Product ID").click();H.queryBuilderHeader().findByText("Save").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.modal().last().findByText("Save").click();cy.wait("@updateCard");H.visualize();@@ -678,7 +678,7 @@ describe("issue 42244", () => {cy.findByText(COLUMN_NAME).realHover();cy.findByText("by month").should("be.visible").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Year").click();H.getNotebookStep("summarize").findByText(`${COLUMN_NAME}: Year`)@@ -1140,7 +1140,7 @@ describe("issue 31960", () => {);H.getDashboardCard().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(dotIndex).realHover();});H.assertEChartsTooltip({@@ -1150,7 +1150,7 @@ describe("issue 31960", () => {],});H.getDashboardCard().within(() => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(dotIndex).click({ force: true });});@@ -1463,7 +1463,7 @@ describe("issue 44668", () => {H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().button("Custom column").click();H.enterCustomColumnDetails({formula: 'concat("abc_", [Count])',diff --git a/e2e/test/scenarios/question/column-compare.cy.spec.ts b/e2e/test/scenarios/question/column-compare.cy.spec.tsindex 838f30121dc..0cc2117c8cf 100644--- a/e2e/test/scenarios/question/column-compare.cy.spec.ts+++ b/e2e/test/scenarios/question/column-compare.cy.spec.ts@@ -291,7 +291,7 @@ describe("scenarios > question", { tags: "@skip" }, () => {);H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getNotebookStep("summarize").findAllByTestId("aggregate-step").last()@@ -330,7 +330,7 @@ describe("scenarios > question", { tags: "@skip" }, () => {);H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getNotebookStep("summarize").findAllByTestId("aggregate-step").last()@@ -347,7 +347,7 @@ describe("scenarios > question", { tags: "@skip" }, () => {cy.findByLabelText("Unit").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Weeks").click();H.popover().within(() => {@@ -1084,7 +1084,7 @@ describe("scenarios > question", { tags: "@skip" }, () => {);H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getNotebookStep("summarize").findAllByTestId("aggregate-step").last()@@ -1101,7 +1101,7 @@ describe("scenarios > question", { tags: "@skip" }, () => {cy.findByLabelText("Unit").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Week").click();H.popover().within(() => {@@ -1918,7 +1918,7 @@ function verifyPlusButtonText(options: CheckTextOpts) {function verifyNotebookText(options: CheckTextOpts) {H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getNotebookStep("summarize").findAllByTestId("aggregate-step").last()diff --git a/e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts b/e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.tsindex edb12bd4f35..e2437250acb 100644--- a/e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts+++ b/e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts@@ -311,7 +311,7 @@ describe("scenarios > question > multiple column breakouts", () => {.findByLabelText(bucketLabel).realHover().click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(bucket1Name).click();H.getNotebookStep("summarize").findByTestId("breakout-step")@@ -321,7 +321,7 @@ describe("scenarios > question > multiple column breakouts", () => {.findByLabelText(columnName).findByLabelText(bucketLabel).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(bucket2Name).click();H.visualize();cy.wait("@dataset");@@ -527,7 +527,7 @@ describe("scenarios > question > multiple column breakouts", () => {.should("contain.text", "All time").click();H.popover().findByDisplayValue("All time").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("On").click();H.popover().within(() => {cy.findByLabelText("Date").clear().type("August 14, 2023");@@ -1851,13 +1851,13 @@ function tableHeaderClick(columnName: string,{ columnIndex = 0 }: { columnIndex?: number } = {},) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractive().findAllByText(columnName).eq(columnIndex).trigger("mousedown");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractive().findAllByText(columnName).eq(columnIndex)diff --git a/e2e/test/scenarios/question/nested.cy.spec.js b/e2e/test/scenarios/question/nested.cy.spec.jsindex 0b2e87108bc..2789de4d1b6 100644--- a/e2e/test/scenarios/question/nested.cy.spec.js+++ b/e2e/test/scenarios/question/nested.cy.spec.js@@ -47,23 +47,23 @@ describe("scenarios > question > nested", () => {);H.tableHeaderClick("Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Distribution").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Count by Total: Auto binned");H.chartPathWithFillColor("#509EE3").should("have.length.of.at.least", 8);// Go back to the nested question and make sure Sum over time works- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Nested GUI").click();H.tableHeaderClick("Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sum over time").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sum of Total by Created At: Month");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("52.76");// Make sure it works for a SQL question@@ -85,23 +85,23 @@ describe("scenarios > question > nested", () => {);H.tableHeaderClick("COUNT");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Distribution").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Count by COUNT: Auto binned");H.chartPathWithFillColor("#509EE3").should("have.length.of.at.least", 5);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Nested SQL").click();H.tableHeaderClick("COUNT");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sum over time").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sum of COUNT");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("744");});@@ -128,7 +128,7 @@ describe("scenarios > question > nested", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("10511");cy.findAllByText("June 2022");cy.findAllByText("13");@@ -244,13 +244,13 @@ describe("scenarios > question > nested", () => {// The column titleH.tableHeaderClick("Products → Category");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distribution").click();cy.wait("@dataset");H.summarize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Group by").parent().within(() => {@@ -380,32 +380,32 @@ describe("scenarios > question > nested", () => {cy.spy(win.console, "warn").as("consoleWarn");},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("New").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Question").should("be.visible").click();H.miniPicker().within(() => {cy.findByText("Our analytics").click();cy.findByText("15725").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a function or metric").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();});it("Count of rows AND Sum of VAL by CAT (metabase#15725-1)", () => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("add").last().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Sum of/).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("VAL").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of VAL");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("CAT").click();H.visualize();@@ -414,21 +414,21 @@ describe("scenarios > question > nested", () => {"not.be.calledWith","Removing invalid MBQL clause",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of VAL");});it("Count of rows by CAT + add sum of VAL later from the sidebar (metabase#15725-2)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("CAT").click();H.visualize();H.summarize();cy.findByTestId("add-aggregation-button").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Sum of/).click();H.popover().findByText("VAL").click();cy.wait("@dataset").then((xhr) => {diff --git a/e2e/test/scenarios/question/new.cy.spec.js b/e2e/test/scenarios/question/new.cy.spec.jsindex 56ebc400d0c..d589ea42eb7 100644--- a/e2e/test/scenarios/question/new.cy.spec.js+++ b/e2e/test/scenarios/question/new.cy.spec.js@@ -83,7 +83,7 @@ describe("scenarios > question > new", () => {H.notebookButton().should("not.exist");H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("18,760");// should reopen saved question picker after returning back to editor modeH.openNotebook();@@ -108,7 +108,7 @@ describe("scenarios > question > new", () => {});cy.findByTestId("data-step-cell").contains("Products");H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Rustic Paper Wallet");});@@ -238,9 +238,9 @@ describe("scenarios > question > new", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User ID is 1");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("37.65");});diff --git a/e2e/test/scenarios/question/notebook.cy.spec.js b/e2e/test/scenarios/question/notebook.cy.spec.jsindex 951456ec9db..235c704d772 100644--- a/e2e/test/scenarios/question/notebook.cy.spec.js+++ b/e2e/test/scenarios/question/notebook.cy.spec.js@@ -26,7 +26,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {cy.button("Visualize").click();// there were no changes to the question, so we shouldn't have the option to "Save"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").should("not.exist");});@@ -39,12 +39,12 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {cy.findByRole("button", { name: "Summarize" }).click();// count orders by user id, filter to the one user with 46 orders- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Pick a function or metric").click();H.popover().within(() => {cy.findByText("Count of rows").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Pick a column to group by").click();H.popover().within(() => {cy.contains("User ID").click();@@ -61,9 +61,9 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("2372"); // user's id in the table- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 1 row"); // ensure only one user was returned});@@ -97,14 +97,14 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {display: "table",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("ID is between 96 and 97").click();H.popover().findByText("Between").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Is not");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Greater than");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Less than");});@@ -113,7 +113,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {cy.intercept("POST", "/api/dataset").as("dataset");H.openProductsTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom column").click();addSimpleCustomColumn("EXPR");@@ -135,11 +135,11 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("EXPR");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("EXPR (1)");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("EXPR (2)");});@@ -167,22 +167,22 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.createQuestion(questionDetails, { visitQuestion: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 98 rows");cy.findByTestId("filters-visibility-control").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID is 2").click();H.popover().within(() => {cy.findByLabelText("Filter value").focus().type("3").blur();cy.button("Update filter").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID is 2 selections");cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 175 rows");});@@ -210,10 +210,10 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {it("should show an info card filter columns in the popover", () => {H.openOrdersTable({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add filters to narrow your answer").click();cy.findByRole("tree")@@ -295,29 +295,29 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Example");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Big");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Small");});it("should work on custom filter", () => {H.filter({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.enterCustomColumnDetails({ formula: "[Subtotal] - Tax > 140" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/^redundant input/i).should("not.exist");cy.button("Done").should("not.be.disabled").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Showing 97 rows");});@@ -382,9 +382,9 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Tax");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("ID").should("not.exist");});@@ -624,7 +624,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {horizontal,vertical,});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("notebook-cell-item").eq(index).should("have.text", name);@@ -665,7 +665,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {vertical,});});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.getNotebookStep(type).findAllByTestId("notebook-cell-item").eq(index)@@ -833,7 +833,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {.should("eq", "Revenue");});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@table").last().as("tableBody")@@ -1008,7 +1008,7 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {H.joinTable("Reviews", "Product ID", "Product ID");H.addSummaryField({ metric: "Count of rows" });H.addSummaryGroupingField({ field: "Created At" });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("button", { name: "Join data" }).last().click();H.joinTable("Reviews", "Created At: Month", "Created At");cy.button("Summarize").click();diff --git a/e2e/test/scenarios/question/nulls.cy.spec.js b/e2e/test/scenarios/question/nulls.cy.spec.jsindex b01e6a89391..e438b213ee1 100644--- a/e2e/test/scenarios/question/nulls.cy.spec.js+++ b/e2e/test/scenarios/question/nulls.cy.spec.js@@ -24,7 +24,7 @@ describe("scenarios > question > null", () => {// find and open previously created questioncy.visit("/collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("13571").click();cy.log("'No Results since at least v0.34.3");@@ -134,7 +134,7 @@ describe("scenarios > question > null", () => {H.openOrdersTable();// Total of "39.72", and the next cell is the `discount` (which is empty)- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("39.72").closest("[role=gridcell]").parent()@@ -146,10 +146,10 @@ describe("scenarios > question > null", () => {H.popover().contains("=").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("39.72");// This row ([id] 3) had the `discount` column value and should be filtered out now- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("49.21").should("not.exist");});@@ -162,7 +162,7 @@ describe("scenarios > question > null", () => {// remove pre-selected "Count"cy.icon("close").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add a function or metric").click();// dropdown immediately opens with the new set of metrics to choose fromH.popover().within(() => {@@ -170,12 +170,12 @@ describe("scenarios > question > null", () => {cy.findByText("Discount").click();});// Group by- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Created At").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Cumulative sum of Discount by Created At: Month");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("There was a problem with your question").should("not.exist",);diff --git a/e2e/test/scenarios/question/offset.cy.spec.ts b/e2e/test/scenarios/question/offset.cy.spec.tsindex a71b3b41157..21ca3aedc6c 100644--- a/e2e/test/scenarios/question/offset.cy.spec.ts+++ b/e2e/test/scenarios/question/offset.cy.spec.ts@@ -176,7 +176,7 @@ describe("scenarios > question > offset", () => {const columnIndex = 9;const columnsCount = 10;const cellIndex = rowIndex * columnsCount + columnIndex;- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("gridcell").eq(cellIndex).click();cy.get(H.POPOVER_ELEMENT).should("not.exist");@@ -557,7 +557,7 @@ describe("scenarios > question > offset", () => {table: "Product",field: "Category",});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByLabelText("Custom column").last().click();H.enterCustomColumnDetails({@@ -566,7 +566,7 @@ describe("scenarios > question > offset", () => {});H.popover().findByText("Done").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().icon("filter").click();H.popover().findByText("Custom Expression").click();@@ -575,7 +575,7 @@ describe("scenarios > question > offset", () => {});H.popover().findByText("Done").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().icon("sort").click();H.popover().findByText(OFFSET_SUM_TOTAL_AGGREGATION_NAME).click();H.getNotebookStep("sort", { stage: 1, index: 0 })@@ -1358,7 +1358,7 @@ function verifyTableContent(rows: string[][]) {}function verifyTableCellContent(index: number, text: string) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("gridcell").eq(index).should("have.text", text);}@@ -1428,7 +1428,7 @@ function addCustomColumn({if (actionButtonsGroup === "first") {cy.findAllByTestId("action-buttons").first().icon("add_data").click();} else {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().icon("add_data").click();}diff --git a/e2e/test/scenarios/question/query-external.cy.spec.js b/e2e/test/scenarios/question/query-external.cy.spec.jsindex 880b02c7e5a..415617edd40 100644--- a/e2e/test/scenarios/question/query-external.cy.spec.js+++ b/e2e/test/scenarios/question/query-external.cy.spec.js@@ -41,7 +41,7 @@ supportedDatabases.forEach(({ database, snapshotName, dbName }) => {});H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("37.65");});},diff --git a/e2e/test/scenarios/question/question-management.cy.spec.js b/e2e/test/scenarios/question/question-management.cy.spec.jsindex 5d690c4dc39..be27b5bbd95 100644--- a/e2e/test/scenarios/question/question-management.cy.spec.js+++ b/e2e/test/scenarios/question/question-management.cy.spec.js@@ -44,7 +44,7 @@ describe(.blur();assertRequestNot403("updateQuestion");assertNoPermissionsError();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders1");});@@ -58,7 +58,7 @@ describe(assertRequestNot403("updateQuestion");assertNoPermissionsError();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("foo");});@@ -405,7 +405,7 @@ describe(cy.findByTestId("archive-button").should("not.exist");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Revert").should("not.exist");});diff --git a/e2e/test/scenarios/question/saved.cy.spec.js b/e2e/test/scenarios/question/saved.cy.spec.jsindex 4c98554e590..a1c366446b5 100644--- a/e2e/test/scenarios/question/saved.cy.spec.js+++ b/e2e/test/scenarios/question/saved.cy.spec.js@@ -30,13 +30,13 @@ describe("scenarios > question > saved", () => {cy.findByText("100").click();cy.findByText("Add filter").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quantity is equal to 100");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 2 rows"); // query updated// check that save will give option to replace- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();cy.findByTestId("save-question-modal").within((modal) => {cy.findByText('Replace original question, "Orders"');@@ -45,13 +45,13 @@ describe("scenarios > question > saved", () => {});// click "Started from Orders" and check that the original question is restored- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Started from").within(() => cy.findByText("Orders").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing first 2,000 rows"); // query updated- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Started from").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quantity is equal to 100").should("not.exist");});@@ -244,10 +244,10 @@ describe("scenarios > question > saved", () => {it("should show collection breadcrumbs for a saved question in the root collection", () => {H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.appBar().within(() => cy.findByText("Our analytics").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");});@@ -257,10 +257,10 @@ describe("scenarios > question > saved", () => {});H.visitQuestion(ORDERS_QUESTION_ID);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.appBar().within(() => cy.findByText("Second collection").click());- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");});@@ -284,7 +284,7 @@ describe("scenarios > question > saved", () => {cy.findByText("Orders in a dashboard").should("not.exist");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Orders").should("be.visible");});diff --git a/e2e/test/scenarios/question/settings.cy.spec.js b/e2e/test/scenarios/question/settings.cy.spec.jsindex 9adc3cbf7b8..d885dc39d4c 100644--- a/e2e/test/scenarios/question/settings.cy.spec.js+++ b/e2e/test/scenarios/question/settings.cy.spec.js@@ -197,7 +197,7 @@ describe("scenarios > question > settings", () => {*/function findColumnAtIndex(column_name, index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn getVisibleSidebarColumns().eq(index).contains(column_name);}});@@ -249,7 +249,7 @@ describe("scenarios > question > settings", () => {});H.openVizSettingsSidebar(); // open settings sidebar- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Conditional Formatting"); // confirm it's openH.tableHeaderClick("Subtotal"); // open subtotal column header actions@@ -257,7 +257,7 @@ describe("scenarios > question > settings", () => {H.popover().icon("gear").click(); // open subtotal column settings//cy.findByText("Table options").should("not.exist"); // no longer displaying the top level settings- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Separator style"); // shows subtotal column settingscy.findByTestId("head-crumbs-container").findByText("Orders").click(); //Dismiss popover@@ -267,7 +267,7 @@ describe("scenarios > question > settings", () => {H.popover().within(() => {cy.icon("gear").click(); // open created_at column settings});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Date style"); // shows created_at column settings});@@ -292,7 +292,7 @@ describe("scenarios > question > settings", () => {H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(newColumnTitle);H.openVizSettingsSidebar();@@ -311,19 +311,19 @@ describe("scenarios > question > settings", () => {});cy.findByDisplayValue("Normal").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Currency").click();cy.findByDisplayValue("US Dollar").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Bitcoin").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("In every table cell").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("₿ 2.07");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("₿ 6.10");});@@ -559,9 +559,9 @@ describe("scenarios > question > settings", () => {H.openNavigationSidebar();H.browseDatabases().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Sample Database").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Orders").click();// This next assertion might not catch bugs where the modal displays afterdiff --git a/e2e/test/scenarios/question/summarization.cy.spec.js b/e2e/test/scenarios/question/summarization.cy.spec.jsindex f5d4f6f2b09..610d35683b2 100644--- a/e2e/test/scenarios/question/summarization.cy.spec.js+++ b/e2e/test/scenarios/question/summarization.cy.spec.js@@ -83,7 +83,7 @@ describe("scenarios > question > summarize sidebar", () => {H.getRemoveDimensionButton({ name: "User → State" }).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User → State").should("not.exist");});@@ -138,7 +138,7 @@ describe("scenarios > question > summarize sidebar", () => {{ visitQuestion: true },);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("49.54");});@@ -159,7 +159,7 @@ describe("scenarios > question > summarize sidebar", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("318.7");});@@ -205,7 +205,7 @@ describe("scenarios > question > summarize sidebar", () => {cy.findByLabelText("Temporal bucket").realHover().click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().within(() => {@@ -270,7 +270,7 @@ describe("scenarios > question > summarize sidebar", () => {H.openReviewsTable();H.summarize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Group by").parent().findByText("Title")diff --git a/e2e/test/scenarios/search/recently-viewed.cy.spec.js b/e2e/test/scenarios/search/recently-viewed.cy.spec.jsindex 1e5c4752108..6af45d04978 100644--- a/e2e/test/scenarios/search/recently-viewed.cy.spec.js+++ b/e2e/test/scenarios/search/recently-viewed.cy.spec.js@@ -153,10 +153,10 @@ describe("search > recently viewed > enterprise features", () => {});const assertRecentlyViewedItem = (index, title, type) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("recently-viewed-item-title").eq(index).should("have.text", title);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("result-link-wrapper").eq(index).should("have.text", type);};diff --git a/e2e/test/scenarios/search/search-pagination.cy.spec.js b/e2e/test/scenarios/search/search-pagination.cy.spec.jsindex 1250247cd76..f23625a396c 100644--- a/e2e/test/scenarios/search/search-pagination.cy.spec.js+++ b/e2e/test/scenarios/search/search-pagination.cy.spec.js@@ -43,7 +43,7 @@ describe("scenarios > search", () => {cy.findByLabelText("Previous page").should("be.disabled");// First page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("search-result-item").should("have.length", PAGE_SIZE);@@ -51,7 +51,7 @@ describe("scenarios > search", () => {cy.findByLabelText("Next page").click();// Second page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${PAGE_SIZE + 1} - ${TOTAL_ITEMS}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("search-result-item").should("have.length", 1);@@ -60,7 +60,7 @@ describe("scenarios > search", () => {cy.findByLabelText("Previous page").click();// First page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`1 - ${PAGE_SIZE}`);cy.findByTestId("pagination-total").should("have.text", TOTAL_ITEMS);cy.findAllByTestId("search-result-item").should("have.length", PAGE_SIZE);diff --git a/e2e/test/scenarios/sharing/downloads/downloads.cy.spec.js b/e2e/test/scenarios/sharing/downloads/downloads.cy.spec.jsindex 064d905969d..f56b0ccab33 100644--- a/e2e/test/scenarios/sharing/downloads/downloads.cy.spec.js+++ b/e2e/test/scenarios/sharing/downloads/downloads.cy.spec.js@@ -58,7 +58,7 @@ describe("scenarios > question > download", () => {});H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("18,760");H.downloadAndAssert({ fileType });@@ -336,7 +336,7 @@ describe("scenarios > question > download", () => {H.popover().within(() => H.fieldValuesCombobox().type("1"));- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add filter").click();cy.wait("@dashboard");diff --git a/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js b/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.jsindex 06b03b7a863..4c9c118a40d 100644--- a/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js+++ b/e2e/test/scenarios/sharing/downloads/sharing-download-reproductions.cy.spec.js@@ -35,7 +35,7 @@ describe("issue 10803", () => {it(`should format the date properly for ${fileType} in unsaved questions`, () => {// Add a space at the end of the query to make it "dirty"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/open editor/i).click();H.NativeEditor.focus().type("{movetoend} ");@@ -166,9 +166,9 @@ describe("issue 18440", () => {it(`export should include a column with remapped values for ${fileType} (metabase#18440-1)`, () => {H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Awesome Concrete Shoes");H.downloadAndAssert({ fileType });@@ -218,9 +218,9 @@ describe("issue 18573", () => {it("for the remapped columns, it should preserve renamed column name in exports for xlsx (metabase#18573)", () => {H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Foo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Awesome Concrete Shoes");H.downloadAndAssert({ fileType: "xlsx" });@@ -288,21 +288,21 @@ describe("issue 19889", () => {});// Reorder columns a and b- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("column a").trigger("mousedown", 0, 0).wait(100); //Don't force the first interaction. This ensures things are actually visible to start moving- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("column a").trigger("mousemove", 10, 10, { force: true }).wait(100);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("column a").trigger("mousemove", 100, 0, { force: true }).wait(100);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("column a").trigger("mouseup", 100, 0, { force: true }).wait(100);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Started from").click(); // Give DOM some time to update});@@ -320,7 +320,7 @@ describe("issue 19889", () => {});it("should order columns correctly in saved native query exports when the query was modified but not re-run before save (#19889)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains(/open editor/i).click();H.NativeEditor.focus().type('{selectall}select 1 "column x", 2 "column y", 3 "column c"',diff --git a/e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js b/e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.jsindex 869aac67ace..1557abeccc2 100644--- a/e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js+++ b/e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js@@ -43,7 +43,7 @@ describe("issue 18009", { tags: "@external" }, () => {.click();// Click anywhere to close the popover that covers the "Send email now" button- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("To:").click();H.sendEmailAndAssert((email) => {@@ -83,21 +83,21 @@ describe("issue 18344", { tags: "@external" }, () => {});H.saveDashboard();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("OrdersFoo");});it("subscription should not include original question name when it's been renamed in the dashboard (metabase#18344)", () => {// Send a test email subscriptionH.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();cy.findByPlaceholderText("Enter user names or email addresses").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${first_name} ${last_name}`).click();// Click this just to close the popover that is blocking the "Send email now" button- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("To:").click();H.sendEmailAndAssert((email) => {@@ -136,14 +136,14 @@ describe("issue 18352", { tags: "@external" }, () => {it("should send the card with the INT64 values (metabase#18352)", () => {H.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();cy.findByPlaceholderText("Enter user names or email addresses").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${first_name} ${last_name}`).click();// Click this just to close the popover that is blocking the "Send email now" button- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("To:").click();H.sendEmailAndAssert(({ html }) => {@@ -206,7 +206,7 @@ describe("issue 18669", { tags: "@external" }, () => {it("should send a test email with non-default parameters (metabase#18669)", () => {H.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();cy.findByPlaceholderText("Enter user names or email addresses")@@ -264,7 +264,7 @@ describe("issue 20393", () => {H.popover().contains("CREATED_AT").click();// save the dashboard- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").click();// open the sharing modal and enable sharing@@ -279,7 +279,7 @@ describe("issue 20393", () => {});// verify that the card is visible on the page- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Q2");});});@@ -391,7 +391,7 @@ describe("issue 22524", () => {H.editDashboard();H.setFilter("Text or Category", "Is");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Select…").click();H.popover().contains("City").click();@@ -411,7 +411,7 @@ describe("issue 22524", () => {cy.findByPlaceholderText("Text").clear().type("Rye{enter}");// Check results- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2-7900 Cuerno Verde Road");});});@@ -558,7 +558,7 @@ describe("issue 25473", () => {};function assertOnResults() {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").last().should("have.text", ccName);cy.findAllByText("xavier").should("have.length", 2);@@ -772,7 +772,7 @@ describe("issue 17657", () => {H.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Emailed monthly/).click();H.sidebar().within(() => {@@ -782,7 +782,7 @@ describe("issue 17657", () => {// Open the popover with all userscy.findByPlaceholderText("Enter user names or email addresses").click();// Pick admin as a recipient- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(`${first_name} ${last_name}`).click();H.sidebar().within(() => {@@ -867,12 +867,12 @@ describe("issue 17658", { tags: "@external" }, () => {H.openSharingMenu("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Emailed monthly/).click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete this subscription").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^This dashboard will no longer be emailed to/).click();cy.button("Delete").click();diff --git a/e2e/test/scenarios/sharing/subscriptions.cy.spec.js b/e2e/test/scenarios/sharing/subscriptions.cy.spec.jsindex 74d91f7d988..50f05b37eaf 100644--- a/e2e/test/scenarios/sharing/subscriptions.cy.spec.js+++ b/e2e/test/scenarios/sharing/subscriptions.cy.spec.js@@ -33,7 +33,7 @@ describe("scenarios > dashboard > subscriptions", () => {});H.addTextBox("Foo");cy.button("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You're editing this dashboard.").should("not.exist");H.openSharingMenu();// Dashboard subscriptions are not shown because@@ -82,16 +82,16 @@ describe("scenarios > dashboard > subscriptions", () => {it("should not enable subscriptions without the recipient (metabase#17657)", () => {openDashboardSubscriptions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();// Make sure no recipients have been assignedcy.findByPlaceholderText("Enter user names or email addresses");// Change the schedule to "Monthly"- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Hourly").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Monthly").click();H.sidebar().within(() => {@@ -101,7 +101,7 @@ describe("scenarios > dashboard > subscriptions", () => {it("should allow creation of a new email subscription", () => {createEmailSubscription();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Emailed hourly");});@@ -124,7 +124,7 @@ describe("scenarios > dashboard > subscriptions", () => {it("should not render people dropdown outside of the borders of the screen (metabase#17186)", () => {openDashboardSubscriptions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();cy.findByPlaceholderText("Enter user names or email addresses").click();@@ -150,7 +150,7 @@ describe("scenarios > dashboard > subscriptions", () => {it("should show existing dashboard subscriptions", () => {createEmailSubscription();openDashboardSubscriptions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Emailed hourly");});@@ -310,16 +310,16 @@ describe("scenarios > dashboard > subscriptions", () => {// This is extremely fragile// TODO: update test once changes from `https://github.com/metabase/metabase/pull/14121` are merged into `master`cy.findByLabelText("Attach results").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Questions to attach").click();clickButton("Done");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Subscriptions");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Emailed hourly").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Delete this subscription").scrollIntoView();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Questions to attach");cy.findAllByRole("listitem").contains("Orders")@@ -354,20 +354,20 @@ describe("scenarios > dashboard > subscriptions", () => {it("should not display 'null' day of the week (metabase#14405)", () => {assignRecipient();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("To:").click();cy.findAllByTestId("select-button").contains("Hourly").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Monthly").click();cy.findAllByTestId("select-button").contains("First").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("15th (Midpoint)").click();cy.findAllByTestId("select-button").contains("15th (Midpoint)").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("First").click();clickButton("Done");// Implicit assertion (word mustn't contain string "null")- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^Emailed monthly on the first (?!null)/);});@@ -423,7 +423,7 @@ describe("scenarios > dashboard > subscriptions", () => {);});// Click anywhere outside to close the popover- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("15705D").click();H.sendEmailAndAssert((email) => {expect(email.html).not.to.include(@@ -439,11 +439,11 @@ describe("scenarios > dashboard > subscriptions", () => {H.visitDashboard(ORDERS_DASHBOARD_ID);H.addTextBox(TEXT_CARD);cy.button("Save").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("You're editing this dashboard.").should("not.exist");assignRecipient();// Click outside popover to close it and at the same time check that the text card content is shown as expected- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(TEXT_CARD).click();H.sendEmailAndAssert((email) => {expect(email.html).to.include(TEXT_CARD);@@ -493,7 +493,7 @@ describe("scenarios > dashboard > subscriptions", () => {cy.findAllByRole("button", { name: "Done" }).should("be.disabled");cy.findByPlaceholderText("Pick a user or channel...").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("#work").click();cy.findAllByRole("button", { name: "Done" }).should("not.be.disabled");});@@ -646,10 +646,10 @@ describe("scenarios > dashboard > subscriptions", () => {describe("with no parameters", () => {it("should have no parameters section", () => {openDashboardSubscriptions();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Email it").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Set filter values for when this gets sent").should("not.exist",);@@ -742,10 +742,10 @@ describe("scenarios > dashboard > subscriptions", () => {assignRecipient();clickButton("Done");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Emailed hourly").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText("Corbin Mertz").last().click();H.popover().within(() => {H.fieldValuesCombobox().type("Bob");@@ -753,7 +753,7 @@ describe("scenarios > dashboard > subscriptions", () => {});H.popover().contains("Update filter").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText("Text 1").last().click();H.popover().findByText("Gizmo").click();H.popover().contains("Add filter").click();diff --git a/e2e/test/scenarios/table-editing/table-editing.cy.spec.ts b/e2e/test/scenarios/table-editing/table-editing.cy.spec.tsindex cfc8c014fc6..5050de95c26 100644--- a/e2e/test/scenarios/table-editing/table-editing.cy.spec.ts+++ b/e2e/test/scenarios/table-editing/table-editing.cy.spec.ts@@ -399,7 +399,7 @@ describe("scenarios > table-editing", () => {cy.get('select[data-am-pm="true"]').as("ampmSelect");cy.get("@ampmSelect").select("AM");// It's safe to click the last button because we're in the popover- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("button").last().click();});diff --git a/e2e/test/scenarios/visualizations-charts/bar_chart.cy.spec.js b/e2e/test/scenarios/visualizations-charts/bar_chart.cy.spec.jsindex d0a7dc29e92..f7998199784 100644--- a/e2e/test/scenarios/visualizations-charts/bar_chart.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/bar_chart.cy.spec.js@@ -54,7 +54,7 @@ describe("scenarios > visualizations > bar chart", () => {}),);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("(empty)").should("not.exist");});@@ -67,7 +67,7 @@ describe("scenarios > visualizations > bar chart", () => {}),);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("(empty)");});});@@ -89,9 +89,9 @@ describe("scenarios > visualizations > bar chart", () => {});H.chartPathWithFillColor("#509EE3").should("have.length", 5); // there are six bars when null isn't filtered- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,800"); // correct data has this on the y-axis- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("16,000").should("not.exist"); // If nulls are included the y-axis stretches much higher});});@@ -322,10 +322,10 @@ describe("scenarios > visualizations > bar chart", () => {});cy.findAllByTestId("legend-item").findByText("Doohickey").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Products").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Category is Doohickey").should("be.visible");});});@@ -853,7 +853,7 @@ describe("scenarios > visualizations > bar chart", () => {H.popover().findByTestId("graph-other-category-aggregation-fn-picker").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(fnName).click();}diff --git a/e2e/test/scenarios/visualizations-charts/gauge.cy.spec.js b/e2e/test/scenarios/visualizations-charts/gauge.cy.spec.jsindex df5e88b6220..aba06895d93 100644--- a/e2e/test/scenarios/visualizations-charts/gauge.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/gauge.cy.spec.js@@ -38,7 +38,7 @@ describe("scenarios > visualizations > gauge chart", () => {);cy.findByTestId("gauge-arc-1").trigger("mousemove");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Something went wrong").should("not.exist");});});diff --git a/e2e/test/scenarios/visualizations-charts/legend.cy.spec.js b/e2e/test/scenarios/visualizations-charts/legend.cy.spec.jsindex da22123f200..35e9b4a07f9 100644--- a/e2e/test/scenarios/visualizations-charts/legend.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/legend.cy.spec.js@@ -558,7 +558,7 @@ describe("scenarios > visualizations > legend", () => {});function hideSeries(legendItemIndex) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("legend-item").eq(legendItemIndex).findByLabelText("Hide series")@@ -566,7 +566,7 @@ function hideSeries(legendItemIndex) {}function showSeries(legendItemIndex) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("legend-item").eq(legendItemIndex).findByLabelText("Show series")diff --git a/e2e/test/scenarios/visualizations-charts/line-bar-tooltips.cy.spec.js b/e2e/test/scenarios/visualizations-charts/line-bar-tooltips.cy.spec.jsindex b33b2cc1640..a6bd3647b9e 100644--- a/e2e/test/scenarios/visualizations-charts/line-bar-tooltips.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/line-bar-tooltips.cy.spec.js@@ -1142,13 +1142,13 @@ function setupDashboard(function showTooltipForCircleInSeries(seriesColor, index = 0) {H.echartsTriggerBlur();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircleWithColor(seriesColor).eq(index).trigger("mousemove");}function showTooltipForBarInSeries(seriesColor, index = 0) {H.echartsTriggerBlur();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.chartPathWithFillColor(seriesColor).eq(index).realHover();}diff --git a/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js b/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.jsindex e868c4db2ea..3101e844684 100644--- a/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js@@ -37,7 +37,7 @@ describe("scenarios > visualizations > line chart", () => {cy.wrap({ x, y }).as("leftAxisLabelPosition");});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Right").click();H.echartsContainer().findByText("Count")@@ -239,7 +239,7 @@ describe("scenarios > visualizations > line chart", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("This chart type doesn't support more than 100 series of data.",);@@ -612,7 +612,7 @@ describe("scenarios > visualizations > line chart", () => {},display: "line",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Category is Doohickey");});diff --git a/e2e/test/scenarios/visualizations-charts/maps.cy.spec.js b/e2e/test/scenarios/visualizations-charts/maps.cy.spec.jsindex 454703d235d..96561f28ebd 100644--- a/e2e/test/scenarios/visualizations-charts/maps.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/maps.cy.spec.js@@ -20,7 +20,7 @@ describe("scenarios > visualizations > maps", () => {cy.findByTestId("native-query-editor-container").icon("play").click();// switch to a pin map visualization- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();cy.icon("pinmap").click();cy.findByTestId("Map-container").within(() => {@@ -216,21 +216,21 @@ describe("scenarios > visualizations > maps", () => {cy.get("@texas").trigger("mousemove");// check tooltip content- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("State:"); // column name key- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Texas"); // feature name as value// open drill-through menu and drill within itcy.get("@texas").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/See these People/i).click();cy.log("Reported as a regression since v0.37.0");cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("State is TX");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("171 Olive Oyle Lane"); // Address in the first row});@@ -316,11 +316,11 @@ describe("scenarios > visualizations > maps", () => {cy.get(".leaflet-interactive").trigger("mousemove");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Latitude: 10°:");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Longitude: 10°:");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1");});@@ -349,7 +349,7 @@ describe("scenarios > visualizations > maps", () => {// Ensure chart is renderedcy.get(".leaflet-interactive");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").click();// Ensure the Map visualization is sensiblediff --git a/e2e/test/scenarios/visualizations-charts/pie_chart.cy.spec.js b/e2e/test/scenarios/visualizations-charts/pie_chart.cy.spec.jsindex 5735a206b36..83e7d0bd8a8 100644--- a/e2e/test/scenarios/visualizations-charts/pie_chart.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/pie_chart.cy.spec.js@@ -296,7 +296,7 @@ describe("scenarios > visualizations > pie chart", () => {H.openVizSettingsSidebar();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("chartsettings-field-picker").last().within(() => {@@ -308,7 +308,7 @@ describe("scenarios > visualizations > pie chart", () => {["Affiliate", "Facebook", "Google", "Organic", "Twitter"],);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("chartsettings-field-picker").last().within(() => {@@ -726,7 +726,7 @@ function confirmSliceClickBehavior(sliceLabel, value, elementIndex) {if (elementIndex == null) {cy.findByText(sliceLabel).click({ force: true });} else {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByText(sliceLabel).eq(elementIndex).click({ force: true });}});diff --git a/e2e/test/scenarios/visualizations-charts/rows.cy.spec.js b/e2e/test/scenarios/visualizations-charts/rows.cy.spec.jsindex e0745c90689..4c7d0385799 100644--- a/e2e/test/scenarios/visualizations-charts/rows.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/rows.cy.spec.js@@ -96,7 +96,7 @@ describe("scenarios > visualizations > rows", () => {.realHover().invoke("width").then((newWidth) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringexpect(prevWidth).eq(newWidth);});});diff --git a/e2e/test/scenarios/visualizations-charts/scatter.cy.spec.js b/e2e/test/scenarios/visualizations-charts/scatter.cy.spec.jsindex cea689079a3..3dcc6e90a52 100644--- a/e2e/test/scenarios/visualizations-charts/scatter.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/scatter.cy.spec.js@@ -136,7 +136,7 @@ describe("scenarios > visualizations > scatter", () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization");cy.findAllByText("79").should("not.exist");});@@ -241,7 +241,7 @@ function triggerPopoverForBubble(index = 13, force = false) {cy.findByLabelText("Switch to visualization").click(); // ... and then back to the scatter visualization (that now seems to be stable enough to make assertions about)});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(index) // Random bubble.trigger("mousemove", { force });diff --git a/e2e/test/scenarios/visualizations-charts/trendline.cy.spec.js b/e2e/test/scenarios/visualizations-charts/trendline.cy.spec.jsindex f9df8b25764..c0804cb7da4 100644--- a/e2e/test/scenarios/visualizations-charts/trendline.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/trendline.cy.spec.js@@ -37,7 +37,7 @@ describe("scenarios > question > trendline", () => {// Remove sum of totalH.leftSidebar().within(() => {cy.findByText("Data").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("close").last().click({ force: true });cy.findByText("Done").click();});diff --git a/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js b/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.jsindex 7ba2505180f..3e02a4d3a45 100644--- a/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/visualizations-charts-reproductions.cy.spec.js@@ -166,11 +166,11 @@ describe("issue 17524", () => {cy.get("polygon");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.icon("play").last().click();cy.get("polygon");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Save").should("not.exist");});});@@ -324,7 +324,7 @@ describe("issue 18061", () => {addFilter("Twitter");cy.wait("@dashCardQuery");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Something went wrong").should("not.exist");cy.location("search").should("eq", "?category=Twitter");@@ -335,9 +335,9 @@ describe("issue 18061", () => {it("should handle data sets that contain only null values for longitude/latitude (metabase#18061-3)", () => {H.visitAlias("@publicLink");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("18061D");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("18061");cy.get("[data-element-id=pin-map]");@@ -435,7 +435,7 @@ describe("issue 18776", () => {it("should not freeze when opening a timeseries chart with sparse data and without the X-axis", () => {H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");});});@@ -713,7 +713,7 @@ describe("issue 22527", { tags: "@skip" }, () => {cy.findByTextEnsureVisible("Data").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Bubble size").parent().contains("Select a field").click();H.popover().contains(/size/i).click();@@ -739,7 +739,7 @@ describe("issue 25007", () => {};const clickLineDot = ({ index } = {}) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(index).click({ force: true });};@@ -962,7 +962,7 @@ describe("issue 27427", () => {const addCountGreaterThan2Filter = () => {H.openNotebook();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("action-buttons").last().button("Filter").click();H.popover().findByText("Count").click();H.selectFilterOperator("Greater than");diff --git a/e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.js b/e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.jsindex d84789136d4..362bd47f747 100644--- a/e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.js+++ b/e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.js@@ -29,7 +29,7 @@ describe("scenarios > visualizations > waterfall", () => {"select 'A' as product, 10 as profit union select 'B' as product, -4 as profit",);cy.findByTestId("native-query-editor-container").icon("play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();cy.icon("waterfall").click();@@ -41,18 +41,18 @@ describe("scenarios > visualizations > waterfall", () => {H.NativeEditor.type("select 1 as X, 20 as Y union select 2 as X, -10 as Y");cy.findByTestId("native-query-editor-container").icon("play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();switchToWaterfallDisplay();H.sidebar().findAllByPlaceholderText("Select a field").first().click();H.popover().findByText("X").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().findAllByPlaceholderText("Select a field").last().click();H.popover().findByText("Y").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Axes").click();H.sidebar().findAllByDisplayValue("Linear").first().click();@@ -65,14 +65,14 @@ describe("scenarios > visualizations > waterfall", () => {H.startNewNativeQuestion();H.NativeEditor.type("select 1 as X, 10 as Y union select 2 as X, -2 as Y");cy.findByTestId("native-query-editor-container").icon("play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();switchToWaterfallDisplay();H.sidebar().findAllByPlaceholderText("Select a field").first().click();H.popover().findByText("X").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().findAllByPlaceholderText("Select a field").last().click();H.popover().findByText("Y").click();@@ -82,15 +82,15 @@ describe("scenarios > visualizations > waterfall", () => {it("should work with time-series data", () => {H.openOrdersTable({ mode: "notebook" });H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Filter").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Custom Expression").click();H.CustomExpressionEditor.type("between([Created At: Month], '2022-01-01', '2022-08-01')",@@ -99,7 +99,7 @@ describe("scenarios > visualizations > waterfall", () => {H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();switchToWaterfallDisplay();@@ -109,16 +109,16 @@ describe("scenarios > visualizations > waterfall", () => {it("should hide the Total label if there is no space", () => {H.openOrdersTable({ mode: "notebook" });H.summarize({ mode: "notebook" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count of rows").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Created At").click();H.visualize();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();switchToWaterfallDisplay();@@ -217,20 +217,20 @@ describe("scenarios > visualizations > waterfall", () => {display: "line",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").click();switchToWaterfallDisplay();H.sidebar().findAllByPlaceholderText("Select a field").first().click();H.popover().findByText("Created At: Year").click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.sidebar().findAllByPlaceholderText("Select a field").last().click();H.popover().findByText("Count").click();H.echartsContainer().should("exist"); // Chart renders after adding a metric- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Add another/).should("not.exist");});@@ -245,7 +245,7 @@ describe("scenarios > visualizations > waterfall", () => {database: SAMPLE_DB_ID,},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").click();cy.icon("waterfall").click({ force: true });H.chartPathWithFillColor("#88BF4D").should("be.visible");@@ -268,14 +268,14 @@ describe("scenarios > visualizations > waterfall", () => {},});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetWaterfallDataLabels().as("labels").eq(-3).invoke("text").should("eq", "0");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@labels").last().invoke("text").should("eq", "0.1");});@@ -299,7 +299,7 @@ describe("scenarios > visualizations > waterfall", () => {// the null data label which should exist at index -3// should now display no label. so the label at index -3 should be the label// before the null data point- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetWaterfallDataLabels().as("labels").eq(-3)@@ -309,14 +309,14 @@ describe("scenarios > visualizations > waterfall", () => {// but the x-axis label and area should still be shown for the null data pointH.echartsContainer().findByText("f");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringgetWaterfallDataLabels().as("labels").eq(-2).invoke("text").should("eq", "(2)");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@labels").last().invoke("text").should("eq", "0.1");});@@ -434,24 +434,24 @@ describe("scenarios > visualizations > waterfall", () => {H.startNewNativeQuestion();H.NativeEditor.type("select 'A' as X, -4.56 as Y");cy.findByTestId("native-query-editor-container").icon("play").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Visualization").click();switchToWaterfallDisplay();});it("should have increase, decrease, and total color options", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Display").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Increase color").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Decrease color").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Total color").click();});it("should allow toggling of the total bar", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Display").click();cy.get('[data-field-title="Show total"]').within(() => {@@ -467,7 +467,7 @@ describe("scenarios > visualizations > waterfall", () => {});it("should allow toggling of value labels", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Display").click();H.echartsContainer().get("text").contains("(4.56)").should("not.exist");diff --git a/e2e/test/scenarios/visualizations-tabular/column-shortcuts.cy.spec.ts b/e2e/test/scenarios/visualizations-tabular/column-shortcuts.cy.spec.tsindex 624c573b23a..a5dc0ced971 100644--- a/e2e/test/scenarios/visualizations-tabular/column-shortcuts.cy.spec.ts+++ b/e2e/test/scenarios/visualizations-tabular/column-shortcuts.cy.spec.ts@@ -334,13 +334,13 @@ function extractColumnAndCheck({cy.wait(`@${requestAlias}`);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").last().should("have.text", newColumn).should("be.visible");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").last().should("have.text", newColumn);if (value) {cy.findByRole("gridcell", { name: value }).should("be.visible");@@ -376,7 +376,7 @@ describe("scenarios > visualizations > combine shortcut", () => {cy.wait(`@${requestAlias}`);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").last().should("have.text", newColumn)@@ -388,9 +388,9 @@ describe("scenarios > visualizations > combine shortcut", () => {}function selectColumn(index: number, name: string) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().findAllByTestId("column-input").eq(index).click();- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(name).click();}diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.jsindex ff72b63c1cc..8f469cea04a 100644--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js@@ -252,26 +252,26 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {H.addSummaryField({ metric: "Count of rows" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pick a column to group by").click();H.popover().within(() => {cy.findByText("City").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualize").click();cy.wait("@dataset");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Count by City");H.chartPathWithFillColor("#509EE3").first().click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("See this CA Person").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("City is Beaver Dams");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("Dominique Leffler");});@@ -571,15 +571,15 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {},display: "table",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/^10 –/).parent().parent().next().contains("85").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quantity is greater than or equal to 10");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Quantity is less than 20");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 85 rows");});@@ -601,14 +601,14 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {});// click on the Count column cell showing the count of null rows- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("16,845").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();// count number of distinct values in the Discount columnH.tableHeaderClick("Discount ($)");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Distinct values").click();// there should be 0 distinct values since they are all null@@ -706,7 +706,7 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {H.visitQuestionAdhoc(questionDetails);// Drill-through the last bar (Widget)- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.chartPathWithFillColor("#509EE3").last().click();H.popover().findByTextEnsureVisible("See these Products").click();});diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/column_extract_drill.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/column_extract_drill.cy.spec.jsindex 4579ec2e697..de564aff781 100644--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/column_extract_drill.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/column_extract_drill.cy.spec.js@@ -296,13 +296,13 @@ describe("extract action", () => {it("should be able to extract path from URL column", () => {function assertTableData({ title, value }) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractive().findAllByTestId("header-cell").last().should("have.text", title);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractiveBody().findAllByTestId("cell-data").last()@@ -383,7 +383,7 @@ function extractColumnAndCheck({H.popover().findByText(option).click();cy.wait(`@${requestAlias}`);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("columnheader").last().scrollIntoView()diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/combine-column.cy.spec.ts b/e2e/test/scenarios/visualizations-tabular/drillthroughs/combine-column.cy.spec.tsindex a577a1d4735..ee6d85c7595 100644--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/combine-column.cy.spec.ts+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/combine-column.cy.spec.ts@@ -41,7 +41,7 @@ describe("scenarios > visualizations > drillthroughs > table_drills > combine cocy.findByText("ID").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText("Name").click();H.popover().within(() => {@@ -58,14 +58,14 @@ describe("scenarios > visualizations > drillthroughs > table_drills > combine co"[email protected]__text__12345",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("textbox").last().clear();cy.findByTestId("combine-example").should("have.text","[email protected]__text12345",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("textbox").last().clear().type("+");cy.findByTestId("combine-example").should("have.text",@@ -75,7 +75,7 @@ describe("scenarios > visualizations > drillthroughs > table_drills > combine cocy.findByText("Done").click();});- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("header-cell").last().should("have.text", "Combined Email, Name, ID");diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/dash_drill.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/dash_drill.cy.spec.jsindex 89cb08ec8af..aae77dac242 100644--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/dash_drill.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/dash_drill.cy.spec.js@@ -30,7 +30,7 @@ describe("scenarios > visualizations > drillthroughs > dash_drill", () => {addCardToNewDashboard(DASHBOARD_NAME, Q2.id);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(DASHBOARD_NAME);clickScalarCardTitle(Q2.name);});@@ -39,7 +39,7 @@ describe("scenarios > visualizations > drillthroughs > dash_drill", () => {cy.log("Assert that the url is correct");cy.location("pathname").should("eq", `/question/${Q2.expectedPath}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.contains("18,760");});});@@ -68,14 +68,14 @@ describe("scenarios > visualizations > drillthroughs > dash_drill", () => {addCardToNewDashboard(DASHBOARD_NAME, Q2.id);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(DASHBOARD_NAME);clickScalarCardTitle(Q2.name);});it("should result in a correct query result", () => {cy.location("pathname").should("eq", `/question/${Q2.expectedPath}`);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("5,755");});});@@ -122,7 +122,7 @@ describe("scenarios > visualizations > drillthroughs > dash_drill", () => {});it("should result in a correct query result", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Affiliate");H.cartesianChartCircle().should("have.length.of.at.least", 100);});diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/table_drills.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/table_drills.cy.spec.jsindex 8157a957b5b..abba9c622d3 100644--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/table_drills.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/table_drills.cy.spec.js@@ -495,7 +495,7 @@ describe("scenarios > visualizations > drillthroughs > table_drills > nulls", ()const CANCELLED_AT_INDEX = 9;H.openTable({ table: ACCOUNTS_ID, limit: 1 });- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("gridcell").eq(CANCELLED_AT_INDEX).should("have.text", "")@@ -511,7 +511,7 @@ describe("scenarios > visualizations > drillthroughs > table_drills > nulls", ()"have.text","Canceled At is not empty",);- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByRole("gridcell").eq(CANCELLED_AT_INDEX).should("not.have.text", "");diff --git a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.jsindex 451fb4e36f4..c4b5a04ed7e 100644--- a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js@@ -298,7 +298,7 @@ describe("scenarios > question > object details", { tags: "@slow" }, () => {drillPK({ id: 2 });cy.url().should("contain", "objectId=2");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findByTestId("object-detail").findAllByText("Domenica Williamson").last()@@ -364,9 +364,9 @@ describe("scenarios > question > object details", { tags: "@slow" }, () => {cy.findByTestId("object-detail");cy.log("metabase(#29023)");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("People → Name").scrollIntoView().should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Item 1 of/i).should("be.visible");});diff --git a/e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.jsindex 77f25289c69..cb5e96d0dcb 100644--- a/e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.js@@ -31,7 +31,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {it("should be created from an ad-hoc question", () => {H.visitQuestionAdhoc({ dataset_query: testQuery, display: "pivot" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc titleH.openVizSettingsSidebar();@@ -81,42 +81,42 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {it("should allow drill through on cells", () => {createTestQuestion();// open drill-through menu- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("783").click();// drill through to orders list- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("See these Orders").click();// filters are applied- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User → Source is Affiliate");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product → Category is Doohickey");// data loads- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("45.04");});it("should allow drill through on left/top header values", () => {createTestQuestion();// open drill-through menu and filter to that value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("=").click());// filter is applied- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product → Category is Doohickey");// filter out affiliate as a source- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Affiliate").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("≠").click());// filter is applied and value is gone from the left header- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User → Source is not Affiliate");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Affiliate").should("not.exist");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,193"); // new grand total});@@ -136,7 +136,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {});// One field should now be empty- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Drag fields here");cy.log("Implicit assertions on a table itself");@@ -206,37 +206,37 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("215"); // see a non-subtotal value// click to collapse rows- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickey").parent().find(".Icon-dash").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,352"); // subtotal is still there- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("215").should("not.exist"); // value is hidden// click to uncollapse- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for Doohickey").parent().find(".Icon-add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("215"); // ...and it's back!// collapse the column- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product → Category").parent().find(".Icon-dash").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("215").should("not.exist"); // value is hidden- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("294").should("not.exist"); // value in another section is also hidden// uncollapse Doohickey- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for Doohickey").parent().find(".Icon-add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("215"); // value in doohickey is visible- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("294").should("not.exist"); // the other one is still hidden});@@ -272,20 +272,20 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {};H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1162").should("be.visible");// Collapse "User ID" column- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User ID").parent().find(".Icon-dash").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for 1162").should("be.visible");//Expanding the grouped column should still work- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for 1162").parent().find(".Icon-add").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1162").should("be.visible");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("34").should("be.visible");});@@ -302,10 +302,10 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc title- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,520"); // check for one of the subtotals// open settings@@ -314,7 +314,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {// Confirm that Product -> Category doesn't have the option to hide subtotalsopenColumnSettings("Product → Category");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show totals").should("not.be.visible");// turn off subtotals for User -> Source@@ -326,7 +326,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {cy.findByRole("switch").click({ force: true });});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,520").should("not.exist"); // the subtotal has disappeared!});@@ -341,9 +341,9 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("899").should("not.exist"); // confirm that "Affiliate" is collapsed- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,520"); // affiliate subtotal is visible// open settings@@ -358,16 +358,16 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {cy.findByRole("switch").click({ force: true });});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,520").should("not.exist"); // the subtotal isn't there- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("899"); // Affiliate is no longer collapsed});it("should allow column formatting", () => {H.visitQuestionAdhoc({ dataset_query: testQuery, display: "pivot" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc titleH.openVizSettingsSidebar();@@ -375,12 +375,12 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {openColumnSettings("User → Source");cy.log("New panel for the column options");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Column title/);cy.log("Change the title for this column");cy.get("input[id=column_title]").clear().type("ModifiedTITLE").blur();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();cy.findByTestId("query-visualization-root").within(() => {cy.findByText("ModifiedTITLE");@@ -390,7 +390,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {it("should allow value formatting", () => {H.visitQuestionAdhoc({ dataset_query: testQuery, display: "pivot" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc titleH.openVizSettingsSidebar();@@ -398,18 +398,18 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {openColumnSettings("Count");cy.log("New panel for the column options");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Column title");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Style");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Separator style");cy.log("Change the value formatting");cy.findByDisplayValue("Normal").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Percent").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Done").click();cy.findByTestId("query-visualization-root").within(() => {cy.findByText("78,300%");@@ -419,14 +419,14 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {it("should not allow sorting of value fields", () => {H.visitQuestionAdhoc({ dataset_query: testQuery, display: "pivot" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc titleH.openVizSettingsSidebar();assertOnPivotSettings();openColumnSettings("Count");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Sort order/).should("not.be.visible");});@@ -480,7 +480,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {visualization_settings: {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Pivot tables can only be used with aggregated queries.");});@@ -508,21 +508,21 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {});// value headings- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of Total");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Sum of Twice Total");// check values in the table- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("42,156.87"); // sum of total for 2022- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("84,313.74"); // sum of "twice total" for 2022// check grand totals- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,510,621.68"); // sum of total grand total- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,021,243.37"); // sum of "twice total" grand total});@@ -547,13 +547,13 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {display: "pivot",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("category_foo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Doohickeyfoo");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("42"); // count of Doohickeyfoo- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("200"); // grand total});});@@ -599,17 +599,17 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {}).then(({ body: { dashboard_id } }) => H.visitDashboard(dashboard_id));assertOnPivotFields();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Google").click(); // open drill-through menu- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usageH.popover().within(() => cy.findByText("=").click()); // drill with additional filter- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("User → Source is Google"); // filter was added- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Row totals"); // it's still a pivot table- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("1,027"); // primary data value- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("3,798"); // subtotal value});});@@ -660,7 +660,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {describe(test.case, () => {beforeEach(() => {cy.visit("collection/root");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(test.subject).click();});@@ -813,7 +813,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {display: "line",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").click();H.leftSidebar().within(() => {// This part is still failing. Uncomment when fixed.@@ -869,18 +869,18 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {},});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("November 9, 2022");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("November 10, 2022");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("November 11, 2022");collapseRowsFor("Created At: Day");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for November 9, 2022");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for November 10, 2022");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Totals for November 11, 2022");function collapseRowsFor(column_name) {@@ -952,15 +952,15 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {});H.openVizSettingsSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Conditional Formatting").click();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Add a rule").click();cy.findByTestId("conditional-formatting-value-input").type("70").blur();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("is equal to").click({ force: true });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("is less than or equal to").click({ force: true });cy.contains("[data-testid=pivot-table-cell]", "65.09").should(@@ -1095,7 +1095,7 @@ describe("scenarios > visualizations > pivot tables", { tags: "@slow" }, () => {cy.findAllByTestId("pivot-table-resize-handle").first().as("leftHeaderColHandle");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findAllByTestId("pivot-table-resize-handle").last().as("totalHeaderColHandle");@@ -1575,7 +1575,7 @@ function sortColumnResults(column, direction) {}function getPivotTableBodyCell(index) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringreturn cy.findByLabelText("pivot-table-body-grid").findAllByTestId("pivot-table-cell")diff --git a/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.jsindex 9c445999eb4..39e824a8c1c 100644--- a/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/scalar.cy.spec.js@@ -59,13 +59,13 @@ describe("scenarios > visualizations > scalar", () => {display: "scalar",});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("April 30, 2024");H.openVizSettingsSidebar();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Show the time").should("be.hidden");- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Time style").should("be.hidden");});});diff --git a/e2e/test/scenarios/visualizations-tabular/smartscalar-trend.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/smartscalar-trend.cy.spec.jsindex cefe0c696ef..ff1351c540e 100644--- a/e2e/test/scenarios/visualizations-tabular/smartscalar-trend.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/smartscalar-trend.cy.spec.js@@ -208,7 +208,7 @@ describe("scenarios > visualizations > trend chart (SmartScalar)", () => {cy.button("Add comparison").should("be.disabled");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.findByTestId("comparison-list").children().last()diff --git a/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/table.cy.spec.jsindex cdc98717141..80471d291fe 100644--- a/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js@@ -23,7 +23,7 @@ describe("scenarios > visualizations > table", () => {}function selectFromDropdown(option, clickOpts) {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.popover().last().findByText(option).click(clickOpts);}@@ -249,7 +249,7 @@ describe("scenarios > visualizations > table", () => {cy.icon("gear").click();});- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Link").click();cy.findByLabelText("Link text").type("{{C");@@ -269,7 +269,7 @@ describe("scenarios > visualizations > table", () => {}).blur();- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Wood River 1 fixed text").should("have.attr","href",@@ -1213,7 +1213,7 @@ function assertCanViewOrdersTableDashcard() {H.tableInteractiveScrollContainer().scrollTo("bottomLeft");// Ensure it renders correct data- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractiveBody().findAllByRole("row").last()@@ -1223,7 +1223,7 @@ function assertCanViewOrdersTableDashcard() {H.tableInteractiveScrollContainer().scrollTo("bottomRight");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.tableInteractiveBody().findAllByRole("row").last()diff --git a/e2e/test/scenarios/visualizations-tabular/visualizations-tabular-reproductions.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/visualizations-tabular-reproductions.cy.spec.jsindex d3f206ea818..56eadec0558 100644--- a/e2e/test/scenarios/visualizations-tabular/visualizations-tabular-reproductions.cy.spec.js+++ b/e2e/test/scenarios/visualizations-tabular/visualizations-tabular-reproductions.cy.spec.js@@ -126,7 +126,7 @@ describe("issue 11435", () => {},};const hoverLineDot = ({ index } = {}) => {- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringH.cartesianChartCircle().eq(index).realHover();};@@ -215,7 +215,7 @@ describe("issue 18976, 18817", () => {it("should display a pivot table as regular one when pivot columns are missing (metabase#18976)", () => {H.visitQuestionAdhoc(questionDetails);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Showing 1 row");});@@ -288,19 +288,19 @@ describe("issue 19373", { tags: "@skip" }, () => {cy.findAllByRole("grid").eq(2).as("tableCells");// Sanity check before we start asserting on this column- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@columnTitles").findAllByTestId("pivot-table-cell").eq(ROW_TOTALS_INDEX).should("contain", "Row totals");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@rowTitles").findAllByTestId("pivot-table-cell").eq(GRAND_TOTALS_INDEX).should("contain", "Grand totals");- // eslint-disable-next-line no-unsafe-element-filtering+ // eslint-disable-next-line metabase/no-unsafe-element-filteringcy.get("@tableCells").findAllByTestId("pivot-table-cell").eq(ROW_TOTALS_INDEX)@@ -337,7 +337,7 @@ describe("issue 21392", () => {it("should render a chart with many columns without freezing (metabase#21392)", () => {H.visitQuestionAdhoc({ dataset_query: TEST_QUERY, display: "line" });- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Visualization").should("be.visible");});});@@ -475,7 +475,7 @@ describe("issue 28304", () => {});it("table should should generate default columns when table.columns entries do not match data.cols (metabase#28304)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Count by Created At: Month").should("be.visible");H.openVizSettingsSidebar();@@ -539,7 +539,7 @@ describe("issue 25250", () => {});it("pivot table should show standalone values when collapsed to the sub-level grouping (metabase#25250)", () => {- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("Product ID").should("be.visible");H.openVizSettingsSidebar();@@ -822,9 +822,9 @@ describe("issue 14148", { tags: "@external" }, () => {"Reported failing on v0.38.0-rc1 querying Postgres, Redshift and BigQuery. It works on MySQL and H2.",);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText(/Grand totals/i);- // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usagecy.findByText("2,500");});});diff --git a/enterprise/frontend/src/.eslintrc.js b/enterprise/frontend/src/.eslintrc.jsindex 36279ba0a7a..d0f06cbd7ef 100644--- a/enterprise/frontend/src/.eslintrc.js+++ b/enterprise/frontend/src/.eslintrc.js@@ -136,7 +136,7 @@ module.exports = {"**/*.stories.{ts,tsx,js,jsx}",],rules: {- "no-external-references-for-sdk-package-code": [+ "metabase/no-external-references-for-sdk-package-code": ["error",{allowedPaths: [diff --git a/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts b/enterprise/frontend/src/embedding-sdk-ee/auth/auth.tsindex 3d9bfcf6b3d..16f47a07c59 100644--- a/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts+++ b/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts@@ -93,7 +93,7 @@ PLUGIN_EMBEDDING_SDK_AUTH.initAuth = async (} catch (e) {// TODO: Fix this. For some reason the instanceof check keeps returning `false`. I'd rather not do this// but due to time constraints this is what we have to do to make sure tests pass.- // eslint-disable-next-line no-literal-metabase-strings -- error checking for better errors. should be improved in the future.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- error checking for better errors. should be improved in the future.if ((e as Error).name === "MetabaseError") {throw e;}@@ -241,13 +241,13 @@ const getRefreshToken = async ({function getSdkRequestHeaders(hash?: string): Record<string, string> {return {- // eslint-disable-next-line no-literal-metabase-strings -- header name+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- header name"X-Metabase-Client": "embedding-sdk-react",- // eslint-disable-next-line no-literal-metabase-strings -- header name+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- header name"X-Metabase-Client-Version":getBuildInfo("METABASE_EMBEDDING_SDK_PACKAGE_BUILD_INFO").version ??EMBEDDING_SDK_PACKAGE_UNKNOWN_VERSION,- // eslint-disable-next-line no-literal-metabase-strings -- header name+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- header name...(hash && { "X-Metabase-SDK-JWT-Hash": hash }),};}diff --git a/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc b/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrcindex 0a3180e4eda..6e42ed14838 100644--- a/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc+++ b/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc@@ -1,6 +1,6 @@{"rules": {- "no-literal-metabase-strings": "off",+ "metabase/no-literal-metabase-strings": "off","no-console": "off",},}diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc b/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrcindex e0399516784..49ccf934c27 100644--- a/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc+++ b/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc@@ -1,7 +1,7 @@{"rules": {- "no-literal-metabase-strings": "off",- "no-color-literals": "off",+ "metabase/no-literal-metabase-strings": "off",+ "metabase/no-color-literals": "off","no-console": "off"}}diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/constants/messages.ts b/enterprise/frontend/src/embedding-sdk-package/cli/constants/messages.tsindex 5087c8f1790..0755e350b0c 100644--- a/enterprise/frontend/src/embedding-sdk-package/cli/constants/messages.ts+++ b/enterprise/frontend/src/embedding-sdk-package/cli/constants/messages.ts@@ -58,7 +58,7 @@ export const getMetabaseInstanceSetupCompleteMessage = (email: string,password: string,) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- link for the CLI message+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- link for the CLI message`Metabase is running at ${blue(instanceUrl)}@@ -118,5 +118,5 @@ export const CONTINUE_SETUP_ON_WARNING_MESSAGE = `Do you want to continue setup?export const LINK_TO_NEXT_JS_SAMPLE = `https://github.com/metabase/metabase-nextjs-sdk-embedding-sample`;-// eslint-disable-next-line no-unconditional-metabase-links-render -- this is for the cli+// eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- this is for the cliexport const LINK_TO_NEXT_JS_GUIDE = `https://www.metabase.com/docs/latest/embedding/sdk/next-js`;diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/snippets/theme-switcher-snippet.ts b/enterprise/frontend/src/embedding-sdk-package/cli/snippets/theme-switcher-snippet.tsindex bda766bd164..08dd0145094 100644--- a/enterprise/frontend/src/embedding-sdk-package/cli/snippets/theme-switcher-snippet.ts+++ b/enterprise/frontend/src/embedding-sdk-package/cli/snippets/theme-switcher-snippet.ts@@ -1,4 +1,4 @@-// eslint-disable-next-line no-unconditional-metabase-links-render -- cli snippets+// eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- cli snippetsexport const THEME_SWITCHER_SNIPPET = `import { useContext } from 'react'diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/snippets/user-switcher-snippet.ts b/enterprise/frontend/src/embedding-sdk-package/cli/snippets/user-switcher-snippet.tsindex 98635f04e37..bfa9343e610 100644--- a/enterprise/frontend/src/embedding-sdk-package/cli/snippets/user-switcher-snippet.ts+++ b/enterprise/frontend/src/embedding-sdk-package/cli/snippets/user-switcher-snippet.ts@@ -6,7 +6,7 @@ export const getUserSwitcherSnippet = () => {firstName: user.firstName,}));- // eslint-disable-next-line no-unconditional-metabase-links-render -- cli snippets+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- cli snippetsreturn `import {useContext} from 'react'diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsxindex 24fa8784c9c..3382b4a8891 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx@@ -1,6 +1,6 @@import { useMetabaseProviderPropsStore } from "embedding-sdk-shared/hooks/use-metabase-provider-props-store";import type { MetabaseTheme } from "metabase/embedding-sdk/theme";-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { colors } from "metabase/lib/colors/colors";type Props = {diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/Loader/Loader.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/Loader/Loader.tsxindex a7947ec17ff..f4327393321 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/private/Loader/Loader.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/Loader/Loader.tsx@@ -1,4 +1,4 @@-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { getSdkLoaderCss } from "embedding/sdk-common/lib/get-sdk-loader-css";import type { CommonStylingProps } from "embedding-sdk-bundle/types/props";import { useMetabaseProviderPropsStore } from "embedding-sdk-shared/hooks/use-metabase-provider-props-store";@@ -11,7 +11,7 @@ type SpinnerProps = {const SPINNER_CLASS_NAME = "metabase-spinner-loader";-// eslint-disable-next-line no-color-literals+// eslint-disable-next-line metabase/no-color-literalsconst Spinner = ({ size = "1.5rem", color = "#509EE3" }: SpinnerProps) => {return (<div>diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsxindex 8eaaeabd1f5..98944ca1f7f 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx@@ -1,5 +1,5 @@import { memo, useEffect, useId, useMemo } from "react";-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport useDeepCompareEffect from "react-use/lib/useDeepCompareEffect";import type { MetabaseProviderProps } from "embedding-sdk-bundle/types/metabase-provider";@@ -107,7 +107,7 @@ export const MetabaseProvider = memo(function MetabaseProvider({groupId="metabase-provider"instanceId={ensureSingleInstanceId}multipleRegisteredInstancesWarningMessage={- // eslint-disable-next-line no-literal-metabase-strings -- Warning message+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Warning message"Multiple instances of MetabaseProvider detected. Metabase modular embedding SDK may work unexpectedly. Ensure only one instance of MetabaseProvider is rendered at a time."}>diff --git a/enterprise/frontend/src/embedding-sdk-package/constants/error-messages.ts b/enterprise/frontend/src/embedding-sdk-package/constants/error-messages.tsindex cd82c8fdbde..a31956f5fde 100644--- a/enterprise/frontend/src/embedding-sdk-package/constants/error-messages.ts+++ b/enterprise/frontend/src/embedding-sdk-package/constants/error-messages.ts@@ -11,9 +11,9 @@ export const SDK_COMPONENT_NOT_YET_AVAILABLE_MESSAGE ="The component is not available in the Embedded Analytics SDK bundle. Update your analytics server to access the component.";export const SDK_COMPONENT_MISSING_REQUIRED_PROPERTY_MESSAGE =- // eslint-disable-next-line no-literal-metabase-strings -- console.error message+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- console.error message"this property is required by the component. Your Embedded Analytics SDK and Metabase instance are out of sync. Update them to matching versions and adjust props based on the updated TypeScript types.";export const SDK_COMPONENT_UNRECOGNIZED_PROPERTY_MESSAGE =- // eslint-disable-next-line no-literal-metabase-strings -- console.error message+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- console.error message"this property is not recognized by the component and will be ignored. Your Embedded Analytics SDK and Metabase instance are out of sync. Update them to matching versions and adjust props based on the updated TypeScript types.";diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-load-sdk-bundle.ts b/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-load-sdk-bundle.tsindex eb4bd99a691..9d2f02df365 100644--- a/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-load-sdk-bundle.ts+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-load-sdk-bundle.ts@@ -1,6 +1,6 @@import { useEffect } from "react";-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { SDK_BUNDLE_FULL_PATH } from "build-configs/embedding-sdk/constants/sdk-bundle";import { SDK_BUNDLE_SCRIPT_DATA_ATTRIBUTE_PASCAL_CASED } from "embedding-sdk-package/constants/sdk-bundle-script-data-attribute-name";import { getSdkBundleScriptElement } from "embedding-sdk-package/lib/private/get-sdk-bundle-script-element";diff --git a/enterprise/frontend/src/embedding-sdk-package/index.ts b/enterprise/frontend/src/embedding-sdk-package/index.tsindex b86ab3caabd..b2cc4deffc8 100644--- a/enterprise/frontend/src/embedding-sdk-package/index.ts+++ b/enterprise/frontend/src/embedding-sdk-package/index.ts@@ -1,8 +1,8 @@-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { EMBEDDING_SDK_CONFIG } from "metabase/embedding-sdk/config";-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { defineBuildInfo } from "metabase/embedding-sdk/lib/define-build-info";-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { defineGlobalDependencies } from "metabase/embedding-sdk/lib/define-global-dependencies";// Enable SDK mode as we are in the SDK packagediff --git a/enterprise/frontend/src/embedding-sdk-package/lib/public/define-metabase-theme.ts b/enterprise/frontend/src/embedding-sdk-package/lib/public/define-metabase-theme.tsindex 616d87fc81b..4d99eaf1818 100644--- a/enterprise/frontend/src/embedding-sdk-package/lib/public/define-metabase-theme.ts+++ b/enterprise/frontend/src/embedding-sdk-package/lib/public/define-metabase-theme.ts@@ -1,4 +1,4 @@-// eslint-disable-next-line no-external-references-for-sdk-package-code+// eslint-disable-next-line metabase/no-external-references-for-sdk-package-codeimport { defineMetabaseTheme } from "metabase/embedding-sdk/theme/define-metabase-theme";export { defineMetabaseTheme };diff --git a/enterprise/frontend/src/embedding/data-picker/DataSelectorTablePicker/DataSelectorTablePicker.tsx b/enterprise/frontend/src/embedding/data-picker/DataSelectorTablePicker/DataSelectorTablePicker.tsxindex 03c4372802a..7d1063f71fd 100644--- a/enterprise/frontend/src/embedding/data-picker/DataSelectorTablePicker/DataSelectorTablePicker.tsx+++ b/enterprise/frontend/src/embedding/data-picker/DataSelectorTablePicker/DataSelectorTablePicker.tsx@@ -157,7 +157,7 @@ const DataSelectorTablePicker = ({};const LinkToDocsOnReferencingSavedQuestionsInQueries = () => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- It's hard to tell if this is still used in the app. Please see https://metaboat.slack.com/archives/C505ZNNH4/p1703243785315819+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- It's hard to tell if this is still used in the app. Please see https://metaboat.slack.com/archives/C505ZNNH4/p1703243785315819const { url: docsUrl } = useDocsUrl("questions/native-editor/referencing-saved-questions-in-queries",);diff --git a/enterprise/frontend/src/embedding/sdk-common/lib/get-sdk-loader-css.ts b/enterprise/frontend/src/embedding/sdk-common/lib/get-sdk-loader-css.tsindex a1006d13793..4df67b2190d 100644--- a/enterprise/frontend/src/embedding/sdk-common/lib/get-sdk-loader-css.ts+++ b/enterprise/frontend/src/embedding/sdk-common/lib/get-sdk-loader-css.ts@@ -7,7 +7,7 @@ export type SdkLoaderData = {export const getSdkLoaderCss = ({className,size = "1.5rem",- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalscolor = "#509EE3",}: SdkLoaderData) => `@keyframes ${className}-animation {diff --git a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModalView.tsx b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModalView.tsxindex 83e52e26005..4bf596b5b3a 100644--- a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModalView.tsx+++ b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModalView.tsx@@ -73,18 +73,18 @@ export const ImpersonationModalView = ({// for redshift, we impersonate using users, not rolesconst impersonationUsesUsers = database.engine === "redshift";- // eslint-disable-next-line no-unconditional-metabase-links-render -- Only shows for admins.+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Only shows for admins.const { url: permsDocsUrl } = useDocsUrl("permissions/data");const modalTitle = impersonationUsesUsers- ? // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingst`Map a Metabase user attribute to database users`: t`Map a user attribute to database roles`;const modalMessage = impersonationUsesUsers- ? // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingst`When the person runs a query (including native queries), Metabase will impersonate the privileges of the database user you associate with the user attribute.`- : // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ : // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingst`When the person runs a query (including native queries), Metabase will impersonate the privileges of the database role you associate with the user attribute.`;return (diff --git a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationWarning/ImpersonationWarning.tsx b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationWarning/ImpersonationWarning.tsxindex b5bccea8d96..cd98b67987c 100644--- a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationWarning/ImpersonationWarning.tsx+++ b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationWarning/ImpersonationWarning.tsx@@ -19,10 +19,10 @@ export const ImpersonationWarning = ({const databaseUser = database.details && database.details.user;const isRedshift = database.engine === "redshift";- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingsconst emptyText = t`Make sure the main database credential has access to everything different user groups may need access to. It's what Metabase uses to sync table information.`;- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingsconst redshiftWarning = jt`You’re connecting Metabase to the ${(<BoldCode key="2" size="13px">{database.name}@@ -37,7 +37,7 @@ export const ImpersonationWarning = ({</BoldCode>)} must be a superuser in Redshift.`;- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingsconst regularWarning = jt`${(<BoldCode key="1" size="13px">{databaseUser}diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/UnsubscribeUserModal/UnsubscribeUserModal.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/UnsubscribeUserModal/UnsubscribeUserModal.tsxindex ef81bcce533..e7b710d77de 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/UnsubscribeUserModal/UnsubscribeUserModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/UnsubscribeUserModal/UnsubscribeUserModal.tsx@@ -65,7 +65,7 @@ export const UnsubscribeUserModal = ({{t`This will delete any dashboard subscriptions or alerts ${user.common_name} has created, and remove them as a recipient from any other subscriptions or alerts.`}</Text><Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`This does not affect email distribution lists that are managed outside of Metabase.`}</Text></Stack>diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.tsxindex 09af05756cb..498256a6ce2 100644--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.tsx@@ -71,7 +71,7 @@ export function SettingsSAMLForm() {[updateSamlSettings],);- // eslint-disable-next-line no-unconditional-metabase-links-render -- Admin settings+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Admin settingsconst { url: docsUrl } = useDocsUrl("people-and-groups/authenticating-with-saml",);@@ -111,7 +111,7 @@ export function SettingsSAMLForm() {</Text><FormSection title={t`Configure your identity provider (IdP)`}><Text c="text-secondary" mb="xl">- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`Your identity provider will need the following info about Metabase.`}</Text>@@ -166,11 +166,11 @@ export function SettingsSAMLForm() {</FormSection><FormSection- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingstitle={t`Tell Metabase about your identity provider`}><Text mb="xl" mt="sm" c="text-secondary">- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`Metabase will need the following info about your provider.`}</Text><Stack gap="md">@@ -245,7 +245,7 @@ export function SettingsSAMLForm() {title={t`Synchronize group membership with your SSO`}><Text c="text-secondary" mb="lg">- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`To enable this, you'll need to create mappings to tell Metabase which group(s) your users shouldbe added to based on the SSO group they're in.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx b/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsxindex b635cd84850..c218c7faaba 100644--- a/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx+++ b/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx@@ -53,7 +53,7 @@ const maxContentDictionarySizeInBytes =maxContentDictionarySizeInMiB * 1024 * 1024;export const ContentTranslationConfiguration = () => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- This is used in admin settings+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This is used in admin settingsconst availableLocalesDocsUrl = useDocsUrl("configuring-metabase/localization",{ anchor: "supported-languages" },@@ -115,7 +115,7 @@ export const ContentTranslationConfiguration = () => {[isDownloadInProgress],);- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.const uploadDescription = t`Upload a translation dictionary to translate strings both in Metabase content (like dashboard titles) and in the data itself (like column names and values). The dictionary must be a CSV with these columns: **Locale Code**, **String**, **Translation**.`;return (diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/SyncOptionsModal.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/SyncOptionsModal.tsxindex 21b218f25e8..07328b55f84 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/SyncOptionsModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/SyncOptionsModal.tsx@@ -45,9 +45,9 @@ export const SyncOptionsModal = ({<Text c="text-secondary" size="sm">{isSingleTable- ? /* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */+ ? /* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */t`If you’ve made changes to this table in the underlying database that aren’t showing up in Metabase yet, re-syncing the schema can fix that.`- : /* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */+ : /* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */t`If you've made changes to these tables in the underlying databases that aren't showing up in Metabase yet, re-syncing the schemas can fix that.`}</Text></Stack>@@ -65,9 +65,9 @@ export const SyncOptionsModal = ({<Text c="text-secondary" size="sm">{isSingleTable- ? /* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */+ ? /* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */t`Metabase can scan the values in this table to enable checkbox filters in dashboards and questions.`- : /* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */+ : /* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */t`Metabase can scan the values in these tables to enable checkbox filters in dashboards and questions.`}</Text></Stack>diff --git a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSection.tsx b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSection.tsxindex 72f9ceb9133..a4d78032b04 100644--- a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSection.tsx@@ -52,7 +52,7 @@ export function DatabaseReplicationSection({<DatabaseInfoSectioncondensedname={t`Database replication`}- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.description={t`Continuously sync the tables from this database with Metabase Cloud Storage - a fast managed database. Then query the copied tables instead of the originals.`}><Flex align="center" justify="space-between" gap="lg">diff --git a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationStatusInfo.tsx b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationStatusInfo.tsxindex 04e4b596641..4416d8f7027 100644--- a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationStatusInfo.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationStatusInfo.tsx@@ -17,9 +17,9 @@ export const DatabaseReplicationStatusInfo = memo(const connections = useSetting("database-replication-connections");const hasConnection = connections?.[databaseId] != null;const message = hasConnection- ? // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.t`Replicating to Metabase Cloud Storage`- : // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ : // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.t`Not replicating to Metabase Cloud Storage`;const color = hasConnection ? "success" : "text-tertiary";diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsxindex 0dd4a14e3ac..3f537d863cd 100644--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx@@ -55,7 +55,7 @@ export const DatabaseRoutingSection = ({const engine = engineKey ? engines[engineKey] : undefined;const dbRoutingInfo =engine?.["extra-info"]?.["db-routing-info"]?.text ??- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.t`When someone views a question using data from this database, Metabase will send the queries to the destination database set by the person's user attribute. Each destination database must have identical schemas.`;const shouldHideSection =database.is_attached_dwh || database.is_sample || !dbSupportsRouting;diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabaseConnectionModal/DestinationDatabaseConnectionModal.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabaseConnectionModal/DestinationDatabaseConnectionModal.tsxindex 34514f3c8a2..6ea9ac2d446 100644--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabaseConnectionModal/DestinationDatabaseConnectionModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabaseConnectionModal/DestinationDatabaseConnectionModal.tsx@@ -30,7 +30,7 @@ export const DestinationDatabaseConnectionModal = ({}) => {const dispatch = useDispatch();- // eslint-disable-next-line no-unconditional-metabase-links-render -- Admin settings+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Admin settingsconst { url: docsUrl } = useDocsUrl("permissions/database-routing");const primaryDbReq = useGetDatabaseQuery(paramIdToGetQuery(databaseId));diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/index.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/index.tsxindex b61dd7f09e5..488c29c4d65 100644--- a/enterprise/frontend/src/metabase-enterprise/database_routing/index.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/index.tsx@@ -24,7 +24,7 @@ export function initializePlugin() {return {label: t`Slug`,- // eslint-disable-next-line no-literal-metabase-strings -- Admin settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settingsdescription: t`Metabase will route queries to this database when the user attribute value matches this slug.`, // Metabase will use this value to map to the user attribute you specify to swap queries at run time`,placeholder: t`For example, pro-users`,};diff --git a/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/auth-manager/AuthManager.ts b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/auth-manager/AuthManager.tsindex d0bc36d8c31..415344340bc 100644--- a/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/auth-manager/AuthManager.ts+++ b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/auth-manager/AuthManager.ts@@ -84,10 +84,10 @@ export class EmbedAuthManager {private getAuthRequestHeader(hash?: string) {return {- // eslint-disable-next-line no-literal-metabase-strings -- header name+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- header name"X-Metabase-Client": "embedding-simple",- // eslint-disable-next-line no-literal-metabase-strings -- header name+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- header name...(hash && { "X-Metabase-SDK-JWT-Hash": hash }),};}diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsxindex 4f1fb943277..fb0aa7f3e2f 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx@@ -150,7 +150,7 @@ export const GdriveAddDataPanel = ({const folderUrl = folder?.url;const NO_STORAGE_SUBTITLE = t`To work with spreadsheets, you can add storage to your instance.`;- // eslint-disable-next-line no-literal-metabase-strings -- admin only+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin onlyconst ERROR_MESSAGE = t`Please check that the folder is shared with the Metabase Service Account.`;if (!isAdmin) {@@ -214,7 +214,7 @@ export const GdriveAddDataPanel = ({return (<PanelWrapper subtitle={NO_STORAGE_SUBTITLE}><ErrorAlert- // eslint-disable-next-line no-literal-metabase-strings -- admin only+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin onlyerror={t`Metabase Storage is full. Add more storage to continue syncing.`}><Group gap="sm" mt="sm" align="center">diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.strings.ts b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.strings.tsindex 64a64bfd308..ce2a8bcc88d 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.strings.ts+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.strings.ts@@ -26,7 +26,7 @@ export const getDisconnectModalStrings = ({return {title: t`To add a new Google Drive folder, the existing one needs to be disconnected first`,bodyCopy: reconnect- ? // eslint-disable-next-line no-literal-metabase-strings -- admin only string+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin only stringt`Only one folder can be synced with Metabase at a time. Your tables and Google Sheets will remain in place.`: t`Your existing tables and Google Sheets will remain in place but they will no longer be updated automatically.`,connectButtonText: t`Keep connected`,diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsxindex cb55794b6ed..5028223bf9d 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx@@ -18,7 +18,7 @@ export function GdriveErrorMenuItem({ error }: { error: any }) {<Text size="sm" c="text-secondary" maw="16rem">{getErrorMessage(error,- // eslint-disable-next-line no-literal-metabase-strings -- admin only ui+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin only uit`Please check that the folder is shared with the Metabase Service Account.`,)}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsxindex 218a5af8a8e..6ce8a9aab53 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx@@ -70,7 +70,7 @@ export const GdriveSyncStatus = () => {console.error(getErrorMessage(apiError,- // eslint-disable-next-line no-literal-metabase-strings -- admin only ui+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin only uit`Please check that the folder is shared with the Metabase Service Account.`,),);@@ -113,7 +113,7 @@ function GsheetsSyncStatusView({.with("error",() =>- // eslint-disable-next-line no-literal-metabase-strings -- admin UI+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin UIt`Please check that the folder is shared with the Metabase Service Account.`,).otherwise(() => undefined);diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/PausedModal.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/PausedModal.tsxindex 8d548fedc12..8048e435377 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/PausedModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/PausedModal.tsx@@ -23,7 +23,7 @@ function PausedModal({ onClose }: { onClose: () => void }) {</Text><Text c="text-secondary">{isAdmin- ? // eslint-disable-next-line no-literal-metabase-strings -- admin only+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin onlyt`Add more storage to your Metabase or connect a database to store the uploaded files.`: t`Please contact your admin to add more storage.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/utils.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/utils.tsxindex 6201833c844..cbf4d9146ef 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/utils.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/utils.tsx@@ -90,7 +90,7 @@ export const useDeleteGdriveFolderLink = (options?: {.catch((response: unknown) => {const error = getErrorMessage(response,- // eslint-disable-next-line no-literal-metabase-strings -- admin only ui+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin only uit`Please check that the folder is shared with the Metabase Service Account.`,);setErrorMessage(error);diff --git a/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/BillingInfo.tsx b/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/BillingInfo.tsxindex b3967d7f728..9e18365d2d3 100644--- a/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/BillingInfo.tsx+++ b/enterprise/frontend/src/metabase-enterprise/license/components/BillingInfo/BillingInfo.tsx@@ -72,11 +72,11 @@ const BillingGoToStore = () => {<SettingHeaderid="billing"title={t`Billing`}- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingsdescription={t`Manage your Cloud account, including billing preferences, in your Metabase Store account.`}/><ButtonLink href={url}>- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`Go to the Metabase Store`}<Icon name="external" opacity={0.6} ml="sm" /></ButtonLink>diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotAdminPage.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotAdminPage.tsxindex 1a9f4174a9a..202fc0759ab 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotAdminPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotAdminPage.tsx@@ -81,7 +81,7 @@ export function MetabotAdminPage() {id="configure-metabot"title={c("{0} is the name of an AI assistant").t`Configure ${metabot.name}`}- description={c("{0} is the name of an AI assistant") // eslint-disable-next-line no-literal-metabase-strings -- admin ui+ description={c("{0} is the name of an AI assistant") // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin ui.t`${metabot.name} is Metabase's AI agent. To help ${metabot.name} more easily find and focus on the data you care about most, configure what content it should be able to access or use to create queries.`}/>{isEmbedMetabot && (diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForNonStoreUser.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForNonStoreUser.tsxindex a0a747ded28..73c78f190ac 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForNonStoreUser.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForNonStoreUser.tsx@@ -17,7 +17,7 @@ export const MetabotPurchasePageForNonStoreUser = ({</video><Text fw="bold">{- /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`Please ask a Metabase Store Admin${anyStoreUserEmailAddress && ` (${anyStoreUserEmailAddress})`} of your organization to enable this for you.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForStoreUser.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForStoreUser.tsxindex 17da5bf7a92..ca73e48333a 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForStoreUser.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotPurchasePage/MetabotPurchasePageForStoreUser.tsx@@ -157,9 +157,9 @@ export const MetabotPurchasePageForStoreUser = () => {<Text>{hadMetabot- ? /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ ? /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`An additional amount for the add-on will be added to your next billing period invoice. You can cancel the add-on anytime in Metabase Store.`- : /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ : /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`After 14 days of free trial an additional amount for the add-on will be added to your next billing period invoice. You can cancel the add-on anytime in Metabase Store.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotTrialPage.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotTrialPage.tsxindex d826ef979c5..0f5217e3236 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotTrialPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotTrialPage.tsx@@ -63,7 +63,7 @@ export const MetabotTrialPage = () => {<SettingsPageWrapper title={t`Metabot AI`}><SettingsSectiontitle={- /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`Get a free month of Metabot, the new AI assistant for Metabase.`}>@@ -72,7 +72,7 @@ export const MetabotTrialPage = () => {<List><List.Item><Markdown>{- /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`**Act as a SQL generation copilot** in the Metabase SQL editor`}</Markdown></List.Item>@@ -133,7 +133,7 @@ export const MetabotTrialPage = () => {) : (<Text fw="bold">{- /* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */+ /* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */t`Please ask a Metabase Store Admin${anyStoreUserEmailAddress && ` (${anyStoreUserEmailAddress})`} of your organization to enable this for you.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotFeedbackModal.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotFeedbackModal.tsxindex d99724cd5a7..dd21842fa87 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotFeedbackModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotFeedbackModal.tsx@@ -153,7 +153,7 @@ export const MetabotFeedbackModal = ({</Stack><Text size="sm" color="text-secondary">- {/* eslint-disable-next-line no-literal-metabase-strings -- this is a translation context string, not shown to users */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- this is a translation context string, not shown to users */}{c("{0} is the name of the application, usually 'Metabase'").t`Please submit this report to ${applicationName}. Note that it may contain sensitive data from your conversation.`}</Text>diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsxindex 5ad61fefd4e..819a43552bb 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx@@ -269,7 +269,7 @@ export const RemoteSyncSettingsForm = (props: RemoteSyncSettingsFormProps) => {tenantCollectionsData,]);- // eslint-disable-next-line no-unconditional-metabase-links-render -- This links only shows for admins.+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This links only shows for admins.const { url: docsUrl } = useDocsUrl("installation-and-operation/remote-sync",{diff --git a/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts b/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.tsindex 97cbd4ae5b2..1a1f3a1676b 100644--- a/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts+++ b/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts@@ -9,7 +9,7 @@ export const LICENSE_ACCEPTED_URL_HASH = "#activated";// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045const INVALID_TOKEN_ERROR = t`This token doesn't seem to be valid. Double-check it, then contact support if you think it should be working.`;-// eslint-disable-next-line ttag/no-module-declaration, no-literal-metabase-strings+// eslint-disable-next-line ttag/no-module-declaration, metabase/no-literal-metabase-stringsconst UNABLE_TO_VALIDATE_TOKEN = t`We're having trouble validating your token. Please double-check that your instance can connect to Metabase's servers.`;export const useLicense = (onActivated?: () => void) => {diff --git a/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts b/enterprise/frontend/src/metabase-enterprise/settings/selectors.tsindex 48f7ee8e6b4..9d3cdd7443b 100644--- a/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts+++ b/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts@@ -33,7 +33,7 @@ export const getLoadingMessage = (state: EnterpriseState) => {return LOADING_MESSAGE_BY_SETTING[setting]?.value ?? (() => "");};-// eslint-disable-next-line no-literal-metabase-strings -- This is a Metabase string we want to keep. It's used for comparison.+// eslint-disable-next-line metabase/no-literal-metabase-strings -- This is a Metabase string we want to keep. It's used for comparison.const DEFAULT_APPLICATION_NAME = "Metabase";export const getIsWhiteLabeling = (state: EnterpriseState) =>getApplicationName(state) !== DEFAULT_APPLICATION_NAME;diff --git a/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx b/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsxindex e26e7eba587..afe5ef56920 100644--- a/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx@@ -65,9 +65,9 @@ export const CloudSMTPConnectionCard = () => {<Radiokey={"metabase"}value={"metabase"}- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingslabel={t`Managed by Metabase`}- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settingsdescription={t`Emails come from Metabase Cloud email server`}classNames={{label: S.label,@@ -80,9 +80,9 @@ export const CloudSMTPConnectionCard = () => {<Stack gap={0}><TextclassName={S.cardTitle}- // eslint-disable-next-line no-literal-metabase-strings -- Metabase settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings>{t`Managed by Metabase`}</Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}<Text>{t`Emails come from Metabase Cloud email server`}</Text></Stack></Flex>diff --git a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/GrantAccessModal.tsx b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/GrantAccessModal.tsxindex 8c647562388..4a7fa797c57 100644--- a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/GrantAccessModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/GrantAccessModal.tsx@@ -66,7 +66,7 @@ export const GrantAccessModal = ({ onClose }: GrantAccessModalProps) => {<Stack><Box mt="sm"><Text display="inline">- {/* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */}{t`You are about to allow a Metabase team member to access your instance.`}{" "}</Text><Text fw="bold" display="inline">diff --git a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/SupportSettingsSection.tsx b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/SupportSettingsSection.tsxindex be1da1e5883..d827e1ceefa 100644--- a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/SupportSettingsSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/SupportSettingsSection.tsx@@ -33,7 +33,7 @@ export function SupportSettingsSection() {description={<><Text c="text-secondary" mt="sm">- {/* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */}{t`Let a Metabase Success Engineer log in to your instance with a troubleshooting account to help resolve problems for you.`}</Text><Text c="text-secondary">diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/EditUserStrategyModal/EditUserStrategyModal.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/EditUserStrategyModal/EditUserStrategyModal.tsxindex 8a3df02006b..80a35494c00 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/EditUserStrategyModal/EditUserStrategyModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/tenants/EditUserStrategyModal/EditUserStrategyModal.tsx@@ -109,7 +109,7 @@ export const EditUserStrategyModal = ({{value: "single-tenant",title: t`Single tenant`,- // eslint-disable-next-line no-literal-metabase-strings -- in admin settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- in admin settingsdescription: t`All users exist in the same world and are managed via Metabase groups. Ideal for internal company analytics, proof of concept, or simple embedding setups.`,},];diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/TenantsDocsButton.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/TenantsDocsButton.tsxindex bb211de2a99..37f0334c5b5 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/TenantsDocsButton.tsx+++ b/enterprise/frontend/src/metabase-enterprise/tenants/TenantsDocsButton.tsx@@ -5,7 +5,7 @@ import { useDocsUrl } from "metabase/common/hooks";import { ActionIcon, Icon, Tooltip } from "metabase/ui";export const TenantsDocsButton = () => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- we can always show links in admin panels, showMetabaseLinks doesn't apply+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- we can always show links in admin panels, showMetabaseLinks doesn't applyconst { url } = useDocsUrl("embedding/tenants");if (!url) {diff --git a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioningModals.tsx b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioningModals.tsxindex de276c80766..e6592fdedf9 100644--- a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioningModals.tsx+++ b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioningModals.tsx@@ -89,7 +89,7 @@ export const UserProvisioningRegenerateTokenModal = ({opened={opened}onClose={onClose}title={t`Regenerate token?`}- // eslint-disable-next-line no-literal-metabase-strings -- admin settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- admin settingsmessage={t`This will delete the existing token. You'll need to update your identity provider with the new token, otherwise people won't be able to log in to your Metabase.`}confirmButtonText={t`Regenerate now`}confirmButtonProps={{ variant: "filled", color: "brand" }}diff --git a/frontend/build/openapi/openapi-ts.config.ts b/frontend/build/openapi/openapi-ts.config.tsindex 9ab6f490245..893e8d7d12a 100644--- a/frontend/build/openapi/openapi-ts.config.ts+++ b/frontend/build/openapi/openapi-ts.config.ts@@ -12,7 +12,7 @@ export default defineConfig({filters: {schemas: {// MetabaseLegacyMbqlSchema has circular references that break TS type checking- // eslint-disable-next-line no-literal-metabase-strings -- this is not user facing text+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- this is not user facing textexclude: ["/^MetabaseLegacyMbqlSchema/"],},},diff --git a/frontend/lint/eslint-rules/index.js b/frontend/lint/eslint-rules/index.jsnew file mode 100644index 00000000000..bb366e7273d--- /dev/null+++ b/frontend/lint/eslint-rules/index.js@@ -0,0 +1,26 @@+/* eslint-disable import/no-commonjs */++const fs = require("fs");++// eslint-disable-next-line no-undef+const pkg = JSON.parse(fs.readFileSync(__dirname + "/package.json", "utf8"));++module.exports = {+ meta: {+ name: pkg.name,+ version: pkg.version,+ },+ rules: {+ "jtag-missing-key": require("./jtag-missing-key"),+ "no-color-literals": require("./no-color-literals"),+ "no-direct-helper-import": require("./no-direct-helper-import"),+ "no-external-references-for-sdk-package-code": require("./no-external-references-for-sdk-package-code"),+ "no-literal-metabase-strings": require("./no-literal-metabase-strings"),+ "no-locale-with-intl-functions": require("./no-locale-with-intl-functions"),+ "no-oss-reinitialize-import": require("./no-oss-reinitialize-import"),+ "no-unconditional-metabase-links-render": require("./no-unconditional-metabase-links-render"),+ "no-unordered-test-helpers": require("./no-unordered-test-helpers"),+ "no-unsafe-element-filtering": require("./no-unsafe-element-filtering"),+ "no-unscoped-text-selectors": require("./no-unscoped-text-selectors"),+ },+};diff --git a/frontend/lint/eslint-rules/package.json b/frontend/lint/eslint-rules/package.jsonnew file mode 100644index 00000000000..6bc230e99b4--- /dev/null+++ b/frontend/lint/eslint-rules/package.json@@ -0,0 +1,7 @@+{+ "name": "eslint-plugin-metabase",+ "version": "1.0.0",+ "description": "Custom ESLint rules for Metabase",+ "main": "index.js",+ "private": true+}diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsxindex 4d596b6ebe5..015cf2459d5 100644--- a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx@@ -39,7 +39,7 @@ export const SdkUsageProblemBanner = ({// we fall back to the system font.const fontFamily = `${DEFAULT_FONT}, sans-serif`;- // eslint-disable-next-line no-literal-metabase-strings -- shown in development+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- shown in developmentconst pillTitle = "Metabase SDK";return (diff --git a/frontend/src/embedding-sdk-bundle/errors/base.ts b/frontend/src/embedding-sdk-bundle/errors/base.tsindex e3ab7948cc0..7ea6515635f 100644--- a/frontend/src/embedding-sdk-bundle/errors/base.ts+++ b/frontend/src/embedding-sdk-bundle/errors/base.ts@@ -6,7 +6,7 @@ export class MetabaseError<C extends MetabaseErrorCode, P> extends Error {constructor(code: C, message: string, params?: P) {super(message);- // eslint-disable-next-line no-literal-metabase-strings -- used as the name for the user-facing error+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- used as the name for the user-facing errorthis.name = "MetabaseError";this.code = code;this.params = params;diff --git a/frontend/src/embedding-sdk-bundle/errors/error-docs-links.ts b/frontend/src/embedding-sdk-bundle/errors/error-docs-links.tsindex 9395d087b94..7f594e71a38 100644--- a/frontend/src/embedding-sdk-bundle/errors/error-docs-links.ts+++ b/frontend/src/embedding-sdk-bundle/errors/error-docs-links.ts@@ -9,6 +9,6 @@ type ErrorDocLinks = Partial<Record<MetabaseErrorCode, string>>;**/export const ERROR_DOC_LINKS: ErrorDocLinks = {EXISTING_USER_SESSION_FAILED:- // eslint-disable-next-line no-unconditional-metabase-links-render -- error documentation link+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- error documentation link"https://www.metabase.com/docs/latest/embedding/embedded-analytics-js#use-existing-user-session-to-test-embeds",};diff --git a/frontend/src/embedding-sdk-bundle/errors/generic.ts b/frontend/src/embedding-sdk-bundle/errors/generic.tsindex 6a24e960da1..cff444cfc9e 100644--- a/frontend/src/embedding-sdk-bundle/errors/generic.ts+++ b/frontend/src/embedding-sdk-bundle/errors/generic.ts@@ -53,7 +53,7 @@ export function AUTH_TIMEOUT() {export function EXISTING_USER_SESSION_FAILED() {return new MetabaseError("EXISTING_USER_SESSION_FAILED",- // eslint-disable-next-line no-literal-metabase-strings -- developer-facing error message explaining authentication failure+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- developer-facing error message explaining authentication failure"Failed to authenticate using an existing Metabase user session.",);}diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.tsindex e5a0bd8eb48..c0cb6e57130 100644--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts@@ -38,7 +38,7 @@ export const useLogVersionInfo = () => {) {console.warn(`SDK package version ${sdkPackageVersion} is not compatible with SDK bundle version ${sdkBundleVersion}, this might cause issues.`,- // eslint-disable-next-line no-unconditional-metabase-links-render -- This links only shows for admins.+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This links only shows for admins."Learn more at https://www.metabase.com/docs/latest/embedding/sdk/version",);}@@ -46,7 +46,7 @@ export const useLogVersionInfo = () => {if (allowConsoleLog) {// eslint-disable-next-line no-consoleconsole.log(- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing string`Using Metabase modular embedding SDK package version ${sdkPackageVersion}, Metabase Embedding SDK bundle version ${sdkBundleVersion}`,);}diff --git a/frontend/src/embedding-sdk-bundle/lib/log-utils.ts b/frontend/src/embedding-sdk-bundle/lib/log-utils.tsindex 8b49ab7af9f..a852e13235d 100644--- a/frontend/src/embedding-sdk-bundle/lib/log-utils.ts+++ b/frontend/src/embedding-sdk-bundle/lib/log-utils.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals */+/* eslint-disable metabase/no-color-literals */// Note: these functions need to return an array of two elements, when styling// console.logs, the style needs to passed as second argumentdiff --git a/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts b/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.tsindex a84faeca9a6..fd4e742d604 100644--- a/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts+++ b/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals */+/* eslint-disable metabase/no-color-literals */import { match } from "ts-pattern";@@ -20,7 +20,7 @@ export function printUsageProblemToConsole(problem: SdkUsageProblem | null) {.exhaustive();const message =- // eslint-disable-next-line no-literal-metabase-strings -- console messages should not be white-labelled+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- console messages should not be white-labelled`%cMetabase modular embedding SDK for React\n\n` +`%c${problem.message}\n` +`See the documentation for more information:\n\n` +diff --git a/frontend/src/embedding-sdk-bundle/lib/usage-problem.ts b/frontend/src/embedding-sdk-bundle/lib/usage-problem.tsindex 69cede8159e..7e6b12412d1 100644--- a/frontend/src/embedding-sdk-bundle/lib/usage-problem.ts+++ b/frontend/src/embedding-sdk-bundle/lib/usage-problem.ts@@ -34,19 +34,19 @@ export const USAGE_PROBLEM_MESSAGES = {// This message only works on localhost at the moment, as we cannot detect if embedding is disabled due to CORS restrictions on /api/session/properties.EMBEDDING_SDK_NOT_ENABLED: `Embedding is not enabled for this instance. Please enable it in settings.`,- // eslint-disable-next-line no-literal-metabase-strings -- only shown in development.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- only shown in development.DEVELOPMENT_MODE_CLOUD_INSTANCE: `This Metabase is in development mode intended exclusively for testing. Using this Metabase for everyday BI work or when embedding in production is considered unfair usage.`,JWT_EXP_NULL: `The JWT token is missing the "exp" (expiration) claim. We will disallow tokens without "exp" in a future release. Please add "exp" to the token payload.`,} as const;export const SDK_AUTH_DOCS_URL =- // eslint-disable-next-line no-unconditional-metabase-links-render -- these links are used in the SDK banner which is only shown to developers+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- these links are used in the SDK banner which is only shown to developers"https://www.metabase.com/docs/latest/embedding/sdk/authentication#2-add-a-new-endpoint-to-your-backend-to-handle-authentication";export const METABASE_UPGRADE_URL = "https://www.metabase.com/upgrade";export const SDK_INTRODUCTION_DOCS_URL =- // eslint-disable-next-line no-unconditional-metabase-links-render -- these links are used in the SDK banner which is only shown to developers+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- these links are used in the SDK banner which is only shown to developers"https://www.metabase.com/docs/latest/embedding/sdk/introduction#in-metabase";/** Documentation for each kind of SDK usage problems */@@ -157,10 +157,10 @@ const toWarning = (type: SdkUsageProblemKey): SdkUsageProblem => ({const getTitle = () => {if (isEmbeddingEajs()) {- // eslint-disable-next-line no-literal-metabase-strings -- only shown in development or config error.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- only shown in development or config error.return "This embed is powered by Metabase";}- // eslint-disable-next-line no-literal-metabase-strings -- only shown in development or config error.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- only shown in development or config error.return "This embed is powered by the Metabase SDK.";};diff --git a/frontend/src/embedding-sdk-bundle/store/index.ts b/frontend/src/embedding-sdk-bundle/store/index.tsindex 4392605a84c..cd2a9b3ee63 100644--- a/frontend/src/embedding-sdk-bundle/store/index.ts+++ b/frontend/src/embedding-sdk-bundle/store/index.ts@@ -57,7 +57,7 @@ const useCheckSdkReduxContext = () => {if (!context) {console.warn(- // eslint-disable-next-line no-literal-metabase-strings -- not UI string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- not UI string"Cannot find react-redux context. Make sure component or hook is wrapped into MetabaseProvider",);}diff --git a/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts b/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.tsindex 70c4b0ffcd6..c8220fe8bb8 100644--- a/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts+++ b/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts@@ -5,7 +5,7 @@ import { createSelectorHook } from "react-redux";import type { SdkStoreState } from "embedding-sdk-bundle/store/types";import { MetabaseReduxContext } from "metabase/lib/redux";-// eslint-disable-next-line no-literal-metabase-strings -- this string only shows in the console.+// eslint-disable-next-line metabase/no-literal-metabase-strings -- this string only shows in the console.export const USE_OUTSIDE_OF_CONTEXT_MESSAGE = `Hooks from the Metabase modular embedding SDK must be used within a component wrapped by the MetabaseProvider`;const _useSdkSelector: TypedUseSelectorHook<SdkStoreState> =diff --git a/frontend/src/embedding-sdk-bundle/test/.eslintrc b/frontend/src/embedding-sdk-bundle/test/.eslintrcindex 0a13c236791..0cdf2a71db9 100644--- a/frontend/src/embedding-sdk-bundle/test/.eslintrc+++ b/frontend/src/embedding-sdk-bundle/test/.eslintrc@@ -1,5 +1,5 @@{"rules": {- "no-color-literals": "off"+ "metabase/no-color-literals": "off"}}diff --git a/frontend/src/metabase-types/api/mocks/card.ts b/frontend/src/metabase-types/api/mocks/card.tsindex a3b5625a9c5..06f06193ba6 100644--- a/frontend/src/metabase-types/api/mocks/card.ts+++ b/frontend/src/metabase-types/api/mocks/card.ts@@ -164,7 +164,7 @@ export const createMockColumnRangeFormattingSetting = (});export const createMockPieRow = (opts?: Partial<PieRow>): PieRow => ({- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalscolor: "#7172AD",defaultColor: false,enabled: true,@@ -180,7 +180,7 @@ export const createMockSegmentFormatting = (opts?: Partial<ScalarSegment>) => ({label: "good",min: 0,max: 1,- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalscolor: "#7172AD",...opts,});diff --git a/frontend/src/metabase-types/api/mocks/settings.ts b/frontend/src/metabase-types/api/mocks/settings.tsindex 5614bf94268..6db41f81e2a 100644--- a/frontend/src/metabase-types/api/mocks/settings.ts+++ b/frontend/src/metabase-types/api/mocks/settings.ts@@ -170,7 +170,7 @@ export const createMockSettings = ("application-colors": {},"application-font": "Lato","application-font-files": [],- // eslint-disable-next-line no-literal-metabase-strings -- This is a mock+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This is a mock"application-name": "Metabase","application-favicon-url": "","available-fonts": [],diff --git a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx b/frontend/src/metabase/browse/databases/BrowseDatabases.tsxindex 8111b9a787f..6e4065004bf 100644--- a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx+++ b/frontend/src/metabase/browse/databases/BrowseDatabases.tsx@@ -87,7 +87,7 @@ const CardImageWrapper = ({ database }: { database: string }) => {className={CS.rounded}style={{boxShadow:- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals"0px 0px 0px 1px rgba(0, 0, 0, 0.05), 0px 1px 4px 0px rgba(0, 0, 0, 0.10)",}}>diff --git a/frontend/src/metabase/browse/models/EmptyStates/ModelsVideo.tsx b/frontend/src/metabase/browse/models/EmptyStates/ModelsVideo.tsxindex d5d90f85d16..045995fe358 100644--- a/frontend/src/metabase/browse/models/EmptyStates/ModelsVideo.tsx+++ b/frontend/src/metabase/browse/models/EmptyStates/ModelsVideo.tsx@@ -10,7 +10,7 @@ export const ModelsVideo = ({ autoplay }: { autoplay: 0 | 1 }) => {className={cx(S.video)}referrerPolicy="strict-origin-when-cross-origin"src={`https://www.youtube.com/embed/Cb7-wLAgSCA?si=gPukXurSJAM8asGJ&autoplay=${autoplay}`}- // eslint-disable-next-line no-literal-metabase-strings -- It's just a title for the a11y purposes+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- It's just a title for the a11y purposestitle={t`Use Models in Metabase | Getting started with Metabase`}width="100%"></iframe>diff --git a/frontend/src/metabase/common/components/ColorPicker/ColorPicker.styled.tsx b/frontend/src/metabase/common/components/ColorPicker/ColorPicker.styled.tsxindex 0d6a1d37172..19c3699cde6 100644--- a/frontend/src/metabase/common/components/ColorPicker/ColorPicker.styled.tsx+++ b/frontend/src/metabase/common/components/ColorPicker/ColorPicker.styled.tsx@@ -13,7 +13,7 @@ export const ContentContainer = styled.div`// to fix this we copy relevant styles here// https://github.com/casesandberg/react-color/blob/v2.18.1/src/components/common/Hue.js#L78// https://github.com/casesandberg/react-color/blob/v2.18.1/src/components/common/Saturation.js#L94-// eslint-disable-next-line no-color-literals+// eslint-disable-next-line metabase/no-color-literalsexport const ControlsRoot = styled.div`.hue-horizontal {background: linear-gradient(diff --git a/frontend/src/metabase/common/components/CommunityLocalizationNotice/CommunityLocalizationNotice.tsx b/frontend/src/metabase/common/components/CommunityLocalizationNotice/CommunityLocalizationNotice.tsxindex e8167711cd4..2ce5894b3bd 100644--- a/frontend/src/metabase/common/components/CommunityLocalizationNotice/CommunityLocalizationNotice.tsx+++ b/frontend/src/metabase/common/components/CommunityLocalizationNotice/CommunityLocalizationNotice.tsx@@ -14,7 +14,7 @@ export function getLocalizationNoticeText({mentionMetabase: boolean;}) {return mentionMetabase- ? // eslint-disable-next-line no-literal-metabase-strings -- For admin screens we want to original app name+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- For admin screens we want to original app namet`Some translations are created by the Metabase community, and might not be perfect.`: t`Some translations are created by the community, and might not be perfect.`;}diff --git a/frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsx b/frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsxindex 3885dce55e5..0484fbee7be 100644--- a/frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsx+++ b/frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsx@@ -50,7 +50,7 @@ export const TabsView = <<Tabs.Listh="2.5rem"style={{- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals"--tab-border-color": "rgba(0, 0, 0, 0)",}}>diff --git a/frontend/src/metabase/common/components/ErrorPages/BugReportModal.tsx b/frontend/src/metabase/common/components/ErrorPages/BugReportModal.tsxindex fcc252853f2..edef6b7fde8 100644--- a/frontend/src/metabase/common/components/ErrorPages/BugReportModal.tsx+++ b/frontend/src/metabase/common/components/ErrorPages/BugReportModal.tsx@@ -79,7 +79,7 @@ export const BugReportModal = ({{t`Include diagnostic information`}</Text><Text color="text-secondary" w="80%">- {/* eslint-disable-next-line no-literal-metabase-strings -- this is a translation context string, not shown to users */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- this is a translation context string, not shown to users */}{c("{0} is the name of the application, usually 'Metabase'").t`This information helps ${applicationName} figure out what exactly caused the issue.`}</Text>diff --git a/frontend/src/metabase/common/components/ErrorPages/DiagnosticCheckboxes.tsx b/frontend/src/metabase/common/components/ErrorPages/DiagnosticCheckboxes.tsxindex 3c06c1f5538..151623f421d 100644--- a/frontend/src/metabase/common/components/ErrorPages/DiagnosticCheckboxes.tsx+++ b/frontend/src/metabase/common/components/ErrorPages/DiagnosticCheckboxes.tsx@@ -48,7 +48,7 @@ export const DiagnosticCheckboxes = ({)}<FormCheckboxname="bugReportDetails"- // eslint-disable-next-line no-literal-metabase-strings -- this is a hidden section of bug report+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- this is a hidden section of bug reportlabel={c("{0} is the name of the application, usually 'Metabase'").t`${applicationName} instance version information`}/>diff --git a/frontend/src/metabase/common/components/ErrorPages/DownloadDiagnosticModal.tsx b/frontend/src/metabase/common/components/ErrorPages/DownloadDiagnosticModal.tsxindex 7b76586a62e..d801d91c250 100644--- a/frontend/src/metabase/common/components/ErrorPages/DownloadDiagnosticModal.tsx+++ b/frontend/src/metabase/common/components/ErrorPages/DownloadDiagnosticModal.tsx@@ -55,7 +55,7 @@ export const DownloadDiagnosticModal = ({placeholder={t`What were you trying to do, and what steps did you take? What was the expected result, and what happened instead?`}/><Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- this is a translation context string, not shown to users */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- this is a translation context string, not shown to users */}{c("{0} is the name of the application, usually 'Metabase'").t`This information helps ${applicationName} figure out what exactly caused the issue`}</Text>diff --git a/frontend/src/metabase/common/components/ExportSettingsWidget/ExportSettingsWidget.tsx b/frontend/src/metabase/common/components/ExportSettingsWidget/ExportSettingsWidget.tsxindex eeefd413a5d..1caa060023e 100644--- a/frontend/src/metabase/common/components/ExportSettingsWidget/ExportSettingsWidget.tsx+++ b/frontend/src/metabase/common/components/ExportSettingsWidget/ExportSettingsWidget.tsx@@ -46,7 +46,7 @@ const useFormattingLabel = ({{ isEmbeddingSdk: false, isFormattingEnabled: true },() =>c(- // eslint-disable-next-line no-literal-metabase-strings -- used for translation context+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- used for translation context"Refers to formatting for a piece of data, like long or short form dates, or currency. {0} is the name of the application, typically Metabase.",).t`E.g. September 6, 2024 or $187.50, like in ${applicationName}`,)diff --git a/frontend/src/metabase/dashboard/components/ClickMappings.jsx b/frontend/src/metabase/dashboard/components/ClickMappings.jsxindex 1cddc2058e4..d2f9b239113 100644--- a/frontend/src/metabase/dashboard/components/ClickMappings.jsx+++ b/frontend/src/metabase/dashboard/components/ClickMappings.jsx@@ -246,7 +246,7 @@ function TargetWithSource({CS.flex,CS.alignCenter,)}- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsstyle={{ borderColor: "#E2E4E8" }}><svg@@ -260,14 +260,14 @@ function TargetWithSource({<g opacity="0.6"><pathd="M9 32C9 33.6569 7.65685 35 6 35C4.34315 35 3 33.6569 3 32C3 30.3431 4.34315 29 6 29C7.65685 29 9 30.3431 9 32Z"- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsfill="#509EE3"/><pathfillRule="evenodd"clipRule="evenodd"d="M12 6C12 8.973 9.83771 11.441 7 11.917V26.083C9.83771 26.559 12 29.027 12 32C12 35.3137 9.31371 38 6 38C2.68629 38 0 35.3137 0 32C0 29.027 2.16229 26.559 5 26.083V11.917C2.16229 11.441 0 8.973 0 6C0 2.68629 2.68629 0 6 0C9.31371 0 12 2.68629 12 6ZM6 10C8.20914 10 10 8.20914 10 6C10 3.79086 8.20914 2 6 2C3.79086 2 2 3.79086 2 6C2 8.20914 3.79086 10 6 10ZM6 36C8.20914 36 10 34.2091 10 32C10 29.7909 8.20914 28 6 28C3.79086 28 2 29.7909 2 32C2 34.2091 3.79086 36 6 36Z"- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsfill="#509EE3"/></g>diff --git a/frontend/src/metabase/databases/components/DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsx b/frontend/src/metabase/databases/components/DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsxindex b75d884a0fe..eefdbc6f2a2 100644--- a/frontend/src/metabase/databases/components/DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsx+++ b/frontend/src/metabase/databases/components/DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsx@@ -99,7 +99,7 @@ export const DatabaseCacheScheduleField = ({{scheduleMode === "on-demand" && (<Box c="text-secondary" fz="sm" maw={rem(620)} mt="sm">- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`When a user adds a new filter to a dashboard or a SQL question, Metabase will scan the field(s) mapped to that filter in order to show the list of selectable values.`}</Box>)}diff --git a/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx b/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsxindex 2ca663382ef..21bf9da8c8c 100644--- a/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx+++ b/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx@@ -228,7 +228,7 @@ const SampleDatabaseIndicator = () => {<Text ml="sm" mr="xs">{t`Sample Database for testing`}</Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- only shown to admins during setup */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- only shown to admins during setup */}<Text inline c="text-tertiary">{t`(by Metabase)`}</Text></Flex><Group gap="xs">diff --git a/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx b/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsxindex f156675a040..3aec612cd43 100644--- a/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx+++ b/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx@@ -98,7 +98,7 @@ const OldEngineWarning = ({ engineName, onChange }: OldEngineWarningProps) => (const CommunityEngineWarning = () => (<Warning icon="info">- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}{t`This is a community-developed driver and not supported by Metabase. `}</Warning>);diff --git a/frontend/src/metabase/databases/components/DatabaseForm/DatabaseFormFooter.tsx b/frontend/src/metabase/databases/components/DatabaseForm/DatabaseFormFooter.tsxindex e59c1849a1d..2b91c712778 100644--- a/frontend/src/metabase/databases/components/DatabaseForm/DatabaseFormFooter.tsx+++ b/frontend/src/metabase/databases/components/DatabaseForm/DatabaseFormFooter.tsx@@ -36,7 +36,7 @@ export const DatabaseFormFooter = ({const hasConnectionError = useHasConnectionError();const isDirty = useIsFormDirty();- // eslint-disable-next-line no-unconditional-metabase-links-render -- Metabase setup + admin pages only+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Metabase setup + admin pages onlyconst { url: docsUrl } = useDocsUrl("databases/connecting");const hasSampleDatabase = useSetting("has-sample-database?");diff --git a/frontend/src/metabase/databases/components/DatabaseFormError/ContactSupportButtonSection.tsx b/frontend/src/metabase/databases/components/DatabaseFormError/ContactSupportButtonSection.tsxindex c182db94bee..107fef74100 100644--- a/frontend/src/metabase/databases/components/DatabaseFormError/ContactSupportButtonSection.tsx+++ b/frontend/src/metabase/databases/components/DatabaseFormError/ContactSupportButtonSection.tsx@@ -20,7 +20,7 @@ export const ContactSupportButtonSection = () => {<TroubleshootingTipbody={<Flex direction="column" gap="md" align="flex-start">- {/* eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to admins */}{t`Reach out to Metabase engineers who can help with technical troubleshooting. Not your typical support agents.`}<Buttoncomponent={Link}diff --git a/frontend/src/metabase/databases/components/DatabaseFormError/DatabaseFormError.tsx b/frontend/src/metabase/databases/components/DatabaseFormError/DatabaseFormError.tsxindex 4671305b46a..3cc971ef635 100644--- a/frontend/src/metabase/databases/components/DatabaseFormError/DatabaseFormError.tsx+++ b/frontend/src/metabase/databases/components/DatabaseFormError/DatabaseFormError.tsx@@ -22,7 +22,7 @@ export const DatabaseFormError = () => {const ref = useRef<HTMLDivElement>(null);const title = isHostAndPortError? t`Hmm, we couldn't connect to the database`- : // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ : // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminst`Metabase tried, but couldn't connect`;useMount(() => {diff --git a/frontend/src/metabase/databases/components/DatabaseFormError/useTroubleshootingTips.tsx b/frontend/src/metabase/databases/components/DatabaseFormError/useTroubleshootingTips.tsxindex ad2a9bdcfd2..f7d09321b84 100644--- a/frontend/src/metabase/databases/components/DatabaseFormError/useTroubleshootingTips.tsx+++ b/frontend/src/metabase/databases/components/DatabaseFormError/useTroubleshootingTips.tsx@@ -36,7 +36,7 @@ export const useTroubleshootingTips = (}const cloudIPLinkContent = getDocsLinkConditionally(- // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminst`Metabase Cloud IP addresses`,getDocPageUrl("cloud/ip-addresses-to-whitelist"),showMetabaseLinks,@@ -55,12 +55,12 @@ export const useTroubleshootingTips = (return [{key: "ip-addresses" as const,- // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminstitle: t`Try allowing Metabase IP addresses`,body: (<>{- // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminsc("{0} refers to 'Metabase Cloud IP addresses'").jt`If the database is behind a firewall or VPN, you may need to allow connections from the ${cloudIPLinkContent}.`}@@ -80,12 +80,12 @@ export const useTroubleshootingTips = (},{key: "permissions" as const,- // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminstitle: t`Check Metabase user permissions`,body: (() => {// unchained `c` -> `jt` call to avoid prettier moving no-literal-metabase-strings comment upconst ctx = c("{0} refers to 'correct permissions'");- // eslint-disable-next-line no-literal-metabase-strings -- Only visible to admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Only visible to adminsreturn ctx.jt`Check that Metabase has the ${permissionsLinkContent} or user role for your database.`;})(),},diff --git a/frontend/src/metabase/databases/components/DatabaseHelpCard/DatabaseHelpCard.tsx b/frontend/src/metabase/databases/components/DatabaseHelpCard/DatabaseHelpCard.tsxindex 89483de41ed..c6f33d225e7 100644--- a/frontend/src/metabase/databases/components/DatabaseHelpCard/DatabaseHelpCard.tsx+++ b/frontend/src/metabase/databases/components/DatabaseHelpCard/DatabaseHelpCard.tsx@@ -13,7 +13,7 @@ export const DatabaseHelpCard = ({className,}: DatabaseHelpCardProps): JSX.Element => {const docsUrl = useSelector((state) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- Metabase setup+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Metabase setupgetDocsUrl(state, { page: "databases/connecting" }),);const isHosted = useSelector((state) => getSetting(state, "is-hosted?"));diff --git a/frontend/src/metabase/databases/components/DatabaseNameField/DatabaseNameField.tsx b/frontend/src/metabase/databases/components/DatabaseNameField/DatabaseNameField.tsxindex 6d098fe45ff..d4f56bd4084 100644--- a/frontend/src/metabase/databases/components/DatabaseNameField/DatabaseNameField.tsx+++ b/frontend/src/metabase/databases/components/DatabaseNameField/DatabaseNameField.tsx@@ -34,7 +34,7 @@ export const DatabaseNameField = ({config.name?.isSlug || false,)}rightSection={- // eslint-disable-next-line no-literal-metabase-strings -- Admin settings+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings<Tooltip label={t`Choose what this data will be called in Metabase.`}><Icon name="info" /></Tooltip>diff --git a/frontend/src/metabase/databases/components/DatabaseSshDescription/DatabaseSshDescription.tsx b/frontend/src/metabase/databases/components/DatabaseSshDescription/DatabaseSshDescription.tsxindex 396a9f1e6c1..9c8ccdd6f86 100644--- a/frontend/src/metabase/databases/components/DatabaseSshDescription/DatabaseSshDescription.tsx+++ b/frontend/src/metabase/databases/components/DatabaseSshDescription/DatabaseSshDescription.tsx@@ -4,7 +4,7 @@ import ExternalLink from "metabase/common/components/ExternalLink";import { useDocsUrl } from "metabase/common/hooks";const DatabaseSshDescription = (): JSX.Element => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- Admin settings+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Admin settingsconst { url: docsUrl } = useDocsUrl("databases/ssh-tunnel");return (diff --git a/frontend/src/metabase/databases/components/DatabaseSslKeyDescription/DatabaseSslKeyDescription.tsx b/frontend/src/metabase/databases/components/DatabaseSslKeyDescription/DatabaseSslKeyDescription.tsxindex abaa56f79c8..eacb731830c 100644--- a/frontend/src/metabase/databases/components/DatabaseSslKeyDescription/DatabaseSslKeyDescription.tsx+++ b/frontend/src/metabase/databases/components/DatabaseSslKeyDescription/DatabaseSslKeyDescription.tsx@@ -9,7 +9,7 @@ const DatabaseSslKeyDescription = (): JSX.Element | null => {const { values } = useFormikContext<DatabaseData>();const { engine } = values;- // eslint-disable-next-line no-unconditional-metabase-links-render -- Admin settings+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Admin settingsconst { url: docsUrl } = useDocsUrl("databases/connections/postgresql", {anchor: "authenticate-client-certificate",});diff --git a/frontend/src/metabase/embedding/embedding-hub/components/DocsLink.tsx b/frontend/src/metabase/embedding/embedding-hub/components/DocsLink.tsxindex 783a3dbb839..9b0b4a2d6cc 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/DocsLink.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/DocsLink.tsx@@ -18,7 +18,7 @@ export const DocsLink = ({utm,children,}: DocsLinkProps) => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- we are in admin so we must always show the link.+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- we are in admin so we must always show the link.const { url } = useDocsUrl(docsPath, {anchor,utm: {diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/AuthenticationSection.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/AuthenticationSection.tsxindex 6a208617caa..0cff26f35f8 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/AuthenticationSection.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/AuthenticationSection.tsx@@ -62,7 +62,7 @@ export const AuthenticationSection = () => {<Radiovalue="sso"label={- // eslint-disable-next-line no-literal-metabase-strings -- Public Facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Public Facing stringt`Metabase account (SSO)`}disabled={!isSimpleEmbedFeatureAvailable}diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/MetabaseAccountSection.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/MetabaseAccountSection.tsxindex 8a4c0a7708a..b878bcb79df 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/MetabaseAccountSection.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Authentication/MetabaseAccountSection.tsx@@ -22,7 +22,7 @@ export const MetabaseAccountSection = () => {const isGuestEmbed = !!settings.isGuest;- // eslint-disable-next-line no-unconditional-metabase-links-render -- Only for admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Only for adminsconst { url: setupSsoUrl } = useDocsUrl("embedding/sdk/authentication", {utm: utmTags,});@@ -45,7 +45,7 @@ export const MetabaseAccountSection = () => {<Stack gap="md" p="xs"><Text size="lg" fw="bold">{- // eslint-disable-next-line no-literal-metabase-strings -- Public Facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Public Facing stringt`Metabase account`}</Text>diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsxindex d903e74596b..fbf75ac5c2c 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx@@ -27,7 +27,7 @@ export const EmbeddingUpsell = ({ campaign }: Props) => {buttonLink={upgradeUrl}campaign={campaign}location={UTM_LOCATION}- /* eslint-disable-next-line no-literal-metabase-strings -- Button text */+ /* eslint-disable-next-line metabase/no-literal-metabase-strings -- Button text */buttonText={t`Upgrade to Metabase Pro`}fullWidthmaxWidth="initial"diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddingCard.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddingCard.tsxindex 8ba8f17f698..8b53f311a09 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddingCard.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddingCard.tsx@@ -104,7 +104,7 @@ export const EnableEmbeddingCard = ({<HoverCard.Dropdown><Stack maw={340} p="md" gap="md"><Text fz="sm" lh="lg">- {/* eslint-disable-next-line no-literal-metabase-strings -- User facing text */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- User facing text */}{t`When you embed charts or dashboards from Metabase in yourown application that application isn't subject to the AfferoGeneral Public License that covers the rest of Metabase,diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/embed-snippet.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/embed-snippet.tsindex 6cfe98e3e9c..e689a353896 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/embed-snippet.ts+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/embed-snippet.ts@@ -25,7 +25,7 @@ export function getEmbedSnippet({experience: SdkIframeEmbedSetupExperience;guestEmbedSignedTokenForSnippet: string | null;}): string {- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.return `<script defer src="${instanceUrl}/app/embed.js"></script><script>function defineMetabaseConfig(config) {diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsxindex 5f07de48e46..2929304d352 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx@@ -22,22 +22,22 @@ export const EmbedHomepage = () => {const hasEmbeddingFeature = useHasTokenFeature("embedding");const embeddingDocsUrl = useSelector((state) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- only visible to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- only visible to adminsgetDocsUrl(state, { page: "embedding/start" }),);const learnMoreInteractiveEmbedding = useSelector((state) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- this is only visible to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- this is only visible to adminsgetDocsUrl(state, { page: "embedding/interactive-embedding" }),);const learnMoreStaticEmbedding = useSelector((state) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- this is only visible to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- this is only visible to adminsgetDocsUrl(state, { page: "embedding/static-embedding" }),);const embedJsDocsUrl = useSelector((state) =>- // eslint-disable-next-line no-unconditional-metabase-links-render -- this is only visible to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- this is only visible to adminsgetDocsUrl(state, { page: "embedding/embedded-analytics-js" }),);@@ -89,7 +89,7 @@ export const EmbedHomepage = () => {hasEmbeddingFeature={hasEmbeddingFeature}embeddingDocsUrl={embeddingDocsUrl + utmTags}analyticsDocsUrl={- // eslint-disable-next-line no-unconditional-metabase-links-render -- only visible to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- only visible to admins"https://www.metabase.com/learn/customer-facing-analytics/" + utmTags}learnMoreInteractiveEmbedUrl={learnMoreInteractiveEmbedding + utmTags}diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsxindex ea5aa25edcd..6175aacdf92 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx@@ -99,10 +99,10 @@ export const EmbedHomepageView = (props: EmbedHomepageViewProps) => {<Card px="xl" py="lg"><Stack gap="xl"><Box>- {/* eslint-disable-next-line no-literal-metabase-strings -- only visible to admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- only visible to admins */}<Title order={2} mb="md">{t`Embedding Metabase`}</Title><Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- only visible to admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- only visible to admins */}{t`Give your customers secure, multi-tenant access to their data with as much (or as little) interactivity and tools to explore data as you want, with as much customization as you need. Embed dashboards, charts—even Metabase's query editor—with iframes or as individual React components.`}</Text></Box>diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsxindex 215a12bdf95..be82a72cf1c 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx@@ -47,7 +47,7 @@ export const EmbedJsContent = ({id="embed-js-title">{t`Modular embedding`}</Text><Text mb="md">- {/* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */}{t`A JavaScript library built on top of Metabase’s modular embedding SDK that lets you embed individual components (charts, dashboards, query builder) using plain JS — no React setup required. You get per-component controls like drill-through, parameters, downloads, theming.`}</Text>{showImage && (diff --git a/frontend/src/metabase/home/components/EmbedHomepage/FeedbackModal.tsx b/frontend/src/metabase/home/components/EmbedHomepage/FeedbackModal.tsxindex 1c232f1d45f..3e4559f9be9 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/FeedbackModal.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/FeedbackModal.tsx@@ -42,7 +42,7 @@ export const FeedbackModal = ({><Title pb="sm" order={2}>{t`How can we improve embedding?`}</Title><Stack gap="lg">- {/* eslint-disable-next-line no-literal-metabase-strings -- only admins can see this component */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- only admins can see this component */}<Text>{t`Please let us know what happened. We’re always looking for ways to improve Metabase.`}</Text><Textareadiff --git a/frontend/src/metabase/home/components/EmbedHomepage/HeaderWithDismiss.tsx b/frontend/src/metabase/home/components/EmbedHomepage/HeaderWithDismiss.tsxindex 5efada8a586..b95a3ed9dd3 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/HeaderWithDismiss.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/HeaderWithDismiss.tsx@@ -13,7 +13,7 @@ export const HeaderWithDismiss = ({ onDismiss }: HeaderWithDismissProps) => {<Group gap="space-between"><Textfw="bold"- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.>{t`Get started with Embedding Metabase in your app`}</Text><Menu trigger="hover" closeDelay={200}><Menu.Target>diff --git a/frontend/src/metabase/home/components/EmbedHomepage/NeedMoreInfoCard.tsx b/frontend/src/metabase/home/components/EmbedHomepage/NeedMoreInfoCard.tsxindex 0287cc9f131..be2d91e20e4 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/NeedMoreInfoCard.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/NeedMoreInfoCard.tsx@@ -15,7 +15,7 @@ export const NeedMoreInfoCard = ({<Card px="xl"><Text c="text-primary" fw="bold">{t`Need more information?`}</Text><Text c="text-tertiary" size="sm">- {/* eslint-disable-next-line no-literal-metabase-strings -- only visible to admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- only visible to admins */}{jt`Explore the ${(<ExternalLink key="embedding-docs" href={embeddingDocsUrl}>{t`embedding documentation`}diff --git a/frontend/src/metabase/home/components/EmbedHomepage/StaticEmbedContent.tsx b/frontend/src/metabase/home/components/EmbedHomepage/StaticEmbedContent.tsxindex 814ead6eed0..c4c0b681dfe 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/StaticEmbedContent.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/StaticEmbedContent.tsx@@ -28,7 +28,7 @@ export const StaticEmbedContent = ({id="static-embed-title">{t`Guest embedding`}</Text><Text mb="md">- {/* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins. */}{t`Embed a dashboard in a 'Powered by Metabase' iframe with interactivity limited to filters and tooltips, and a few customization options. The iframe loads a Metabase URL secured with a signed JSON Web Token (JWT). Appears with "Powered by Metabase", on Open Source and Starter plans, with the option to remove on Pro and Enterprise. As the simplest form of embedding, you can add a dashboard into your app in a few minutes with just a snippet.`}</Text>{showImage && (diff --git a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsxindex ae0d9eb780b..b025dd8eff9 100644--- a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx+++ b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx@@ -286,10 +286,10 @@ export const Onboarding = () => {width="100%"/>{!isPaidPlan ? (- // eslint-disable-next-line no-literal-metabase-strings -- OSS doesn't have whitelabeling option+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- OSS doesn't have whitelabeling option<Text>{t`Don't be shy with invites. Metabase makes self-service analytics easy.`}</Text>) : (- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins<Text>{t`Don't be shy with invites. Metabase Starter plan includes 5 users, and Pro includes 10 users without the need to pay additionally.`}</Text>)}diff --git a/frontend/src/metabase/lib/analytics.ts b/frontend/src/metabase/lib/analytics.tsindex f9df514c4a9..a80b541ec2e 100644--- a/frontend/src/metabase/lib/analytics.ts+++ b/frontend/src/metabase/lib/analytics.ts@@ -50,7 +50,7 @@ export function trackSchemaEvent(schema: SchemaType, event: SchemaEvent): void {// eslint-disable-next-line no-consoleconsole.log(`%c[SNOWPLOW EVENT | event sent:${shouldSendEvent}]%c, ${type}`,- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals"background: #222; color: #bada55","color: ",other,diff --git a/frontend/src/metabase/lib/api.js b/frontend/src/metabase/lib/api.jsindex 41088676630..253cb9bce7d 100644--- a/frontend/src/metabase/lib/api.js+++ b/frontend/src/metabase/lib/api.js@@ -11,9 +11,9 @@ import { PLUGIN_API, PLUGIN_EMBEDDING_SDK } from "metabase/plugins";const ONE_SECOND = 1000;const MAX_RETRIES = 10;-// eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+// eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringconst ANTI_CSRF_HEADER = "X-Metabase-Anti-CSRF-Token";-// eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+// eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringconst METABASE_VERSION_HEADER = "X-Metabase-Version";let ANTI_CSRF_TOKEN = null;@@ -67,12 +67,12 @@ export class Api extends EventEmitter {}if (this.sessionToken) {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Session"] = self.sessionToken;}if (isWithinIframe() && !self.requestClient) {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Embedded"] = "true";/*** We counted static embed preview query executions which led to wrong embedding stats (EMB-930)@@ -80,20 +80,20 @@ export class Api extends EventEmitter {* embedding iframe (only for Documents at the time of this comment)*/if (!IFRAMED_IN_SELF) {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Client"] = "embedding-iframe";}}if (self.requestClient) {if (typeof self.requestClient === "object") {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Client"] = self.requestClient.name;- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Client-Version"] =self.requestClient.version ?? "unknown";} else {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Client"] = self.requestClient;}}@@ -102,11 +102,11 @@ export class Api extends EventEmitter {headers[ANTI_CSRF_HEADER] = ANTI_CSRF_TOKEN;}- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringif (DEFAULT_OPTIONS.headers["X-Metabase-Locale"]) {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringheaders["X-Metabase-Locale"] =- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringDEFAULT_OPTIONS.headers["X-Metabase-Locale"];}@@ -449,6 +449,6 @@ export const setLocaleHeader = (locale) => {* We need it to localize downloads. It *currently* only work if there is a user, so it won't work* for public/static embedding.*/- // eslint-disable-next-line no-literal-metabase-strings -- Header name, not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Header name, not a user facing stringDEFAULT_OPTIONS.headers["X-Metabase-Locale"] = locale ?? undefined;};diff --git a/frontend/src/metabase/lib/colors/constants/accent-colors.ts b/frontend/src/metabase/lib/colors/constants/accent-colors.tsindex 747bf71c0ba..58ce8117ff9 100644--- a/frontend/src/metabase/lib/colors/constants/accent-colors.ts+++ b/frontend/src/metabase/lib/colors/constants/accent-colors.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals -- we define chart colors here to avoid duplication */+/* eslint-disable metabase/no-color-literals -- we define chart colors here to avoid duplication */import type { ChartColorV2 } from "../types";diff --git a/frontend/src/metabase/lib/colors/constants/base-colors.ts b/frontend/src/metabase/lib/colors/constants/base-colors.tsindex 2759025d351..febec63cda7 100644--- a/frontend/src/metabase/lib/colors/constants/base-colors.ts+++ b/frontend/src/metabase/lib/colors/constants/base-colors.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals */+/* eslint-disable metabase/no-color-literals */// NOTE: DO NOT ADD COLORS WITHOUT EXTREMELY GOOD REASON AND DESIGN REVIEW/**diff --git a/frontend/src/metabase/lib/colors/constants/themes/dark.ts b/frontend/src/metabase/lib/colors/constants/themes/dark.tsindex 3aab68fe346..62e4131ff07 100644--- a/frontend/src/metabase/lib/colors/constants/themes/dark.ts+++ b/frontend/src/metabase/lib/colors/constants/themes/dark.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals */+/* eslint-disable metabase/no-color-literals */import type { MetabaseThemeV2 } from "../../types";import { DARK_THEME_ACCENT_COLORS } from "../accent-colors";import { getBaseColorsForThemeDefinitionOnly } from "../base-colors";diff --git a/frontend/src/metabase/lib/colors/constants/themes/light.ts b/frontend/src/metabase/lib/colors/constants/themes/light.tsindex f42d14c3c70..e46635ba0ac 100644--- a/frontend/src/metabase/lib/colors/constants/themes/light.ts+++ b/frontend/src/metabase/lib/colors/constants/themes/light.ts@@ -1,4 +1,4 @@-/* eslint-disable no-color-literals */+/* eslint-disable metabase/no-color-literals */import type { MetabaseThemeV2 } from "../../types";import { LIGHT_THEME_ACCENT_COLORS } from "../accent-colors";import { getBaseColorsForThemeDefinitionOnly } from "../base-colors";diff --git a/frontend/src/metabase/lib/i18n.js b/frontend/src/metabase/lib/i18n.jsindex e361b93ba1f..60ee4159ba6 100644--- a/frontend/src/metabase/lib/i18n.js+++ b/frontend/src/metabase/lib/i18n.js@@ -28,7 +28,7 @@ export async function loadLocalization(locale) {"plural-forms": "nplurals=2; plural=(n != 1);",},translations: {- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing string"": { Metabase: { msgid: "Metabase", msgstr: ["Metabase"] } },},};diff --git a/frontend/src/metabase/metadata/components/DataSourceInput.tsx b/frontend/src/metabase/metadata/components/DataSourceInput.tsxindex 2d08f0bc927..7ec1a474d29 100644--- a/frontend/src/metabase/metadata/components/DataSourceInput.tsx+++ b/frontend/src/metabase/metadata/components/DataSourceInput.tsx@@ -44,7 +44,7 @@ function getData(showMetabaseTransform?: boolean) {{ value: "unknown" as const, label: t`Unspecified` },{ value: "ingested" as const, label: t`Ingested` },showMetabaseTransform- ? // eslint-disable-next-line no-literal-metabase-strings -- shown in Data Studio only+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- shown in Data Studio only{ value: "metabase-transform" as const, label: t`Metabase transform` }: undefined,{ value: "transform" as const, label: t`Transform` },diff --git a/frontend/src/metabase/metadata/components/SyncOptionsModal/SyncOptionsModal.tsx b/frontend/src/metabase/metadata/components/SyncOptionsModal/SyncOptionsModal.tsxindex 1be034097cc..8f1df1e4dc0 100644--- a/frontend/src/metabase/metadata/components/SyncOptionsModal/SyncOptionsModal.tsx+++ b/frontend/src/metabase/metadata/components/SyncOptionsModal/SyncOptionsModal.tsx@@ -32,7 +32,7 @@ export const SyncOptionsModal = ({<Text fw="bold">{t`Re-sync schema`}</Text><Text c="text-secondary" size="sm">- {/* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */}{t`If you’ve made changes to this table in the underlying database that aren’t showing up in Metabase yet, re-syncing the schema can fix that.`}</Text></Stack>@@ -45,7 +45,7 @@ export const SyncOptionsModal = ({<Text fw="bold">{t`Scan field values`}</Text><Text c="text-secondary" size="sm">- {/* eslint-disable-next-line no-literal-metabase-strings -- Admin settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Admin settings */}{t`Metabase can scan the values in this table to enable checkbox filters in dashboards and questions.`}</Text></Stack>diff --git a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsxindex b87080ea55f..8b7f6684615 100644--- a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx+++ b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx@@ -73,7 +73,7 @@ export const AdminNavbar = ({<AdminLogoLink to="/admin"><AdminLogoContainer><LogoIcon className={cx(CS.textBrand, CS.my2)} dark />- {/* eslint-disable-next-line no-literal-metabase-strings -- Metabase settings */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Metabase settings */}<AdminLogoText>{t`Metabase Admin`}</AdminLogoText></AdminLogoContainer></AdminLogoLink>diff --git a/frontend/src/metabase/nav/components/ProfileLink/ProfileLink.tsx b/frontend/src/metabase/nav/components/ProfileLink/ProfileLink.tsxindex fea1b96425c..bcdaffcde81 100644--- a/frontend/src/metabase/nav/components/ProfileLink/ProfileLink.tsx+++ b/frontend/src/metabase/nav/components/ProfileLink/ProfileLink.tsx@@ -123,7 +123,7 @@ function ProfileLinkInner({}if (showOnboardingLink) {menuItems.push({- // eslint-disable-next-line no-literal-metabase-strings -- This string only shows for non-whitelabeled instances+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for non-whitelabeled instancestitle: t`How to use Metabase`,icon: null,link: "/getting-started",@@ -291,9 +291,9 @@ function ProfileLinkInner({)}><span className={CS.block}>- {/* eslint-disable-next-line i18next/no-literal-string, no-literal-metabase-strings -- This only shows on OSS instance */}+ {/* eslint-disable-next-line i18next/no-literal-string, metabase/no-literal-metabase-strings -- This only shows on OSS instance */}<span className={CS.textBold}>Metabase</span>{" "}- {/* eslint-disable-next-line i18next/no-literal-string, no-literal-metabase-strings -- This only shows on OSS instance */}+ {/* eslint-disable-next-line i18next/no-literal-string, metabase/no-literal-metabase-strings -- This only shows on OSS instance */}{t`is a Trademark of`} Metabase, Inc</span><span>{t`and is built with care by a team from all across this pale blue dot.`}</span>diff --git a/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx b/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsxindex f6024be2bae..9b4d8a5f08c 100644--- a/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx+++ b/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx@@ -9,7 +9,7 @@ export const ReadOnlyBanner = () => {bg="warning"body={<Text fw="bold" c="text-primary">- {/* eslint-disable-next-line no-literal-metabase-strings -- correct usage */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- correct usage */}{t`Metabase is under maintenance and is operating in read-only mode. It should only take up to 30 minutes.`}</Text>}diff --git a/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.tsx b/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.tsxindex abb4cc7db78..ab4cd6ef6bd 100644--- a/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.tsx+++ b/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.tsx@@ -66,7 +66,7 @@ export function WhatsNewNotification() {</IconButtonWrapper></Flex>- {/* eslint-disable-next-line no-literal-metabase-strings -- This only shows for admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This only shows for admins */}<Text fw="bold" size="sm">{t`Metabase has been updated`}</Text><Anchordiff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.tsxindex 2eeba7def60..d6826146a85 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/GettingStartedSection.tsx@@ -58,7 +58,7 @@ export const GettingStartedSection = ({isSelected={isOnboardingPageSelected}onClick={() => trackOnboardingChecklistOpened()}>- {/* eslint-disable-next-line no-literal-metabase-strings -- We only show this to non-whitelabelled instances */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- We only show this to non-whitelabelled instances */}{t`How to use Metabase`}</PaddedSidebarLink>diff --git a/frontend/src/metabase/plugins/oss/core.ts b/frontend/src/metabase/plugins/oss/core.tsindex 5fe4d22f581..c1d28275384 100644--- a/frontend/src/metabase/plugins/oss/core.ts+++ b/frontend/src/metabase/plugins/oss/core.ts@@ -79,7 +79,7 @@ const getDefaultSelectors = () => ({canWhitelabel: (_state: State) => false,getLoadingMessageFactory: (_state: State) => getLoadingMessage,getIsWhiteLabeling: (_state: State) => false,- // eslint-disable-next-line no-literal-metabase-strings -- This is the actual Metabase name, so we don't want to translate it.+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- This is the actual Metabase name, so we don't want to translate it.getApplicationName: (_state: State) => "Metabase",getShowMetabaseLinks: (_state: State) => true,getLoginPageIllustration: (_state: State): IllustrationValue => {diff --git a/frontend/src/metabase/public/components/EmbedFrame/LogoBadge/LogoBadge.tsx b/frontend/src/metabase/public/components/EmbedFrame/LogoBadge/LogoBadge.tsxindex 0d4eab04c81..42325b07664 100644--- a/frontend/src/metabase/public/components/EmbedFrame/LogoBadge/LogoBadge.tsx+++ b/frontend/src/metabase/public/components/EmbedFrame/LogoBadge/LogoBadge.tsx@@ -23,7 +23,7 @@ export const LogoBadge = ({ dark }: { dark: boolean }) => {target="_blank"><span>{t`Powered by`}</span>- {/* eslint-disable-next-line no-literal-metabase-strings -- This embedding badge which we don't want to show the whitelabeled name */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This embedding badge which we don't want to show the whitelabeled name */}<MetabaseLogoWithText height={32} aria-label="Metabase" /></ExternalLink>);diff --git a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsxindex 8cd9711d2f3..eafbc3f8d7d 100644--- a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx+++ b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx@@ -55,7 +55,7 @@ export const LookAndFeelSettings = ({displayOptions,onChangeDisplayOptions,}: AppearanceSettingsProps): JSX.Element => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- Only appear to admins+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- Only appear to adminsconst { url: docsUrl } = useDocsUrl("embedding/static-embedding", {anchor: "customizing-the-appearance-of-static-embeds",utm: {diff --git a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/OverviewSettings.tsx b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/OverviewSettings.tsxindex f30f203a268..9443ffe7b08 100644--- a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/OverviewSettings.tsx+++ b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/OverviewSettings.tsx@@ -37,7 +37,7 @@ export const OverviewSettings = ({clientCodeOptions[0].id,);- // eslint-disable-next-line no-unconditional-metabase-links-render -- This links only shows for admins.+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This links only shows for admins.const { url: docsUrl } = useDocsUrl("embedding/static-embedding", {utm: {utm_source: "product",diff --git a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/utils.ts b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/utils.tsindex 4583c47a5c6..c1e4f458cb3 100644--- a/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/utils.ts+++ b/frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/utils.ts@@ -10,9 +10,9 @@ export function getCheckerBoardDataUri() {const [color1, color2] = match(theme).returnType<[string, string]>()- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals.with("checkerboard-light", () => ["#ededed", "#ffffff"])- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals.with("checkerboard-dark", () => ["#000000", "#323232"]).exhaustive();diff --git a/frontend/src/metabase/public/components/widgets/LegaleseStep/LegaleseStep.tsx b/frontend/src/metabase/public/components/widgets/LegaleseStep/LegaleseStep.tsxindex 200d9cfeafb..539a436da4e 100644--- a/frontend/src/metabase/public/components/widgets/LegaleseStep/LegaleseStep.tsx+++ b/frontend/src/metabase/public/components/widgets/LegaleseStep/LegaleseStep.tsx@@ -41,7 +41,7 @@ export const LegaleseStep = ({)}`}</Text><Text>- {/* eslint-disable-next-line no-literal-metabase-strings -- This only shows for admins */}+ {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- This only shows for admins */}{t`When you embed charts or dashboards from Metabase in your own application that application isn't subject to the Affero General Public License that covers the rest of Metabase, provided you keep the Metabase logo and the "Powered by Metabase" visible on those embeds.`}</Text><Text>diff --git a/frontend/src/metabase/public/hooks/use-embed-frame-options.ts b/frontend/src/metabase/public/hooks/use-embed-frame-options.tsindex e434021188d..c46662fb2a9 100644--- a/frontend/src/metabase/public/hooks/use-embed-frame-options.ts+++ b/frontend/src/metabase/public/hooks/use-embed-frame-options.ts@@ -24,7 +24,7 @@ export const useEmbedFrameOptions = ({ location }: { location: Location }) => {hide_download_button?: boolean | null;};- // eslint-disable-next-line no-unconditional-metabase-links-render -- this is a console.error for a deprecated parameter+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- this is a console.error for a deprecated parameterconst { url: staticEmbedParametersDocsUrl } = useDocsUrl("embedding/static-embedding-parameters",{@@ -36,7 +36,7 @@ export const useEmbedFrameOptions = ({ location }: { location: Location }) => {if (hide_download_button !== null) {console.error(`%c⚠️ The \`hide_download_button\` option has been removed. Please use the \`downloads\` option instead: ${staticEmbedParametersDocsUrl}`,- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literals"color: #FF2222; font-size: 16px; font-weight: bold;",);}diff --git a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorTablePicker/DataSelectorTablePicker.tsx b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorTablePicker/DataSelectorTablePicker.tsxindex cd58e5e708a..944d221199a 100644--- a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorTablePicker/DataSelectorTablePicker.tsx+++ b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorTablePicker/DataSelectorTablePicker.tsx@@ -154,7 +154,7 @@ export const DataSelectorTablePicker = ({};const LinkToDocsOnReferencingSavedQuestionsInQueries = () => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- It's hard to tell if this is still used in the app. Please see https://metaboat.slack.com/archives/C505ZNNH4/p1703243785315819+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- It's hard to tell if this is still used in the app. Please see https://metaboat.slack.com/archives/C505ZNNH4/p1703243785315819const { url: docsUrl } = useDocsUrl("questions/native-editor/referencing-saved-questions-in-queries",);diff --git a/frontend/src/metabase/querying/expressions/config.ts b/frontend/src/metabase/querying/expressions/config.tsindex 95f918411ba..f20e44765e6 100644--- a/frontend/src/metabase/querying/expressions/config.ts+++ b/frontend/src/metabase/querying/expressions/config.ts@@ -1055,7 +1055,7 @@ const DATE = defineClauses(optional: true,description:// TODO: This is the only place that's not easy to replace the application name.- // eslint-disable-next-line no-literal-metabase-strings -- Hard to replace the application name because it's not a React component+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Hard to replace the application name because it's not a React componentt`Optional. The default is \`"ISO"\`.- ISO: Week 1 starts on the Monday before the first Thursday of January.- US: Week 1 starts on Jan 1. All other weeks start on Sunday.diff --git a/frontend/src/metabase/redux/downloads.ts b/frontend/src/metabase/redux/downloads.tsindex c4c76de9d69..00f602ee5a3 100644--- a/frontend/src/metabase/redux/downloads.ts+++ b/frontend/src/metabase/redux/downloads.ts@@ -590,7 +590,7 @@ export const getChartFileName = (question: Question, branded: boolean) => {const name = question.displayName() ?? t`New question`;const date = new Date().toLocaleString();const fileName = `${name}-${date}.png`;- // eslint-disable-next-line no-literal-metabase-strings -- Used explicitly in non-whitelabeled instances+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Used explicitly in non-whitelabeled instancesreturn branded ? `Metabase-${fileName}` : fileName;};@@ -600,7 +600,7 @@ export const getDashboardPdfFileName = () => {const originalFileName = `${dashboard.name}.pdf`;const fileName = branded- ? // eslint-disable-next-line no-literal-metabase-strings -- Used explicitly in non-whitelabeled instances+ ? // eslint-disable-next-line metabase/no-literal-metabase-strings -- Used explicitly in non-whitelabeled instances`Metabase - ${originalFileName}`: originalFileName;return fileName;diff --git a/frontend/src/metabase/route-guards.tsx b/frontend/src/metabase/route-guards.tsxindex cc1e0262df2..0fc63ade81d 100644--- a/frontend/src/metabase/route-guards.tsx+++ b/frontend/src/metabase/route-guards.tsx@@ -27,7 +27,7 @@ const getRedirectUrl = () => {};const MetabaseIsSetup = connectedReduxRedirect<Props, State>({- // eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Not a user facing stringwrapperDisplayName: "MetabaseIsSetup",redirectPath: "/setup",allowRedirectBack: false,diff --git a/frontend/src/metabase/selectors/settings.ts b/frontend/src/metabase/selectors/settings.tsindex abc8a504a11..1f742215486 100644--- a/frontend/src/metabase/selectors/settings.ts+++ b/frontend/src/metabase/selectors/settings.ts@@ -63,7 +63,7 @@ export const migrateToCloudGuideUrl = () =>"https://www.metabase.com/cloud/docs/migrate/guide";export const getLearnUrl = (path = "") => {- // eslint-disable-next-line no-unconditional-metabase-links-render -- This is the implementation of getLearnUrl()+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This is the implementation of getLearnUrl()return `https://www.metabase.com/learn/${path}`;};@@ -159,7 +159,7 @@ export const getDocsUrlForVersion = (anchor = `#${anchor}`;}- // eslint-disable-next-line no-unconditional-metabase-links-render -- This function is only used by this file and "metabase/lib/settings"+ // eslint-disable-next-line metabase/no-unconditional-metabase-links-render -- This function is only used by this file and "metabase/lib/settings"return `https://www.metabase.com/docs/${tag}/${page}${anchor}`;};diff --git a/frontend/src/metabase/static-viz/components/FunnelChart/FunnelChart.tsx b/frontend/src/metabase/static-viz/components/FunnelChart/FunnelChart.tsxindex 5589c1d267b..e3d39cbe7f2 100644--- a/frontend/src/metabase/static-viz/components/FunnelChart/FunnelChart.tsx+++ b/frontend/src/metabase/static-viz/components/FunnelChart/FunnelChart.tsx@@ -31,11 +31,11 @@ const layout = {nameFontSize: 16,stepTextOffset: 8,colors: {- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalstextMedium: "#949aab",- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsbrand: "#509ee3",- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsborder: "#f0f0f0",},paddingLeft: 10,diff --git a/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx b/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsxindex ab1b2d5bef2..4869265573e 100644--- a/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx+++ b/frontend/src/metabase/static-viz/components/ProgressBar/ProgressBar.tsx@@ -140,7 +140,7 @@ export const ProgressBar = ({<><CheckMarkIconsize={layout.iconSize}- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalscolor="#ffffff"x={10}y={(layout.barHeight - layout.iconSize) / 2}@@ -151,7 +151,7 @@ export const ProgressBar = ({x={layout.iconSize + 16}y={layout.barHeight / 2}verticalAnchor="middle"- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsfill="#ffffff">{barMessage}diff --git a/frontend/src/metabase/static-viz/components/Text/Text.tsx b/frontend/src/metabase/static-viz/components/Text/Text.tsxindex 54205dadf13..d410575a314 100644--- a/frontend/src/metabase/static-viz/components/Text/Text.tsx+++ b/frontend/src/metabase/static-viz/components/Text/Text.tsx@@ -8,6 +8,6 @@ type Props = Omit<TextProps, "color"> & {};export const Text = (props: Props) => {- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsreturn <VText fontFamily="Lato" fontSize="13" fill="#4C5773" {...props} />;};diff --git a/frontend/src/metabase/ui/theme.ts b/frontend/src/metabase/ui/theme.tsindex 46ae9081811..5a56bc475fe 100644--- a/frontend/src/metabase/ui/theme.ts+++ b/frontend/src/metabase/ui/theme.ts@@ -84,9 +84,9 @@ export const getThemeOverrides = (colorScheme,},shadows: {- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalssm: "0px 1px 4px 2px rgba(0, 0, 0, 0.08)",- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsmd: "0px 4px 20px 0px rgba(0, 0, 0, 0.05)",},spacing: {diff --git a/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx b/frontend/src/metabase/visualizations/components/ChoroplethMap.jsxindex 83aaad8da4d..dfadaa1fbe0 100644--- a/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx+++ b/frontend/src/metabase/visualizations/components/ChoroplethMap.jsx@@ -33,9 +33,9 @@ import LeafletChoropleth from "./LeafletChoropleth";import LegacyChoropleth from "./LegacyChoropleth";// TODO COLOR-// eslint-disable-next-line no-color-literals+// eslint-disable-next-line metabase/no-color-literalsconst HEAT_MAP_COLORS = ["#C4E4FF", "#81C5FF", "#51AEFF", "#1E96FF", "#0061B5"];-// eslint-disable-next-line no-color-literals+// eslint-disable-next-line metabase/no-color-literalsconst HEAT_MAP_ZERO_COLOR = "#CCC";export function getColorplethColorScale(diff --git a/frontend/src/metabase/visualizations/components/skeletons/ScalarSkeleton/ScalarSkeleton.styled.tsx b/frontend/src/metabase/visualizations/components/skeletons/ScalarSkeleton/ScalarSkeleton.styled.tsxindex 4eb13d634e9..dc6e77512ba 100644--- a/frontend/src/metabase/visualizations/components/skeletons/ScalarSkeleton/ScalarSkeleton.styled.tsx+++ b/frontend/src/metabase/visualizations/components/skeletons/ScalarSkeleton/ScalarSkeleton.styled.tsx@@ -5,7 +5,7 @@ import { VisualizationRoot } from "metabase/visualizations/components/Visualizatimport { animationStyles } from "metabase/visualizations/components/skeletons/ChartSkeleton/ChartSkeleton.styled";import SkeletonCaption from "metabase/visualizations/components/skeletons/SkeletonCaption";-// eslint-disable-next-line no-color-literals+// eslint-disable-next-line metabase/no-color-literalsexport const PositionedActionMenu = styled.div`position: absolute;top: 0.3125rem;diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/option.ts b/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/option.tsindex 4744e1a7f22..85eb06174d2 100644--- a/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/option.ts+++ b/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/option.ts@@ -114,7 +114,7 @@ export const getTimelineEventsSeries = (symbol: "none",lineStyle: {type: "solid",- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalscolor: "rgba(105, 110, 123, 0.2)",width: 2,},diff --git a/frontend/src/metabase/visualizations/echarts/graph/sankey/constants/style.ts b/frontend/src/metabase/visualizations/echarts/graph/sankey/constants/style.tsindex e1b54518121..3504d5718d4 100644--- a/frontend/src/metabase/visualizations/echarts/graph/sankey/constants/style.ts+++ b/frontend/src/metabase/visualizations/echarts/graph/sankey/constants/style.ts@@ -15,7 +15,7 @@ export const SANKEY_CHART_STYLE = {minPadding: 24,},edgeColor: {- // eslint-disable-next-line no-color-literals+ // eslint-disable-next-line metabase/no-color-literalsgray: "#81898e", // --mb-base-color-orion-50},};diff --git a/frontend/test/.eslintrc b/frontend/test/.eslintrcindex 1da8da0f1d3..a28dadaed97 100644--- a/frontend/test/.eslintrc+++ b/frontend/test/.eslintrc@@ -1,7 +1,7 @@{"rules": {"import/no-commonjs": 0,- "no-color-literals": 0+ "metabase/no-color-literals": 0},"env": {"node": truediff --git a/frontend/test/__support__/server-mocks/store.ts b/frontend/test/__support__/server-mocks/store.tsindex 3ab579d9a48..78fa583f07d 100644--- a/frontend/test/__support__/server-mocks/store.ts+++ b/frontend/test/__support__/server-mocks/store.ts@@ -49,7 +49,7 @@ export function setupStoreEETieredMetabotAI(status: 403,})).with("error-no-connection", () => ({- // eslint-disable-next-line no-literal-metabase-strings -- Used for fetch mock only+ // eslint-disable-next-line metabase/no-literal-metabase-strings -- Used for fetch mock onlybody: "Could not establish a connection to Metabase Cloud.",status: 404,}))diff --git a/lint-staged.config.cjs b/lint-staged.config.cjsindex ad8d41a53de..fb1ad3cfe5d 100644--- a/lint-staged.config.cjs+++ b/lint-staged.config.cjs@@ -7,12 +7,12 @@ module.exports = {"prettier --write",],"+(frontend|enterprise/frontend)/**/*.{js,jsx,ts,tsx}": [- "cross-env LINT_CSS_MODULES=true eslint --rulesdir frontend/lint/eslint-rules --max-warnings 0 --fix",+ "cross-env LINT_CSS_MODULES=true eslint --max-warnings 0 --fix","prettier --write","node ./bin/verify-doc-links",],"e2e/**/*.{js,jsx,ts,jsx}": [- "eslint --rulesdir frontend/lint/eslint-rules --max-warnings 0 --fix",+ "eslint --max-warnings 0 --fix","prettier --write",],"**/*.{clj,cljc,cljs,bb}": [diff --git a/package.json b/package.jsonindex fb6295ab79c..89bb9fac45b 100644--- a/package.json+++ b/package.json@@ -271,6 +271,7 @@"eslint-plugin-jest": "^27.2.0","eslint-plugin-jest-dom": "^5.4.0","eslint-plugin-jest-formatting": "^3.1.0",+ "eslint-plugin-metabase": "file:./frontend/lint/eslint-rules","eslint-plugin-no-only-tests": "^2.4.0","eslint-plugin-postcss-modules": "^2.0.0","eslint-plugin-react": "^7.32.2",@@ -455,7 +456,7 @@"lint-docs-links": "yarn && ./bin/verify-doc-links","lint-css": "stylelint './frontend/**/*.css'","lint-eslint": "yarn build:cljs && yarn lint-eslint-pure",- "lint-eslint-pure": "eslint --cache --cache-strategy content --ext .js,.jsx,.ts,.tsx --rulesdir frontend/lint/eslint-rules --max-warnings 0 --report-unused-disable-directives enterprise/frontend frontend e2e",+ "lint-eslint-pure": "eslint --cache --cache-strategy content --ext .js,.jsx,.ts,.tsx --max-warnings 0 --report-unused-disable-directives enterprise/frontend frontend e2e","lint-prettier": "yarn && yarn lint-prettier-pure","lint-prettier-pure": "prettier --check --cache '{frontend,enterprise/frontend,e2e}/**/*.{js,jsx,ts,tsx,css}'","lint-yaml": "yamllint **/*.{yaml,yml} --ignore=node_modules/**/*.{yaml,yml}",diff --git a/yarn.lock b/yarn.lockindex 309ab5e98a1..f41dede67a6 100644--- a/yarn.lock+++ b/yarn.lock@@ -10816,6 +10816,9 @@ eslint-plugin-jest@^27.2.0:dependencies:"@typescript-eslint/utils" "^5.10.0"+"eslint-plugin-metabase@file:./frontend/lint/eslint-rules":+ version "1.0.0"+eslint-plugin-no-only-tests@^2.4.0:version "2.4.0"resolved "https://registry.yarnpkg.com/eslint-plugin-no-only-tests/-/eslint-plugin-no-only-tests-2.4.0.tgz#7d565434aa7d16ccc7eea957c391d98f827332ca"