Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Deprecate isEEBuild helper (#68848)

Timofey Kachalov7b921d8f43ed
diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx
index 2929304d352..39e3eb5ae44 100644
--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx
+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx
@@ -77,7 +77,7 @@ export const EmbedHomepage = () => {
}
};
- const variant = isEEBuild() ? "ee" : "oss/starter";
+ const variant = isEEBuild() ? "ee" : "oss";
return (
<>
diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx
index 6175aacdf92..6f4a01090c4 100644
--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx
+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx
@@ -13,7 +13,7 @@ import { StaticEmbedContent } from "./StaticEmbedContent";
export type EmbedHomepageViewProps = {
exampleDashboardId: number | null;
- variant: "oss/starter" | "ee";
+ variant: "oss" | "ee";
hasEmbeddingFeature: boolean;
onDismiss: (reason: EmbeddingHomepageDismissReason) => void;
// links
@@ -45,7 +45,7 @@ export const EmbedHomepageView = (props: EmbedHomepageViewProps) => {
: undefined;
const content = match(variant)
- .with("oss/starter", () => {
+ .with("oss", () => {
return (
<>
<StaticEmbedContent
@@ -116,7 +116,7 @@ export const EmbedHomepageView = (props: EmbedHomepageViewProps) => {
/>
</Stack>
- {variant === "oss/starter" && (
+ {variant === "oss" && (
<Box mt="2.5rem">
<UpsellEmbedHomepage location="embedding-homepage" />
</Box>
diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx
index 197586283a8..4b44205b4e9 100644
--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx
+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx
@@ -11,7 +11,7 @@ type EmbedJsContentProps = {
embedJsDocsUrl: string;
showImage?: boolean;
hasEmbeddingFeature?: boolean;
- variant: "oss/starter" | "ee";
+ variant: "oss" | "ee";
};
export const EmbedJsContent = ({
diff --git a/frontend/src/metabase/lib/utils.ts b/frontend/src/metabase/lib/utils.ts
index 736fbdb09ae..03e65c2fd05 100644
--- a/frontend/src/metabase/lib/utils.ts
+++ b/frontend/src/metabase/lib/utils.ts
@@ -161,6 +161,12 @@ export function versionIsLatest({
return result != null && result >= 0;
}
+/**
+ * @deprecated
+ * In most cases we want to use specific token features, not the type of build.
+ * Use only we want to display something differently based on specifically the build,
+ * ie: "Switch binary" vs "Put a valid token in the settings"
+ */
export const isEEBuild = () => PLUGIN_IS_EE_BUILD.isEEBuild();
// Extract resource id from signed JWT token used in Static Embedding