Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix input styles in chart visualization settings (#76308)

Anderson7be4c69df78b
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
index 93d7735f024..804ac64ab70 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
@@ -126,6 +126,7 @@ export const ChartSettingFieldPicker = ({
align="center"
>
<ChartSettingSelect
+ variant="unstyled"
pl={hasLeftSection ? "sm" : 0}
w="100%"
defaultDropdownOpened={autoOpenWhenUnset && value === undefined}
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.module.css b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.module.css
index 0b30059eae9..d6628798e71 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.module.css
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.module.css
@@ -7,15 +7,14 @@
.wrapper {
margin-top: 0;
-}
-.section {
- background-color: unset;
- z-index: initial;
+ .section {
+ background-color: unset;
+ z-index: initial;
+ }
}
.input {
- border: none;
color: var(--mb-color-text-primary);
cursor: pointer;
font-weight: bold;
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
index 3d39da23a8b..d1fa5ca5540 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
@@ -27,6 +27,7 @@ type ChartSettingSelectProps = Pick<
| "pl"
| "pr"
| "rightSection"
+ | "variant"
| "w"
> & {
footer?: ReactNode;
@@ -63,6 +64,7 @@ export const ChartSettingSelect = ({
rightSectionWidth,
searchProp,
value = null,
+ variant,
w,
}: ChartSettingSelectProps) => {
const disabled =
@@ -130,6 +132,7 @@ export const ChartSettingSelect = ({
defaultDropdownOpened={defaultDropdownOpened}
pl={pl}
pr={pr}
+ variant={variant}
w={w}
/>
);