Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove cypress-each (#81086)

Andrei Chernykh7c08b5d95c91
diff --git a/bun.lock b/bun.lock
index c2a02090796..8957ca2bc69 100644
--- a/bun.lock
+++ b/bun.lock
@@ -83,7 +83,6 @@
"cronstrue": "^2.11.0",
"csv-parse": "^5.5.6",
"csv-stringify": "^6.5.0",
- "cypress-each": "^1.14.1",
"d3": "^7.9.0",
"d3-scale": "^4.0.2",
"dayjs": "^1.11.18",
@@ -2708,8 +2707,6 @@
"cypress": ["[email protected]", "", { "dependencies": { "@cypress/request": "^3.0.10", "@cypress/xvfb": "^1.2.4", "@types/sinonjs__fake-timers": "8.1.1", "@types/sizzle": "^2.3.2", "@types/tmp": "^0.2.3", "arch": "^2.2.0", "blob-util": "^2.0.2", "bluebird": "^3.7.2", "buffer": "^5.7.1", "cachedir": "^2.3.0", "chalk": "^4.1.0", "ci-info": "^4.1.0", "cli-cursor": "^3.1.0", "cli-table3": "0.6.1", "commander": "^6.2.1", "common-tags": "^1.8.0", "dayjs": "^1.10.4", "debug": "^4.3.4", "enquirer": "^2.3.6", "eventemitter2": "6.4.7", "execa": "4.1.0", "executable": "^4.1.1", "extract-zip": "2.0.1", "figures": "^3.2.0", "fs-extra": "^9.1.0", "hasha": "5.2.2", "is-installed-globally": "~0.4.0", "listr2": "^3.8.3", "lodash": "^4.17.23", "log-symbols": "^4.0.0", "minimist": "^1.2.8", "ospath": "^1.2.2", "pretty-bytes": "^5.6.0", "process": "^0.11.10", "proxy-from-env": "1.0.0", "request-progress": "^3.0.0", "supports-color": "^8.1.1", "systeminformation": "^5.31.1", "tmp": "~0.2.4", "tree-kill": "1.2.2", "tslib": "1.14.1", "untildify": "^4.0.0", "yauzl": "^2.10.0" }, "bin": { "cypress": "bin/cypress" } }, "sha512-AkuiHNSnmm0a+h/horcvbjmY6dWpCe1Ebp1R0LjMP5I6pjMaNA50Mw1YP/d07pLHJ/sV8FZoGecUWFCJ/Nifpw=="],
- "cypress-each": ["[email protected]", "", { "dependencies": { "format-util": "^1.0.5" } }, "sha512-evywTv0Gid5J24C2W6ajYsVoBpoXIkvNo6L5a5+6QabtKOG1pn9Fq4zO/EwrdfktDZ9PWRRWFbJBMoRh3NlrYg=="],
-
"cypress-iframe": ["[email protected]", "", {}, "sha512-Ne+xkZmWMhfq3x6wbfzK/SzsVTCrJru3R3cLXsoSAZyfUtJDamXyaIieHXeea3pQDXF4wE2w4iUuvCYHhoD31g=="],
"cypress-multi-reporters": ["[email protected]", "", { "dependencies": { "debug": "^4.4.0", "lodash": "^4.17.21", "semver": "^7.6.3" }, "peerDependencies": { "mocha": ">=3.1.2" } }, "sha512-5ReXlNE7C/9/rpDI3z0tAJbPXsTHK7P3ogvUtBntQlmctRQ+sSMts7dIQY5MTb0XfBSge3CuwvNvaoqtw90KSQ=="],
@@ -3212,8 +3209,6 @@
"form-data": ["[email protected]", "", { "dependencies": { "asynckit": "^0.4.0", "combined-stream": "^1.0.8", "es-set-tostringtag": "^2.1.0", "hasown": "^2.0.4", "mime-types": "^2.1.35" } }, "sha512-vKatAh4SlVfgbv+YtmhiRjhEMJsYpsG1Y2rMQtR+SVSbytsSD1YGzDIcrAJmdFec88u/+VoGmxnl+80gL1tRCQ=="],
- "format-util": ["[email protected]", "", {}, "sha512-varLbTj0e0yVyRpqQhuWV+8hlePAgaoFRhNFj50BNjEIrw1/DphHSObtqwskVCPWNgzwPoQrZAbfa/SBiicNeg=="],
-
"formik": ["[email protected]", "", { "dependencies": { "@types/hoist-non-react-statics": "^3.3.1", "deepmerge": "^2.1.1", "hoist-non-react-statics": "^3.3.0", "lodash": "^4.17.21", "lodash-es": "^4.17.21", "react-fast-compare": "^2.0.1", "tiny-warning": "^1.0.2", "tslib": "^2.0.0" } }, "sha512-A+2EI7U7aG296q2TLGvNapDNTZp1khVt5Vk0Q/fyfSROss0V/V6+txt2aJnwEos44IxTCW/LYAi/zgWzlevj+g=="],
"forwarded": ["[email protected]", "", {}, "sha512-buRG0fpBtRHSTCOASe6hD258tEubFoRLb4ZNA6NxMVHNw2gOcwHo9wyablzMzOA5z9xA9L1KNjk/Nt6MT9aYow=="],
diff --git a/e2e/support/index.ts b/e2e/support/index.ts
index 47ef1db7635..028a5310432 100644
--- a/e2e/support/index.ts
+++ b/e2e/support/index.ts
@@ -1,8 +1,6 @@
// H is for helpers πŸ€—
import * as H from "./helpers";
-import "cypress-each";
-
type HelperTypes = typeof H;
declare global {
diff --git a/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts b/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts
index 20947db3c0c..d3cb14029c3 100644
--- a/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts
+++ b/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts
@@ -24,720 +24,727 @@ const MYSQL_DB_ID = SAMPLE_DB_ID + 1;
const MYSQL_DB_SCHEMA_ID = `${MYSQL_DB_ID}:`;
const areas: ("admin" | "data studio")[] = ["admin", "data studio"];
-type Area = (typeof areas)[number];
-describe.each<Area>(areas)("data model > %s", (area: Area) => {
- const getBasePath = getBasePathForArea(area);
- const visit = visitArea(area);
- const checkLocation = getCheckLocation(area);
+areas.forEach((area) => {
+ describe(`data model > ${area}`, () => {
+ const getBasePath = getBasePathForArea(area);
+ const visit = visitArea(area);
+ const checkLocation = getCheckLocation(area);
- beforeEach(() => {
- H.restore();
- H.resetSnowplow();
- cy.signInAsAdmin();
- H.activateToken("pro-self-hosted");
+ beforeEach(() => {
+ H.restore();
+ H.resetSnowplow();
+ cy.signInAsAdmin();
+ H.activateToken("pro-self-hosted");
- getInterceptsForArea(area);
- });
-
- describe("Data loading", () => {
- it("should show 404 if database does not exist (metabase#14652)", () => {
- visit({ databaseId: 54321, skipWaiting: true });
- cy.wait("@databases");
- cy.wait(100); // wait with assertions for React effects to kick in
-
- TablePicker.getDatabases().should("have.length", 1);
- TablePicker.getTables().should("have.length", 0);
- H.DataModel.get().findByText("Not found.").should("be.visible");
- checkLocation("/database/54321");
+ getInterceptsForArea(area);
});
- it("should show 404 if table does not exist", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: 12345,
- skipWaiting: true,
+ describe("Data loading", () => {
+ it("should show 404 if database does not exist (metabase#14652)", () => {
+ visit({ databaseId: 54321, skipWaiting: true });
+ cy.wait("@databases");
+ cy.wait(100); // wait with assertions for React effects to kick in
+
+ TablePicker.getDatabases().should("have.length", 1);
+ TablePicker.getTables().should("have.length", 0);
+ H.DataModel.get().findByText("Not found.").should("be.visible");
+ checkLocation("/database/54321");
});
- cy.wait("@databases");
- cy.wait(100); // wait with assertions for React effects to kick in
-
- TablePicker.getDatabases().should("have.length", 1);
- TablePicker.getTables().should("have.length", 8);
- H.DataModel.get().findByText("Not found.").should("be.visible");
- checkLocation(
- `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/12345`,
- );
- if (area === "admin") {
- verifyAdminTableSectionEmptyState();
- }
- });
- it(
- "should show 404 if field does not exist",
- // We eliminate the flakiness by removing the need to scroll horizontally
- { viewportWidth: 1600 },
- () => {
+ it("should show 404 if table does not exist", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: 12345, // we're force navigating to a fake field id
+ tableId: 12345,
skipWaiting: true,
});
- if (area === "admin") {
- cy.wait("@databases");
- cy.wait(100); // wait with assertions for React effects to kick in
- } else {
- cy.wait(["@datamodel/visit/databases", "@datamodel/visit/metadata"]);
- }
+ cy.wait("@databases");
+ cy.wait(100); // wait with assertions for React effects to kick in
TablePicker.getDatabases().should("have.length", 1);
TablePicker.getTables().should("have.length", 8);
+ H.DataModel.get().findByText("Not found.").should("be.visible");
checkLocation(
- `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}/field/12345`,
+ `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/12345`,
);
-
- if (area === "data studio") {
- H.DataModel.get().within(() => {
- cy.findByText("Field details").should("be.visible");
- cy.findByText("Not found.").should("be.visible");
- });
+ if (area === "admin") {
+ verifyAdminTableSectionEmptyState();
}
- },
- );
-
- it(
- "should not show 404 error if database is not selected",
- { tags: ["@external"] },
- () => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "multi_schema" });
- H.resyncDatabase({ dbId: WRITABLE_DB_ID });
-
- cy.log("database not selected");
- visit();
- H.DataModel.get()
- .findByText(/Not found/)
- .should("not.exist");
-
- cy.log("database selected");
- TablePicker.getDatabase("Writable Postgres12").click();
- H.DataModel.get()
- .findByText(/Not found/)
- .should("not.exist");
-
- cy.log("schema selected");
- TablePicker.getSchema("Domestic").click();
- H.DataModel.get()
- .findByText(/Not found/)
- .should("not.exist");
-
- cy.log("table selected");
- TablePicker.getTable("Animals").click();
- H.DataModel.get()
- .findByText(/Not found/)
- .should("not.exist");
- },
- );
- });
-
- describe("Table picker", () => {
- describe("No databases", () => {
- beforeEach(() => {
- cy.request("DELETE", `/api/database/${SAMPLE_DB_ID}`);
});
- it("should allow to navigate databases, schemas, and tables", () => {
- visit();
-
- cy.get("main")
- .findByText("No connected databases")
- .should("be.visible");
+ it(
+ "should show 404 if field does not exist",
+ // We eliminate the flakiness by removing the need to scroll horizontally
+ { viewportWidth: 1600 },
+ () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: 12345, // we're force navigating to a fake field id
+ skipWaiting: true,
+ });
+ if (area === "admin") {
+ cy.wait("@databases");
+ cy.wait(100); // wait with assertions for React effects to kick in
+ } else {
+ cy.wait([
+ "@datamodel/visit/databases",
+ "@datamodel/visit/metadata",
+ ]);
+ }
- cy.findByRole("link", { name: "Connect a database" })
- .should("be.visible")
- .click();
+ TablePicker.getDatabases().should("have.length", 1);
+ TablePicker.getTables().should("have.length", 8);
+ checkLocation(
+ `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}/field/12345`,
+ );
- cy.location("pathname").should("eq", "/admin/databases/create");
- cy.findByRole("heading", { name: "Add a database" }).should(
- "be.visible",
- );
- });
- });
+ if (area === "data studio") {
+ H.DataModel.get().within(() => {
+ cy.findByText("Field details").should("be.visible");
+ cy.findByText("Not found.").should("be.visible");
+ });
+ }
+ },
+ );
- describe("1 database, no schemas", () => {
- it("should allow to navigate tables", { tags: ["@external"] }, () => {
- H.restore("mysql-8");
- cy.signInAsAdmin();
+ it(
+ "should not show 404 error if database is not selected",
+ { tags: ["@external"] },
+ () => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "multi_schema" });
+ H.resyncDatabase({ dbId: WRITABLE_DB_ID });
- visit();
+ cy.log("database not selected");
+ visit();
+ H.DataModel.get()
+ .findByText(/Not found/)
+ .should("not.exist");
- TablePicker.getDatabase("QA MySQL8").click();
- TablePicker.getTables().should("have.length", 4);
- TablePicker.getSchemas().should("have.length", 0);
+ cy.log("database selected");
+ TablePicker.getDatabase("Writable Postgres12").click();
+ H.DataModel.get()
+ .findByText(/Not found/)
+ .should("not.exist");
- cy.location("pathname").should(
- "eq",
- `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
- );
+ cy.log("schema selected");
+ TablePicker.getSchema("Domestic").click();
+ H.DataModel.get()
+ .findByText(/Not found/)
+ .should("not.exist");
- TablePicker.getTable("Products").click();
- TableSection.getNameInput().should("have.value", "Products");
+ cy.log("table selected");
+ TablePicker.getTable("Animals").click();
+ H.DataModel.get()
+ .findByText(/Not found/)
+ .should("not.exist");
+ },
+ );
+ });
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}/table/`,
- );
+ describe("Table picker", () => {
+ describe("No databases", () => {
+ beforeEach(() => {
+ cy.request("DELETE", `/api/database/${SAMPLE_DB_ID}`);
});
- });
- it("should allow searching for tables", { tags: ["@external"] }, () => {
- H.restore("mysql-8");
- visit();
+ it("should allow to navigate databases, schemas, and tables", () => {
+ visit();
- TablePicker.getSearchInput().type("rEvIeWs");
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getDatabase("QA MySQL8").should("be.visible");
- TablePicker.getDatabase("Sample Database").should("be.visible");
- TablePicker.getTables().should("have.length", 2);
+ cy.get("main")
+ .findByText("No connected databases")
+ .should("be.visible");
- TablePicker.getTables().eq(0).click();
- TableSection.getNameInput().should("have.value", "Reviews");
- if (area === "admin") {
- verifyFieldSectionEmptyState();
- }
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}/table/`,
+ cy.findByRole("link", { name: "Connect a database" })
+ .should("be.visible")
+ .click();
+
+ cy.location("pathname").should("eq", "/admin/databases/create");
+ cy.findByRole("heading", { name: "Add a database" }).should(
+ "be.visible",
);
});
});
- it("should restore previously selected table when expanding the tree", () => {
- H.restore("mysql-8");
- cy.signInAsAdmin();
+ describe("1 database, no schemas", () => {
+ it("should allow to navigate tables", { tags: ["@external"] }, () => {
+ H.restore("mysql-8");
+ cy.signInAsAdmin();
- visit({
- databaseId: MYSQL_DB_ID,
- schemaId: MYSQL_DB_SCHEMA_ID,
- });
+ visit();
- TablePicker.getDatabase("QA MySQL8").click();
- cy.location("pathname").should(
- "eq",
- `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
- );
+ TablePicker.getDatabase("QA MySQL8").click();
+ TablePicker.getTables().should("have.length", 4);
+ TablePicker.getSchemas().should("have.length", 0);
- TablePicker.getDatabase("QA MySQL8").click();
- cy.location("pathname").should(
- "eq",
- `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
- );
+ cy.location("pathname").should(
+ "eq",
+ `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
+ );
- cy.log("ensure navigation to another db works");
- TablePicker.getDatabase("Sample Database").click();
- TablePicker.getTables().should("have.length", 12);
- });
- });
+ TablePicker.getTable("Products").click();
+ TableSection.getNameInput().should("have.value", "Products");
- describe("1 database, 1 schema", () => {
- it("should allow to navigate databases, schemas, and tables", () => {
- visit();
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}/table/`,
+ );
+ });
+ });
- cy.log("should auto-open the only schema in the only database");
- checkLocation(
- `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}`,
- );
+ it("should allow searching for tables", { tags: ["@external"] }, () => {
+ H.restore("mysql-8");
+ visit();
- TablePicker.getDatabases().should("have.length", 1);
- TablePicker.getDatabase("Sample Database").should("be.visible");
- TablePicker.getSchemas().should("have.length", 0);
- TablePicker.getTables().should("have.length", 8);
- TableSection.get().should("not.exist");
- TablePicker.getTable("Orders").should("be.visible").click();
+ TablePicker.getSearchInput().type("rEvIeWs");
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getDatabase("QA MySQL8").should("be.visible");
+ TablePicker.getDatabase("Sample Database").should("be.visible");
+ TablePicker.getTables().should("have.length", 2);
- checkLocation(
- `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}`,
- );
- TableSection.get().should("be.visible");
- if (area === "admin") {
- verifyFieldSectionEmptyState();
- }
+ TablePicker.getTables().eq(0).click();
+ TableSection.getNameInput().should("have.value", "Reviews");
+ if (area === "admin") {
+ verifyFieldSectionEmptyState();
+ }
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}/table/`,
+ );
+ });
+ });
- TablePicker.getTable("Products").should("be.visible").click();
- checkLocation(
- `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${PRODUCTS_ID}`,
- );
+ it("should restore previously selected table when expanding the tree", () => {
+ H.restore("mysql-8");
+ cy.signInAsAdmin();
- TableSection.get().should("be.visible");
- if (area === "admin") {
- verifyFieldSectionEmptyState();
- }
- });
- });
+ visit({
+ databaseId: MYSQL_DB_ID,
+ schemaId: MYSQL_DB_SCHEMA_ID,
+ });
- describe(
- "mutliple databases, with single and multiple schemas",
- { tags: "@external" },
- () => {
- beforeEach(() => {
- H.restore("postgres-writable");
- H.activateToken("pro-self-hosted");
+ TablePicker.getDatabase("QA MySQL8").click();
+ cy.location("pathname").should(
+ "eq",
+ `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
+ );
- H.resetTestTable({ type: "postgres", table: "multi_schema" });
- H.resyncDatabase({ dbId: WRITABLE_DB_ID });
+ TablePicker.getDatabase("QA MySQL8").click();
+ cy.location("pathname").should(
+ "eq",
+ `${getBasePath()}/database/${MYSQL_DB_ID}/schema/${MYSQL_DB_SCHEMA_ID}`,
+ );
+
+ cy.log("ensure navigation to another db works");
+ TablePicker.getDatabase("Sample Database").click();
+ TablePicker.getTables().should("have.length", 12);
});
+ });
+ describe("1 database, 1 schema", () => {
it("should allow to navigate databases, schemas, and tables", () => {
visit();
- if (area === "admin") {
- checkLocation("/database");
- } else {
- checkLocation("");
- }
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 0);
- TablePicker.getTables().should("have.length", 0);
- TablePicker.getDatabase("Sample Database").should("be.visible");
-
- cy.log("open database");
- TablePicker.getDatabase("Writable Postgres12")
- .should("be.visible")
- .click();
- checkLocation(`/database/${WRITABLE_DB_ID}`);
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 2);
- TablePicker.getTables().should("have.length", 0);
- TablePicker.getSchema("Wild").should("be.visible");
- TablePicker.getSchema("Domestic").should("be.visible");
-
- cy.log("open schema");
- TablePicker.getSchema("Domestic").click();
+ cy.log("should auto-open the only schema in the only database");
checkLocation(
- `/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic`,
+ `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}`,
);
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 2);
- TablePicker.getTables().should("have.length", 1);
- TablePicker.getTable("Animals").should("be.visible");
- cy.log("open table");
- TablePicker.getTable("Animals").click();
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
- );
- });
- TableSection.getNameInput().should("have.value", "Animals");
+ TablePicker.getDatabases().should("have.length", 1);
+ TablePicker.getDatabase("Sample Database").should("be.visible");
+ TablePicker.getSchemas().should("have.length", 0);
+ TablePicker.getTables().should("have.length", 8);
+ TableSection.get().should("not.exist");
+ TablePicker.getTable("Orders").should("be.visible").click();
- cy.log("open another schema");
- TablePicker.getSchema("Wild").click();
- cy.log(
- "should not update URL to point to schema as we have a table open",
+ checkLocation(
+ `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}`,
);
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
- );
- });
-
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 2);
- TablePicker.getTables().should("have.length", 3);
- TablePicker.getTable("Birds").should("be.visible");
-
- cy.log("open another table");
- TablePicker.getTable("Birds").click();
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
- );
- });
- TableSection.getNameInput().should("have.value", "Birds");
-
- cy.log("close schema");
+ TableSection.get().should("be.visible");
if (area === "admin") {
- TablePicker.getSchema("Wild").click();
- }
- if (area === "data studio") {
- TablePicker.getSchema("Wild").within(() => {
- cy.findByRole("button", { name: "Collapse" }).click();
- });
+ verifyFieldSectionEmptyState();
}
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 2);
- TablePicker.getTables().should("have.length", 1);
- TablePicker.getTable("Birds").should("not.exist");
+ TablePicker.getTable("Products").should("be.visible").click();
+ checkLocation(
+ `/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${PRODUCTS_ID}`,
+ );
- cy.log("close database");
+ TableSection.get().should("be.visible");
if (area === "admin") {
- TablePicker.getDatabase("Writable Postgres12").click();
+ verifyFieldSectionEmptyState();
}
- if (area === "data studio") {
- TablePicker.getDatabase("Writable Postgres12").within(() => {
- cy.findByRole("button", { name: "Collapse" }).click();
- });
- }
- TablePicker.getDatabases().should("have.length", 2);
- TablePicker.getSchemas().should("have.length", 0);
- TablePicker.getTables().should("have.length", 0);
+ });
+ });
- cy.log("we still have a table opened");
- cy.location("pathname").should((pathname) => {
- return pathname.startsWith(
- `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
- );
+ describe(
+ "mutliple databases, with single and multiple schemas",
+ { tags: "@external" },
+ () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.activateToken("pro-self-hosted");
+
+ H.resetTestTable({ type: "postgres", table: "multi_schema" });
+ H.resyncDatabase({ dbId: WRITABLE_DB_ID });
});
- if (area === "admin") {
- cy.log("databases, schemas, and tables should be links");
- TablePicker.getDatabase("Sample Database").click();
- TablePicker.getDatabase("Writable Postgres12").click();
- TablePicker.getDatabase("Writable Postgres12")
- .should("have.prop", "tagName", "A")
- .and(
- "have.attr",
- "href",
- `/admin/datamodel/database/${WRITABLE_DB_ID}`,
- );
- TablePicker.getSchema("Domestic")
- .should("have.prop", "tagName", "A")
- .and(
- "have.attr",
- "href",
- `/admin/datamodel/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic`,
- );
- TablePicker.getTable("Orders")
- .should("have.prop", "tagName", "A")
- .and(
- "have.attr",
- "href",
- `/admin/datamodel/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}`,
- );
- }
- });
- },
- );
- });
+ it("should allow to navigate databases, schemas, and tables", () => {
+ visit();
+ if (area === "admin") {
+ checkLocation("/database");
+ } else {
+ checkLocation("");
+ }
- describe("Table section", () => {
- it("should show all tables in sample database and fields in orders table", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- });
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 0);
+ TablePicker.getTables().should("have.length", 0);
+ TablePicker.getDatabase("Sample Database").should("be.visible");
- TablePicker.getTables().should("have.length", 8);
-
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("ID");
-
- if (area === "data studio") {
- // Sometimes in CI this doesn't happen
- FieldSection.get().scrollIntoView();
- }
-
- FieldSection.getDataType()
- .should("be.visible")
- .and("have.text", "BIGINT");
- FieldSection.getSemanticTypeInput().should("have.value", "Entity Key");
-
- TableSection.clickField("User ID");
- FieldSection.getDataType()
- .should("be.visible")
- .and("have.text", "INTEGER");
- FieldSection.getSemanticTypeInput().should("have.value", "Foreign Key");
- FieldSection.getSemanticTypeFkTarget().should(
- "have.value",
- "People β†’ ID",
- );
+ cy.log("open database");
+ TablePicker.getDatabase("Writable Postgres12")
+ .should("be.visible")
+ .click();
+ checkLocation(`/database/${WRITABLE_DB_ID}`);
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 2);
+ TablePicker.getTables().should("have.length", 0);
+ TablePicker.getSchema("Wild").should("be.visible");
+ TablePicker.getSchema("Domestic").should("be.visible");
+
+ cy.log("open schema");
+ TablePicker.getSchema("Domestic").click();
+ checkLocation(
+ `/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic`,
+ );
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 2);
+ TablePicker.getTables().should("have.length", 1);
+ TablePicker.getTable("Animals").should("be.visible");
+
+ cy.log("open table");
+ TablePicker.getTable("Animals").click();
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
+ );
+ });
+ TableSection.getNameInput().should("have.value", "Animals");
- TableSection.clickField("Tax");
- FieldSection.getDataType()
- .should("be.visible")
- .and("have.text", "DOUBLE PRECISION");
- FieldSection.getSemanticTypeInput().should(
- "have.value",
- "No semantic type",
- );
+ cy.log("open another schema");
+ TablePicker.getSchema("Wild").click();
+ cy.log(
+ "should not update URL to point to schema as we have a table open",
+ );
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
+ );
+ });
- TableSection.clickField("Discount");
- FieldSection.getDataType()
- .should("be.visible")
- .and("have.text", "DOUBLE PRECISION");
- FieldSection.getSemanticTypeInput().should("have.value", "Discount");
-
- TableSection.clickField("Created At");
- FieldSection.getDataType()
- .should("be.visible")
- .and("have.text", "TIMESTAMP");
- FieldSection.getSemanticTypeInput().should(
- "have.value",
- "Creation timestamp",
- );
- });
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 2);
+ TablePicker.getTables().should("have.length", 3);
+ TablePicker.getTable("Birds").should("be.visible");
- it("should be able to preview the table in the query builder", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- });
- TableSection.getQueryBuilderLink().click();
- H.queryBuilderHeader().findByText("Orders").should("be.visible");
- });
+ cy.log("open another table");
+ TablePicker.getTable("Birds").click();
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
+ );
+ });
+ TableSection.getNameInput().should("have.value", "Birds");
+
+ cy.log("close schema");
+ if (area === "admin") {
+ TablePicker.getSchema("Wild").click();
+ }
+ if (area === "data studio") {
+ TablePicker.getSchema("Wild").within(() => {
+ cy.findByRole("button", { name: "Collapse" }).click();
+ });
+ }
+
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 2);
+ TablePicker.getTables().should("have.length", 1);
+ TablePicker.getTable("Birds").should("not.exist");
+
+ cy.log("close database");
+ if (area === "admin") {
+ TablePicker.getDatabase("Writable Postgres12").click();
+ }
+ if (area === "data studio") {
+ TablePicker.getDatabase("Writable Postgres12").within(() => {
+ cy.findByRole("button", { name: "Collapse" }).click();
+ });
+ }
+ TablePicker.getDatabases().should("have.length", 2);
+ TablePicker.getSchemas().should("have.length", 0);
+ TablePicker.getTables().should("have.length", 0);
+
+ cy.log("we still have a table opened");
+ cy.location("pathname").should((pathname) => {
+ return pathname.startsWith(
+ `${getBasePath()}/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic/table/`,
+ );
+ });
- it("should be able to see details of a table", () => {
- visit({ databaseId: SAMPLE_DB_ID });
-
- if (area === "admin") {
- verifyAdminTableSectionEmptyState();
- } else {
- verifyDataStudioTableSectionEmptyState();
- }
-
- TablePicker.getTable("Orders").click();
- if (area === "admin") {
- verifyFieldSectionEmptyState();
- } else {
- verifyDataStudioFieldSectionEmptyState();
- }
- TableSection.getNameInput().should("have.value", "Orders");
- TableSection.getDescriptionInput().should(
- "have.value",
- "Confirmed Sample Company orders for a product, from a user.",
+ if (area === "admin") {
+ cy.log("databases, schemas, and tables should be links");
+ TablePicker.getDatabase("Sample Database").click();
+ TablePicker.getDatabase("Writable Postgres12").click();
+ TablePicker.getDatabase("Writable Postgres12")
+ .should("have.prop", "tagName", "A")
+ .and(
+ "have.attr",
+ "href",
+ `/admin/datamodel/database/${WRITABLE_DB_ID}`,
+ );
+ TablePicker.getSchema("Domestic")
+ .should("have.prop", "tagName", "A")
+ .and(
+ "have.attr",
+ "href",
+ `/admin/datamodel/database/${WRITABLE_DB_ID}/schema/${WRITABLE_DB_ID}:Domestic`,
+ );
+ TablePicker.getTable("Orders")
+ .should("have.prop", "tagName", "A")
+ .and(
+ "have.attr",
+ "href",
+ `/admin/datamodel/database/${SAMPLE_DB_ID}/schema/${SAMPLE_DB_SCHEMA_ID}/table/${ORDERS_ID}`,
+ );
+ }
+ });
+ },
);
});
- it(
- "should be able to select and update a table in a database without schemas",
- { tags: ["@external"] },
- () => {
- H.restore("mysql-8");
-
+ describe("Table section", () => {
+ it("should show all tables in sample database and fields in orders table", () => {
visit({
- databaseId: MYSQL_DB_ID,
- schemaId: MYSQL_DB_SCHEMA_ID,
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
tableId: ORDERS_ID,
});
- TableSection.getNameInput().clear().type("New orders").blur();
- cy.wait("@updateTable");
- verifyAndCloseToast("Table name updated");
- TableSection.getNameInput().should("have.value", "New orders");
- },
- );
-
- it(
- "should show empty state when table has no fields",
- { tags: ["@external"] },
- () => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "multi_schema" });
- H.queryWritableDB(
- 'alter table "Domestic"."Animals" drop column Name, drop column Score',
- );
- H.resyncDatabase({ dbId: WRITABLE_DB_ID });
-
- visit();
- TablePicker.getDatabase("Writable Postgres12").click();
- TablePicker.getSchema("Domestic").click();
- TablePicker.getTable("Animals").click();
+ TablePicker.getTables().should("have.length", 8);
if (area === "data studio") {
TableSection.clickFieldsTab();
}
- TableSection.get()
- .findByText("This table has no fields")
- .should("exist");
- TableSection.getSortButton().should("not.exist");
- },
- );
-
- describe("Name and description", () => {
- it("should allow changing the table name", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- });
+ TableSection.clickField("ID");
- TableSection.getNameInput().clear().type("New orders").blur();
- cy.wait("@updateTable");
- verifyAndCloseToast("Table name updated");
- TableSection.getNameInput().should("have.value", "New orders");
+ if (area === "data studio") {
+ // Sometimes in CI this doesn't happen
+ FieldSection.get().scrollIntoView();
+ }
- H.startNewQuestion();
- H.miniPicker().within(() => {
- cy.findByText("Sample Database").click();
- cy.findByText("People").should("be.visible");
- cy.findByText("New orders").should("be.visible");
- });
- });
+ FieldSection.getDataType()
+ .should("be.visible")
+ .and("have.text", "BIGINT");
+ FieldSection.getSemanticTypeInput().should("have.value", "Entity Key");
- it("should allow changing the table description", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- });
+ TableSection.clickField("User ID");
+ FieldSection.getDataType()
+ .should("be.visible")
+ .and("have.text", "INTEGER");
+ FieldSection.getSemanticTypeInput().should("have.value", "Foreign Key");
+ FieldSection.getSemanticTypeFkTarget().should(
+ "have.value",
+ "People β†’ ID",
+ );
- TableSection.getDescriptionInput()
- .clear()
- .type("New description")
- .blur();
- cy.wait("@updateTable");
- verifyAndCloseToast("Table description updated");
- TableSection.getDescriptionInput().should(
+ TableSection.clickField("Tax");
+ FieldSection.getDataType()
+ .should("be.visible")
+ .and("have.text", "DOUBLE PRECISION");
+ FieldSection.getSemanticTypeInput().should(
"have.value",
- "New description",
+ "No semantic type",
);
- cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Orders").should("be.visible");
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("New description").should("be.visible");
+ TableSection.clickField("Discount");
+ FieldSection.getDataType()
+ .should("be.visible")
+ .and("have.text", "DOUBLE PRECISION");
+ FieldSection.getSemanticTypeInput().should("have.value", "Discount");
+
+ TableSection.clickField("Created At");
+ FieldSection.getDataType()
+ .should("be.visible")
+ .and("have.text", "TIMESTAMP");
+ FieldSection.getSemanticTypeInput().should(
+ "have.value",
+ "Creation timestamp",
+ );
});
- it("should allow clearing the table description", () => {
+ it("should be able to preview the table in the query builder", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
tableId: ORDERS_ID,
});
-
- TableSection.getDescriptionInput().clear().blur();
- cy.wait("@updateTable");
- verifyAndCloseToast("Table description updated");
- TableSection.getDescriptionInput().should("have.value", "");
-
- cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Orders").should("be.visible");
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("No description yet").should("be.visible");
+ TableSection.getQueryBuilderLink().click();
+ H.queryBuilderHeader().findByText("Orders").should("be.visible");
});
- });
- describe("Field name and description", () => {
- it("should allow changing the field name", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- });
+ it("should be able to see details of a table", () => {
+ visit({ databaseId: SAMPLE_DB_ID });
- if (area === "data studio") {
- TableSection.clickFieldsTab();
+ if (area === "admin") {
+ verifyAdminTableSectionEmptyState();
+ } else {
+ verifyDataStudioTableSectionEmptyState();
}
- TableSection.getFieldNameInput("Tax").clear().type("New tax").blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Name of Tax updated");
- TableSection.getFieldNameInput("New tax").should("be.visible");
-
- cy.log("verify preview");
- TableSection.clickField("New tax");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "New tax",
- values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
- });
- verifyObjectDetailPreview({ rowNumber: 4, row: ["New tax", "2.07"] });
- cy.log("verify viz");
- H.openOrdersTable();
- H.tableHeaderColumn("New tax").should("be.visible");
- H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
- "not.exist",
+ TablePicker.getTable("Orders").click();
+ if (area === "admin") {
+ verifyFieldSectionEmptyState();
+ } else {
+ verifyDataStudioFieldSectionEmptyState();
+ }
+ TableSection.getNameInput().should("have.value", "Orders");
+ TableSection.getDescriptionInput().should(
+ "have.value",
+ "Confirmed Sample Company orders for a product, from a user.",
);
});
- it("should allow changing the field description", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
+ it(
+ "should be able to select and update a table in a database without schemas",
+ { tags: ["@external"] },
+ () => {
+ H.restore("mysql-8");
+
+ visit({
+ databaseId: MYSQL_DB_ID,
+ schemaId: MYSQL_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ TableSection.getNameInput().clear().type("New orders").blur();
+ cy.wait("@updateTable");
+ verifyAndCloseToast("Table name updated");
+ TableSection.getNameInput().should("have.value", "New orders");
+ },
+ );
+
+ it(
+ "should show empty state when table has no fields",
+ { tags: ["@external"] },
+ () => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "multi_schema" });
+ H.queryWritableDB(
+ 'alter table "Domestic"."Animals" drop column Name, drop column Score',
+ );
+ H.resyncDatabase({ dbId: WRITABLE_DB_ID });
+
+ visit();
+ TablePicker.getDatabase("Writable Postgres12").click();
+ TablePicker.getSchema("Domestic").click();
+ TablePicker.getTable("Animals").click();
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.get()
+ .findByText("This table has no fields")
+ .should("exist");
+ TableSection.getSortButton().should("not.exist");
+ },
+ );
+
+ describe("Name and description", () => {
+ it("should allow changing the table name", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ TableSection.getNameInput().clear().type("New orders").blur();
+ cy.wait("@updateTable");
+ verifyAndCloseToast("Table name updated");
+ TableSection.getNameInput().should("have.value", "New orders");
+
+ H.startNewQuestion();
+ H.miniPicker().within(() => {
+ cy.findByText("Sample Database").click();
+ cy.findByText("People").should("be.visible");
+ cy.findByText("New orders").should("be.visible");
+ });
});
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.getFieldDescriptionInput("Total")
- .clear()
- .type("New description")
- .blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Description of Total updated");
- TableSection.getFieldDescriptionInput("Total").should(
- "have.value",
- "New description",
- );
+ it("should allow changing the table description", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
- cy.log("verify preview");
- TableSection.clickField("Total");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Total",
- description: "New description",
- values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
+ TableSection.getDescriptionInput()
+ .clear()
+ .type("New description")
+ .blur();
+ cy.wait("@updateTable");
+ verifyAndCloseToast("Table description updated");
+ TableSection.getDescriptionInput().should(
+ "have.value",
+ "New description",
+ );
+
+ cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Orders").should("be.visible");
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("New description").should("be.visible");
});
- cy.visit(
- `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
- );
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Total").should("be.visible");
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("New description").should("be.visible");
+ it("should allow clearing the table description", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ TableSection.getDescriptionInput().clear().blur();
+ cy.wait("@updateTable");
+ verifyAndCloseToast("Table description updated");
+ TableSection.getDescriptionInput().should("have.value", "");
+
+ cy.visit(`/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}`);
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Orders").should("be.visible");
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("No description yet").should("be.visible");
+ });
});
- it("should allow clearing the field description", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
+ describe("Field name and description", () => {
+ it("should allow changing the field name", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.getFieldNameInput("Tax").clear().type("New tax").blur();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Name of Tax updated");
+ TableSection.getFieldNameInput("New tax").should("be.visible");
+
+ cy.log("verify preview");
+ TableSection.clickField("New tax");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "New tax",
+ values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
+ });
+ verifyObjectDetailPreview({ rowNumber: 4, row: ["New tax", "2.07"] });
+
+ cy.log("verify viz");
+ H.openOrdersTable();
+ H.tableHeaderColumn("New tax").should("be.visible");
+ H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
+ "not.exist",
+ );
});
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.getFieldDescriptionInput("Total").clear().blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Description of Total updated");
- TableSection.getFieldDescriptionInput("Total").should("have.value", "");
-
- cy.log("verify preview");
- TableSection.clickField("Total");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Total",
- values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
+ it("should allow changing the field description", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.getFieldDescriptionInput("Total")
+ .clear()
+ .type("New description")
+ .blur();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Description of Total updated");
+ TableSection.getFieldDescriptionInput("Total").should(
+ "have.value",
+ "New description",
+ );
+
+ cy.log("verify preview");
+ TableSection.clickField("Total");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Total",
+ description: "New description",
+ values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
+ });
+
+ cy.visit(
+ `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
+ );
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Total").should("be.visible");
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("New description").should("be.visible");
+ });
+
+ it("should allow clearing the field description", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.getFieldDescriptionInput("Total").clear().blur();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Description of Total updated");
+ TableSection.getFieldDescriptionInput("Total").should(
+ "have.value",
+ "",
+ );
+
+ cy.log("verify preview");
+ TableSection.clickField("Total");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Total",
+ values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
+ });
+ // realHover is avoided here because Chrome v133+ headless hit-tests
+ // CDP mouse events differently and the HoverCard wouldn't open. We
+ // dispatch synthetic events instead β€” both `mouseover` (bubbles, so
+ // React 18 turns it into onMouseEnter for any wrapper) and
+ // `mouseenter` (for any native useEventListener-attached handler on
+ // the cell itself). After `cy.wait("@dataset")` the table re-renders
+ // on a microtask (fetch resolution), so re-query the cell each time
+ // to ensure the events land on the post-render DOM node.
+ hoverHeaderCell();
+ H.hovercard().should("not.contain.text", "The total billed amount.");
+
+ cy.visit(
+ `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
+ );
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Total").should("be.visible");
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("No description yet").should("be.visible");
});
- // realHover is avoided here because Chrome v133+ headless hit-tests
- // CDP mouse events differently and the HoverCard wouldn't open. We
- // dispatch synthetic events instead β€” both `mouseover` (bubbles, so
- // React 18 turns it into onMouseEnter for any wrapper) and
- // `mouseenter` (for any native useEventListener-attached handler on
- // the cell itself). After `cy.wait("@dataset")` the table re-renders
- // on a microtask (fetch resolution), so re-query the cell each time
- // to ensure the events land on the post-render DOM node.
- hoverHeaderCell();
- H.hovercard().should("not.contain.text", "The total billed amount.");
-
- cy.visit(
- `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
- );
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Total").should("be.visible");
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("No description yet").should("be.visible");
});
});
});
diff --git a/e2e/test/scenarios/data-model/data-model-shared-2.cy.spec.ts b/e2e/test/scenarios/data-model/data-model-shared-2.cy.spec.ts
index 72c0911ca79..4238aeb4ad0 100644
--- a/e2e/test/scenarios/data-model/data-model-shared-2.cy.spec.ts
+++ b/e2e/test/scenarios/data-model/data-model-shared-2.cy.spec.ts
@@ -23,828 +23,706 @@ const MYSQL_DB_ID = SAMPLE_DB_ID + 1;
const MYSQL_DB_SCHEMA_ID = `${MYSQL_DB_ID}:`;
const areas: ("admin" | "data studio")[] = ["admin", "data studio"];
-type Area = (typeof areas)[number];
-
-describe.each<Area>(areas)("data model > %s", (area: Area) => {
- const visit = visitArea(area);
- const getTriggeredFrom = getTriggeredFromArea(area);
-
- beforeEach(() => {
- H.restore();
- H.resetSnowplow();
- cy.signInAsAdmin();
- H.activateToken("pro-self-hosted");
-
- cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
- cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
- cy.intercept("GET", "/api/database/*/schema/*").as("schema");
- cy.intercept("POST", "/api/dataset*").as("dataset");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
- "updateField",
- );
- cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
- cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
- cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
- cy.intercept("PUT", "/api/table").as("updateTables");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
-
- if (area === "admin") {
- cy.intercept("GET", "/api/database?*").as("databases");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
- }
- if (area === "data studio") {
- cy.intercept("GET", "/api/database").as("databases");
- }
- });
+areas.forEach((area) => {
+ describe(`data model > ${area}`, () => {
+ const visit = visitArea(area);
+ const getTriggeredFrom = getTriggeredFromArea(area);
- describe("Field section", () => {
beforeEach(() => {
+ H.restore();
H.resetSnowplow();
- H.enableTracking();
- });
-
- afterEach(() => {
- H.expectNoBadSnowplowEvents();
- });
-
- describe("Name and description", () => {
- it("should allow changing the field name", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
- });
-
- FieldSection.getNameInput().clear().type("New tax").blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Name of Tax updated");
- TableSection.getFieldNameInput("New tax").should("exist");
-
- cy.log("verify preview");
- TableSection.clickField("New tax");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "New tax",
- values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
- });
- verifyObjectDetailPreview({ rowNumber: 4, row: ["New tax", "2.07"] });
-
- cy.log("verify viz");
- H.openOrdersTable();
- H.tableHeaderColumn("New tax").should("be.visible");
- H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
- "not.exist",
- );
- });
-
- it("should allow changing the field description", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TOTAL,
- });
-
- FieldSection.getDescriptionInput()
- .clear()
- .type("New description")
- .blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Description of Total updated");
- TableSection.getFieldDescriptionInput("Total").should(
- "have.value",
- "New description",
- );
-
- cy.log("verify preview");
- TableSection.clickField("Total");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Total",
- description: "New description",
- values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
- });
+ cy.signInAsAdmin();
+ H.activateToken("pro-self-hosted");
- cy.visit(
- `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
- );
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Total").should("be.visible");
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("New description").should("be.visible");
- });
-
- it("should remap FK display value from field section", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.PRODUCT_ID,
- });
+ cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
+ cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
+ cy.intercept("GET", "/api/database/*/schema/*").as("schema");
+ cy.intercept("POST", "/api/dataset*").as("dataset");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
+ "updateField",
+ );
+ cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
+ cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
+ cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
+ cy.intercept("PUT", "/api/table").as("updateTables");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
- FieldSection.getNameInput()
- .clear()
- .type("Remapped Product ID")
- .realPress("Tab");
- cy.wait("@updateField");
- verifyAndCloseToast("Name of Product ID updated");
-
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Remapped Product ID",
- values: ["14", "123", "105", "94", "132"],
- });
- verifyObjectDetailPreview({
- rowNumber: 2,
- row: ["Remapped Product ID", "14"],
- });
+ if (area === "admin") {
+ cy.intercept("GET", "/api/database?*").as("databases");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
+ }
- cy.log("verify viz");
- H.openOrdersTable({ limit: 5 });
- H.tableHeaderColumn("Remapped Product ID").should("be.visible");
- });
+ if (area === "data studio") {
+ cy.intercept("GET", "/api/database").as("databases");
+ }
});
- describe("Field values", () => {
- it("should allow to sync table schema, re-scan table, and discard cached field values", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: PRODUCTS_ID,
- fieldId: PRODUCTS.CATEGORY,
- });
- FieldSection.getFieldValuesButton().click();
-
- cy.log("re-scan field");
- H.modal().within(() => {
- cy.button("Re-scan field").click();
- cy.button("Re-scan field").should("not.exist");
- cy.button("Scan triggered!").should("be.visible");
- cy.button("Scan triggered!").should("not.exist");
- cy.button("Re-scan field").should("be.visible");
- });
-
- cy.log("discard cached field values");
- H.modal().within(() => {
- cy.button("Discard cached field values").click();
- cy.button("Discard cached field values").should("not.exist");
- cy.button("Discard triggered!").should("be.visible");
- cy.button("Discard triggered!").should("not.exist");
- cy.button("Discard cached field values").should("be.visible");
- });
-
- cy.realPress("Escape");
- H.modal().should("not.exist");
+ describe("Field section", () => {
+ beforeEach(() => {
+ H.resetSnowplow();
+ H.enableTracking();
});
- it("should not automatically re-fetch field values when they are discarded unless 'Custom mapping' is used (metabase#62626)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: PRODUCTS_ID,
- fieldId: PRODUCTS.CATEGORY,
- });
-
- FieldSection.getFieldValuesButton().click();
- H.modal().within(() => {
- cy.button("Discard cached field values").click();
- cy.button("Discard triggered!").should("be.visible");
- cy.button("Discard triggered!").should("not.exist");
- });
-
- cy.get("@fieldValues.all").should("have.length", 0);
+ afterEach(() => {
+ H.expectNoBadSnowplowEvents();
});
- });
- describe("Data", () => {
- describe("Coercion strategy", () => {
- it("should allow you to cast a field to a data type", () => {
+ describe("Name and description", () => {
+ it("should allow changing the field name", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: FEEDBACK_ID,
- fieldId: FEEDBACK.RATING,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
});
- cy.log(
- "Ensure that Coercion strategy has been humanized (metabase#44723)",
- );
- FieldSection.getCoercionToggle().parent().scrollIntoView().click();
- H.popover().should("not.contain.text", "Coercion");
- H.popover().findByText("UNIX seconds β†’ Datetime").click();
+ FieldSection.getNameInput().clear().type("New tax").blur();
cy.wait("@updateField");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "type_casting",
- triggered_from: getTriggeredFrom(),
- });
- verifyAndCloseToast("Casting enabled for Rating");
+ verifyAndCloseToast("Name of Tax updated");
+ TableSection.getFieldNameInput("New tax").should("exist");
cy.log("verify preview");
+ TableSection.clickField("New tax");
FieldSection.getPreviewButton().click();
verifyTablePreview({
- column: "Rating",
- values: [
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- ],
- });
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Rating", "December 31, 1969, 4:00 PM"],
+ column: "New tax",
+ values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
});
+ verifyObjectDetailPreview({ rowNumber: 4, row: ["New tax", "2.07"] });
cy.log("verify viz");
- H.openTable({ database: SAMPLE_DB_ID, table: FEEDBACK_ID });
- cy.findAllByTestId("cell-data")
- .contains("December 31, 1969, 4:00 PM")
- .should("have.length.greaterThan", 0);
+ H.openOrdersTable();
+ H.tableHeaderColumn("New tax").should("be.visible");
+ H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
+ "not.exist",
+ );
});
- it("should allow to enable, change, and disable coercion strategy", () => {
+ it("should allow changing the field description", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: FEEDBACK_ID,
- fieldId: FEEDBACK.RATING,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TOTAL,
});
- cy.log("show error when strategy not chosen after toggling");
- FieldSection.getCoercionToggle()
- .parent()
- .click({ scrollBehavior: "center" });
- clickAway();
- FieldSection.get()
- .findByText("To enable casting, please select a data type")
- .should("be.visible");
-
- cy.log("enable casting");
- FieldSection.getCoercionInput().click({ scrollBehavior: "center" });
- H.popover().findByText("UNIX nanoseconds β†’ Datetime").click();
+ FieldSection.getDescriptionInput()
+ .clear()
+ .type("New description")
+ .blur();
cy.wait("@updateField");
- verifyAndCloseToast("Casting enabled for Rating");
+ verifyAndCloseToast("Description of Total updated");
+ TableSection.getFieldDescriptionInput("Total").should(
+ "have.value",
+ "New description",
+ );
cy.log("verify preview");
+ TableSection.clickField("Total");
FieldSection.getPreviewButton().click();
- // ideally we should change the formatting to show smaller values and assert those
- // but we can't set formatting on a coerced field (metabase#60483)
verifyTablePreview({
- column: "Rating",
- values: [
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- "December 31, 1969, 4:00 PM",
- ],
+ column: "Total",
+ description: "New description",
+ values: ["39.72", "117.03", "49.21", "115.23", "134.91"],
});
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Rating", "December 31, 1969, 4:00 PM"],
- });
-
- cy.log("change casting");
- FieldSection.getCoercionInput().click({ scrollBehavior: "center" });
- H.popover().findByText("UNIX seconds β†’ Datetime").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Casting updated for Rating");
-
- cy.log("disable casting");
- FieldSection.getCoercionToggle()
- .parent()
- .click({ scrollBehavior: "center" });
- cy.wait("@updateField");
- verifyAndCloseToast("Casting disabled for Rating");
-
- cy.log("enable casting");
- FieldSection.getCoercionToggle()
- .parent()
- .click({ scrollBehavior: "center" });
- H.popover().findByText("UNIX seconds β†’ Datetime").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Casting enabled for Rating");
- H.openTable({ database: SAMPLE_DB_ID, table: FEEDBACK_ID });
- cy.findAllByTestId("cell-data")
- .contains("December 31, 1969, 4:00 PM")
- .should("have.length.greaterThan", 0);
+ cy.visit(
+ `/reference/databases/${SAMPLE_DB_ID}/tables/${ORDERS_ID}/fields/${ORDERS.TOTAL}`,
+ );
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Total").should("be.visible");
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("New description").should("be.visible");
});
- });
- });
- describe("Metadata", () => {
- describe("Semantic type", () => {
- it("should allow to change the type to 'No semantic type' (metabase#59052)", () => {
+ it("should remap FK display value from field section", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
tableId: ORDERS_ID,
fieldId: ORDERS.PRODUCT_ID,
});
- cy.wait(["@metadata", "@metadata"]);
- FieldSection.getSemanticTypeInput()
- .should("have.value", "Foreign Key")
- // it should allow to just type to search (metabase#59052)
- .type("no sema{downarrow}{enter}");
+ FieldSection.getNameInput()
+ .clear()
+ .type("Remapped Product ID")
+ .realPress("Tab");
cy.wait("@updateField");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "semantic_type_change",
- triggered_from: getTriggeredFrom(),
- });
- H.undoToast().should(
- "contain.text",
- "Semantic type of Product ID updated",
- );
+ verifyAndCloseToast("Name of Product ID updated");
cy.log("verify preview");
FieldSection.getPreviewButton().click();
- cy.wait("@dataset");
- PreviewSection.get()
- .findAllByTestId("cell-data")
- .should("have.length", 6)
- .eq(1)
- // FKs get blueish background
- .should("have.css", "background-color", "rgba(0, 0, 0, 0)");
-
- cy.reload();
- cy.wait("@metadata");
-
- FieldSection.getSemanticTypeInput().should(
- "have.value",
- "No semantic type",
- );
+ verifyTablePreview({
+ column: "Remapped Product ID",
+ values: ["14", "123", "105", "94", "132"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 2,
+ row: ["Remapped Product ID", "14"],
+ });
+
+ cy.log("verify viz");
+ H.openOrdersTable({ limit: 5 });
+ H.tableHeaderColumn("Remapped Product ID").should("be.visible");
});
+ });
- it("should allow to change the type to 'Foreign Key' and choose the target field (metabase#59052)", () => {
+ describe("Field values", () => {
+ it("should allow to sync table schema, re-scan table, and discard cached field values", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
+ tableId: PRODUCTS_ID,
+ fieldId: PRODUCTS.CATEGORY,
});
+ FieldSection.getFieldValuesButton().click();
- FieldSection.getSemanticTypeInput()
- .should("have.value", "Quantity")
- .click();
- H.popover().findByText("Foreign Key").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Semantic type of Quantity updated");
+ cy.log("re-scan field");
+ H.modal().within(() => {
+ cy.button("Re-scan field").click();
+ cy.button("Re-scan field").should("not.exist");
+ cy.button("Scan triggered!").should("be.visible");
+ cy.button("Scan triggered!").should("not.exist");
+ cy.button("Re-scan field").should("be.visible");
+ });
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- cy.wait("@dataset");
- PreviewSection.get()
- .findAllByTestId("cell-data")
- .should("have.length", 6)
- .eq(1)
- // FKs get blueish background
- .should("not.have.css", "background-color", "rgba(0, 0, 0, 0)");
-
- FieldSection.getSemanticTypeFkTarget()
- .should("have.value", "")
- // it should allow to just type to search (metabase#59052)
- .type("products{downarrow}{enter}");
- cy.wait("@updateField");
- H.undoToast().should(
- "contain.text",
- "Semantic type of Quantity updated",
- );
+ cy.log("discard cached field values");
+ H.modal().within(() => {
+ cy.button("Discard cached field values").click();
+ cy.button("Discard cached field values").should("not.exist");
+ cy.button("Discard triggered!").should("be.visible");
+ cy.button("Discard triggered!").should("not.exist");
+ cy.button("Discard cached field values").should("be.visible");
+ });
- cy.log("verify preview");
- cy.wait("@dataset");
- PreviewSection.get()
- .findAllByTestId("cell-data")
- .should("have.length", 6)
- .eq(1)
- // FKs get blueish background
- .should("not.have.css", "background-color", "rgba(0, 0, 0, 0)");
-
- cy.reload();
- cy.wait(["@metadata", "@metadata"]);
-
- FieldSection.getSemanticTypeFkTarget()
- .scrollIntoView() //This should not be necessary, but CI consistently fails to scroll into view on mount
- .should("be.visible")
- .and("have.value", "Products β†’ ID");
+ cy.realPress("Escape");
+ H.modal().should("not.exist");
});
- it("should allow to change the foreign key target", () => {
+ it("should not automatically re-fetch field values when they are discarded unless 'Custom mapping' is used (metabase#62626)", () => {
visit({
databaseId: SAMPLE_DB_ID,
schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.USER_ID,
+ tableId: PRODUCTS_ID,
+ fieldId: PRODUCTS.CATEGORY,
});
- FieldSection.getSemanticTypeFkTarget()
- .should("have.value", "People β†’ ID")
- .click();
- H.popover().within(() => {
- cy.findByText("Reviews β†’ ID").should("be.visible");
- cy.findByText("Products β†’ ID").click();
+ FieldSection.getFieldValuesButton().click();
+ H.modal().within(() => {
+ cy.button("Discard cached field values").click();
+ cy.button("Discard triggered!").should("be.visible");
+ cy.button("Discard triggered!").should("not.exist");
});
- cy.wait("@updateField");
- H.undoToast().should(
- "contain.text",
- "Semantic type of User ID updated",
- );
- FieldSection.getSemanticTypeFkTarget().should(
- "have.value",
- "Products β†’ ID",
- );
- H.openTable({
- database: SAMPLE_DB_ID,
- table: ORDERS_ID,
- mode: "notebook",
- });
- cy.icon("join_left_outer").click();
- H.miniPicker().within(() => {
- cy.findByText("Sample Database").click();
- cy.findByText("Products").click();
- });
- cy.findByLabelText("Left column").should("contain.text", "User ID");
+ cy.get("@fieldValues.all").should("have.length", 0);
});
+ });
- it("should allow to change the type to 'Currency' and choose the currency (metabase#59052)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
- });
+ describe("Data", () => {
+ describe("Coercion strategy", () => {
+ it("should allow you to cast a field to a data type", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: FEEDBACK_ID,
+ fieldId: FEEDBACK.RATING,
+ });
- FieldSection.getSemanticTypeInput()
- .should("have.value", "No semantic type")
- .click();
- H.popover().findByText("Currency").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Semantic type of Tax updated");
+ cy.log(
+ "Ensure that Coercion strategy has been humanized (metabase#44723)",
+ );
+ FieldSection.getCoercionToggle().parent().scrollIntoView().click();
+ H.popover().should("not.contain.text", "Coercion");
+ H.popover().findByText("UNIX seconds β†’ Datetime").click();
+ cy.wait("@updateField");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "type_casting",
+ triggered_from: getTriggeredFrom(),
+ });
+ verifyAndCloseToast("Casting enabled for Rating");
+
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Rating",
+ values: [
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ ],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Rating", "December 31, 1969, 4:00 PM"],
+ });
- cy.log("verify preview");
- TableSection.clickField("Tax");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Tax ($)",
- values: ["2.07", "6.10", "2.90", "6.01", "7.03"],
- });
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Tax ($)", "2.07"],
+ cy.log("verify viz");
+ H.openTable({ database: SAMPLE_DB_ID, table: FEEDBACK_ID });
+ cy.findAllByTestId("cell-data")
+ .contains("December 31, 1969, 4:00 PM")
+ .should("have.length.greaterThan", 0);
});
- cy.log("change currency");
- FieldSection.getSemanticTypeCurrencyInput()
- .scrollIntoView()
- .should("be.visible")
- .and("have.value", "US Dollar")
- // it should allow to just type to search (metabase#59052)
- .type("canadian{downarrow}{enter}");
- cy.wait("@updateField");
- verifyAndCloseToast("Semantic type of Tax updated");
+ it("should allow to enable, change, and disable coercion strategy", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: FEEDBACK_ID,
+ fieldId: FEEDBACK.RATING,
+ });
- cy.log("verify preview");
- verifyTablePreview({
- column: "Tax (CA$)",
- values: ["2.07", "6.10", "2.90", "6.01", "7.03"],
- });
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Tax (CA$)", "2.07"],
- });
+ cy.log("show error when strategy not chosen after toggling");
+ FieldSection.getCoercionToggle()
+ .parent()
+ .click({ scrollBehavior: "center" });
+ clickAway();
+ FieldSection.get()
+ .findByText("To enable casting, please select a data type")
+ .should("be.visible");
- cy.log("verify viz");
- H.openOrdersTable();
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Tax (CA$)").should("be.visible");
- });
+ cy.log("enable casting");
+ FieldSection.getCoercionInput().click({ scrollBehavior: "center" });
+ H.popover().findByText("UNIX nanoseconds β†’ Datetime").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Casting enabled for Rating");
+
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ // ideally we should change the formatting to show smaller values and assert those
+ // but we can't set formatting on a coerced field (metabase#60483)
+ verifyTablePreview({
+ column: "Rating",
+ values: [
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ "December 31, 1969, 4:00 PM",
+ ],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Rating", "December 31, 1969, 4:00 PM"],
+ });
- it("should correctly filter out options in Foreign Key picker (metabase#56839)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.PRODUCT_ID,
- });
- cy.wait(["@metadata", "@metadata"]);
-
- FieldSection.getSemanticTypeFkTarget().focus().clear();
- H.popover()
- .should("contain.text", "Orders β†’ ID")
- .and("contain.text", "People β†’ ID")
- .and("contain.text", "Products β†’ ID")
- .and("contain.text", "Reviews β†’ ID");
-
- cy.log("should case-insensitive match field display name");
- FieldSection.getSemanticTypeFkTarget().focus().type("id");
- H.popover()
- .should("contain.text", "Orders β†’ ID")
- .and("contain.text", "People β†’ ID")
- .and("contain.text", "Products β†’ ID")
- .and("contain.text", "Reviews β†’ ID");
-
- cy.log("should case-insensitive match field description");
- FieldSection.getSemanticTypeFkTarget().focus().clear().type("EXT");
- H.popover()
- .should("not.contain.text", "Orders β†’ ID")
- .and("not.contain.text", "People β†’ ID")
- .and("contain.text", "Products β†’ ID")
- .and("contain.text", "Reviews β†’ ID");
- });
+ cy.log("change casting");
+ FieldSection.getCoercionInput().click({ scrollBehavior: "center" });
+ H.popover().findByText("UNIX seconds β†’ Datetime").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Casting updated for Rating");
- it("should not let you change the type to 'Number' (metabase#16781)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.PRODUCT_ID,
- });
- cy.wait(["@metadata", "@metadata"]);
+ cy.log("disable casting");
+ FieldSection.getCoercionToggle()
+ .parent()
+ .click({ scrollBehavior: "center" });
+ cy.wait("@updateField");
+ verifyAndCloseToast("Casting disabled for Rating");
+
+ cy.log("enable casting");
+ FieldSection.getCoercionToggle()
+ .parent()
+ .click({ scrollBehavior: "center" });
+ H.popover().findByText("UNIX seconds β†’ Datetime").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Casting enabled for Rating");
- FieldSection.getSemanticTypeInput().click();
- H.popover()
- .should("contain.text", "Foreign Key")
- .and("not.contain.text", "Number");
+ H.openTable({ database: SAMPLE_DB_ID, table: FEEDBACK_ID });
+ cy.findAllByTestId("cell-data")
+ .contains("December 31, 1969, 4:00 PM")
+ .should("have.length.greaterThan", 0);
+ });
});
+ });
- it("should not overflow the screen on smaller viewports (metabase#56442)", () => {
- const viewportHeight = 400;
-
- cy.viewport(1280, viewportHeight);
- visit({ databaseId: SAMPLE_DB_ID });
- TablePicker.getTable("Reviews").scrollIntoView().click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("ID");
- FieldSection.getSemanticTypeInput().click();
-
- H.popover().scrollTo("top");
- H.popover()
- .findByText("Entity Key")
- .should(($element) => {
- const rect = $element[0].getBoundingClientRect();
- expect(rect.top).greaterThan(0);
- });
-
- H.popover().scrollTo("bottom");
- H.popover()
- .findByText("No semantic type")
- .should(($element) => {
- const rect = $element[0].getBoundingClientRect();
- expect(rect.bottom).lessThan(viewportHeight);
+ describe("Metadata", () => {
+ describe("Semantic type", () => {
+ it("should allow to change the type to 'No semantic type' (metabase#59052)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.PRODUCT_ID,
});
- });
+ cy.wait(["@metadata", "@metadata"]);
- it(
- "should show an error with links to other fields with 'Entity name' semantic type",
- { tags: "@external" },
- () => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "many_data_types" });
- cy.signInAsAdmin();
- H.resyncDatabase({
- dbId: WRITABLE_DB_ID,
- tableName: "many_data_types",
+ FieldSection.getSemanticTypeInput()
+ .should("have.value", "Foreign Key")
+ // it should allow to just type to search (metabase#59052)
+ .type("no sema{downarrow}{enter}");
+ cy.wait("@updateField");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "semantic_type_change",
+ triggered_from: getTriggeredFrom(),
});
+ H.undoToast().should(
+ "contain.text",
+ "Semantic type of Product ID updated",
+ );
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Json β†’ D");
- FieldSection.getSemanticTypeInput().click();
- H.popover().findByText("Entity Name").click();
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ cy.wait("@dataset");
+ PreviewSection.get()
+ .findAllByTestId("cell-data")
+ .should("have.length", 6)
+ .eq(1)
+ // FKs get blueish background
+ .should("have.css", "background-color", "rgba(0, 0, 0, 0)");
- TableSection.clickField("Text");
- FieldSection.getSemanticTypeInput().click();
- H.popover().findByText("Entity Name").click();
+ cy.reload();
+ cy.wait("@metadata");
- FieldSection.get().should(
- "contain.text",
- "There are other fields with this semantic type: Json: Json β†’ D",
+ FieldSection.getSemanticTypeInput().should(
+ "have.value",
+ "No semantic type",
);
- FieldSection.get()
- .findByRole("link", { name: "Json: Json β†’ D" })
- .should("be.visible")
- .click();
+ });
- FieldSection.getNameInput().should("have.value", "Json β†’ D");
+ it("should allow to change the type to 'Foreign Key' and choose the target field (metabase#59052)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
- FieldSection.get().should(
+ FieldSection.getSemanticTypeInput()
+ .should("have.value", "Quantity")
+ .click();
+ H.popover().findByText("Foreign Key").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Semantic type of Quantity updated");
+
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ cy.wait("@dataset");
+ PreviewSection.get()
+ .findAllByTestId("cell-data")
+ .should("have.length", 6)
+ .eq(1)
+ // FKs get blueish background
+ .should("not.have.css", "background-color", "rgba(0, 0, 0, 0)");
+
+ FieldSection.getSemanticTypeFkTarget()
+ .should("have.value", "")
+ // it should allow to just type to search (metabase#59052)
+ .type("products{downarrow}{enter}");
+ cy.wait("@updateField");
+ H.undoToast().should(
"contain.text",
- "There are other fields with this semantic type: Text",
+ "Semantic type of Quantity updated",
);
- FieldSection.get()
- .findByRole("link", { name: "Text" })
- .should("be.visible")
- .click();
- FieldSection.getNameInput().should("have.value", "Text");
- },
- );
- });
- });
+ cy.log("verify preview");
+ cy.wait("@dataset");
+ PreviewSection.get()
+ .findAllByTestId("cell-data")
+ .should("have.length", 6)
+ .eq(1)
+ // FKs get blueish background
+ .should("not.have.css", "background-color", "rgba(0, 0, 0, 0)");
- describe("Behavior", () => {
- describe("Visibility", () => {
- it("should let you change field visibility to 'Everywhere'", () => {
- cy.request("PUT", `/api/field/${ORDERS.TAX}`, {
- visibility_type: "sensitive",
- });
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
- });
+ cy.reload();
+ cy.wait(["@metadata", "@metadata"]);
- FieldSection.getVisibilityInput()
- .should("have.value", "Do not include")
- .click();
- H.popover().findByText("Everywhere").click();
- cy.wait("@updateField");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "visibility_change",
- triggered_from: getTriggeredFrom(),
+ FieldSection.getSemanticTypeFkTarget()
+ .scrollIntoView() //This should not be necessary, but CI consistently fails to scroll into view on mount
+ .should("be.visible")
+ .and("have.value", "Products β†’ ID");
});
- verifyAndCloseToast("Visibility of Tax updated");
- FieldSection.getVisibilityInput().should("have.value", "Everywhere");
- cy.log("verify preview");
- TableSection.clickField("Tax");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Tax",
- values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
- });
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Tax", "2.07"],
- });
+ it("should allow to change the foreign key target", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.USER_ID,
+ });
- cy.log("table viz");
- H.openOrdersTable();
- H.tableHeaderColumn("Total").should("be.visible");
- H.tableHeaderColumn("Tax").should("be.visible");
-
- cy.log("object detail viz");
- cy.findByTestId("table-body")
- .findAllByTestId("cell-data")
- .eq(0)
- .click();
- H.modal().findByText("Tax").should("be.visible");
- H.modal().findByText("2.07").should("be.visible");
- });
+ FieldSection.getSemanticTypeFkTarget()
+ .should("have.value", "People β†’ ID")
+ .click();
+ H.popover().within(() => {
+ cy.findByText("Reviews β†’ ID").should("be.visible");
+ cy.findByText("Products β†’ ID").click();
+ });
+ cy.wait("@updateField");
+ H.undoToast().should(
+ "contain.text",
+ "Semantic type of User ID updated",
+ );
+ FieldSection.getSemanticTypeFkTarget().should(
+ "have.value",
+ "Products β†’ ID",
+ );
- it("should let you change field visibility to 'Do not include'", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
+ H.openTable({
+ database: SAMPLE_DB_ID,
+ table: ORDERS_ID,
+ mode: "notebook",
+ });
+ cy.icon("join_left_outer").click();
+ H.miniPicker().within(() => {
+ cy.findByText("Sample Database").click();
+ cy.findByText("Products").click();
+ });
+ cy.findByLabelText("Left column").should("contain.text", "User ID");
});
- FieldSection.getVisibilityInput()
- .should("have.value", "Everywhere")
- .click();
- H.popover().findByText("Do not include").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Visibility of Tax updated");
- FieldSection.getVisibilityInput().should(
- "have.value",
- "Do not include",
- );
+ it("should allow to change the type to 'Currency' and choose the currency (metabase#59052)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
+ });
- cy.log("verify preview");
- TableSection.clickField("Tax");
- FieldSection.getPreviewButton().click();
- PreviewSection.get()
- .findByText("This field is hidden")
- .should("exist");
- cy.get("@dataset.all").should("have.length", 0);
- PreviewSection.getPreviewTypeInput().findByText("Detail").click();
- cy.wait("@dataset");
- PreviewSection.get().findByText("Tax").should("not.exist");
-
- cy.log("table viz");
- H.openOrdersTable();
- H.tableHeaderColumn("Total").should("be.visible");
- H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
- "not.exist",
- );
+ FieldSection.getSemanticTypeInput()
+ .should("have.value", "No semantic type")
+ .click();
+ H.popover().findByText("Currency").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Semantic type of Tax updated");
- cy.log("object detail viz");
- cy.findByTestId("table-body")
- .findAllByTestId("cell-data")
- .eq(0)
- .click();
- H.modal().findByText("Tax").should("not.exist");
- H.modal().findByText("2.07").should("not.exist");
- });
+ cy.log("verify preview");
+ TableSection.clickField("Tax");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Tax ($)",
+ values: ["2.07", "6.10", "2.90", "6.01", "7.03"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Tax ($)", "2.07"],
+ });
- it("should let you change field visibility to 'Do not include' even if Preview is opened (metabase#61806)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
- });
+ cy.log("change currency");
+ FieldSection.getSemanticTypeCurrencyInput()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.value", "US Dollar")
+ // it should allow to just type to search (metabase#59052)
+ .type("canadian{downarrow}{enter}");
+ cy.wait("@updateField");
+ verifyAndCloseToast("Semantic type of Tax updated");
- TableSection.clickField("Tax");
- FieldSection.getPreviewButton().click();
- PreviewSection.get().within(() => {
- cy.findByText("Filtering").click();
+ cy.log("verify preview");
+ verifyTablePreview({
+ column: "Tax (CA$)",
+ values: ["2.07", "6.10", "2.90", "6.01", "7.03"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Tax (CA$)", "2.07"],
+ });
- cy.findByTestId("number-filter-picker").should("be.visible");
+ cy.log("verify viz");
+ H.openOrdersTable();
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Tax (CA$)").should("be.visible");
});
- FieldSection.getVisibilityInput()
- .should("have.value", "Everywhere")
- .click();
- H.popover().findByText("Do not include").click();
- cy.wait("@updateField");
-
- PreviewSection.get()
- .findByText("This field is hidden")
- .should("exist");
- });
+ it("should correctly filter out options in Foreign Key picker (metabase#56839)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.PRODUCT_ID,
+ });
+ cy.wait(["@metadata", "@metadata"]);
+
+ FieldSection.getSemanticTypeFkTarget().focus().clear();
+ H.popover()
+ .should("contain.text", "Orders β†’ ID")
+ .and("contain.text", "People β†’ ID")
+ .and("contain.text", "Products β†’ ID")
+ .and("contain.text", "Reviews β†’ ID");
+
+ cy.log("should case-insensitive match field display name");
+ FieldSection.getSemanticTypeFkTarget().focus().type("id");
+ H.popover()
+ .should("contain.text", "Orders β†’ ID")
+ .and("contain.text", "People β†’ ID")
+ .and("contain.text", "Products β†’ ID")
+ .and("contain.text", "Reviews β†’ ID");
+
+ cy.log("should case-insensitive match field description");
+ FieldSection.getSemanticTypeFkTarget().focus().clear().type("EXT");
+ H.popover()
+ .should("not.contain.text", "Orders β†’ ID")
+ .and("not.contain.text", "People β†’ ID")
+ .and("contain.text", "Products β†’ ID")
+ .and("contain.text", "Reviews β†’ ID");
+ });
+
+ it("should not let you change the type to 'Number' (metabase#16781)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.PRODUCT_ID,
+ });
+ cy.wait(["@metadata", "@metadata"]);
- it("should let you change field visibility to 'Only in detail views'", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.TAX,
+ FieldSection.getSemanticTypeInput().click();
+ H.popover()
+ .should("contain.text", "Foreign Key")
+ .and("not.contain.text", "Number");
});
- FieldSection.getVisibilityInput()
- .should("have.value", "Everywhere")
- .click();
- H.popover().findByText("Only in detail views").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Visibility of Tax updated");
- FieldSection.getVisibilityInput().should(
- "have.value",
- "Only in detail views",
- );
+ it("should not overflow the screen on smaller viewports (metabase#56442)", () => {
+ const viewportHeight = 400;
- cy.log("verify preview");
- TableSection.clickField("Tax");
- FieldSection.getPreviewButton().click();
- PreviewSection.get()
- .findByText("This field is hidden")
- .should("exist");
- cy.get("@dataset.all").should("have.length", 0);
- verifyObjectDetailPreview({
- rowNumber: 4,
- row: ["Tax", "2.07"],
- });
+ cy.viewport(1280, viewportHeight);
+ visit({ databaseId: SAMPLE_DB_ID });
+ TablePicker.getTable("Reviews").scrollIntoView().click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("ID");
+ FieldSection.getSemanticTypeInput().click();
- cy.log("table viz");
- H.openOrdersTable();
- H.tableHeaderColumn("Total").should("be.visible");
- H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
- "not.exist",
+ H.popover().scrollTo("top");
+ H.popover()
+ .findByText("Entity Key")
+ .should(($element) => {
+ const rect = $element[0].getBoundingClientRect();
+ expect(rect.top).greaterThan(0);
+ });
+
+ H.popover().scrollTo("bottom");
+ H.popover()
+ .findByText("No semantic type")
+ .should(($element) => {
+ const rect = $element[0].getBoundingClientRect();
+ expect(rect.bottom).lessThan(viewportHeight);
+ });
+ });
+
+ it(
+ "should show an error with links to other fields with 'Entity name' semantic type",
+ { tags: "@external" },
+ () => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_data_types" });
+ cy.signInAsAdmin();
+ H.resyncDatabase({
+ dbId: WRITABLE_DB_ID,
+ tableName: "many_data_types",
+ });
+
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Json β†’ D");
+ FieldSection.getSemanticTypeInput().click();
+ H.popover().findByText("Entity Name").click();
+
+ TableSection.clickField("Text");
+ FieldSection.getSemanticTypeInput().click();
+ H.popover().findByText("Entity Name").click();
+
+ FieldSection.get().should(
+ "contain.text",
+ "There are other fields with this semantic type: Json: Json β†’ D",
+ );
+ FieldSection.get()
+ .findByRole("link", { name: "Json: Json β†’ D" })
+ .should("be.visible")
+ .click();
+
+ FieldSection.getNameInput().should("have.value", "Json β†’ D");
+
+ FieldSection.get().should(
+ "contain.text",
+ "There are other fields with this semantic type: Text",
+ );
+ FieldSection.get()
+ .findByRole("link", { name: "Text" })
+ .should("be.visible")
+ .click();
+
+ FieldSection.getNameInput().should("have.value", "Text");
+ },
);
-
- cy.log("object detail viz");
- cy.findByTestId("table-body")
- .findAllByTestId("cell-data")
- .eq(0)
- .click();
- H.modal().findByText("Tax").should("be.visible");
- H.modal().findByText("2.07").should("be.visible");
});
+ });
- it(
- "should be able to select and update a field in a database without schemas",
- { tags: ["@external"] },
- () => {
- H.restore("mysql-8");
+ describe("Behavior", () => {
+ describe("Visibility", () => {
+ it("should let you change field visibility to 'Everywhere'", () => {
+ cy.request("PUT", `/api/field/${ORDERS.TAX}`, {
+ visibility_type: "sensitive",
+ });
visit({
- databaseId: MYSQL_DB_ID,
- schemaId: MYSQL_DB_SCHEMA_ID,
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
});
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
+ FieldSection.getVisibilityInput()
+ .should("have.value", "Do not include")
+ .click();
+ H.popover().findByText("Everywhere").click();
+ cy.wait("@updateField");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "visibility_change",
+ triggered_from: getTriggeredFrom(),
+ });
+ verifyAndCloseToast("Visibility of Tax updated");
+ FieldSection.getVisibilityInput().should(
+ "have.value",
+ "Everywhere",
+ );
+
+ cy.log("verify preview");
TableSection.clickField("Tax");
- FieldSection.getVisibilityInput().click();
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Tax",
+ values: ["2.07", "6.1", "2.9", "6.01", "7.03"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Tax", "2.07"],
+ });
+
+ cy.log("table viz");
+ H.openOrdersTable();
+ H.tableHeaderColumn("Total").should("be.visible");
+ H.tableHeaderColumn("Tax").should("be.visible");
+
+ cy.log("object detail viz");
+ cy.findByTestId("table-body")
+ .findAllByTestId("cell-data")
+ .eq(0)
+ .click();
+ H.modal().findByText("Tax").should("be.visible");
+ H.modal().findByText("2.07").should("be.visible");
+ });
+
+ it("should let you change field visibility to 'Do not include'", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
+ });
+
+ FieldSection.getVisibilityInput()
+ .should("have.value", "Everywhere")
+ .click();
H.popover().findByText("Do not include").click();
cy.wait("@updateField");
verifyAndCloseToast("Visibility of Tax updated");
@@ -852,111 +730,243 @@ describe.each<Area>(areas)("data model > %s", (area: Area) => {
"have.value",
"Do not include",
);
- },
- );
- });
- describe("Filtering", () => {
- it("should let you change filtering to 'Search box'", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
+ cy.log("verify preview");
+ TableSection.clickField("Tax");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.get()
+ .findByText("This field is hidden")
+ .should("exist");
+ cy.get("@dataset.all").should("have.length", 0);
+ PreviewSection.getPreviewTypeInput().findByText("Detail").click();
+ cy.wait("@dataset");
+ PreviewSection.get().findByText("Tax").should("not.exist");
+
+ cy.log("table viz");
+ H.openOrdersTable();
+ H.tableHeaderColumn("Total").should("be.visible");
+ H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
+ "not.exist",
+ );
- FieldSection.getFilteringInput()
- .should("have.value", "A list of all values")
- .click();
- H.popover().findByText("Search box").click();
- cy.wait("@updateField");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "filtering_change",
- triggered_from: getTriggeredFrom(),
+ cy.log("object detail viz");
+ cy.findByTestId("table-body")
+ .findAllByTestId("cell-data")
+ .eq(0)
+ .click();
+ H.modal().findByText("Tax").should("not.exist");
+ H.modal().findByText("2.07").should("not.exist");
});
- verifyAndCloseToast("Filtering of Quantity updated");
- cy.log("verify preview");
- TableSection.clickField("Quantity");
- FieldSection.getPreviewButton().click();
- PreviewSection.getPreviewTypeInput().findByText("Filtering").click();
- PreviewSection.get().within(() => {
- cy.findByPlaceholderText("Enter a number").should("be.visible");
- cy.button(/Add filter/).should("not.exist");
- });
+ it("should let you change field visibility to 'Do not include' even if Preview is opened (metabase#61806)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
+ });
- cy.reload();
- FieldSection.getFilteringInput()
- .scrollIntoView()
- .should("be.visible")
- .and("have.value", "Search box");
- });
+ TableSection.clickField("Tax");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.get().within(() => {
+ cy.findByText("Filtering").click();
- it("should let you change filtering to 'Plain input box'", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
+ cy.findByTestId("number-filter-picker").should("be.visible");
+ });
- FieldSection.getFilteringInput()
- .should("have.value", "A list of all values")
- .click();
- H.popover().findByText("Plain input box").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Filtering of Quantity updated");
+ FieldSection.getVisibilityInput()
+ .should("have.value", "Everywhere")
+ .click();
+ H.popover().findByText("Do not include").click();
+ cy.wait("@updateField");
- cy.log("verify preview");
- TableSection.clickField("Quantity");
- FieldSection.getPreviewButton().click();
- PreviewSection.getPreviewTypeInput().findByText("Filtering").click();
- PreviewSection.get().within(() => {
- cy.findByPlaceholderText("Min").should("be.visible");
- cy.findByPlaceholderText("Max").should("be.visible");
- cy.button(/Add filter/).should("not.exist");
+ PreviewSection.get()
+ .findByText("This field is hidden")
+ .should("exist");
});
- cy.reload();
- FieldSection.getFilteringInput()
- .scrollIntoView()
- .should("be.visible")
- .and("have.value", "Plain input box");
+ it("should let you change field visibility to 'Only in detail views'", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.TAX,
+ });
+
+ FieldSection.getVisibilityInput()
+ .should("have.value", "Everywhere")
+ .click();
+ H.popover().findByText("Only in detail views").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Visibility of Tax updated");
+ FieldSection.getVisibilityInput().should(
+ "have.value",
+ "Only in detail views",
+ );
+
+ cy.log("verify preview");
+ TableSection.clickField("Tax");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.get()
+ .findByText("This field is hidden")
+ .should("exist");
+ cy.get("@dataset.all").should("have.length", 0);
+ verifyObjectDetailPreview({
+ rowNumber: 4,
+ row: ["Tax", "2.07"],
+ });
+
+ cy.log("table viz");
+ H.openOrdersTable();
+ H.tableHeaderColumn("Total").should("be.visible");
+ H.tableHeaderColumn("Tax", { scrollIntoView: false }).should(
+ "not.exist",
+ );
+
+ cy.log("object detail viz");
+ cy.findByTestId("table-body")
+ .findAllByTestId("cell-data")
+ .eq(0)
+ .click();
+ H.modal().findByText("Tax").should("be.visible");
+ H.modal().findByText("2.07").should("be.visible");
+ });
+
+ it(
+ "should be able to select and update a field in a database without schemas",
+ { tags: ["@external"] },
+ () => {
+ H.restore("mysql-8");
+ visit({
+ databaseId: MYSQL_DB_ID,
+ schemaId: MYSQL_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ });
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Tax");
+ FieldSection.getVisibilityInput().click();
+ H.popover().findByText("Do not include").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Visibility of Tax updated");
+ FieldSection.getVisibilityInput().should(
+ "have.value",
+ "Do not include",
+ );
+ },
+ );
});
- it("should let you change filtering to 'A list of all values'", () => {
- cy.request("PUT", `/api/field/${ORDERS.QUANTITY}`, {
- has_field_values: "none",
- });
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
+ describe("Filtering", () => {
+ it("should let you change filtering to 'Search box'", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+
+ FieldSection.getFilteringInput()
+ .should("have.value", "A list of all values")
+ .click();
+ H.popover().findByText("Search box").click();
+ cy.wait("@updateField");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "filtering_change",
+ triggered_from: getTriggeredFrom(),
+ });
+ verifyAndCloseToast("Filtering of Quantity updated");
+
+ cy.log("verify preview");
+ TableSection.clickField("Quantity");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.getPreviewTypeInput()
+ .findByText("Filtering")
+ .click();
+ PreviewSection.get().within(() => {
+ cy.findByPlaceholderText("Enter a number").should("be.visible");
+ cy.button(/Add filter/).should("not.exist");
+ });
+
+ cy.reload();
+ FieldSection.getFilteringInput()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.value", "Search box");
});
- FieldSection.getFilteringInput()
- .should("have.value", "Plain input box")
- .click();
- H.popover().findByText("A list of all values").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Filtering of Quantity updated");
+ it("should let you change filtering to 'Plain input box'", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
- cy.log("verify preview");
- TableSection.clickField("Quantity");
- FieldSection.getPreviewButton().click();
- PreviewSection.getPreviewTypeInput().findByText("Filtering").click();
- PreviewSection.get().within(() => {
- cy.findByPlaceholderText("Search the list").should("be.visible");
- cy.button(/Add filter/).should("not.exist");
+ FieldSection.getFilteringInput()
+ .should("have.value", "A list of all values")
+ .click();
+ H.popover().findByText("Plain input box").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Filtering of Quantity updated");
+
+ cy.log("verify preview");
+ TableSection.clickField("Quantity");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.getPreviewTypeInput()
+ .findByText("Filtering")
+ .click();
+ PreviewSection.get().within(() => {
+ cy.findByPlaceholderText("Min").should("be.visible");
+ cy.findByPlaceholderText("Max").should("be.visible");
+ cy.button(/Add filter/).should("not.exist");
+ });
+
+ cy.reload();
+ FieldSection.getFilteringInput()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.value", "Plain input box");
});
- cy.reload();
- FieldSection.getFilteringInput()
- .scrollIntoView()
- .should("be.visible")
- .and("have.value", "A list of all values");
+ it("should let you change filtering to 'A list of all values'", () => {
+ cy.request("PUT", `/api/field/${ORDERS.QUANTITY}`, {
+ has_field_values: "none",
+ });
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+
+ FieldSection.getFilteringInput()
+ .should("have.value", "Plain input box")
+ .click();
+ H.popover().findByText("A list of all values").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Filtering of Quantity updated");
+
+ cy.log("verify preview");
+ TableSection.clickField("Quantity");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.getPreviewTypeInput()
+ .findByText("Filtering")
+ .click();
+ PreviewSection.get().within(() => {
+ cy.findByPlaceholderText("Search the list").should("be.visible");
+ cy.button(/Add filter/).should("not.exist");
+ });
+
+ cy.reload();
+ FieldSection.getFilteringInput()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.value", "A list of all values");
+ });
});
});
});
diff --git a/e2e/test/scenarios/data-model/data-model-shared-3.cy.spec.ts b/e2e/test/scenarios/data-model/data-model-shared-3.cy.spec.ts
index e57632961a3..41c55eb9bc8 100644
--- a/e2e/test/scenarios/data-model/data-model-shared-3.cy.spec.ts
+++ b/e2e/test/scenarios/data-model/data-model-shared-3.cy.spec.ts
@@ -20,776 +20,779 @@ const { ORDERS_ID, ORDERS, PRODUCTS, PRODUCTS_ID, REVIEWS, REVIEWS_ID } =
SAMPLE_DATABASE;
const areas: ("admin" | "data studio")[] = ["admin", "data studio"];
-type Area = (typeof areas)[number];
-
-describe.each<Area>(areas)("data model > %s", (area: Area) => {
- const visit = visitArea(area);
- const getTriggeredFrom = getTriggeredFromArea(area);
-
- beforeEach(() => {
- H.restore();
- H.resetSnowplow();
- cy.signInAsAdmin();
- H.activateToken("pro-self-hosted");
-
- cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
- cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
- cy.intercept("GET", "/api/database/*/schema/*").as("schema");
- cy.intercept("POST", "/api/dataset*").as("dataset");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
- "updateField",
- );
- cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
- cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
- cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
- cy.intercept("PUT", "/api/table").as("updateTables");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
-
- if (area === "admin") {
- cy.intercept("GET", "/api/database?*").as("databases");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
- }
- if (area === "data studio") {
- cy.intercept("GET", "/api/database").as("databases");
- }
- });
+areas.forEach((area) => {
+ describe(`data model > ${area}`, () => {
+ const visit = visitArea(area);
+ const getTriggeredFrom = getTriggeredFromArea(area);
- describe("Field section", () => {
beforeEach(() => {
+ H.restore();
H.resetSnowplow();
- H.enableTracking();
- });
+ cy.signInAsAdmin();
+ H.activateToken("pro-self-hosted");
+
+ cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
+ cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
+ cy.intercept("GET", "/api/database/*/schema/*").as("schema");
+ cy.intercept("POST", "/api/dataset*").as("dataset");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
+ "updateField",
+ );
+ cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
+ cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
+ cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
+ cy.intercept("PUT", "/api/table").as("updateTables");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
+
+ if (area === "admin") {
+ cy.intercept("GET", "/api/database?*").as("databases");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
+ }
- afterEach(() => {
- H.expectNoBadSnowplowEvents();
+ if (area === "data studio") {
+ cy.intercept("GET", "/api/database").as("databases");
+ }
});
- describe("Behavior", () => {
- describe("Display values", () => {
- it("should show tooltips explaining why remapping options are disabled", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: PRODUCTS_ID,
- fieldId: PRODUCTS.TITLE,
- });
+ describe("Field section", () => {
+ beforeEach(() => {
+ H.resetSnowplow();
+ H.enableTracking();
+ });
+
+ afterEach(() => {
+ H.expectNoBadSnowplowEvents();
+ });
- FieldSection.getDisplayValuesInput().click();
+ describe("Behavior", () => {
+ describe("Display values", () => {
+ it("should show tooltips explaining why remapping options are disabled", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: PRODUCTS_ID,
+ fieldId: PRODUCTS.TITLE,
+ });
- cy.log("foreign key mapping");
- H.popover().within(() => {
- cy.findByRole("option", { name: /Use foreign key/ }).should(
- "have.attr",
- "data-combobox-disabled",
- "true",
+ FieldSection.getDisplayValuesInput().click();
+
+ cy.log("foreign key mapping");
+ H.popover().within(() => {
+ cy.findByRole("option", { name: /Use foreign key/ }).should(
+ "have.attr",
+ "data-combobox-disabled",
+ "true",
+ );
+ cy.findByRole("option", { name: /Use foreign key/ })
+ .icon("info")
+ .realHover();
+ });
+ H.tooltip().should(
+ "contain.text",
+ 'You can only use foreign key mapping for fields with the semantic type set to "Foreign Key"',
);
- cy.findByRole("option", { name: /Use foreign key/ })
- .icon("info")
- .realHover();
- });
- H.tooltip().should(
- "contain.text",
- 'You can only use foreign key mapping for fields with the semantic type set to "Foreign Key"',
- );
-
- cy.log("custom mapping");
- H.popover().within(() => {
- cy.findByRole("option", { name: /Custom mapping/ }).should(
- "have.attr",
- "data-combobox-disabled",
- "true",
+
+ cy.log("custom mapping");
+ H.popover().within(() => {
+ cy.findByRole("option", { name: /Custom mapping/ }).should(
+ "have.attr",
+ "data-combobox-disabled",
+ "true",
+ );
+ cy.findByRole("option", { name: /Custom mapping/ })
+ .icon("info")
+ .realHover();
+ });
+ H.tooltip().should(
+ "contain.text",
+ 'You can only use custom mapping for numerical fields with filtering set to "A list of all values"',
);
- cy.findByRole("option", { name: /Custom mapping/ })
- .icon("info")
- .realHover();
- });
- H.tooltip().should(
- "contain.text",
- 'You can only use custom mapping for numerical fields with filtering set to "A list of all values"',
- );
-
- cy.log("clicking disabled option does not change the value");
- cy.findByRole("option", { name: /Custom mapping/ }).click({
- force: true, // try to click it despite pointer-events: none
- });
- FieldSection.getDisplayValuesInput().should(
- "have.value",
- "Use original value",
- );
- });
- it("should let you change to 'Use foreign key' and change the target for field with fk", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.PRODUCT_ID,
+ cy.log("clicking disabled option does not change the value");
+ cy.findByRole("option", { name: /Custom mapping/ }).click({
+ force: true, // try to click it despite pointer-events: none
+ });
+ FieldSection.getDisplayValuesInput().should(
+ "have.value",
+ "Use original value",
+ );
});
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Product ID",
- values: ["14", "123", "105", "94", "132"],
- });
- verifyObjectDetailPreview({
- rowNumber: 2,
- row: ["Product ID", "14"],
- });
+ it("should let you change to 'Use foreign key' and change the target for field with fk", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.PRODUCT_ID,
+ });
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Use foreign key").click();
- H.popover().findByText("Title").click();
- cy.wait("@updateFieldDimension");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "display_values",
- triggered_from: getTriggeredFrom(),
- });
- H.undoToast().should(
- "contain.text",
- "Display values of Product ID updated",
- );
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Product ID",
+ values: ["14", "123", "105", "94", "132"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 2,
+ row: ["Product ID", "14"],
+ });
- cy.log("verify preview");
- verifyObjectDetailPreview({
- rowNumber: 2,
- row: ["Product ID", "Awesome Concrete Shoes"],
- });
- verifyTablePreview({
- column: "Product ID",
- values: [
- "Awesome Concrete Shoes",
- "Mediocre Wooden Bench",
- "Fantastic Wool Shirt",
- "Awesome Bronze Plate",
- "Sleek Steel Table",
- ],
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Use foreign key").click();
+ H.popover().findByText("Title").click();
+ cy.wait("@updateFieldDimension");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "display_values",
+ triggered_from: getTriggeredFrom(),
+ });
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Product ID updated",
+ );
+
+ cy.log("verify preview");
+ verifyObjectDetailPreview({
+ rowNumber: 2,
+ row: ["Product ID", "Awesome Concrete Shoes"],
+ });
+ verifyTablePreview({
+ column: "Product ID",
+ values: [
+ "Awesome Concrete Shoes",
+ "Mediocre Wooden Bench",
+ "Fantastic Wool Shirt",
+ "Awesome Bronze Plate",
+ "Sleek Steel Table",
+ ],
+ });
+
+ cy.reload();
+ FieldSection.getDisplayValuesInput()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.value", "Use foreign key");
+ FieldSection.getDisplayValuesFkTargetInput()
+ .should("be.visible")
+ .and("have.value", "Title");
});
- cy.reload();
- FieldSection.getDisplayValuesInput()
- .scrollIntoView()
- .should("be.visible")
- .and("have.value", "Use foreign key");
- FieldSection.getDisplayValuesFkTargetInput()
- .should("be.visible")
- .and("have.value", "Title");
- });
+ it("should allow 'Custom mapping' null values", () => {
+ const remappedNullValue = "nothin";
+
+ cy.signInAsAdmin();
+ H.addSqliteDatabase();
+
+ cy.get<number>("@sqliteID").then((databaseId) => {
+ H.withDatabase(
+ databaseId,
+ ({ NUMBER_WITH_NULLS: { NUM }, NUMBER_WITH_NULLS_ID }) => {
+ cy.request("GET", `/api/database/${databaseId}/schemas`).then(
+ ({ body }) => {
+ const [schemaName] = body;
+
+ visit({
+ databaseId,
+ schemaId: `${databaseId}:${schemaName}`,
+ tableId: NUMBER_WITH_NULLS_ID,
+ fieldId: NUM,
+ });
+ },
+ );
+
+ cy.log("Change `null` to custom mapping");
+ FieldSection.getDisplayValuesInput().scrollIntoView().click();
+ H.popover().findByText("Custom mapping").click();
+ cy.wait("@updateFieldValues");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "display_values",
+ triggered_from: getTriggeredFrom(),
+ });
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Num updated",
+ );
+ H.undoToast().icon("close").click({
+ force: true, // it's behind a modal
+ });
- it("should allow 'Custom mapping' null values", () => {
- const remappedNullValue = "nothin";
-
- cy.signInAsAdmin();
- H.addSqliteDatabase();
-
- cy.get<number>("@sqliteID").then((databaseId) => {
- H.withDatabase(
- databaseId,
- ({ NUMBER_WITH_NULLS: { NUM }, NUMBER_WITH_NULLS_ID }) => {
- cy.request("GET", `/api/database/${databaseId}/schemas`).then(
- ({ body }) => {
- const [schemaName] = body;
-
- visit({
- databaseId,
- schemaId: `${databaseId}:${schemaName}`,
- tableId: NUMBER_WITH_NULLS_ID,
- fieldId: NUM,
+ H.modal()
+ .should("be.visible")
+ .within(() => {
+ cy.findAllByPlaceholderText("Enter value")
+ .filter("[value='null']")
+ .clear()
+ .type(remappedNullValue);
+ cy.button("Save").click();
});
- },
- );
-
- cy.log("Change `null` to custom mapping");
- FieldSection.getDisplayValuesInput().scrollIntoView().click();
- H.popover().findByText("Custom mapping").click();
- cy.wait("@updateFieldValues");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "display_values",
- triggered_from: getTriggeredFrom(),
- });
- H.undoToast().should(
- "contain.text",
- "Display values of Num updated",
- );
- H.undoToast().icon("close").click({
- force: true, // it's behind a modal
- });
-
- H.modal()
- .should("be.visible")
- .within(() => {
- cy.findAllByPlaceholderText("Enter value")
- .filter("[value='null']")
- .clear()
- .type(remappedNullValue);
- cy.button("Save").click();
+ cy.wait("@updateFieldValues");
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Num updated",
+ );
+
+ cy.log("Make sure custom mapping appears in QB");
+ H.openTable({
+ database: databaseId,
+ table: NUMBER_WITH_NULLS_ID,
});
- cy.wait("@updateFieldValues");
- H.undoToast().should(
- "contain.text",
- "Display values of Num updated",
- );
-
- cy.log("Make sure custom mapping appears in QB");
- H.openTable({
- database: databaseId,
- table: NUMBER_WITH_NULLS_ID,
- });
- cy.findAllByRole("gridcell", {
- name: remappedNullValue,
- }).should("be.visible");
- },
- );
+ cy.findAllByRole("gridcell", {
+ name: remappedNullValue,
+ }).should("be.visible");
+ },
+ );
+ });
});
- });
- it("should correctly show remapped column value", () => {
- visit({ databaseId: SAMPLE_DB_ID });
-
- // edit "Product ID" column in "Orders" table
- TablePicker.getTable("Orders").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Product ID");
-
- // remap its original value to use foreign key
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Use foreign key").click();
- H.popover().findByText("Title").click();
- cy.wait("@updateFieldDimension");
- H.undoToast().should(
- "contain.text",
- "Display values of Product ID updated",
- );
+ it("should correctly show remapped column value", () => {
+ visit({ databaseId: SAMPLE_DB_ID });
+
+ // edit "Product ID" column in "Orders" table
+ TablePicker.getTable("Orders").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Product ID");
+
+ // remap its original value to use foreign key
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Use foreign key").click();
+ H.popover().findByText("Title").click();
+ cy.wait("@updateFieldDimension");
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Product ID updated",
+ );
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyObjectDetailPreview({
- rowNumber: 2,
- row: ["Product ID", "Awesome Concrete Shoes"],
- });
- verifyTablePreview({
- column: "Product ID",
- values: [
- "Awesome Concrete Shoes",
- "Mediocre Wooden Bench",
- "Fantastic Wool Shirt",
- "Awesome Bronze Plate",
- "Sleek Steel Table",
- ],
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyObjectDetailPreview({
+ rowNumber: 2,
+ row: ["Product ID", "Awesome Concrete Shoes"],
+ });
+ verifyTablePreview({
+ column: "Product ID",
+ values: [
+ "Awesome Concrete Shoes",
+ "Mediocre Wooden Bench",
+ "Fantastic Wool Shirt",
+ "Awesome Bronze Plate",
+ "Sleek Steel Table",
+ ],
+ });
+
+ FieldSection.get()
+ .findByText(
+ "You might want to update the field name to make sure it still makes sense based on your remapping choices.",
+ )
+ .scrollIntoView()
+ .should("be.visible");
+
+ cy.log("Name of the product should be displayed instead of its ID");
+ H.openOrdersTable();
+ cy.findByRole("gridcell", {
+ name: "Awesome Concrete Shoes",
+ }).should("be.visible");
});
- FieldSection.get()
- .findByText(
- "You might want to update the field name to make sure it still makes sense based on your remapping choices.",
- )
- .scrollIntoView()
- .should("be.visible");
+ it("should correctly apply and display custom remapping for numeric values", () => {
+ // this test also indirectly reproduces metabase#12771
+ const customMap = {
+ 1: "Awful",
+ 2: "Unpleasant",
+ 3: "Meh",
+ 4: "Enjoyable",
+ 5: "Perfecto",
+ };
+
+ visit({ databaseId: SAMPLE_DB_ID });
+ // edit "Rating" values in "Reviews" table
+ TablePicker.getTable("Reviews").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Rating");
+
+ // apply custom remapping for "Rating" values 1-5
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Custom mapping").click();
+ cy.wait("@updateFieldValues");
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Rating updated",
+ );
+ H.undoToast().icon("close").click({
+ force: true, // it's behind a modal
+ });
+ H.modal().within(() => {
+ cy.findByText(
+ "You might want to update the field name to make sure it still makes sense based on your remapping choices.",
+ ).should("be.visible");
- cy.log("Name of the product should be displayed instead of its ID");
- H.openOrdersTable();
- cy.findByRole("gridcell", {
- name: "Awesome Concrete Shoes",
- }).should("be.visible");
- });
+ Object.entries(customMap).forEach(([key, value]) => {
+ cy.findByDisplayValue(key).click().clear().type(value);
+ });
- it("should correctly apply and display custom remapping for numeric values", () => {
- // this test also indirectly reproduces metabase#12771
- const customMap = {
- 1: "Awful",
- 2: "Unpleasant",
- 3: "Meh",
- 4: "Enjoyable",
- 5: "Perfecto",
- };
-
- visit({ databaseId: SAMPLE_DB_ID });
- // edit "Rating" values in "Reviews" table
- TablePicker.getTable("Reviews").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Rating");
-
- // apply custom remapping for "Rating" values 1-5
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Custom mapping").click();
- cy.wait("@updateFieldValues");
- H.undoToast().should(
- "contain.text",
- "Display values of Rating updated",
- );
- H.undoToast().icon("close").click({
- force: true, // it's behind a modal
- });
- H.modal().within(() => {
- cy.findByText(
- "You might want to update the field name to make sure it still makes sense based on your remapping choices.",
- ).should("be.visible");
+ cy.button("Save").click();
+ });
+ cy.wait("@updateFieldValues");
+ cy.wait("@updateFieldDimension");
+ H.undoToast().should(
+ "contain.text",
+ "Display values of Rating updated",
+ );
- Object.entries(customMap).forEach(([key, value]) => {
- cy.findByDisplayValue(key).click().clear().type(value);
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Rating",
+ values: [
+ "Perfecto",
+ "Enjoyable",
+ "Perfecto",
+ "Enjoyable",
+ "Perfecto",
+ ],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 3,
+ row: ["Rating", "Perfecto"],
});
- cy.button("Save").click();
+ cy.log("Numeric ratings should be remapped to custom strings");
+ H.openReviewsTable();
+ Object.values(customMap).forEach((rating) => {
+ cy.findAllByText(rating)
+ .eq(0)
+ .scrollIntoView()
+ .should("be.visible");
+ });
});
- cy.wait("@updateFieldValues");
- cy.wait("@updateFieldDimension");
- H.undoToast().should(
- "contain.text",
- "Display values of Rating updated",
- );
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Rating",
- values: [
- "Perfecto",
- "Enjoyable",
- "Perfecto",
- "Enjoyable",
- "Perfecto",
- ],
- });
- verifyObjectDetailPreview({
- rowNumber: 3,
- row: ["Rating", "Perfecto"],
- });
+ it("should allow 'Custom mapping' option only for 'Search box' filtering type (metabase#16322)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: REVIEWS_ID,
+ fieldId: REVIEWS.RATING,
+ });
- cy.log("Numeric ratings should be remapped to custom strings");
- H.openReviewsTable();
- Object.values(customMap).forEach((rating) => {
- cy.findAllByText(rating)
- .eq(0)
- .scrollIntoView()
- .should("be.visible");
+ FieldSection.getFilteringInput().click();
+ H.popover().findByText("Search box").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Filtering of Rating updated");
+
+ FieldSection.getDisplayValuesInput().click();
+ H.popover()
+ .findByRole("option", { name: /Custom mapping/ })
+ .should("have.attr", "data-combobox-disabled", "true");
+ H.popover()
+ .findByRole("option", { name: /Custom mapping/ })
+ .icon("info")
+ .realHover();
+ H.tooltip()
+ .should("be.visible")
+ .and(
+ "have.text",
+ 'You can only use custom mapping for numerical fields with filtering set to "A list of all values"',
+ );
+
+ cy.log("close popover by clicking on element inside panel");
+ FieldSection.get().findByText("Field settings").click();
+
+ cy.log("open popover");
+ FieldSection.getFilteringInput().click();
+ H.popover().findByText("A list of all values").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Filtering of Rating updated");
+
+ FieldSection.getDisplayValuesInput().click();
+ H.popover()
+ .findByRole("option", { name: /Custom mapping/ })
+ .should("not.have.attr", "data-combobox-disabled");
});
- });
- it("should allow 'Custom mapping' option only for 'Search box' filtering type (metabase#16322)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: REVIEWS_ID,
- fieldId: REVIEWS.RATING,
- });
+ it("should allow to map FK to date fields (metabase#7108)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.USER_ID,
+ });
- FieldSection.getFilteringInput().click();
- H.popover().findByText("Search box").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Filtering of Rating updated");
-
- FieldSection.getDisplayValuesInput().click();
- H.popover()
- .findByRole("option", { name: /Custom mapping/ })
- .should("have.attr", "data-combobox-disabled", "true");
- H.popover()
- .findByRole("option", { name: /Custom mapping/ })
- .icon("info")
- .realHover();
- H.tooltip()
- .should("be.visible")
- .and(
- "have.text",
- 'You can only use custom mapping for numerical fields with filtering set to "A list of all values"',
- );
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Use foreign key").click();
+ cy.wait("@updateFieldDimension");
+ verifyAndCloseToast("Display values of User ID updated");
- cy.log("close popover by clicking on element inside panel");
- FieldSection.get().findByText("Field settings").click();
+ FieldSection.getDisplayValuesFkTargetInput().click();
- cy.log("open popover");
- FieldSection.getFilteringInput().click();
- H.popover().findByText("A list of all values").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Filtering of Rating updated");
+ H.popover().within(() => {
+ cy.findByText("Birth Date").scrollIntoView().should("be.visible");
+ cy.findByText("Created At")
+ .scrollIntoView()
+ .should("be.visible")
+ .click();
+ });
+ cy.wait("@updateFieldDimension");
+ H.undoToast().should(
+ "contain.text",
+ "Display values of User ID updated",
+ );
+
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "User ID",
+ values: [
+ "2026-10-07T01:34:35.462-07:00",
+ "2026-10-07T01:34:35.462-07:00",
+ "2026-10-07T01:34:35.462-07:00",
+ "2026-10-07T01:34:35.462-07:00",
+ "2026-10-07T01:34:35.462-07:00",
+ ],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 1,
+ row: ["User ID", "2026-10-07T01:34:35.462-07:00"],
+ });
- FieldSection.getDisplayValuesInput().click();
- H.popover()
- .findByRole("option", { name: /Custom mapping/ })
- .should("not.have.attr", "data-combobox-disabled");
+ H.visitQuestion(ORDERS_QUESTION_ID);
+ cy.findAllByTestId("cell-data")
+ .eq(10) // 1st data row, 2nd column (User ID)
+ .should("have.text", "2026-10-07T01:34:35.462-07:00");
+ });
});
- it("should allow to map FK to date fields (metabase#7108)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.USER_ID,
+ describe("Unfold JSON", { tags: "@external" }, () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_data_types" });
+ cy.signInAsAdmin();
+ H.resyncDatabase({
+ dbId: WRITABLE_DB_ID,
+ tableName: "many_data_types",
+ });
+ cy.intercept(
+ "POST",
+ `/api/database/${WRITABLE_DB_ID}/sync_schema`,
+ ).as("sync_schema");
});
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Use foreign key").click();
- cy.wait("@updateFieldDimension");
- verifyAndCloseToast("Display values of User ID updated");
+ it("should let you enable/disable 'Unfold JSON' for JSON columns", () => {
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
- FieldSection.getDisplayValuesFkTargetInput().click();
+ cy.log("json is unfolded initially and shows prefix");
+ TableSection.getField("Json β†’ A")
+ .scrollIntoView()
+ .should("be.visible");
+ TableSection.getField("Json β†’ A")
+ .findByTestId("name-prefix")
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.text", "Json:");
- H.popover().within(() => {
- cy.findByText("Birth Date").scrollIntoView().should("be.visible");
- cy.findByText("Created At")
+ cy.log("shows prefix in field section");
+ TableSection.clickField("Json β†’ A");
+ FieldSection.get()
+ .findByTestId("name-prefix")
.scrollIntoView()
.should("be.visible")
- .click();
- });
- cy.wait("@updateFieldDimension");
- H.undoToast().should(
- "contain.text",
- "Display values of User ID updated",
- );
+ .and("have.text", "Json:");
+ FieldSection.getRawName()
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.text", "json.a");
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "User ID",
- values: [
- "2026-10-07T01:34:35.462-07:00",
- "2026-10-07T01:34:35.462-07:00",
- "2026-10-07T01:34:35.462-07:00",
- "2026-10-07T01:34:35.462-07:00",
- "2026-10-07T01:34:35.462-07:00",
- ],
- });
- verifyObjectDetailPreview({
- rowNumber: 1,
- row: ["User ID", "2026-10-07T01:34:35.462-07:00"],
- });
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Json β†’ A",
+ values: ["10", "10"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 1,
+ row: ["Json β†’ A", "10"],
+ });
- H.visitQuestion(ORDERS_QUESTION_ID);
- cy.findAllByTestId("cell-data")
- .eq(10) // 1st data row, 2nd column (User ID)
- .should("have.text", "2026-10-07T01:34:35.462-07:00");
- });
- });
+ cy.log("show prefix in table section when sorting");
+ TableSection.getSortButton().click();
+ TableSection.getField("Json β†’ A")
+ .findByTestId("name-prefix")
+ .should("be.visible")
+ .and("have.text", "Json:");
+ TableSection.get().button("Done").click();
+ TableSection.clickField("Json");
+
+ FieldSection.getUnfoldJsonInput()
+ .should("have.value", "Yes")
+ .click();
+ H.popover().findByText("No").click();
+ cy.wait("@updateField");
+ H.expectUnstructuredSnowplowEvent({
+ event: "metadata_edited",
+ event_detail: "json_unfolding",
+ triggered_from: getTriggeredFrom(),
+ });
+ H.undoToast().should(
+ "contain.text",
+ "JSON unfolding disabled for Json",
+ );
- describe("Unfold JSON", { tags: "@external" }, () => {
- beforeEach(() => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "many_data_types" });
- cy.signInAsAdmin();
- H.resyncDatabase({
- dbId: WRITABLE_DB_ID,
- tableName: "many_data_types",
+ // Check setting has persisted
+ cy.reload();
+ FieldSection.getUnfoldJsonInput().should("have.value", "No");
+
+ // Sync database
+ cy.visit(`/admin/databases/${WRITABLE_DB_ID}`);
+ cy.button("Sync database schema").click();
+ cy.wait("@sync_schema");
+ cy.button(/Sync triggered!/).should("be.visible");
+
+ // Check json field is not unfolded
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.getField("Json β†’ A").should("not.exist");
});
- cy.intercept(
- "POST",
- `/api/database/${WRITABLE_DB_ID}/sync_schema`,
- ).as("sync_schema");
- });
- it("should let you enable/disable 'Unfold JSON' for JSON columns", () => {
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
+ it("should let you change the name of JSON-unfolded columns (metabase#55563)", () => {
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Json β†’ A");
- cy.log("json is unfolded initially and shows prefix");
- TableSection.getField("Json β†’ A")
- .scrollIntoView()
- .should("be.visible");
- TableSection.getField("Json β†’ A")
- .findByTestId("name-prefix")
- .scrollIntoView()
- .should("be.visible")
- .and("have.text", "Json:");
+ TableSection.getFieldNameInput("Json β†’ A").clear().type("A").blur();
+ FieldSection.getPreviewButton().click();
- cy.log("shows prefix in field section");
- TableSection.clickField("Json β†’ A");
- FieldSection.get()
- .findByTestId("name-prefix")
- .scrollIntoView()
- .should("be.visible")
- .and("have.text", "Json:");
- FieldSection.getRawName()
- .scrollIntoView()
- .should("be.visible")
- .and("have.text", "json.a");
+ FieldSection.getNameInput().should("have.value", "A");
+ FieldSection.get()
+ .findByTestId("name-prefix")
+ .scrollIntoView()
+ .should("be.visible")
+ .and("have.text", "Json:");
+ verifyTablePreview({
+ column: "A",
+ values: ["10", "10"],
+ });
+ });
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Json β†’ A",
- values: ["10", "10"],
+ it("should smartly truncate prefix name", () => {
+ const shortPrefix = "Short prefix";
+ const longPrefix = "Legendarily long column prefix";
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Json β†’ A");
+
+ cy.log("should not truncante short prefixes");
+ TableSection.getFieldNameInput("Json")
+ .clear()
+ .type(shortPrefix)
+ .blur();
+
+ cy.log("in field section");
+ FieldSection.get()
+ .findByTestId("name-prefix")
+ .should("have.text", `${shortPrefix}:`)
+ .then((element) => {
+ H.assertIsNotEllipsified(element[0]);
+ });
+ FieldSection.get().findByTestId("name-prefix").realHover();
+ H.tooltip().should("not.exist");
+
+ cy.log("in table section");
+ TableSection.getField("Json β†’ D")
+ .findByTestId("name-prefix")
+ .should("have.text", `${shortPrefix}:`)
+ .then((element) => {
+ H.assertIsNotEllipsified(element[0]);
+ });
+ TableSection.getField("Json β†’ D")
+ .findByTestId("name-prefix")
+ .realHover();
+ H.tooltip().should("not.exist");
+
+ cy.log("should truncante long prefixes");
+ TableSection.getFieldNameInput(shortPrefix)
+ .clear()
+ .type(longPrefix)
+ .blur();
+
+ cy.log("in field section");
+ FieldSection.get()
+ .findByTestId("name-prefix")
+ .should("have.text", `${longPrefix}:`)
+ .then((element) => {
+ H.assertIsEllipsified(element[0]);
+ });
+ FieldSection.get()
+ .findByTestId("name-prefix")
+ .realHover({ scrollBehavior: "center" });
+ H.tooltip().should("be.visible").and("have.text", longPrefix);
+
+ // hide tooltip
+ FieldSection.getDescriptionInput().realHover();
+ H.tooltip().should("not.exist");
+
+ cy.log("in table section");
+ TableSection.getField("Json β†’ D")
+ .scrollIntoView({ offset: { left: 0, top: -400 } })
+ .findByTestId("name-prefix")
+ .should("have.text", `${longPrefix}:`)
+ .realHover({ scrollBehavior: "center" });
+ H.tooltip().should("be.visible").and("have.text", longPrefix);
});
- verifyObjectDetailPreview({
- rowNumber: 1,
- row: ["Json β†’ A", "10"],
+ });
+ });
+
+ describe("Formatting", () => {
+ it("should let you to change field formatting", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
});
- cy.log("show prefix in table section when sorting");
- TableSection.getSortButton().click();
- TableSection.getField("Json β†’ A")
- .findByTestId("name-prefix")
- .should("be.visible")
- .and("have.text", "Json:");
- TableSection.get().button("Done").click();
- TableSection.clickField("Json");
-
- FieldSection.getUnfoldJsonInput().should("have.value", "Yes").click();
- H.popover().findByText("No").click();
+ FieldSection.getStyleInput().click();
+ H.popover().findByText("Percent").click();
cy.wait("@updateField");
H.expectUnstructuredSnowplowEvent({
event: "metadata_edited",
- event_detail: "json_unfolding",
+ event_detail: "formatting",
triggered_from: getTriggeredFrom(),
});
- H.undoToast().should(
- "contain.text",
- "JSON unfolding disabled for Json",
- );
-
- // Check setting has persisted
- cy.reload();
- FieldSection.getUnfoldJsonInput().should("have.value", "No");
-
- // Sync database
- cy.visit(`/admin/databases/${WRITABLE_DB_ID}`);
- cy.button("Sync database schema").click();
- cy.wait("@sync_schema");
- cy.button(/Sync triggered!/).should("be.visible");
-
- // Check json field is not unfolded
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.getField("Json β†’ A").should("not.exist");
- });
-
- it("should let you change the name of JSON-unfolded columns (metabase#55563)", () => {
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Json β†’ A");
+ verifyAndCloseToast("Formatting of Quantity updated");
- TableSection.getFieldNameInput("Json β†’ A").clear().type("A").blur();
+ cy.log("verify preview");
FieldSection.getPreviewButton().click();
-
- FieldSection.getNameInput().should("have.value", "A");
- FieldSection.get()
- .findByTestId("name-prefix")
- .scrollIntoView()
- .should("be.visible")
- .and("have.text", "Json:");
verifyTablePreview({
- column: "A",
- values: ["10", "10"],
+ column: "Quantity",
+ values: ["200%", "300%", "200%", "600%", "500%"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 8,
+ row: ["Quantity", "200%"],
});
});
- it("should smartly truncate prefix name", () => {
- const shortPrefix = "Short prefix";
- const longPrefix = "Legendarily long column prefix";
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Json β†’ A");
-
- cy.log("should not truncante short prefixes");
- TableSection.getFieldNameInput("Json")
- .clear()
- .type(shortPrefix)
- .blur();
-
- cy.log("in field section");
- FieldSection.get()
- .findByTestId("name-prefix")
- .should("have.text", `${shortPrefix}:`)
- .then((element) => {
- H.assertIsNotEllipsified(element[0]);
- });
- FieldSection.get().findByTestId("name-prefix").realHover();
- H.tooltip().should("not.exist");
-
- cy.log("in table section");
- TableSection.getField("Json β†’ D")
- .findByTestId("name-prefix")
- .should("have.text", `${shortPrefix}:`)
- .then((element) => {
- H.assertIsNotEllipsified(element[0]);
- });
- TableSection.getField("Json β†’ D")
- .findByTestId("name-prefix")
- .realHover();
- H.tooltip().should("not.exist");
-
- cy.log("should truncante long prefixes");
- TableSection.getFieldNameInput(shortPrefix)
- .clear()
- .type(longPrefix)
- .blur();
-
- cy.log("in field section");
- FieldSection.get()
- .findByTestId("name-prefix")
- .should("have.text", `${longPrefix}:`)
- .then((element) => {
- H.assertIsEllipsified(element[0]);
+ it("should only show currency formatting options for currency fields", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.DISCOUNT,
+ });
+ cy.wait("@metadata");
+
+ cy.findByTestId("column-settings")
+ .scrollIntoView()
+ .within(() => {
+ cy.findByText("Unit of currency").should("be.visible");
+ cy.findByText("Currency label style").should("be.visible");
});
- FieldSection.get()
- .findByTestId("name-prefix")
- .realHover({ scrollBehavior: "center" });
- H.tooltip().should("be.visible").and("have.text", longPrefix);
-
- // hide tooltip
- FieldSection.getDescriptionInput().realHover();
- H.tooltip().should("not.exist");
-
- cy.log("in table section");
- TableSection.getField("Json β†’ D")
- .scrollIntoView({ offset: { left: 0, top: -400 } })
- .findByTestId("name-prefix")
- .should("have.text", `${longPrefix}:`)
- .realHover({ scrollBehavior: "center" });
- H.tooltip().should("be.visible").and("have.text", longPrefix);
- });
- });
- });
- describe("Formatting", () => {
- it("should let you to change field formatting", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+ cy.wait("@metadata");
- FieldSection.getStyleInput().click();
- H.popover().findByText("Percent").click();
- cy.wait("@updateField");
- H.expectUnstructuredSnowplowEvent({
- event: "metadata_edited",
- event_detail: "formatting",
- triggered_from: getTriggeredFrom(),
- });
- verifyAndCloseToast("Formatting of Quantity updated");
+ cy.findByTestId("column-settings")
+ .scrollIntoView()
+ .within(() => {
+ // shouldnt show currency settings by default for quantity field
+ cy.findByText("Unit of currency").should("not.be.visible");
+ cy.findByText("Currency label style").should("not.be.visible");
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Quantity",
- values: ["200%", "300%", "200%", "600%", "500%"],
- });
- verifyObjectDetailPreview({
- rowNumber: 8,
- row: ["Quantity", "200%"],
- });
- });
+ cy.get("#number_style").click();
+ });
- it("should only show currency formatting options for currency fields", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.DISCOUNT,
- });
- cy.wait("@metadata");
+ // if you change the style to currency, currency settings should appear
+ H.popover().findByText("Currency").click();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Formatting of Quantity updated");
- cy.findByTestId("column-settings")
- .scrollIntoView()
- .within(() => {
+ cy.findByTestId("column-settings").within(() => {
cy.findByText("Unit of currency").should("be.visible");
cy.findByText("Currency label style").should("be.visible");
});
-
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
});
- cy.wait("@metadata");
-
- cy.findByTestId("column-settings")
- .scrollIntoView()
- .within(() => {
- // shouldnt show currency settings by default for quantity field
- cy.findByText("Unit of currency").should("not.be.visible");
- cy.findByText("Currency label style").should("not.be.visible");
- cy.get("#number_style").click();
+ it("should save and obey field prefix formatting settings", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
});
+ cy.wait("@metadata");
- // if you change the style to currency, currency settings should appear
- H.popover().findByText("Currency").click();
- cy.wait("@updateField");
- verifyAndCloseToast("Formatting of Quantity updated");
-
- cy.findByTestId("column-settings").within(() => {
- cy.findByText("Unit of currency").should("be.visible");
- cy.findByText("Currency label style").should("be.visible");
- });
- });
-
- it("should save and obey field prefix formatting settings", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
- cy.wait("@metadata");
-
- FieldSection.getPrefixInput().scrollIntoView().type("about ").blur();
- cy.wait("@updateField");
- verifyAndCloseToast("Formatting of Quantity updated");
+ FieldSection.getPrefixInput().scrollIntoView().type("about ").blur();
+ cy.wait("@updateField");
+ verifyAndCloseToast("Formatting of Quantity updated");
- cy.log("verify preview");
- FieldSection.getPreviewButton().click();
- verifyTablePreview({
- column: "Quantity",
- values: ["about 2", "about 3", "about 2", "about 6", "about 5"],
- });
- verifyObjectDetailPreview({
- rowNumber: 8,
- row: ["Quantity", "about 2"],
- });
+ cy.log("verify preview");
+ FieldSection.getPreviewButton().click();
+ verifyTablePreview({
+ column: "Quantity",
+ values: ["about 2", "about 3", "about 2", "about 6", "about 5"],
+ });
+ verifyObjectDetailPreview({
+ rowNumber: 8,
+ row: ["Quantity", "about 2"],
+ });
- cy.log("verify viz");
- H.visitQuestionAdhoc({
- dataset_query: {
- database: SAMPLE_DB_ID,
- query: {
- "source-table": ORDERS_ID,
- aggregation: [["sum", ["field", ORDERS.QUANTITY, null]]],
+ cy.log("verify viz");
+ H.visitQuestionAdhoc({
+ dataset_query: {
+ database: SAMPLE_DB_ID,
+ query: {
+ "source-table": ORDERS_ID,
+ aggregation: [["sum", ["field", ORDERS.QUANTITY, null]]],
+ },
+ type: "query",
},
- type: "query",
- },
+ });
+ cy.findByTestId("visualization-root")
+ .findByText("about 69,540")
+ .should("be.visible");
});
- cy.findByTestId("visualization-root")
- .findByText("about 69,540")
- .should("be.visible");
- });
- it("should not call PUT field endpoint when prefix or suffix has not been changed (SEM-359)", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
- cy.wait("@metadata");
+ it("should not call PUT field endpoint when prefix or suffix has not been changed (SEM-359)", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+ cy.wait("@metadata");
- FieldSection.getPrefixInput().focus().blur();
- cy.get("@updateFieldSpy").should("not.have.been.called");
- H.undoToast().should("not.exist");
+ FieldSection.getPrefixInput().focus().blur();
+ cy.get("@updateFieldSpy").should("not.have.been.called");
+ H.undoToast().should("not.exist");
- FieldSection.getSuffixInput().focus().blur();
- cy.get("@updateFieldSpy").should("not.have.been.called");
- H.undoToast().should("not.exist");
+ FieldSection.getSuffixInput().focus().blur();
+ cy.get("@updateFieldSpy").should("not.have.been.called");
+ H.undoToast().should("not.exist");
+ });
});
});
});
diff --git a/e2e/test/scenarios/data-model/data-model-shared-4.cy.spec.ts b/e2e/test/scenarios/data-model/data-model-shared-4.cy.spec.ts
index 3acd8d1f872..56aa2125633 100644
--- a/e2e/test/scenarios/data-model/data-model-shared-4.cy.spec.ts
+++ b/e2e/test/scenarios/data-model/data-model-shared-4.cy.spec.ts
@@ -13,440 +13,441 @@ const { ORDERS_ID, ORDERS } = SAMPLE_DATABASE;
const { visitArea } = Shared;
const areas: ("admin" | "data studio")[] = ["admin", "data studio"];
-type Area = (typeof areas)[number];
-
-describe.each<Area>(areas)("data model > %s", (area: Area) => {
- const visit = visitArea(area);
-
- beforeEach(() => {
- H.restore();
- H.resetSnowplow();
- cy.signInAsAdmin();
- H.activateToken("pro-self-hosted");
-
- cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
- cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
- cy.intercept("GET", "/api/database/*/schema/*").as("schema");
- cy.intercept("POST", "/api/dataset*").as("dataset");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
- "updateField",
- );
- cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
- cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
- cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
- cy.intercept("PUT", "/api/table").as("updateTables");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
-
- if (area === "admin") {
- cy.intercept("GET", "/api/database?*").as("databases");
- cy.intercept("GET", "/api/field/*/values").as("fieldValues");
- cy.intercept("PUT", "/api/table/*").as("updateTable");
- }
- if (area === "data studio") {
- cy.intercept("GET", "/api/database").as("databases");
- }
- });
+areas.forEach((area) => {
+ describe(`data model > ${area}`, () => {
+ const visit = visitArea(area);
- describe("Error handling", { tags: "@external" }, () => {
beforeEach(() => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "many_data_types" });
+ H.restore();
+ H.resetSnowplow();
cy.signInAsAdmin();
- H.resyncDatabase({
- dbId: WRITABLE_DB_ID,
- tableName: "many_data_types",
- });
-
- const error = { statusCode: 500 };
- cy.intercept("POST", "/api/dataset*", error);
- cy.intercept("PUT", "/api/field/*", error);
- cy.intercept("PUT", "/api/table/*/fields/order", error);
- cy.intercept("POST", "/api/field/*/values", error);
- cy.intercept("POST", "/api/field/*/dimension", error);
- cy.intercept("PUT", "/api/table/*", error);
- if (area === "admin") {
- cy.intercept("POST", "/api/table/*/sync_schema", error);
- cy.intercept("POST", "/api/table/*/rescan_values", error);
- cy.intercept("POST", "/api/table/*/discard_values", error);
- } else {
- cy.intercept("POST", "/api/data-studio/table/sync-schema", error);
- cy.intercept("POST", "/api/data-studio/table/rescan-values", error);
- cy.intercept("POST", "/api/data-studio/table/discard-values", error);
- }
- });
-
- it("shows toast errors and preview errors", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
- });
-
- cy.log("table section");
-
- if (area === "data studio") {
- TableSection.clickDetailsTab();
- }
- cy.log("name");
- TableSection.getNameInput().type("a").blur();
- verifyAndCloseToast("Failed to update table name");
-
- cy.log("description");
- TableSection.getDescriptionInput().type("a").blur();
- verifyAndCloseToast("Failed to update table description");
-
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- // cy.pause();
- }
- cy.log("predefined field order");
- TableSection.getSortButton().click();
- TableSection.getSortOrderInput()
- .findByLabelText("Alphabetical order")
- .click();
- verifyAndCloseToast("Failed to update field order");
-
- cy.log("custom field order");
- TableSection.getSortableField("ID").as("dragElement");
- H.moveDnDKitElementByAlias("@dragElement", {
- vertical: 50,
- });
- verifyAndCloseToast("Failed to update field order");
- TableSection.get().button("Done").click();
-
- if (area === "data studio") {
- TableSection.clickDetailsTab();
- }
- cy.log("sync");
+ H.activateToken("pro-self-hosted");
- if (area === "data studio") {
- TableSection.getActionsMenuButton().click();
- H.popover().findByText("Re-sync schema").click();
- } else {
- TableSection.getSyncOptionsButton().click();
- H.modal().button("Sync table schema").click();
- }
- verifyAndCloseToast("Failed to start sync");
-
- if (area === "data studio") {
- TableSection.getActionsMenuButton().click();
- H.popover().findByText("Re-scan field values").click();
- } else {
- H.modal().button("Re-scan table").click();
- }
- verifyAndCloseToast("Failed to start scan");
-
- if (area === "data studio") {
- TableSection.getActionsMenuButton().click();
- H.popover().findByText("Discard cached field values").click();
- } else {
- H.modal().button("Discard cached field values").click();
- }
+ cy.intercept("GET", "/api/database/*/schemas?*").as("schemas");
+ cy.intercept("GET", "/api/table/*/query_metadata*").as("metadata");
+ cy.intercept("GET", "/api/database/*/schema/*").as("schema");
+ cy.intercept("POST", "/api/dataset*").as("dataset");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/field/*", cy.spy().as("updateFieldSpy")).as(
+ "updateField",
+ );
+ cy.intercept("PUT", "/api/table/*/fields/order").as("updateFieldOrder");
+ cy.intercept("POST", "/api/field/*/values").as("updateFieldValues");
+ cy.intercept("POST", "/api/field/*/dimension").as("updateFieldDimension");
+ cy.intercept("PUT", "/api/table").as("updateTables");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
- verifyAndCloseToast("Failed to discard values");
if (area === "admin") {
- cy.realPress("Escape");
+ cy.intercept("GET", "/api/database?*").as("databases");
+ cy.intercept("GET", "/api/field/*/values").as("fieldValues");
+ cy.intercept("PUT", "/api/table/*").as("updateTable");
}
if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- cy.log("field name");
- TableSection.getFieldNameInput("Quantity").type("a").blur();
- verifyAndCloseToast("Failed to update name of Quantity");
-
- cy.log("field description");
- TableSection.getFieldDescriptionInput("Quantity").type("a").blur();
- verifyAndCloseToast("Failed to update description of Quantity");
-
- cy.log("field section");
- TableSection.clickField("Quantity");
- cy.log("name");
- FieldSection.getNameInput().type("a").blur();
- verifyAndCloseToast("Failed to update name of Quantity");
-
- cy.log("description");
- FieldSection.getDescriptionInput().type("a").blur();
- verifyAndCloseToast("Failed to update description of Quantity");
-
- cy.log("coercion strategy");
- FieldSection.getCoercionToggle().parent().scrollIntoView().click();
- H.popover()
- .findByText("UNIX seconds β†’ Datetime")
- .scrollIntoView()
- .click();
- verifyAndCloseToast("Failed to enable casting for Quantity");
-
- cy.log("semantic type");
- FieldSection.getSemanticTypeInput().click();
- H.popover().findByText("Score").click();
- verifyAndCloseToast("Failed to update semantic type of Quantity");
-
- cy.log("visibility");
- FieldSection.getVisibilityInput().click();
- H.popover().findByText("Only in detail views").click();
- verifyAndCloseToast("Failed to update visibility of Quantity");
-
- cy.log("filtering");
- FieldSection.getFilteringInput().click();
- H.popover().findByText("Search box").click();
- verifyAndCloseToast("Failed to update filtering of Quantity");
-
- cy.log("display values");
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Custom mapping").click();
- verifyAndCloseToast("Failed to update display values of Quantity");
-
- cy.log("JSON unfolding");
- // navigating away would cause onChange to be triggered in InputBlurChange and TextareaBlurChange
- // components, so new undos will appear - this makes this test flaky, so we navigate with page reload instead
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Json");
- FieldSection.getUnfoldJsonInput().click();
- H.popover().findByText("No").click();
- verifyAndCloseToast("Failed to disable JSON unfolding for Json");
-
- cy.log("formatting");
- TablePicker.getDatabase("Sample Database").click();
- TablePicker.getTable("Orders").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
+ cy.intercept("GET", "/api/database").as("databases");
}
- TableSection.clickField("Quantity");
- FieldSection.getPrefixInput().type("5").blur();
- verifyAndCloseToast("Failed to update formatting of Quantity");
-
- cy.log("preview section");
-
- cy.log("table preview");
- FieldSection.getPreviewButton().click();
- PreviewSection.get()
- .scrollIntoView()
- .findByText("Something went wrong")
- .should("be.visible");
-
- cy.log("object detail preview");
- PreviewSection.getPreviewTypeInput().findByText("Detail").click();
- PreviewSection.get()
- .findByText("Something went wrong")
- .should("be.visible");
});
- });
- describe("Undos", { tags: "@external" }, () => {
- beforeEach(() => {
- H.restore("postgres-writable");
- H.resetTestTable({ type: "postgres", table: "many_data_types" });
- cy.signInAsAdmin();
- H.resyncDatabase({
- dbId: WRITABLE_DB_ID,
- tableName: "many_data_types",
+ describe("Error handling", { tags: "@external" }, () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_data_types" });
+ cy.signInAsAdmin();
+ H.resyncDatabase({
+ dbId: WRITABLE_DB_ID,
+ tableName: "many_data_types",
+ });
+
+ const error = { statusCode: 500 };
+ cy.intercept("POST", "/api/dataset*", error);
+ cy.intercept("PUT", "/api/field/*", error);
+ cy.intercept("PUT", "/api/table/*/fields/order", error);
+ cy.intercept("POST", "/api/field/*/values", error);
+ cy.intercept("POST", "/api/field/*/dimension", error);
+ cy.intercept("PUT", "/api/table/*", error);
+ if (area === "admin") {
+ cy.intercept("POST", "/api/table/*/sync_schema", error);
+ cy.intercept("POST", "/api/table/*/rescan_values", error);
+ cy.intercept("POST", "/api/table/*/discard_values", error);
+ } else {
+ cy.intercept("POST", "/api/data-studio/table/sync-schema", error);
+ cy.intercept("POST", "/api/data-studio/table/rescan-values", error);
+ cy.intercept("POST", "/api/data-studio/table/discard-values", error);
+ }
});
- });
- it("allows to undo every action", () => {
- visit({
- databaseId: SAMPLE_DB_ID,
- schemaId: SAMPLE_DB_SCHEMA_ID,
- tableId: ORDERS_ID,
- fieldId: ORDERS.QUANTITY,
+ it("shows toast errors and preview errors", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+
+ cy.log("table section");
+
+ if (area === "data studio") {
+ TableSection.clickDetailsTab();
+ }
+ cy.log("name");
+ TableSection.getNameInput().type("a").blur();
+ verifyAndCloseToast("Failed to update table name");
+
+ cy.log("description");
+ TableSection.getDescriptionInput().type("a").blur();
+ verifyAndCloseToast("Failed to update table description");
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ // cy.pause();
+ }
+ cy.log("predefined field order");
+ TableSection.getSortButton().click();
+ TableSection.getSortOrderInput()
+ .findByLabelText("Alphabetical order")
+ .click();
+ verifyAndCloseToast("Failed to update field order");
+
+ cy.log("custom field order");
+ TableSection.getSortableField("ID").as("dragElement");
+ H.moveDnDKitElementByAlias("@dragElement", {
+ vertical: 50,
+ });
+ verifyAndCloseToast("Failed to update field order");
+ TableSection.get().button("Done").click();
+
+ if (area === "data studio") {
+ TableSection.clickDetailsTab();
+ }
+ cy.log("sync");
+
+ if (area === "data studio") {
+ TableSection.getActionsMenuButton().click();
+ H.popover().findByText("Re-sync schema").click();
+ } else {
+ TableSection.getSyncOptionsButton().click();
+ H.modal().button("Sync table schema").click();
+ }
+ verifyAndCloseToast("Failed to start sync");
+
+ if (area === "data studio") {
+ TableSection.getActionsMenuButton().click();
+ H.popover().findByText("Re-scan field values").click();
+ } else {
+ H.modal().button("Re-scan table").click();
+ }
+ verifyAndCloseToast("Failed to start scan");
+
+ if (area === "data studio") {
+ TableSection.getActionsMenuButton().click();
+ H.popover().findByText("Discard cached field values").click();
+ } else {
+ H.modal().button("Discard cached field values").click();
+ }
+
+ verifyAndCloseToast("Failed to discard values");
+ if (area === "admin") {
+ cy.realPress("Escape");
+ }
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ cy.log("field name");
+ TableSection.getFieldNameInput("Quantity").type("a").blur();
+ verifyAndCloseToast("Failed to update name of Quantity");
+
+ cy.log("field description");
+ TableSection.getFieldDescriptionInput("Quantity").type("a").blur();
+ verifyAndCloseToast("Failed to update description of Quantity");
+
+ cy.log("field section");
+ TableSection.clickField("Quantity");
+ cy.log("name");
+ FieldSection.getNameInput().type("a").blur();
+ verifyAndCloseToast("Failed to update name of Quantity");
+
+ cy.log("description");
+ FieldSection.getDescriptionInput().type("a").blur();
+ verifyAndCloseToast("Failed to update description of Quantity");
+
+ cy.log("coercion strategy");
+ FieldSection.getCoercionToggle().parent().scrollIntoView().click();
+ H.popover()
+ .findByText("UNIX seconds β†’ Datetime")
+ .scrollIntoView()
+ .click();
+ verifyAndCloseToast("Failed to enable casting for Quantity");
+
+ cy.log("semantic type");
+ FieldSection.getSemanticTypeInput().click();
+ H.popover().findByText("Score").click();
+ verifyAndCloseToast("Failed to update semantic type of Quantity");
+
+ cy.log("visibility");
+ FieldSection.getVisibilityInput().click();
+ H.popover().findByText("Only in detail views").click();
+ verifyAndCloseToast("Failed to update visibility of Quantity");
+
+ cy.log("filtering");
+ FieldSection.getFilteringInput().click();
+ H.popover().findByText("Search box").click();
+ verifyAndCloseToast("Failed to update filtering of Quantity");
+
+ cy.log("display values");
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Custom mapping").click();
+ verifyAndCloseToast("Failed to update display values of Quantity");
+
+ cy.log("JSON unfolding");
+ // navigating away would cause onChange to be triggered in InputBlurChange and TextareaBlurChange
+ // components, so new undos will appear - this makes this test flaky, so we navigate with page reload instead
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Json");
+ FieldSection.getUnfoldJsonInput().click();
+ H.popover().findByText("No").click();
+ verifyAndCloseToast("Failed to disable JSON unfolding for Json");
+
+ cy.log("formatting");
+ TablePicker.getDatabase("Sample Database").click();
+ TablePicker.getTable("Orders").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Quantity");
+ FieldSection.getPrefixInput().type("5").blur();
+ verifyAndCloseToast("Failed to update formatting of Quantity");
+
+ cy.log("preview section");
+
+ cy.log("table preview");
+ FieldSection.getPreviewButton().click();
+ PreviewSection.get()
+ .scrollIntoView()
+ .findByText("Something went wrong")
+ .should("be.visible");
+
+ cy.log("object detail preview");
+ PreviewSection.getPreviewTypeInput().findByText("Detail").click();
+ PreviewSection.get()
+ .findByText("Something went wrong")
+ .should("be.visible");
});
+ });
- cy.log("table section");
-
- if (area === "data studio") {
- TableSection.clickDetailsTab();
- }
- cy.log("name");
- TableSection.getNameInput().type("a").blur();
- verifyToastAndUndo("Table name updated");
- TableSection.getNameInput().should("have.value", "Orders");
-
- cy.log("description");
- TableSection.getDescriptionInput().type("a").blur();
- verifyToastAndUndo("Table description updated");
- TableSection.getDescriptionInput().should(
- "have.value",
- "Confirmed Sample Company orders for a product, from a user.",
- );
-
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- cy.log("predefined field order");
- TableSection.getSortButton().click();
- TableSection.getSortOrderInput()
- .findByLabelText("Alphabetical order")
- .click();
- verifyToastAndUndo("Field order updated");
- TableSection.getSortOrderInput()
- .findByDisplayValue("database")
- .should("be.checked");
-
- cy.log("custom field order");
- TableSection.getSortableField("ID").as("dragElement");
- H.moveDnDKitElementByAlias("@dragElement", {
- vertical: 50,
+ describe("Undos", { tags: "@external" }, () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_data_types" });
+ cy.signInAsAdmin();
+ H.resyncDatabase({
+ dbId: WRITABLE_DB_ID,
+ tableName: "many_data_types",
+ });
});
- verifyToastAndUndo("Field order updated");
- TableSection.getSortOrderInput()
- .findByDisplayValue("database")
- .should("be.checked");
- TableSection.get().button("Done").click();
-
- cy.log("field name");
- TableSection.getFieldNameInput("Quantity").type("a").blur();
- verifyToastAndUndo("Name of Quantity updated");
- TableSection.getFieldNameInput("Quantity").should(
- "have.value",
- "Quantity",
- );
-
- cy.log("field description");
- TableSection.getFieldDescriptionInput("Quantity").type("a").blur();
- verifyToastAndUndo("Description of Quantity updated");
- TableSection.getFieldDescriptionInput("Quantity").should(
- "have.value",
- "Number of products bought.",
- );
-
- cy.log("field section");
- TableSection.clickField("Quantity");
-
- cy.log("name");
- FieldSection.getNameInput().type("a").blur();
- verifyToastAndUndo("Name of Quantity updated");
- FieldSection.getNameInput().should("have.value", "Quantity");
-
- cy.log("description");
- FieldSection.getDescriptionInput().type("a").blur();
- verifyToastAndUndo("Description of Quantity updated");
- FieldSection.getDescriptionInput().should(
- "have.value",
- "Number of products bought.",
- );
-
- cy.log("coercion strategy");
- FieldSection.getCoercionToggle().parent().scrollIntoView().click();
- H.popover()
- .findByText("UNIX seconds β†’ Datetime")
- .scrollIntoView()
- .click();
- verifyToastAndUndo("Casting enabled for Quantity");
- FieldSection.getCoercionToggle().should("not.be.checked");
-
- cy.log("semantic type");
- FieldSection.getSemanticTypeInput().click();
- H.popover().findByText("Score").click();
- verifyToastAndUndo("Semantic type of Quantity updated");
- FieldSection.getSemanticTypeInput().should("have.value", "Quantity");
-
- cy.log("visibility");
- FieldSection.getVisibilityInput().click();
- H.popover().findByText("Only in detail views").click();
- verifyToastAndUndo("Visibility of Quantity updated");
- FieldSection.getVisibilityInput().should("have.value", "Everywhere");
-
- cy.log("filtering");
- FieldSection.getFilteringInput().click();
- H.popover().findByText("Search box").click();
- verifyToastAndUndo("Filtering of Quantity updated");
- FieldSection.getFilteringInput().should(
- "have.value",
- "A list of all values",
- );
-
- cy.log("display values");
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Custom mapping").click();
- H.modal().should("be.visible");
- H.modal().button("Close").click();
- verifyToastAndUndo("Display values of Quantity updated");
- FieldSection.getDisplayValuesInput().should(
- "have.value",
- "Use original value",
- );
- cy.log("custom mapping");
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Custom mapping").click();
- verifyAndCloseToast("Display values of Quantity updated");
- H.modal().within(() => {
- cy.findByDisplayValue("0")
- .clear()
- .type("XYZ", { scrollBehavior: "center" })
- .blur();
- cy.button("Save").click();
+ it("allows to undo every action", () => {
+ visit({
+ databaseId: SAMPLE_DB_ID,
+ schemaId: SAMPLE_DB_SCHEMA_ID,
+ tableId: ORDERS_ID,
+ fieldId: ORDERS.QUANTITY,
+ });
+
+ cy.log("table section");
+
+ if (area === "data studio") {
+ TableSection.clickDetailsTab();
+ }
+ cy.log("name");
+ TableSection.getNameInput().type("a").blur();
+ verifyToastAndUndo("Table name updated");
+ TableSection.getNameInput().should("have.value", "Orders");
+
+ cy.log("description");
+ TableSection.getDescriptionInput().type("a").blur();
+ verifyToastAndUndo("Table description updated");
+ TableSection.getDescriptionInput().should(
+ "have.value",
+ "Confirmed Sample Company orders for a product, from a user.",
+ );
+
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ cy.log("predefined field order");
+ TableSection.getSortButton().click();
+ TableSection.getSortOrderInput()
+ .findByLabelText("Alphabetical order")
+ .click();
+ verifyToastAndUndo("Field order updated");
+ TableSection.getSortOrderInput()
+ .findByDisplayValue("database")
+ .should("be.checked");
+
+ cy.log("custom field order");
+ TableSection.getSortableField("ID").as("dragElement");
+ H.moveDnDKitElementByAlias("@dragElement", {
+ vertical: 50,
+ });
+ verifyToastAndUndo("Field order updated");
+ TableSection.getSortOrderInput()
+ .findByDisplayValue("database")
+ .should("be.checked");
+ TableSection.get().button("Done").click();
+
+ cy.log("field name");
+ TableSection.getFieldNameInput("Quantity").type("a").blur();
+ verifyToastAndUndo("Name of Quantity updated");
+ TableSection.getFieldNameInput("Quantity").should(
+ "have.value",
+ "Quantity",
+ );
+
+ cy.log("field description");
+ TableSection.getFieldDescriptionInput("Quantity").type("a").blur();
+ verifyToastAndUndo("Description of Quantity updated");
+ TableSection.getFieldDescriptionInput("Quantity").should(
+ "have.value",
+ "Number of products bought.",
+ );
+
+ cy.log("field section");
+ TableSection.clickField("Quantity");
+
+ cy.log("name");
+ FieldSection.getNameInput().type("a").blur();
+ verifyToastAndUndo("Name of Quantity updated");
+ FieldSection.getNameInput().should("have.value", "Quantity");
+
+ cy.log("description");
+ FieldSection.getDescriptionInput().type("a").blur();
+ verifyToastAndUndo("Description of Quantity updated");
+ FieldSection.getDescriptionInput().should(
+ "have.value",
+ "Number of products bought.",
+ );
+
+ cy.log("coercion strategy");
+ FieldSection.getCoercionToggle().parent().scrollIntoView().click();
+ H.popover()
+ .findByText("UNIX seconds β†’ Datetime")
+ .scrollIntoView()
+ .click();
+ verifyToastAndUndo("Casting enabled for Quantity");
+ FieldSection.getCoercionToggle().should("not.be.checked");
+
+ cy.log("semantic type");
+ FieldSection.getSemanticTypeInput().click();
+ H.popover().findByText("Score").click();
+ verifyToastAndUndo("Semantic type of Quantity updated");
+ FieldSection.getSemanticTypeInput().should("have.value", "Quantity");
+
+ cy.log("visibility");
+ FieldSection.getVisibilityInput().click();
+ H.popover().findByText("Only in detail views").click();
+ verifyToastAndUndo("Visibility of Quantity updated");
+ FieldSection.getVisibilityInput().should("have.value", "Everywhere");
+
+ cy.log("filtering");
+ FieldSection.getFilteringInput().click();
+ H.popover().findByText("Search box").click();
+ verifyToastAndUndo("Filtering of Quantity updated");
+ FieldSection.getFilteringInput().should(
+ "have.value",
+ "A list of all values",
+ );
+
+ cy.log("display values");
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Custom mapping").click();
+ H.modal().should("be.visible");
+ H.modal().button("Close").click();
+ verifyToastAndUndo("Display values of Quantity updated");
+ FieldSection.getDisplayValuesInput().should(
+ "have.value",
+ "Use original value",
+ );
+
+ cy.log("custom mapping");
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Custom mapping").click();
+ verifyAndCloseToast("Display values of Quantity updated");
+ H.modal().within(() => {
+ cy.findByDisplayValue("0")
+ .clear()
+ .type("XYZ", { scrollBehavior: "center" })
+ .blur();
+ cy.button("Save").click();
+ });
+ verifyToastAndUndo("Display values of Quantity updated");
+ FieldSection.get().button("Edit mapping").click();
+ H.modal().within(() => {
+ cy.findByDisplayValue("0").should("be.visible");
+ cy.findByDisplayValue("XYZ").should("not.exist");
+ cy.button("Close").click();
+ });
+
+ cy.log("foreign key");
+ TableSection.clickField("User ID");
+ FieldSection.getDisplayValuesInput().click();
+ H.popover().findByText("Use foreign key").click();
+ verifyToastAndUndo("Display values of User ID updated");
+ FieldSection.getDisplayValuesInput().should(
+ "have.value",
+ "Use original value",
+ );
+
+ cy.log("JSON unfolding");
+ // The in-test DB switch via picker (.getDatabase().click() then
+ // .getTable().click()) races the picker re-render: the table click can
+ // land before the writable DB tables list is interactive, so the click
+ // never propagates to a URL change. The "Error handling" sibling above
+ // hit the same flake and was fixed by using visit({ databaseId:
+ // WRITABLE_DB_ID }) (which waits for picker bootstrap). Same pattern
+ // here.
+ visit({ databaseId: WRITABLE_DB_ID });
+ TablePicker.getTable("Many Data Types").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Json");
+ FieldSection.getUnfoldJsonInput().click();
+ H.popover().findByText("No").click();
+ verifyToastAndUndo("JSON unfolding disabled for Json");
+ FieldSection.getUnfoldJsonInput().should("have.value", "Yes");
+
+ cy.log("formatting");
+ // Same fresh-visit anchor as the Many Data Types switch above.
+ visit({ databaseId: SAMPLE_DB_ID });
+ TablePicker.getTable("Orders").click();
+ if (area === "data studio") {
+ TableSection.clickFieldsTab();
+ }
+ TableSection.clickField("Quantity");
+
+ cy.log("prefix (ChartSettingInput)");
+ FieldSection.getPrefixInput().type("5").blur();
+ verifyToastAndUndo("Formatting of Quantity updated");
+ FieldSection.getPrefixInput().should("have.value", "");
+
+ cy.log("multiply by number (ChartSettingInputNumeric)");
+ FieldSection.getMultiplyByNumberInput().type("5").blur();
+ verifyToastAndUndo("Formatting of Quantity updated");
+ FieldSection.getMultiplyByNumberInput().should("have.value", "");
+
+ cy.log("mini bar chart (ChartSettingToggle)");
+ FieldSection.getMiniBarChartToggle()
+ .parent()
+ .click({ scrollBehavior: "center" });
+ verifyToastAndUndo("Formatting of Quantity updated");
+ FieldSection.getMiniBarChartToggle().should("not.be.checked");
});
- verifyToastAndUndo("Display values of Quantity updated");
- FieldSection.get().button("Edit mapping").click();
- H.modal().within(() => {
- cy.findByDisplayValue("0").should("be.visible");
- cy.findByDisplayValue("XYZ").should("not.exist");
- cy.button("Close").click();
- });
-
- cy.log("foreign key");
- TableSection.clickField("User ID");
- FieldSection.getDisplayValuesInput().click();
- H.popover().findByText("Use foreign key").click();
- verifyToastAndUndo("Display values of User ID updated");
- FieldSection.getDisplayValuesInput().should(
- "have.value",
- "Use original value",
- );
-
- cy.log("JSON unfolding");
- // The in-test DB switch via picker (.getDatabase().click() then
- // .getTable().click()) races the picker re-render: the table click can
- // land before the writable DB tables list is interactive, so the click
- // never propagates to a URL change. The "Error handling" sibling above
- // hit the same flake and was fixed by using visit({ databaseId:
- // WRITABLE_DB_ID }) (which waits for picker bootstrap). Same pattern
- // here.
- visit({ databaseId: WRITABLE_DB_ID });
- TablePicker.getTable("Many Data Types").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Json");
- FieldSection.getUnfoldJsonInput().click();
- H.popover().findByText("No").click();
- verifyToastAndUndo("JSON unfolding disabled for Json");
- FieldSection.getUnfoldJsonInput().should("have.value", "Yes");
-
- cy.log("formatting");
- // Same fresh-visit anchor as the Many Data Types switch above.
- visit({ databaseId: SAMPLE_DB_ID });
- TablePicker.getTable("Orders").click();
- if (area === "data studio") {
- TableSection.clickFieldsTab();
- }
- TableSection.clickField("Quantity");
-
- cy.log("prefix (ChartSettingInput)");
- FieldSection.getPrefixInput().type("5").blur();
- verifyToastAndUndo("Formatting of Quantity updated");
- FieldSection.getPrefixInput().should("have.value", "");
-
- cy.log("multiply by number (ChartSettingInputNumeric)");
- FieldSection.getMultiplyByNumberInput().type("5").blur();
- verifyToastAndUndo("Formatting of Quantity updated");
- FieldSection.getMultiplyByNumberInput().should("have.value", "");
-
- cy.log("mini bar chart (ChartSettingToggle)");
- FieldSection.getMiniBarChartToggle()
- .parent()
- .click({ scrollBehavior: "center" });
- verifyToastAndUndo("Formatting of Quantity updated");
- FieldSection.getMiniBarChartToggle().should("not.be.checked");
});
});
});
diff --git a/package.json b/package.json
index ac189a85e44..5a166d0bc9f 100644
--- a/package.json
+++ b/package.json
@@ -92,7 +92,6 @@
"cronstrue": "^2.11.0",
"csv-parse": "^5.5.6",
"csv-stringify": "^6.5.0",
- "cypress-each": "^1.14.1",
"d3": "^7.9.0",
"d3-scale": "^4.0.2",
"dayjs": "^1.11.18",