Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Guard v60 dependency_status drop changesets against missing source columns (#74594)

Eric Normand7c7bbb9a956f
diff --git a/resources/migrations/060/20260402_dependency_status.yaml b/resources/migrations/060/20260402_dependency_status.yaml
index 7fc668b339c..8c3c7acabcd 100644
--- a/resources/migrations/060/20260402_dependency_status.yaml
+++ b/resources/migrations/060/20260402_dependency_status.yaml
@@ -259,6 +259,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:11
author: ericnormand
comment: Drop dependency_analysis_version index from report_card
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_card
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: report_card
@@ -275,6 +281,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:12
author: ericnormand
comment: Drop dependency_analysis_version index from transform
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: transform
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: transform
@@ -291,6 +303,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:13
author: ericnormand
comment: Drop dependency_analysis_version index from native_query_snippet
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: native_query_snippet
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: native_query_snippet
@@ -307,6 +325,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:14
author: ericnormand
comment: Drop dependency_analysis_version index from report_dashboard
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_dashboard
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: report_dashboard
@@ -323,6 +347,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:15
author: ericnormand
comment: Drop dependency_analysis_version index from document
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: document
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: document
@@ -339,6 +369,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:16
author: ericnormand
comment: Drop dependency_analysis_version index from sandboxes
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: sandboxes
+ columnName: dependency_analysis_version
changes:
- dropIndex:
tableName: sandboxes
@@ -357,6 +393,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:17
author: ericnormand
comment: Drop dependency_analysis_version column from report_card
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_card
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: report_card
@@ -376,6 +418,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:18
author: ericnormand
comment: Drop dependency_analysis_version column from transform
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: transform
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: transform
@@ -395,6 +443,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:19
author: ericnormand
comment: Drop dependency_analysis_version column from native_query_snippet
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: native_query_snippet
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: native_query_snippet
@@ -414,6 +468,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:20
author: ericnormand
comment: Drop dependency_analysis_version column from report_dashboard
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: report_dashboard
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: report_dashboard
@@ -433,6 +493,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:21
author: ericnormand
comment: Drop dependency_analysis_version column from document
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: document
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: document
@@ -452,6 +518,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:22
author: ericnormand
comment: Drop dependency_analysis_version column from sandboxes
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: sandboxes
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: sandboxes
@@ -471,6 +543,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:23
author: ericnormand
comment: Drop dependency_analysis_version column from segment
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: segment
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: segment
@@ -490,6 +568,12 @@ databaseChangeLog:
id: v60.2026-04-02T00:00:24
author: ericnormand
comment: Drop dependency_analysis_version column from measure
+ validCheckSum: ANY
+ preConditions:
+ - onFail: MARK_RAN
+ - columnExists:
+ tableName: measure
+ columnName: dependency_analysis_version
changes:
- dropColumn:
tableName: measure
diff --git a/test/metabase/app_db/schema_migrations_test.clj b/test/metabase/app_db/schema_migrations_test.clj
index 02a1133e123..d415e5d6436 100644
--- a/test/metabase/app_db/schema_migrations_test.clj
+++ b/test/metabase/app_db/schema_migrations_test.clj
@@ -2933,15 +2933,20 @@
:updated_at :%now}))))))))
(deftest dependency-status-segment-handles-missing-column-migration-test
- (testing "Migration v60.2026-04-02T00:00:09 MARK_RANs when segment.dependency_analysis_version is missing (issue #74443)"
- (impl/test-migrations ["v60.2026-04-02T00:00:09" "v60.2026-04-02T00:00:09"] [migrate!]
- ;; Simulate the broken partial-migration state: source column gone before the data-migration runs.
+ (testing "The whole 20260402_dependency_status changeset run survives a missing
+ segment.dependency_analysis_version column (issue #74443). Every changeset that
+ touches the column — the INSERT (T00:00:09) and the DROP COLUMN (T00:00:23) —
+ must MARK_RAN rather than fail."
+ (impl/test-migrations ["v60.2026-04-02T00:00:09" "v60.2026-04-02T00:00:24"] [migrate!]
+ ;; Simulate an instance whose segment table never got dependency_analysis_version.
(t2/query "ALTER TABLE segment DROP COLUMN dependency_analysis_version")
+ ;; Must not throw: the migration run completes despite the missing column.
(migrate!)
- (testing "T00:00:09 is recorded as MARK_RAN"
- (is (= "MARK_RAN"
- (:exectype (liquibase/changelog-by-id mdb.connection/*application-db*
- "v60.2026-04-02T00:00:09"))))))))
+ (doseq [id ["v60.2026-04-02T00:00:09" ; INSERT … SELECT FROM segment
+ "v60.2026-04-02T00:00:23"]] ; ALTER TABLE segment DROP COLUMN
+ (testing (str id " is recorded as MARK_RAN")
+ (is (= "MARK_RAN"
+ (:exectype (liquibase/changelog-by-id mdb.connection/*application-db* id)))))))))
;;;
;;; 62 tests