The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
SQL Server: create :type/Text columns as nvarchar(max) instead of text (#78861)
Timothy S. Dean7d1b01bac526
diff --git a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.cljindex 1ea8ffab353..826db7971f9 100644--- a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj+++ b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj@@ -170,7 +170,9 @@(defmethod type->database-type :type/Integer [_] [:int])(defmethod type->database-type :type/Number [_] [:bigint])(defmethod type->database-type :type/BigInteger [_] [:bigint])-(defmethod type->database-type :type/Text [_] [:text])+;; not `text` -- SQL Server forbids comparing, sorting, or grouping text/ntext columns+;; (IS NULL and LIKE only); nvarchar(max) is equally unbounded without the restriction.+(defmethod type->database-type :type/Text [_] [[:raw "nvarchar(max)"]])(defmethod type->database-type :type/Time [_] [:time])(defmethod type->database-type :type/UUID [_] [:uniqueidentifier])diff --git a/modules/drivers/sqlserver/test/metabase/driver/sqlserver_test.clj b/modules/drivers/sqlserver/test/metabase/driver/sqlserver_test.cljindex c573705cb59..b788deb3889 100644--- a/modules/drivers/sqlserver/test/metabase/driver/sqlserver_test.clj+++ b/modules/drivers/sqlserver/test/metabase/driver/sqlserver_test.clj@@ -945,9 +945,15 @@:type/Float [:float]:type/Integer [:int]:type/Number [:bigint]- :type/Text [:text]+ :type/Text [[:raw "nvarchar(max)"]]:type/Time [:time]- :type/UUID [:uniqueidentifier])))+ :type/UUID [:uniqueidentifier]))+ (testing ":type/Text must not compile to `text`/`ntext` -- SQL Server rejects those in GROUP BY, ORDER BY,+ and comparisons (\"The text, ntext, and image data types cannot be compared or sorted\")"+ (let [ddl (#'driver.sql-jdbc/create-table!-sql :sqlserver :dbo/t+ [["state" (driver/type->database-type :sqlserver :type/Text)]])]+ (is (re-find #"(?i)nvarchar\(max\)" ddl))+ (is (not (re-find #"(?i)\bn?text\b" ddl))))))(deftest ^:parallel compile-transform-test(mt/test-driver :sqlserver