Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update our Table icon (#66900)

Maz Ameli7ddc7cae7d63
diff --git a/.loki/reference/chrome_laptop_App_Palette_Recents.png b/.loki/reference/chrome_laptop_App_Palette_Recents.png
index 0adf64fc217..799b0250a19 100644
Binary files a/.loki/reference/chrome_laptop_App_Palette_Recents.png and b/.loki/reference/chrome_laptop_App_Palette_Recents.png differ
diff --git a/.loki/reference/chrome_laptop_App_Palette_Search.png b/.loki/reference/chrome_laptop_App_Palette_Search.png
index 94be6a81dcf..44257c242cf 100644
Binary files a/.loki/reference/chrome_laptop_App_Palette_Search.png and b/.loki/reference/chrome_laptop_App_Palette_Search.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Table_Default.png b/.loki/reference/chrome_laptop_Components_Table_Default.png
index 740f0c37a79..8f3ffc5e96b 100644
Binary files a/.loki/reference/chrome_laptop_Components_Table_Default.png and b/.loki/reference/chrome_laptop_Components_Table_Default.png differ
diff --git a/frontend/src/metabase/common/components/Pickers/QuestionPicker/components/QuestionPickerModal.tsx b/frontend/src/metabase/common/components/Pickers/QuestionPicker/components/QuestionPickerModal.tsx
index 97a77b4cc6d..c4007c79f4d 100644
--- a/frontend/src/metabase/common/components/Pickers/QuestionPicker/components/QuestionPickerModal.tsx
+++ b/frontend/src/metabase/common/components/Pickers/QuestionPicker/components/QuestionPickerModal.tsx
@@ -108,7 +108,7 @@ export const QuestionPickerModal = ({
displayName: t`Questions`,
models: ["card" as const],
folderModels: ["collection" as const],
- icon: "table",
+ icon: "folder",
render: ({ onItemSelect }) => (
<QuestionPicker
initialValue={value}
diff --git a/frontend/src/metabase/querying/drills/utils/underlying-records-drill.ts b/frontend/src/metabase/querying/drills/utils/underlying-records-drill.ts
index 8145b6a6852..9970930dabd 100644
--- a/frontend/src/metabase/querying/drills/utils/underlying-records-drill.ts
+++ b/frontend/src/metabase/querying/drills/utils/underlying-records-drill.ts
@@ -33,7 +33,7 @@ export const underlyingRecordsDrill: Drill<
name: "underlying-records",
title: actionTitle,
section: "records",
- icon: "table_spaced",
+ icon: "table",
buttonType: "horizontal",
question: () =>
applyDrill(drill)
diff --git a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts b/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
index 066e4bddbfe..302dbe28b5e 100644
--- a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
+++ b/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
@@ -1621,7 +1621,6 @@ export const Icons: Record<IconName, { component: React.VFC; source: string }> =
source: birthday_source,
},
external: { component: share_component, source: share_source },
- table_spaced: { component: table_component, source: table_source },
collection: { component: folder_component, source: folder_source },
collection2: {
component: collection2_component,
@@ -1908,7 +1907,6 @@ export type IconName =
| "scalar"
| "cake"
| "external"
- | "table_spaced"
| "collection"
| "beaker"
| "test_tube"
diff --git a/frontend/src/metabase/ui/components/icons/Icon/icons/table.svg b/frontend/src/metabase/ui/components/icons/Icon/icons/table.svg
index a8b9b72ee4b..aaf6fda742e 100644
--- a/frontend/src/metabase/ui/components/icons/Icon/icons/table.svg
+++ b/frontend/src/metabase/ui/components/icons/Icon/icons/table.svg
@@ -1,11 +1,3 @@
<svg viewBox="0 0 16 16" fill="currentcolor" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
- <path d="M2 2H5.33333V5.33333H2V2Z" />
- <path d="M6.33333 2H9.66666V5.33333H6.33333V2Z" />
- <path d="M14 2H10.6667V5.33333H14V2Z" />
- <path d="M2 6.33333H5.33333V9.66666H2V6.33333Z" />
- <path d="M9.66666 6.33333H6.33333V9.66666H9.66666V6.33333Z" />
- <path d="M10.6667 6.33333H14V9.66666H10.6667V6.33333Z" />
- <path d="M5.33333 10.6667H2V14H5.33333V10.6667Z" />
- <path d="M6.33333 10.6667H9.66666V14H6.33333V10.6667Z" />
- <path d="M14 10.6667H10.6667V14H14V10.6667Z" />
+ <path d="M12.667 1.25c1.15 0 2.083.933 2.083 2.083v9.334c0 1.15-.933 2.083-2.083 2.083H3.333a2.083 2.083 0 0 1-2.083-2.083V3.333c0-1.15.933-2.083 2.083-2.083h9.334zm-9.917 9.5v1.917c0 .322.261.583.583.583H7.25v-2.5h-4.5zm6 0v2.5h3.917a.583.583 0 0 0 .583-.583V10.75h-4.5zm-6-1.5h4.5v-2.5h-4.5v2.5zm6 0h4.5v-2.5h-4.5v2.5zm-5.417-6.5a.583.583 0 0 0-.583.583V5.25h4.5v-2.5H3.333zm5.417 2.5h4.5V3.333a.583.583 0 0 0-.583-.583H8.75v2.5z" />
</svg>
diff --git a/frontend/src/metabase/visualizations/visualizations/DashCardPlaceholder.tsx b/frontend/src/metabase/visualizations/visualizations/DashCardPlaceholder.tsx
index e813f64160d..89e35ca5a01 100644
--- a/frontend/src/metabase/visualizations/visualizations/DashCardPlaceholder.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/DashCardPlaceholder.tsx
@@ -91,7 +91,7 @@ function preventDragging(e: React.MouseEvent<HTMLButtonElement>) {
export const DashCardPlaceholder = Object.assign(DashCardPlaceholderInner, {
getUiName: () => t`Empty card`,
identifier: "placeholder",
- iconName: "table_spaced", // TODO replace
+ iconName: "table",
canSavePng: false,
noHeader: true,