Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Conceal JWT signing secret by default (#70329)

Rodrigo López Dato7eb9d271079c
diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsJWTForm/SettingsJWTForm.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsJWTForm/SettingsJWTForm.unit.spec.tsx
index d1545c00c0c..ce1dcbf18f0 100644
--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsJWTForm/SettingsJWTForm.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsJWTForm/SettingsJWTForm.unit.spec.tsx
@@ -61,9 +61,7 @@ describe("SettingsJWTForm", () => {
ATTRS["jwt-identity-provider-uri"],
);
await userEvent.type(
- await screen.findByRole("textbox", {
- name: /String used by the JWT signing key/,
- }),
+ await screen.findByLabelText(/String used by the JWT signing key/),
ATTRS["jwt-shared-secret"],
);
await userEvent.type(
@@ -113,9 +111,7 @@ describe("SettingsJWTForm", () => {
ATTRS["jwt-identity-provider-uri"],
);
await userEvent.type(
- await screen.findByRole("textbox", {
- name: /String used by the JWT signing key/,
- }),
+ await screen.findByLabelText(/String used by the JWT signing key/),
ATTRS["jwt-shared-secret"],
);
diff --git a/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx b/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx
index a4e434dd07c..38274b1a3d7 100644
--- a/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx
+++ b/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx
@@ -7,11 +7,11 @@ import { t } from "ttag";
import { ConfirmModal } from "metabase/common/components/ConfirmModal";
import CS from "metabase/css/core/index.css";
import { UtilApi } from "metabase/services";
-import type { TextInputProps } from "metabase/ui";
-import { Button, Flex, TextInput } from "metabase/ui";
+import type { PasswordInputProps } from "metabase/ui";
+import { Button, Flex, PasswordInput } from "metabase/ui";
export interface FormSecretKeyProps
- extends Omit<TextInputProps, "value" | "error"> {
+ extends Omit<PasswordInputProps, "value" | "error"> {
name: string;
nullable?: boolean;
confirmation: {
@@ -63,7 +63,7 @@ export const FormSecretKey = forwardRef(function FormSecretKey(
return (
<>
<Flex align="end" gap="1rem">
- <TextInput
+ <PasswordInput
{...props}
ref={ref}
name={name}