The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Deduplicate do-useless-hash (#86039)
Alexander Polyankin803ff85fe293
diff --git a/src/metabase/session/api.clj b/src/metabase/session/api.cljindex 4cbcc255079..729a947ef33 100644--- a/src/metabase/session/api.clj+++ b/src/metabase/session/api.clj@@ -37,9 +37,10 @@(def ^:private throttling-disabled? (config/config-bool :mb-disable-session-throttle))(def ^:private login-throttlers- {:username (throttle/make-throttler :username)+ {:username (throttle/make-throttler :username);; IP Address doesn't have an actual UI field so just show error by username- :ip-address (throttle/make-throttler :username, :attempts-threshold 50)})+ :ip-address (throttle/make-throttler :username, :attempts-threshold 50)+ :ldap-account (throttle/make-throttler :username)})(def ^:private verify-throttlers;; Codes are 6 digits, so brute-force limits are load-bearing. Only failures count (see@@ -77,32 +78,35 @@(def ^:private password-fail-snippet (deferred-tru "did not match stored password"))(mu/defn- ldap-login :- [:maybe [:or session.schema/SessionSchema [:map [:mfa/pending? [:= true]]]]]- "If LDAP is enabled and a matching user exists return a new Session for them (or an MFA-pending- result map when a second factor is required), or `nil` if they couldn't be authenticated."+ "Return a new Session (or an MFA-pending result map) for a directory user, `nil` when local login should be tried, or+ throw when the directory login is refused."[username :- ms/NonBlankStringpassword :- ms/NonBlankStringdevice-info :- request/DeviceInfo]- (when (sso/ldap-enabled)- (let [result (auth-identity/login! :provider/ldap- {:username username- :password password- :device-info device-info})]- (cond- ;; Fallback when the ldap operation fails- (contains? #{:ldap-error :server-error} (:error result))- nil-- (= (:error result) :invalid-credentials)- (throw (ex-info (str password-fail-message)- {:status-code 401- :errors {:password password-fail-snippet}}))-- (:success? result)- (if (:mfa/pending? result) result (:session result))-- :else- (throw (ex-info (str (:message result)) {:errors {:_error (:error result)}- :status-code 401}))))))+ (when-let [{:keys [dn]} (and (sso/ldap-enabled) (u/ignore-exceptions (sso/find-user username)))]+ (call-with-failure-throttling+ [[(login-throttlers :ldap-account) (u/lower-case-en dn)]]+ (fn []+ (let [result (auth-identity/login! :provider/ldap+ {:username username+ :password password+ :device-info device-info})]+ (cond+ ;; Fallback when the ldap operation fails+ (contains? #{:ldap-error :server-error} (:error result))+ nil++ (= (:error result) :invalid-credentials)+ (throw (ex-info (str password-fail-message)+ {:status-code 401+ :errors {:password password-fail-snippet}}))++ (:success? result)+ (if (:mfa/pending? result) result (:session result))++ :else+ (throw (ex-info (str (:message result)) {:errors {:_error (:error result)}+ :status-code 401}))))))))(mu/defn- email-login :- [:maybe [:or session.schema/SessionSchema [:map [:mfa/pending? [:= true]]]]]"Find a matching `User` if one exists and return a new Session for them (or an MFA-pending resultdiff --git a/test/metabase/session/api_test.clj b/test/metabase/session/api_test.cljindex 5c0b038c8da..4dc0c719db6 100644--- a/test/metabase/session/api_test.clj+++ b/test/metabase/session/api_test.clj@@ -1004,6 +1004,22 @@(is (= {:errors {:password "did not match stored password"}}(mt/client :post 401 "session" (mt/user->credentials :lucky)))))))+(deftest ldap-login-throttles-account-across-login-aliases-test+ (testing "LDAP login - failures under uid and mail add up for one directory account"+ (ldap.test/with-ldap-server!+ (mt/with-temporary-setting-values [mfa-enforcement :off]+ (api.session/reset-throttlers-for-testing!)+ (try+ (doseq [username (concat (repeat 5 "sbrown20") (repeat 5 "[email protected]"))]+ (mt/client :post 401 "session" {:username username, :password "wrong-password"}))+ (is (=? {:errors {:username #"Too many attempts!.*"}}+ (mt/client :post 401 "session" {:username "sbrown20", :password "1234"})))+ (testing "refused login creates no user"+ (is (not (t2/exists? :model/User :%lower.email "[email protected]"))))+ (finally+ (api.session/reset-throttlers-for-testing!)+ (t2/delete! :model/User :%lower.email "[email protected]")))))))+(deftest ldap-login-deactivated-user-test(testing "LDAP login - deactivated user cannot login"(ldap.test/with-ldap-server!