Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Enable `codespell` for the enterprise folder (#67979)

Nemanja Glumac80b6060ab70a
diff --git a/.codespellignore b/.codespellignore
index 03653a4e5e4..deb3d739d93 100644
--- a/.codespellignore
+++ b/.codespellignore
@@ -1,23 +1,29 @@
-Brite
afterAll
ags
altho
+Brite
cancelation
cancelations
datas
edn
eduction
+hasTable
hasTables
horizontalX
horizontalY
juxt
methodd
notIn
+ot
pass-thru
+requestor
+re-use
ser
serieses
sortings
+titel
trs
trsn
tru
trun
+unparseable
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
index 9422e3de93e..0518ed27e99 100644
--- a/.github/workflows/codespell.yml
+++ b/.github/workflows/codespell.yml
@@ -3,17 +3,18 @@ name: Codespell
on:
push:
branches:
- - 'master'
- - 'release-**'
+ - "master"
+ - "release-**"
pull_request:
jobs:
codespell:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v3
- - uses: codespell-project/actions-codespell@v1
+ - uses: actions/checkout@v4
+ - uses: codespell-project/actions-codespell@v2
with:
- # keep this list in sync with the list in `mage/src/mage/codespell.yml`
+ # keep this list in sync with the list in `mage/src/mage/codespell.clj`
path: >-
docs
+ enterprise
diff --git a/enterprise/backend/test/metabase_enterprise/metabot_v3/table_utils_test.clj b/enterprise/backend/test/metabase_enterprise/metabot_v3/table_utils_test.clj
index 16654d517cf..cded3402cbe 100644
--- a/enterprise/backend/test/metabase_enterprise/metabot_v3/table_utils_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/metabot_v3/table_utils_test.clj
@@ -31,9 +31,9 @@
(is (table-utils/similar? "people" "person")) ; change 2 chars
(is (table-utils/similar? "accounts" "account")) ; remove 1 char
(is (table-utils/similar? "products" "product")) ; remove 1 char
- (is (table-utils/similar? "PEOPLE" "PEOPL")) ; remove 1 char (our use case!)
+ (is (table-utils/similar? "PEOPLE" "PEOPL")) ; codespell:ignore | remove 1 char (our use case!)
(is (table-utils/similar? "ORDERS" "ORDRE")) ; change 1 char
- (is (table-utils/similar? "ACCOUNTS" "ACOUNT")))) ; remove 2 chars
+ (is (table-utils/similar? "ACCOUNTS" "ACOUNT")))) ; codespell:ignore | remove 2 chars
(deftest similar?-threshold-boundary-test
(testing "similar? function at threshold boundary"
diff --git a/enterprise/backend/test/metabase_enterprise/sandbox/api/user_test.clj b/enterprise/backend/test/metabase_enterprise/sandbox/api/user_test.clj
index db881e2622c..6d18bf215d9 100644
--- a/enterprise/backend/test/metabase_enterprise/sandbox/api/user_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/sandbox/api/user_test.clj
@@ -66,7 +66,7 @@
[:model/User _ {:login_attributes {:foo "bar"
:woo "hoo"}}
:model/User _ {:login_attributes {:foo "biz"
- :woo "haa"}}
+ :woo "haa"}} ; codespell:ignore haa
:model/User _ {:login_attributes {:third-one "nope"}}]
(is (= 2
(count (mt/user-http-request :crowberto :get 200 "mt/user/attributes")))))))))
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
index 944a4c2cb25..93803a22d6b 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
@@ -60,12 +60,12 @@ describe("SchemaFormSelect", () => {
const input = screen.getByRole("textbox");
act(() => input.focus());
- await userEvent.type(input, "fo");
+ await userEvent.type(input, "fo"); // codespell:ignore fo
expect(screen.getByText("foo")).toBeInTheDocument();
expect(screen.getByText(/Create new schema/)).toBeInTheDocument();
await userEvent.click(screen.getByText(/Create new schema/));
- expect(input).toHaveValue("fo");
+ expect(input).toHaveValue("fo"); // codespell:ignore fo
expect(
screen.getByText(
diff --git a/mage/src/mage/codespell.clj b/mage/src/mage/codespell.clj
index 5fd4b946765..e375e2e0e68 100644
--- a/mage/src/mage/codespell.clj
+++ b/mage/src/mage/codespell.clj
@@ -10,7 +10,7 @@
[#_"dev"
"docs"
#_"e2e"
- #_"enterprise"
+ "enterprise"
#_"frontend"
#_"modules/drivers"
#_"src"