The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Remove the reduntant `skip` input from bundle-size step (#80070)
Nemanja Glumac812e970d411e
diff --git a/.github/workflows/bundle-size.yml b/.github/workflows/bundle-size.ymlindex 4c0bf1af31d..39ba39c2dc7 100644--- a/.github/workflows/bundle-size.yml+++ b/.github/workflows/bundle-size.yml@@ -7,11 +7,6 @@ name: Bundle Sizeon:workflow_call:- inputs:- skip:- description: Whether to skip the check (e.g. no front-end sources changed, or the uberjar failed to build).- required: true- type: booleanconcurrency:group: bundle-size-${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}@@ -20,7 +15,6 @@ concurrency:jobs:bundle-size-check:name: "Bundle size check"- if: ${{ !inputs.skip }}continue-on-error: trueruns-on: ${{ vars.DEFAULT_RUNNER_KEY }}timeout-minutes: 20diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.ymlindex f5e14431737..199bc76c622 100644--- a/.github/workflows/run-tests.yml+++ b/.github/workflows/run-tests.yml@@ -237,11 +237,13 @@ jobs:bundle-size:needs: [uberjar, create-test-plan]- if: always() && !cancelled()+ if: |+ !cancelled() &&+ github.event_name == 'pull_request' &&+ needs.uberjar.result == 'success' &&+ needs.create-test-plan.outputs.frontend_sources == 'true'uses: ./.github/workflows/bundle-size.ymlsecrets: inherit- with:- skip: ${{ github.event_name != 'pull_request' || needs.uberjar.result != 'success' || needs.create-test-plan.outputs.frontend_sources != 'true' }}pr-env:needs: [uberjar]