Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove unused eslintrc files (#69098)

Fraser823559542ce4
diff --git a/.eslintrc.js b/.eslintrc.js
deleted file mode 100644
index f3092c4f228..00000000000
--- a/.eslintrc.js
+++ /dev/null
@@ -1,362 +0,0 @@
-/* eslint-disable import/no-commonjs */
-/* eslint-disable no-undef */
-
-const path = require("path");
-
-// `postcss-modules` lints css modules class names, but it currently crashes
-// eslint on vscode. If you use webstorm or want to run the lint for the cli, you
-// can use this flag to enable it. This is set to true in CI
-const shouldLintCssModules =
- process.env.LINT_CSS_MODULES === "true" || process.env.CI;
-const plugins = [
- "react",
- "no-only-tests",
- "ttag",
- "i18next",
- "metabase",
-];
-if (shouldLintCssModules) {
- plugins.push("postcss-modules");
-}
-
-module.exports = {
- ignorePatterns: ["!.storybook"],
- rules: {
- strict: [2, "never"],
- "no-undef": 2,
- "no-var": 1,
- "no-unused-vars": [
- "error",
- {
- vars: "all",
- args: "none",
- varsIgnorePattern: "^_.+$",
- ignoreRestSiblings: true,
- },
- ],
- "no-empty": [1, { allowEmptyCatch: true }],
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- paths: [
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- ],
- },
- ],
- curly: [1, "all"],
- eqeqeq: [1, "smart"],
- "import/no-duplicates": ["warn", { considerQueryString: true }],
- "import/no-default-export": 2,
- "import/no-named-as-default": 0,
- "import/no-commonjs": 1,
- "import/order": [
- "error",
- {
- "newlines-between": "always",
- alphabetize: {
- order: "asc",
- orderImportKind: "asc",
- caseInsensitive: false,
- },
- groups: [
- "builtin",
- "external",
- "internal",
- "parent",
- "sibling",
- "index",
- ],
- warnOnUnassignedImports: false,
- },
- ],
- "sort-imports": [
- "error",
- {
- // allows this rule to work with import/order
- ignoreDeclarationSort: true,
- },
- ],
- "no-console": [2, { allow: ["warn", "error", "errorBuffer"] }],
- "react/no-is-mounted": 2,
- "react/prefer-es6-class": 2,
- "react/display-name": 1,
- "react/prop-types": 2,
- "react/no-did-mount-set-state": 0,
- "react/no-did-update-set-state": 0,
- "react/no-find-dom-node": 0,
- "react/no-children-prop": 2,
- "react/no-string-refs": 2,
- "react/no-unescaped-entities": 2,
- "react/jsx-no-target-blank": 2,
- "react/jsx-key": 2,
- "react/forbid-component-props": [2, { forbid: ["sx"] }],
- "react-hooks/exhaustive-deps": ["warn"],
- "prefer-const": [1, { destructuring: "all" }],
- "no-restricted-globals": ["error", "close"],
- "no-useless-escape": 0,
- "no-only-tests/no-only-tests": [
- "error",
- {
- block: [
- "describe",
- "it",
- "context",
- "test",
- "tape",
- "fixture",
- "serial",
- "Feature",
- "Scenario",
- "Given",
- "And",
- "When",
- "Then",
- ],
- },
- ],
- complexity: ["error", { max: 55 }],
- ...(shouldLintCssModules
- ? {
- "postcss-modules/no-undef-class": "error",
- }
- : {}),
- },
- globals: {
- before: true,
- cy: true,
- Cypress: true,
- },
- env: {
- browser: true,
- es2020: true,
- commonjs: true,
- jest: true,
- "jest/globals": true,
- },
- parser: "babel-eslint",
- plugins,
- extends: [
- "eslint:recommended",
- "plugin:react/recommended",
- "plugin:react/jsx-runtime",
- "plugin:react-hooks/recommended",
- "plugin:import/errors",
- "plugin:import/warnings",
- "plugin:import/typescript",
- "plugin:depend/recommended",
- "plugin:storybook/recommended",
- "plugin:i18next/recommended",
- ],
- settings: {
- "import/internal-regex": "^metabase/|^metabase-lib/",
- "import/resolver": {
- webpack: {
- config: path.resolve(__dirname, "./rspack.main.config.js"),
- typescript: true,
- },
- },
- "import/ignore": ["\\.css$"],
- react: {
- version: "detect",
- },
- "postcss-modules": {
- baseDir: "./frontend/src",
- },
- },
- parserOptions: {
- ecmaFeatures: {
- legacyDecorators: true,
- },
- },
- overrides: [
- {
- files: ["*.js", "*.jsx", "*.ts", "*.tsx"],
- rules: {
- "metabase/jtag-missing-key": "error",
- "metabase/no-unconditional-metabase-links-render": "error",
- "metabase/no-color-literals": "error",
- "metabase/no-literal-metabase-strings": "error",
- "metabase/no-oss-reinitialize-import": "error",
- "depend/ban-dependencies": [
- "error",
- {
- allowed: [
- "underscore",
- "moment",
- "lodash.orderby",
- "lodash.debounce",
- ],
- },
- ],
- },
- },
- {
- files: [
- "*.unit.spec.*",
- "frontend/src/metabase/admin/**/*",
- "frontend/src/metabase/setup/**/*",
- "enterprise/frontend/src/metabase-enterprise/whitelabel/**/*",
- "enterprise/frontend/src/metabase-enterprise/embedding/**/*",
- "frontend/lint/**/*",
- "*.stories.*",
- "**/.storybook/*",
- "stories-data.*",
- "e2e/**/*",
- "**/tests/*",
- "release/**/*",
- "rspack.config.js",
- "rspack.main.config.js",
- "rspack.embedding-sdk-package.config.js",
- "rspack.embedding-sdk-bundle.config.js",
- ],
- rules: {
- "metabase/no-color-literals": "off",
- "metabase/no-unconditional-metabase-links-render": "off",
- "metabase/no-literal-metabase-strings": "off",
- },
- },
- {
- files: [
- "*.unit.spec.*",
- "frontend/lint/**/*",
- "*.stories.*",
- "stories-data.*",
- "e2e/**/*",
- "**/tests/*",
- "release/**/*",
- "rspack.main.config.js",
- ],
- rules: {
- "i18next/no-literal-string": "off",
- },
- },
- {
- extends: ["plugin:@typescript-eslint/recommended"],
- files: ["*.ts", "*.tsx"],
- parser: "@typescript-eslint/parser",
- plugins: ["@typescript-eslint"],
- rules: {
- "prefer-rest-params": "off",
- "react/prop-types": "off", // TypeScript handles prop validation
- "@typescript-eslint/explicit-module-boundary-types": "off",
- "@typescript-eslint/no-inferrable-types": "off",
- "@typescript-eslint/no-explicit-any": "off",
- "@typescript-eslint/no-this-alias": "off",
- "@typescript-eslint/consistent-type-imports": [
- "error",
- {
- fixStyle: "inline-type-imports",
- },
- ],
- "@typescript-eslint/no-import-type-side-effects": "error",
- "@typescript-eslint/no-unused-vars": [
- "error",
- {
- argsIgnorePattern: "^_.+$",
- varsIgnorePattern: "^_.+$",
- ignoreRestSiblings: true,
- destructuredArrayIgnorePattern: "^_.+$",
- },
- ],
- // This was introduced in 6.0.0
- "@typescript-eslint/no-unsafe-declaration-merging": "off",
- },
- },
- {
- extends: [
- "plugin:jest/recommended",
- "plugin:jest-dom/recommended",
- "plugin:testing-library/react",
- "plugin:jest-formatting/recommended",
- ],
- plugins: ["jest", "jest-dom", "testing-library", "jest-formatting"],
- files: [
- "*.unit.spec.ts",
- "*.unit.spec.tsx",
- "*.unit.spec.js",
- "*.unit.spec.jsx",
- ],
- rules: {
- "jest/valid-title": ["error", { ignoreTypeOfDescribeName: true }],
- "jest/expect-expect": [
- "error",
- {
- assertFunctionNames: ["expect*", "assert*"],
- additionalTestBlockFunctions: [],
- },
- ],
- },
- },
- {
- // Enable jest formatting for cypress tests too, the plugin logic just works
- extends: ["plugin:jest-formatting/recommended"],
- files: ["*.cy.spec.ts", "*.cy.spec.js"],
- },
- {
- files: ["frontend/src/**/*"],
- rules: {
- "no-restricted-syntax": [
- "error",
- {
- selector: "Literal[value=/mb-base-color-/]",
- message:
- "You may not use base colors in the application, use semantic colors instead. (see colors.module.css)",
- },
- ],
- },
- },
- {
- files: ["frontend/src/metabase/**/*"],
- rules: {
- "no-restricted-syntax": [
- "error",
- {
- selector: "Literal[value=/mb-base-color-/]",
- message:
- "You may not use base colors in the application, use semantic colors instead. (see colors.module.css)",
- },
- ],
- },
- },
- {
- files: ["frontend/src/metabase/query_builder/**/*"],
- rules: {
- "import/no-cycle": "error",
- },
- },
- {
- files: ["docs/**/snippets/**/*.{ts,tsx,js,jsx}"],
- rules: {
- "@typescript-eslint/no-unused-vars": "off",
- "@typescript-eslint/no-var-requires": "off",
- "import/no-commonjs": "off",
- "import/no-default-export": "off",
- "import/order": "off",
- "import/no-unresolved": "off",
- "metabase/no-color-literals": "off",
- },
- },
- {
- files: ["frontend/build/**/*.js"],
- rules: {
- "import/no-commonjs": "off",
- },
- },
- {
- files: ["**/*.stories.tsx", "**/preview.tsx"],
- rules: {
- "import/no-default-export": "off",
- },
- },
- ],
-};
diff --git a/e2e/.eslintrc b/e2e/.eslintrc
deleted file mode 100644
index abf218f4e32..00000000000
--- a/e2e/.eslintrc
+++ /dev/null
@@ -1,69 +0,0 @@
-{
- "rules": {
- "metabase/no-unscoped-text-selectors": 2,
- "import/no-commonjs": 0,
- "metabase/no-color-literals": 0,
- "no-console": 0,
- "@typescript-eslint/no-namespace": "off",
- "cypress/no-assigning-return-values": "error",
- "cypress/no-async-tests": "error",
- "cypress/no-pause": "error",
- "quotes": ["error", "double", { "avoidEscape": true }],
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- "paths": [
- {
- "name": "moment",
- "message": "Moment is deprecated, please use dayjs"
- },
- {
- "name": "moment-timezone",
- "message": "Moment is deprecated, please use dayjs"
- },
- {
- // mocks/presets is for unit tests
- "name": "metabase-types/api/mocks/presets",
- "message": "Please use e2e/support/cypress_sample_database instead"
- }
- ],
- "patterns": [
- {
- "group": [
- "**/enterprise/frontend/src/embedding-sdk-package",
- "**/enterprise/frontend/src/embedding-sdk-package/*"
- ],
- "message": "Please use SDK package name - '@metabase/embedding-sdk-react'"
- }
- ]
- }
- ],
- "import/no-unresolved": [
- "error",
- {
- "ignore": [
- "@metabase/embedding-sdk-react"
- ]
- }
- ],
- "metabase/no-direct-helper-import": 2,
- "metabase/no-unsafe-element-filtering": ["warn"],
- "metabase/no-unordered-test-helpers": 2
- },
- "env": {
- "cypress/globals": true,
- "node": true
- },
- "plugins": ["cypress"],
- "overrides": [
- {
- "files": ["*.cy.spec.*"],
- "rules": {
- "no-console": "error"
- }
- }
- ]
-}
diff --git a/e2e/embedding-sdk-host-apps/.eslintrc b/e2e/embedding-sdk-host-apps/.eslintrc
deleted file mode 100644
index 20addf6dd0b..00000000000
--- a/e2e/embedding-sdk-host-apps/.eslintrc
+++ /dev/null
@@ -1,6 +0,0 @@
-{
- "rules": {
- "import/no-default-export": "off",
- "import/no-unresolved": "off"
- }
-}
diff --git a/enterprise/frontend/src/.eslintrc.js b/enterprise/frontend/src/.eslintrc.js
deleted file mode 100644
index d0f06cbd7ef..00000000000
--- a/enterprise/frontend/src/.eslintrc.js
+++ /dev/null
@@ -1,154 +0,0 @@
-/* eslint-disable no-undef,import/no-commonjs */
-const path = require("path");
-
-const TEST_FILES_NAME_PATTERN_ERROR_MESSAGE = `Please name your test setup and utils files with a ".spec.*" in the filename, or put them under "/tests", e.g. "setup.spec.ts", "MyComponent.setup.spec.ts", or "tests/setup.ts". This is to ensure they won't be imported in the SDK build.`;
-
-const baseRestrictedConfig = {
- patterns: [
- { group: ["cljs/metabase.lib*"] },
- {
- group: ["metabase-types/openapi", "metabase-types/openapi/**"],
- message:
- "Direct imports from metabase-types/openapi are restricted. Reexport types under readable names from metabase-types/api instead.",
- },
- ],
- paths: [
- {
- name: "@mantine/core",
- message: "Please import from `metabase/ui` instead.",
- },
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@storybook/test",
- message:
- "Please use `testing-library/react` or `@testing-library/user-event`",
- },
- {
- name: "react-redux",
- importNames: ["useSelector", "useDispatch", "connect"],
- message: 'Please use "useSdkSelector", "useSdkDispatch"',
- },
- ],
-};
-
-module.exports = {
- settings: {
- "import/resolver": {
- webpack: {
- config: path.resolve(
- __dirname,
- "../../../rspack.embedding-sdk-bundle.config.js",
- ),
- typescript: true,
- },
- },
- },
- rules: {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- ...baseRestrictedConfig,
- patterns: [
- ...baseRestrictedConfig.patterns,
- {
- group: ["__support__/**", "!__support__/metadata"],
- message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
- },
- ],
- },
- ],
- "ttag/no-module-declaration": 2,
- },
- overrides: [
- {
- files: ["embedding-sdk-{package,bundle,shared}/**/*.{ts,tsx,js,jsx}"],
- rules: {
- "no-restricted-imports": [
- "error",
- {
- patterns: [
- ...baseRestrictedConfig.patterns,
- {
- group: ["__support__/**"],
- message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
- },
- ],
- paths: [
- ...baseRestrictedConfig.paths,
- {
- name: "metabase/lib/redux",
- importNames: ["useStore", "useDispatch"],
- message: 'Please use "useSdkStore", "useSdkDispatch"',
- },
- ],
- },
- ],
- },
- },
- {
- files: [
- "**/*.spec.*",
- "**/test-utils.*",
- "**/tests/**/*",
- "**/test/**/*",
- ],
- rules: {
- "no-restricted-imports": ["error", baseRestrictedConfig],
- },
- },
- {
- files: ["**/.storybook/*", "**/*.stories.tsx"],
- rules: {
- "import/no-default-export": 0,
- "no-restricted-imports": 0,
- },
- },
- {
- files: ["**/metabase-types/**/*.{ts,tsx,js,jsx}"],
- rules: {
- "no-restricted-imports": [
- "error",
- {
- patterns: [{ group: ["cljs/metabase.lib*"] }],
- paths: baseRestrictedConfig.paths,
- },
- ],
- },
- },
- {
- files: ["embedding-sdk-{package,shared}/**/*.{ts,tsx,js,jsx}"],
- excludedFiles: [
- "embedding-sdk-package/{bin,cli}/**/*.{ts,tsx,js,jsx}",
- "**/.storybook/**",
- "**/jest/**",
- "**/test/**",
- "**/*.spec.{ts,tsx,js,jsx}",
- "**/*.stories.{ts,tsx,js,jsx}",
- ],
- rules: {
- "metabase/no-external-references-for-sdk-package-code": [
- "error",
- {
- allowedPaths: [
- path.join(__dirname, "embedding-sdk-package"),
- path.resolve(
- __dirname,
- "../../../frontend/src/embedding-sdk-shared",
- ),
- ],
- },
- ],
- },
- },
- ],
-};
diff --git a/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc b/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc
deleted file mode 100644
index 6e42ed14838..00000000000
--- a/enterprise/frontend/src/embedding-sdk-package/bin/.eslintrc
+++ /dev/null
@@ -1,6 +0,0 @@
-{
- "rules": {
- "metabase/no-literal-metabase-strings": "off",
- "no-console": "off",
- },
-}
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc b/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc
deleted file mode 100644
index 49ccf934c27..00000000000
--- a/enterprise/frontend/src/embedding-sdk-package/cli/.eslintrc
+++ /dev/null
@@ -1,7 +0,0 @@
-{
- "rules": {
- "metabase/no-literal-metabase-strings": "off",
- "metabase/no-color-literals": "off",
- "no-console": "off"
- }
-}
diff --git a/enterprise/frontend/src/embedding/auth-common/.eslintrc b/enterprise/frontend/src/embedding/auth-common/.eslintrc
deleted file mode 100644
index 0701b5f0be4..00000000000
--- a/enterprise/frontend/src/embedding/auth-common/.eslintrc
+++ /dev/null
@@ -1,20 +0,0 @@
-{
- "rules": {
- "no-restricted-imports": [
- "error",
- {
- "patterns": [
- {
- "group": [
- "embedding-sdk-bundle/*",
- "metabase/*",
- "!embedding-sdk-bundle/errors",
- "!embedding-sdk-bundle/types"
- ],
- "message": "Keep imports in auth-common to a minimum as it is used in embed.js for iframe embedding."
- }
- ]
- }
- ]
- }
-}
diff --git a/frontend/src/embedding-sdk-bundle/.eslintrc.js b/frontend/src/embedding-sdk-bundle/.eslintrc.js
deleted file mode 100644
index cab26a9b0d7..00000000000
--- a/frontend/src/embedding-sdk-bundle/.eslintrc.js
+++ /dev/null
@@ -1,139 +0,0 @@
-/* eslint-disable import/no-commonjs */
-
-const TEST_FILES_NAME_PATTERN_ERROR_MESSAGE = `Please name your test setup and utils files with a ".spec.*" in the filename, or put them under "/tests", e.g. "setup.spec.ts", "MyComponent.setup.spec.ts", or "tests/setup.ts". This is to ensure they won't be imported in the SDK build.`;
-
-const baseRestrictedConfig = {
- patterns: [
- {
- group: ["metabase-enterprise"],
- },
- {
- group: ["metabase-enterprise/*"],
- },
- {
- group: ["cljs/metabase.lib*"],
- },
- { group: ["/embedding-sdk-package"] },
- ],
- paths: [
- {
- name: "react-redux",
- importNames: ["useSelector", "useDispatch", "connect"],
- message: "Please import from `metabase/lib/redux` instead.",
- },
- {
- name: "@mantine/core",
- message: "Please import from `metabase/ui` instead.",
- },
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- {
- name: "@storybook/test",
- message:
- "Please use `testing-library/react` or `@testing-library/user-event`",
- },
- ],
-};
-
-module.exports = {
- rules: {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- ...baseRestrictedConfig,
- patterns: [
- ...baseRestrictedConfig.patterns,
- {
- group: ["__support__/**", "!__support__/metadata"],
- message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
- },
- ],
- },
- ],
- "ttag/no-module-declaration": 2,
- },
- overrides: [
- {
- files: ["./app.js"],
- rules: {
- "import/no-duplicates": 0,
- },
- },
- {
- files: ["**/*.stories.tsx"],
- rules: {
- "import/no-default-export": 0,
- "no-restricted-imports": 0,
- },
- },
- {
- files: ["lib/redux/hooks.ts"],
- rules: {
- "no-restricted-imports": 0,
- },
- },
- {
- files: [
- "**/*.spec.*",
- "**/test-utils.*",
- "**/tests/**/*",
- "**/test/**/*",
- ],
- rules: {
- "no-restricted-imports": ["error", baseRestrictedConfig],
- },
- },
- {
- files: ["ui/**/*.{js,jsx,ts,tsx}"],
- rules: {
- "no-restricted-imports": [
- "error",
- {
- patterns: [
- "metabase-enterprise",
- "metabase-enterprise/*",
- "cljs/metabase.lib*",
- ],
- paths: [
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- ],
- },
- ],
- },
- },
- ],
-};
diff --git a/frontend/src/embedding-sdk-bundle/test/.eslintrc b/frontend/src/embedding-sdk-bundle/test/.eslintrc
deleted file mode 100644
index 0cdf2a71db9..00000000000
--- a/frontend/src/embedding-sdk-bundle/test/.eslintrc
+++ /dev/null
@@ -1,5 +0,0 @@
-{
- "rules": {
- "metabase/no-color-literals": "off"
- }
-}
diff --git a/frontend/src/embedding-sdk-shared/.eslintrc.js b/frontend/src/embedding-sdk-shared/.eslintrc.js
deleted file mode 100644
index cab26a9b0d7..00000000000
--- a/frontend/src/embedding-sdk-shared/.eslintrc.js
+++ /dev/null
@@ -1,139 +0,0 @@
-/* eslint-disable import/no-commonjs */
-
-const TEST_FILES_NAME_PATTERN_ERROR_MESSAGE = `Please name your test setup and utils files with a ".spec.*" in the filename, or put them under "/tests", e.g. "setup.spec.ts", "MyComponent.setup.spec.ts", or "tests/setup.ts". This is to ensure they won't be imported in the SDK build.`;
-
-const baseRestrictedConfig = {
- patterns: [
- {
- group: ["metabase-enterprise"],
- },
- {
- group: ["metabase-enterprise/*"],
- },
- {
- group: ["cljs/metabase.lib*"],
- },
- { group: ["/embedding-sdk-package"] },
- ],
- paths: [
- {
- name: "react-redux",
- importNames: ["useSelector", "useDispatch", "connect"],
- message: "Please import from `metabase/lib/redux` instead.",
- },
- {
- name: "@mantine/core",
- message: "Please import from `metabase/ui` instead.",
- },
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- {
- name: "@storybook/test",
- message:
- "Please use `testing-library/react` or `@testing-library/user-event`",
- },
- ],
-};
-
-module.exports = {
- rules: {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- ...baseRestrictedConfig,
- patterns: [
- ...baseRestrictedConfig.patterns,
- {
- group: ["__support__/**", "!__support__/metadata"],
- message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
- },
- ],
- },
- ],
- "ttag/no-module-declaration": 2,
- },
- overrides: [
- {
- files: ["./app.js"],
- rules: {
- "import/no-duplicates": 0,
- },
- },
- {
- files: ["**/*.stories.tsx"],
- rules: {
- "import/no-default-export": 0,
- "no-restricted-imports": 0,
- },
- },
- {
- files: ["lib/redux/hooks.ts"],
- rules: {
- "no-restricted-imports": 0,
- },
- },
- {
- files: [
- "**/*.spec.*",
- "**/test-utils.*",
- "**/tests/**/*",
- "**/test/**/*",
- ],
- rules: {
- "no-restricted-imports": ["error", baseRestrictedConfig],
- },
- },
- {
- files: ["ui/**/*.{js,jsx,ts,tsx}"],
- rules: {
- "no-restricted-imports": [
- "error",
- {
- patterns: [
- "metabase-enterprise",
- "metabase-enterprise/*",
- "cljs/metabase.lib*",
- ],
- paths: [
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- ],
- },
- ],
- },
- },
- ],
-};
diff --git a/frontend/src/metabase-lib/.eslintrc b/frontend/src/metabase-lib/.eslintrc
deleted file mode 100644
index 7b2cfed70b3..00000000000
--- a/frontend/src/metabase-lib/.eslintrc
+++ /dev/null
@@ -1,48 +0,0 @@
-{
- "rules": {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- "patterns": [
- {
- "group": [
- "metabase/*",
- "!metabase/env",
- "!metabase/lib",
- "!metabase/querying",
- "!metabase/services"
- ]
- },
- {
- "group": [
- "metabase/lib/*",
- "!metabase/lib/colors",
- "!metabase/lib/encoding",
- "!metabase/lib/formatting",
- "!metabase/lib/number",
- "!metabase/lib/time",
- "!metabase/lib/time-dayjs",
- "!metabase/lib/types",
- "!metabase/lib/urls",
- "!metabase/lib/utils"
- ]
- }
- ],
- "paths": [
- {
- "name": "moment",
- "message": "Moment is deprecated, please use dayjs"
- },
- {
- "name": "moment-timezone",
- "message": "Moment is deprecated, please use dayjs"
- }
- ]
- }
- ],
- "ttag/no-module-declaration": 2,
- }
-}
diff --git a/frontend/src/metabase/.eslintrc.js b/frontend/src/metabase/.eslintrc.js
deleted file mode 100644
index d568186795a..00000000000
--- a/frontend/src/metabase/.eslintrc.js
+++ /dev/null
@@ -1,150 +0,0 @@
-/* eslint-disable import/no-commonjs */
-
-const TEST_FILES_NAME_PATTERN_ERROR_MESSAGE = `Please name your test setup and utils files with a ".spec.*" in the filename, or put them under "/tests", e.g. "setup.spec.ts", "MyComponent.setup.spec.ts", or "tests/setup.ts". This is to ensure they won't be imported in the SDK build.`;
-
-const baseRestrictedConfig = {
- patterns: [
- {
- group: ["metabase-enterprise"],
- },
- {
- group: ["metabase-enterprise/*"],
- },
- {
- group: ["cljs/metabase.lib*"],
- },
- { group: ["/embedding-sdk-package"] },
- {
- group: ["metabase-types/openapi", "metabase-types/openapi/**"],
- message:
- "Direct imports from metabase-types/openapi are restricted. Reexport types under readable names from metabase-types/api instead.",
- },
- ],
- paths: [
- {
- name: "react-redux",
- importNames: ["useSelector", "useDispatch", "connect"],
- message: "Please import from `metabase/lib/redux` instead.",
- },
- {
- name: "@mantine/core",
- message: "Please import from `metabase/ui` instead.",
- },
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- {
- name: "@storybook/test",
- message:
- "Please use `testing-library/react` or `@testing-library/user-event`",
- },
- {
- name: "metabase/lib/colors/constants/base-colors",
- importNames: ["getBaseColorsForThemeDefinitionOnly"],
- message:
- "getBaseColorsForThemeDefinitionOnly is only for use within lib/colors. Use theme colors from 'metabase/lib/colors' instead.",
- },
- ],
-};
-
-module.exports = {
- rules: {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- ...baseRestrictedConfig,
- patterns: [
- ...baseRestrictedConfig.patterns,
- {
- group: ["__support__/**", "!__support__/metadata"],
- message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
- },
- ],
- },
- ],
- "ttag/no-module-declaration": 2,
- },
- overrides: [
- {
- files: ["./app.js"],
- rules: {
- "import/no-duplicates": 0,
- },
- },
- {
- files: ["**/*.stories.tsx"],
- rules: {
- "import/no-default-export": 0,
- "no-restricted-imports": 0,
- },
- },
- {
- files: ["lib/redux/hooks.ts"],
- rules: {
- "no-restricted-imports": 0,
- },
- },
- {
- files: [
- "**/*.spec.*",
- "**/test-utils.*",
- "**/tests/**/*",
- "**/test/**/*",
- ],
- rules: {
- "no-restricted-imports": ["error", baseRestrictedConfig],
- },
- },
- {
- files: ["ui/**/*.{js,jsx,ts,tsx}"],
- rules: {
- "no-restricted-imports": [
- "error",
- {
- patterns: [
- "metabase-enterprise",
- "metabase-enterprise/*",
- "cljs/metabase.lib*",
- ],
- paths: [
- {
- name: "moment",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "moment-timezone",
- message: "Moment is deprecated, please use dayjs",
- },
- {
- name: "@emotion/styled",
- message: "Please style components using css modules.",
- },
- {
- name: "@emotion/react",
- message:
- "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- ],
- },
- ],
- },
- },
- ],
-};
diff --git a/frontend/src/metabase/metadata/.eslintrc b/frontend/src/metabase/metadata/.eslintrc
deleted file mode 100644
index 4bed1e7be77..00000000000
--- a/frontend/src/metabase/metadata/.eslintrc
+++ /dev/null
@@ -1,53 +0,0 @@
-{
- "rules": {
- // Note: adding this rule to a eslint config file in a subfolder will remove
- // *not* carry over the restricted imports from parent folders, you will
- // need to copy them over
- "no-restricted-imports": [
- "error",
- {
- "patterns": [
- "metabase-enterprise",
- "metabase-enterprise/*",
- "cljs/metabase.lib*",
- "/embedding-sdk-package",
- "/embedding-sdk-bundle",
- "/embedding-sdk-shared",
- "metabase/entities",
- "metabase/entities/*",
- ],
- "paths": [
- {
- "name": "react-redux",
- "importNames": ["useSelector", "useDispatch", "connect"],
- "message": "Please import from `metabase/lib/redux` instead.",
- },
- {
- "name": "@mantine/core",
- "message": "Please import from `metabase/ui` instead.",
- },
- {
- "name": "moment",
- "message": "Moment is deprecated, please use dayjs",
- },
- {
- "name": "moment-timezone",
- "message": "Moment is deprecated, please use dayjs",
- },
- {
- "name": "@emotion/styled",
- "message": "Please style components using css modules.",
- },
- {
- "name": "@emotion/react",
- "message": "Please use components from `metabase/ui` instead and style them using css modules.",
- },
- {
- "name": "@storybook/test",
- "message": "Please use `testing-library/react` or `@testing-library/user-event`",
- },
- ],
- },
- ],
- },
-}
diff --git a/frontend/test/.eslintrc b/frontend/test/.eslintrc
deleted file mode 100644
index a28dadaed97..00000000000
--- a/frontend/test/.eslintrc
+++ /dev/null
@@ -1,9 +0,0 @@
-{
- "rules": {
- "import/no-commonjs": 0,
- "metabase/no-color-literals": 0
- },
- "env": {
- "node": true
- }
-}
diff --git a/release/.eslintrc b/release/.eslintrc
deleted file mode 100644
index fdb6dbe97e5..00000000000
--- a/release/.eslintrc
+++ /dev/null
@@ -1,10 +0,0 @@
-{
- "overrides": [
- {
- "files": ["*.ts", "*.js"],
- "rules": {
- "no-console": "off"
- }
- }
- ]
-}