The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Improve Metabot input and message scrolling UX (#68117)
Thomas Schmidt825719067a8a
diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/AIMarkdown/AIMarkdown.module.css b/enterprise/frontend/src/metabase-enterprise/metabot/components/AIMarkdown/AIMarkdown.module.cssindex e302341fa39..caaead10fe0 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/AIMarkdown/AIMarkdown.module.css+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/AIMarkdown/AIMarkdown.module.css@@ -1,10 +1,55 @@.aiMarkdown {line-height: 1.5;+ max-width: 100%;+ overflow: hidden;}.aiMarkdown pre {- width: 100%;- overflow-x: auto;+ overflow: auto hidden;+ max-width: 100%;+ white-space: pre;+ background: var(--mb-color-background-secondary);+ padding: 0.625rem 0.75rem;+ border-radius: 0.375rem;+ margin: 0.5rem 0;+ border: 1px solid var(--mb-color-border);+ scrollbar-width: thin;+ scrollbar-color: var(--mb-color-border) transparent;+}++.aiMarkdown pre::-webkit-scrollbar {+ height: 6px;+}++.aiMarkdown pre::-webkit-scrollbar-track {+ background: transparent;+}++.aiMarkdown pre::-webkit-scrollbar-thumb {+ background: var(--mb-color-border);+ border-radius: 3px;+}++.aiMarkdown pre::-webkit-scrollbar-thumb:hover {+ background: var(--mb-color-text-tertiary);+}++.aiMarkdown code {+ font-family: Monaco, Menlo, "Courier New", monospace;+ background: var(--mb-color-background-secondary);+ color: var(--mb-color-text-primary);+ padding: 0.125rem 0.375rem;+ border-radius: 0.25rem;+ font-size: 0.875em;+ border: 1px solid var(--mb-color-border);+}++.aiMarkdown pre code {+ font-size: 0.6875rem;+ line-height: 1.5;+ background: transparent;+ border: none;+ padding: 0;}.aiMarkdown p {diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotChat.module.css b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotChat.module.cssindex 1fd1a092413..bdcc68423ca 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotChat.module.css+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotChat/MetabotChat.module.css@@ -58,7 +58,7 @@.messageContainerUser {align-items: flex-end;align-self: flex-end;- max-width: 80%;+ max-width: 90%;min-width: 6rem;width: fit-content;}@@ -78,6 +78,8 @@padding: 0.5rem 1rem;border-radius: 1rem;background: var(--mb-color-background-tertiary);+ max-width: 100%;+ overflow: hidden;}.messageUserAction {diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/MetabotPromptInput.module.css b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/MetabotPromptInput.module.cssindex 66db8c4996e..336a03435fd 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/MetabotPromptInput.module.css+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/MetabotPromptInput.module.css@@ -9,8 +9,14 @@color: var(--mb-color-text-primary);font-size: var(--mantine-font-size-md);min-height: 1.7em;+ max-height: 12.5rem;+ overflow-y: auto;+ overflow-x: hidden;+ scroll-behavior: smooth;white-space: pre-wrap;word-break: break-word;+ scrollbar-width: thin;+ scrollbar-color: var(--mb-color-border) transparent;&:focus {outline: none;@@ -21,6 +27,23 @@margin: 0;}+.content :global(.ProseMirror)::-webkit-scrollbar {+ width: 8px;+}++.content :global(.ProseMirror)::-webkit-scrollbar-track {+ background: transparent;+}++.content :global(.ProseMirror)::-webkit-scrollbar-thumb {+ background: var(--mb-color-border);+ border-radius: 4px;+}++.content :global(.ProseMirror)::-webkit-scrollbar-thumb:hover {+ background: var(--mb-color-text-tertiary);+}+.content :global(.is-empty:first-child:before) {color: var(--mb-color-text-tertiary);content: attr(data-placeholder);diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.ts b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.tsindex 4cd3814566f..a6e2a57640b 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.ts@@ -8,7 +8,16 @@ import {import { mbProtocolModelToSuggestionModel } from "metabase/rich_text_editing/tiptap/extensions/shared/suggestionUtils";function serializeNodes(nodes: JSONContent[]): string {- return nodes.map((node) => serializeNode(node)).join("");+ return nodes+ .map((node, index) => {+ const serialized = serializeNode(node);+ // Add newline after paragraphs, except for the last one+ if (node.type === "paragraph" && index < nodes.length - 1) {+ return serialized + "\n";+ }+ return serialized;+ })+ .join("");}function serializeNode(node: JSONContent): string {@@ -41,7 +50,7 @@ function serializeNode(node: JSONContent): string {}export function serializeTiptapToMetabotMessage(content: JSONContent): string {- return serializeNodes(content?.content || []);+ return serializeNodes(content?.content || []).trim();}const MENTION_REGEX = new RegExp(METABSE_PROTOCOL_MD_LINK, "g");diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.unit.spec.tsindex f3ea4cbe2d8..f4a9535ae9a 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.unit.spec.ts+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotPromptInput/utils.unit.spec.ts@@ -26,6 +26,86 @@ describe("MetabotChatEditor > utils", () => {expect(result).toBe("[test](metabase://table/1)");});++ it("should preserve newlines between paragraphs", () => {+ const input: JSONContent = {+ type: "doc",+ content: [+ {+ type: "paragraph",+ content: [{ type: "text", text: "First line" }],+ },+ {+ type: "paragraph",+ content: [{ type: "text", text: "Second line" }],+ },+ {+ type: "paragraph",+ content: [{ type: "text", text: "Third line" }],+ },+ ],+ };+ const result = serializeTiptapToMetabotMessage(input);++ expect(result).toBe("First line\nSecond line\nThird line");+ });++ it("should not add trailing newline after last paragraph", () => {+ const input: JSONContent = {+ type: "doc",+ content: [+ {+ type: "paragraph",+ content: [{ type: "text", text: "Only line" }],+ },+ ],+ };+ const result = serializeTiptapToMetabotMessage(input);++ expect(result).toBe("Only line");+ });++ it("should handle empty paragraphs", () => {+ const input: JSONContent = {+ type: "doc",+ content: [+ {+ type: "paragraph",+ content: [{ type: "text", text: "First" }],+ },+ {+ type: "paragraph",+ content: [],+ },+ {+ type: "paragraph",+ content: [{ type: "text", text: "Third" }],+ },+ ],+ };+ const result = serializeTiptapToMetabotMessage(input);++ expect(result).toBe("First\n\nThird");+ });++ it("should handle hard breaks within paragraphs", () => {+ const input: JSONContent = {+ type: "doc",+ content: [+ {+ type: "paragraph",+ content: [+ { type: "text", text: "Line 1" },+ { type: "hardBreak" },+ { type: "text", text: "Line 2" },+ ],+ },+ ],+ };+ const result = serializeTiptapToMetabotMessage(input);++ expect(result).toBe("Line 1\nLine 2");+ });});describe("parseMetabotMessageToTiptapDoc", () => {