Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Migrate AutocompleteInput dropdown off Emotion (#82948)

Andrei Chernykh8317274709ca
diff --git a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.styled.tsx b/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.styled.tsx
deleted file mode 100644
index 46ed169f0bb..00000000000
--- a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.styled.tsx
+++ /dev/null
@@ -1,9 +0,0 @@
-// eslint-disable-next-line no-restricted-imports
-import styled from "@emotion/styled";
-
-import { SelectList } from "metabase/common/components/SelectList";
-
-export const OptionsList = styled(SelectList)`
- padding: 0.5rem;
- min-width: 300px;
-`;
diff --git a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx b/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
index 9105b5c78b7..2a54c0f273d 100644
--- a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
+++ b/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
@@ -4,11 +4,9 @@ import { useMemo, useRef } from "react";
import { SelectList } from "metabase/common/components/SelectList";
import { useListKeyboardNavigation } from "metabase/common/hooks/use-list-keyboard-navigation";
-import { Popover, TextInput, type TextInputProps } from "metabase/ui";
+import { Popover, TextInput, type TextInputProps, rem } from "metabase/ui";
import type { VisualizationSettings } from "metabase-types/api";
-import { OptionsList } from "./AutocompleteInput.styled";
-
export interface AutocompleteInputProps extends Omit<
TextInputProps,
"onChange"
@@ -123,7 +121,12 @@ export const AutocompleteInput = ({
/>
</Popover.Target>
<Popover.Dropdown>
- <OptionsList ref={optionsListRef} onMouseDown={handleListMouseDown}>
+ <SelectList
+ ref={optionsListRef}
+ p="sm"
+ miw={rem(300)}
+ onMouseDown={handleListMouseDown}
+ >
{filteredOptions.map((item, index) => (
<SelectList.Item
isSelected={cursorIndex === index}
@@ -138,7 +141,7 @@ export const AutocompleteInput = ({
{item}
</SelectList.Item>
))}
- </OptionsList>
+ </SelectList>
</Popover.Dropdown>
</Popover>
);