The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Introduce Copilot code review instructions (#69846)
Nemanja Glumac83fdafad015d
diff --git a/.claude/skills/typescript-review/SKILL.md b/.claude/skills/typescript-review/SKILL.mdindex 2c1de31a524..be052434c37 100644--- a/.claude/skills/typescript-review/SKILL.md+++ b/.claude/skills/typescript-review/SKILL.md@@ -12,8 +12,9 @@ allowed-tools: Read, Grep, Bash, GlobReview pull requests with a focus on:+- Readability and maintainability+- Appropriate test coverage- Compliance with project coding standards and conventions- Code quality and best practices-- Clear and correct JSDoc comments- Type safety and proper TypeScript usage-- React best practices (when applicable)\ No newline at end of file+- React best practices (when applicable)diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.mdindex 4d7a610d794..d759f44e572 100644--- a/.github/copilot-instructions.md+++ b/.github/copilot-instructions.md@@ -1,52 +1,55 @@# Metabase Developer Assistant Instructions-## Frontend Development+For detailed coding standards and conventions, see `CLAUDE.md` and the skills in `.claude/skills/`.-### Repository Structure+## Code Review Standards-```-frontend/src/-├── metabase/ # Main application components and pages-├── metabase-lib/ # Query building and data modeling utilities-├── metabase-types/ # TypeScript type definitions-└── metabase/ui/ # Design system components+Review focus areas: Security → Performance → Testing → Documentation (in priority order)-e2e/ # Cypress end-to-end tests-frontend/test/ # Jest unit tests-```+When reviewing code, use these emoji prefixes to categorize feedback:+- 🔒 Security concerns+- ⚡ Performance opportunities+- 🧹 Cleanup needs+- 📚 Documentation gaps+- 🚨 Blocking issues+- 💭 Clarification questions-### Technology Stack+### Security Critical Issues-- **Framework**: React 18 with TypeScript-- **State**: Redux Toolkit-- **Styling**: CSS Modules (preferred) > Emotion styled-components-- **UI**: `metabase/ui` components built with Mantine v8-- **Build**: Rspack (primary), Webpack (legacy)-- **Testing**: Jest + React Testing Library, Cypress+- Check for hardcoded secrets, API keys, or credentials+- Look for SQL injection and XSS vulnerabilities+- Verify proper input validation and sanitization+- Review authentication and authorization logic+- Ensure enterprise features use the plugin system (no enterprise code in OSS)-### Coding Standards+### Performance Red Flags-#### Component Preferences+- Identify N+1 database query problems+- Spot inefficient loops and algorithmic issues+- Check for memory leaks and resource cleanup+- Review caching opportunities for expensive operations-- Prefer `metabase/ui`components over `metabase/common/components`-- Use `.tsx` for components, `.ts` for utilities+### Code Quality Essentials-#### Styling+- Functions should be focused and appropriately sized+- Use clear, descriptive naming conventions+- Ensure proper error handling throughout+- Remove dead code and unused imports-ALWAYS prefer Mantine style props,then CSS modules. DO NOT suggest styled components, they are deprecated.+### Review Style-#### TypeScript Migration+- Only flag actual issues worth mentioning+- Do not post "looks good" comments or congratulate following conventions+- Be specific and actionable in feedback+- Explain the "why" behind recommendations+- Ask clarifying questions when code intent is unclear-When heavily editing `.js`/`.jsx` files, create a separate PR to convert to TypeScript first, then implement changes.+### Review Format-#### Enterprise Features+- Condense feedback into as few comments as possible+- Prefer a single summary comment over dozens of inline comments+- Only use inline comments for critical issues that require immediate attention+- For non-critical issues, link to the specific line from the summary instead+- Delete all stale comments and summaries on each new push or CI run-Enterprise functionality MUST use the plugin system. It is very important to not expose enterprise code in the OSS version.--#### Testing Requirements--All PRs should include tests. Prefer Unit tests over E2E tests.--#### Localization--All user-facing strings MUST be localized using the ttag library. Localized strings should be complete phrases, do not concatenate a few separately localized strings. You should add context to strings where the meaning of the string might not be obvious in isolation: e.g. "Home" might have different words in some languages depending on whether you're talking about a dwelling or the landing page for a website.+Language-specific rules are in `.github/instructions/*.instructions.md`.diff --git a/.github/instructions/clojure.instructions.md b/.github/instructions/clojure.instructions.mdnew file mode 100644index 00000000000..bb1286bd236--- /dev/null+++ b/.github/instructions/clojure.instructions.md@@ -0,0 +1,9 @@+---+applyTo: "**/*.{clj,cljs,cljc}"+---++# Clojure/ClojureScript Code Review++When reviewing Clojure or ClojureScript code, apply the guidelines in these files:+- `.claude/skills/_shared/clojure-style-guide.md`+- `.claude/skills/clojure-review/SKILL.md`diff --git a/.github/instructions/docs.instructions.md b/.github/instructions/docs.instructions.mdnew file mode 100644index 00000000000..d810b1f0afb--- /dev/null+++ b/.github/instructions/docs.instructions.md@@ -0,0 +1,9 @@+---+applyTo: "docs/**/*.md"+---++# Documentation Review++When reviewing documentation, apply the guidelines in these files:+- `.claude/skills/_shared/metabase-style-guide.md`+- `.claude/skills/docs-review/SKILL.md`diff --git a/.github/instructions/typescript.instructions.md b/.github/instructions/typescript.instructions.mdnew file mode 100644index 00000000000..1c737ad3697--- /dev/null+++ b/.github/instructions/typescript.instructions.md@@ -0,0 +1,11 @@+---+applyTo: "**/*.{ts,tsx,js,jsx}"+---++# TypeScript/JavaScript Code Review++When reviewing TypeScript or JavaScript code, apply the guidelines in these files:++- `.claude/skills/typescript-review/SKILL.md`+- `docs/developers-guide/frontend.md`+- `frontend/CLAUDE.md`