Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Increase min height for query builder header (#74068)

Nick Fitzpatrick840127211b59
diff --git a/e2e/test/scenarios/question/saved.cy.spec.js b/e2e/test/scenarios/question/saved.cy.spec.js
index 0d85562d8dc..3a93ca0cd49 100644
--- a/e2e/test/scenarios/question/saved.cy.spec.js
+++ b/e2e/test/scenarios/question/saved.cy.spec.js
@@ -21,6 +21,15 @@ describe("scenarios > question > saved", () => {
H.visitQuestion(ORDERS_QUESTION_ID);
cy.findAllByText("Orders"); // question and table name appears
+ // capture the view header height in the saved state to assert it does not
+ // change after the question transitions to ad-hoc (UXW-3751)
+ let savedHeaderHeight;
+ cy.findByTestId("qb-header")
+ .invoke("outerHeight")
+ .then((h) => {
+ savedHeaderHeight = h;
+ });
+
// filter to only orders with quantity=100
H.tableHeaderClick("Quantity");
H.popover().findByText("Filter by this column").click();
@@ -35,10 +44,17 @@ describe("scenarios > question > saved", () => {
// eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
cy.findByText("Showing 2 rows"); // query updated
+ // view header height should be unchanged in the ad-hoc state
+ cy.findByTestId("qb-header")
+ .invoke("outerHeight")
+ .should((h) => {
+ expect(h).to.equal(savedHeaderHeight);
+ });
+
// check that save will give option to replace
// eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
cy.findByText("Save").click();
- cy.findByTestId("save-question-modal").within((modal) => {
+ cy.findByTestId("save-question-modal").within(() => {
cy.findByText('Replace original question, "Orders"');
cy.findByText("Save as new question");
cy.findByText("Cancel").click();
diff --git a/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx b/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx
index 551e73d4b44..f494c3a3906 100644
--- a/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx
+++ b/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx
@@ -31,6 +31,7 @@ export function SavedQuestionHeaderButton({
maxLength={QUESTION_NAME_MAX_LENGTH}
onChange={onSave}
data-testid="saved-question-header-title"
+ lh={undefined}
/>
<Flex
diff --git a/frontend/src/metabase/query_builder/components/view/View/ViewHeaderContainer/ViewHeaderContainer.module.css b/frontend/src/metabase/query_builder/components/view/View/ViewHeaderContainer/ViewHeaderContainer.module.css
index bc1113e35a9..f201f77e447 100644
--- a/frontend/src/metabase/query_builder/components/view/View/ViewHeaderContainer/ViewHeaderContainer.module.css
+++ b/frontend/src/metabase/query_builder/components/view/View/ViewHeaderContainer/ViewHeaderContainer.module.css
@@ -2,7 +2,7 @@
border-bottom: 1px solid var(--mb-color-border);
padding-top: 8px;
padding-bottom: 8px;
- min-height: 4rem;
+ min-height: 4.25rem; /* Give some extra space so various verisons of the header have a consistent height (saved question, ad-hoc, etc) */
}
.QueryBuilderViewHeaderContainer {