Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UIT-138: Make unchecked checkboxes and radios look enabled (#85364)

Will Fry85fd424ebbba
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png
index 983fb00f57c..5056c182bc2 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png
index 8e38f85cbf5..2094b4d1c84 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png
index 983fb00f57c..5056c182bc2 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png
index f7cbd7e27a7..4842ac528ce 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png
index 029c506bae8..c1eddf1b579 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png
index 314806a16bd..e56b3e3c129 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png
index 029c506bae8..277cb37c1e4 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png
index 2a533495a9d..212ab02f38d 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Checkbox_Card.png b/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Checkbox_Card.png
index 4efca9db8a4..1bb4673b6fe 100644
Binary files a/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Checkbox_Card.png and b/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Checkbox_Card.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Overview.png b/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Overview.png
index 2b562d79c7e..000cd33d740 100644
Binary files a/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Overview.png and b/.loki/reference/chrome_laptop_Components_Inputs_Checkbox_Overview.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Inputs_Radio_Overview.png b/.loki/reference/chrome_laptop_Components_Inputs_Radio_Overview.png
index 58a75f24ec5..4632d8f6c8a 100644
Binary files a/.loki/reference/chrome_laptop_Components_Inputs_Radio_Overview.png and b/.loki/reference/chrome_laptop_Components_Inputs_Radio_Overview.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Inputs_Radio_Radio_Card.png b/.loki/reference/chrome_laptop_Components_Inputs_Radio_Radio_Card.png
index b9fdb7af045..1b84f5d3c9c 100644
Binary files a/.loki/reference/chrome_laptop_Components_Inputs_Radio_Radio_Card.png and b/.loki/reference/chrome_laptop_Components_Inputs_Radio_Radio_Card.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png
index 3424449e9b6..b38bd509893 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png
index 1bc366d4cdc..7cb1d391e20 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_DataGrid_DataGrid_Selectable_Rows.png b/.loki/reference/chrome_laptop_DataGrid_DataGrid_Selectable_Rows.png
index 36fe3a3a651..678e7bab68d 100644
Binary files a/.loki/reference/chrome_laptop_DataGrid_DataGrid_Selectable_Rows.png and b/.loki/reference/chrome_laptop_DataGrid_DataGrid_Selectable_Rows.png differ
diff --git a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
index bba1c2620f7..577655254da 100644
--- a/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
+++ b/frontend/src/metabase/ui/components/inputs/Checkbox/Checkbox.module.css
@@ -56,8 +56,9 @@
}
.input {
- border: 1px solid var(--mb-color-border-neutral-strong);
- background-color: var(--mb-color-background_surface-secondary);
+ border: 1px solid var(--mb-color-border-neutral-strongest);
+ background-color: var(--mb-color-background_surface-primary);
+ box-shadow: var(--mantine-shadow-xs);
&:not(:disabled) {
cursor: pointer;
@@ -74,6 +75,7 @@
&:disabled {
border-color: transparent;
background-color: var(--mb-color-background_surface-disabled);
+ box-shadow: none;
}
}
@@ -128,8 +130,9 @@
flex-shrink: 0;
margin-top: rem(1px);
- border: 1px solid var(--mb-color-border-neutral-strong);
- background-color: var(--mb-color-background_surface-secondary);
+ border: 1px solid var(--mb-color-border-neutral-strongest);
+ background-color: var(--mb-color-background_surface-primary);
+ box-shadow: var(--mantine-shadow-xs);
&[data-checked] {
border-color: var(--mb-color-border-neutral-strong);
@@ -141,6 +144,7 @@
border-color: transparent;
background-color: var(--mb-color-background_surface-disabled);
+ box-shadow: none;
/* Mantine pins the disabled+checked icon color per scheme with (0,5,0) specificity */
[data-mantine-color-scheme] &[data-checked] > .icon {
diff --git a/frontend/src/metabase/ui/components/inputs/Radio/Radio.module.css b/frontend/src/metabase/ui/components/inputs/Radio/Radio.module.css
index 43befbeebc6..4e5af7eb182 100644
--- a/frontend/src/metabase/ui/components/inputs/Radio/Radio.module.css
+++ b/frontend/src/metabase/ui/components/inputs/Radio/Radio.module.css
@@ -37,8 +37,9 @@
}
.radio {
- border: 1px solid var(--mb-color-border-neutral-strong);
- background-color: var(--mb-color-background_surface-secondary);
+ border: 1px solid var(--mb-color-border-neutral-strongest);
+ background-color: var(--mb-color-background_surface-primary);
+ box-shadow: var(--mantine-shadow-xs);
&:not(:disabled) {
cursor: pointer;
@@ -52,6 +53,7 @@
&:disabled {
border-color: transparent;
background-color: var(--mb-color-background_surface-disabled);
+ box-shadow: none;
}
}
@@ -102,8 +104,9 @@
flex-shrink: 0;
margin-top: rem(1px);
- border: 1px solid var(--mb-color-border-neutral-strong);
- background-color: var(--mb-color-background_surface-secondary);
+ border: 1px solid var(--mb-color-border-neutral-strongest);
+ background-color: var(--mb-color-background_surface-primary);
+ box-shadow: var(--mantine-shadow-xs);
&[data-checked] {
border-color: var(--mb-color-border-neutral-strong);
@@ -115,6 +118,7 @@
border-color: transparent;
background-color: var(--mb-color-background_surface-disabled);
+ box-shadow: none;
[data-mantine-color-scheme] &[data-checked] > .icon {
color: var(--mb-color-text-disabled);