Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[BOT-1233] Fix `get-table-details` arg flag typos (#71679)

Tyler Plude878fc365a301
diff --git a/src/metabase/metabot/tools/resources.clj b/src/metabase/metabot/tools/resources.clj
index ca715139281..9580f63e972 100644
--- a/src/metabase/metabot/tools/resources.clj
+++ b/src/metabase/metabot/tools/resources.clj
@@ -78,18 +78,18 @@
;; metabase://table/123/fields
(= sub-resource "fields")
(entity-details/get-table-details {:table-id table-id
- :with-fields true
- :with-field-values false
- :with-related-tables false
+ :with-fields? true
+ :with-field-values? false
+ :with-related-tables? false
:with-measures? true
:with-segments? true})
;; metabase://table/123
(nil? sub-resource)
(entity-details/get-table-details {:table-id table-id
- :with-fields false
- :with-field-values false
- :with-related-tables false
+ :with-fields? false
+ :with-field-values? false
+ :with-related-tables? false
:with-measures? true
:with-segments? true})
@@ -112,18 +112,18 @@
;; metabase://model/123/fields
(= sub-resource "fields")
(entity-details/get-table-details {:model-id model-id
- :with-fields true
- :with-field-values false
- :with-related-tables false
+ :with-fields? true
+ :with-field-values? false
+ :with-related-tables? false
:with-measures? true
:with-segments? true})
;; metabase://model/123
(nil? sub-resource)
(entity-details/get-table-details {:model-id model-id
- :with-fields false
- :with-field-values false
- :with-related-tables false
+ :with-fields? false
+ :with-field-values? false
+ :with-related-tables? false
:with-measures? true
:with-segments? true})
diff --git a/test/metabase/metabot/tools/resources_test.clj b/test/metabase/metabot/tools/resources_test.clj
index 1c06f348da4..6a55bee56a6 100644
--- a/test/metabase/metabot/tools/resources_test.clj
+++ b/test/metabase/metabot/tools/resources_test.clj
@@ -96,6 +96,26 @@
(read-resource/read-resource
{:uris ["metabase://table/99999"]}))))))))
+(deftest read-table-resource-excludes-related-tables-test
+ (testing "table resources should not include related_tables (to avoid bloated responses)"
+ (mt/test-drivers #{:h2}
+ (mt/with-current-user (mt/user->id :crowberto)
+ ;; Use orders table which has FK relationships to other tables
+ (let [orders-id (mt/id :orders)]
+ (testing "metabase://table/:id excludes related_tables"
+ (let [result (read-resource/read-resource
+ {:uris [(str "metabase://table/" orders-id)]})
+ output (get-in result [:resources 0 :content :structured-output])]
+ (is (nil? (:related_tables output))
+ "table resource should not include related_tables")))
+
+ (testing "metabase://table/:id/fields excludes related_tables"
+ (let [result (read-resource/read-resource
+ {:uris [(str "metabase://table/" orders-id "/fields")]})
+ output (get-in result [:resources 0 :content :structured-output])]
+ (is (nil? (:related_tables output))
+ "table/fields resource should not include related_tables"))))))))
+
(deftest read-dashboard-resource-test
(mt/with-current-user (mt/user->id :crowberto)
(mt/with-temp [:model/Dashboard {dashboard-id :id dashboard-name :name}