Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Make Trunk analytics always run (#65451)

Nemanja Glumac8a9a134989b6
diff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.yml
index 38af70ff6a8..727299f3dac 100644
--- a/.github/actions/test-driver/action.yml
+++ b/.github/actions/test-driver/action.yml
@@ -29,10 +29,9 @@ runs:
shell: bash
id: run-test
# Trunk Quarantine controls the final state of the run in the CI!
- # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to
- # pass the whole job, based on the quarantine list.
- # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!
- continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
+ # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
+ # whether to fail or to pass the whole job, based on the quarantine list.
+ continue-on-error: true
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@v1
# As per the documentation: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#steps-context
diff --git a/.github/actions/upload-test-results/action.yml b/.github/actions/upload-test-results/action.yml
index 7d9e23feb4a..c97b51cd65e 100644
--- a/.github/actions/upload-test-results/action.yml
+++ b/.github/actions/upload-test-results/action.yml
@@ -48,10 +48,11 @@ runs:
aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
- name: Upload results to Trunk
- if: ${{ always() && !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
+ if: always() # Important! This step must always run because it controls job's exit code.
uses: trunk-io/analytics-uploader@main
with:
junit-paths: ${{ inputs.input-path }}
variant: ${{ inputs.variant || inputs.output-name }}
org-slug: metabase
+ dry-run: ${{ github.event_name == 'pull_request' && github.event.pull_request.draft == true }} # quarantine, but do not upload results
token: ${{ inputs.trunk-api-token }}
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index 3d42f79809a..5a28dc3d96b 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -130,10 +130,9 @@ jobs:
:exclude-tags '[:mb/driver-tests ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
${{ matrix.job.test-args }}
# Trunk Quarantine controls the final state of the run in the CI!
- # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to
- # pass the whole job, based on the quarantine list.
- # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!
- continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
+ # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
+ # whether to fail or to pass the whole job, based on the quarantine list.
+ continue-on-error: true
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
index 9a96b45495d..6dccd1eb7cd 100644
--- a/.github/workflows/e2e-test.yml
+++ b/.github/workflows/e2e-test.yml
@@ -146,10 +146,9 @@ jobs:
--spec "$SPEC_PATH" \
--browser ${{ steps.cypress-prep.outputs.chrome-path }}
# Trunk Quarantine controls the final state of the run in the CI!
- # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to
- # pass the whole job, based on the quarantine list.
- # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!
- continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
+ # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
+ # whether to fail or to pass the whole job, based on the quarantine list.
+ continue-on-error: true
- name: Run Tagged EE Cypress tests on ${{ inputs.name }}
if: ${{ inputs.specs }}
@@ -163,10 +162,9 @@ jobs:
--spec "$SPEC_PATH" \
--browser ${{ steps.cypress-prep.outputs.chrome-path }}
# Trunk Quarantine controls the final state of the run in the CI!
- # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to
- # pass the whole job, based on the quarantine list.
- # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!
- continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
+ # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
+ # whether to fail or to pass the whole job, based on the quarantine list.
+ continue-on-error: true
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
index 870ddad40ae..62d21d93d3f 100644
--- a/.github/workflows/frontend.yml
+++ b/.github/workflows/frontend.yml
@@ -91,8 +91,9 @@ jobs:
uses: ./.github/actions/prepare-backend
- name: Run frontend unit tests
run: yarn run test-unit --silent --shard=${{ matrix.shard }}/${{ env.SHARDS }}
- # We want Trunk to still receive test reports even if this job fails.
- # It will filter out the quarantined tests, and will control the job exit code based on the analysis.
+ # Trunk Quarantine controls the final state of the run in the CI!
+ # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
+ # whether to fail or to pass the whole job, based on the quarantine list.
continue-on-error: true
- name: Upload Test Results
uses: ./.github/actions/upload-test-results