Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flaky Remote Sync test (#65862)

John Swanson8b369333c336
diff --git a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
index e18b28a00ee..22b9ce0b8b8 100644
--- a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
+++ b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
@@ -597,7 +597,7 @@ describe("Remote Sync", () => {
cy.visit("/admin/settings/remote-sync");
cy.findByLabelText("Sync branch").clear().type("test");
- cy.button("Save changes").click();
+ cy.findByTestId("remote-sync-submit-button").click();
cy.findByTestId("admin-layout-content")
.findByText("Success")
@@ -609,7 +609,7 @@ describe("Remote Sync", () => {
H.waitForTask({ taskName: "import" });
- cy.findByRole("button", { name: "Save changes" }).should("be.disabled");
+ cy.findByTestId("remote-sync-submit-button").should("be.disabled");
cy.visit("/");
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncAdminSettings.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncAdminSettings.tsx
index 93d314a1206..e0700ea0c76 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncAdminSettings.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncAdminSettings.tsx
@@ -305,6 +305,7 @@ export const RemoteSyncAdminSettings = () => {
</Button>
)}
<FormSubmitButton
+ data-testid="remote-sync-submit-button"
label={
isRemoteSyncEnabled
? t`Save changes`