Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Test registration fixes (#82130)

Ben Grabow8b58b48375ce
diff --git a/enterprise/backend/test/metabase_enterprise/remote_sync/source/ingestable_test.clj b/enterprise/backend/test/metabase_enterprise/remote_sync/source/ingestable_test.clj
index 136ea3e309b..a07997f3cd8 100644
--- a/enterprise/backend/test/metabase_enterprise/remote_sync/source/ingestable_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/remote_sync/source/ingestable_test.clj
@@ -5,10 +5,15 @@
[metabase-enterprise.remote-sync.source.protocol :as source.p]
[metabase-enterprise.remote-sync.test-helpers :as test-helpers]
[metabase-enterprise.serialization.core :as serialization]
+ [metabase.audit-app.events.audit-log]
[metabase.test.fixtures :as fixtures]
[metabase.test.util :as mt]
+ [metabase.users.settings]
[toucan2.core :as t2]))
+(comment metabase.audit-app.events.audit-log/keep-me
+ metabase.users.settings/keep-me)
+
(use-fixtures :each test-helpers/clean-remote-sync-state)
(use-fixtures :once (fixtures/initialize :db))
diff --git a/enterprise/backend/test/metabase_enterprise/serialization/models/entity_id_test.clj b/enterprise/backend/test/metabase_enterprise/serialization/models/entity_id_test.clj
index b06e5f15c67..1ad0a9ecc56 100644
--- a/enterprise/backend/test/metabase_enterprise/serialization/models/entity_id_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/serialization/models/entity_id_test.clj
@@ -7,6 +7,7 @@
(:require
[clojure.test :refer :all]
[metabase-enterprise.serialization.v2.models :as serdes.models]
+ [metabase.classloader.core :as classloader]
[metabase.models.resolution :as models.resolution]
[metabase.models.serialization :as serdes]))
@@ -171,4 +172,6 @@
(testing (format (str "Model %s should either: have the ::mi/entity-id property, or be explicitly listed as having "
"an external name, or explicitly listed as excluded from serialization")
model)
+ ;; the property is registered by the model's own namespace, which nothing else here loads
+ (classloader/require (models.resolution/model->namespace model))
(is (serdes/has-entity-id? model))))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_inspector/lens_output_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_inspector/lens_output_test.clj
index 17d9663e04a..1d463d4c764 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_inspector/lens_output_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_inspector/lens_output_test.clj
@@ -2,6 +2,7 @@
"Tests for lens card output validation and trigger flow."
(:require
[clojure.test :refer :all]
+ [metabase-enterprise.transforms-inspector.core]
[metabase-enterprise.transforms-inspector.lens.core :as lens.core]
[metabase.lib.core :as lib]
[metabase.lib.metadata :as lib.metadata]
@@ -13,6 +14,8 @@
(set! *warn-on-reflection* true)
+(comment metabase-enterprise.transforms-inspector.core/keep-me)
+
;;; -------------------------------------------------- Test context helpers --------------------------------------------------
(defn- collect-field-metadata
diff --git a/test/metabase/api/common_test.clj b/test/metabase/api/common_test.clj
index 09ac7793314..dbfbe23cb80 100644
--- a/test/metabase/api/common_test.clj
+++ b/test/metabase/api/common_test.clj
@@ -4,7 +4,9 @@
[mb.hawk.assert-exprs.approximately-equal :as hawk.approx]
[metabase.api.common :as api]
[metabase.events.core :as events]
+ [metabase.measures.models.measure]
[metabase.models.interface :as mi]
+ [metabase.segments.models.segment]
[metabase.server.middleware.exceptions :as mw.exceptions]
[metabase.server.middleware.misc :as mw.misc]
[metabase.server.middleware.security :as mw.security]
@@ -13,6 +15,9 @@
[methodical.core :as methodical])
(:import (clojure.lang ExceptionInfo)))
+(comment metabase.measures.models.measure/keep-me
+ metabase.segments.models.segment/keep-me)
+
;;; TESTS FOR CHECK (ETC)
(defn- four-oh-four
diff --git a/test/metabase/channel/email_test.clj b/test/metabase/channel/email_test.clj
index e84a3bf3c69..e001f89a8bd 100644
--- a/test/metabase/channel/email_test.clj
+++ b/test/metabase/channel/email_test.clj
@@ -5,6 +5,7 @@
[clojure.string :as str]
[clojure.test :refer :all]
[medley.core :as m]
+ [metabase.audit-app.events.audit-log]
[metabase.channel.api.email :as api.email]
[metabase.channel.email :as email]
[metabase.channel.settings :as channel.settings]
@@ -26,6 +27,8 @@
(set! *warn-on-reflection* true)
+(comment metabase.audit-app.events.audit-log/keep-me)
+
;; TODO - this should be made dynamic so it's (at least theoretically) possible to use this in parallel
(def inbox
"Map of email addresses -> sequence of messages they've received."
diff --git a/test/metabase/lib_be/json_schema_test.clj b/test/metabase/lib_be/json_schema_test.clj
index c6b956697bc..77ea3b1c1f6 100644
--- a/test/metabase/lib_be/json_schema_test.clj
+++ b/test/metabase/lib_be/json_schema_test.clj
@@ -7,12 +7,15 @@
[metabase.lib-be.json-schema :as js]
[metabase.lib.core :as lib]
[metabase.lib.test-metadata :as meta]
+ [metabase.server.middleware.json]
[metabase.util.json :as json-util])
(:import
(com.github.erosb.jsonsKema FormatValidationPolicy JsonParser SchemaLoader Validator ValidatorConfig)))
(set! *warn-on-reflection* true)
+(comment metabase.server.middleware.json/keep-me)
+
(defn- check-node [node]
(when (map? node)
(when (contains? node "type")
diff --git a/test/metabase/server/middleware/offset_paging_test.clj b/test/metabase/server/middleware/offset_paging_test.clj
index dc9429db798..9fc707788f6 100644
--- a/test/metabase/server/middleware/offset_paging_test.clj
+++ b/test/metabase/server/middleware/offset_paging_test.clj
@@ -4,12 +4,15 @@
[clojure.test :refer :all]
[metabase.request.core :as request]
[metabase.server.handler :as handler]
+ [metabase.tiles.settings]
[metabase.util.json :as json]
[ring.mock.request :as ring.mock]
[ring.util.response :as response])
(:import
(java.io PipedInputStream)))
+(comment metabase.tiles.settings/keep-me)
+
(defn- handler [request]
(let [handler (fn [request respond _]
(respond (response/response {:limit (request/limit)
diff --git a/test/metabase/server/middleware/ssl_test.clj b/test/metabase/server/middleware/ssl_test.clj
index 81debe69be1..7564d60189f 100644
--- a/test/metabase/server/middleware/ssl_test.clj
+++ b/test/metabase/server/middleware/ssl_test.clj
@@ -1,11 +1,14 @@
(ns metabase.server.middleware.ssl-test
(:require
[clojure.test :refer :all]
+ [metabase.audit-app.events.audit-log]
[metabase.server.middleware.ssl :as mw.ssl]
[metabase.test.util :as tu]
[ring.mock.request :as ring.mock]
[ring.util.response :as response]))
+(comment metabase.audit-app.events.audit-log/keep-me)
+
(defn- handler [request]
((mw.ssl/redirect-to-https-middleware
(fn [_request respond _raise] (respond (response/response ""))))
diff --git a/test/metabase/settings/models/setting/multi_setting_test.clj b/test/metabase/settings/models/setting/multi_setting_test.clj
index 8ddd925f581..f5e1ff8a603 100644
--- a/test/metabase/settings/models/setting/multi_setting_test.clj
+++ b/test/metabase/settings/models/setting/multi_setting_test.clj
@@ -1,10 +1,13 @@
(ns metabase.settings.models.setting.multi-setting-test
(:require
[clojure.test :refer :all]
+ [metabase.audit-app.events.audit-log]
[metabase.settings.models.setting :as setting]
[metabase.settings.models.setting.multi-setting :as multi-setting]
[metabase.test.fixtures :as fixtures]))
+(comment metabase.audit-app.events.audit-log/keep-me)
+
(use-fixtures :once (fixtures/initialize :db))
(def ^:dynamic ^:private *parakeet* :green-friend)
diff --git a/test/metabase/transforms/revision_test.clj b/test/metabase/transforms/revision_test.clj
index 1ef94ea3f53..fadd79dc7b7 100644
--- a/test/metabase/transforms/revision_test.clj
+++ b/test/metabase/transforms/revision_test.clj
@@ -1,8 +1,11 @@
(ns metabase.transforms.revision-test
(:require
[clojure.test :refer :all]
+ [metabase.revisions.impl.transform]
[metabase.revisions.models.revision :as revision]))
+(comment metabase.revisions.impl.transform/keep-me)
+
(deftest transform-serialize-instance-test
(testing "serialize-instance for :model/Transform excludes the correct columns"
(let [transform {:id 1