Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

card creator field selection (#79065)

Arik Aronov8b8d31b5d26a
diff --git a/src/metabase/queries_rest/api/card.clj b/src/metabase/queries_rest/api/card.clj
index 1428327a39f..eb954c2cf32 100644
--- a/src/metabase/queries_rest/api/card.clj
+++ b/src/metabase/queries_rest/api/card.clj
@@ -218,6 +218,7 @@
[:moderation_reviews :moderator_details]
:param_fields
:is_remote_synced)
+ (update :creator select-keys [:id :first_name :last_name :email :common_name])
(update :param_fields (fn [param-fields]
(let [viewable? (memoize (fn [table-id]
(perms/user-has-permission-for-table?
diff --git a/test/metabase/queries_rest/api/card_test.clj b/test/metabase/queries_rest/api/card_test.clj
index c93ce6e8f97..85f818e78b3 100644
--- a/test/metabase/queries_rest/api/card_test.clj
+++ b/test/metabase/queries_rest/api/card_test.clj
@@ -800,9 +800,8 @@
:last-edit-info {:timestamp true :id true :first_name "Rasta"
:last_name "Toucan" :email "[email protected]"}
:creator (merge
- (select-keys (mt/fetch-user :rasta) [:id :date_joined :last_login :locale])
+ (select-keys (mt/fetch-user :rasta) [:id])
{:common_name "Rasta Toucan"
- :is_superuser false
:last_name "Toucan"
:first_name "Rasta"
:email "[email protected]"})
@@ -815,7 +814,6 @@
(update :dataset_query map?)
(update :entity_id string?)
(update :result_metadata (partial every? map?))
- (update :creator dissoc :is_qbnewb)
(update :last-edit-info (fn [edit-info]
(-> edit-info
(update :id boolean)
@@ -1618,10 +1616,8 @@
:parameter_usage_count 0
:creator_id (mt/user->id :rasta)
:creator (merge
- (select-keys (mt/fetch-user :rasta) [:id :date_joined :last_login])
+ (select-keys (mt/fetch-user :rasta) [:id])
{:common_name "Rasta Toucan"
- :is_superuser false
- :is_qbnewb true
:last_name "Toucan"
:first_name "Rasta"
:email "[email protected]"})