The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-1585 Update incremental transform warning copy for complex queries (#69109)
Kamil Mielnik8c0645cc97ba
diff --git a/frontend/src/metabase/transforms/components/QueryComplexityWarning/QueryComplexityWarning.tsx b/frontend/src/metabase/transforms/components/QueryComplexityWarning/QueryComplexityWarning.tsxindex 566bb20d891..d99543e2305 100644--- a/frontend/src/metabase/transforms/components/QueryComplexityWarning/QueryComplexityWarning.tsx+++ b/frontend/src/metabase/transforms/components/QueryComplexityWarning/QueryComplexityWarning.tsx@@ -1,30 +1,18 @@import cx from "classnames";-import { c, t } from "ttag";+import { t } from "ttag";-import { uncapitalize } from "metabase/lib/formatting/strings";import { CHECKPOINT_TEMPLATE_TAG } from "metabase/transforms/constants";import { Stack, Text } from "metabase/ui";-import type { QueryComplexity } from "metabase-types/api";import S from "./QueryComplexityWarning.module.css";type QueryComplexityWarningProps = {variant?: "default" | "standout";- complexity: QueryComplexity;};export const QueryComplexityWarning = ({variant = "default",- complexity,}: QueryComplexityWarningProps) => {- const renderParagraph = () => {- const reason = uncapitalize(complexity.reason);- return c(- "{0} is a reason phrase like 'contains a LIMIT', 'contains an OFFSET', 'contains a CTE', or 'is not a simple SELECT'",- )- .t`Because this query ${reason}, we can't automatically select a checkpoint column. You should either remove the LIMIT, turn off incremental transformation, or add an explicit conditional filter to the query, like this:`;- };-return (<Stackgap={variant === "standout" ? "sm" : "md"}@@ -34,7 +22,7 @@ export const QueryComplexityWarning = ({{variant === "standout" && (<Text fw="bold">{t`We couldn’t add the check automatically.`}</Text>)}- <Text lh="1.25rem">{renderParagraph()}</Text>+ <Text lh="1.25rem">{t`This query is too complicated for us to automatically add a checkpoint. You can turn off incremental transformation, or add an explicit filter to the query, like this:`}</Text><Textlh="1.25rem"py="md"diff --git a/frontend/src/metabase/transforms/components/QueryComplexityWarning/use-query-complexity-checks.tsx b/frontend/src/metabase/transforms/components/QueryComplexityWarning/use-query-complexity-checks.tsxindex db706443428..f7f5142ce5e 100644--- a/frontend/src/metabase/transforms/components/QueryComplexityWarning/use-query-complexity-checks.tsx+++ b/frontend/src/metabase/transforms/components/QueryComplexityWarning/use-query-complexity-checks.tsx@@ -63,7 +63,7 @@ export const useQueryComplexityChecks = () => {return new Promise<boolean>((resolve) => {show({title: t`Can't automatically run this transform incrementally`,- message: <QueryComplexityWarning complexity={complexity} />,+ message: <QueryComplexityWarning />,onConfirm: () => resolve(true),onCancel: () => resolve(false),confirmButtonText,diff --git a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsxindex 1f33c945d33..567430118d6 100644--- a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx+++ b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx@@ -201,9 +201,7 @@ function CreateTransformForm({onIncrementalChange={handleIncrementalChange}/>)}- {complexity && (- <QueryComplexityWarning complexity={complexity} variant="standout" />- )}+ {complexity && <QueryComplexityWarning variant="standout" />}<Group><Box flex={1}><FormErrorMessage />