The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Don't hit DWH server when no parameters are being set (#81727)
Ben Grabow8e4e18f6d569
diff --git a/src/metabase/driver/sql_jdbc/execute.clj b/src/metabase/driver/sql_jdbc/execute.cljindex 0ed11014073..c05325dccc0 100644--- a/src/metabase/driver/sql_jdbc/execute.clj+++ b/src/metabase/driver/sql_jdbc/execute.clj@@ -529,9 +529,12 @@"Set parameters for the prepared statement by calling `set-parameter` for each parameter."{:added "0.35.0"}[driver stmt params]- (when (< (try (.. ^PreparedStatement stmt getParameterMetaData getParameterCount)- (catch Throwable _ (count params)))- (count params))+ ;; `getParameterMetaData` costs a server round trip on some drivers -- Snowflake describes the statement -- so only+ ;; ask when there are parameters that could outnumber the placeholders.+ (when (and (seq params)+ (< (try (.. ^PreparedStatement stmt getParameterMetaData getParameterCount)+ (catch Throwable _ (count params)))+ (count params)))(throw (ex-info (tru "It looks like we got more parameters than we can handle, remember that parameters cannot be used in comments or as identifiers."){:driver driver:type driver-api/qp.error-type.driver