Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move ActionViz into dashboard (#73614)

Fraser8f1ff6aeb5a2
diff --git a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
index f3f16b861be..c6e739e00bb 100644
--- a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
@@ -2,12 +2,12 @@ import { useDisclosure } from "@mantine/hooks";
import { useMemo } from "react";
import { t } from "ttag";
-import ActionViz from "metabase/actions/components/ActionViz";
-import { ActionDashcardSettings } from "metabase/actions/components/ActionViz/ActionDashcardSettings";
import { isActionDashCard } from "metabase/actions/utils";
import { FormField } from "metabase/common/components/FormField/FormField";
import { Sidebar } from "metabase/common/components/Sidebar";
import CS from "metabase/css/core/index.css";
+import ActionViz from "metabase/dashboard/components/ActionViz";
+import { ActionDashcardSettings } from "metabase/dashboard/components/ActionViz/ActionDashcardSettings";
import { useDashboardContext } from "metabase/dashboard/context";
import { Form, FormProvider, FormSelect, FormTextInput } from "metabase/forms";
import {
diff --git a/frontend/src/metabase/actions/components/ActionViz/Action.tsx b/frontend/src/metabase/dashboard/components/ActionViz/Action.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/Action.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/Action.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/Action.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ActionViz/Action.unit.spec.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/Action.unit.spec.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/Action.unit.spec.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionButton.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionButton.styled.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionButton.styled.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionButton.styled.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionButtonView.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionButtonView.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.styled.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.styled.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.styled.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionForm.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionForm.styled.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionForm.styled.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionForm.styled.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionParameterMapping.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionParameterMapping.styled.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionParameterMapping.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionParameterMapping.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionViz.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionViz.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionViz.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionViz.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionVizForm.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionVizForm.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionVizForm.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionVizForm.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionVizForm.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionVizForm.unit.spec.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ActionVizForm.unit.spec.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ActionVizForm.unit.spec.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/ExplainerText.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/ExplainerText.styled.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/ExplainerText.styled.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/ExplainerText.styled.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/ExplainerText.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/ExplainerText.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/ExplainerText.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/ExplainerText.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/index.ts b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/index.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/index.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/index.ts
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/common.unit.spec.ts b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/common.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/common.unit.spec.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/common.unit.spec.ts
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/enterprise.unit.spec.ts b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/enterprise.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/enterprise.unit.spec.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/enterprise.unit.spec.ts
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/premium.unit.spec.ts b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/premium.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/premium.unit.spec.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/premium.unit.spec.ts
diff --git a/frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/setup.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/setup.tsx
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/ExplainerText/tests/setup.tsx
rename to frontend/src/metabase/dashboard/components/ActionViz/ExplainerText/tests/setup.tsx
diff --git a/frontend/src/metabase/actions/components/ActionViz/index.ts b/frontend/src/metabase/dashboard/components/ActionViz/index.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/index.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/index.ts
diff --git a/frontend/src/metabase/actions/components/ActionViz/utils.ts b/frontend/src/metabase/dashboard/components/ActionViz/utils.ts
similarity index 100%
rename from frontend/src/metabase/actions/components/ActionViz/utils.ts
rename to frontend/src/metabase/dashboard/components/ActionViz/utils.ts
diff --git a/frontend/src/metabase/dashboard/visualizations/register.js b/frontend/src/metabase/dashboard/visualizations/register.js
index 678f792cfca..19dc42482f6 100644
--- a/frontend/src/metabase/dashboard/visualizations/register.js
+++ b/frontend/src/metabase/dashboard/visualizations/register.js
@@ -1,3 +1,4 @@
+import ActionViz from "metabase/dashboard/components/ActionViz";
import { registerVisualization } from "metabase/visualizations";
import { DashCardPlaceholder } from "./DashCardPlaceholder";
@@ -8,6 +9,7 @@ import { Text } from "./Text";
// eslint-disable-next-line import/no-default-export -- deprecated usage
export default function () {
+ registerVisualization(ActionViz);
registerVisualization(DashCardPlaceholder);
registerVisualization(Heading);
registerVisualization(LinkViz);
diff --git a/frontend/src/metabase/visualizations/register.js b/frontend/src/metabase/visualizations/register.js
index 28a9a713e34..dd8f02c8a8f 100644
--- a/frontend/src/metabase/visualizations/register.js
+++ b/frontend/src/metabase/visualizations/register.js
@@ -1,4 +1,3 @@
-import ActionViz from "metabase/actions/components/ActionViz";
import { ListViz } from "metabase/list-view/components/ListViz";
import {
registerVisualization,
@@ -47,8 +46,6 @@ export default function () {
registerVisualization(PivotTable);
registerVisualization(SankeyChart);
- registerVisualization(ActionViz);
-
registerVisualization(ListViz);
setDefaultVisualization(Table);