Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Ghy 4210 show the actual output destination for a transform run (#78874)

Egor Grushin91c76f0f4179
diff --git a/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.tsx b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.tsx
new file mode 100644
index 00000000000..b176bde6136
--- /dev/null
+++ b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.tsx
@@ -0,0 +1,86 @@
+import {
+ skipToken,
+ useGetTransformQuery,
+ useListDatabaseSchemasQuery,
+} from "metabase/api";
+import { getErrorMessage } from "metabase/api/utils";
+import { CopyButton } from "metabase/common/components/CopyButton";
+import { Box, Breadcrumbs, FixedSizeIcon, Group, Loader } from "metabase/ui";
+import * as Urls from "metabase/urls";
+import type { TransformId } from "metabase-types/api";
+
+import { TransformOutputItem } from "./TransformOutputItem";
+
+type TransformOutputProps = {
+ transformId: TransformId;
+};
+
+export const TransformOutput = ({ transformId }: TransformOutputProps) => {
+ const {
+ data: transform,
+ isLoading: isTransformLoading,
+ error: transformError,
+ } = useGetTransformQuery(transformId);
+ const table = transform?.table;
+
+ const {
+ data: schemas,
+ isLoading: isSchemasLoading,
+ error: schemasError,
+ } = useListDatabaseSchemasQuery(
+ transform
+ ? { id: transform.target.database, include_hidden: true }
+ : skipToken,
+ );
+ const isLoading = isTransformLoading || isSchemasLoading;
+ const error = transformError || schemasError;
+
+ if (isLoading) {
+ return <Loader size="xs" />;
+ }
+
+ if (error || !transform) {
+ return (
+ <Box component="span" c="error">
+ {getErrorMessage(error)}
+ </Box>
+ );
+ }
+
+ const {
+ schema: schemaName,
+ name: tableName,
+ database: databaseId,
+ } = transform.target;
+
+ return (
+ <Group gap="sm" wrap="nowrap" miw={0} lh={1}>
+ <Breadcrumbs
+ miw={0}
+ separator={<FixedSizeIcon name="chevronright" size={12} />}
+ >
+ {schemaName && (
+ <TransformOutputItem
+ icon="folder"
+ label={schemaName}
+ to={
+ schemas?.includes(schemaName)
+ ? Urls.dataModel({ databaseId, schemaName })
+ : undefined
+ }
+ data-testid="output-schema-link"
+ />
+ )}
+ <TransformOutputItem
+ icon="table2"
+ label={tableName}
+ to={table ? Urls.queryBuilderTable(table.id, table.db_id) : undefined}
+ data-testid="output-table-link"
+ />
+ </Breadcrumbs>
+ <CopyButton
+ value={schemaName ? `${schemaName}.${tableName}` : tableName}
+ />
+ </Group>
+ );
+};
diff --git a/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.unit.spec.tsx b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.unit.spec.tsx
new file mode 100644
index 00000000000..ebe94c7a98b
--- /dev/null
+++ b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutput.unit.spec.tsx
@@ -0,0 +1,166 @@
+import userEvent from "@testing-library/user-event";
+import fetchMock from "fetch-mock";
+
+import {
+ setupGetTransformEndpoint,
+ setupListDatabaseSchemasEndpoint,
+} from "__support__/server-mocks";
+import {
+ renderWithProviders,
+ screen,
+ waitForLoaderToBeRemoved,
+} from "__support__/ui";
+import type { SchemaName, Transform } from "metabase-types/api";
+import {
+ createMockTable,
+ createMockTransform,
+ createMockTransformTarget,
+} from "metabase-types/api/mocks";
+
+import { TransformOutput } from "./TransformOutput";
+
+type SetupOpts = {
+ transform?: Transform;
+ schemas?: SchemaName[];
+ error?: string;
+};
+
+const setup = async ({
+ transform = createMockTransform(),
+ schemas = [],
+ error,
+}: SetupOpts = {}) => {
+ if (error === undefined) {
+ setupGetTransformEndpoint(transform);
+ } else {
+ fetchMock.get(`path:/api/transform/${transform.id}`, {
+ status: 500,
+ body: { message: error },
+ });
+ }
+ setupListDatabaseSchemasEndpoint(transform.target.database, schemas);
+ renderWithProviders(<TransformOutput transformId={transform.id} />);
+ await waitForLoaderToBeRemoved();
+};
+
+describe("TransformOutput", () => {
+ it("should link the output schema and table", async () => {
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({
+ database: 2,
+ schema: "mb_workspace_test",
+ name: "orders",
+ }),
+ table: createMockTable({ id: 10, db_id: 2 }),
+ }),
+ schemas: ["mb_workspace_test"],
+ });
+
+ const schemaLink = screen.getByTestId("output-schema-link");
+ expect(schemaLink).toHaveTextContent("mb_workspace_test");
+ expect(schemaLink).toHaveAttribute(
+ "href",
+ "/admin/datamodel/database/2/schema/2:mb_workspace_test",
+ );
+
+ const tableLink = screen.getByTestId("output-table-link");
+ expect(tableLink).toHaveTextContent("orders");
+ expect(tableLink).toHaveAttribute("href", "/question#?db=2&table=10");
+ });
+
+ it("should not link the output table when it is not synced yet", async () => {
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({ schema: "public", name: "orders" }),
+ table: null,
+ }),
+ });
+
+ const tableItem = screen.getByTestId("output-table-link");
+ expect(tableItem).toHaveTextContent("orders");
+ expect(tableItem).not.toHaveAttribute("href");
+ });
+
+ it("should not link a schema that does not exist in the database", async () => {
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({ schema: "public", name: "orders" }),
+ table: null,
+ }),
+ schemas: ["other"],
+ });
+
+ const schemaItem = screen.getByTestId("output-schema-link");
+ expect(schemaItem).toHaveTextContent("public");
+ expect(schemaItem).not.toHaveAttribute("href");
+ });
+
+ it("should still link an existing schema when the table is not synced yet", async () => {
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({ schema: "public", name: "orders" }),
+ table: null,
+ }),
+ schemas: ["public"],
+ });
+
+ expect(screen.getByTestId("output-schema-link")).toHaveAttribute(
+ "href",
+ "/admin/datamodel/database/1/schema/1:public",
+ );
+ expect(screen.getByTestId("output-table-link")).not.toHaveAttribute("href");
+ });
+
+ it("should not render a schema when the target has none", async () => {
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({ schema: null, name: "orders" }),
+ table: createMockTable({ id: 10, db_id: 1 }),
+ }),
+ });
+
+ expect(screen.getByTestId("output-table-link")).toHaveTextContent("orders");
+ expect(screen.queryByTestId("output-schema-link")).not.toBeInTheDocument();
+ });
+
+ it("should copy the qualified table name", async () => {
+ const writeText = jest.fn().mockResolvedValue(undefined);
+ Object.assign(navigator, { clipboard: { writeText } });
+
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({
+ schema: "mb_workspace_test",
+ name: "orders",
+ }),
+ }),
+ });
+
+ await userEvent.click(screen.getByTestId("copy-button"));
+
+ expect(writeText).toHaveBeenCalledWith("mb_workspace_test.orders");
+ });
+
+ it("should copy the bare table name when the target has no schema", async () => {
+ const writeText = jest.fn().mockResolvedValue(undefined);
+ Object.assign(navigator, { clipboard: { writeText } });
+
+ await setup({
+ transform: createMockTransform({
+ target: createMockTransformTarget({ schema: null, name: "orders" }),
+ }),
+ });
+
+ await userEvent.click(screen.getByTestId("copy-button"));
+
+ expect(writeText).toHaveBeenCalledWith("orders");
+ });
+
+ it("should render an error when the transform cannot be loaded", async () => {
+ await setup({ error: "Boom" });
+
+ expect(screen.getByText("Boom")).toBeInTheDocument();
+ expect(screen.queryByTestId("output-table-link")).not.toBeInTheDocument();
+ });
+});
diff --git a/frontend/src/metabase/transforms/components/TransformOutput/TransformOutputItem.tsx b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutputItem.tsx
new file mode 100644
index 00000000000..cc815c6ef16
--- /dev/null
+++ b/frontend/src/metabase/transforms/components/TransformOutput/TransformOutputItem.tsx
@@ -0,0 +1,52 @@
+import { ForwardRefLink } from "metabase/common/components/Link";
+import { Anchor, Box, Ellipsified, FixedSizeIcon, Group } from "metabase/ui";
+import type { IconName } from "metabase-types/api";
+
+type TransformOutputItemProps = {
+ icon: IconName;
+ label: string;
+ to?: string;
+ "data-testid": string;
+};
+
+export const TransformOutputItem = ({
+ icon,
+ label,
+ to,
+ "data-testid": dataTestId,
+}: TransformOutputItemProps) => {
+ const content = (
+ <Group gap="sm" wrap="nowrap" miw={0}>
+ <FixedSizeIcon name={icon} />
+ <Ellipsified>{label}</Ellipsified>
+ </Group>
+ );
+
+ return to ? (
+ <Anchor
+ display="flex"
+ flex="1 1 0"
+ miw={0}
+ maw="max-content"
+ component={ForwardRefLink}
+ to={to}
+ target="_blank"
+ lh="inherit"
+ fz="inherit"
+ data-testid={dataTestId}
+ >
+ {content}
+ </Anchor>
+ ) : (
+ <Box
+ component="span"
+ display="flex"
+ flex="1 1 0"
+ miw={0}
+ maw="max-content"
+ data-testid={dataTestId}
+ >
+ {content}
+ </Box>
+ );
+};
diff --git a/frontend/src/metabase/transforms/components/TransformOutput/index.ts b/frontend/src/metabase/transforms/components/TransformOutput/index.ts
new file mode 100644
index 00000000000..34016097f87
--- /dev/null
+++ b/frontend/src/metabase/transforms/components/TransformOutput/index.ts
@@ -0,0 +1 @@
+export { TransformOutput } from "./TransformOutput";
diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx
index 02faed9baf5..bfa268bceaf 100644
--- a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx
@@ -3,7 +3,9 @@ import fetchMock from "fetch-mock";
import {
setupDatabaseListEndpoint,
+ setupGetTransformEndpoint,
setupGetTransformJobEndpoint,
+ setupListDatabaseSchemasEndpoint,
setupListJobRunTransformRunsEndpoint,
setupListTransformJobRunsEndpoint,
setupListTransformJobTransformsEndpoint,
@@ -26,6 +28,7 @@ import type {
import {
createMockDatabase,
createMockListTransformJobRunsResponse,
+ createMockTransform,
createMockTransformJob,
createMockTransformJobRun,
createMockTransformRunForJobRun,
@@ -34,6 +37,7 @@ import {
import { JobRunListPage } from "./JobRunListPage";
const JOB_ID = 3;
+const TRANSFORM_ID = 1;
type SetupOpts = {
runs?: TransformJobRun[];
@@ -46,6 +50,7 @@ function setup({
transformRunsByRunId = {},
initialRoute = `/data-studio/transforms/jobs/${JOB_ID}/runs`,
}: SetupOpts = {}) {
+ const transform = createMockTransform({ id: TRANSFORM_ID });
const job = createMockTransformJob({ id: JOB_ID, name: "Nightly job" });
let currentRuns = runs;
@@ -53,6 +58,8 @@ function setup({
setupGetTransformJobEndpoint(job);
setupDatabaseListEndpoint([createMockDatabase()]);
setupListTransformJobTransformsEndpoint(JOB_ID, []);
+ setupGetTransformEndpoint(transform);
+ setupListDatabaseSchemasEndpoint(transform.target.database, []);
setupListTransformJobRunsEndpoint(JOB_ID, () =>
createMockListTransformJobRunsResponse({
data: currentRuns,
@@ -115,6 +122,7 @@ describe("JobRunListPage", () => {
createMockTransformRunForJobRun({
id: 17,
status: "succeeded",
+ transform_id: TRANSFORM_ID,
transform_name: "transform_2",
}),
],
@@ -137,6 +145,7 @@ describe("JobRunListPage", () => {
createMockTransformRunForJobRun({
id: 21,
status: "failed",
+ transform_id: TRANSFORM_ID,
transform_name: "broken_transform",
message: 'relation "abc" does not exist',
}),
@@ -165,6 +174,7 @@ describe("JobRunListPage", () => {
createMockTransformRunForJobRun({
id: 17,
status: isFinished ? "succeeded" : "started",
+ transform_id: TRANSFORM_ID,
transform_name: "transform_f",
}),
]);
diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx
index c656625b763..1754a787760 100644
--- a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx
+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx
@@ -75,6 +75,7 @@ export const JobRunSidebar = memo(function JobRunSidebar({
className={S.sidebar}
direction="column"
flex={1}
+ miw={0}
h="100%"
bg="background_page-primary"
data-testid="job-run-list-sidebar"
diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx
index 9a6e0009f66..af0321ee15a 100644
--- a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx
+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx
@@ -4,13 +4,22 @@ import { DateTime } from "metabase/common/components/DateTime";
import { ForwardRefLink } from "metabase/common/components/Link";
import CS from "metabase/css/core/index.css";
import { ErrorSection } from "metabase/transforms/components/ErrorSection";
+import { TransformOutput } from "metabase/transforms/components/TransformOutput";
import {
formatStatus,
getRunDurationMs,
getTransformRunName,
isErrorStatus,
} from "metabase/transforms/utils";
-import { Anchor, Box, FixedSizeIcon, Group, Stack, Tooltip } from "metabase/ui";
+import {
+ Anchor,
+ Box,
+ FixedSizeIcon,
+ Group,
+ Stack,
+ Text,
+ Tooltip,
+} from "metabase/ui";
import * as Urls from "metabase/urls";
import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";
import { formatDurationLong } from "metabase/utils/formatting/time";
@@ -75,6 +84,16 @@ export function TransformRunItem({ transformRun }: TransformRunItemProps) {
</>
)}
</Group>
+ {transformRun.transform_id !== null && (
+ <Group gap="sm" wrap="nowrap" fz="sm" lh="1rem">
+ <Text
+ c="text-secondary"
+ fz="inherit"
+ lh="inherit"
+ >{t`Output:`}</Text>
+ <TransformOutput transformId={transformRun.transform_id} />
+ </Group>
+ )}
{transformRun.message != null && (
<ErrorSection run={transformRun} showTitle={false} />
)}
diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.unit.spec.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.unit.spec.tsx
new file mode 100644
index 00000000000..df2c398c5d8
--- /dev/null
+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.unit.spec.tsx
@@ -0,0 +1,58 @@
+import {
+ setupGetTransformEndpoint,
+ setupListDatabaseSchemasEndpoint,
+} from "__support__/server-mocks";
+import {
+ renderWithProviders,
+ screen,
+ waitForLoaderToBeRemoved,
+} from "__support__/ui";
+import type { TransformRunForJobRun } from "metabase-types/api";
+import {
+ createMockTransform,
+ createMockTransformRunForJobRun,
+ createMockTransformTarget,
+} from "metabase-types/api/mocks";
+
+import { TransformRunItem } from "./TransformRunItem";
+
+type SetupOpts = {
+ transformRun?: TransformRunForJobRun;
+};
+
+const setup = async ({
+ transformRun = createMockTransformRunForJobRun(),
+}: SetupOpts = {}) => {
+ const transform = createMockTransform({
+ id: 5,
+ target: createMockTransformTarget({
+ database: 2,
+ schema: "public",
+ name: "orders",
+ }),
+ });
+ setupGetTransformEndpoint(transform);
+ setupListDatabaseSchemasEndpoint(transform.target.database, ["public"]);
+ renderWithProviders(<TransformRunItem transformRun={transformRun} />);
+ await waitForLoaderToBeRemoved();
+};
+
+describe("TransformRunItem", () => {
+ it("should render the output table of the run", async () => {
+ await setup({
+ transformRun: createMockTransformRunForJobRun({ transform_id: 5 }),
+ });
+
+ expect(screen.getByText("Output:")).toBeInTheDocument();
+ expect(screen.getByTestId("output-table-link")).toHaveTextContent("orders");
+ });
+
+ it("should not render an output table when the run has no transform", async () => {
+ await setup({
+ transformRun: createMockTransformRunForJobRun({ transform_id: null }),
+ });
+
+ expect(screen.queryByText("Output:")).not.toBeInTheDocument();
+ expect(screen.queryByTestId("output-table-link")).not.toBeInTheDocument();
+ });
+});
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunListPage.unit.spec.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunListPage.unit.spec.tsx
index 69e4e1f195c..27415f3e3e6 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunListPage.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunListPage.unit.spec.tsx
@@ -1,6 +1,8 @@
import userEvent from "@testing-library/user-event";
import {
+ setupGetTransformEndpoint,
+ setupListDatabaseSchemasEndpoint,
setupListTransformRunsEndpoint,
setupListTransformTagsEndpoint,
setupListTransformsEndpoint,
@@ -14,6 +16,7 @@ import {
} from "__support__/ui";
import { Route } from "metabase/router";
import * as Urls from "metabase/urls";
+import { isNotNull } from "metabase/utils/types";
import type { TransformRun } from "metabase-types/api";
import {
createMockListTransformRunsResponse,
@@ -28,6 +31,8 @@ type SetupOpts = {
};
function setup({ runs = [] }: SetupOpts = {}) {
+ const transforms = runs.map((run) => run.transform).filter(isNotNull);
+
setupUserMetabotPermissionsEndpoint();
setupListTransformRunsEndpoint(
createMockListTransformRunsResponse({
@@ -35,8 +40,14 @@ function setup({ runs = [] }: SetupOpts = {}) {
total: runs.length,
}),
);
- setupListTransformsEndpoint([]);
+ if (transforms.length) {
+ setupListTransformsEndpoint(transforms);
+ }
setupListTransformTagsEndpoint([]);
+ transforms.forEach((transform) => {
+ setupGetTransformEndpoint(transform);
+ setupListDatabaseSchemasEndpoint(transform.target.database, []);
+ });
mockGetBoundingClientRect({ width: 1200, height: 800 });
const path = Urls.transformRunList();
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx
index 0f8ffb4c03c..d5bec960632 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx
@@ -7,6 +7,7 @@ import type { TransformRun } from "metabase-types/api";
import { CheckpointValue } from "../../../../components/CheckpointValue";
import { SidebarInfoRow } from "../../../../components/SidebarInfoRow";
+import { TransformOutput } from "../../../../components/TransformOutput";
import {
formatRunMethod,
formatStatus,
@@ -42,6 +43,11 @@ export function InfoSection({ run }: InfoSectionProps) {
<SidebarInfoRow label={t`Trigger`}>
{formatRunMethod(run.run_method)}
</SidebarInfoRow>
+ {run.transform && (
+ <SidebarInfoRow label={t`Output table`}>
+ <TransformOutput transformId={run.transform.id} />
+ </SidebarInfoRow>
+ )}
{checkpointField != null && (
<SidebarInfoRow label={t`Checkpoint field`}>
{checkpointField.display_name}
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.unit.spec.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.unit.spec.tsx
index 8a0e50caa8c..556914ff834 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.unit.spec.tsx
@@ -1,6 +1,18 @@
-import { renderWithProviders, screen } from "__support__/ui";
+import {
+ setupGetTransformEndpoint,
+ setupListDatabaseSchemasEndpoint,
+} from "__support__/server-mocks";
+import {
+ renderWithProviders,
+ screen,
+ waitForLoaderToBeRemoved,
+} from "__support__/ui";
import type { TransformRun } from "metabase-types/api";
-import { createMockTransformRun } from "metabase-types/api/mocks";
+import {
+ createMockTransform,
+ createMockTransformRun,
+ createMockTransformTarget,
+} from "metabase-types/api/mocks";
import { InfoSection } from "./InfoSection";
@@ -9,6 +21,10 @@ type SetupOpts = {
};
function setup({ run = createMockTransformRun() }: SetupOpts = {}) {
+ if (run.transform) {
+ setupGetTransformEndpoint(run.transform);
+ setupListDatabaseSchemasEndpoint(run.transform.target.database, ["public"]);
+ }
renderWithProviders(<InfoSection run={run} />);
}
@@ -69,4 +85,25 @@ describe("InfoSection", () => {
expect(screen.getByText("Schedule")).toBeInTheDocument();
});
+
+ it("should render the output table of the run", async () => {
+ const run = createMockTransformRun({
+ transform: createMockTransform({
+ id: 5,
+ target: createMockTransformTarget({ schema: "public", name: "orders" }),
+ }),
+ });
+ setup({ run });
+ await waitForLoaderToBeRemoved();
+
+ expect(screen.getByText("Output table")).toBeInTheDocument();
+ expect(screen.getByTestId("output-table-link")).toHaveTextContent("orders");
+ });
+
+ it("should not render the output table when the run has no transform", () => {
+ const run = createMockTransformRun({ transform: undefined });
+ setup({ run });
+
+ expect(screen.queryByText("Output table")).not.toBeInTheDocument();
+ });
});
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.unit.spec.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.unit.spec.tsx
index ca2a0b14657..6ddf0c7bd15 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.unit.spec.tsx
@@ -1,4 +1,12 @@
-import { renderWithProviders, screen } from "__support__/ui";
+import {
+ setupGetTransformEndpoint,
+ setupListDatabaseSchemasEndpoint,
+} from "__support__/server-mocks";
+import {
+ renderWithProviders,
+ screen,
+ waitForLoaderToBeRemoved,
+} from "__support__/ui";
import type { TransformRun } from "metabase-types/api";
import {
createMockTransform,
@@ -13,6 +21,10 @@ type SetupOpts = {
function setup({ run = createMockTransformRun() }: SetupOpts = {}) {
const onClose = jest.fn();
+ if (run.transform) {
+ setupGetTransformEndpoint(run.transform);
+ setupListDatabaseSchemasEndpoint(run.transform.target.database, []);
+ }
renderWithProviders(
<RunSidebar
run={run}
@@ -26,10 +38,11 @@ function setup({ run = createMockTransformRun() }: SetupOpts = {}) {
}
describe("RunSidebar", () => {
- it("should render the transform name in the header", () => {
+ it("should render the transform name in the header", async () => {
const transform = createMockTransform({ name: "Test Transform" });
const run = createMockTransformRun({ transform });
setup({ run });
+ await waitForLoaderToBeRemoved();
expect(screen.getByText("Test Transform")).toBeInTheDocument();
});
diff --git a/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunListPage.unit.spec.tsx b/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunListPage.unit.spec.tsx
index 457c0109f65..9bf16982f1d 100644
--- a/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunListPage.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunListPage.unit.spec.tsx
@@ -3,7 +3,9 @@ import fetchMock from "fetch-mock";
import {
setupCancelJobRunEndpoint,
+ setupGetTransformEndpoint,
setupListDagRunTransformRunsEndpoint,
+ setupListDatabaseSchemasEndpoint,
setupListJobRunTransformRunsEndpoint,
setupListTransformGraphRunsEndpoint,
setupListTransformsEndpoint,
@@ -20,12 +22,18 @@ import { Route } from "metabase/router";
import type { TransformGraphRun } from "metabase-types/api";
import {
createMockListTransformGraphRunsResponse,
+ createMockTransform,
createMockTransformGraphRun,
createMockTransformRunForJobRun,
+ createMockTransformTarget,
} from "metabase-types/api/mocks";
import { TransformGraphRunListPage } from "./TransformGraphRunListPage";
+const DATABASE_ID = 1;
+const MEMBER_TRANSFORM_ID = 1;
+const STANDALONE_TRANSFORM_ID = 20;
+
type SetupOpts = {
runs?: TransformGraphRun[];
initialRoute?: string;
@@ -35,14 +43,23 @@ function setup({
runs = [],
initialRoute = "/data-studio/transforms/runs",
}: SetupOpts = {}) {
+ const transforms = [MEMBER_TRANSFORM_ID, STANDALONE_TRANSFORM_ID].map((id) =>
+ createMockTransform({
+ id,
+ target: createMockTransformTarget({ database: DATABASE_ID }),
+ }),
+ );
+
setupUserMetabotPermissionsEndpoint();
- setupListTransformsEndpoint([]);
+ setupListTransformsEndpoint(transforms);
setupListTransformGraphRunsEndpoint(
createMockListTransformGraphRunsResponse({
data: runs,
total: runs.length,
}),
);
+ transforms.forEach((transform) => setupGetTransformEndpoint(transform));
+ setupListDatabaseSchemasEndpoint(DATABASE_ID, []);
mockGetBoundingClientRect({ width: 1200, height: 800 });
const { history } = renderWithProviders(
@@ -77,7 +94,7 @@ const DAG_RUN = createMockTransformGraphRun({
const TRANSFORM_RUN = createMockTransformGraphRun({
run_type: "transform",
id: 301,
- entity_id: 20,
+ entity_id: STANDALONE_TRANSFORM_ID,
name: "Products normalized",
});
diff --git a/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunSidebar/TransformGraphRunSidebar.tsx b/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunSidebar/TransformGraphRunSidebar.tsx
index 50bcd198fef..cc411fcfc62 100644
--- a/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunSidebar/TransformGraphRunSidebar.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformGraphRunListPage/TransformGraphRunSidebar/TransformGraphRunSidebar.tsx
@@ -143,6 +143,7 @@ export const TransformGraphRunSidebar = memo(function TransformGraphRunSidebar({
direction="column"
flex={1}
h="100%"
+ miw={0}
bg="background_page-primary"
data-testid="transform-graph-run-sidebar"
>
diff --git a/frontend/test/__support__/server-mocks/database.ts b/frontend/test/__support__/server-mocks/database.ts
index 07c54d5b012..5fb31b3bfbe 100644
--- a/frontend/test/__support__/server-mocks/database.ts
+++ b/frontend/test/__support__/server-mocks/database.ts
@@ -4,7 +4,12 @@ import _ from "underscore";
import { shouldSchemaBePassedAsQueryParam } from "metabase/api";
import { SAVED_QUESTIONS_DATABASE } from "metabase/databases/constants";
import { isTypePK } from "metabase-lib/v1/types/utils/isa";
-import type { Database, DatabaseUsageInfo } from "metabase-types/api";
+import type {
+ Database,
+ DatabaseId,
+ DatabaseUsageInfo,
+ SchemaName,
+} from "metabase-types/api";
import { PERMISSION_ERROR } from "./constants";
import { setupTableEndpoints } from "./table";
@@ -115,6 +120,13 @@ export const setupSchemaEndpoints = (db: Database) => {
});
};
+export const setupListDatabaseSchemasEndpoint = (
+ databaseId: DatabaseId,
+ schemaNames: SchemaName[],
+) => {
+ fetchMock.get(`path:/api/database/${databaseId}/schemas`, schemaNames);
+};
+
export function setupDatabaseIdFieldsEndpoints({
database: { id, tables = [] },
}: {