The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Converts some tests to ts (#71520)
Ryan Laurie92cd3f6cbf1a
diff --git a/frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.js b/frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.tsxsimilarity index 68%rename from frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.jsrename to frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.tsxindex e675adf62e0..7dc7af2975f 100644--- a/frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.js+++ b/frontend/src/metabase/account/app/components/AccountLayout/AccountLayout.unit.spec.tsx@@ -1,17 +1,16 @@import { render, screen } from "__support__/ui";+import { createMockUser } from "metabase-types/api/mocks";import AccountLayout from "./AccountLayout";-const getUser = () => ({- id: 1,- first_name: "John",- last_name: "Doe",- email: "[email protected]",-});-describe("AccountLayout", () => {it("should render header and content", () => {- const user = getUser();+ const user = createMockUser({+ id: 1,+ first_name: "John",+ last_name: "Doe",+ email: "[email protected]",+ });render(<AccountLayout user={user} onChangeLocation={() => {}}>diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.js b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsxsimilarity index 54%rename from frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.jsrename to frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsxindex f4c427a390c..83ae4330001 100644--- a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.js+++ b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsx@@ -2,39 +2,64 @@ import userEvent from "@testing-library/user-event";import { getIcon, render, screen } from "__support__/ui";-import { DataPermissionValue } from "../../types";+import {+ DataPermission,+ DataPermissionType,+ DataPermissionValue,+ type PermissionOption,+} from "../../types";import { PermissionsSelect } from "./PermissionsSelect";-const options = [+const options: PermissionOption[] = [{label: "Allowed",- value: "all",+ value: DataPermissionValue.ALL,icon: "check",- iconColor: "green",+ iconColor: "success",},{label: "Limited",value: DataPermissionValue.CONTROLLED,icon: "permissions_limited",- iconColor: "blue",+ iconColor: "brand",},{label: "No access",- value: "none",+ value: DataPermissionValue.NONE,icon: "close",- iconColor: "yellow",+ iconColor: "warning",},];describe("PermissionSelect", () => {it("shows selected option", () => {- render(<PermissionsSelect options={options} value="all" />);+ render(+ <PermissionsSelect+ options={options}+ value={DataPermissionValue.ALL}+ onChange={jest.fn()}+ isDisabled={false}+ disabledTooltip={"disabled"}+ permission={DataPermission.VIEW_DATA}+ type={DataPermissionType.ACCESS}+ />,+ );expect(screen.getByText("Allowed")).toBeInTheDocument();});it("when clicked shows options except selected", async () => {- render(<PermissionsSelect options={options} value="all" />);+ render(+ <PermissionsSelect+ options={options}+ value={DataPermissionValue.ALL}+ onChange={jest.fn()}+ isDisabled={false}+ disabledTooltip={"disabled"}+ permission={DataPermission.VIEW_DATA}+ type={DataPermissionType.ACCESS}+ />,+ );await userEvent.click(screen.getByText("Allowed"));@@ -53,8 +78,12 @@ describe("PermissionSelect", () => {render(<PermissionsSelectoptions={options}- value="all"+ value={DataPermissionValue.ALL}onChange={onChangeMock}+ isDisabled={false}+ disabledTooltip={"disabled"}+ permission={DataPermission.VIEW_DATA}+ type={DataPermissionType.ACCESS}/>,);@@ -74,7 +103,15 @@ describe("PermissionSelect", () => {it("does not show options after click when disabled", async () => {render(- <PermissionsSelect options={options} value="all" isDisabled={true} />,+ <PermissionsSelect+ options={options}+ value={DataPermissionValue.ALL}+ isDisabled={true}+ onChange={jest.fn()}+ disabledTooltip={"disabled"}+ permission={DataPermission.VIEW_DATA}+ type={DataPermissionType.ACCESS}+ />,);await userEvent.click(screen.getByText("Allowed"));@@ -86,7 +123,16 @@ describe("PermissionSelect", () => {it("shows warning", async () => {const WARNING = "warning test";render(- <PermissionsSelect options={options} value="all" warning={WARNING} />,+ <PermissionsSelect+ options={options}+ value={DataPermissionValue.ALL}+ warning={WARNING}+ onChange={jest.fn()}+ isDisabled={false}+ disabledTooltip={"disabled"}+ permission={DataPermission.VIEW_DATA}+ type={DataPermissionType.ACCESS}+ />,);await userEvent.hover(getIcon("warning"));