The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix null effective_type for sample database fields (GHY-3367) (#72571)
Eric Normand92df3ec3e9cf
diff --git a/resources/sample-content.edn b/resources/sample-content.ednindex fad5b418e59..ed108683b79 100644--- a/resources/sample-content.edn+++ b/resources/sample-content.edn@@ -837,6 +837,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.891063Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 1,@@ -858,6 +859,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.921812Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 2,@@ -879,6 +881,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.910615Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 3,@@ -900,6 +903,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.886234Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 4,@@ -921,6 +925,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.931798Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 5,@@ -943,6 +948,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.936403Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 6,@@ -964,6 +970,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.863684Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 7,@@ -986,6 +993,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.957037Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 8,@@ -1008,6 +1016,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.933483Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 9,@@ -1030,6 +1039,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.927189Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 10,@@ -1052,6 +1062,7 @@:fk_target_field_id 4,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.912991Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 11,@@ -1073,6 +1084,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.894744Z",+ :effective_type "type/Date",:active true,:parent_id nil,:id 12,@@ -1094,6 +1106,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.916777Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 13,@@ -1115,6 +1128,7 @@:fk_target_field_id 8,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.919506Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 14,@@ -1136,6 +1150,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.948962Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 15,@@ -1157,6 +1172,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.946365Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 16,@@ -1178,6 +1194,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.952943Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 17,@@ -1199,6 +1216,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.947758Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 18,@@ -1220,6 +1238,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.966952Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 19,@@ -1241,6 +1260,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.995757Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 20,@@ -1262,6 +1282,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.053358Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 21,@@ -1283,6 +1304,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.010696Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 22,@@ -1304,6 +1326,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.992076Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 23,@@ -1325,6 +1348,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.057988Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 24,@@ -1346,6 +1370,7 @@:fk_target_field_id 24,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.000851Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 25,@@ -1367,6 +1392,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.993750Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 26,@@ -1388,6 +1414,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.006054Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 27,@@ -1409,6 +1436,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.997589Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 28,@@ -1430,6 +1458,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.098518Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 29,@@ -1452,6 +1481,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.880768Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 30,@@ -1473,6 +1503,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.063064Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 31,@@ -1494,6 +1525,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.094978Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 32,@@ -1515,6 +1547,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.044794Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 33,@@ -1536,6 +1569,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.955812Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 34,@@ -1557,6 +1591,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.089684Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 35,@@ -1578,6 +1613,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.029824Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 36,@@ -1599,6 +1635,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.033381Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 37,@@ -1620,6 +1657,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.049591Z",+ :effective_type "type/Boolean",:active true,:parent_id nil,:id 38,@@ -1641,6 +1679,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.078035Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 39,@@ -1662,6 +1701,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.037084Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 40,@@ -1683,6 +1723,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.072954Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 41,@@ -1704,6 +1745,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.076132Z",+ :effective_type "type/Boolean",:active true,:parent_id nil,:id 42,@@ -1725,6 +1767,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.060369Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 43,@@ -1747,6 +1790,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.958226Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 44,@@ -1768,6 +1812,7 @@:fk_target_field_id 24,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.093193Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 45,@@ -1789,6 +1834,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.108515Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 46,@@ -1810,6 +1856,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.070687Z",+ :effective_type "type/Boolean",:active true,:parent_id nil,:id 47,@@ -1831,6 +1878,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.871361Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 48,@@ -1852,6 +1900,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.096400Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 49,@@ -1873,6 +1922,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.888589Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 50,@@ -1894,6 +1944,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.898004Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 51,@@ -1916,6 +1967,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.883248Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 52,@@ -1937,6 +1989,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.874874Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 53,@@ -1958,6 +2011,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.868884Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 54,@@ -1979,6 +2033,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.970693Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 55,@@ -2000,6 +2055,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.027936Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 56,@@ -2021,6 +2077,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.047470Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 57,@@ -2043,6 +2100,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.878744Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 58,@@ -2064,6 +2122,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.969117Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 59,@@ -2085,6 +2144,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.091626Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 60,@@ -2106,6 +2166,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T19:48:00.338809Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 61,@@ -2127,6 +2188,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.066721Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 62,@@ -2148,6 +2210,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.954443Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 63,@@ -2169,6 +2232,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.117905Z",+ :effective_type "type/Float",:active true,:parent_id nil,:id 64,@@ -2190,6 +2254,7 @@:fk_target_field_id 8,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.972233Z",+ :effective_type "type/Integer",:active true,:parent_id nil,:id 65,@@ -2211,6 +2276,7 @@:fk_target_field_id 24,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.112761Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 66,@@ -2232,6 +2298,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:56.973643Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 67,@@ -2253,6 +2320,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.110031Z",+ :effective_type "type/BigInteger",:active true,:parent_id nil,:id 68,@@ -2274,6 +2342,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T19:48:00.339704Z",+ :effective_type "type/Text",:active true,:parent_id nil,:id 69,@@ -2295,6 +2364,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.107209Z",+ :effective_type "type/Boolean",:active true,:parent_id nil,:id 70,@@ -2316,6 +2386,7 @@:fk_target_field_id nil,:is_defective_duplicate false,:updated_at #t "2026-02-23T11:14:57.115865Z",+ :effective_type "type/DateTime",:active true,:parent_id nil,:id 71,diff --git a/test/metabase/app_db/custom_migrations_test.clj b/test/metabase/app_db/custom_migrations_test.cljindex 049fc1527c8..17b1ee2cc34 100644--- a/test/metabase/app_db/custom_migrations_test.clj+++ b/test/metabase/app_db/custom_migrations_test.clj@@ -2253,6 +2253,14 @@(migrate!)(is (false? (sample-content-created?))))))+(deftest ^:mb/old-migrations-test create-sample-content-effective-type-test+ (testing "Every sample-database field has a non-null effective_type after migration (GHY-3367)"+ (impl/test-migrations "v52.2024-12-03T15:55:22" [migrate!]+ (migrate!)+ (let [fields (t2/query "SELECT name, base_type, effective_type FROM metabase_field")]+ (is (seq fields))+ (is (empty? (filter #(nil? (:effective_type %)) fields)))))))+(defn- insert-returning-pk))