Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Skip event publishing during Document deserialization (#72655)

Edward Paget9731ed83c8e1
diff --git a/src/metabase/documents/models/document.clj b/src/metabase/documents/models/document.clj
index 3d4b5a0d42f..f0083358b9f 100644
--- a/src/metabase/documents/models/document.clj
+++ b/src/metabase/documents/models/document.clj
@@ -98,7 +98,8 @@
(sync-document-cards-collection! id collection_id
:archived archived
:archived-directly archived_directly)
- (events/publish-event! :event/document-update {:object instance})
+ (when-not mi/*deserializing?*
+ (events/publish-event! :event/document-update {:object instance}))
instance)
(t2/define-after-select :model/Document
diff --git a/src/metabase/transforms/models/transform.clj b/src/metabase/transforms/models/transform.clj
index acf42ebf317..e1aa1b271c3 100644
--- a/src/metabase/transforms/models/transform.clj
+++ b/src/metabase/transforms/models/transform.clj
@@ -250,16 +250,19 @@
{:email (:owner_email transform)}))))))
(t2/define-after-insert :model/Transform [transform]
- (events/publish-event! :event/create-transform {:object transform})
+ (when-not mi/*deserializing?*
+ (events/publish-event! :event/create-transform {:object transform}))
transform)
(t2/define-after-update :model/Transform [transform]
- (events/publish-event! :event/update-transform {:object transform})
+ (when-not mi/*deserializing?*
+ (events/publish-event! :event/update-transform {:object transform}))
transform)
(t2/define-before-delete :model/Transform [transform]
(ws.table/delete-orphaned-provisional-table! (:target_table_id transform) (:id transform))
- (events/publish-event! :event/delete-transform {:id (:id transform)})
+ (when-not mi/*deserializing?*
+ (events/publish-event! :event/delete-transform {:id (:id transform)}))
(search.core/delete! :model/Transform [(str (:id transform))])
transform)
diff --git a/test/metabase/documents/models/document_test.clj b/test/metabase/documents/models/document_test.clj
index 47860692519..e46b836a0c8 100644
--- a/test/metabase/documents/models/document_test.clj
+++ b/test/metabase/documents/models/document_test.clj
@@ -3,6 +3,8 @@
[clojure.test :refer :all]
[metabase.collections.models.collection :as collection]
[metabase.documents.models.document :as document]
+ [metabase.events.core :as events]
+ [metabase.models.interface :as mi]
[metabase.models.serialization :as serdes]
[metabase.permissions.core :as perms]
[metabase.test :as mt]
@@ -815,3 +817,19 @@
(is (contains? descendants ["Card" 111]))
(is (contains? descendants ["Dashboard" 222]))
(is (contains? descendants ["Table" 333]))))))
+
+(deftest no-events-during-deserialization-test
+ (testing "Document after-update hook does not publish events during deserialization (#72293)"
+ (mt/with-temp [:model/Document {doc-id :id} {:name "Test Document"}]
+ (let [events-published (atom [])]
+ (with-redefs [events/publish-event! (fn [topic event]
+ (swap! events-published conj [topic event]))]
+ (testing "events fire normally"
+ (t2/update! :model/Document doc-id {:name "Updated Name"})
+ (is (= 1 (count @events-published)))
+ (is (= :event/document-update (ffirst @events-published))))
+ (reset! events-published [])
+ (testing "events are suppressed during deserialization"
+ (binding [mi/*deserializing?* true]
+ (t2/update! :model/Document doc-id {:name "Deserialized Name"}))
+ (is (empty? @events-published))))))))
diff --git a/test/metabase/transforms/models/transform_test.clj b/test/metabase/transforms/models/transform_test.clj
index 4db0caefc79..372d823abee 100644
--- a/test/metabase/transforms/models/transform_test.clj
+++ b/test/metabase/transforms/models/transform_test.clj
@@ -1,7 +1,10 @@
(ns metabase.transforms.models.transform-test
(:require
[clojure.test :refer :all]
- [metabase.test :as mt]))
+ [metabase.events.core :as events]
+ [metabase.models.interface :as mi]
+ [metabase.test :as mt]
+ [toucan2.core :as t2]))
(deftest source-database-id-set-test
(testing "inserting a transform correctly sets the source-database-id column"
@@ -22,3 +25,29 @@
:type "native"
:native {:query "SELECT 1"}}}}]
(is (= (mt/id) (:source_database_id transform))))))
+
+(deftest no-events-during-deserialization-test
+ (testing "Transform lifecycle hooks do not publish events during deserialization"
+ (let [events-published (atom [])
+ source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}]
+ (with-redefs [events/publish-event! (fn [topic event]
+ (swap! events-published conj [topic event]))]
+ (testing "events fire normally for insert/update/delete"
+ (mt/with-temp [:model/Transform {transform-id :id} {:name "Test Transform" :source source}]
+ (is (some #(= :event/create-transform (first %)) @events-published))
+ (reset! events-published [])
+ (t2/update! :model/Transform transform-id {:name "Updated Name"})
+ (is (some #(= :event/update-transform (first %)) @events-published))
+ (reset! events-published [])
+ (t2/delete! :model/Transform transform-id)
+ (is (some #(= :event/delete-transform (first %)) @events-published))))
+ (reset! events-published [])
+ (testing "events are suppressed during deserialization"
+ (binding [mi/*deserializing?* true]
+ (mt/with-temp [:model/Transform {transform-id :id} {:name "Deserialized Transform" :source source}]
+ (t2/update! :model/Transform transform-id {:name "Deserialized Update"})
+ (t2/delete! :model/Transform transform-id)))
+ (is (empty? @events-published)))))))