Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Reclassify schema as shared tier (#74946)

Fraser982040aa43ae
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index fd53a9f3097..290c6740ef2 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -3,7 +3,7 @@ const createElement = ({
name,
pattern,
mode,
- enforceOutgoing = false,
+ enforceOutgoing = true,
}) => ({
type: `${type}/${name}`,
pattern: pattern ?? `frontend/src/metabase/${name}/**`,
@@ -13,150 +13,131 @@ const createElement = ({
const elements = [
// lib
+ createElement({ type: "lib", name: "analytics" }),
+ createElement({ type: "lib", name: "css" }),
createElement({
type: "lib",
- name: "types",
- pattern: "frontend/src/metabase-types/*/**",
- }),
- createElement({
- type: "lib",
- name: "schema",
- pattern: "frontend/src/metabase/schema.js",
+ name: "env",
+ pattern: "frontend/src/metabase/env.ts",
mode: "full",
}),
- createElement({ type: "lib", name: "utils", enforceOutgoing: true }),
- createElement({ type: "lib", name: "analytics", enforceOutgoing: true }),
- createElement({ type: "lib", name: "css", enforceOutgoing: true }),
createElement({
type: "lib",
- name: "env",
- pattern: "frontend/src/metabase/env.ts",
- mode: "full",
- enforceOutgoing: true,
+ name: "types",
+ pattern: "frontend/src/metabase-types/*/**",
+ enforceOutgoing: false,
}),
+ createElement({ type: "lib", name: "utils" }),
- // mlv1/mlv2 need to be in this order
- // for precedence
+ // mlv1 (basic) and mlv2 (lib) must stay in this order: mlv1's pattern is a
+ // subset of mlv2's, and the first matching element wins. This precedence
+ // requirement crosses tiers, so the pair is kept together here rather than
+ // sorted into the lib/basic groups.
createElement({
type: "basic",
name: "mlv1",
pattern: "frontend/src/metabase-lib/v1/**",
- enforceOutgoing: true,
}),
createElement({
type: "lib",
name: "mlv2",
pattern: "frontend/src/metabase-lib/**",
- enforceOutgoing: true,
}),
// basic
- createElement({ type: "basic", name: "ui", enforceOutgoing: true }),
- createElement({ type: "shared", name: "api", enforceOutgoing: true }),
+ createElement({ type: "basic", name: "ui" }),
+
// shared
- createElement({ type: "shared", name: "embedding" }),
- createElement({ type: "shared", name: "common", enforceOutgoing: true }),
- createElement({ type: "shared", name: "palette", enforceOutgoing: true }),
- createElement({ type: "shared", name: "querying" }),
+ createElement({ type: "shared", name: "account" }),
+ createElement({ type: "shared", name: "api" }),
+ createElement({ type: "shared", name: "archive" }),
+ createElement({ type: "shared", name: "auth" }),
+ createElement({ type: "shared", name: "browse" }),
+ createElement({ type: "shared", name: "collections" }),
+ createElement({ type: "shared", name: "comments" }),
+ createElement({ type: "shared", name: "common" }),
createElement({
type: "shared",
- name: "visualizations",
- enforceOutgoing: true,
+ name: "custom-viz",
+ pattern: "enterprise/frontend/src/custom-viz/**",
}),
- createElement({ type: "shared", name: "visualizer", enforceOutgoing: true }),
- createElement({ type: "shared", name: "account", enforceOutgoing: true }),
- createElement({ type: "shared", name: "archive", enforceOutgoing: true }),
- createElement({ type: "shared", name: "auth", enforceOutgoing: true }),
- createElement({ type: "shared", name: "browse", enforceOutgoing: true }),
- createElement({ type: "shared", name: "collections", enforceOutgoing: true }),
- createElement({ type: "shared", name: "comments", enforceOutgoing: true }),
- createElement({ type: "shared", name: "data-grid", enforceOutgoing: true }),
- createElement({ type: "shared", name: "data-studio", enforceOutgoing: true }),
- createElement({ type: "shared", name: "databases", enforceOutgoing: true }),
- createElement({ type: "shared", name: "detail-view", enforceOutgoing: true }),
- createElement({ type: "shared", name: "documents", enforceOutgoing: true }),
- createElement({ type: "shared", name: "forms", enforceOutgoing: true }),
- createElement({ type: "shared", name: "history", enforceOutgoing: true }),
- createElement({ type: "shared", name: "hoc", enforceOutgoing: true }),
- createElement({ type: "shared", name: "home", enforceOutgoing: true }),
- createElement({ type: "shared", name: "hooks", enforceOutgoing: true }),
- createElement({ type: "shared", name: "i18n", enforceOutgoing: true }),
- createElement({ type: "shared", name: "metadata", enforceOutgoing: true }),
- createElement({ type: "shared", name: "metrics", enforceOutgoing: true }),
- createElement({ type: "shared", name: "models", enforceOutgoing: true }),
+ createElement({ type: "shared", name: "data-grid" }),
+ createElement({ type: "shared", name: "data-studio" }),
+ createElement({ type: "shared", name: "databases" }),
+ createElement({ type: "shared", name: "detail-view" }),
+ createElement({ type: "shared", name: "documents" }),
+ createElement({ type: "shared", name: "embedding", enforceOutgoing: false }),
createElement({
type: "shared",
- name: "metrics-viewer",
- enforceOutgoing: true,
+ name: "embedding-ee",
+ pattern: "enterprise/frontend/src/embedding/**",
}),
- createElement({ type: "shared", name: "new", enforceOutgoing: true }),
- createElement({ type: "shared", name: "pulse", enforceOutgoing: true }),
- createElement({ type: "shared", name: "questions", enforceOutgoing: true }),
- createElement({ type: "shared", name: "router", enforceOutgoing: true }),
- createElement({ type: "shared", name: "search", enforceOutgoing: true }),
- createElement({ type: "shared", name: "setup", enforceOutgoing: true }),
- createElement({ type: "shared", name: "status", enforceOutgoing: true }),
createElement({
type: "shared",
- name: "styled-components",
- enforceOutgoing: true,
+ name: "embedding-sdk-package",
+ pattern: "enterprise/frontend/src/embedding-sdk-package/**",
}),
- createElement({ type: "shared", name: "timelines", enforceOutgoing: true }),
- createElement({ type: "shared", name: "transforms", enforceOutgoing: true }),
- createElement({ type: "shared", name: "urls", enforceOutgoing: true }),
createElement({
type: "shared",
name: "embedding-sdk-shared",
pattern: "frontend/src/embedding-sdk-shared/**",
- enforceOutgoing: true,
}),
+ createElement({ type: "shared", name: "forms" }),
+ createElement({ type: "shared", name: "history" }),
+ createElement({ type: "shared", name: "hoc" }),
+ createElement({ type: "shared", name: "home" }),
+ createElement({ type: "shared", name: "hooks" }),
+ createElement({ type: "shared", name: "i18n" }),
createElement({
type: "shared",
name: "metabase-shared",
pattern: "frontend/src/metabase-shared/**",
- enforceOutgoing: true,
}),
+ createElement({ type: "shared", name: "metadata" }),
+ createElement({ type: "shared", name: "metrics" }),
+ createElement({ type: "shared", name: "metrics-viewer" }),
+ createElement({ type: "shared", name: "models" }),
+ createElement({ type: "shared", name: "new" }),
+ createElement({ type: "shared", name: "palette" }),
+ createElement({ type: "shared", name: "pulse" }),
+ createElement({ type: "shared", name: "querying", enforceOutgoing: false }),
+ createElement({ type: "shared", name: "questions" }),
+ createElement({ type: "shared", name: "router" }),
createElement({
type: "shared",
- name: "types",
- pattern: "frontend/src/types/**",
- enforceOutgoing: true,
- }),
- createElement({
- type: "shared",
- name: "custom-viz",
- pattern: "enterprise/frontend/src/custom-viz/**",
- enforceOutgoing: true,
- }),
- createElement({
- type: "shared",
- name: "embedding-ee",
- pattern: "enterprise/frontend/src/embedding/**",
- enforceOutgoing: true,
+ name: "schema",
+ pattern: "frontend/src/metabase/schema.js",
+ mode: "full",
+ enforceOutgoing: false,
}),
+ createElement({ type: "shared", name: "search" }),
+ createElement({ type: "shared", name: "setup" }),
+ createElement({ type: "shared", name: "status" }),
+ createElement({ type: "shared", name: "styled-components" }),
+ createElement({ type: "shared", name: "timelines" }),
+ createElement({ type: "shared", name: "transforms" }),
createElement({
type: "shared",
- name: "embedding-sdk-package",
- pattern: "enterprise/frontend/src/embedding-sdk-package/**",
- enforceOutgoing: true,
+ name: "types",
+ pattern: "frontend/src/types/**",
}),
+ createElement({ type: "shared", name: "urls" }),
+ createElement({ type: "shared", name: "visualizations" }),
+ createElement({ type: "shared", name: "visualizer" }),
+
// feature
- createElement({ type: "feature", name: "dashboard", enforceOutgoing: true }),
- createElement({
- type: "feature",
- name: "query_builder",
- enforceOutgoing: true,
- }),
- createElement({ type: "feature", name: "admin", enforceOutgoing: true }),
- createElement({ type: "feature", name: "public", enforceOutgoing: true }),
- createElement({ type: "feature", name: "reference", enforceOutgoing: true }),
+ createElement({ type: "feature", name: "admin" }),
+ createElement({ type: "feature", name: "dashboard" }),
createElement({
type: "feature",
name: "enterprise",
pattern: "enterprise/frontend/src/metabase-enterprise/**",
mode: "full",
- enforceOutgoing: true,
}),
+ createElement({ type: "feature", name: "public" }),
+ createElement({ type: "feature", name: "query_builder" }),
+ createElement({ type: "feature", name: "reference" }),
+
// app
...[
"frontend/src/metabase/app.js",
@@ -180,7 +161,6 @@ const elements = [
name: "misc",
pattern: path,
mode: "full",
- enforceOutgoing: true,
}),
),
// catch-all for unmoduled files - must be last
@@ -188,6 +168,7 @@ const elements = [
type: "shared",
name: "other",
pattern: "frontend/src/*/**",
+ enforceOutgoing: false,
}),
];