The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-2833 Add per-version download link to Security Center advisories (#77677)
Egor Grushin9a5a4e25876a
diff --git a/e2e/support/helpers/api/seedSecurityAdvisories.ts b/e2e/support/helpers/api/seedSecurityAdvisories.tsindex 375b2b6cce6..3665df6826e 100644--- a/e2e/support/helpers/api/seedSecurityAdvisories.ts+++ b/e2e/support/helpers/api/seedSecurityAdvisories.ts@@ -6,6 +6,7 @@ export type SecurityAdvisorySpec = {remediation: string;advisory_url?: string | null;affected_versions: { min: string; fixed: string }[];+ download_jar_urls?: { version: string; url: string }[];matching_query?: Record<string, string> | null;match_status: "unknown" | "active" | "resolved" | "not_affected" | "error";published_at: string;diff --git a/e2e/test/scenarios/admin-2/security-center.cy.spec.ts b/e2e/test/scenarios/admin-2/security-center.cy.spec.tsindex 91fb9e747fc..48a0043397d 100644--- a/e2e/test/scenarios/admin-2/security-center.cy.spec.ts+++ b/e2e/test/scenarios/admin-2/security-center.cy.spec.ts@@ -218,4 +218,50 @@ describe("scenarios > admin > security center", { tags: "@EE" }, () => {cy.findByTestId("sync-advisories").click();cy.wait("@sync");});++ describe("per-version download link", () => {+ const DOWNLOADABLE_ADVISORY = {+ advisory_id: "TEST-DL",+ severity: "critical",+ title: "Critical bug with a downloadable fix",+ description: "A critical issue shipping a per-version JAR fix.",+ remediation: "Upgrade to the patched release",+ affected_versions: [{ min: "0.58.0", fixed: "0.59.11" }],+ download_jar_urls: [+ { version: "0.58.11", url: "https://downloads.example.com/58.jar" },+ { version: "0.59.11", url: "https://downloads.example.com/59.jar" },+ ],+ match_status: "active",+ published_at: "2026-03-24T00:00:00Z",+ updated_at: "2026-03-24T00:00:00Z",+ } as const;++ it("stores and returns download_jar_urls through the real backend", () => {+ H.seedSecurityAdvisories([DOWNLOADABLE_ADVISORY]);+ cy.request("GET", "/api/ee/security-center").then(({ body }) => {+ const advisory = body.advisories.find(+ (a: { advisory_id: string }) => a.advisory_id === "TEST-DL",+ );+ expect(advisory.download_jar_urls).to.deep.equal([+ { version: "0.58.11", url: "https://downloads.example.com/58.jar" },+ { version: "0.59.11", url: "https://downloads.example.com/59.jar" },+ ]);+ });+ });++ it("shows a single download button for the fix matching the instance major version", () => {+ H.mockSessionProperty("version", { tag: "v0.59.3" });+ H.seedSecurityAdvisories([DOWNLOADABLE_ADVISORY]);+ cy.visit("/admin/security-center");++ cy.findAllByTestId("advisory-card")+ .first()+ .within(() => {+ cy.findByRole("link", { name: /Download v0\.59\.11/ })+ .should("have.attr", "href", "https://downloads.example.com/59.jar")+ .and("have.attr", "target", "_blank");+ cy.findByText("Download v0.58.11").should("not.exist");+ });+ });+ });});diff --git a/enterprise/backend/src/metabase_enterprise/security_center/api.clj b/enterprise/backend/src/metabase_enterprise/security_center/api.cljindex 0768d849958..ab5b5f2d817 100644--- a/enterprise/backend/src/metabase_enterprise/security_center/api.clj+++ b/enterprise/backend/src/metabase_enterprise/security_center/api.clj@@ -27,7 +27,8 @@[advisory](-> (select-keys advisory [:advisory_id :title :severity :description :advisory_url :remediation:published_at :match_status :last_evaluated_at- :acknowledged_by_user :acknowledged_at :affected_versions])+ :acknowledged_by_user :acknowledged_at :affected_versions :download_jar_urls])+ (update :download_jar_urls sequence)(set/rename-keys {:acknowledged_by_user :acknowledged_by})))(def ^:private AcknowledgedByUser@@ -51,7 +52,8 @@[:last_evaluated_at [:maybe ms/TemporalInstant]][:acknowledged_by [:maybe AcknowledgedByUser]][:acknowledged_at [:maybe ms/TemporalInstant]]- [:affected_versions ::security-center.schema/affected-versions]])+ [:affected_versions ::security-center.schema/affected-versions]+ [:download_jar_urls ::security-center.schema/download-jar-urls]])(def ^:private AcknowledgeResponse"Schema for the acknowledge endpoint response."diff --git a/enterprise/backend/src/metabase_enterprise/security_center/fetch.clj b/enterprise/backend/src/metabase_enterprise/security_center/fetch.cljindex 4822ceabc58..cb343d63073 100644--- a/enterprise/backend/src/metabase_enterprise/security_center/fetch.clj+++ b/enterprise/backend/src/metabase_enterprise/security_center/fetch.clj@@ -23,7 +23,7 @@[:enum "critical" "high" "medium" "low"])(mr/def ::affected-version- [:map {:closed true}+ [:map[:min ::security-center.schema/semver][:fixed ::security-center.schema/semver]])@@ -44,6 +44,7 @@[:updated_at ms/TemporalString][:advisory_url [:maybe :string]][:affected_versions [:vector {:min 1} ::affected-version]]+ [:download_jar_urls {:optional true} [:maybe ::security-center.schema/download-jar-urls]][:matching_query [:maybe ::matching-query]][:remediation [:string {:min 1}]]])@@ -99,6 +100,7 @@:advisory_url (:advisory_url advisory):remediation (:remediation advisory):affected_versions (:affected_versions advisory)+ :download_jar_urls (:download_jar_urls advisory):matching_query (parse-matching-query (:matching_query advisory)):published_at (t/offset-date-time (:published_at advisory)):updated_at (t/offset-date-time (:updated_at advisory))})diff --git a/enterprise/backend/src/metabase_enterprise/security_center/models/security_advisory.clj b/enterprise/backend/src/metabase_enterprise/security_center/models/security_advisory.cljindex 3a998abd2b5..6ca549e33b2 100644--- a/enterprise/backend/src/metabase_enterprise/security_center/models/security_advisory.clj+++ b/enterprise/backend/src/metabase_enterprise/security_center/models/security_advisory.clj@@ -15,6 +15,7 @@{:severity mi/transform-keyword:match_status mi/transform-keyword:affected_versions mi/transform-json+ :download_jar_urls mi/transform-json;; EDN because HoneySQL treats keywords as identifiers and strings as values.:matching_query mi/transform-edn})diff --git a/enterprise/backend/src/metabase_enterprise/security_center/schema.clj b/enterprise/backend/src/metabase_enterprise/security_center/schema.cljindex bbb8d21e0e8..f770fe2610e 100644--- a/enterprise/backend/src/metabase_enterprise/security_center/schema.clj+++ b/enterprise/backend/src/metabase_enterprise/security_center/schema.clj@@ -24,6 +24,15 @@(mr/def ::affected-versions[:sequential ::version-range])+(mr/def ::download-jar-url+ "A downloadable JAR for a given fixed version."+ [:map+ [:version ::semver]+ [:url :string]])++(mr/def ::download-jar-urls+ [:sequential ::download-jar-url])+(mr/def ::matching-query"HoneySQL query keyed by dialect. nil means affects all instances.Stored as EDN to preserve keywords that HoneySQL requires for identifiers/operators."diff --git a/enterprise/backend/test/metabase_enterprise/security_center/api_test.clj b/enterprise/backend/test/metabase_enterprise/security_center/api_test.cljindex c677f6ad298..d3fab1c2878 100644--- a/enterprise/backend/test/metabase_enterprise/security_center/api_test.clj+++ b/enterprise/backend/test/metabase_enterprise/security_center/api_test.clj@@ -69,6 +69,28 @@(testing "non-superuser gets 403"(mt/user-http-request :rasta :get 403 "ee/security-center"))))))+(deftest list-advisories-returns-download-jar-urls-test+ (testing "GET /api/ee/security-center returns download_jar_urls"+ (mt/with-premium-features #{:admin-security-center}+ (mt/with-temp [:model/SecurityAdvisory _+ {:advisory_id "SC-DL-001"+ :severity "high"+ :title "Advisory with download link"+ :description "Test"+ :remediation "Upgrade"+ :affected_versions [{"min" "1.58.0" "fixed" "1.58.11"}]+ :download_jar_urls [{"version" "1.58.11"+ "url" "https://downloads.example.com/metabase.jar"}]+ :match_status "active"+ :published_at #t "2026-03-24T00:00:00Z"+ :updated_at #t "2026-03-24T00:00:00Z"}]+ (let [response (mt/user-http-request :crowberto :get 200 "ee/security-center")+ advisory (->> response :advisories (some #(when (= "SC-DL-001" (:advisory_id %)) %)))]+ (is (= [{:min "1.58.0" :fixed "1.58.11"}]+ (:affected_versions advisory)))+ (is (= [{:version "1.58.11" :url "https://downloads.example.com/metabase.jar"}]+ (:download_jar_urls advisory))))))))+(deftest trial-subscription-gate-test(testing "Security Center is not available on trial subscriptions"(mt/with-premium-features #{:admin-security-center}diff --git a/enterprise/backend/test/metabase_enterprise/security_center/fetch_test.clj b/enterprise/backend/test/metabase_enterprise/security_center/fetch_test.cljindex e676fe8c75b..c3ef90887a7 100644--- a/enterprise/backend/test/metabase_enterprise/security_center/fetch_test.clj+++ b/enterprise/backend/test/metabase_enterprise/security_center/fetch_test.clj@@ -106,6 +106,25 @@:title "Advisory SC-2026-001"}row))))))))+(deftest fetch-advisory-with-download-jar-urls-test+ (testing "download_jar_urls side field passes validation and is stored"+ (let [advisory (make-json-advisory "SC-DL-001"+ "affected_versions" [{"min" "0.58.0" "fixed" "0.58.11"}+ {"min" "0.59.0" "fixed" "0.59.6"}]+ "download_jar_urls" [{"version" "0.58.11"+ "url" "https://downloads.example.com/metabase.jar"}])]+ (mt/with-model-cleanup [:model/SecurityAdvisory]+ (with-redefs [http/get (constantly (fake-store-response [advisory]))+ premium-features/premium-embedding-token (constantly "fake-token")+ premium-features/site-uuid-for-premium-features-token-checks (constantly "fake-uuid")]+ (fetch/sync-advisories!)+ (let [row (t2/select-one :model/SecurityAdvisory :advisory_id "SC-DL-001")]+ (is (some? row))+ (is (= [{:min "0.58.0" :fixed "0.58.11"} {:min "0.59.0" :fixed "0.59.6"}]+ (:affected_versions row)))+ (is (= [{:version "0.58.11" :url "https://downloads.example.com/metabase.jar"}]+ (:download_jar_urls row)))))))))+(deftest sync-advisories-stores-updated-at-test(mt/with-model-cleanup [:model/SecurityAdvisory](mt/with-dynamic-fn-redefs [fetch/fetch-advisories-from-storediff --git a/enterprise/frontend/src/metabase-enterprise/security_center/analytics.ts b/enterprise/frontend/src/metabase-enterprise/security_center/analytics.tsindex 4579137ac40..b5494850e27 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/analytics.ts+++ b/enterprise/frontend/src/metabase-enterprise/security_center/analytics.ts@@ -5,3 +5,9 @@ export const trackSecurityCenterPageViewed = () => {event: "security_center_page_viewed",});};++export const trackSecurityAdvisoryDownloadClicked = () => {+ trackSimpleEvent({+ event: "security_advisory_download_clicked",+ });+};diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsxindex 0c2f37db55f..7a3a237db3d 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx@@ -1,6 +1,7 @@import { match } from "ts-pattern";import { t } from "ttag";+import { useSetting } from "metabase/common/hooks";import {Anchor,Badge,@@ -22,7 +23,8 @@ import type {AdvisorySeverity,} from "metabase-types/api";-import { isAcknowledged } from "../../utils";+import { trackSecurityAdvisoryDownloadClicked } from "../../analytics";+import { getDownloadJarForInstance, isAcknowledged } from "../../utils";interface AdvisoryCardProps {advisory: Advisory;@@ -35,7 +37,11 @@ export function AdvisoryCard({isAffecting,onAcknowledge,}: AdvisoryCardProps) {+ const currentVersion = useSetting("version").tag ?? "";const acknowledged = isAcknowledged(advisory);+ const downloadJar = isAffecting+ ? getDownloadJarForInstance(advisory, currentVersion)+ : null;return (<Card p="xl" withBorder data-testid="advisory-card">@@ -88,6 +94,19 @@ export function AdvisoryCard({</Box><Group gap="md" mt="sm">+ {downloadJar && (+ <Button+ variant="outline"+ component="a"+ href={downloadJar.url}+ target="_blank"+ rel="noopener noreferrer"+ leftSection={<Icon name="download" />}+ onClick={trackSecurityAdvisoryDownloadClicked}+ >+ {t`Download v${downloadJar.version}`}+ </Button>+ )}{!acknowledged && onAcknowledge && (<Tooltiplabel={t`Clicking on Dismiss just hides the notification and you can view this later by toggling 'Show dismissed'`}diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsxindex fbee9a93bda..dbf6c9bae6c 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx@@ -171,6 +171,67 @@ describe("SecurityCenterPage", () => {expect(advisoryLink).toHaveAttribute("target", "_blank");});+ it("renders a single download button for the fix matching the instance's major version", async () => {+ const advisories = [+ createAdvisory({+ advisory_id: "1",+ match_status: "active",+ affected_versions: [+ { min: "0.58.0", fixed: "0.58.11" },+ { min: "0.59.0", fixed: "0.59.11" },+ ],+ download_jar_urls: [+ { version: "0.58.11", url: "https://downloads.example.com/58.jar" },+ { version: "0.59.11", url: "https://downloads.example.com/59.jar" },+ ],+ }),+ ];++ setup(advisories);++ expect(screen.queryByText("Download v0.58.11")).not.toBeInTheDocument();+ const downloadButton = screen.getByRole("link", {+ name: /Download v0.59.11/,+ });+ expect(downloadButton).toHaveAttribute(+ "href",+ "https://downloads.example.com/59.jar",+ );+ expect(downloadButton).toHaveAttribute("target", "_blank");+ });++ it("does not render a download button when there is no matching download url", async () => {+ const advisories = [+ createAdvisory({+ advisory_id: "1",+ match_status: "active",+ affected_versions: [{ min: "0.59.0", fixed: "0.59.11" }],+ download_jar_urls: [],+ }),+ ];++ setup(advisories);++ expect(screen.queryByText("Download v0.59.11")).not.toBeInTheDocument();+ });++ it("does not render a download button when the instance is not affected", async () => {+ const advisories = [+ createAdvisory({+ advisory_id: "1",+ match_status: "not_affected",+ affected_versions: [{ min: "0.59.0", fixed: "0.59.11" }],+ download_jar_urls: [+ { version: "0.59.11", url: "https://downloads.example.com/59.jar" },+ ],+ }),+ ];++ setup(advisories);++ expect(screen.queryByText("Download v0.59.11")).not.toBeInTheDocument();+ });+it("calls acknowledgeAdvisory when dismiss button is clicked", async () => {const advisories = [createAdvisory({ advisory_id: "SA-001", acknowledged_at: null }),diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts b/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.tsindex 19eeb3f6d09..69e78e93b5d 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts+++ b/enterprise/frontend/src/metabase-enterprise/security_center/hooks/use-security-advisories.ts@@ -1,11 +1,8 @@-import { useMemo } from "react";-import {useAcknowledgeAdvisoriesMutation,useAcknowledgeAdvisoryMutation,useListSecurityAdvisoriesQuery,} from "metabase/api";-import type { Advisory } from "metabase-types/api";const POLLING_INTERVAL = 2000;@@ -21,13 +18,8 @@ export function useSecurityAdvisories(isPolling = false) {const [acknowledgeAdvisory] = useAcknowledgeAdvisoryMutation();const [acknowledgeAdvisories] = useAcknowledgeAdvisoriesMutation();- const advisories: Advisory[] = useMemo(- () => response?.advisories ?? [],- [response?.advisories],- );-return {- data: advisories,+ data: response?.advisories ?? [],lastCheckedAt: response?.last_checked_at ?? null,isLoading,isError,diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/utils.ts b/enterprise/frontend/src/metabase-enterprise/security_center/utils.tsindex 590241702e3..07ce5a26117 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/security_center/utils.ts@@ -1,8 +1,27 @@-import { compareVersions } from "metabase/utils/version";-import type { Advisory, AdvisorySeverity } from "metabase-types/api";+import { compareVersions, getMajorVersion } from "metabase/utils/version";+import type {+ Advisory,+ AdvisoryDownloadJarUrl,+ AdvisorySeverity,+} from "metabase-types/api";import type { AdvisoryFilter } from "./types";+export const getDownloadJarForInstance = (+ advisory: Advisory,+ currentVersion: string,+): AdvisoryDownloadJarUrl | null => {+ const currentMajor = getMajorVersion(currentVersion);+ if (currentMajor == null) {+ return null;+ }+ return (+ advisory.download_jar_urls.find(+ (jar) => getMajorVersion(jar.version) === currentMajor,+ ) ?? null+ );+};+const SEVERITY_ORDER: Record<AdvisorySeverity, number> = {critical: 0,high: 1,diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/security_center/utils.unit.spec.tsindex 8c6d817e489..4e251325f41 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/utils.unit.spec.ts+++ b/enterprise/frontend/src/metabase-enterprise/security_center/utils.unit.spec.ts@@ -16,6 +16,7 @@ const makeAdvisory = (overrides: Partial<Advisory>): Advisory => ({acknowledged_by: null,acknowledged_at: null,affected_versions: [{ min: "0.45.0", fixed: "0.59.0" }],+ download_jar_urls: [],...overrides,});diff --git a/frontend/src/metabase-types/api/mocks/security-center.ts b/frontend/src/metabase-types/api/mocks/security-center.tsindex c497e9aff83..04949a323d2 100644--- a/frontend/src/metabase-types/api/mocks/security-center.ts+++ b/frontend/src/metabase-types/api/mocks/security-center.ts@@ -58,6 +58,7 @@ export function createAdvisory(overrides: Partial<Advisory> = {}): Advisory {acknowledged_by: null,acknowledged_at: null,affected_versions: [{ min: "0.45.0", fixed: "0.59.0" }],+ download_jar_urls: [],...overrides,};}diff --git a/frontend/src/metabase-types/api/security-center.ts b/frontend/src/metabase-types/api/security-center.tsindex 578642d7dc0..17ded1c2750 100644--- a/frontend/src/metabase-types/api/security-center.ts+++ b/frontend/src/metabase-types/api/security-center.ts@@ -11,6 +11,11 @@ export type AdvisoryVersionRange = {fixed: string;};+export type AdvisoryDownloadJarUrl = {+ version: string;+ url: string;+};+export type AdvisorySeverity = "critical" | "high" | "medium" | "low";export type AdvisoryId = string;@@ -28,6 +33,7 @@ export type Advisory = {acknowledged_by: { id: number; common_name: string; email: string } | null;acknowledged_at: string | null;affected_versions: AdvisoryVersionRange[];+ download_jar_urls: AdvisoryDownloadJarUrl[];};export type ListAdvisoriesResponse = {diff --git a/frontend/src/metabase/utils/version.ts b/frontend/src/metabase/utils/version.tsindex 70b30303555..ba1a1577ce3 100644--- a/frontend/src/metabase/utils/version.ts+++ b/frontend/src/metabase/utils/version.ts@@ -38,6 +38,10 @@ export function versionToNumericComponents(version: string): number[] | null {].map((part) => (typeof part === "string" ? parseInt(part, 10) : part));}+export function getMajorVersion(version: string): number | null {+ return versionToNumericComponents(version)?.[1] ?? null;+}+/*** this should correctly compare all version formats Metabase uses, e.g.* 0.0.9, 0.0.10-snapshot, 0.0.10-alpha1, 0.0.10-rc1, 0.0.10-rc2, 0.0.10-rc10diff --git a/resources/migrations/001_update_migrations.yaml b/resources/migrations/001_update_migrations.yamlindex d3affe5fd7d..61f66d725f8 100644--- a/resources/migrations/001_update_migrations.yaml+++ b/resources/migrations/001_update_migrations.yaml@@ -11776,6 +11776,27 @@ databaseChangeLog:- column:name: match_status+ - changeSet:+ id: v55.2026-03-30T00:00:05+ author: egorgrushin+ comment: Add security_advisory.download_jar_urls for per-version download links+ preConditions:+ - onFail: MARK_RAN+ - not:+ - columnExists:+ tableName: security_advisory+ columnName: download_jar_urls+ changes:+ - addColumn:+ tableName: security_advisory+ columns:+ - column:+ name: download_jar_urls+ type: ${text.type}+ remarks: "JSON array of {version, url} downloadable JARs"+ constraints:+ nullable: true+# >>>>>>>>>> DO NOT ADD NEW MIGRATIONS BELOW THIS LINE! ADD THEM ABOVE <<<<<<<<<<########################################################################################################################diff --git a/src/metabase/testing_api/api.clj b/src/metabase/testing_api/api.cljindex ec86683d371..96fc4c76183 100644--- a/src/metabase/testing_api/api.clj+++ b/src/metabase/testing_api/api.clj@@ -291,6 +291,7 @@[:advisory_url {:optional true} [:maybe ms/NonBlankString]][:remediation ms/NonBlankString][:affected_versions [:sequential [:map [:min :string] [:fixed :string]]]]+ [:download_jar_urls {:optional true} [:maybe [:sequential [:map [:version :string] [:url :string]]]]][:matching_query {:optional true} [:maybe [:map-of :keyword :string]]][:match_status [:enum "unknown" "active" "resolved" "not_affected" "error"]][:published_at :any]