Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

attempt to cut admin <-> sdk cycle in modules (#80146)

Nicolò Pretto9ad311d127dc
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index b6a2472593f..3da10acfc69 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -253,15 +253,21 @@ const elements = [
// feature
// The theme editor previews the live embed through the app-tier EAJS
// runtime, so the whole editor is an app-tier module. It still lives under
- // the admin folder, and the admin routes mount it via the whitelisted allow
- // rule below; the pattern must come before feature/admin (first match wins).
- // TODO(embedding-modules): move the folder out of admin and mount the route
- // from the app tier, then drop the whitelist entry.
+ // the admin folder; the pattern must come before feature/admin (first match
+ // wins).
+ // TODO(embedding-modules): move the folder out of admin so module == folder.
createElement({
type: "app",
name: "theme-editor",
pattern: "frontend/src/metabase/admin/embedding/components/ThemeEditor/**",
}),
+ // Route composition for the admin app. Must precede feature/admin.
+ ...[
+ "frontend/src/metabase/admin/routes.tsx",
+ "frontend/src/metabase/admin/routes.unit.spec.tsx",
+ ].map((pattern) =>
+ createElement({ type: "app", name: "admin-routes", pattern, mode: "full" }),
+ ),
createElement({ type: "feature", name: "admin" }),
createElement({ type: "feature", name: "dashboard" }),
createElement({ type: "feature", name: "data-studio" }),
@@ -329,6 +335,13 @@ const elements = [
createElement({ type: "feature", name: "search" }),
// app
+ // Composition/barrel file for reducers shared among the embedding sdk and the core app
+ createElement({
+ type: "app",
+ name: "reducers-common",
+ pattern: "frontend/src/metabase/reducers-common.ts",
+ mode: "full",
+ }),
...[
"frontend/src/metabase/app.tsx",
"frontend/src/metabase/app-embed-sdk.tsx",
@@ -342,7 +355,6 @@ const elements = [
"frontend/src/metabase/app/selectors.ts",
"frontend/src/metabase/app/selectors.unit.spec.ts",
"frontend/src/metabase/reducers-main.ts",
- "frontend/src/metabase/reducers-common.ts",
"frontend/src/metabase/reducers-public.ts",
"frontend/src/metabase/routes.tsx",
"frontend/src/metabase/routes.unit.spec.tsx",
@@ -450,14 +462,6 @@ const baseRules = [
from: ["app/*"],
allow: ["lib/*", "basic/*", "shared/*", "feature/*", "app/*"],
},
- // Whitelisted cross-tier edges. Keep this list short; every entry should
- // eventually be removed.
- // The admin routes lazy-mount the app-tier theme editor. Remove once the
- // route is registered from the app tier instead.
- {
- from: ["feature/admin"],
- allow: ["app/theme-editor"],
- },
];
// The full rule set drives the standalone `bun run module-boundaries` count.