Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix broken text wrapping in tables in documents (#65254)

Aleksandr Lesnenko9b41d141474e
diff --git a/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts b/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
index 0a74ab948e2..2cafb35645d 100644
--- a/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
+++ b/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
@@ -1,3 +1,4 @@
+import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
DOCUMENT_WITH_THREE_CARDS_AND_COLUMNS,
DOCUMENT_WITH_TWO_CARDS,
@@ -502,6 +503,45 @@ describe("documents card embed node custom logic", () => {
});
});
+ describe("text wrapping in table cards", () => {
+ it("should support text wrapping with proper row heights", () => {
+ H.createQuestion({
+ name: "reviews",
+ type: "model",
+ query: {
+ "source-table": SAMPLE_DATABASE.REVIEWS_ID,
+ },
+ visualization_settings: {
+ "table.column_widths": [246, 195, 69, 116, 134, 83],
+ column_settings: {
+ '["name","BODY"]': {
+ text_wrapping: true,
+ },
+ },
+ },
+ });
+
+ cy.visit("/document/new");
+
+ H.documentContent().click();
+ H.addToDocument("/reviews", false);
+ H.commandSuggestionItem(/reviews/).click();
+
+ H.getDocumentCard("reviews")
+ .should("be.visible")
+ .findByTestId("table-root")
+ .should("exist");
+
+ H.getDocumentCard("reviews").within(() => {
+ H.tableInteractive()
+ .find("[data-index=0]")
+ .should("exist")
+ .invoke("height")
+ .should("be.greaterThan", 60);
+ });
+ });
+ });
+
describe("deleting a cardEmbed", () => {
it("should allow you to remove a card if it is the first item in a docuemnt (UXW-2169)", () => {
cy.visit("/document/new");
diff --git a/frontend/src/metabase/data-grid/hooks/use-body-cell-measure.tsx b/frontend/src/metabase/data-grid/hooks/use-body-cell-measure.tsx
index 86ab2374951..7d2b05d5d3e 100644
--- a/frontend/src/metabase/data-grid/hooks/use-body-cell-measure.tsx
+++ b/frontend/src/metabase/data-grid/hooks/use-body-cell-measure.tsx
@@ -1,6 +1,8 @@
import type React from "react";
import { useCallback, useMemo, useRef } from "react";
+import { createPortal } from "react-dom";
+import { getPortalRootElement } from "metabase/css/core/overlays/utils";
import { BodyCell } from "metabase/data-grid/components/BodyCell/BodyCell";
import { reactNodeToHtmlString } from "metabase/lib/react-to-html";
import { EmotionCacheProvider } from "metabase/styled-components/components/EmotionCacheProvider";
@@ -99,11 +101,13 @@ export const useBodyCellMeasure = (theme?: DataGridTheme) => {
} = useCellMeasure(bodyCellToMeasure, "[data-grid-cell-content]");
const measureRoot = useMemo(
- () => (
- <EmotionCacheProvider>
- <ThemeProvider>{measureBodyCellRoot}</ThemeProvider>
- </EmotionCacheProvider>
- ),
+ () =>
+ createPortal(
+ <EmotionCacheProvider>
+ <ThemeProvider>{measureBodyCellRoot}</ThemeProvider>
+ </EmotionCacheProvider>,
+ getPortalRootElement(),
+ ),
[measureBodyCellRoot],
);
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.module.css b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.module.css
index dc630ac0f3e..62925b38458 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.module.css
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.module.css
@@ -33,10 +33,6 @@
-ms-user-select: none;
}
-.cardEmbed div[data-element-id="data-grid-measure-root"] {
- display: none;
-}
-
.questionHeader {
padding: 0.5rem 1rem;
}