Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remote sync should ignore system git settings (#65293)

Nathan Voxland9b4c474e1181
diff --git a/enterprise/backend/src/metabase_enterprise/remote_sync/init.clj b/enterprise/backend/src/metabase_enterprise/remote_sync/init.clj
index 6d0a844274c..e8b75977aea 100644
--- a/enterprise/backend/src/metabase_enterprise/remote_sync/init.clj
+++ b/enterprise/backend/src/metabase_enterprise/remote_sync/init.clj
@@ -1,15 +1,42 @@
(ns metabase-enterprise.remote-sync.init
(:require
+ [clojure.java.io :as io]
[metabase-enterprise.remote-sync.events]
[metabase-enterprise.remote-sync.impl :as impl]
[metabase-enterprise.remote-sync.settings :as settings]
[metabase-enterprise.remote-sync.task.import]
[metabase-enterprise.remote-sync.task.table-cleanup]
[metabase.startup.core :as startup]
- [metabase.util.log :as log]))
+ [metabase.util.log :as log])
+ (:import
+ (org.eclipse.jgit.storage.file FileBasedConfig)
+ (org.eclipse.jgit.util FS SystemReader SystemReader$Delegate)))
(set! *warn-on-reflection* true)
+(defn- create-isolated-system-reader
+ "Creates a SystemReader that does not read any system git configuration.
+ This prevents JGit from reading ~/.gitconfig or /etc/gitconfig files."
+ []
+ (let [base-reader (SystemReader/getInstance)]
+ (proxy [SystemReader$Delegate] [base-reader]
+ (getenv [variable]
+ (if (= "GIT_CONFIG_NOSYSTEM" variable)
+ "true"
+ (.getenv base-reader variable)))
+
+ (openUserConfig [_config ^FS fs]
+ (proxy [FileBasedConfig] [(io/file "_no_config_") ^FS fs]
+ (load [] nil)
+ (save [] nil)))
+
+ (openSystemConfig [_config ^FS fs]
+ (proxy [FileBasedConfig] [(io/file "_no_config_") ^FS fs]
+ (load [] nil)
+ (save [] nil))))))
+
+(SystemReader/setInstance (create-isolated-system-reader))
+
(defmethod startup/def-startup-logic! ::RemoteSyncInit [_]
;; Initialize Remote Sync features
(future