Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add explicit import/export direction to serialization errors (#63777)

Rodrigo López Dato9b82a4d92ddb
diff --git a/enterprise/backend/src/metabase_enterprise/serialization/api.clj b/enterprise/backend/src/metabase_enterprise/serialization/api.clj
index 3723824686f..d1ec6033ddd 100644
--- a/enterprise/backend/src/metabase_enterprise/serialization/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/serialization/api.clj
@@ -87,8 +87,8 @@
(catch Exception e
(reset! err e)
(if full-stacktrace
- (log/error e "Error during serialization")
- (log/error (u/strip-error e "Error during serialization"))))))]
+ (log/error e "Error during serialization export")
+ (log/error (u/strip-error e "Error during serialization export"))))))]
{:archive (when (.exists dst)
dst)
:log-file (when (.exists log-file)
@@ -142,8 +142,8 @@
(catch Exception e
(reset! err e)
(if full-stacktrace
- (log/error e "Error during serialization")
- (log/error (u/strip-error e "Error during serialization"))))))]
+ (log/error e "Error during serialization import")
+ (log/error (u/strip-error e "Error during serialization import"))))))]
{:log-file log-file
:status (:status (ex-data @err))
:error-message (when @err
diff --git a/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj b/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
index 6884bba9e71..4fe3d810501 100644
--- a/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
+++ b/enterprise/backend/src/metabase_enterprise/serialization/cmd.clj
@@ -270,8 +270,8 @@
(u/strip-error @err nil))})
(when @err
(if (:full-stacktrace opts)
- (log/error @err "Error during serialization")
- (log/error (u/strip-error @err "Error during deserialization")))
+ (log/error @err "Error during serialization export")
+ (log/error (u/strip-error @err "Error during serialization export")))
(throw (ex-info (ex-message @err) {:cmd/exit true})))
(log/info (format "Export to '%s' complete!" path) (u/emoji "🚛💨 📦"))
report))