The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
small ui fixes GDGT-1276 (#66406)
Egor Grushin9bef1912958a
diff --git a/e2e/test/scenarios/data-studio/data-model/data-studio-single-table.cy.spec.ts b/e2e/test/scenarios/data-studio/data-model/data-studio-single-table.cy.spec.tsindex 844f98b9cac..a3410cda339 100644--- a/e2e/test/scenarios/data-studio/data-model/data-studio-single-table.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/data-model/data-studio-single-table.cy.spec.ts@@ -51,7 +51,7 @@ describe("Table editing", () => {const expectedDate = new Date(updatedAt).toLocaleString();const viewCount = response?.body.view_count ?? 0;- cy.findByLabelText("Name on disk").should("have.text", "ORDERS");+ cy.findByLabelText("Name in the database").should("have.text", "ORDERS");cy.findByLabelText("Last updated at").should("have.text", expectedDate);cy.findByLabelText("View count").should("have.text", viewCount);cy.findByLabelText("Est. row count").should("not.exist");@@ -127,7 +127,7 @@ describe("Table editing", () => {TablePicker.getDatabase("QA Postgres12").click();TablePicker.getTable("Orders").click();- H.selectHasValue("Owner", "No one").click();+ H.selectHasValue("Owner", "Unspecified").click();H.selectDropdown().contains("Bobby Tables").click();H.undoToastListContainer().findByText("Table owner updated")@@ -136,7 +136,7 @@ describe("Table editing", () => {H.selectHasValue("Visibility type", "Bronze").click();H.selectDropdown().contains("Gold").click();H.undoToastListContainer()- .findByText("Table layer updated")+ .findByText("Table visibility type updated").should("be.visible");H.selectHasValue("Entity type", "Transaction").click();@@ -145,7 +145,7 @@ describe("Table editing", () => {.findByText("Entity type updated").should("be.visible");- H.selectHasValue("Source", "Unknown").click();+ H.selectHasValue("Source", "Unspecified").click();H.selectDropdown().contains("Ingested").click();H.undoToastListContainer().findByText("Table data source updated")diff --git a/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts b/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.tsindex b3b0b6659ce..72441ecde03 100644--- a/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/data-model/datamodel-data-studio.cy.spec.ts@@ -677,7 +677,7 @@ describe("scenarios > data studio > datamodel", () => {cy.get<TableId>("@silverTableId").then(expectTableNotVisible);});- it("should filter tables owned by no one", () => {+ it("should filter tables owned by unspecified", () => {cy.request("GET", "/api/user/current").its("body").then(({ id }) => {@@ -696,7 +696,7 @@ describe("scenarios > data studio > datamodel", () => {H.DataModel.visitDataStudio();openFilterPopover();- selectFilterOption("Owner", "No one");+ selectFilterOption("Owner", "Unspecified");applyFilters();cy.get<TableId>("@unownedTableId").then(expectTableVisible);diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableAttributesEditSingle.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableAttributesEditSingle.tsxindex 2137e6cfe3d..65c1ea3c399 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableAttributesEditSingle.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableAttributesEditSingle.tsx@@ -86,9 +86,9 @@ export function TableAttributesEditSingle({ table }: Props) {});if (error) {- sendErrorToast(t`Failed to update table layer`);+ sendErrorToast(t`Failed to update table visibility type`);} else {- sendSuccessToast(t`Table layer updated`, async () => {+ sendSuccessToast(t`Table visibility type updated`, async () => {const { error } = await updateTable({id: table.id,data_layer: table.data_layer,diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsxindex 7bdf3920ade..7d5090d8677 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx@@ -27,7 +27,7 @@ export function TableMetadata({ table }: Props) {return (<Stack gap="md">- <MetadataRow label={t`Name on disk`} value={table.name} />+ <MetadataRow label={t`Name in the database`} value={table.name} /><MetadataRow label={t`Last updated at`} value={formattedDate} /><MetadataRowlabel={t`View count`}diff --git a/frontend/src/metabase/metadata/components/DataSourceInput.tsx b/frontend/src/metabase/metadata/components/DataSourceInput.tsxindex 10bc44333b1..2d08f0bc927 100644--- a/frontend/src/metabase/metadata/components/DataSourceInput.tsx+++ b/frontend/src/metabase/metadata/components/DataSourceInput.tsx@@ -41,7 +41,7 @@ export const DataSourceInput = ({function getData(showMetabaseTransform?: boolean) {return [- { value: "unknown" as const, label: t`Unknown` },+ { value: "unknown" as const, label: t`Unspecified` },{ value: "ingested" as const, label: t`Ingested` },showMetabaseTransform? // eslint-disable-next-line no-literal-metabase-strings -- shown in Data Studio onlydiff --git a/frontend/src/metabase/metadata/components/LayerInput.tsx b/frontend/src/metabase/metadata/components/LayerInput.tsxindex 9844d5dca3d..f1d39191fe5 100644--- a/frontend/src/metabase/metadata/components/LayerInput.tsx+++ b/frontend/src/metabase/metadata/components/LayerInput.tsx@@ -58,7 +58,7 @@ export const LayerInput = ({leftSection={value ? <Icon c={getColor(value)} name="medallion" /> : undefined}- placeholder={t`Select a layer`}+ placeholder={t`Select a visibility type`}value={value}onChange={(value) => onChange(value)}onFocus={handleFocus}diff --git a/frontend/src/metabase/metadata/components/UserInput.tsx b/frontend/src/metabase/metadata/components/UserInput.tsxindex 3692f94d00f..aa993521314 100644--- a/frontend/src/metabase/metadata/components/UserInput.tsx+++ b/frontend/src/metabase/metadata/components/UserInput.tsx@@ -119,7 +119,7 @@ type Option = {function getData(email: string | null, users: User[]): Option[] {return [{- label: t`No one`,+ label: t`Unspecified`,value: "unknown",type: "unknown" as const,},