The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix validation in public dashboard action endpoint (#72088)
Ngoc Khuat9d50b86f1654
diff --git a/.clj-kondo/config/modules/config.edn b/.clj-kondo/config/modules/config.ednindex ccb92d66985..659f56ab9d6 100644--- a/.clj-kondo/config/modules/config.edn+++ b/.clj-kondo/config/modules/config.edn@@ -1537,7 +1537,7 @@requesttilesutil}- :model-imports #{:model/Card :model/Dashboard :model/Document}}+ :model-imports #{:model/Card :model/Dashboard :model/DashboardCard :model/Document}}pulse{:team "Gadget"diff --git a/src/metabase/public_sharing_rest/api.clj b/src/metabase/public_sharing_rest/api.cljindex e6b5fa813db..f9ebf8ef133 100644--- a/src/metabase/public_sharing_rest/api.clj+++ b/src/metabase/public_sharing_rest/api.clj@@ -381,10 +381,11 @@{:keys [parameters]} :- [:map[:parameters ms/JSONString]]](public-sharing.validation/check-public-sharing-enabled)- (api/check-404 (t2/select-one-pk :model/Dashboard :public_uuid uuid :archived false))- (actions/fetch-values- (api/check-404 (actions/dashcard->action dashcard-id))- (json/decode parameters)))+ (let [dashboard-id (api/check-404 (t2/select-one-pk :model/Dashboard :public_uuid uuid :archived false))]+ (api/check-404 (t2/select-one-pk :model/DashboardCard :id dashcard-id :dashboard_id dashboard-id))+ (actions/fetch-values+ (api/check-404 (actions/dashcard->action dashcard-id))+ (json/decode parameters))))(def ^:private dashcard-execution-throttle (throttle/make-throttler :dashcard-id :attempts-threshold 5000))diff --git a/test/metabase/public_sharing_rest/api_test.clj b/test/metabase/public_sharing_rest/api_test.cljindex baa3cb0e495..5d2252b4f4e 100644--- a/test/metabase/public_sharing_rest/api_test.clj+++ b/test/metabase/public_sharing_rest/api_test.clj@@ -699,6 +699,29 @@(is (= "An error occurred."(mt/user-http-request :crowberto :post 400 execute-path {:parameters {"id" 1 "name" "Blueberries" "price" 1234}})))))))))))))+(deftest public-dashboard-action-prefill-validates-dashcard-belongs-to-dashboard-test+ (testing "GET prefill should validate that the dashcard belongs to the dashboard"+ (mt/with-temporary-setting-values [enable-public-sharing true]+ (mt/test-drivers (mt/normal-drivers-with-feature :actions)+ (mt/with-actions-test-data-tables #{"venues" "categories"}+ (mt/with-actions-test-data-and-actions-enabled+ (mt/with-actions [{card-id :id} {:type :model, :dataset_query (mt/mbql-query venues {:fields [$id $name $price]})}+ {:keys [action-id]} {:type :implicit+ :kind "row/update"}]+ (let [public-uuid (str (random-uuid))]+ (mt/with-temp [:model/Dashboard {public-dashboard-id :id} {:public_uuid public-uuid}+ :model/DashboardCard _public-dashcard {:dashboard_id public-dashboard-id}+ :model/Dashboard {other-dashboard-id :id} {}+ :model/DashboardCard other-dashcard {:dashboard_id other-dashboard-id+ :action_id action-id+ :card_id card-id}]+ (testing "dashcard from a different dashboard should 404"+ (is (= "Not found."+ (client/client :get 404+ (format "public/dashboard/%s/dashcard/%s/execute"+ public-uuid (:id other-dashcard))+ :parameters (json/encode {:id 1}))))))))))))))+(deftest get-public-dashboard-actions-test(testing "GET /api/public/dashboard/:uuid"(mt/with-actions-test-data-and-actions-enabled