The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
handful of fixes (#64854)
Nick Fitzpatrick9ddffb2edf03
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.pngindex 63913eaff41..76be519e4cf 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.pngindex 0ddc4ecfb0d..be26ae8f7a3 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.pngindex 1d38c345f3c..05df61de6eb 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.pngindex 915ba6b03d9..c859ffd0f80 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.pngindex b9a6a5a5766..f8dfcdf87c8 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.pngindex 9e3699a0504..0ebb2bc599e 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png differdiff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.pngindex 21914d7a572..5d017beba62 100644Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png differdiff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.pngindex d5f41ae26ea..b06aa141424 100644Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png differdiff --git a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.cssindex b352e8d4c08..b73e8dad89f 100644--- a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css+++ b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css@@ -2,4 +2,5 @@border: 1px solid var(--mb-color-border);border-radius: var(--mantine-radius-sm);box-shadow: 0 2px 12px var(--mb-color-shadow);+ background: var(--mb-color-background);}diff --git a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.tsx b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.tsxindex 60e9855961f..9846ae886c0 100644--- a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.tsx@@ -101,7 +101,6 @@ export const EditorBubbleMenu: React.FC<EditorBubbleMenuProps> = ({><Flexgap={4}- bg="white"p="2px"className={S.bubbleMenu}data-testid="document-formatting-menu"diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsxindex e3d3d22b458..7087e4467f9 100644--- a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx+++ b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx@@ -40,11 +40,10 @@ export const PermissionsTableCell = styled.td`&:first-of-type {max-width: 300px;- background: var(--mb-color-white);left: 0;top: 0;position: sticky;- padding-left: 1.5rem;+ padding-left: 0;padding-right: 1.5rem;&:after {diff --git a/frontend/src/metabase/collections/components/CollectionHeader/CollectionCaption.tsx b/frontend/src/metabase/collections/components/CollectionHeader/CollectionCaption.tsxindex b2ad093b8ae..359825cd886 100644--- a/frontend/src/metabase/collections/components/CollectionHeader/CollectionCaption.tsx+++ b/frontend/src/metabase/collections/components/CollectionHeader/CollectionCaption.tsx@@ -93,14 +93,14 @@ const CollectionCaptionIcon = ({ collection }: { collection: Collection }) => {}if (isRootTrashCollection(collection)) {- return <Icon name="trash" size={24} />;+ return <Icon name="trash" size={24} c="text-disabled" />;}if (collection.archived &&PLUGIN_COLLECTIONS.isRegularCollection(collection)) {- return <Icon name="folder" size={24} c="text-light" />;+ return <Icon name="folder" size={24} c="text-disabled" />;}return (diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.cssindex 5f9d2fd8e3f..c5762e52e32 100644--- a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css+++ b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css@@ -22,17 +22,13 @@}&:disabled {- color: var(--mb-color-text-tertiary);+ color: var(--mb-color-text-disabled-inverse);border-color: color-mix(in srgb,- var(--mb-color-background),+ var(--mb-color-background-disabled-inverse),transparent 100%);- background-color: color-mix(- in srgb,- var(--mb-color-background),- transparent 90%- );+ background-color: var(--mb-color-background-disabled-inverse);}}diff --git a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsxindex 71b8f307ae7..abcc8f42c66 100644--- a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx+++ b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx@@ -47,7 +47,7 @@ export function SelectListItem({hasRightIcon={!!rightIcon}>{icon && (- <ItemIcon className={classNames.icon} c="brand" {...iconProps} />+ <ItemIcon className={classNames.icon} color="brand" {...iconProps} />)}<ItemTitleclassName={classNames.label}diff --git a/frontend/src/metabase/css/core/colors.module.css b/frontend/src/metabase/css/core/colors.module.cssindex 9b47e0f1d61..a87554efdf4 100644--- a/frontend/src/metabase/css/core/colors.module.css+++ b/frontend/src/metabase/css/core/colors.module.css@@ -115,3 +115,7 @@.bgLightBlue {background-color: var(--mb-color-bg-light);}++.textTooltipSecondary {+ color: var(--mb-color-tooltip-text-secondary);+}diff --git a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.cssindex 54cd2a79af8..0d38b6bc858 100644--- a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css+++ b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css@@ -3,10 +3,20 @@flex: 1;}+ &:hover {+ .QuestionListItemIcon {+ color: var(--mb-color-text-primary);+ }+ }+.QuestionListItemLabel {overflow: hidden;}+ .QuestionListItemIcon {+ color: var(--mb-color-brand);+ }+.QuestionListItemIcon:last-child {justify-self: start;}diff --git a/frontend/src/metabase/lib/colors/colors.ts b/frontend/src/metabase/lib/colors/colors.tsindex 49b8a64945f..a3ddc6a8012 100644--- a/frontend/src/metabase/lib/colors/colors.ts+++ b/frontend/src/metabase/lib/colors/colors.ts@@ -241,7 +241,7 @@ const baseColors = {export const colorConfig = {"accent-gray-dark": {light: baseColors.orion[20],- dark: baseColors.black,+ dark: baseColors.orion[110],},"accent-gray-light": {light: baseColors.orion[5],@@ -268,6 +268,10 @@ export const colorConfig = {light: baseColors.orionAlpha[10],dark: baseColors.orionAlphaInverse[10],},+ "background-disabled-inverse": {+ light: baseColors.orionAlphaInverse[10],+ dark: baseColors.orionAlpha[10],+ },"background-error-secondary": {light: baseColors.lobster[5],dark: baseColors.lobster[90],@@ -380,7 +384,7 @@ export const colorConfig = {},focus: {light: baseColors.blue[20],- dark: baseColors.blue[50],+ dark: baseColors.blue[70],},"icon-primary-disabled": {light: baseColors.orion[30],@@ -429,7 +433,7 @@ export const colorConfig = {},shadow: {light: baseColors.orionAlpha[20],- dark: `color-mix(in srgb, ${baseColors.black} 20%, transparent)`,+ dark: `color-mix(in srgb, ${baseColors.orion[110]} 20%, transparent)`,},"success-darker": {//should be success-primary?@@ -469,6 +473,10 @@ export const colorConfig = {light: baseColors.orionAlpha[40],dark: baseColors.orionAlphaInverse[40],},+ "text-disabled-inverse": {+ light: baseColors.orionAlphaInverse[40],+ dark: baseColors.orionAlpha[40],+ },"text-hover": {light: baseColors.brand[60],dark: baseColors.brand[30], //CHANGED DOWN TO HERE@@ -533,7 +541,7 @@ export const colorConfig = {},"tooltip-text": {light: baseColors.white,- dark: baseColors.white,+ dark: baseColors.orionAlphaInverse[80],},warning: {light: baseColors.dubloon[30],@@ -558,7 +566,7 @@ export const colorConfig = {white: {//should be changed to be semanticlight: baseColors.white,- dark: baseColors.black,+ dark: baseColors.orion[110],},// Legacy colors (keeping existing ones for backward compatibility)accent0: {@@ -595,11 +603,11 @@ export const colorConfig = {},"bg-primary": {light: baseColors.white,- dark: baseColors.black,+ dark: baseColors.orion[110],},"bg-secondary": {light: baseColors.orion[5],- dark: baseColors.black,+ dark: baseColors.orion[100],},"bg-tertiary": {//I don't think this is used?diff --git a/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx b/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsxindex 6c8e95ddc54..660b567369f 100644--- a/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx+++ b/frontend/src/metabase/list-view/components/ListView/ColumnValue.tsx@@ -8,14 +8,14 @@ import styles from "./ListView.module.css";// Light background colors for category valuesconst CATEGORY_COLORS = [- "color-mix(in srgb, var(--mb-color-brand) 8%, white)",- "color-mix(in srgb, var(--mb-color-success) 8%, white)",- "color-mix(in srgb, var(--mb-color-warning) 8%, white)",- "color-mix(in srgb, var(--mb-color-error) 8%, white)",- "color-mix(in srgb, var(--mb-color-filter) 8%, white)",- "color-mix(in srgb, var(--mb-color-summarize) 8%, white)",- "color-mix(in srgb, var(--mb-color-focus) 8%, white)",- "color-mix(in srgb, var(--mb-color-text-medium) 8%, white)",+ "color-mix(in srgb, var(--mb-color-brand) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-success) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-warning) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-error) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-filter) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-summarize) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-focus) 8%, var(--mb-color-background))",+ "color-mix(in srgb, var(--mb-color-text-medium) 8%, var(--mb-color-background))",];// Get a consistent color for a category value based on its hashdiff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsxindex fbaffca8347..d1ff96e49d4 100644--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx@@ -4,7 +4,7 @@ import styled from "@emotion/styled";export const ChartSettingsWidgetListHeader = styled.h4`margin-left: 2rem;margin-bottom: 1rem;- color: var(--mb-color-bg-dark);+ color: var(--mb-color-text-secondary);text-transform: uppercase;`;diff --git a/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx b/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsxindex 35a4abc3716..b02e26c0ee3 100644--- a/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx+++ b/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx@@ -84,7 +84,9 @@ const TooltipRow = ({}: TooltipRowProps) => (<tr>{name ? (- <TableCell className={cx(CS.textLight, CS.textRight)}>{name}:</TableCell>+ <TableCell className={cx(CS.textTooltipSecondary, CS.textRight)}>+ {name}:+ </TableCell>) : (<TableCell />)}