Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix Graphy log noise: classify customer-environment failures, fix the bugs behind the rest (#84353)

dpsutton9de985784a1c
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj b/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj
index 30df6d1906e..94932048992 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/models/analysis_finding.clj
@@ -49,11 +49,14 @@
"Convert an error from lib/find-bad-refs-with-source to a row for analysis_finding_error table.
We use `:message` for the error detail if there was an `validation-exception-error`."
[error :- ::lib.schema.validate/error-with-source]
- {:error-type (:type error)
- ;; error-detail cannot be longer than 254
- :error-detail (some-> (or (:name error) (:message error)) (u/truncate 254))
- :source-entity-type (:source-entity-type error)
- :source-entity-id (:source-entity-id error)})
+ ;; source_entity_id is an integer column; a non-integer id would fail the insert and roll back the whole analysis.
+ ;; `mu/defn` doesn't validate input in prod, so one can get here.
+ (let [source? (pos-int? (:source-entity-id error))]
+ {:error-type (:type error)
+ ;; error-detail cannot be longer than 254
+ :error-detail (some-> (or (:name error) (:message error)) (u/truncate 254))
+ :source-entity-type (when source? (:source-entity-type error))
+ :source-entity-id (when source? (:source-entity-id error))}))
(def ^:private FindingDetails
"The errors an analysis found, as `lib/find-bad-refs-with-source` returns them."
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/native_validation.clj b/enterprise/backend/src/metabase_enterprise/dependencies/native_validation.clj
index 5496a60a5e0..c3bbd67cc04 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/native_validation.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/native_validation.clj
@@ -270,10 +270,12 @@
Returns a set of errors, each enriched with source entity information when possible.
Returns empty set for queries with table-type template tags since the actual
- table (and therefore columns) is unknown at check time."
+ table (and therefore columns) is unknown at check time, and for non-SQL drivers (e.g. Mongo), whose native queries
+ the SQL parser can't read."
[driver :- :keyword
query :- ::lib.schema/query]
- (if (has-table-template-tags? query)
+ (if (or (not (isa? driver/hierarchy driver :sql))
+ (has-table-template-tags? query))
#{}
(into #{}
(comp
diff --git a/enterprise/backend/src/metabase_enterprise/transforms_python/base.clj b/enterprise/backend/src/metabase_enterprise/transforms_python/base.clj
index ded2d26a271..f347aa22f47 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms_python/base.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms_python/base.clj
@@ -416,7 +416,8 @@
:else
(do
- (log/errorf "Error executing Python transform: %s" (ex-message e))
+ ;; the caller owns the failure (and logs it); this returns it in the result map
+ (log/debugf "Error executing Python transform: %s" (ex-message e))
{:status :failed
:error e
:logs (str logs "\n" error-message)})))))))
diff --git a/enterprise/backend/src/metabase_enterprise/transforms_python/execute.clj b/enterprise/backend/src/metabase_enterprise/transforms_python/execute.clj
index cff7726ba2b..e2ad7a94c1b 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms_python/execute.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms_python/execute.clj
@@ -146,5 +146,5 @@
(transforms-base.u/complete-execution! transform {})
{:run_id run-id :result result}))))))
(catch Throwable t
- (log/errorf "Error executing Python transform: %s" (ex-message t))
+ (log/errorf "Error executing Python transform %s: %s" (pr-str (:id transform)) (ex-message t))
(throw t))))
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/models/analysis_finding_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/models/analysis_finding_test.clj
index 919f23bc793..e469f7f8ff3 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/models/analysis_finding_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/models/analysis_finding_test.clj
@@ -3,9 +3,11 @@
[clojure.test :refer :all]
[metabase-enterprise.dependencies.db :as dependencies.db]
[metabase-enterprise.dependencies.models.analysis-finding :as models.analysis-finding]
+ [metabase-enterprise.dependencies.models.analysis-finding-error :as models.analysis-finding-error]
[metabase-enterprise.dependencies.models.dependency :as models.dependency]
[metabase-enterprise.dependencies.test-util :as deps.test]
[metabase.test :as mt]
+ [metabase.util.malli :as mu]
[toucan2.core :as t2])
(:import
(java.util.concurrent CyclicBarrier TimeUnit)))
@@ -60,3 +62,15 @@
(is (=? {:result true} (finding card-id)))
(is (zero? (t2/count :model/AnalysisFindingError :analyzed_entity_type "card"
:analyzed_entity_id card-id))))))))))
+
+(deftest ^:synchronized malformed-source-id-does-not-break-the-finding-insert-test
+ (testing "an error naming a non-integer source (unchecked in prod) is recorded without the source (GHY-4956)"
+ (mt/with-premium-features #{:dependencies}
+ (mt/with-model-cleanup [:model/AnalysisFinding :model/AnalysisFindingError]
+ (mt/with-temp [:model/Card {cid :id} {}]
+ (mu/disable-enforcement
+ (models.analysis-finding/upsert-analysis! :card cid false
+ #{{:type :missing-card, :name "card__1"
+ :source-entity-type :card, :source-entity-id "card__1"}}))
+ (is (=? [{:error_type :missing-card, :source_entity_type nil, :source_entity_id nil}]
+ (models.analysis-finding-error/errors-for-entity :card cid))))))))
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/native_validation_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/native_validation_test.clj
index 6cce6c3ae00..171abeb27d5 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/native_validation_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/native_validation_test.clj
@@ -121,6 +121,14 @@
driver
(fake-query mp "select bad from products"))))))))
+(deftest ^:parallel validate-non-sql-native-query-test
+ (testing "native queries for non-SQL drivers aren't sent to the SQL parser (GHY-4955)"
+ (let [mp (deps.tu/default-metadata-provider)]
+ (is (= #{}
+ (deps.native-validation/validate-native-query
+ :mongo
+ (fake-query mp "[{\"$match\": {\"status\": \"active\"}}]")))))))
+
(deftest ^:parallel validate-table-function-query-test
(testing "can validate queries using table functions"
(let [mp (deps.tu/default-metadata-provider)
diff --git a/src/metabase/driver/sql_jdbc/metadata.clj b/src/metabase/driver/sql_jdbc/metadata.clj
index 7c81722bc8f..9cbfeb422c7 100644
--- a/src/metabase/driver/sql_jdbc/metadata.clj
+++ b/src/metabase/driver/sql_jdbc/metadata.clj
@@ -5,6 +5,7 @@
[metabase.driver-api.core :as driver-api]
[metabase.driver.sql-jdbc.execute :as sql-jdbc.execute]
[metabase.driver.sql-jdbc.sync.interface :as sql-jdbc.sync.interface]
+ [metabase.driver.sql.query-processor :as sql.qp]
[metabase.query-processor.schema :as qp.schema]
[metabase.util.malli :as mu]
[metabase.util.performance :refer [mapv]]))
@@ -30,7 +31,8 @@
database
nil
(fn [^java.sql.Connection conn]
- (with-open [stmt (sql-jdbc.execute/prepared-statement driver conn sql params)]
+ ;; Some JDBC drivers (e.g. Athena) get metadata by wrapping the SQL in a subselect, which breaks on a trailing `;`
+ (with-open [stmt (sql-jdbc.execute/prepared-statement driver conn (sql.qp/make-nestable-sql* sql) params)]
(let [rsmeta (.getMetaData stmt)]
(mapv (fn [i]
(let [database-type (.getColumnTypeName rsmeta i)]
diff --git a/src/metabase/lib/validate.cljc b/src/metabase/lib/validate.cljc
index 8844ebae3bf..c005dc6cefa 100644
--- a/src/metabase/lib/validate.cljc
+++ b/src/metabase/lib/validate.cljc
@@ -142,11 +142,13 @@
[query :- ::lib.schema/query]
(let [mp (lib.metadata/->metadata-provider query)
bad-sources (volatile! #{})
+ ;; `mu/defn` doesn't validate input in prod, so a malformed id (e.g. "card__1") can get here: report the
+ ;; error, but only name the source when it's a real id
flag! (fn [error entity-type entity-id]
(vswap! bad-sources conj
- (assoc error
- :source-entity-type entity-type
- :source-entity-id entity-id)))]
+ (cond-> error
+ (pos-int? entity-id) (assoc :source-entity-type entity-type
+ :source-entity-id entity-id))))]
(lib.walk/walk-stages
query
(fn [_query _path stage]
diff --git a/src/metabase/parameters/field.clj b/src/metabase/parameters/field.clj
index a7653c8198a..b701cebdc4c 100644
--- a/src/metabase/parameters/field.clj
+++ b/src/metabase/parameters/field.clj
@@ -71,7 +71,10 @@
limit (or maybe-limit default-max-field-search-limit)]
(search-values-query/search-values-query field search-field value limit))
(catch Throwable e
- (log/errorf "Error searching field values: %s" (ex-message e))
+ ;; search-as-you-type on a big unindexed column can hit a statement timeout; that's expected
+ (if (some (comp :query/query-canceled? ex-data) (u/full-exception-chain e))
+ (log/warnf "Field values search was canceled: %s" (ex-message e))
+ (log/errorf "Error searching field values: %s" (ex-message e)))
[]))))
(mu/defn field->values :- ms/FieldValuesResult
diff --git a/src/metabase/queries/models/card/metadata.clj b/src/metabase/queries/models/card/metadata.clj
index ef3670add74..5915d11342d 100644
--- a/src/metabase/queries/models/card/metadata.clj
+++ b/src/metabase/queries/models/card/metadata.clj
@@ -11,6 +11,7 @@
[metabase.models.interface :as mi]
[metabase.queries.db :as queries.db]
[metabase.queries.schema :as queries.schema]
+ [metabase.query-processor.error-type :as qp.error-type]
[metabase.query-processor.metadata :as qp.metadata]
[metabase.query-processor.preprocess :as qp.preprocess]
[metabase.query-processor.schema :as qp.schema]
@@ -32,7 +33,10 @@
#_{:clj-kondo/ignore [:deprecated-var]}
(qp.metadata/legacy-result-metadata query api/*current-user-id*)
(catch Throwable e
- (log/errorf "Error calculating result metadata for Card: %s" (ex-message e))
+ ;; a native query with a required parameter and no default can't run without a value; that's expected here
+ (if (qp.error-type/missing-required-parameter? e)
+ (log/debugf "Not calculating result metadata for Card: %s" (ex-message e))
+ (log/errorf "Error calculating result metadata for Card: %s" (ex-message e)))
;; sentinel: callers distinguish this from "the query produced no columns"
::recompute-failed))))
diff --git a/src/metabase/query_processor/error_type.clj b/src/metabase/query_processor/error_type.clj
index 56bc6b04a49..f2f5999c498 100644
--- a/src/metabase/query_processor/error_type.clj
+++ b/src/metabase/query_processor/error_type.clj
@@ -3,7 +3,10 @@
is one of the types here. If you see an Exception in QP code that doesn't return an `:type`, add it!
(throw (ex-info (tru \"Don''t know how to parse {0} {1}\" (class x) x)
- {:type qp.error-type/invalid-parameter}))")
+ {:type qp.error-type/invalid-parameter}))"
+ (:require
+ [metabase.util :as u]
+ [metabase.util.performance :as perf]))
(def ^:private hierarchy
(make-hierarchy))
@@ -63,6 +66,13 @@
:parent invalid-query
:show-in-embeds? true)
+(defn missing-required-parameter?
+ "Does `e`, or any exception in its cause chain, have `:type` [[missing-required-parameter]]? Middleware wraps the
+ original exception, so the type is usually not on the outermost one."
+ [e]
+ (boolean (perf/some #(= (:type (ex-data %)) missing-required-parameter)
+ (u/full-exception-chain e))))
+
(deferror multiple-conflicting-parameter-values
"The query is parameterized, and multiple filters provided conflicting values."
:parent invalid-query
diff --git a/src/metabase/query_processor/metadata.clj b/src/metabase/query_processor/metadata.clj
index c287eaaac10..fbd48666747 100644
--- a/src/metabase/query_processor/metadata.clj
+++ b/src/metabase/query_processor/metadata.clj
@@ -13,6 +13,7 @@
[metabase.lib.schema.id :as lib.schema.id]
[metabase.lib.schema.metadata :as lib.schema.metadata]
[metabase.query-processor :as qp]
+ [metabase.query-processor.error-type :as qp.error-type]
[metabase.query-processor.preprocess :as qp.preprocess]
[metabase.query-processor.schema :as qp.schema]
[metabase.query-processor.util :as qp.util]
@@ -61,7 +62,9 @@
(try
(qp/process-query query' result-metadata-rff)
(catch Throwable e
- (log/errorf "Error running query to determine Card result metadata: %s" (ex-message e))
+ (if (qp.error-type/missing-required-parameter? e)
+ (log/debugf "Not running query to determine Card result metadata: %s" (ex-message e))
+ (log/errorf "Error running query to determine Card result metadata: %s" (ex-message e)))
[]))))
(mu/defn- metadata-from-driver :- [:sequential :map]
diff --git a/src/metabase/sync/fetch_metadata.clj b/src/metabase/sync/fetch_metadata.clj
index 4f91267c6b8..16c23c20d44 100644
--- a/src/metabase/sync/fetch_metadata.clj
+++ b/src/metabase/sync/fetch_metadata.clj
@@ -16,13 +16,17 @@
[metabase.util.malli.fn :as mu.fn]))
(defmacro log-if-error
- "Logs an error message if an exception is thrown while executing the body."
+ "Logs an error message if an exception is thrown while executing the body. The sync step that catches the exception
+ logs it too, so failures that aren't Metabase bugs (an unreachable warehouse, a missing grant) only log at DEBUG
+ here."
{:style/indent 1}
[function-name & body]
`(try
~@body
(catch Throwable e#
- (log/errorf "Error while fetching metadata with '%s': %s" ~function-name (ex-message e#))
+ (if (or (sync-util/transient-exception? e#) (sync-util/customer-environment-exception? e#))
+ (log/debugf "Error while fetching metadata with '%s': %s" ~function-name (ex-message e#))
+ (log/errorf "Error while fetching metadata with '%s': %s" ~function-name (ex-message e#)))
(throw e#))))
(mu/defn db-metadata :- i/DatabaseMetadata
@@ -71,6 +75,9 @@
(mapv #(assoc % :table-schema (:schema table) :table-name (:name table))
table-fields))
(catch Throwable e
+ ;; an unreachable warehouse fails every table the same way; abort so sync can retry later
+ (when (sync-util/transient-exception? e)
+ (throw e))
(log/warn (str "Could not fetch fields from table " table-id ": " (ex-message e)))
nil))))
table-ids)))
diff --git a/src/metabase/sync/sync_metadata.clj b/src/metabase/sync/sync_metadata.clj
index 1eabacb2d7a..42c4b6adefe 100644
--- a/src/metabase/sync/sync_metadata.clj
+++ b/src/metabase/sync/sync_metadata.clj
@@ -20,6 +20,7 @@
[metabase.sync.sync-metadata.tables :as sync-tables]
[metabase.sync.util :as sync-util]
[metabase.tracing.core :as tracing]
+ [metabase.util.log :as log]
[metabase.util.malli :as mu]
[metabase.warehouse-schema.models.table :as table]))
@@ -73,6 +74,12 @@
(tracing/with-span :sync "sync.metadata.fetch-metadata" {:db/id (:id database)}
(fetch-metadata/db-metadata database))
(catch Throwable e
+ ;; `log-if-error` logs a transient failure only at DEBUG, and the sync operation rethrows
+ ;; it without logging, so a caller that drops the exception (e.g. a `future`) leaves no
+ ;; other trace
+ (when (sync-util/transient-exception? e)
+ (log/warnf "Could not fetch metadata for %s: %s"
+ (sync-util/name-for-logging database) (ex-message e)))
(sync-util/set-initial-database-sync-aborted! database e)
(throw e)))
;; holder the `sync-tables` step fills with any `_metabase_metadata` table(s) as it streams
diff --git a/src/metabase/sync/sync_metadata/fields.clj b/src/metabase/sync/sync_metadata/fields.clj
index f172f394788..74e211d5c8d 100644
--- a/src/metabase/sync/sync_metadata/fields.clj
+++ b/src/metabase/sync/sync_metadata/fields.clj
@@ -153,7 +153,16 @@
table)]
(sync-and-update! database table all-metadata))
(catch Exception e
- (log/error (ex-message e))
+ ;; an unreachable warehouse fails every table: abort the step
+ (when (sync-util/transient-exception? e)
+ (throw e))
+ ;; a missing grant or FDW user mapping is for the customer to
+ ;; fix, not a Metabase bug
+ (if (sync-util/customer-environment-exception? e)
+ (log/warnf "Error syncing Fields for %s: %s"
+ (sync-util/name-for-logging table) (ex-message e))
+ (log/errorf e "Error syncing Fields for %s: %s"
+ (sync-util/name-for-logging table) (ex-message e)))
0))
0)]
{:total-fields (count table-metadata)
diff --git a/src/metabase/sync/sync_metadata/metabase_metadata.clj b/src/metabase/sync/sync_metadata/metabase_metadata.clj
index fe196ad7d61..ce2723a138c 100644
--- a/src/metabase/sync/sync_metadata/metabase_metadata.clj
+++ b/src/metabase/sync/sync_metadata/metabase_metadata.clj
@@ -81,10 +81,15 @@
[driver :- :keyword
database :- i/DatabaseInstance
metabase-metadata-table :- i/DatabaseMetadataTable]
- (doseq [{:keys [keypath value]} (driver/table-rows-seq driver database metabase-metadata-table)]
- (sync-util/with-error-handling (format "Error handling metabase metadata entry: set %s -> %s" keypath value)
- (or (set-property! database (parse-keypath keypath) value)
- (log/error (u/format-color 'red "Error syncing _metabase_metadata: no matching keypath, or property not settable: %s" keypath))))))
+ (let [unmatched (volatile! [])]
+ (doseq [{:keys [keypath value]} (driver/table-rows-seq driver database metabase-metadata-table)]
+ (sync-util/with-error-handling (format "Error handling metabase metadata entry: set %s -> %s" keypath value)
+ (when-not (set-property! database (parse-keypath keypath) value)
+ (vswap! unmatched conj keypath))))
+ ;; usually stale rows for tables that no longer exist, so one line per sync rather than one per row
+ (when-let [keypaths (seq @unmatched)]
+ (log/warnf "Ignoring %d _metabase_metadata row(s) whose keypath matches nothing or isn't settable: %s"
+ (count keypaths) (str/join ", " (take 20 keypaths))))))
(mu/defn is-metabase-metadata-table?
"Is this TABLE the special `_metabase_metadata` table?"
diff --git a/src/metabase/sync/util.clj b/src/metabase/sync/util.clj
index 028a8cdd10f..24b11147ff8 100644
--- a/src/metabase/sync/util.clj
+++ b/src/metabase/sync/util.clj
@@ -236,6 +236,29 @@
(or (isa? transient-exception-hierarchy (class e) ::transient-exception)
(some-> (ex-cause e) recur)))
+(defn- customer-environment-sql-exception?
+ [^java.sql.SQLException e]
+ (let [state (.getSQLState e)]
+ (or (some-> state (str/starts-with? "28")) ; invalid authorization specification
+ (= state "42501") ; insufficient privilege
+ (and (= state "42000") ; MySQL: access denied to a db, table, or column
+ (contains? #{1044 1142 1143} (.getErrorCode e)))
+ (some-> (ex-message e) (str/includes? "user mapping not found"))))) ; Postgres FDW
+
+(defn- customer-environment-exception*?
+ [e]
+ (or (and (instance? java.sql.SQLException e)
+ (customer-environment-sql-exception? e))
+ ;; checked on every exception: a JDBC driver may put the AWS SDK's message in its own SQLException
+ (some-> (ex-message e) (str/includes? "not authorized to perform:")))) ; AWS IAM denial (Athena, Glue)
+
+(defn customer-environment-exception?
+ "True if `e` (or any of its causes) is a failure the customer has to fix in their own environment -- the connecting
+ user lacks a login, a grant, a user mapping, or an IAM permission -- rather than a Metabase bug. Like
+ [[transient-exception?]] failures, these are still logged, but not at ERROR."
+ [e]
+ (boolean (some customer-environment-exception*? (u/full-exception-chain e))))
+
(defn do-with-error-handling
"Internal implementation of [[with-error-handling]]; use that instead of calling this directly."
([f]
diff --git a/src/metabase/transforms/canceling.clj b/src/metabase/transforms/canceling.clj
index 327b694c4b0..356e7a8a29b 100644
--- a/src/metabase/transforms/canceling.clj
+++ b/src/metabase/transforms/canceling.clj
@@ -16,6 +16,7 @@
[metabase.util.jvm :as u.jvm]
[metabase.util.log :as log])
(:import
+ (com.mchange.v2.resourcepool TimeoutException)
(java.time OffsetDateTime)
(java.util.concurrent Executors ScheduledExecutorService TimeUnit)))
@@ -185,6 +186,12 @@
:label "transform run"
:reap-fn #(transform-run/reap-orphaned-runs! transform-heartbeat-stale-minutes)}))
+(defn- app-db-checkout-timeout?
+ "Is `e`, or anything in its cause chain, a c3p0 pool-checkout timeout? Then the app DB pool is exhausted, and this
+ poller is only the messenger."
+ [^Throwable e]
+ (boolean (some #(instance? TimeoutException %) (u/full-exception-chain e))))
+
(defmethod task/init! ::CancelRuns [_]
(log/info "Scheduling the cancelation background task.")
;; does not use the Quartz scheduler
@@ -201,4 +208,6 @@
(log/error (str "Error canceling " id ": " (ex-message t)))))))
(wr.cancelation/reducible-canceled-local-runs))
(catch Throwable t
- (log/errorf "Error while canceling a transform run: %s" (ex-message t)))) 0 20 TimeUnit/SECONDS))
+ (if (app-db-checkout-timeout? t)
+ (log/warnf "Could not check for transform runs to cancel: %s" (ex-message t))
+ (log/errorf "Error while canceling a transform run: %s" (ex-message t))))) 0 20 TimeUnit/SECONDS))
diff --git a/src/metabase/transforms/execute.clj b/src/metabase/transforms/execute.clj
index b69128fe00d..e8175837019 100644
--- a/src/metabase/transforms/execute.clj
+++ b/src/metabase/transforms/execute.clj
@@ -4,7 +4,8 @@
[metabase.transforms-base.util :as transforms-base.u]
[metabase.transforms.interface :as transforms.i]
;; load the `transforms.i/execute!` `:query` method
- [metabase.transforms.query-impl]))
+ [metabase.transforms.query-impl]
+ [metabase.util.log :as log]))
(set! *warn-on-reflection* true)
@@ -36,7 +37,13 @@
(when on-start
(on-start run-id)))})]
(try
- (transforms.i/execute! (resolve-target transform) opts)
+ ;; the executors log their own failures at ERROR; this one happens before any executor runs
+ (transforms.i/execute! (try (resolve-target transform)
+ (catch Throwable t
+ (log/errorf "Could not resolve the target of transform %s: %s"
+ (pr-str (:id transform)) (ex-message t))
+ (throw t)))
+ opts)
(catch Throwable t
;; so a caller awaiting the start isn't left hanging on a pre-start failure;
;; a no-op when the run had already started and the promise was delivered
diff --git a/src/metabase/transforms/jobs.clj b/src/metabase/transforms/jobs.clj
index 57302a1e0d0..fc8362ed3cb 100644
--- a/src/metabase/transforms/jobs.clj
+++ b/src/metabase/transforms/jobs.clj
@@ -181,7 +181,8 @@
(run-transform! ctx started-run-id transform)
{::status :succeeded ::transform transform}
(catch Throwable t
- (log/errorf "Transform %s in run %s failed: %s" (pr-str (:id transform)) (pr-str run-id) (ex-message t))
+ ;; WARN: a failure while executing was already logged at ERROR by the transform's executor
+ (log/warnf "Transform %s in run %s failed: %s" (pr-str (:id transform)) (pr-str run-id) (ex-message t))
{::status :failed
::transform transform
::message (or (ex-message t) (str t))
@@ -476,6 +477,8 @@
(log/errorf "Error when failing %s %s: %s" label (pr-str run-id) (ex-message e)))))
result)
(catch Throwable t
+ ;; a transform's own failure is returned in `result`, not thrown, so this is the coordinator failing
+ (log/errorf "%s %s failed: %s" label (pr-str run-id) (ex-message t))
(try
(coordinated-run/fail-started-run! model run-id {:message (ex-message t)})
(catch Exception e
diff --git a/src/metabase/transforms/query_impl.clj b/src/metabase/transforms/query_impl.clj
index 7232f890867..02b1abc305f 100644
--- a/src/metabase/transforms/query_impl.clj
+++ b/src/metabase/transforms/query_impl.clj
@@ -71,7 +71,7 @@
(catch Throwable t
(if (= :already-running (:error (ex-data t)))
(log/warnf "Transform %d is already running" id)
- (log/errorf "Error executing transform: %s" (ex-message t)))
+ (log/errorf "Error executing transform %d: %s" id (ex-message t)))
(throw t)))))
(defmethod transforms.i/execute! :query [transform opts]
diff --git a/src/metabase/transforms_base/query.clj b/src/metabase/transforms_base/query.clj
index 261c003dff1..4e801e96622 100644
--- a/src/metabase/transforms_base/query.clj
+++ b/src/metabase/transforms_base/query.clj
@@ -146,7 +146,8 @@
{:status :cancelled
:error e}
(do
- (log/errorf "Error executing transform: %s" (ex-message e))
+ ;; the caller owns the failure (and logs it); this returns it in the result map
+ (log/debugf "Error executing transform: %s" (ex-message e))
{:status :failed
:error e}))))))
diff --git a/src/metabase/transforms_rest/api/util.clj b/src/metabase/transforms_rest/api/util.clj
index daaf7be9fea..7c260baebd4 100644
--- a/src/metabase/transforms_rest/api/util.clj
+++ b/src/metabase/transforms_rest/api/util.clj
@@ -41,8 +41,9 @@
(try
(start! start-promise)
(catch Throwable t
- ;; post-start failures: the run row was already failed by the runner; this is a fallback log
- (log/errorf "Async run failed: %s" (ex-message t)))))
+ ;; post-start failures: the run row was already failed, and the error logged at ERROR, by the transform's
+ ;; executor or the job/DAG coordinator; this is a fallback log
+ (log/warnf "Async run failed: %s" (ex-message t)))))
(when (instance? Throwable @start-promise)
(throw @start-promise))
(let [result @start-promise
diff --git a/src/metabase/warehouses/models/database.clj b/src/metabase/warehouses/models/database.clj
index fd2a0895443..51139492c71 100644
--- a/src/metabase/warehouses/models/database.clj
+++ b/src/metabase/warehouses/models/database.clj
@@ -652,8 +652,11 @@
;; there is an known issue with exception is ignored when render API response (#32822)
;; If you see this error, you probably need to define a setting for `setting-name`.
;; But ideally, we should resolve the above issue, and remove this try/catch
- (log/errorf "Error checking the readability of %s setting. The setting will be hidden in API response. Error: %s"
- setting-name (ex-message e))
+ (if (setting/registered? setting-name)
+ (log/errorf "Error checking the readability of %s setting. The setting will be hidden in API response. Error: %s"
+ setting-name (ex-message e))
+ ;; a removed setting stays in the stored settings until the database is saved
+ (log/debugf "Hiding unknown setting %s in API response" setting-name))
;; let's be conservative and hide it by defaults, if you want to see it,
;; you need to define it :)
false)))
diff --git a/test/metabase/driver/sql_jdbc/metadata_test.clj b/test/metabase/driver/sql_jdbc/metadata_test.clj
index 85f4fcbbc4a..fd70b39c535 100644
--- a/test/metabase/driver/sql_jdbc/metadata_test.clj
+++ b/test/metabase/driver/sql_jdbc/metadata_test.clj
@@ -2,6 +2,8 @@
{:clj-kondo/config '{:linters {:deprecated-var {:exclude {metabase.test.data/mbql-query {:namespaces [metabase.driver.sql-jdbc.metadata-test]}}}}}}
(:require
[clojure.test :refer :all]
+ [metabase.driver :as driver]
+ [metabase.driver.sql-jdbc.execute :as sql-jdbc.execute]
[metabase.driver.sql-jdbc.metadata :as sql-jdbc.metadata]
[metabase.test :as mt]))
@@ -34,3 +36,19 @@
(sql-jdbc.metadata/query-result-metadata
:h2
(mt/native-query {:query "SELECT * FROM venues WHERE id = ?;", :params [1]}))))))
+
+;; Mimics the Athena JDBC driver, which gets metadata by preparing `SELECT * FROM (<sql>) LIMIT 0`
+(driver/register! ::subselect-wrapping-h2, :parent :h2)
+
+(defmethod sql-jdbc.execute/prepared-statement ::subselect-wrapping-h2
+ [_driver conn sql params]
+ ((get-method sql-jdbc.execute/prepared-statement :h2) :h2 conn (str "SELECT * FROM (" sql ") LIMIT 0") params))
+
+(deftest ^:parallel trailing-semicolon-is-stripped-before-preparing-test
+ (testing "A trailing `;` breaks drivers that get metadata by wrapping the SQL in a subselect (GHY-4953)"
+ (doseq [sql ["SELECT 1 AS x;"
+ "SELECT 1 AS x; -- trailing comment"
+ "SELECT 1 AS x ;\n; "]]
+ (testing (pr-str sql)
+ (is (=? [{:name "X"}]
+ (sql-jdbc.metadata/query-result-metadata ::subselect-wrapping-h2 (mt/native-query {:query sql}))))))))
diff --git a/test/metabase/lib/validate_test.cljc b/test/metabase/lib/validate_test.cljc
index c02da590521..7612703b48e 100644
--- a/test/metabase/lib/validate_test.cljc
+++ b/test/metabase/lib/validate_test.cljc
@@ -5,7 +5,8 @@
[metabase.lib.core :as lib]
[metabase.lib.metadata :as lib.metadata]
[metabase.lib.test-metadata :as meta]
- [metabase.lib.test-util :as lib.tu]))
+ [metabase.lib.test-util :as lib.tu]
+ [metabase.util.malli :as mu]))
(deftest ^:parallel find-bad-refs-with-source-table-test
(testing "invalid query of a table returns error with table as source"
@@ -214,6 +215,14 @@
:source-entity-id card-id}}
(lib/find-bad-refs-with-source query-on-deleted-card)))))))
+(deftest ^:parallel find-bad-refs-with-source-malformed-source-id-test
+ (testing "a malformed `:source-card` id (unchecked in prod) is reported without a source (GHY-4956)"
+ (let [query (assoc-in (lib/query meta/metadata-provider (meta/table-metadata :products))
+ [:stages 0] {:lib/type :mbql.stage/mbql, :source-card "card__1"})]
+ (is (= #{{:type :missing-card}}
+ (mu/disable-enforcement
+ (lib/find-bad-refs-with-source query)))))))
+
(deftest ^:parallel find-bad-refs-with-source-multi-stage-test
(testing "invalid query referencing previous stage has no source"
(let [mp meta/metadata-provider
diff --git a/test/metabase/parameters/field_test.clj b/test/metabase/parameters/field_test.clj
index d3af0d5c44f..2e393b02ae6 100644
--- a/test/metabase/parameters/field_test.clj
+++ b/test/metabase/parameters/field_test.clj
@@ -2,6 +2,7 @@
(:require
[clojure.test :refer :all]
[metabase.parameters.field :as parameters.field]
+ [metabase.parameters.field.search-values-query :as search-values-query]
[metabase.query-processor.timeseries-test.util :as tqpt]
[metabase.test :as mt]
[toucan2.core :as t2]))
@@ -88,3 +89,20 @@
(t2/select-one :model/Field (mt/id :users :name))
"African"
nil))))))
+
+(deftest search-values-canceled-query-is-a-warning-test
+ (testing "a search query canceled by a statement timeout logs at warn, other failures at error (GHY-4958)"
+ (let [search (fn [ex]
+ (mt/with-dynamic-fn-redefs [search-values-query/search-values-query (fn [& _] (throw ex))]
+ (mt/with-log-messages-for-level [messages [metabase.parameters.field :warn]]
+ (is (= [] (parameters.field/search-values (t2/select-one :model/Field :id (mt/id :venues :id))
+ (t2/select-one :model/Field :id (mt/id :venues :name))
+ "Red")))
+ (mapv :level (messages)))))]
+ (is (= [:warn]
+ (search (ex-info "Error reducing result rows"
+ {}
+ (ex-info "Error executing query: ERROR: canceling statement due to statement timeout"
+ {:query/query-canceled? true})))))
+ (is (= [:error]
+ (search (ex-info "Error executing query: Code: 47. DB::Exception: Identifier cannot be resolved" {})))))))
diff --git a/test/metabase/queries/models/card/metadata_test.clj b/test/metabase/queries/models/card/metadata_test.clj
index a14d63c34e3..cce8b07aff7 100644
--- a/test/metabase/queries/models/card/metadata_test.clj
+++ b/test/metabase/queries/models/card/metadata_test.clj
@@ -153,3 +153,20 @@
(is (= typed (metadata typed-id))))
(testing "a model whose metadata still cannot be inferred is not changed"
(is (= unresolvable (metadata unresolvable-id))))))))
+
+(deftest missing-required-parameter-is-not-an-error-test
+ (testing "a native query whose required parameter has no value is expected to fail metadata calculation (GHY-4954)"
+ (let [mp (mt/metadata-provider)
+ query (fn [sql template-tags]
+ (lib/query mp (mt/native-query {:query sql, :template-tags template-tags})))
+ logs (fn [query]
+ (mt/with-log-messages-for-level [messages [metabase.queries.models.card.metadata :debug]]
+ (is (= ::card.metadata/recompute-failed @(#'card.metadata/legacy-result-metadata-future query)))
+ (into #{} (map :level) (messages))))]
+ (testing "logs at debug"
+ (is (= #{:debug}
+ (logs (query "SELECT * FROM venues WHERE id = {{id}}"
+ {"id" {:name "id", :display-name "ID", :type :number, :required true, :id "1"}})))))
+ (testing "other failures still log at error"
+ (is (= #{:error}
+ (logs (query "SELECT * FROM no_such_table" {}))))))))
diff --git a/test/metabase/sync/fetch_metadata_test.clj b/test/metabase/sync/fetch_metadata_test.clj
new file mode 100644
index 00000000000..000e90b1747
--- /dev/null
+++ b/test/metabase/sync/fetch_metadata_test.clj
@@ -0,0 +1,55 @@
+(ns metabase.sync.fetch-metadata-test
+ (:require
+ [clojure.test :refer :all]
+ [metabase.sync.fetch-metadata :as fetch-metadata]
+ [metabase.test :as mt])
+ (:import
+ (com.mchange.v2.resourcepool CannotAcquireResourceException)
+ (java.sql SQLException)))
+
+(defn- tables-attempted
+ "Run the describe-table fallback over the test DB with every table failing with `e`. Returns the number of tables
+ attempted and whether the run threw."
+ [e]
+ (let [attempted (atom 0)
+ ;; outside the redef: the first `mt/db` creates and syncs the test DB, which must not see the failures
+ db (mt/db)]
+ (mt/with-dynamic-fn-redefs [fetch-metadata/table-fields-metadata (fn [_database _table]
+ (swap! attempted inc)
+ (throw e))]
+ (let [threw? (try
+ (dorun (#'fetch-metadata/describe-fields-using-describe-table :h2 db))
+ false
+ (catch Throwable _ true))]
+ {:attempted @attempted, :threw? threw?}))))
+
+(deftest describe-fields-fallback-aborts-on-transient-failure-test
+ (testing "an unreachable warehouse fails every table the same way, so stop after the first (GHY-4944)"
+ (is (= {:attempted 1, :threw? true}
+ (tables-attempted (SQLException. "Connections could not be acquired from the underlying database!"
+ (CannotAcquireResourceException. "A ResourcePool could not acquire a resource"))))))
+ (testing "a failure specific to one table is skipped, and the rest are still described"
+ (is (=? {:attempted #(> % 1), :threw? false}
+ (tables-attempted (SQLException. "permission denied for table"))))))
+
+(defn- sql-exception
+ ([message state] (sql-exception message state 0))
+ ([message state code] (SQLException. ^String message ^String state (int code))))
+
+(deftest log-if-error-levels-test
+ (testing "the sync step logs every failure; fetch-metadata adds an ERROR only for what might be a Metabase bug (GHY-4946)"
+ (doseq [[expected e] [[:error (SQLException. "syntax error at or near \"FROM\"" "42601")]
+ [:debug (ex-info "Unable to connect to the database" {} (CannotAcquireResourceException. "x"))]
+ [:debug (sql-exception "password authentication failed for user \"mb\"" "28P01")]
+ [:debug (sql-exception "permission denied for table orders" "42501")]
+ [:debug (sql-exception "SELECT command denied to user 'mb'@'localhost' for table 'orders'" "42000" 1142)]
+ [:error (sql-exception "You have an error in your SQL syntax" "42000" 1064)]
+ [:debug (ex-info "Error executing query" {} (sql-exception "ERROR: user mapping not found for \"mb\"" "42704"))]
+ [:debug (RuntimeException. "You are not authorized to perform: athena:ListDatabases on the resource.")]
+ [:debug (sql-exception "User: arn:aws:iam::1:user/mb is not authorized to perform: glue:GetTables" "HY000")]]]
+ (testing (ex-message e)
+ (is (= [expected]
+ ;; `log-if-error` is a macro, so it logs under the namespace it's expanded in
+ (mt/with-log-messages-for-level [messages [metabase.sync.fetch-metadata-test :debug]]
+ (is (thrown? Throwable (fetch-metadata/log-if-error "test" (throw e))))
+ (mapv :level (messages)))))))))
diff --git a/test/metabase/sync/sync_metadata/fields_test.clj b/test/metabase/sync/sync_metadata/fields_test.clj
index 56c7d498701..de172fb7152 100644
--- a/test/metabase/sync/sync_metadata/fields_test.clj
+++ b/test/metabase/sync/sync_metadata/fields_test.clj
@@ -9,6 +9,7 @@
[metabase.driver.sql-jdbc.connection :as sql-jdbc.conn]
[metabase.query-processor.test :as qp]
[metabase.sync.core :as sync]
+ [metabase.sync.fetch-metadata :as fetch-metadata]
[metabase.sync.sync-metadata :as sync-metadata]
[metabase.sync.sync-metadata.fields :as sync-fields]
[metabase.sync.sync-metadata.fks :as sync-fks]
@@ -692,3 +693,37 @@
(is (= :PHI (mirror)))))
(finally
(t2/delete! :model/Database (mt/id)))))))
+
+(deftest per-table-field-sync-failure-levels-test
+ (testing "a failure syncing one table's fields is logged by kind (GHY-4945, GHY-4946)"
+ (let [run (fn [e]
+ (let [attempted (atom 0)]
+ (mt/with-dynamic-fn-redefs [fetch-metadata/include-nested-fields-for-table
+ (fn [& _] (swap! attempted inc) (throw e))]
+ (mt/with-log-messages-for-level [messages [metabase.sync.sync-metadata.fields :warn]]
+ (let [threw? (try (sync-fields/sync-fields! (mt/db)) false
+ (catch Throwable _ true))]
+ {:attempted @attempted
+ :threw? threw?
+ :levels (into #{} (map :level) (messages))})))))]
+ (testing "a missing grant is the customer's to fix: WARN, and the other tables are still synced"
+ (is (=? {:attempted #(> % 1), :threw? false, :levels #{:warn}}
+ (run (java.sql.SQLException. "SELECT command denied to user 'mb'@'localhost' for table 'orders'"
+ "42000" (int 1142))))))
+ (testing "an unreachable warehouse aborts the step after the first table"
+ (is (=? {:attempted 1, :threw? true}
+ (run (ex-info "Unable to connect to the database" {}
+ (com.mchange.v2.resourcepool.CannotAcquireResourceException. "x"))))))
+ (testing "anything else might be a Metabase bug: ERROR"
+ (is (=? {:attempted #(> % 1), :threw? false, :levels #{:error}}
+ (run (ex-info "boom" {}))))))))
+
+(deftest per-table-field-sync-failure-names-table-once-test
+ (testing "the per-table field sync failure names the table once"
+ (mt/with-dynamic-fn-redefs [fetch-metadata/include-nested-fields-for-table
+ (fn [& _] (throw (ex-info "boom" {})))]
+ (mt/with-log-messages-for-level [messages [metabase.sync.sync-metadata.fields :warn]]
+ (sync-fields/sync-fields! (mt/db))
+ (let [msgs (map :message (messages))]
+ (is (seq msgs))
+ (is (not-any? #(re-find #"Table Table" %) msgs)))))))
diff --git a/test/metabase/sync/sync_metadata/metabase_metadata_test.clj b/test/metabase/sync/sync_metadata/metabase_metadata_test.clj
index 93e39d6ba31..7770fdead56 100644
--- a/test/metabase/sync/sync_metadata/metabase_metadata_test.clj
+++ b/test/metabase/sync/sync_metadata/metabase_metadata_test.clj
@@ -74,3 +74,13 @@
(t2/select-one :model/Table :id (u/the-id table))))
(is (=? {:table_id (u/the-id table), :visibility_type :normal}
(t2/select-one :model/Field :id (u/the-id field)))))))))
+
+(deftest unmatched-keypaths-log-one-warning-test
+ (testing "rows for tables that don't exist log one WARN per sync, not an ERROR per row (GHY-4946)"
+ (mt/with-temp [:model/Database db {:engine ::moviedb/moviedb}]
+ ;; no `movies` table, so the two `movies.*` keypaths don't match anything
+ (is (=? [{:level :warn
+ :message #"Ignoring 2 _metabase_metadata row\(s\).*: movies.filming.description, movies.description"}]
+ (mt/with-log-messages-for-level [messages [metabase.sync.sync-metadata.metabase-metadata :warn]]
+ (metabase-metadata/sync-metabase-metadata! db)
+ (messages)))))))
diff --git a/test/metabase/sync/sync_metadata_test.clj b/test/metabase/sync/sync_metadata_test.clj
index ffce5c14137..aa6984ac363 100644
--- a/test/metabase/sync/sync_metadata_test.clj
+++ b/test/metabase/sync/sync_metadata_test.clj
@@ -77,3 +77,15 @@
(#'sync-metadata/sync-db-metadata!* (t2/select-one :model/Database :id (mt/id)))
(is (= {:initial_sync_status "complete", :initial_sync_error nil}
(t2/select-one [:model/Database :initial_sync_status :initial_sync_error] :id (mt/id)))))))
+
+(deftest transient-db-metadata-failure-is-logged-test
+ (testing "an unreachable warehouse logs a WARN even when the caller drops the exception (e.g. POST /api/notify/db)"
+ (mt/with-dynamic-fn-redefs [fetch-metadata/db-metadata
+ (fn [_database]
+ (throw (java.sql.SQLException.
+ "Connections could not be acquired from the underlying database!"
+ (com.mchange.v2.resourcepool.CannotAcquireResourceException. "x"))))]
+ (mt/with-log-messages-for-level [messages [metabase.sync.sync-metadata :warn]]
+ (is (thrown? Throwable (sync-metadata/sync-db-metadata! (mt/db))))
+ (is (=? [{:level :warn, :message #"Could not fetch metadata for .*Connections could not be acquired.*"}]
+ (messages)))))))
diff --git a/test/metabase/transforms_rest/api/transform_dag_run_test.clj b/test/metabase/transforms_rest/api/transform_dag_run_test.clj
index 9bbbb50e683..864c78f9e95 100644
--- a/test/metabase/transforms_rest/api/transform_dag_run_test.clj
+++ b/test/metabase/transforms_rest/api/transform_dag_run_test.clj
@@ -5,9 +5,11 @@
[clojure.test :refer :all]
[metabase.permissions.models.permissions-group :as perms-group]
[metabase.test :as mt]
+ [metabase.transforms.jobs :as jobs]
[metabase.transforms.test-util :refer [parse-instant
utc-timestamp
with-transforms-api-users!]]
+ [metabase.util :as u]
[toucan2.core :as t2]))
(set! *warn-on-reflection* true)
@@ -245,3 +247,23 @@
(mt/with-temp [:model/Transform {tid :id} {:name "Seed"}]
(mt/user-http-request :rasta :post 403 (str "transform/" tid "/run-dag")
{:direction "upstream"}))))))
+
+(deftest run-dag-coordinator-failure-logs-error-test
+ (testing "POST /api/transform/:id/run-dag logs an ERROR when the DAG run coordinator fails"
+ (mt/with-temporary-raw-setting-values [transforms-enabled "true"]
+ (mt/with-premium-features #{:transforms-basic}
+ (mt/with-temp [:model/Transform {tid :id} {:name "Seed" :table_dependencies []}]
+ (mt/with-log-messages-for-level [messages :warn]
+ (mt/with-dynamic-fn-redefs [jobs/run-transforms! (fn [& _] (throw (ex-info "coordinator crashed" {})))]
+ (let [{run-id :dag_run_id} (mt/user-http-request :crowberto :post 202 (str "transform/" tid "/run-dag")
+ {:direction "upstream"})
+ timer (u/start-timer)]
+ ;; the run continues on a virtual thread after the 202; its last act is the fallback WARN
+ (while (and (not-any? #(re-find #"Async run failed" (:message %)) (messages))
+ (< (u/since-ms timer) 10000))
+ (Thread/sleep 50))
+ (is (= :failed (t2/select-one-fn :status :model/TransformDagRun :id run-id)))
+ (is (some #(and (= :error (:level %))
+ (re-find #"coordinator crashed" (str (:message %) (some-> (:e %) ex-message))))
+ (messages))
+ (pr-str (map (juxt :level :namespace :message) (messages))))))))))))
diff --git a/test/metabase/warehouses/models/database_test.clj b/test/metabase/warehouses/models/database_test.clj
index ae48ecc864c..5eb7c569be3 100644
--- a/test/metabase/warehouses/models/database_test.clj
+++ b/test/metabase/warehouses/models/database_test.clj
@@ -288,6 +288,18 @@
"id" 3}
(encode-decode pg-db)))))))
+(deftest unknown-database-setting-test
+ (testing "a removed setting left in a database's settings is hidden, and isn't logged as an error (GHY-4961)"
+ (let [db (mi/instance :model/Database {:id 3
+ :settings {:database-enable-actions true
+ :removed-setting true}})]
+ (request/with-current-user (mt/user->id :rasta)
+ (mt/with-log-messages-for-level [messages [metabase.warehouses.models.database :debug]]
+ (is (= {"database-enable-actions" true}
+ (get (json/decode (json/encode db)) "settings")))
+ (is (=? [{:level :debug, :message #"Hiding unknown setting :removed-setting.*"}]
+ (filter #(re-find #"removed-setting" (:message %)) (messages)))))))))
+
(deftest driver-supports-actions-and-database-enable-actions-test
(mt/test-drivers #{:sqlite}
(testing "Updating database-enable-actions to true should fail if the engine doesn't support actions"
diff --git a/test/metabase/warehouses_rest/api_test.clj b/test/metabase/warehouses_rest/api_test.clj
index e57a659bd8d..592dfab764b 100644
--- a/test/metabase/warehouses_rest/api_test.clj
+++ b/test/metabase/warehouses_rest/api_test.clj
@@ -2983,18 +2983,13 @@
:unaggregated-query-row-limit (symbol "nil #_\"key is not present.\"")}
(settings)))))))))
-(deftest log-an-error-if-contains-undefined-setting-test
- (testing "should log an error message if database contains undefined settings"
+(deftest hide-undefined-setting-test
+ (testing "undefined settings are hidden from the response without logging an error"
(mt/with-temp [:model/Database {db-id :id} {:settings {:undefined-setting true}}]
(mt/with-log-messages-for-level [messages :error]
- (testing "does not includes undefined keys by default"
- (is (not (contains? (:settings (mt/user-http-request :crowberto :get 200 (str "database/" db-id)))
- :undefined-setting))))
- (is (= (str "Error checking the readability of :undefined-setting setting. The setting will be hidden in API response."
- " Error: Unknown setting: :undefined-setting")
- (-> (messages)
- first
- :message)))))))
+ (is (not (contains? (:settings (mt/user-http-request :crowberto :get 200 (str "database/" db-id)))
+ :undefined-setting)))
+ (is (not-any? #(str/includes? (:message %) "undefined-setting") (messages)))))))
(deftest autocomplete-suggestions-do-not-include-dashboard-cards
(testing "GET /api/database/:id/card_autocomplete_suggestions"