The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Additional changes for Embedding names (#66899)
Timofey Kachalov9e62f8c2b7d3
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/show-metabase-cli-title.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/show-metabase-cli-title.tsindex 29ff3b15d08..bab4674fc93 100644--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/show-metabase-cli-title.ts+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/show-metabase-cli-title.ts@@ -5,7 +5,7 @@ import type { CliStepMethod } from "../types/cli";import { printEmptyLines, printTitle, printWithPadding } from "../utils/print";export const showMetabaseCliTitle: CliStepMethod = (state) => {- printTitle(`Welcome to the Metabase Embedding SDK CLI`);+ printTitle(`Welcome to the Metabase modular embedding SDK CLI`);printTitle(`View docs at ${SDK_DOCS_LINK}`);printEmptyLines();diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsxindex b24913fd3a7..8eaaeabd1f5 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.tsx@@ -108,7 +108,7 @@ export const MetabaseProvider = memo(function MetabaseProvider({instanceId={ensureSingleInstanceId}multipleRegisteredInstancesWarningMessage={// eslint-disable-next-line no-literal-metabase-strings -- Warning message- "Multiple instances of MetabaseProvider detected. Metabase Embedding SDK may work unexpectedly. Ensure only one instance of MetabaseProvider is rendered at a time."+ "Multiple instances of MetabaseProvider detected. Metabase modular embedding SDK may work unexpectedly. Ensure only one instance of MetabaseProvider is rendered at a time."}><MetabaseProviderInner {...props} />diff --git a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettingsCard.tsx b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettingsCard.tsxindex 4d5a15442f3..770aee147ab 100644--- a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettingsCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettingsCard.tsx@@ -1,49 +1,20 @@-import cx from "classnames";-import { c, t } from "ttag";+import { t } from "ttag";import { EmbeddingSettingsCard } from "metabase/admin/settings/components/EmbeddingSettings";-import ExternalLink from "metabase/common/components/ExternalLink";-import { useDocsUrl, useSetting } from "metabase/common/hooks";-import CS from "metabase/css/core/index.css";+import { useSetting } from "metabase/common/hooks";import { Stack } from "metabase/ui/components";import { InteractiveEmbeddingAuthorizedOriginsWidget } from "metabase-enterprise/embedding/components/InteractiveEmbeddingAuthorizedOriginsWidget";-const utmTags = {- utm_source: "product",- utm_medium: "docs",- utm_campaign: "embedding-interactive",- utm_content: "embedding-interactive-admin",-};-export function InteractiveEmbeddingSettingsCard() {const isInteractiveEmbeddingEnabled = useSetting("enable-embedding-interactive",);- const { url: quickStartUrl } = useDocsUrl(- "embedding/interactive-embedding-quick-start-guide",- {- utm: utmTags,- },- );-return (<EmbeddingSettingsCardtitle={t`Enable full app embedding`}- description={t`A way to embed the entire Metabase app in an iframe. It integrates your permissions and SSO to give people the right level ofaccess to query and drill-down into your data.`}+ description={t`Embed the full Metabase application or individual pages into your app. Best for complex, BI-focused scenarios where you want to embed all of Metabase's capabilities into your app. If you are looking for stability of UX, flexibility or control, or don't have a complex use case that requires a full-blown BI solution, we recommend using Modular embedding instead.`}settingKey="enable-embedding-interactive"- alertInfoText={c(- "{0} is the link to switch binaries. {1} is the link to upsell the SDK. {2} is the link to implement JWT or SAML authentication.",- )- .jt`The new embedding methods give you more flexibility. Full app embedding and Static embedding will be deprecated in a future version of Metabase. ${(- <ExternalLink- key="migration-guide-from-legacy-embedding"- href={quickStartUrl}- className={cx(CS.link, CS.textBold)}- >- {t`Read more`}- </ExternalLink>- )}.`}>{isInteractiveEmbeddingEnabled && (<Stack gap="xl" px="xl" pb="lg">diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.stories.tsxindex f189fdf3d3e..5584b8228ca 100644--- a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.stories.tsx+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.stories.tsx@@ -23,7 +23,7 @@ const Template: StoryFn<SdkUsageProblemBannerProps> = (args) => {};const MESSAGE =- "The embedding SDK is using API keys. This is intended for evaluation purposes and works only on localhost. To use on other sites, implement SSO.";+ "The modular embedding SDK is using API keys. This is intended for evaluation purposes and works only on localhost. To use on other sites, implement SSO.";export const Warning = {render: Template,diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.tsindex 3562d480143..e5a0bd8eb48 100644--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.ts@@ -47,7 +47,7 @@ export const useLogVersionInfo = () => {// eslint-disable-next-line no-consoleconsole.log(// eslint-disable-next-line no-literal-metabase-strings -- Not a user facing string- `Using Metabase Embedding SDK package version ${sdkPackageVersion}, Metabase Embedding SDK bundle version ${sdkBundleVersion}`,+ `Using Metabase modular embedding SDK package version ${sdkPackageVersion}, Metabase Embedding SDK bundle version ${sdkBundleVersion}`,);}}, [allowConsoleLog, sdkPackageVersion, sdkBundleVersion]);diff --git a/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts b/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.tsindex 5e7d9080496..a84faeca9a6 100644--- a/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts+++ b/frontend/src/embedding-sdk-bundle/lib/print-usage-problem.ts@@ -21,7 +21,7 @@ export function printUsageProblemToConsole(problem: SdkUsageProblem | null) {const message =// eslint-disable-next-line no-literal-metabase-strings -- console messages should not be white-labelled- `%cMetabase Embedding SDK for React\n\n` ++ `%cMetabase modular embedding SDK for React\n\n` +`%c${problem.message}\n` +`See the documentation for more information:\n\n` +`%c${problem.documentationUrl}\n\n`;diff --git a/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts b/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.tsindex d5c3881868e..70c4b0ffcd6 100644--- a/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts+++ b/frontend/src/embedding-sdk-bundle/store/use-sdk-selector.ts@@ -6,7 +6,7 @@ import type { SdkStoreState } from "embedding-sdk-bundle/store/types";import { MetabaseReduxContext } from "metabase/lib/redux";// eslint-disable-next-line no-literal-metabase-strings -- this string only shows in the console.-export const USE_OUTSIDE_OF_CONTEXT_MESSAGE = `Hooks from the Metabase Embedding SDK must be used within a component wrapped by the MetabaseProvider`;+export const USE_OUTSIDE_OF_CONTEXT_MESSAGE = `Hooks from the Metabase modular embedding SDK must be used within a component wrapped by the MetabaseProvider`;const _useSdkSelector: TypedUseSelectorHook<SdkStoreState> =createSelectorHook(MetabaseReduxContext);diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsxindex 9b4f1dc9ea9..00ab02635e8 100644--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx@@ -72,7 +72,7 @@ export const EmbeddingSdkSettings = () => {return (<EmbeddingSettingsCard- title={t`Enable SDK for React`}+ title={t`Enable modular embedding SDK`}description={t`Embed the full power of Metabase into your application to build a custom analytics experience and programmatically manage dashboards and data.`}settingKey="enable-embedding-sdk"links={[diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/common.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/common.unit.spec.tsxindex 435a36d1c86..feabcb973a1 100644--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/common.unit.spec.tsx+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/common.unit.spec.tsx@@ -10,7 +10,7 @@ describe("EmbeddingSdkSettings (OSS)", () => {showSdkEmbedTerms: false,});expect(- screen.queryByText(/Enable SDK for React/i),+ screen.queryByText(/Enable modular embedding SDK/i),).not.toBeInTheDocument();});});diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/simple-embedding.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/simple-embedding.unit.spec.tsxindex f9fb04ad87c..32f7d5fc9ae 100644--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/simple-embedding.unit.spec.tsx+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSettings/tests/simple-embedding.unit.spec.tsx@@ -27,7 +27,9 @@ describe("EmbeddingSdkSettings (EE with Simple Embedding feature)", () => {expect(toggles).toHaveLength(2);expect(- screen.getByRole("switch", { name: "Enable SDK for React toggle" }),+ screen.getByRole("switch", {+ name: "Enable modular embedding SDK toggle",+ }),).toBeInTheDocument();expect(diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsxindex f3d57cbfe1d..3e855bf11f6 100644--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/SharedCombinedEmbeddingSettings/SharedCombinedEmbeddingSettings.tsx@@ -48,7 +48,7 @@ export function SharedCombinedEmbeddingSettings({<><EmbeddingSettingsCardtitle={t`Enable guest embeds`}- description={t`A secure way to embed charts and dashboards, without single sign-on. Useful when you don’t want to offer ad-hoc querying or chart drill-through.`}+ description={t`A secure way to embed charts and dashboards, without single sign-on, when you don’t want to offer ad-hoc querying or chart drill-through. Enables modular embedding and static embedding.`}settingKey="enable-embedding-static"actionButton={<NewEmbedButton />}dependentSettingKeys={dependentSettingKeys}diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsxindex 5659a661770..d903e74596b 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Common/EmbeddingUpsell.tsx@@ -32,7 +32,7 @@ export const EmbeddingUpsell = ({ campaign }: Props) => {fullWidthmaxWidth="initial">- {t`Upgrade to get access to embeds with single sign-on, drill through, advanced theming, the Modular Embedding SDK, and more.`}+ {t`Upgrade to get access to embeds with single sign-on, drill through, advanced theming, the modular embedding SDK, and more.`}</UpsellCard>);};diff --git a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsxindex 94670854ee5..3405ce5085f 100644--- a/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx+++ b/frontend/src/metabase/home/components/EmbedHomepage/EmbedJsContent.tsx@@ -48,7 +48,7 @@ export const EmbedJsContent = ({>{t`Modular embedding`}</Text><Text mb="md">{/* eslint-disable-next-line no-literal-metabase-strings -- This string only shows for admins. */}- {t`A JavaScript library built on top of Metabase’s React SDK that lets you embed individual components (charts, dashboards, query builder) using plain JS — no React setup required. You get per-component controls like drill-through, parameters, downloads, theming.`}+ {t`A JavaScript library built on top of Metabase’s modular embedding SDK that lets you embed individual components (charts, dashboards, query builder) using plain JS — no React setup required. You get per-component controls like drill-through, parameters, downloads, theming.`}</Text>{showImage && (<EmbedJsImage