Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix timeseries value detection (#66161)

Denis Berezin9e65cc60bfdc
diff --git a/frontend/src/metabase/visualizations/lib/date-validation.ts b/frontend/src/metabase/visualizations/lib/date-validation.ts
index a1af83b2904..c1ba73d33e4 100644
--- a/frontend/src/metabase/visualizations/lib/date-validation.ts
+++ b/frontend/src/metabase/visualizations/lib/date-validation.ts
@@ -34,7 +34,7 @@ const minutePattern = /(?<minute>[0-5]\d)/;
* Seconds are always 2 digits.
* 60 is used to represent leap seconds.
*/
-const secondsPattern = /(?<seconds>([0-5]\d)|60)/;
+const secondsPattern = /(?<seconds>([0-5]\d)|60)?/;
/**
* Milliseconds have no defined precision.
* Allowing for up to 9 since this gets to nanoseconds.
@@ -127,7 +127,8 @@ const spaceSeparatedDateTimePattern =
hourPattern.source +
/:/.source +
minutePattern.source +
- /:/.source +
+ // seconds and milliseconds are optional
+ /:?/.source +
secondsPattern.source +
millisecondsPattern.source +
/$/.source;
diff --git a/frontend/src/metabase/visualizations/lib/date-validation.unit.spec.ts b/frontend/src/metabase/visualizations/lib/date-validation.unit.spec.ts
index 3d586237e49..511d7833a91 100644
--- a/frontend/src/metabase/visualizations/lib/date-validation.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/date-validation.unit.spec.ts
@@ -11,6 +11,7 @@ describe("isValidIso8601", () => {
"2016-W06-5",
"2016-043",
"2024-06-28 00:00:00",
+ "2025-11-21 05:00",
];
VALID_ISO_8601_DATES.forEach((isoDate) => {