Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

bugfix for dependency diagnostics error (#68968)

John Swanson9e980b93154a
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
index f5a25c2309d..aa184684f22 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
@@ -359,7 +359,7 @@
{:user-id api/*current-user-id*
:is-superuser? api/*is-superuser?*
:is-data-analyst? api/*is-data-analyst?*}
- {:perms/create-queries [:query-builder :query-builder-and-native]})]}]])
+ {:perms/create-queries :query-builder})]}]])
;; Collection-based entities with archived field
(:model/Card :model/Dashboard :model/Document :model/NativeQuerySnippet)
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
index bb489d6897c..a9b5a2cfb65 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
@@ -14,6 +14,7 @@
[metabase.lib.metadata :as lib.metadata]
[metabase.native-query-snippets.models.native-query-snippet.permissions :as snippet.perms]
[metabase.permissions.core :as perms]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.queries.models.card :as card]
[metabase.test :as mt]
[metabase.util :as u]
@@ -2852,3 +2853,27 @@
:owner {:id (mt/user->id :crowberto)
:email "[email protected]"}}}]}
response)))))))))
+
+(deftest data-analyst-can-access-dependency-graph-test
+ (mt/with-premium-features #{:data-studio :dependencies}
+ (testing "Data analysts can access dependency diagnostics endpoints"
+ (let [data-analyst-group-id (:id (perms-group/data-analyst))]
+ (mt/with-temp [:model/User {analyst-id :id} {:first_name "Data"
+ :last_name "Analyst"
+ :is_data_analyst true}
+ :model/PermissionsGroupMembership _ {:user_id analyst-id
+ :group_id data-analyst-group-id}
+ :model/Database {db-id :id} {}
+ :model/Table {_table-id :id} {:db_id db-id}
+ :model/Transform {transform-id :id} {:source_database_id db-id
+ :name "Test Transform"}]
+ (testing "graph/unreferenced"
+ (is (map? (mt/user-http-request analyst-id :get 200
+ "ee/dependencies/graph/unreferenced"))))
+ (testing "graph/breaking"
+ (is (map? (mt/user-http-request analyst-id :get 200
+ "ee/dependencies/graph/breaking"))))
+ (testing "graph with transform"
+ (is (map? (mt/user-http-request analyst-id :get 200
+ (str "ee/dependencies/graph?type=transform&id=" transform-id))))))))))