Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flake in should preserve correct order of columns after column removal via sidebar (metabase#13455) (#76083)

Nick Fitzpatrick9eb4bd140759
diff --git a/e2e/test/scenarios/question/settings.cy.spec.js b/e2e/test/scenarios/question/settings.cy.spec.js
index 6c1b60b409b..63a1c91fce4 100644
--- a/e2e/test/scenarios/question/settings.cy.spec.js
+++ b/e2e/test/scenarios/question/settings.cy.spec.js
@@ -174,6 +174,12 @@ describe("scenarios > question > settings", () => {
findColumnAtIndex("Products → Category", 5);
+ // Let the refreshed results finish rendering (Total visible) before hiding,
+ // so the hide toggle doesn't race the in-flight results render.
+ cy.findByTestId("query-builder-main")
+ .findByText("117.03")
+ .should("exist");
+
// Remove "Total"
hideColumn("Total");
@@ -603,8 +609,10 @@ function getVisibleSidebarColumns() {
}
function hideColumn(name) {
+ // Click the hide button without force so Cypress waits for actionability and
+ // re-queries on re-render — a force click can land on a stale node and be lost.
H.sidebar()
.findByTestId(`draggable-item-${name}`)
- .icon("eye_outline")
- .click({ force: true });
+ .findByTestId(`${name}-hide-button`)
+ .click();
}