Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[Typescript] Convert files that need no changes (#68321)

Sloan Sparger9eebf22cbce6
diff --git a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/services.js b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/services.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/advanced_permissions/services.js
rename to enterprise/frontend/src/metabase-enterprise/advanced_permissions/services.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/application_permissions/api.js b/enterprise/frontend/src/metabase-enterprise/application_permissions/api.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/application_permissions/api.js
rename to enterprise/frontend/src/metabase-enterprise/application_permissions/api.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/group_managers/actions.js b/enterprise/frontend/src/metabase-enterprise/group_managers/actions.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/group_managers/actions.js
rename to enterprise/frontend/src/metabase-enterprise/group_managers/actions.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/overrides.js b/enterprise/frontend/src/metabase-enterprise/overrides.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/overrides.js
rename to enterprise/frontend/src/metabase-enterprise/overrides.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/plugins.js b/enterprise/frontend/src/metabase-enterprise/plugins.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/plugins.js
rename to enterprise/frontend/src/metabase-enterprise/plugins.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-plugins.js b/enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-plugins.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-plugins.js
rename to enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-plugins.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-script-plugins.js b/enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-script-plugins.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-script-plugins.js
rename to enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-script-plugins.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/static-viz-overrides.js b/enterprise/frontend/src/metabase-enterprise/static-viz-overrides.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/static-viz-overrides.js
rename to enterprise/frontend/src/metabase-enterprise/static-viz-overrides.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/overrides.js b/enterprise/frontend/src/metabase-enterprise/whitelabel/overrides.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/whitelabel/overrides.js
rename to enterprise/frontend/src/metabase-enterprise/whitelabel/overrides.ts
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/static-viz-overrides.js b/enterprise/frontend/src/metabase-enterprise/whitelabel/static-viz-overrides.ts
similarity index 100%
rename from enterprise/frontend/src/metabase-enterprise/whitelabel/static-viz-overrides.js
rename to enterprise/frontend/src/metabase-enterprise/whitelabel/static-viz-overrides.ts
diff --git a/frontend/src/metabase-lib/v1/metadata/utils/saved-questions.unit.spec.js b/frontend/src/metabase-lib/v1/metadata/utils/saved-questions.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase-lib/v1/metadata/utils/saved-questions.unit.spec.js
rename to frontend/src/metabase-lib/v1/metadata/utils/saved-questions.unit.spec.ts
diff --git a/frontend/src/metabase-lib/v1/operators/utils/index.unit.spec.js b/frontend/src/metabase-lib/v1/operators/utils/index.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase-lib/v1/operators/utils/index.unit.spec.js
rename to frontend/src/metabase-lib/v1/operators/utils/index.unit.spec.ts
diff --git a/frontend/src/metabase-lib/v1/queries/utils/normalize.js b/frontend/src/metabase-lib/v1/queries/utils/normalize.ts
similarity index 100%
rename from frontend/src/metabase-lib/v1/queries/utils/normalize.js
rename to frontend/src/metabase-lib/v1/queries/utils/normalize.ts
diff --git a/frontend/src/metabase-lib/v1/types/utils/isa.unit.spec.js b/frontend/src/metabase-lib/v1/types/utils/isa.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase-lib/v1/types/utils/isa.unit.spec.js
rename to frontend/src/metabase-lib/v1/types/utils/isa.unit.spec.ts
diff --git a/frontend/src/metabase/account/login-history/containers/LoginHistoryApp/LoginHistoryApp.jsx b/frontend/src/metabase/account/login-history/containers/LoginHistoryApp/LoginHistoryApp.tsx
similarity index 100%
rename from frontend/src/metabase/account/login-history/containers/LoginHistoryApp/LoginHistoryApp.jsx
rename to frontend/src/metabase/account/login-history/containers/LoginHistoryApp/LoginHistoryApp.tsx
diff --git a/frontend/src/metabase/admin/admin.js b/frontend/src/metabase/admin/admin.ts
similarity index 100%
rename from frontend/src/metabase/admin/admin.js
rename to frontend/src/metabase/admin/admin.ts
diff --git a/frontend/src/metabase/admin/people/events.js b/frontend/src/metabase/admin/people/events.ts
similarity index 100%
rename from frontend/src/metabase/admin/people/events.js
rename to frontend/src/metabase/admin/people/events.ts
diff --git a/frontend/src/metabase/admin/permissions/constants/collections-permissions.js b/frontend/src/metabase/admin/permissions/constants/collections-permissions.ts
similarity index 100%
rename from frontend/src/metabase/admin/permissions/constants/collections-permissions.js
rename to frontend/src/metabase/admin/permissions/constants/collections-permissions.ts
diff --git a/frontend/src/metabase/admin/permissions/routes.jsx b/frontend/src/metabase/admin/permissions/routes.tsx
similarity index 100%
rename from frontend/src/metabase/admin/permissions/routes.jsx
rename to frontend/src/metabase/admin/permissions/routes.tsx
diff --git a/frontend/src/metabase/admin/permissions/utils/urls.unit.spec.js b/frontend/src/metabase/admin/permissions/utils/urls.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/admin/permissions/utils/urls.unit.spec.js
rename to frontend/src/metabase/admin/permissions/utils/urls.unit.spec.ts
diff --git a/frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.jsx b/frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.tsx
similarity index 76%
rename from frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.jsx
rename to frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.tsx
index b91ca117cad..227e8a2b8f9 100644
--- a/frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.jsx
+++ b/frontend/src/metabase/common/components/PopoverWithTrigger/PopoverWithTrigger.tsx
@@ -1,4 +1,7 @@
import { Popover } from "metabase/common/components/Popover";
import { Triggerable } from "metabase/common/components/Triggerable";
+/**
+ * @deprecated prefer Popover from "metabase/ui"
+ */
export const PopoverWithTrigger = Triggerable(Popover);
diff --git a/frontend/src/metabase/dev-noop.js b/frontend/src/metabase/dev-noop.ts
similarity index 100%
rename from frontend/src/metabase/dev-noop.js
rename to frontend/src/metabase/dev-noop.ts
diff --git a/frontend/src/metabase/dev.js b/frontend/src/metabase/dev.ts
similarity index 65%
rename from frontend/src/metabase/dev.js
rename to frontend/src/metabase/dev.ts
index aeaa3e8e9c9..c3f7612fe61 100644
--- a/frontend/src/metabase/dev.js
+++ b/frontend/src/metabase/dev.ts
@@ -1,7 +1,5 @@
if (
- // eslint-disable-next-line no-undef
process.env.ENABLE_CLJS_HOT_RELOAD === "true" ||
- // eslint-disable-next-line no-undef
process.env.ENABLE_CLJS_DEV_TOOLS === "true"
) {
import("cljs/metabase.util.devtools");
diff --git a/frontend/src/metabase/lib/constants.js b/frontend/src/metabase/lib/constants.ts
similarity index 100%
rename from frontend/src/metabase/lib/constants.js
rename to frontend/src/metabase/lib/constants.ts
diff --git a/frontend/src/metabase/lib/dayjs-parse-zone-plugin.unit.spec.js b/frontend/src/metabase/lib/dayjs-parse-zone-plugin.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/lib/dayjs-parse-zone-plugin.unit.spec.js
rename to frontend/src/metabase/lib/dayjs-parse-zone-plugin.unit.spec.ts
diff --git a/frontend/src/metabase/lib/formatting.js b/frontend/src/metabase/lib/formatting.ts
similarity index 100%
rename from frontend/src/metabase/lib/formatting.js
rename to frontend/src/metabase/lib/formatting.ts
diff --git a/frontend/src/metabase/lib/keyboard.js b/frontend/src/metabase/lib/keyboard.ts
similarity index 100%
rename from frontend/src/metabase/lib/keyboard.js
rename to frontend/src/metabase/lib/keyboard.ts
diff --git a/frontend/src/metabase/lib/noop.js b/frontend/src/metabase/lib/noop.ts
similarity index 100%
rename from frontend/src/metabase/lib/noop.js
rename to frontend/src/metabase/lib/noop.ts
diff --git a/frontend/src/metabase/lib/schema/schema.unit.spec.js b/frontend/src/metabase/lib/schema/schema.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/lib/schema/schema.unit.spec.js
rename to frontend/src/metabase/lib/schema/schema.unit.spec.ts
diff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.jsx b/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.tsx
similarity index 100%
rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.jsx
rename to frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.tsx
diff --git a/frontend/src/metabase/plugins/builtin.js b/frontend/src/metabase/plugins/builtin.ts
similarity index 100%
rename from frontend/src/metabase/plugins/builtin.js
rename to frontend/src/metabase/plugins/builtin.ts
diff --git a/frontend/src/metabase/plugins/builtin/auth/google.js b/frontend/src/metabase/plugins/builtin/auth/google.ts
similarity index 88%
rename from frontend/src/metabase/plugins/builtin/auth/google.js
rename to frontend/src/metabase/plugins/builtin/auth/google.ts
index 852e098352d..59cb5211426 100644
--- a/frontend/src/metabase/plugins/builtin/auth/google.js
+++ b/frontend/src/metabase/plugins/builtin/auth/google.ts
@@ -8,6 +8,7 @@ PLUGIN_AUTH_PROVIDERS.providers.push((providers) => {
const googleProvider = {
name: "google",
// circular dependencies
+ // eslint-disable-next-line @typescript-eslint/no-require-imports
Button: require("metabase/auth/components/GoogleButton").GoogleButton,
};
diff --git a/frontend/src/metabase/plugins/builtin/auth/jwt.js b/frontend/src/metabase/plugins/builtin/auth/jwt.ts
similarity index 100%
rename from frontend/src/metabase/plugins/builtin/auth/jwt.js
rename to frontend/src/metabase/plugins/builtin/auth/jwt.ts
diff --git a/frontend/src/metabase/plugins/builtin/auth/ldap.js b/frontend/src/metabase/plugins/builtin/auth/ldap.ts
similarity index 100%
rename from frontend/src/metabase/plugins/builtin/auth/ldap.js
rename to frontend/src/metabase/plugins/builtin/auth/ldap.ts
diff --git a/frontend/src/metabase/plugins/builtin/auth/password.js b/frontend/src/metabase/plugins/builtin/auth/password.ts
similarity index 74%
rename from frontend/src/metabase/plugins/builtin/auth/password.js
rename to frontend/src/metabase/plugins/builtin/auth/password.ts
index 7ec8cb514aa..793508bcac4 100644
--- a/frontend/src/metabase/plugins/builtin/auth/password.js
+++ b/frontend/src/metabase/plugins/builtin/auth/password.ts
@@ -4,7 +4,9 @@ PLUGIN_AUTH_PROVIDERS.providers.push((providers) => {
const passwordProvider = {
name: "password",
// circular dependencies
+ // eslint-disable-next-line @typescript-eslint/no-require-imports
Button: require("metabase/auth/components/PasswordButton").PasswordButton,
+ // eslint-disable-next-line @typescript-eslint/no-require-imports
Panel: require("metabase/auth/components/PasswordPanel").PasswordPanel,
};
diff --git a/frontend/src/metabase/plugins/builtin/auth/saml.js b/frontend/src/metabase/plugins/builtin/auth/saml.ts
similarity index 100%
rename from frontend/src/metabase/plugins/builtin/auth/saml.js
rename to frontend/src/metabase/plugins/builtin/auth/saml.ts
diff --git a/frontend/src/metabase/plugins/noop.js b/frontend/src/metabase/plugins/noop.ts
similarity index 100%
rename from frontend/src/metabase/plugins/noop.js
rename to frontend/src/metabase/plugins/noop.ts
diff --git a/frontend/src/metabase/query_builder/components/DataSelector/saved-entity-picker/SavedEntityPicker.unit.spec.jsx b/frontend/src/metabase/query_builder/components/DataSelector/saved-entity-picker/SavedEntityPicker.unit.spec.tsx
similarity index 100%
rename from frontend/src/metabase/query_builder/components/DataSelector/saved-entity-picker/SavedEntityPicker.unit.spec.jsx
rename to frontend/src/metabase/query_builder/components/DataSelector/saved-entity-picker/SavedEntityPicker.unit.spec.tsx
diff --git a/frontend/src/metabase/querying/expressions/tokenizer/lezer.terms.js b/frontend/src/metabase/querying/expressions/tokenizer/lezer.terms.ts
similarity index 100%
rename from frontend/src/metabase/querying/expressions/tokenizer/lezer.terms.js
rename to frontend/src/metabase/querying/expressions/tokenizer/lezer.terms.ts
diff --git a/frontend/src/metabase/reference/databases/NoDatabasesEmptyState.jsx b/frontend/src/metabase/reference/databases/NoDatabasesEmptyState.tsx
similarity index 100%
rename from frontend/src/metabase/reference/databases/NoDatabasesEmptyState.jsx
rename to frontend/src/metabase/reference/databases/NoDatabasesEmptyState.tsx
diff --git a/frontend/src/metabase/static-viz/lib/text.unit.spec.js b/frontend/src/metabase/static-viz/lib/text.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/static-viz/lib/text.unit.spec.js
rename to frontend/src/metabase/static-viz/lib/text.unit.spec.ts
diff --git a/frontend/src/metabase/visualizations/components/PinMap.unit.spec.js b/frontend/src/metabase/visualizations/components/PinMap.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/visualizations/components/PinMap.unit.spec.js
rename to frontend/src/metabase/visualizations/components/PinMap.unit.spec.ts
diff --git a/frontend/src/metabase/visualizations/lib/errors.unit.spec.js b/frontend/src/metabase/visualizations/lib/errors.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/visualizations/lib/errors.unit.spec.js
rename to frontend/src/metabase/visualizations/lib/errors.unit.spec.ts
diff --git a/frontend/src/metabase/visualizations/lib/numeric.unit.spec.js b/frontend/src/metabase/visualizations/lib/numeric.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/visualizations/lib/numeric.unit.spec.js
rename to frontend/src/metabase/visualizations/lib/numeric.unit.spec.ts
diff --git a/frontend/src/metabase/visualizations/lib/utils.unit.spec.js b/frontend/src/metabase/visualizations/lib/utils.unit.spec.ts
similarity index 100%
rename from frontend/src/metabase/visualizations/lib/utils.unit.spec.js
rename to frontend/src/metabase/visualizations/lib/utils.unit.spec.ts
diff --git a/frontend/test/__mocks__/aceSearchBoxExtMock.js b/frontend/test/__mocks__/aceSearchBoxExtMock.ts
similarity index 100%
rename from frontend/test/__mocks__/aceSearchBoxExtMock.js
rename to frontend/test/__mocks__/aceSearchBoxExtMock.ts
diff --git a/frontend/test/__mocks__/svgMock.jsx b/frontend/test/__mocks__/svgMock.tsx
similarity index 100%
rename from frontend/test/__mocks__/svgMock.jsx
rename to frontend/test/__mocks__/svgMock.tsx
diff --git a/frontend/test/metabase/lib/browser.unit.spec.js b/frontend/test/metabase/lib/browser.unit.spec.ts
similarity index 100%
rename from frontend/test/metabase/lib/browser.unit.spec.js
rename to frontend/test/metabase/lib/browser.unit.spec.ts
diff --git a/frontend/test/metabase/lib/schema_metadata.unit.spec.js b/frontend/test/metabase/lib/schema_metadata.unit.spec.ts
similarity index 100%
rename from frontend/test/metabase/lib/schema_metadata.unit.spec.js
rename to frontend/test/metabase/lib/schema_metadata.unit.spec.ts
diff --git a/frontend/test/metabase/lib/string.unit.spec.js b/frontend/test/metabase/lib/string.unit.spec.ts
similarity index 100%
rename from frontend/test/metabase/lib/string.unit.spec.js
rename to frontend/test/metabase/lib/string.unit.spec.ts
diff --git a/jest.config.js b/jest.config.js
index e1038e4e0c4..89cc7fb7574 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -11,7 +11,7 @@ const baseConfig = {
"^cljs/(.*)$": "<rootDir>/target/cljs_dev/$1",
"^d3-(.*)$": "<rootDir>/node_modules/d3-$1/dist/d3-$1",
"\\.svg\\?(component|source)":
- "<rootDir>/frontend/test/__mocks__/svgMock.jsx",
+ "<rootDir>/frontend/test/__mocks__/svgMock.tsx",
"csv-parse/browser/esm/sync":
"<rootDir>/node_modules/csv-parse/dist/cjs/sync",
"csv-stringify/browser/esm/sync":
@@ -21,19 +21,19 @@ const baseConfig = {
* This isn't a problem in the core app because we seem to not import to entry file directly
* for any component under tests.
*/
- "sdk-ee-plugins": "<rootDir>/frontend/src/metabase/plugins/noop.js",
+ "sdk-ee-plugins": "<rootDir>/frontend/src/metabase/plugins/noop.ts",
/**
* SDK iframe embedding imports the embedding sdk and its components.
* We want to exclude the SDK from the main app's bundle to reduce the bundle size.
*/
"sdk-iframe-embedding-ee-plugins":
- "<rootDir>/frontend/src/metabase/lib/noop.js",
- "ee-plugins": "<rootDir>/frontend/src/metabase/lib/noop.js",
+ "<rootDir>/frontend/src/metabase/lib/noop.ts",
+ "ee-plugins": "<rootDir>/frontend/src/metabase/lib/noop.ts",
/**
* Imports which are only applicable to the embedding sdk.
* As we use SDK components in new iframe embedding, we need to import them here.
**/
- "sdk-specific-imports": "<rootDir>/frontend/src/metabase/lib/noop.js",
+ "sdk-specific-imports": "<rootDir>/frontend/src/metabase/lib/noop.ts",
"docs/(.*)$": "<rootDir>/docs/$1",
},
transformIgnorePatterns: [
diff --git a/jest.tz.unit.conf.js b/jest.tz.unit.conf.js
index fb2068fe9de..ead4457f2d1 100644
--- a/jest.tz.unit.conf.js
+++ b/jest.tz.unit.conf.js
@@ -13,7 +13,7 @@ module.exports = {
"^cljs/(.*)$": "<rootDir>/target/cljs_dev/$1",
"^d3-(.*)$": "<rootDir>/node_modules/d3-$1/dist/d3-$1",
"\\.svg\\?(component|source)":
- "<rootDir>/frontend/test/__mocks__/svgMock.jsx",
+ "<rootDir>/frontend/test/__mocks__/svgMock.tsx",
},
transformIgnorePatterns: [
`<rootDir>/node_modules/(?!(${esmPackages.join("|")})/)`,
diff --git a/rspack.main.config.js b/rspack.main.config.js
index 2b31141c52a..1fa0ffdfcdf 100644
--- a/rspack.main.config.js
+++ b/rspack.main.config.js
@@ -224,7 +224,7 @@ const config = {
"metabase-lib": LIB_SRC_PATH,
"metabase-enterprise": ENTERPRISE_SRC_PATH,
"metabase-types": TYPES_SRC_PATH,
- "metabase-dev": `${SRC_PATH}/dev${isDevMode ? "" : "-noop"}.js`,
+ "metabase-dev": `${SRC_PATH}/dev${isDevMode ? "" : "-noop"}.ts`,
cljs: isDevMode ? CLJS_SRC_PATH_DEV : CLJS_SRC_PATH,
__support__: TEST_SUPPORT_PATH,
e2e: E2E_PATH,