Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

style(sdk-bundle): addressing SDK error comments (#78548)

Egor Grushin9f9ee277ccf9
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.stories.tsx
new file mode 100644
index 00000000000..93c72a104a9
--- /dev/null
+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.stories.tsx
@@ -0,0 +1,38 @@
+import type { StoryFn } from "@storybook/react";
+
+import { getHostedBundleStoryDecorator } from "embedding-sdk-package/test/getHostedBundleStoryDecorator";
+import type { MetabaseTheme } from "metabase/embedding-sdk/theme";
+
+import { Error as ErrorComponent } from "./Error";
+
+export default {
+ title: "EmbeddingSDK/Error",
+ component: ErrorComponent,
+ decorators: [getHostedBundleStoryDecorator()],
+};
+
+type Args = {
+ message: string;
+ theme: MetabaseTheme | undefined;
+};
+
+const Template: StoryFn<Args> = (args) => <ErrorComponent {...args} />;
+
+export const Default = {
+ render: Template,
+ args: {
+ message: "Something went wrong.",
+ theme: undefined,
+ },
+};
+
+const LONG_MESSAGE =
+ "Something went wrong while loading this content. Please check your connection and try again, or contact your administrator if the problem persists.";
+
+export const LongMessage = {
+ render: Template,
+ args: {
+ message: LONG_MESSAGE,
+ theme: undefined,
+ },
+};
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx
index 81b80768d25..5c6cc904568 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx
@@ -17,10 +17,11 @@ const DefaultErrorMessage = ({ message, theme }: Props) => {
alignItems: "center",
padding: "1.25rem 1rem",
background:
- theme?.colors?.background ?? colors["background_surface-error"],
- color: theme?.colors?.["text-primary"] ?? colors["text-primary"],
- border: `1px solid ${theme?.colors?.error ?? colors["feedback-negative"]}`,
- borderRadius: "0.5rem",
+ theme?.colors?.background ??
+ colors["background_surface-error-subtle"],
+ color: theme?.colors?.["text-secondary"] ?? colors["text-secondary"],
+ border: `0.5px solid ${theme?.colors?.error ?? colors["feedback-negative-strong"]}`,
+ borderRadius: "12px",
textAlign: "center",
lineHeight: "1.4rem",
}}
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
index 4342ddbdb9c..03fd888373e 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
@@ -1,5 +1,6 @@
import type { StoryFn } from "@storybook/react";
+import { PublicComponentWrapper } from "embedding-sdk-bundle/components/private/PublicComponentWrapper";
import { CommonSdkStoryWrapper } from "embedding-sdk-bundle/test/CommonSdkStoryWrapper";
import type { SdkErrorComponentProps } from "embedding-sdk-bundle/types";
@@ -16,7 +17,9 @@ export default {
};
const Template: StoryFn<SdkErrorComponentProps> = (args) => (
- <SdkError {...args} />
+ <PublicComponentWrapper>
+ <SdkError {...args} />
+ </PublicComponentWrapper>
);
export const Default = {
@@ -76,9 +79,17 @@ export const LongMessage = {
};
export const QuestionNotFound = {
- render: () => <QuestionNotFoundError id={1} />,
+ render: () => (
+ <PublicComponentWrapper>
+ <QuestionNotFoundError id={1} />
+ </PublicComponentWrapper>
+ ),
};
export const DashboardNotFound = {
- render: () => <DashboardNotFoundError id={42} />,
+ render: () => (
+ <PublicComponentWrapper>
+ <DashboardNotFoundError id={42} />
+ </PublicComponentWrapper>
+ ),
};
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
index 80e3ffac55b..36de2435a5a 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
@@ -108,6 +108,19 @@ const DefaultErrorMessage = ({ message, onClose }: SdkErrorComponentProps) => (
icon={<Icon name="warning" />}
withCloseButton={Boolean(onClose)}
onClose={onClose}
+ styles={{
+ root: { background: "var(--alert-bg)" },
+ closeButton: {
+ display: "flex",
+ alignItems: "center",
+ justifyContent: "center",
+ padding: 0,
+ border: 0,
+ background: "transparent",
+ appearance: "none",
+ cursor: "pointer",
+ },
+ }}
>
<Box
style={{